)]}'
{"designatedashboard/dashboards/project/dns_domains/forms.py":[{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"3d3bba92244bd4f3c78a9a11bb5e14b3360644af","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            data \u003d {}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"            if ex is not None:"},{"line_number":56,"context_line":"                data[\u0027message\u0027] \u003d ex"},{"line_number":57,"context_line":"                msg +\u003d \"Error: %(message)s\""},{"line_number":58,"context_line":"            else:"},{"line_number":59,"context_line":"                data[\"type\"] \u003d ex.type"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_cc99287a","line":56,"updated":"2017-06-20 03:22:01.000000000","message":"Why did change to use an object instead of a message [1]?\n[1] https://github.com/openstack/python-designateclient/blob/master/designateclient/exceptions.py#L37","commit_id":"afc341350b73ec92d3e1e1e90ba0676b1bc88694"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"18a584af9c9ae07473d52f11149a3426ca59d923","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            data \u003d {}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"            if ex is not None:"},{"line_number":56,"context_line":"                data[\u0027message\u0027] \u003d ex"},{"line_number":57,"context_line":"                msg +\u003d \"Error: %(message)s\""},{"line_number":58,"context_line":"            else:"},{"line_number":59,"context_line":"                data[\"type\"] \u003d ex.type"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_a7d04555","line":56,"in_reply_to":"7f231b9d_073c99bd","updated":"2017-06-20 04:16:59.000000000","message":"IMO, I dont think data[\u0027message\u0027] can return an object? right? So the [2] reference link is not the same thing with this.","commit_id":"afc341350b73ec92d3e1e1e90ba0676b1bc88694"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"56a5abc16f86217f8a5ddbcc7d22ccdbeca35c71","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            data \u003d {}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"            if ex is not None:"},{"line_number":56,"context_line":"                data[\u0027message\u0027] \u003d ex"},{"line_number":57,"context_line":"                msg +\u003d \"Error: %(message)s\""},{"line_number":58,"context_line":"            else:"},{"line_number":59,"context_line":"                data[\"type\"] \u003d ex.type"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_27f55284","line":56,"in_reply_to":"7f231b9d_a7d04555","updated":"2017-06-20 07:09:31.000000000","message":"Thank you, Dai.\nI\u0027ve got your idea.\nNew change has been uploaded.","commit_id":"afc341350b73ec92d3e1e1e90ba0676b1bc88694"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"4c024ec188521e3fed601603b6641d29956f5abf","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            data \u003d {}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"            if ex is not None:"},{"line_number":56,"context_line":"                data[\u0027message\u0027] \u003d ex"},{"line_number":57,"context_line":"                msg +\u003d \"Error: %(message)s\""},{"line_number":58,"context_line":"            else:"},{"line_number":59,"context_line":"                data[\"type\"] \u003d ex.type"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_073c99bd","line":56,"in_reply_to":"7f231b9d_cc99287a","updated":"2017-06-20 04:11:23.000000000","message":"Hi Dai,\nThanks for your review.\n\nBecause \u0027message\u0027 attribute in Exception has been deprecated.\nThis decision is also based on [1] and [2]\n\n[1] https://github.com/openstack/python-designateclient/blob/master/designateclient/exceptions.py#L18\n[2] https://review.openstack.org/#/c/463230/5/cinder/volume/drivers/ibm/storwize_svc/replication.py\n\nIf you have any other concern, please feel free to let me know.","commit_id":"afc341350b73ec92d3e1e1e90ba0676b1bc88694"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"c79223dd1529f55dd5f35fe0388487e460d14f56","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            msg \u003d \"\""},{"line_number":54,"context_line":"            data \u003d {}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"            if ex is not None:"},{"line_number":57,"context_line":"                data[\u0027message\u0027] \u003d six.text_type(ex)"},{"line_number":58,"context_line":"                msg +\u003d \"Error: %(message)s\""},{"line_number":59,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_a72e02f8","line":56,"updated":"2017-06-20 07:10:03.000000000","message":"If we got an exception, so we also get a not None ex.\nThen we can not change this line to ex.message.\n\nP/s: I agree with you about below line change.","commit_id":"eda0e4bf3589b58bf44a117a1dc0adc6d069f524"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"a837f93079c12059e003f9c0af54d5dd6db2e7c3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            msg \u003d \"\""},{"line_number":54,"context_line":"            data \u003d {}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"            if ex is not None:"},{"line_number":57,"context_line":"                data[\u0027message\u0027] \u003d six.text_type(ex)"},{"line_number":58,"context_line":"                msg +\u003d \"Error: %(message)s\""},{"line_number":59,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_6ae0b1fb","line":56,"in_reply_to":"7f231b9d_a72e02f8","updated":"2017-06-20 07:36:40.000000000","message":"Thank you, required change has been done :)","commit_id":"eda0e4bf3589b58bf44a117a1dc0adc6d069f524"}]}