)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a52b0e4ede7077daaacf8b2b639f58801026febe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"542456e1_6b9cbe3a","updated":"2026-03-12 17:03:35.000000000","message":"LGTM","commit_id":"86e346c1eff43cbf45e4a6a180f9a2c8a77e6b9d"}],"designatedashboard/api/rest/designate.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6c8a877225b9d823a94ba175c7af9391727e98a8","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        name\u003ddata[\u0027name\u0027],"},{"line_number":45,"context_line":"        type\u003ddata[\u0027type\u0027],"},{"line_number":46,"context_line":"    )"},{"line_number":47,"context_line":"    if data.get(\u0027email\u0027, None):"},{"line_number":48,"context_line":"        build_kwargs[\u0027email\u0027] \u003d data[\u0027email\u0027]"},{"line_number":49,"context_line":"    if data.get(\u0027description\u0027, None):"},{"line_number":50,"context_line":"        build_kwargs[\u0027description\u0027] \u003d data[\u0027description\u0027]"},{"line_number":51,"context_line":"    if data.get(\u0027ttl\u0027, None):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ca443a74_b73e09d2","line":48,"range":{"start_line":47,"start_character":4,"end_line":48,"end_character":45},"updated":"2026-03-11 13:09:54.000000000","message":"I think it is better than what we had so far, but incomplete IMO.\n\nPRIMARY requires email and forbids masters, SECONDARY requires masters and forbids email/ttl. How about:\n\n```diff\ndiff --git a/designatedashboard/api/rest/designate.py b/designatedashboard/api/rest/designate.py\nindex 96f1444..5555641 100644\n--- a/designatedashboard/api/rest/designate.py\n+++ b/designatedashboard/api/rest/designate.py\n@@ -42,15 +42,17 @@ def create_zone(request):\n     conn \u003d get_sdk_connection(request)\n     build_kwargs \u003d dict(\n         name\u003ddata[\u0027name\u0027],\n-        email\u003ddata[\u0027email\u0027],\n         type\u003ddata[\u0027type\u0027],\n     )\n+    if data[\u0027type\u0027] \u003d\u003d \u0027PRIMARY\u0027:\n+        build_kwargs[\u0027email\u0027] \u003d data[\u0027email\u0027]\n+        if data.get(\u0027ttl\u0027, None):\n+            build_kwargs[\u0027ttl\u0027] \u003d data[\u0027ttl\u0027]\n+    elif data[\u0027type\u0027] \u003d\u003d \u0027SECONDARY\u0027:\n+        if data.get(\u0027masters\u0027, None):\n+            build_kwargs[\u0027masters\u0027] \u003d data[\u0027masters\u0027]\n     if data.get(\u0027description\u0027, None):\n         build_kwargs[\u0027description\u0027] \u003d data[\u0027description\u0027]\n-    if data.get(\u0027ttl\u0027, None):\n-        build_kwargs[\u0027ttl\u0027] \u003d data[\u0027ttl\u0027]\n-    if data.get(\u0027masters\u0027, None):\n-        build_kwargs[\u0027masters\u0027] \u003d data[\u0027masters\u0027]\n \n     zone \u003d conn.dns.create_zone(**build_kwargs)\n     return zone.to_dict()\n```","commit_id":"4fbaf8d024546b9af8ffca8751ec0fd42fedebd9"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"60af507c481563d29334a3e10e55d5eb832b5a0e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        name\u003ddata[\u0027name\u0027],"},{"line_number":45,"context_line":"        type\u003ddata[\u0027type\u0027],"},{"line_number":46,"context_line":"    )"},{"line_number":47,"context_line":"    if data.get(\u0027email\u0027, None):"},{"line_number":48,"context_line":"        build_kwargs[\u0027email\u0027] \u003d data[\u0027email\u0027]"},{"line_number":49,"context_line":"    if data.get(\u0027description\u0027, None):"},{"line_number":50,"context_line":"        build_kwargs[\u0027description\u0027] \u003d data[\u0027description\u0027]"},{"line_number":51,"context_line":"    if data.get(\u0027ttl\u0027, None):"}],"source_content_type":"text/x-python","patch_set":1,"id":"64e31620_d32480c1","line":48,"range":{"start_line":47,"start_character":4,"end_line":48,"end_character":45},"in_reply_to":"ca443a74_b73e09d2","updated":"2026-03-12 13:33:58.000000000","message":"Done, with the correction that masters is a required parameter for secondary zones","commit_id":"4fbaf8d024546b9af8ffca8751ec0fd42fedebd9"}]}