)]}'
{"designate_tempest_plugin/services/dns/json/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9f30a03ad0725727ff2549c3e59ca762f4fc0ac0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def deserialize(self, object_str):"},{"line_number":54,"context_line":"        return json.loads(object_str)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def expected_success(self, expected_code, read_code):"},{"line_number":57,"context_line":"        # the base class method does not check correctly if read_code is not"},{"line_number":58,"context_line":"        # an int. warn about this and cast to int to avoid silent errors."},{"line_number":59,"context_line":"        if not isinstance(read_code, int):"},{"line_number":60,"context_line":"            message \u003d (\"expected_success(%(expected_code)r, %(read_code)r) \""},{"line_number":61,"context_line":"                       \"received not-int read_code %(read_code)r\" %"},{"line_number":62,"context_line":"                       {\u0027expected_code\u0027: expected_code,"},{"line_number":63,"context_line":"                        \u0027read_code\u0027: read_code})"},{"line_number":64,"context_line":"            LOG.warn(message)"},{"line_number":65,"context_line":"        return super(DnsClientBase, self).expected_success("},{"line_number":66,"context_line":"            expected_code\u003dexpected_code, read_code\u003dint(read_code),"},{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def get_uri(self, resource_name, uuid\u003dNone, params\u003dNone):"},{"line_number":70,"context_line":"        \"\"\"Get URI for a specific resource or object."}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_ef4d819a","line":67,"range":{"start_line":56,"start_character":0,"end_line":67,"end_character":9},"updated":"2016-04-18 10:05:50.000000000","message":"I feel not to go with wrapper on rest_client functions.\n\nJFYI, m putting error for non int code in expected_success that will help here - https://review.openstack.org/#/c/306919/","commit_id":"471df92f967c013caa710847c52c63928d141a26"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"219a5adbe6090ef6276853a6212c31d4593122c2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def deserialize(self, object_str):"},{"line_number":54,"context_line":"        return json.loads(object_str)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def expected_success(self, expected_code, read_code):"},{"line_number":57,"context_line":"        # the base class method does not check correctly if read_code is not"},{"line_number":58,"context_line":"        # an int. warn about this and cast to int to avoid silent errors."},{"line_number":59,"context_line":"        if not isinstance(read_code, int):"},{"line_number":60,"context_line":"            message \u003d (\"expected_success(%(expected_code)r, %(read_code)r) \""},{"line_number":61,"context_line":"                       \"received not-int read_code %(read_code)r\" %"},{"line_number":62,"context_line":"                       {\u0027expected_code\u0027: expected_code,"},{"line_number":63,"context_line":"                        \u0027read_code\u0027: read_code})"},{"line_number":64,"context_line":"            LOG.warn(message)"},{"line_number":65,"context_line":"        return super(DnsClientBase, self).expected_success("},{"line_number":66,"context_line":"            expected_code\u003dexpected_code, read_code\u003dint(read_code),"},{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def get_uri(self, resource_name, uuid\u003dNone, params\u003dNone):"},{"line_number":70,"context_line":"        \"\"\"Get URI for a specific resource or object."}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_caaeb384","line":67,"range":{"start_line":56,"start_character":0,"end_line":67,"end_character":9},"in_reply_to":"1a122d0e_ef4d819a","updated":"2016-04-18 10:16:07.000000000","message":"wrapper way might makes things not much readable or maintainable.  \nI think this address the issue - https://review.openstack.org/#/c/306919/","commit_id":"471df92f967c013caa710847c52c63928d141a26"}]}
