)]}'
{"designate_tempest_plugin/services/dns/json/base.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"193a39b1d9bb328cd82efdf1658e27e8d5af6666","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                            specified type."},{"line_number":80,"context_line":"        :param params: A Python dict that represents the query paramaters to"},{"line_number":81,"context_line":"                       include in the request URI."},{"line_number":82,"context_line":"        :param int expected_status: The response code that is expected."},{"line_number":83,"context_line":"                                  Optionally a list of integers can be used"},{"line_number":84,"context_line":"                                  to specify multiple valid success codes"},{"line_number":85,"context_line":"        :returns: A tuple with the server response and the deserialized created"},{"line_number":86,"context_line":"                 object."},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        body \u003d self.serialize(object_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_afc0a92b","line":85,"range":{"start_line":82,"start_character":1,"end_line":85,"end_character":79},"updated":"2016-04-18 10:02:03.000000000","message":"I think I prefer Paul\u0027s approach to this in https://review.openstack.org/#/c/306616/ - by keeping the [201, 202] here without the ability to change it, we enforce that all Designate APIs return the same set of codes for Create requests, trying to add an API that returns 200 then becomes really obvious..","commit_id":"4c58901dbbefdb267c2257c47e2e2cc533c848c9"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"e4323d151f56159bbfb3ebf0c965e171d16c3ab5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                            specified type."},{"line_number":80,"context_line":"        :param params: A Python dict that represents the query paramaters to"},{"line_number":81,"context_line":"                       include in the request URI."},{"line_number":82,"context_line":"        :param int expected_status: The response code that is expected."},{"line_number":83,"context_line":"                                  Optionally a list of integers can be used"},{"line_number":84,"context_line":"                                  to specify multiple valid success codes"},{"line_number":85,"context_line":"        :returns: A tuple with the server response and the deserialized created"},{"line_number":86,"context_line":"                 object."},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        body \u003d self.serialize(object_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_ca6353db","line":85,"range":{"start_line":82,"start_character":1,"end_line":85,"end_character":79},"in_reply_to":"1a122d0e_afc0a92b","updated":"2016-04-18 10:13:56.000000000","message":"Actually we should explicitly check each possible code. Create zone import will always return 202 so allowing check of 201 also may create issue if code return unwanted 201. Thats why we should check specific status code of each API.\n\nPlease correct me if I am wrong.\n\nhttps://github.com/openstack/designate/blob/master/designate/api/v2/controllers/zones/tasks/imports.py#L94","commit_id":"4c58901dbbefdb267c2257c47e2e2cc533c848c9"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"30faaf19eb374f5151ecee9df9bb56a20939ca99","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                            specified type."},{"line_number":80,"context_line":"        :param params: A Python dict that represents the query paramaters to"},{"line_number":81,"context_line":"                       include in the request URI."},{"line_number":82,"context_line":"        :param int expected_status: The response code that is expected."},{"line_number":83,"context_line":"                                  Optionally a list of integers can be used"},{"line_number":84,"context_line":"                                  to specify multiple valid success codes"},{"line_number":85,"context_line":"        :returns: A tuple with the server response and the deserialized created"},{"line_number":86,"context_line":"                 object."},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        body \u003d self.serialize(object_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_9b1e6fb9","line":85,"range":{"start_line":82,"start_character":1,"end_line":85,"end_character":79},"in_reply_to":"1a122d0e_c69f9e4e","updated":"2016-04-20 00:09:30.000000000","message":"I understand now . This is a nice approach which makes all APIs consistent .Thanks for clarification. I will  keep  those as it is.","commit_id":"4c58901dbbefdb267c2257c47e2e2cc533c848c9"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"7dc7395d0ec991dc6e7db78867c3b68da61fb280","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                            specified type."},{"line_number":80,"context_line":"        :param params: A Python dict that represents the query paramaters to"},{"line_number":81,"context_line":"                       include in the request URI."},{"line_number":82,"context_line":"        :param int expected_status: The response code that is expected."},{"line_number":83,"context_line":"                                  Optionally a list of integers can be used"},{"line_number":84,"context_line":"                                  to specify multiple valid success codes"},{"line_number":85,"context_line":"        :returns: A tuple with the server response and the deserialized created"},{"line_number":86,"context_line":"                 object."},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        body \u003d self.serialize(object_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_c69f9e4e","line":85,"range":{"start_line":82,"start_character":1,"end_line":85,"end_character":79},"in_reply_to":"1a122d0e_ca6353db","updated":"2016-04-19 08:24:28.000000000","message":"We absolutely want to check the specific code an individual API is expected to return, however, we also want to check that that specific code matches the overall conventions for the project, and it isn\u0027t a special snowflake :)\n\nHere, in the base class, we enforce that no API can be a snowflake e.g. enforce that all POST APIs return a 201 or a 202.\n\nThen, In the zones client, enforce that a POST /zones is a 202.\n\nDoing this, both patterns are enforced, without it being easily to accidentally +A a change that adds \"200\" as a valid POST response code..","commit_id":"4c58901dbbefdb267c2257c47e2e2cc533c848c9"}],"designate_tempest_plugin/services/dns/v2/json/zones_client.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"193a39b1d9bb328cd82efdf1658e27e8d5af6666","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        resp, body \u003d self._create_request(\u0027zones\u0027, zone, params\u003dparams,"},{"line_number":50,"context_line":"                                          expected_status\u003d[201, 202])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if wait_until:"},{"line_number":53,"context_line":"            waiters.wait_for_zone_status(self, body[\u0027id\u0027], wait_until)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_6ff4d186","line":50,"range":{"start_line":50,"start_character":42,"end_line":50,"end_character":68},"updated":"2016-04-18 10:02:03.000000000","message":"Designate will always return a 202 for a create zone call, despite some legacy code we have laying around in the create zone API call that makes it look like we may return either.","commit_id":"4c58901dbbefdb267c2257c47e2e2cc533c848c9"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"7dc7395d0ec991dc6e7db78867c3b68da61fb280","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        resp, body \u003d self._create_request(\u0027zones\u0027, zone, params\u003dparams,"},{"line_number":50,"context_line":"                                          expected_status\u003d[201, 202])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if wait_until:"},{"line_number":53,"context_line":"            waiters.wait_for_zone_status(self, body[\u0027id\u0027], wait_until)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_86ebe6af","line":50,"range":{"start_line":50,"start_character":42,"end_line":50,"end_character":68},"in_reply_to":"1a122d0e_4a274364","updated":"2016-04-19 08:24:28.000000000","message":"That code needs to be removed :) It\u0027s the legacy code I was referring to! It\u0027s never actually makes it into the `else` branch","commit_id":"4c58901dbbefdb267c2257c47e2e2cc533c848c9"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"e4323d151f56159bbfb3ebf0c965e171d16c3ab5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        resp, body \u003d self._create_request(\u0027zones\u0027, zone, params\u003dparams,"},{"line_number":50,"context_line":"                                          expected_status\u003d[201, 202])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if wait_until:"},{"line_number":53,"context_line":"            waiters.wait_for_zone_status(self, body[\u0027id\u0027], wait_until)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_4a274364","line":50,"range":{"start_line":50,"start_character":42,"end_line":50,"end_character":68},"in_reply_to":"1a122d0e_6ff4d186","updated":"2016-04-18 10:13:56.000000000","message":"oh is it? I thought it can return any of those-\nhttps://github.com/openstack/designate/blob/master/designate/api/v2/controllers/zones/__init__.py#L115-L118","commit_id":"4c58901dbbefdb267c2257c47e2e2cc533c848c9"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"30faaf19eb374f5151ecee9df9bb56a20939ca99","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        resp, body \u003d self._create_request(\u0027zones\u0027, zone, params\u003dparams,"},{"line_number":50,"context_line":"                                          expected_status\u003d[201, 202])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if wait_until:"},{"line_number":53,"context_line":"            waiters.wait_for_zone_status(self, body[\u0027id\u0027], wait_until)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_fbade39b","line":50,"range":{"start_line":50,"start_character":42,"end_line":50,"end_character":68},"in_reply_to":"1a122d0e_86ebe6af","updated":"2016-04-20 00:09:30.000000000","message":"Oh I see. ok I will fix that and will fix the doc also.","commit_id":"4c58901dbbefdb267c2257c47e2e2cc533c848c9"}]}