)]}'
{"designate_tempest_plugin/common/waiters.py":[{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"b06c3d441f8711e9f97b5639862e47dfed635a84","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            raise lib_exc.TimeoutException(message)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"def wait_for_pool_status(client, pool_id, status):"},{"line_number":188,"context_line":"    \"\"\"Waits for a pool to reach given status.\"\"\""},{"line_number":189,"context_line":"    LOG.info(\u0027Waiting for pool %s to reach %s\u0027, pool_id, status)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_bf520065","line":187,"updated":"2016-04-20 19:53:13.000000000","message":"We don\u0027t need this method. All operations on pools are synchronous, so a pool doesn\u0027t have a status.","commit_id":"4f2c930defe7b70a1ea5bf9fe52c3c22fe3070ba"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"c190fee4ec8d4d6b486476b7ae75e42ac1a99d93","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            raise lib_exc.TimeoutException(message)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"def wait_for_pool_status(client, pool_id, status):"},{"line_number":188,"context_line":"    \"\"\"Waits for a pool to reach given status.\"\"\""},{"line_number":189,"context_line":"    LOG.info(\u0027Waiting for pool %s to reach %s\u0027, pool_id, status)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_c3654b1e","line":187,"in_reply_to":"1a122d0e_bf520065","updated":"2016-04-21 10:35:24.000000000","message":"Done","commit_id":"4f2c930defe7b70a1ea5bf9fe52c3c22fe3070ba"}],"designate_tempest_plugin/data_utils.py":[{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"b06c3d441f8711e9f97b5639862e47dfed635a84","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"def rand_pool_data():"},{"line_number":148,"context_line":"    ns_zone \u003d rand_zone_data()[\u0027name\u0027]"},{"line_number":149,"context_line":"    data \u003d {"},{"line_number":150,"context_line":"        \"name\": rand_zone_name(),"},{"line_number":151,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_3f69d0f9","line":148,"updated":"2016-04-20 19:53:13.000000000","message":"Just call `rand_zone_name()` for this.","commit_id":"4f2c930defe7b70a1ea5bf9fe52c3c22fe3070ba"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"c190fee4ec8d4d6b486476b7ae75e42ac1a99d93","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"def rand_pool_data():"},{"line_number":148,"context_line":"    ns_zone \u003d rand_zone_data()[\u0027name\u0027]"},{"line_number":149,"context_line":"    data \u003d {"},{"line_number":150,"context_line":"        \"name\": rand_zone_name(),"},{"line_number":151,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_036c6306","line":148,"in_reply_to":"1a122d0e_3f69d0f9","updated":"2016-04-21 10:35:24.000000000","message":"Done","commit_id":"4f2c930defe7b70a1ea5bf9fe52c3c22fe3070ba"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"b06c3d441f8711e9f97b5639862e47dfed635a84","unresolved":false,"context_lines":[{"line_number":147,"context_line":"def rand_pool_data():"},{"line_number":148,"context_line":"    ns_zone \u003d rand_zone_data()[\u0027name\u0027]"},{"line_number":149,"context_line":"    data \u003d {"},{"line_number":150,"context_line":"        \"name\": rand_zone_name(),"},{"line_number":151,"context_line":"    }"},{"line_number":152,"context_line":"    records \u003d []"},{"line_number":153,"context_line":"    for i in range(0, 2):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_ff29189c","line":150,"updated":"2016-04-20 19:53:13.000000000","message":"A pool\u0027s name doesn\u0027t need to be a zone name. To be less confusing in request logs, can we just use `data_util.rand_name(name\u003d\u0027pool\u0027)` for the pool name (or similar)?","commit_id":"4f2c930defe7b70a1ea5bf9fe52c3c22fe3070ba"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"c190fee4ec8d4d6b486476b7ae75e42ac1a99d93","unresolved":false,"context_lines":[{"line_number":147,"context_line":"def rand_pool_data():"},{"line_number":148,"context_line":"    ns_zone \u003d rand_zone_data()[\u0027name\u0027]"},{"line_number":149,"context_line":"    data \u003d {"},{"line_number":150,"context_line":"        \"name\": rand_zone_name(),"},{"line_number":151,"context_line":"    }"},{"line_number":152,"context_line":"    records \u003d []"},{"line_number":153,"context_line":"    for i in range(0, 2):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_e36e87fe","line":150,"in_reply_to":"1a122d0e_ff29189c","updated":"2016-04-21 10:35:24.000000000","message":"Done","commit_id":"4f2c930defe7b70a1ea5bf9fe52c3c22fe3070ba"}],"designate_tempest_plugin/services/dns/v2/json/pool_client.py":[{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"b06c3d441f8711e9f97b5639862e47dfed635a84","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \"\"\"API V2 Tempest REST client for Pool API\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @base.handle_errors"},{"line_number":24,"context_line":"    def create_pool(self, pool_model\u003dNone, wait_until\u003dFalse, params\u003dNone):"},{"line_number":25,"context_line":"        \"\"\"Create a pool with the specified parameters."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        :param pool_model: A dictionary represening the data for pool"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_55a46db8","line":24,"updated":"2016-04-20 19:53:13.000000000","message":"We aren\u0027t using models anymore. Following the pattern of the other clients, this should accept one parameter for each field of the pool json.\n\nAlso no wait_until.","commit_id":"4f2c930defe7b70a1ea5bf9fe52c3c22fe3070ba"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"c190fee4ec8d4d6b486476b7ae75e42ac1a99d93","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \"\"\"API V2 Tempest REST client for Pool API\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @base.handle_errors"},{"line_number":24,"context_line":"    def create_pool(self, pool_model\u003dNone, wait_until\u003dFalse, params\u003dNone):"},{"line_number":25,"context_line":"        \"\"\"Create a pool with the specified parameters."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        :param pool_model: A dictionary represening the data for pool"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_23751fca","line":24,"in_reply_to":"1a122d0e_55a46db8","updated":"2016-04-21 10:35:24.000000000","message":"Done","commit_id":"4f2c930defe7b70a1ea5bf9fe52c3c22fe3070ba"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"b06c3d441f8711e9f97b5639862e47dfed635a84","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        # Create Pool should Return a HTTP 201"},{"line_number":41,"context_line":"        self.expected_success(201, resp.status)"},{"line_number":42,"context_line":"        if wait_until:"},{"line_number":43,"context_line":"            waiters.wait_for_pool_status(self, body[\u0027id\u0027], wait_until)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        return resp, body"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_159f955f","line":43,"updated":"2016-04-20 19:53:13.000000000","message":"Remove this waiting - pools are synchronous.","commit_id":"4f2c930defe7b70a1ea5bf9fe52c3c22fe3070ba"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"c190fee4ec8d4d6b486476b7ae75e42ac1a99d93","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        # Create Pool should Return a HTTP 201"},{"line_number":41,"context_line":"        self.expected_success(201, resp.status)"},{"line_number":42,"context_line":"        if wait_until:"},{"line_number":43,"context_line":"            waiters.wait_for_pool_status(self, body[\u0027id\u0027], wait_until)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        return resp, body"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_8380738c","line":43,"in_reply_to":"1a122d0e_159f955f","updated":"2016-04-21 10:35:24.000000000","message":"Done","commit_id":"4f2c930defe7b70a1ea5bf9fe52c3c22fe3070ba"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"b06c3d441f8711e9f97b5639862e47dfed635a84","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @base.handle_errors"},{"line_number":82,"context_line":"    def update_pool(self, uuid, pool_model\u003dNone, wait_until\u003dFalse,"},{"line_number":83,"context_line":"                    params\u003dNone):"},{"line_number":84,"context_line":"        \"\"\"Update a pool with the specified parameters."},{"line_number":85,"context_line":"        :param uuid: The unique identifier of the pool."},{"line_number":86,"context_line":"        :param pool_model: A dictionary represening the data for pool"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_b57a2122","line":83,"updated":"2016-04-20 19:53:13.000000000","message":"Same thing as above - we aren\u0027t passing around models anymore.","commit_id":"4f2c930defe7b70a1ea5bf9fe52c3c22fe3070ba"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"c190fee4ec8d4d6b486476b7ae75e42ac1a99d93","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @base.handle_errors"},{"line_number":82,"context_line":"    def update_pool(self, uuid, pool_model\u003dNone, wait_until\u003dFalse,"},{"line_number":83,"context_line":"                    params\u003dNone):"},{"line_number":84,"context_line":"        \"\"\"Update a pool with the specified parameters."},{"line_number":85,"context_line":"        :param uuid: The unique identifier of the pool."},{"line_number":86,"context_line":"        :param pool_model: A dictionary represening the data for pool"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_c34c2ba0","line":83,"in_reply_to":"1a122d0e_b57a2122","updated":"2016-04-21 10:35:24.000000000","message":"Done","commit_id":"4f2c930defe7b70a1ea5bf9fe52c3c22fe3070ba"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"0568d67aa87d92509346fb7072a9f5866277fcee","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                       include in the request URI."},{"line_number":31,"context_line":"        :return: A tuple with the server response and the created pool."},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":"        pool \u003d {"},{"line_number":34,"context_line":"                 \"name\": pool_name,"},{"line_number":35,"context_line":"                 \"ns_records\": ns_records"},{"line_number":36,"context_line":"        }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if pool[\u0027name\u0027] is None or pool[\u0027ns_records\u0027] is None:"},{"line_number":39,"context_line":"            pool \u003d dns_data_utils.rand_pool_data()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        resp, body \u003d self._create_request(\u0027pools\u0027, object_dict\u003dpool,"},{"line_number":42,"context_line":"                                          params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_e66c5a38","line":39,"range":{"start_line":33,"start_character":8,"end_line":39,"end_character":50},"updated":"2016-05-04 16:29:50.000000000","message":"This doesn\u0027t allow us to selectively specify just the pool_name or just ns_records. If I do,\n\n    create_pool(pool_name\u003d\"whatever\")\n\nsince ns_records\u003dNone, the pool_name passed in would get replaced with a randomly generated value.","commit_id":"cbaa57c0309859033de2ba1e06d7f962c08b6628"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"54678ad04886470764ec28ea07bbb54d5e56c6f7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                       include in the request URI."},{"line_number":31,"context_line":"        :return: A tuple with the server response and the created pool."},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":"        pool \u003d {"},{"line_number":34,"context_line":"                 \"name\": pool_name,"},{"line_number":35,"context_line":"                 \"ns_records\": ns_records"},{"line_number":36,"context_line":"        }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if pool[\u0027name\u0027] is None or pool[\u0027ns_records\u0027] is None:"},{"line_number":39,"context_line":"            pool \u003d dns_data_utils.rand_pool_data()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        resp, body \u003d self._create_request(\u0027pools\u0027, object_dict\u003dpool,"},{"line_number":42,"context_line":"                                          params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_033cde91","line":39,"range":{"start_line":33,"start_character":8,"end_line":39,"end_character":50},"in_reply_to":"1a122d0e_e66c5a38","updated":"2016-05-04 19:06:24.000000000","message":"Done","commit_id":"cbaa57c0309859033de2ba1e06d7f962c08b6628"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"0568d67aa87d92509346fb7072a9f5866277fcee","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        :return: A tuple with the server response and the updated pool."},{"line_number":96,"context_line":"        \"\"\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        pool \u003d {}"},{"line_number":99,"context_line":"        if pool_name is not None:"},{"line_number":100,"context_line":"            pool[\u0027name\u0027] \u003d pool_name"},{"line_number":101,"context_line":"        if ns_records is not None:"},{"line_number":102,"context_line":"            pool[\u0027ns_records\u0027] \u003d ns_records"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        if pool[\u0027name\u0027] is None and pool[\u0027ns_records\u0027] is None:"},{"line_number":105,"context_line":"            pool \u003d dns_data_utils.rand_pool_data()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        resp, body \u003d self._update_request(\u0027pools\u0027, uuid, pool,"},{"line_number":108,"context_line":"                                          params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_e653ba6a","line":105,"range":{"start_line":98,"start_character":8,"end_line":105,"end_character":50},"updated":"2016-05-04 16:29:50.000000000","message":"Same issue as above.","commit_id":"cbaa57c0309859033de2ba1e06d7f962c08b6628"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"54678ad04886470764ec28ea07bbb54d5e56c6f7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        :return: A tuple with the server response and the updated pool."},{"line_number":96,"context_line":"        \"\"\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        pool \u003d {}"},{"line_number":99,"context_line":"        if pool_name is not None:"},{"line_number":100,"context_line":"            pool[\u0027name\u0027] \u003d pool_name"},{"line_number":101,"context_line":"        if ns_records is not None:"},{"line_number":102,"context_line":"            pool[\u0027ns_records\u0027] \u003d ns_records"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        if pool[\u0027name\u0027] is None and pool[\u0027ns_records\u0027] is None:"},{"line_number":105,"context_line":"            pool \u003d dns_data_utils.rand_pool_data()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        resp, body \u003d self._update_request(\u0027pools\u0027, uuid, pool,"},{"line_number":108,"context_line":"                                          params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_633dd28d","line":105,"range":{"start_line":98,"start_character":8,"end_line":105,"end_character":50},"in_reply_to":"1a122d0e_e653ba6a","updated":"2016-05-04 19:06:24.000000000","message":"Done","commit_id":"cbaa57c0309859033de2ba1e06d7f962c08b6628"}],"designate_tempest_plugin/tests/api/v2/test_pool.py":[{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"b06c3d441f8711e9f97b5639862e47dfed635a84","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        LOG.info(\u0027Create a pool\u0027)"},{"line_number":43,"context_line":"        _, pool \u003d self.client.create_pool(pool_model\u003dpool_model)"},{"line_number":44,"context_line":"        self.addCleanup(self.client.delete_pool, pool[\u0027id\u0027])"},{"line_number":45,"context_line":"        self.assertEqual(pool_model[\"name\"], pool[\u0027name\u0027])"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":48,"context_line":"    @test.idempotent_id(\u0027e80eb70a-8ee5-40eb-b06e-599597a8ab7e\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_55074d81","line":45,"updated":"2016-04-20 19:53:13.000000000","message":"I think we want to use the `self.assertExpected(...)` method here.","commit_id":"4f2c930defe7b70a1ea5bf9fe52c3c22fe3070ba"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"c190fee4ec8d4d6b486476b7ae75e42ac1a99d93","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        LOG.info(\u0027Create a pool\u0027)"},{"line_number":43,"context_line":"        _, pool \u003d self.client.create_pool(pool_model\u003dpool_model)"},{"line_number":44,"context_line":"        self.addCleanup(self.client.delete_pool, pool[\u0027id\u0027])"},{"line_number":45,"context_line":"        self.assertEqual(pool_model[\"name\"], pool[\u0027name\u0027])"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":48,"context_line":"    @test.idempotent_id(\u0027e80eb70a-8ee5-40eb-b06e-599597a8ab7e\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_43613b04","line":45,"in_reply_to":"1a122d0e_55074d81","updated":"2016-04-21 10:35:24.000000000","message":"Done","commit_id":"4f2c930defe7b70a1ea5bf9fe52c3c22fe3070ba"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"4adbb3cb6bfefdf3da18dc42a8929cc8bd170ecd","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    excluded_keys \u003d [\u0027created_at\u0027, \u0027updated_at\u0027, \u0027links\u0027, \u0027ns_records\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class PoolTest(BasePoolTest):"},{"line_number":30,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_504104a8","line":29,"range":{"start_line":29,"start_character":6,"end_line":29,"end_character":14},"updated":"2016-04-29 15:59:51.000000000","message":"For consistency\u0027s sake, can we call this the TldAdmin test?","commit_id":"658b6edfeb0c62da7b4366f94db4c5b26d2f4e63"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"4adbb3cb6bfefdf3da18dc42a8929cc8bd170ecd","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class PoolTest(BasePoolTest):"},{"line_number":30,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_100aec78","line":30,"range":{"start_line":30,"start_character":19,"end_line":30,"end_character":28},"updated":"2016-04-29 15:59:51.000000000","message":"Primary creds appear to be unused, so we can remove that one from the list.","commit_id":"658b6edfeb0c62da7b4366f94db4c5b26d2f4e63"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"4adbb3cb6bfefdf3da18dc42a8929cc8bd170ecd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def setup_clients(cls):"},{"line_number":34,"context_line":"        super(PoolTest, cls).setup_clients()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        cls.client \u003d cls.os_adm.pool_client"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":39,"context_line":"    @test.idempotent_id(\u002769257f7c-b3d5-4e1b-998e-0677ad12f125\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_5028e4e1","line":36,"range":{"start_line":36,"start_character":7,"end_line":36,"end_character":18},"updated":"2016-04-29 15:59:51.000000000","message":"Again for consistency, can we call this `cls.admin_client`","commit_id":"658b6edfeb0c62da7b4366f94db4c5b26d2f4e63"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"0568d67aa87d92509346fb7072a9f5866277fcee","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class BasePoolTest(base.BaseDnsTest):"},{"line_number":26,"context_line":"    excluded_keys \u003d [\u0027created_at\u0027, \u0027updated_at\u0027, \u0027links\u0027, \u0027ns_records\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class PoolAdminTest(BasePoolTest):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_26e5b2a7","line":26,"range":{"start_line":26,"start_character":58,"end_line":26,"end_character":70},"updated":"2016-05-04 16:29:50.000000000","message":"Do we want to exclude the ns_records here?","commit_id":"cbaa57c0309859033de2ba1e06d7f962c08b6628"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"54678ad04886470764ec28ea07bbb54d5e56c6f7","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class BasePoolTest(base.BaseDnsTest):"},{"line_number":26,"context_line":"    excluded_keys \u003d [\u0027created_at\u0027, \u0027updated_at\u0027, \u0027links\u0027, \u0027ns_records\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class PoolAdminTest(BasePoolTest):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_43cb76a4","line":26,"range":{"start_line":26,"start_character":58,"end_line":26,"end_character":70},"in_reply_to":"1a122d0e_26e5b2a7","updated":"2016-05-04 19:06:24.000000000","message":"No. This should be included. I will fix it in next patch.","commit_id":"cbaa57c0309859033de2ba1e06d7f962c08b6628"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"0568d67aa87d92509346fb7072a9f5866277fcee","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        LOG.info(\u0027List pools\u0027)"},{"line_number":86,"context_line":"        _, body \u003d self.admin_client.list_pools()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        self.assertTrue(len(body[\u0027pools\u0027]) \u003e 0)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":91,"context_line":"    @test.idempotent_id(\u0027fdcc84ce-af65-4af6-a5fc-6c50acbea0f0\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_26065220","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":47},"updated":"2016-05-04 16:29:50.000000000","message":"This should use self.assertGreater()","commit_id":"cbaa57c0309859033de2ba1e06d7f962c08b6628"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"54678ad04886470764ec28ea07bbb54d5e56c6f7","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        LOG.info(\u0027List pools\u0027)"},{"line_number":86,"context_line":"        _, body \u003d self.admin_client.list_pools()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        self.assertTrue(len(body[\u0027pools\u0027]) \u003e 0)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":91,"context_line":"    @test.idempotent_id(\u0027fdcc84ce-af65-4af6-a5fc-6c50acbea0f0\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_63531217","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":47},"in_reply_to":"1a122d0e_26065220","updated":"2016-05-04 19:06:24.000000000","message":"Done","commit_id":"cbaa57c0309859033de2ba1e06d7f962c08b6628"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"0568d67aa87d92509346fb7072a9f5866277fcee","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        _, patch_pool \u003d self.admin_client.update_pool("},{"line_number":101,"context_line":"            pool[\u0027id\u0027], pool_name\u003dpool_data[\u0027name\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.assertNotEqual(pool[\"name\"], patch_pool[\"name\"])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":106,"context_line":"    @test.idempotent_id(\u002741ad6a84-00ce-4a04-9fd5-b7c15c31e2db\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_86464679","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":61},"updated":"2016-05-04 16:29:50.000000000","message":"Can we instead check the value is the right one?\n\n    self.assertEqual(pool_data[\u0027name\u0027], patch_pool[\u0027name\u0027])","commit_id":"cbaa57c0309859033de2ba1e06d7f962c08b6628"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"54678ad04886470764ec28ea07bbb54d5e56c6f7","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        _, patch_pool \u003d self.admin_client.update_pool("},{"line_number":101,"context_line":"            pool[\u0027id\u0027], pool_name\u003dpool_data[\u0027name\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.assertNotEqual(pool[\"name\"], patch_pool[\"name\"])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":106,"context_line":"    @test.idempotent_id(\u002741ad6a84-00ce-4a04-9fd5-b7c15c31e2db\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_833e2eb6","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":61},"in_reply_to":"1a122d0e_86464679","updated":"2016-05-04 19:06:24.000000000","message":"Done","commit_id":"cbaa57c0309859033de2ba1e06d7f962c08b6628"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"67e0b11b804d3d418641b8906998100562db3542","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        _, body \u003d self.admin_client.show_pool(pool[\u0027id\u0027])"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        LOG.info(\u0027Ensure the fetched response matches the created pool\u0027)"},{"line_number":66,"context_line":"        self.assertExpected(pool, body, self.excluded_keys)"},{"line_number":67,"context_line":"        for item in pool[\u0027ns_records\u0027]:"},{"line_number":68,"context_line":"            self.assertIn(item, body[\u0027ns_records\u0027])"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_986fb191","line":66,"updated":"2016-05-04 22:17:04.000000000","message":"It turns out that the ns_records in the request and in the response are not necessarily in the same order[1].\n\nWe\u0027ll probably want to add ns_records the exclude_keys, and check the ns_records separately from assertExpected(). Or, we can add an assertExpectedPool() function, or something similar.\n\n----------\n1. http://logs.openstack.org/97/307797/10/check/gate-tempest-dsvm-designate-powerdns/97ad700/logs/testr_results.html.gz","commit_id":"92460493dfda0dbc87028932d0d4448702e9f12a"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"1209573be04be7689384bd28f07953993af17544","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        _, body \u003d self.admin_client.show_pool(pool[\u0027id\u0027])"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        LOG.info(\u0027Ensure the fetched response matches the created pool\u0027)"},{"line_number":66,"context_line":"        self.assertExpected(pool, body, self.excluded_keys)"},{"line_number":67,"context_line":"        for item in pool[\u0027ns_records\u0027]:"},{"line_number":68,"context_line":"            self.assertIn(item, body[\u0027ns_records\u0027])"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_65b14de0","line":66,"in_reply_to":"1a122d0e_986fb191","updated":"2016-05-05 00:43:32.000000000","message":"Done","commit_id":"92460493dfda0dbc87028932d0d4448702e9f12a"}]}