)]}'
{"designate_tempest_plugin/config.py":[{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"e0783c01e1ac2a01634f21143b7c8a68fd715545","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    cfg.BoolOpt(\"designate\","},{"line_number":21,"context_line":"                default\u003dTrue,"},{"line_number":22,"context_line":"                help\u003d\"Whether or not designate is expected to be available.\"),"},{"line_number":23,"context_line":"]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"dns_group \u003d cfg.OptGroup(name\u003d\u0027dns\u0027,"},{"line_number":26,"context_line":"                         title\u003d\u0027DNS service options\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_4adc6346","line":23,"updated":"2016-05-03 16:47:18.000000000","message":"Would someone ever run these tests if they don\u0027t expect designate to be available? Do people want to install a whole bunch of tempest plugins for testing various services and toggle tests on/off via configs?","commit_id":"a1272e2b7823d247ecd742c219e1af13d572a2e8"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"af253c765804c20353860bbd0fef7e3e756ceae1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    cfg.BoolOpt(\"designate\","},{"line_number":21,"context_line":"                default\u003dTrue,"},{"line_number":22,"context_line":"                help\u003d\"Whether or not designate is expected to be available.\"),"},{"line_number":23,"context_line":"]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"dns_group \u003d cfg.OptGroup(name\u003d\u0027dns\u0027,"},{"line_number":26,"context_line":"                         title\u003d\u0027DNS service options\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_758f802e","line":23,"in_reply_to":"1a122d0e_4adc6346","updated":"2016-05-03 16:52:50.000000000","message":"2 reasons for this.. re your Q - Yea, I can see the plugin getting packaged in e.g. Ubuntu, and being sucked in as a dep of the \"tempest\" deb package.. (I talked with Zigo about something along these lines at the Summit)\n\nSecond one is, other services need some way of telling \"Designate is available\" to test e.g. the Neutron APIs which make use of Designate. `CONF.service_avaiable.designate` is the standard pattern here, this gets us closer to that (but still need an is-defined check on the consumer side :()","commit_id":"a1272e2b7823d247ecd742c219e1af13d572a2e8"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"c02510810c897d734ddd53b09647dfd20e7c367e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               help\u003d\"Timeout in seconds to wait for an resource to build.\"),"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"dns_feature_group \u003d cfg.OptGroup(name\u003d\u0027dns_feature_enabled\u0027,"},{"line_number":46,"context_line":"                                 title\u003d\u0027Enabled Designate Features\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"DnsFeatureGroup \u003d ["},{"line_number":49,"context_line":"    cfg.BoolOpt(\u0027api_v1\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_fb770706","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":68},"updated":"2016-05-03 14:53:52.000000000","message":"Since it might not be obvious to others, tempest explicitly requests users DO NOT use discovery to decide whether or not to test a feature, as a broken discovery mechanism (e.g. Discover as off, when in reality enabled) would lead to more issues.\n\nSee http://docs.openstack.org/developer/tempest/HACKING.html#skipping-tests","commit_id":"a1272e2b7823d247ecd742c219e1af13d572a2e8"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"af253c765804c20353860bbd0fef7e3e756ceae1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               help\u003d\"Timeout in seconds to wait for an resource to build.\"),"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"dns_feature_group \u003d cfg.OptGroup(name\u003d\u0027dns_feature_enabled\u0027,"},{"line_number":46,"context_line":"                                 title\u003d\u0027Enabled Designate Features\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"DnsFeatureGroup \u003d ["},{"line_number":49,"context_line":"    cfg.BoolOpt(\u0027api_v1\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_55fd246d","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":68},"in_reply_to":"1a122d0e_4a25835a","updated":"2016-05-03 16:52:50.000000000","message":"We could, but I\u0027ve another patch coming for our DevStack plugin itself to support enabling/disabling APIs - which will set these values. Also looking at passing enabled API extensions in while I\u0027m at it.","commit_id":"a1272e2b7823d247ecd742c219e1af13d572a2e8"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"e0783c01e1ac2a01634f21143b7c8a68fd715545","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               help\u003d\"Timeout in seconds to wait for an resource to build.\"),"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"dns_feature_group \u003d cfg.OptGroup(name\u003d\u0027dns_feature_enabled\u0027,"},{"line_number":46,"context_line":"                                 title\u003d\u0027Enabled Designate Features\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"DnsFeatureGroup \u003d ["},{"line_number":49,"context_line":"    cfg.BoolOpt(\u0027api_v1\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_4a25835a","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":68},"in_reply_to":"1a122d0e_fb770706","updated":"2016-05-03 16:47:18.000000000","message":"This is okay. But if things are confined to separate directories (v1 tests in a v1/ dir, v2 in v2/, etc) or to separate files (secondary zone tests in test_secondary*.py), we could just filter out tests by regex.","commit_id":"a1272e2b7823d247ecd742c219e1af13d572a2e8"}],"designate_tempest_plugin/services/dns/v1/json/domains_client.py":[{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"e0783c01e1ac2a01634f21143b7c8a68fd715545","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class DomainsClient(rest_client.RestClient):"},{"line_number":28,"context_line":"    def list_domains(self, params\u003dNone):"},{"line_number":29,"context_line":"        \"\"\"List all domains.\"\"\""},{"line_number":30,"context_line":"        resp, body \u003d self.get(\"v1/domains\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_b5fd98b3","line":27,"range":{"start_line":27,"start_character":20,"end_line":27,"end_character":42},"updated":"2016-05-03 16:47:18.000000000","message":"With the v2 clients, we have a v2 base class https://github.com/openstack/designate-tempest-plugin/blob/master/designate_tempest_plugin/services/dns/v2/json/base.py. Ideally, we would follow the same pattern here, with a DnsClientV1Base class.","commit_id":"a1272e2b7823d247ecd742c219e1af13d572a2e8"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"af253c765804c20353860bbd0fef7e3e756ceae1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class DomainsClient(rest_client.RestClient):"},{"line_number":28,"context_line":"    def list_domains(self, params\u003dNone):"},{"line_number":29,"context_line":"        \"\"\"List all domains.\"\"\""},{"line_number":30,"context_line":"        resp, body \u003d self.get(\"v1/domains\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_f5bb90e2","line":27,"range":{"start_line":27,"start_character":20,"end_line":27,"end_character":42},"in_reply_to":"1a122d0e_b5fd98b3","updated":"2016-05-03 16:52:50.000000000","message":"Agree, I was trying to keep this as close to a straight port of the existing tests from contrib as possible, but that\u0027s slowly gone out the window.. Will adjust ;)","commit_id":"a1272e2b7823d247ecd742c219e1af13d572a2e8"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"e0783c01e1ac2a01634f21143b7c8a68fd715545","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        \"\"\"List all domains.\"\"\""},{"line_number":30,"context_line":"        resp, body \u003d self.get(\"v1/domains\")"},{"line_number":31,"context_line":"        body \u003d json.loads(body)"},{"line_number":32,"context_line":"        self.validate_response(schema.list_domains, resp, body)"},{"line_number":33,"context_line":"        return resp, body[\u0027domains\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get_domain(self, domain_id):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_6a583f58","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":30},"updated":"2016-05-03 16:47:18.000000000","message":"Just a reminder, this function skips validation when the response code is \u003e\u003d 400 (effectively): https://github.com/openstack/tempest/blob/master/tempest/lib/common/rest_client.py#L819\n\nI doesn\u0027t look like the status codes get checked in the test cases themselves either, so we\u0027ll probably want to assert the status code is correct in these client methods.","commit_id":"a1272e2b7823d247ecd742c219e1af13d572a2e8"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"af253c765804c20353860bbd0fef7e3e756ceae1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        \"\"\"List all domains.\"\"\""},{"line_number":30,"context_line":"        resp, body \u003d self.get(\"v1/domains\")"},{"line_number":31,"context_line":"        body \u003d json.loads(body)"},{"line_number":32,"context_line":"        self.validate_response(schema.list_domains, resp, body)"},{"line_number":33,"context_line":"        return resp, body[\u0027domains\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get_domain(self, domain_id):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_b5ebd8db","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":30},"in_reply_to":"1a122d0e_6a583f58","updated":"2016-05-03 16:52:50.000000000","message":"Agree, I was trying to keep this as close to a straight port of the existing tests from contrib as possible, but that\u0027s slowly gone out the window.. Will adjust ;)","commit_id":"a1272e2b7823d247ecd742c219e1af13d572a2e8"}]}