)]}'
{"designate_tempest_plugin/tests/api/v2/test_blacklists.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"306da85e0fef1a706ed1ae651d7a0f494120e63d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    excluded_keys \u003d [\u0027created_at\u0027, \u0027updated_at\u0027, \u0027links\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class BlacklistsTest(BaseBlacklistsTest):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    credentials \u003d [\"admin\"]"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_ce1f19b6","line":29,"range":{"start_line":29,"start_character":6,"end_line":29,"end_character":20},"updated":"2016-04-21 17:06:57.000000000","message":"I\u0027d, purely for my consistency OCD, call this \"BlacklistsAdminTest\"","commit_id":"2acc5fb63750e8dbdc8bb0a3fb8e9144fa5618fb"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"306da85e0fef1a706ed1ae651d7a0f494120e63d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(BlacklistsTest, cls).setup_clients()"},{"line_number":36,"context_line":"        cls.admin_client \u003d cls.os_adm.blacklists_client"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":39,"context_line":"    @test.idempotent_id(\u00273a7f7564-6bdd-446e-addc-a3475b4c3f71\u0027)"},{"line_number":40,"context_line":"    def test_create_blacklist(self):"},{"line_number":41,"context_line":"        LOG.info(\u0027Create a blacklist\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_2e020d70","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":28},"updated":"2016-04-21 17:06:57.000000000","message":"I *think* we should mark tests like these (things which affect the system globally) as something other than smoke.. Both as, there not 100% critical to the basic function of Designate, and there not something you would want to run against your production cloud, so having a way to filter them out would be v.useful.","commit_id":"2acc5fb63750e8dbdc8bb0a3fb8e9144fa5618fb"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"c527e3d63fcd85657a2d3f4749ad34538f99d70e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(BlacklistsTest, cls).setup_clients()"},{"line_number":36,"context_line":"        cls.admin_client \u003d cls.os_adm.blacklists_client"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":39,"context_line":"    @test.idempotent_id(\u00273a7f7564-6bdd-446e-addc-a3475b4c3f71\u0027)"},{"line_number":40,"context_line":"    def test_create_blacklist(self):"},{"line_number":41,"context_line":"        LOG.info(\u0027Create a blacklist\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_f9861d15","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":28},"in_reply_to":"1a122d0e_2e020d70","updated":"2016-04-21 17:26:51.000000000","message":"If there are no admin creds available (like with pre-provisioned creds), Tempest will skip tests that require admin credentials. I saw this work when I hacked some things together to get these tests running against our internal envs.","commit_id":"2acc5fb63750e8dbdc8bb0a3fb8e9144fa5618fb"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"203d2613a0b75e3131472016808d55096d298edc","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(BlacklistsTest, cls).setup_clients()"},{"line_number":36,"context_line":"        cls.admin_client \u003d cls.os_adm.blacklists_client"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":39,"context_line":"    @test.idempotent_id(\u00273a7f7564-6bdd-446e-addc-a3475b4c3f71\u0027)"},{"line_number":40,"context_line":"    def test_create_blacklist(self):"},{"line_number":41,"context_line":"        LOG.info(\u0027Create a blacklist\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_f472a4af","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":28},"in_reply_to":"1a122d0e_f9861d15","updated":"2016-04-21 17:33:55.000000000","message":"Ah, nice. Okay.. Ignore me on that part :) I\u0027m still not sure I\u0027d call them smoke tests though, the idea being smoke tests should be quick, real quick to run, and should cover only the most used APIs and features. Removing the `test.attr` decorator would make it line up with my thinking - but I\u0027m not that fussed now that the admin creds thing has been explained.","commit_id":"2acc5fb63750e8dbdc8bb0a3fb8e9144fa5618fb"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"306da85e0fef1a706ed1ae651d7a0f494120e63d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def test_create_blacklist(self):"},{"line_number":41,"context_line":"        LOG.info(\u0027Create a blacklist\u0027)"},{"line_number":42,"context_line":"        _, blacklist \u003d self.admin_client.create_blacklist()"},{"line_number":43,"context_line":"        self.addCleanup(self.admin_client.delete_blacklist, blacklist[\u0027id\u0027])"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":46,"context_line":"    @test.idempotent_id(\u00275bc02942-6225-4619-8f49-2105581a8dd6\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_ae161def","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":76},"updated":"2016-04-21 17:06:57.000000000","message":"So, I think we should do the whole assertExpected thing here.\n\nHere, against the response from the POST API call, and in the show test below, against the response to the GET request.","commit_id":"2acc5fb63750e8dbdc8bb0a3fb8e9144fa5618fb"}]}