)]}'
{"designate_tempest_plugin/services/dns/json/base.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"3f09744c6cddc13cd39046613a4bc2299cc3511d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    UPDATE_STATUS_CODES \u003d []"},{"line_number":58,"context_line":"    DELETE_STATUS_CODES \u003d []"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def serialize(self, data):"},{"line_number":61,"context_line":"        if isinstance(data, six.string_types):"},{"line_number":62,"context_line":"            return data"},{"line_number":63,"context_line":"        return json.dumps(data)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def deserialize(self, resp, object_str):"},{"line_number":66,"context_line":"        if \u0027application/json\u0027 in resp[\u0027content-type\u0027]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_d3fb6845","line":63,"range":{"start_line":60,"start_character":4,"end_line":63,"end_character":31},"updated":"2016-06-01 17:20:16.000000000","message":"While this is perfectly valid, I wonder if we should follow the same pattern used in deserialize, where a content-type would be passed in to decide the serialization format?","commit_id":"b51bfd75c19d46798a205c0753d7ac1b57e82cc1"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"1ef3f7fbd9e57cb0f7ea4308eb05436a66743dec","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    UPDATE_STATUS_CODES \u003d []"},{"line_number":58,"context_line":"    DELETE_STATUS_CODES \u003d []"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def serialize(self, data):"},{"line_number":61,"context_line":"        if isinstance(data, six.string_types):"},{"line_number":62,"context_line":"            return data"},{"line_number":63,"context_line":"        return json.dumps(data)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def deserialize(self, resp, object_str):"},{"line_number":66,"context_line":"        if \u0027application/json\u0027 in resp[\u0027content-type\u0027]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_76ad4ae8","line":63,"range":{"start_line":60,"start_character":4,"end_line":63,"end_character":31},"in_reply_to":"9abb7d3a_d3fb6845","updated":"2016-06-01 17:29:33.000000000","message":"Well, I wanted to do that actually, but I thought it was awkward. We would have to grab the content-type header from either headers or extra_headers or use a default (of application/json). \n\nI think that would also block us from doing certain kinds of negative testing where you want to mix and match content-types and content freely (although maybe we\u0027ll never do this testing, Idk).","commit_id":"b51bfd75c19d46798a205c0753d7ac1b57e82cc1"}]}