)]}'
{"designate_tempest_plugin/tests/scenario/v2/test_recordsets.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"957f40a9bca0f06de7b9512990a87c89d6fa324c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if self.zone:"},{"line_number":44,"context_line":"            LOG.info(\u0027Retrieve info from a zone\u0027)"},{"line_number":45,"context_line":"            resp, zone \u003d self.client.show_zone(self.zone)"},{"line_number":46,"context_line":"        else:"},{"line_number":47,"context_line":"            LOG.info(\u0027Create a new zone\u0027)"},{"line_number":48,"context_line":"            resp, zone \u003d self.client.create_zone()"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_c34bbe28","line":46,"updated":"2018-03-11 17:10:09.000000000","message":"Looks good, but there is no automatic cleanup.\n\nAdd something like\n\u003e self.addCleanup(self.client.delete_zone, zone[\u0027id\u0027])\n\nIf the tests fail at any time, the zones will never get cleaned up with the current code.","commit_id":"7db8b84040168e5761fb50b3981ef3931b95d38c"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"a9c30b38cd1b0e0a9374bc54478c8a83fd4a646e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if self.zone:"},{"line_number":44,"context_line":"            LOG.info(\u0027Retrieve info from a zone\u0027)"},{"line_number":45,"context_line":"            resp, zone \u003d self.client.show_zone(self.zone)"},{"line_number":46,"context_line":"        else:"},{"line_number":47,"context_line":"            LOG.info(\u0027Create a new zone\u0027)"},{"line_number":48,"context_line":"            resp, zone \u003d self.client.create_zone()"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_71c2bceb","line":46,"in_reply_to":"df7087c5_c34bbe28","updated":"2018-03-13 00:07:22.000000000","message":"Thanks, the Cleanup is added now. :)","commit_id":"7db8b84040168e5761fb50b3981ef3931b95d38c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3c0dc23bb8a563819ab361853d413ea3bd4e561e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def test_create_and_delete_records_on_existing_zone(self, name,"},{"line_number":43,"context_line":"                                                        type, records):"},{"line_number":44,"context_line":"        if self.zone:"},{"line_number":45,"context_line":"            LOG.info(\u0027Retrieve info from a zone\u0027)"},{"line_number":46,"context_line":"            resp, zone \u003d self.client.show_zone(self.zone)"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            LOG.info(\u0027Create a new zone\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_72c2baeb","line":45,"updated":"2018-03-12 05:52:38.000000000","message":"I\u0027m wondering whether this should be moved to the class setup. We don\u0027t need a new zone for each new data set, do we?","commit_id":"970bd0385fc4f40eacbeddd05395e611662700ad"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"a9c30b38cd1b0e0a9374bc54478c8a83fd4a646e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def test_create_and_delete_records_on_existing_zone(self, name,"},{"line_number":43,"context_line":"                                                        type, records):"},{"line_number":44,"context_line":"        if self.zone:"},{"line_number":45,"context_line":"            LOG.info(\u0027Retrieve info from a zone\u0027)"},{"line_number":46,"context_line":"            resp, zone \u003d self.client.show_zone(self.zone)"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            LOG.info(\u0027Create a new zone\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_b27cd2b5","line":45,"in_reply_to":"df7087c5_72c2baeb","updated":"2018-03-13 00:07:22.000000000","message":"Thanks Jens, no, we don\u0027t separate zone for each recordset.","commit_id":"970bd0385fc4f40eacbeddd05395e611662700ad"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3c0dc23bb8a563819ab361853d413ea3bd4e561e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                                        type, records):"},{"line_number":44,"context_line":"        if self.zone:"},{"line_number":45,"context_line":"            LOG.info(\u0027Retrieve info from a zone\u0027)"},{"line_number":46,"context_line":"            resp, zone \u003d self.client.show_zone(self.zone)"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            LOG.info(\u0027Create a new zone\u0027)"},{"line_number":49,"context_line":"            resp, zone \u003d self.client.create_zone()"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_f2848ab3","line":46,"updated":"2018-03-12 05:52:38.000000000","message":"The \"resp\" doesn\u0027t seem to get used anywhere, so it should be replaced by \"_\" to indicate that.\n\nSame for all occurrences further down the line.","commit_id":"970bd0385fc4f40eacbeddd05395e611662700ad"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"a9c30b38cd1b0e0a9374bc54478c8a83fd4a646e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                                        type, records):"},{"line_number":44,"context_line":"        if self.zone:"},{"line_number":45,"context_line":"            LOG.info(\u0027Retrieve info from a zone\u0027)"},{"line_number":46,"context_line":"            resp, zone \u003d self.client.show_zone(self.zone)"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            LOG.info(\u0027Create a new zone\u0027)"},{"line_number":49,"context_line":"            resp, zone \u003d self.client.create_zone()"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_126ede00","line":46,"in_reply_to":"df7087c5_f2848ab3","updated":"2018-03-13 00:07:22.000000000","message":"Agree, will fix it","commit_id":"970bd0385fc4f40eacbeddd05395e611662700ad"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3c0dc23bb8a563819ab361853d413ea3bd4e561e","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            LOG.info(\u0027Ensure we respond with CREATE+PENDING\u0027)"},{"line_number":54,"context_line":"            self.assertEqual(\u0027CREATE\u0027, zone[\u0027action\u0027])"},{"line_number":55,"context_line":"            self.assertEqual(\u0027PENDING\u0027, zone[\u0027status\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        LOG.info(\u0027Ensure we respond with ACTIVE\u0027)"},{"line_number":58,"context_line":"        waiters.wait_for_zone_status(self.client, zone[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_12eb3e79","line":55,"updated":"2018-03-12 05:52:38.000000000","message":"Not sure we should be checking this here, as it isn\u0027t the focus of the tests.","commit_id":"970bd0385fc4f40eacbeddd05395e611662700ad"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"a9c30b38cd1b0e0a9374bc54478c8a83fd4a646e","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            LOG.info(\u0027Ensure we respond with CREATE+PENDING\u0027)"},{"line_number":54,"context_line":"            self.assertEqual(\u0027CREATE\u0027, zone[\u0027action\u0027])"},{"line_number":55,"context_line":"            self.assertEqual(\u0027PENDING\u0027, zone[\u0027status\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        LOG.info(\u0027Ensure we respond with ACTIVE\u0027)"},{"line_number":58,"context_line":"        waiters.wait_for_zone_status(self.client, zone[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_52645622","line":55,"in_reply_to":"df7087c5_12eb3e79","updated":"2018-03-13 00:07:22.000000000","message":"Agree, will fix it","commit_id":"970bd0385fc4f40eacbeddd05395e611662700ad"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3c0dc23bb8a563819ab361853d413ea3bd4e561e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                              zone[\u0027id\u0027], recordset[\u0027id\u0027]))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if not self.zone:"},{"line_number":101,"context_line":"            LOG.info(\u0027Delete the created zone\u0027)"},{"line_number":102,"context_line":"            resp, body \u003d self.client.delete_zone(zone[\u0027id\u0027])"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"            LOG.info(\u0027Ensure we respond with DELETE+PENDING\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_72f4fa5b","line":101,"updated":"2018-03-12 05:52:38.000000000","message":"I don\u0027t think we still need this whole block with the auto-cleanup added. As zone deletion isn\u0027t the focus of these tests, I think we could just skip it?","commit_id":"970bd0385fc4f40eacbeddd05395e611662700ad"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"a9c30b38cd1b0e0a9374bc54478c8a83fd4a646e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                              zone[\u0027id\u0027], recordset[\u0027id\u0027]))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if not self.zone:"},{"line_number":101,"context_line":"            LOG.info(\u0027Delete the created zone\u0027)"},{"line_number":102,"context_line":"            resp, body \u003d self.client.delete_zone(zone[\u0027id\u0027])"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"            LOG.info(\u0027Ensure we respond with DELETE+PENDING\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_72671a27","line":101,"in_reply_to":"df7087c5_72f4fa5b","updated":"2018-03-13 00:07:22.000000000","message":"Agree, will fix it","commit_id":"970bd0385fc4f40eacbeddd05395e611662700ad"}]}