)]}'
{"designate_tempest_plugin/tests/api/v2/test_quotas.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3ffb5e4890d662c6d6560cbcdcfe1db9f8bd3a8a","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                                     \"is not being verified.\")"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        project_id \u003d \u0027project-that-does-not-exist\u0027"},{"line_number":161,"context_line":"        original_quotas \u003d self._store_quotas(project_id\u003dproject_id,"},{"line_number":162,"context_line":"                                             cleanup\u003dFalse)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        LOG.info(\"Updating quotas for non-existing %s \", project_id)"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_576c8d9b","line":162,"range":{"start_line":161,"start_character":8,"end_line":162,"end_character":59},"updated":"2019-03-21 09:33:41.000000000","message":"This doesn\u0027t look right to me. We are trying to get quotas for a non-existing project, which I\u0027m not sure whether that has a defined result at all ...","commit_id":"dc4007151f9823fb02d0d3b9e85c334add692a22"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1f1b1201fb43eef4d73b606aab417a87aabf03aa","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                                     \"is not being verified.\")"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        project_id \u003d \u0027project-that-does-not-exist\u0027"},{"line_number":161,"context_line":"        original_quotas \u003d self._store_quotas(project_id\u003dproject_id,"},{"line_number":162,"context_line":"                                             cleanup\u003dFalse)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        LOG.info(\"Updating quotas for non-existing %s \", project_id)"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_7cdcf217","line":162,"range":{"start_line":161,"start_character":8,"end_line":162,"end_character":59},"in_reply_to":"5fc1f717_576c8d9b","updated":"2019-03-22 08:00:41.000000000","message":"when validation of the project for quota is disabled (and this test is not skipped, see the if-condition above) any request to non-existing project will return default quotas, which we are saving\n\nin fact, when project validation for quota is disabled, designate will allow updating quota for project represented as any string (bug 1760822) - it will not actually enforce those though (as enforcement happens on exact match of project UUID), but still this is supported behavior as project-for-quota verification is disabled by default, and we must have a test for it.","commit_id":"dc4007151f9823fb02d0d3b9e85c334add692a22"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3ffb5e4890d662c6d6560cbcdcfe1db9f8bd3a8a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        with self.assertRaisesDns(lib_exc.BadRequest, \u0027invalid_project\u0027, 400):"},{"line_number":171,"context_line":"            self.admin_client.update_quotas(**request)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        _, client_body \u003d self.quotas_client.show_quotas()"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        self.assertExpected(original_quotas, client_body, [])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_5701edae","line":173,"updated":"2019-03-21 09:33:41.000000000","message":"... and then we compare those to the quota settings of the default client, which may match, if both happen to have the same default quota settings, but fail otherwise.\n\nI think it would make sense to instead drop this last check. Then you can also drop the cleanup preparation above and as a total result omit the \"cleanup\" variable in your helper function.","commit_id":"dc4007151f9823fb02d0d3b9e85c334add692a22"}]}