)]}'
{".zuul.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f8e3c1e0810ad64926676405e87b529037e1730d","unresolved":true,"context_lines":[{"line_number":8,"context_line":"      jobs:"},{"line_number":9,"context_line":"        - neutron-tempest-plugin-designate-scenario"},{"line_number":10,"context_line":"        - designate-tempest-plugin-split-horizon"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    gate:"},{"line_number":13,"context_line":"      queue: designate"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"381740cf_2aabfb89","line":11,"updated":"2021-03-12 06:17:34.000000000","message":"Not sure whether the empty line is actually harmful, but it does look unneeded.","commit_id":"9e6bd8e0e04647729ad4eb9ab10f5c04574f751b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f8e3c1e0810ad64926676405e87b529037e1730d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"        - designate-tempest-plugin-split-horizon"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    gate:"},{"line_number":13,"context_line":"      queue: designate"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- job:"},{"line_number":16,"context_line":"    name: designate-tempest-plugin-split-horizon"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"e0c71496_0b8e54da","line":13,"updated":"2021-03-12 06:17:34.000000000","message":"I think you would want to have the new job also for gating.","commit_id":"9e6bd8e0e04647729ad4eb9ab10f5c04574f751b"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"c5fe75758fac8d3fcf129cc3f7e95fe9ddeb60be","unresolved":true,"context_lines":[{"line_number":10,"context_line":"        - designate-tempest-plugin-split-horizon"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    gate:"},{"line_number":13,"context_line":"      queue: designate"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- job:"},{"line_number":16,"context_line":"    name: designate-tempest-plugin-split-horizon"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"ead9eeda_770bbd5c","line":13,"in_reply_to":"e0c71496_0b8e54da","updated":"2021-03-12 18:57:12.000000000","message":"what is gating? can u explain more thanks","commit_id":"9e6bd8e0e04647729ad4eb9ab10f5c04574f751b"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"028e25adfc4c336206803ea34818cd8122b77f4f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"        - designate-tempest-plugin-split-horizon"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    gate:"},{"line_number":13,"context_line":"      queue: designate"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- job:"},{"line_number":16,"context_line":"    name: designate-tempest-plugin-split-horizon"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"5617a623_35b847e7","line":13,"in_reply_to":"ead9eeda_770bbd5c","updated":"2021-03-12 19:59:26.000000000","message":"The gate check is run to verify that the change can merge. This is done after it is workflow +1.\n\nhttps://zuul-ci.org/docs/zuul/discussion/concepts.html","commit_id":"9e6bd8e0e04647729ad4eb9ab10f5c04574f751b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f8e3c1e0810ad64926676405e87b529037e1730d","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    name: designate-tempest-plugin-split-horizon"},{"line_number":17,"context_line":"    parent: devstack-tempest"},{"line_number":18,"context_line":"    description: Designate split-horizon feature"},{"line_number":19,"context_line":"    voting: false"},{"line_number":20,"context_line":"    required-projects:"},{"line_number":21,"context_line":"      - openstack/designate"},{"line_number":22,"context_line":"      - openstack/designate-dashboard"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"d54e5b9a_97517405","line":19,"updated":"2021-03-12 06:17:34.000000000","message":"Why should this be non-voting?","commit_id":"9e6bd8e0e04647729ad4eb9ab10f5c04574f751b"}],"designate_tempest_plugin/config.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f8e3c1e0810ad64926676405e87b529037e1730d","unresolved":true,"context_lines":[{"line_number":88,"context_line":"                default\u003dFalse,"},{"line_number":89,"context_line":"                help\u003d\"Is https://specs.openstack.org/openstack/\""},{"line_number":90,"context_line":"                     \"designate-specs/specs/ussuri/split-view.html \""},{"line_number":91,"context_line":"                \"merged\"),"},{"line_number":92,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":25,"id":"ffaf598d_139281c5","line":91,"updated":"2021-03-12 06:17:34.000000000","message":"This mix of indentations looks confusing to me, can we keep that more consistent? Like if you unindent L90, the final word might fit in there?\nBut maybe the wording also should be changed, as the spec is already merged. IIUC the question should rather be whether the split horizon config is actually enabled in the pool configuration.","commit_id":"9e6bd8e0e04647729ad4eb9ab10f5c04574f751b"}],"designate_tempest_plugin/tests/scenario/v2/test_split_horizon.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f8e3c1e0810ad64926676405e87b529037e1730d","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    def setup_clients(cls):"},{"line_number":45,"context_line":"        super(SplitHorizonTest, cls).setup_clients()"},{"line_number":46,"context_line":"        # if the split horizon not enabled dont create"},{"line_number":47,"context_line":"        if not CONF.dns_feature_enabled.split_horizon:"},{"line_number":48,"context_line":"            return"},{"line_number":49,"context_line":"        cls.client \u003d cls.os_primary.zones_client"},{"line_number":50,"context_line":"        cls.recordset_client \u003d cls.os_primary.recordset_client"}],"source_content_type":"text/x-python","patch_set":25,"id":"b12a6b1e_e93674e6","line":47,"updated":"2021-03-12 06:17:34.000000000","message":"Can this happen before the super() call? Otherwise parent classes may have set up stuff already.","commit_id":"9e6bd8e0e04647729ad4eb9ab10f5c04574f751b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f8e3c1e0810ad64926676405e87b529037e1730d","unresolved":true,"context_lines":[{"line_number":122,"context_line":"        \"Config option dns.nameservers is missing or empty\")"},{"line_number":123,"context_line":"    @testtools.skipUnless("},{"line_number":124,"context_line":"        CONF.dns_feature_enabled.split_horizon,"},{"line_number":125,"context_line":"        \"Config option dns_feature_enabled.split_horizon is not enabled\")"},{"line_number":126,"context_line":"    def test_split_horizon(self):"},{"line_number":127,"context_line":"        zone_axfr \u003d dict()"},{"line_number":128,"context_line":"        mdns_host, mdns_port \u003d self._get_mdns_listen()"}],"source_content_type":"text/x-python","patch_set":25,"id":"024b9034_5ce49174","line":125,"updated":"2021-03-12 06:17:34.000000000","message":"You are checking this in the class setup already, why check twice?","commit_id":"9e6bd8e0e04647729ad4eb9ab10f5c04574f751b"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"fa009429196b5ea489553fe0155dc1125634084d","unresolved":true,"context_lines":[{"line_number":122,"context_line":"        \"Config option dns.nameservers is missing or empty\")"},{"line_number":123,"context_line":"    @testtools.skipUnless("},{"line_number":124,"context_line":"        CONF.dns_feature_enabled.split_horizon,"},{"line_number":125,"context_line":"        \"Config option dns_feature_enabled.split_horizon is not enabled\")"},{"line_number":126,"context_line":"    def test_split_horizon(self):"},{"line_number":127,"context_line":"        zone_axfr \u003d dict()"},{"line_number":128,"context_line":"        mdns_host, mdns_port \u003d self._get_mdns_listen()"}],"source_content_type":"text/x-python","patch_set":25,"id":"37c56247_4293b457","line":125,"in_reply_to":"024b9034_5ce49174","updated":"2021-03-12 18:55:55.000000000","message":"based on this it should be added \nhttps://docs.openstack.org/tempest/latest/HACKING.html#new-tests-for-new-features","commit_id":"9e6bd8e0e04647729ad4eb9ab10f5c04574f751b"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"2c8c87ce48af67a8e2d48d32167cd0bcd9d7407b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":32,"id":"08d289f0_187033a4","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":73},"updated":"2021-07-06 16:38:38.000000000","message":"It looks like a first license line, it means: \"Copyright [yyyy] [name of copyright owner]\"\nis missing here, usually this line is included, for example:\n\n\n# Copyright 2021 Red Hat.\n#\n# Licensed under the Apache License, Version 2.0 (the \"License\"); you may...\n...\n...","commit_id":"69f9fcce4cb1a6df1b33f158fe4f80d24a3a4c28"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"2c8c87ce48af67a8e2d48d32167cd0bcd9d7407b","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"},{"line_number":69,"context_line":"    def _create_recordsets(cls):"},{"line_number":70,"context_line":"        if not cls.zone:"},{"line_number":71,"context_line":"            LOG.info(\u0027The zone is not created yet\u0027)"},{"line_number":72,"context_line":"            return"},{"line_number":73,"context_line":"        cls.recordsets \u003d dict()"},{"line_number":74,"context_line":"        LOG.info(\u0027Create the recordsets\u0027)"},{"line_number":75,"context_line":"        for record_type in [\u0027A\u0027, \u0027AAAA\u0027]:"}],"source_content_type":"text/x-python","patch_set":32,"id":"f5903f50_138d1945","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":18},"updated":"2021-07-06 16:38:38.000000000","message":"Do we really need this check? Is that for a future needs?\n\nThis function: \"_create_recordsets\" is called by: \"resource_setup\"[1] only after waiter (Zone is ACTIVE) has been completed.\nThe above means that the Zone at this stagel, is already created and ACTIVE.\n \n[1] - https://review.opendev.org/c/openstack/designate-tempest-plugin/+/755876/32/designate_tempest_plugin/tests/scenario/v2/test_split_horizon.py#105","commit_id":"69f9fcce4cb1a6df1b33f158fe4f80d24a3a4c28"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"2c8c87ce48af67a8e2d48d32167cd0bcd9d7407b","unresolved":true,"context_lines":[{"line_number":79,"context_line":"                recordset_data \u003d data_utils.rand_aaaa_recordset("},{"line_number":80,"context_line":"                    cls.zone[\u0027name\u0027], ip\u003d\u0027bb65:272:d768:368f\u0027"},{"line_number":81,"context_line":"                    \u0027:ff54:2e08:e4e7:8877\u0027)"},{"line_number":82,"context_line":"            _, recordset \u003d cls.recordset_client.create_recordset("},{"line_number":83,"context_line":"                cls.zone[\u0027id\u0027], recordset_data)"},{"line_number":84,"context_line":"            cls.addClassResourceCleanup("},{"line_number":85,"context_line":"                test_utils.call_and_ignore_notfound_exc,"},{"line_number":86,"context_line":"                cls.recordset_client.delete_recordset,"}],"source_content_type":"text/x-python","patch_set":32,"id":"2e3d9cda_31f2304d","line":83,"range":{"start_line":82,"start_character":0,"end_line":83,"end_character":47},"updated":"2021-07-06 16:38:38.000000000","message":"Nit: we are trying to avoid using \"throwaway variables\" in code and to use indexing instead, for example the same could be done with:\n\nrecordset \u003d cls.recordset_client.create_recordset(\n    cls.zone[\u0027id\u0027], recordset_data)[1]","commit_id":"69f9fcce4cb1a6df1b33f158fe4f80d24a3a4c28"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"2c8c87ce48af67a8e2d48d32167cd0bcd9d7407b","unresolved":true,"context_lines":[{"line_number":97,"context_line":"        if not CONF.dns_feature_enabled.split_horizon:"},{"line_number":98,"context_line":"            return"},{"line_number":99,"context_line":"        LOG.info(\u0027Create a new zone\u0027)"},{"line_number":100,"context_line":"        _, zone \u003d cls.client.create_zone()"},{"line_number":101,"context_line":"        cls.addClassResourceCleanup("},{"line_number":102,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":103,"context_line":"            cls.client.delete_zone, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":32,"id":"ffa1ec8f_5c84428e","line":100,"range":{"start_line":100,"start_character":8,"end_line":100,"end_character":42},"updated":"2021-07-06 16:38:38.000000000","message":"Same as in #83","commit_id":"69f9fcce4cb1a6df1b33f158fe4f80d24a3a4c28"}]}