)]}'
{"designate_tempest_plugin/tests/api/v2/test_recordset.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4c47b5aaa79533407e29e36848a431bd2f81a3d2","unresolved":true,"context_lines":[{"line_number":496,"context_line":"                        self.zone_client,"},{"line_number":497,"context_line":"                        zone[\u0027id\u0027])"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        # Create recordset for zone \"A\""},{"line_number":500,"context_line":"        recordset_data \u003d data_utils.rand_recordset_data("},{"line_number":501,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":502,"context_line":"        LOG.info(\u0027Create a Recordset\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a2807c7_f3367d79","line":499,"updated":"2021-03-04 21:53:30.000000000","message":"This could be enhanced to check the negative case as well. If you created a zone and recordset using the alt credential, then this would test that this call *only* returns the recordsets for the project ID in the os_primary credential.","commit_id":"1a05fbe02fb57f91f479573d8909769c9549ded5"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3c91c1bd1997dddca2eb55b7d9239a351499e358","unresolved":true,"context_lines":[{"line_number":496,"context_line":"                        self.zone_client,"},{"line_number":497,"context_line":"                        zone[\u0027id\u0027])"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        # Create recordset for zone \"A\""},{"line_number":500,"context_line":"        recordset_data \u003d data_utils.rand_recordset_data("},{"line_number":501,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":502,"context_line":"        LOG.info(\u0027Create a Recordset\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"2572e3d6_0f991f96","line":499,"in_reply_to":"3a2807c7_f3367d79","updated":"2021-03-05 19:20:41.000000000","message":"I think that this negative case is already covered in L515.\nIf for some reason project_ids_api (type:set) will include more than one member or not expected \"id\"it will fail the test.","commit_id":"1a05fbe02fb57f91f479573d8909769c9549ded5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4c47b5aaa79533407e29e36848a431bd2f81a3d2","unresolved":true,"context_lines":[{"line_number":570,"context_line":"                \u0027 for all projects {} \u0027.format(prj_id, project_ids_api))"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    @decorators.idempotent_id(\u0027910eb17e-7c3a-11eb-a40b-74e5f9e2a801\u0027)"},{"line_number":573,"context_line":"    def test_user_to_impersonate_another_project(self):"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        # Create zone \"A\" and save used project_id"},{"line_number":576,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"f2c2589d_8e050d65","line":573,"updated":"2021-03-04 21:53:30.000000000","message":"This test name is not clear what it is testing. I.e. in the subunit test results html page this will not tell reviewers what the test is for.\nMaybe: test_list_recordsets_impersonate_project ?\n\nClear names help us know if the failure is related to the patch under test or maybe just needs a recheck due to an unrelated issue.","commit_id":"1a05fbe02fb57f91f479573d8909769c9549ded5"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3c91c1bd1997dddca2eb55b7d9239a351499e358","unresolved":true,"context_lines":[{"line_number":570,"context_line":"                \u0027 for all projects {} \u0027.format(prj_id, project_ids_api))"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    @decorators.idempotent_id(\u0027910eb17e-7c3a-11eb-a40b-74e5f9e2a801\u0027)"},{"line_number":573,"context_line":"    def test_user_to_impersonate_another_project(self):"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        # Create zone \"A\" and save used project_id"},{"line_number":576,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"67f76c3b_119f7c8e","line":573,"in_reply_to":"f2c2589d_8e050d65","updated":"2021-03-05 19:20:41.000000000","message":"Will be fixed","commit_id":"1a05fbe02fb57f91f479573d8909769c9549ded5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4c47b5aaa79533407e29e36848a431bd2f81a3d2","unresolved":true,"context_lines":[{"line_number":579,"context_line":"                        self.zone_client,"},{"line_number":580,"context_line":"                        zone[\u0027id\u0027])"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        # Create a recordsets for zone \"A\""},{"line_number":583,"context_line":"        recordset_data \u003d data_utils.rand_recordset_data("},{"line_number":584,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":585,"context_line":"        LOG.info(\u0027Create a Recordset\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"97d41666_4b3d56eb","line":582,"updated":"2021-03-04 21:53:30.000000000","message":"Same here, if you create zone \"B\" with the alt credentials here you can confirm that the below checks only return the \"sudo-project-id\" recordsets.","commit_id":"1a05fbe02fb57f91f479573d8909769c9549ded5"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3c91c1bd1997dddca2eb55b7d9239a351499e358","unresolved":true,"context_lines":[{"line_number":579,"context_line":"                        self.zone_client,"},{"line_number":580,"context_line":"                        zone[\u0027id\u0027])"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        # Create a recordsets for zone \"A\""},{"line_number":583,"context_line":"        recordset_data \u003d data_utils.rand_recordset_data("},{"line_number":584,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":585,"context_line":"        LOG.info(\u0027Create a Recordset\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"b571804d_ecfb8731","line":582,"in_reply_to":"97d41666_4b3d56eb","updated":"2021-03-05 19:20:41.000000000","message":"Covered in L611","commit_id":"1a05fbe02fb57f91f479573d8909769c9549ded5"}]}