)]}'
{"designate_tempest_plugin/services/dns/v2/json/zones_client.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"7805ca199873551e2066789d026af730e022c885","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @base.handle_errors"},{"line_number":25,"context_line":"    def create_zone(self, name\u003dNone, email\u003dNone, ttl\u003dNone, description\u003dTrue,"},{"line_number":26,"context_line":"                    wait_until\u003dFalse, params\u003dNone, use_random\u003dNone):"},{"line_number":27,"context_line":"        \"\"\"Create a zone with the specified parameters."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param name: The name of the zone."}],"source_content_type":"text/x-python","patch_set":1,"id":"a43cb0ea_4f34bcf3","line":26,"updated":"2021-03-15 19:33:10.000000000","message":"This should default to False right? With the current default and description I read it as use_random can provide a random value as well.","commit_id":"aa87767bbf87a74e820055eb057d6ecd2a2bd2cf"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0f9564383235c3babc4838f9efee40327087d433","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @base.handle_errors"},{"line_number":25,"context_line":"    def create_zone(self, name\u003dNone, email\u003dNone, ttl\u003dNone, description\u003dTrue,"},{"line_number":26,"context_line":"                    wait_until\u003dFalse, params\u003dNone, use_random\u003dNone):"},{"line_number":27,"context_line":"        \"\"\"Create a zone with the specified parameters."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param name: The name of the zone."}],"source_content_type":"text/x-python","patch_set":1,"id":"e024f225_23071062","line":26,"in_reply_to":"29f0aafa_ea6f3753","updated":"2021-03-15 19:36:27.000000000","message":"Yes, it should be False thanks!!!\nGoing to fix that now.","commit_id":"aa87767bbf87a74e820055eb057d6ecd2a2bd2cf"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"aa1012826484d212919ea56b78f3a9310ce1b056","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @base.handle_errors"},{"line_number":25,"context_line":"    def create_zone(self, name\u003dNone, email\u003dNone, ttl\u003dNone, description\u003dTrue,"},{"line_number":26,"context_line":"                    wait_until\u003dFalse, params\u003dNone, use_random\u003dNone):"},{"line_number":27,"context_line":"        \"\"\"Create a zone with the specified parameters."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param name: The name of the zone."}],"source_content_type":"text/x-python","patch_set":1,"id":"29f0aafa_ea6f3753","line":26,"in_reply_to":"a43cb0ea_4f34bcf3","updated":"2021-03-15 19:34:23.000000000","message":"*can take a random value as well.","commit_id":"aa87767bbf87a74e820055eb057d6ecd2a2bd2cf"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"cdbcb2882c3d66d5cdee68681a14193288e64464","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @base.handle_errors"},{"line_number":25,"context_line":"    def create_zone(self, name\u003dNone, email\u003dNone, ttl\u003dNone, description\u003dTrue,"},{"line_number":26,"context_line":"                    wait_until\u003dFalse, params\u003dNone, use_random\u003dNone):"},{"line_number":27,"context_line":"        \"\"\"Create a zone with the specified parameters."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param name: The name of the zone."}],"source_content_type":"text/x-python","patch_set":1,"id":"ff44e194_2e1cbe79","line":26,"in_reply_to":"e024f225_23071062","updated":"2021-03-15 19:42:15.000000000","message":"Should be True by default :)","commit_id":"aa87767bbf87a74e820055eb057d6ecd2a2bd2cf"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"e7bf9c0539bc2ca155bc42d3a75d28bf761d5e31","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @base.handle_errors"},{"line_number":25,"context_line":"    def create_zone(self, name\u003dNone, email\u003dNone, ttl\u003dNone, description\u003dTrue,"},{"line_number":26,"context_line":"                    wait_until\u003dFalse, params\u003dNone, use_random\u003dNone):"},{"line_number":27,"context_line":"        \"\"\"Create a zone with the specified parameters."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param name: The name of the zone."}],"source_content_type":"text/x-python","patch_set":1,"id":"defce78f_0d7cf093","line":26,"in_reply_to":"ff44e194_2e1cbe79","updated":"2021-03-15 19:45:10.000000000","message":"Done","commit_id":"aa87767bbf87a74e820055eb057d6ecd2a2bd2cf"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"74eab84695bcf9dbd821c495c89f8fe069b666c2","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    \"\"\"API V2 Tempest REST client for Designate API\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @base.handle_errors"},{"line_number":25,"context_line":"    def create_zone(self, name\u003dNone, email\u003dNone, ttl\u003dNone, description\u003dTrue,"},{"line_number":26,"context_line":"                    wait_until\u003dFalse, params\u003dNone, use_random\u003dTrue):"},{"line_number":27,"context_line":"        \"\"\"Create a zone with the specified parameters."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3898ef72_aa4a7847","line":25,"range":{"start_line":25,"start_character":71,"end_line":25,"end_character":75},"updated":"2021-04-23 22:51:55.000000000","message":"Changing this to True will mean you can no longer have None as the default, so the random string will not be generated right?","commit_id":"ceb57b465e8679630293a60f0187e9c9b06cecc7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9c5afd0b8dc6b3d9c9351758265f8772bf34d448","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\"API V2 Tempest REST client for Designate API\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @base.handle_errors"},{"line_number":25,"context_line":"    def create_zone(self, name\u003dNone, email\u003dNone, ttl\u003dNone, description\u003dTrue,"},{"line_number":26,"context_line":"                    wait_until\u003dFalse, params\u003dNone, use_random\u003dTrue):"},{"line_number":27,"context_line":"        \"\"\"Create a zone with the specified parameters."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0a26a071_8001aa6a","line":25,"range":{"start_line":25,"start_character":71,"end_line":25,"end_character":75},"in_reply_to":"3898ef72_aa4a7847","updated":"2021-04-26 11:59:38.000000000","message":"Done","commit_id":"ceb57b465e8679630293a60f0187e9c9b06cecc7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"74eab84695bcf9dbd821c495c89f8fe069b666c2","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        \"\"\"Create a zone with the specified parameters."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param name: The name of the zone."},{"line_number":30,"context_line":"            Default: Random Value"},{"line_number":31,"context_line":"        :param email: The email for the zone."},{"line_number":32,"context_line":"            Default: Random Value"},{"line_number":33,"context_line":"        :param ttl: The ttl for the zone."}],"source_content_type":"text/x-python","patch_set":2,"id":"96a8d3d1_7fa3c1be","line":30,"range":{"start_line":30,"start_character":12,"end_line":30,"end_character":33},"updated":"2021-04-23 22:51:55.000000000","message":"These comments don\u0027t seem to apply any longer as the default will depend on the \"use_random\" setting which could be false.","commit_id":"ceb57b465e8679630293a60f0187e9c9b06cecc7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9c5afd0b8dc6b3d9c9351758265f8772bf34d448","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \"\"\"Create a zone with the specified parameters."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param name: The name of the zone."},{"line_number":30,"context_line":"            Default: Random Value"},{"line_number":31,"context_line":"        :param email: The email for the zone."},{"line_number":32,"context_line":"            Default: Random Value"},{"line_number":33,"context_line":"        :param ttl: The ttl for the zone."}],"source_content_type":"text/x-python","patch_set":2,"id":"642a46ed_0f4ab14c","line":30,"range":{"start_line":30,"start_character":12,"end_line":30,"end_character":33},"in_reply_to":"96a8d3d1_7fa3c1be","updated":"2021-04-26 11:59:38.000000000","message":"Done","commit_id":"ceb57b465e8679630293a60f0187e9c9b06cecc7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"74eab84695bcf9dbd821c495c89f8fe069b666c2","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        :param wait_until: Block until the zone reaches the desiered status"},{"line_number":38,"context_line":"        :param params: A Python dict that represents the query paramaters to"},{"line_number":39,"context_line":"                       include in the request URI."},{"line_number":40,"context_line":"        :param use_random: If True, default random values will be generated"},{"line_number":41,"context_line":"                           when no value has been provided by caller, else"},{"line_number":42,"context_line":"                           provided values will be used as is."},{"line_number":43,"context_line":"        :return: A tuple with the server response and the created zone."}],"source_content_type":"text/x-python","patch_set":2,"id":"a4225e2d_bc2ee595","line":40,"updated":"2021-04-23 22:51:55.000000000","message":"Just so I\u0027m clear, this change is to allow passing \"None\" into the create call, correct?\nI don\u0027t see None used in the tests in this patch, so I\u0027m not sure I understand why this needed to change.","commit_id":"ceb57b465e8679630293a60f0187e9c9b06cecc7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9c5afd0b8dc6b3d9c9351758265f8772bf34d448","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        :param wait_until: Block until the zone reaches the desiered status"},{"line_number":38,"context_line":"        :param params: A Python dict that represents the query paramaters to"},{"line_number":39,"context_line":"                       include in the request URI."},{"line_number":40,"context_line":"        :param use_random: If True, default random values will be generated"},{"line_number":41,"context_line":"                           when no value has been provided by caller, else"},{"line_number":42,"context_line":"                           provided values will be used as is."},{"line_number":43,"context_line":"        :return: A tuple with the server response and the created zone."}],"source_content_type":"text/x-python","patch_set":2,"id":"e9e05c7a_47818bd3","line":40,"in_reply_to":"a4225e2d_bc2ee595","updated":"2021-04-26 11:59:38.000000000","message":"Done","commit_id":"ceb57b465e8679630293a60f0187e9c9b06cecc7"}],"designate_tempest_plugin/tests/api/v2/test_zones_negative.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"74eab84695bcf9dbd821c495c89f8fe069b666c2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Hewlett Packard Enterprise Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"5881a17b_8227381b","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":69},"updated":"2021-04-23 22:51:55.000000000","message":"I don\u0027t think this is correct.","commit_id":"ceb57b465e8679630293a60f0187e9c9b06cecc7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9c5afd0b8dc6b3d9c9351758265f8772bf34d448","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Hewlett Packard Enterprise Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"a83b0430_9a54c511","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":69},"in_reply_to":"5881a17b_8227381b","updated":"2021-04-26 11:59:38.000000000","message":"Done","commit_id":"ceb57b465e8679630293a60f0187e9c9b06cecc7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"74eab84695bcf9dbd821c495c89f8fe069b666c2","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class BaseZonesTest(base.BaseDnsV2Test):"},{"line_number":26,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ZonesNegativeTest(BaseZonesTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"d88c239f_b35a23b1","line":26,"range":{"start_line":26,"start_character":30,"end_line":26,"end_character":37},"updated":"2021-04-23 22:51:55.000000000","message":"Is admin used here? I\u0027m not seeing it.","commit_id":"ceb57b465e8679630293a60f0187e9c9b06cecc7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9c5afd0b8dc6b3d9c9351758265f8772bf34d448","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class BaseZonesTest(base.BaseDnsV2Test):"},{"line_number":26,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ZonesNegativeTest(BaseZonesTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"2bc41cdb_a48a4d21","line":26,"range":{"start_line":26,"start_character":30,"end_line":26,"end_character":37},"in_reply_to":"d88c239f_b35a23b1","updated":"2021-04-26 11:59:38.000000000","message":"Done","commit_id":"ceb57b465e8679630293a60f0187e9c9b06cecc7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"74eab84695bcf9dbd821c495c89f8fe069b666c2","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027551853c0-8593-11eb-8c8a-74e5f9e2a801\u0027)"},{"line_number":71,"context_line":"    def test_no_valid_ttl(self):"},{"line_number":72,"context_line":"        no_valid_tls \u003d [\u0027zahlabut\u0027, -60000, 0, \u0027\u0027]"},{"line_number":73,"context_line":"        for ttl in no_valid_tls:"},{"line_number":74,"context_line":"            LOG.info("},{"line_number":75,"context_line":"                \u0027Trying to create a zone using: {} as TTL\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"31da1b60_3bfb355c","line":72,"updated":"2021-04-23 22:51:55.000000000","message":"Per the RFC (https://tools.ietf.org/html/rfc2181 section 8) 0 is a valid TTL and we should check that number larger than 2147483647 is invalid.","commit_id":"ceb57b465e8679630293a60f0187e9c9b06cecc7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9c5afd0b8dc6b3d9c9351758265f8772bf34d448","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027551853c0-8593-11eb-8c8a-74e5f9e2a801\u0027)"},{"line_number":71,"context_line":"    def test_no_valid_ttl(self):"},{"line_number":72,"context_line":"        no_valid_tls \u003d [\u0027zahlabut\u0027, -60000, 0, \u0027\u0027]"},{"line_number":73,"context_line":"        for ttl in no_valid_tls:"},{"line_number":74,"context_line":"            LOG.info("},{"line_number":75,"context_line":"                \u0027Trying to create a zone using: {} as TTL\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"e1cdf6d0_7149ef04","line":72,"in_reply_to":"31da1b60_3bfb355c","updated":"2021-04-26 11:59:38.000000000","message":"Done","commit_id":"ceb57b465e8679630293a60f0187e9c9b06cecc7"}]}