)]}'
{"designate_tempest_plugin/clients.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2f1b6b654946715f09d779b634f7fe812bcac0ef","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    import TsigkeyClient"},{"line_number":50,"context_line":"from designate_tempest_plugin.services.dns.v2.json.service_client \\"},{"line_number":51,"context_line":"    import SevriceClient"},{"line_number":52,"context_line":"from designate_tempest_plugin.services.dns.v2.json.ptr_client import PtrClient"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":8,"id":"09bda0f9_069ddaaa","line":52,"updated":"2021-05-06 19:03:03.000000000","message":"This patch is going to merge conflict again with https://review.opendev.org/c/openstack/designate-tempest-plugin/+/780871\nIt would be best to make this part of a chain with the other patch.","commit_id":"d346e648a83ab9aad9a1797cd226179f08230206"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2f1b6b654946715f09d779b634f7fe812bcac0ef","unresolved":true,"context_lines":[{"line_number":50,"context_line":"from designate_tempest_plugin.services.dns.v2.json.service_client \\"},{"line_number":51,"context_line":"    import SevriceClient"},{"line_number":52,"context_line":"from designate_tempest_plugin.services.dns.v2.json.ptr_client import PtrClient"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"CONF \u003d config.CONF"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"c4542e4a_6844afa9","line":53,"updated":"2021-05-06 19:03:03.000000000","message":"Nit: this extra line isn\u0027t needed here.","commit_id":"d346e648a83ab9aad9a1797cd226179f08230206"}],"designate_tempest_plugin/services/dns/v2/json/ptr_client.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e591c5cf7ea1afb06c726812dfd74980361bacac","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2021 RedHat|IBM"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"9237c44b_2c022c67","line":1,"range":{"start_line":1,"start_character":1,"end_line":1,"end_character":27},"updated":"2021-04-27 17:47:46.000000000","message":"This is probably not right, check with your internal company policies.","commit_id":"fe2e02c420013466c105ac0f22c30bb7e965e0b3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"311280ddae5dda426eb8468736ba6beea7bca4a0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2021 RedHat|IBM"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"4e6d5e53_1cdb698f","line":1,"range":{"start_line":1,"start_character":1,"end_line":1,"end_character":27},"in_reply_to":"9237c44b_2c022c67","updated":"2021-04-27 19:57:08.000000000","message":"Done","commit_id":"fe2e02c420013466c105ac0f22c30bb7e965e0b3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e591c5cf7ea1afb06c726812dfd74980361bacac","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        :param ttl TTL or random valid value if not provided."},{"line_number":34,"context_line":"        :param description Description or random if not provided."},{"line_number":35,"context_line":"        :param headers (dict): The headers to use for the request."},{"line_number":36,"context_line":"        :param use_random if False, PTR record\u0027s values will be"},{"line_number":37,"context_line":"               used as is, valid random values won\u0027t be created."},{"line_number":38,"context_line":"        :return: created PTR dictionary."},{"line_number":39,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"b8e13e79_6b4c58a9","line":36,"range":{"start_line":36,"start_character":15,"end_line":36,"end_character":26},"updated":"2021-04-27 17:47:46.000000000","message":"Do we need this or can we simplify it like we did the other client?\nI don\u0027t think we need \"use_random\"","commit_id":"fe2e02c420013466c105ac0f22c30bb7e965e0b3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"311280ddae5dda426eb8468736ba6beea7bca4a0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        :param ttl TTL or random valid value if not provided."},{"line_number":34,"context_line":"        :param description Description or random if not provided."},{"line_number":35,"context_line":"        :param headers (dict): The headers to use for the request."},{"line_number":36,"context_line":"        :param use_random if False, PTR record\u0027s values will be"},{"line_number":37,"context_line":"               used as is, valid random values won\u0027t be created."},{"line_number":38,"context_line":"        :return: created PTR dictionary."},{"line_number":39,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"e7dbb5b9_1c95f6ed","line":36,"range":{"start_line":36,"start_character":15,"end_line":36,"end_character":26},"in_reply_to":"b8e13e79_6b4c58a9","updated":"2021-04-27 19:57:08.000000000","message":"Done","commit_id":"fe2e02c420013466c105ac0f22c30bb7e965e0b3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e591c5cf7ea1afb06c726812dfd74980361bacac","unresolved":true,"context_lines":[{"line_number":87,"context_line":"            uuid\u003dfloatingip_id, data\u003ddata, headers\u003dheaders,"},{"line_number":88,"context_line":"            uuid_prefix_char\u003d\u0027:\u0027)"},{"line_number":89,"context_line":"        # Unset PTR should Return a HTTP 202"},{"line_number":90,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":91,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":5,"id":"c3a89c82_df2249b4","line":90,"updated":"2021-04-27 17:47:46.000000000","message":"Generally I don\u0027t like tests in the clients as it limits your ability to run negative tests.\nTo me it is better to do this kind of check in the test itself.\nHow can you check a 403 or 404 expected response in a test?","commit_id":"fe2e02c420013466c105ac0f22c30bb7e965e0b3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"311280ddae5dda426eb8468736ba6beea7bca4a0","unresolved":true,"context_lines":[{"line_number":87,"context_line":"            uuid\u003dfloatingip_id, data\u003ddata, headers\u003dheaders,"},{"line_number":88,"context_line":"            uuid_prefix_char\u003d\u0027:\u0027)"},{"line_number":89,"context_line":"        # Unset PTR should Return a HTTP 202"},{"line_number":90,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":91,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":5,"id":"076dcf86_ce775918","line":90,"in_reply_to":"c3a89c82_df2249b4","updated":"2021-04-27 19:57:08.000000000","message":"Agree, bu this is according the convention we have in Designate.\nI think that the \"handle_errors\" decorator is responsible to do the job.\nAnyway, I\u0027ve added a test: \"test_set_floatingip_ptr_invalid_ttl\" that validates 400 BadRequest without any problem.","commit_id":"fe2e02c420013466c105ac0f22c30bb7e965e0b3"}],"designate_tempest_plugin/tests/api/v2/test_ptrs.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e591c5cf7ea1afb06c726812dfd74980361bacac","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2021 RedHat|IBM"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"91c3eb45_598ae9e2","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":27},"updated":"2021-04-27 17:47:46.000000000","message":"This is probably not right, check with your internal company policies.","commit_id":"fe2e02c420013466c105ac0f22c30bb7e965e0b3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"311280ddae5dda426eb8468736ba6beea7bca4a0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2021 RedHat|IBM"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"edaeae6c_f39524a5","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":27},"in_reply_to":"91c3eb45_598ae9e2","updated":"2021-04-27 19:57:08.000000000","message":"Done","commit_id":"fe2e02c420013466c105ac0f22c30bb7e965e0b3"}]}