)]}'
{"designate_tempest_plugin/tests/api/v2/test_zones.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"22b705bb47871722a0603382ca5291e433b998f4","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        cls.alt_client \u003d cls.os_alt.zones_client"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @decorators.idempotent_id(\u0027f6fe8cce-8b04-11eb-a861-74e5f9e2a801\u0027)"},{"line_number":139,"context_line":"    def test_impersonate_another_project(self):"},{"line_number":140,"context_line":"        LOG.info(\u0027Create zone \"A\" using primary client\u0027)"},{"line_number":141,"context_line":"        zone \u003d self.client.create_zone()[1]"},{"line_number":142,"context_line":"        self.addCleanup(self.wait_zone_delete, self.client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"b6895d82_c6393320","line":139,"range":{"start_line":139,"start_character":8,"end_line":139,"end_character":40},"updated":"2021-04-23 22:33:21.000000000","message":"Can we make this test title more descriptive?\nI don\u0027t know what action this is testing.","commit_id":"7c035f42d62343683a7d5e0551405e746c081700"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"e1a011e3a558dcab9b241cfe4076004c25667570","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        cls.alt_client \u003d cls.os_alt.zones_client"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @decorators.idempotent_id(\u0027f6fe8cce-8b04-11eb-a861-74e5f9e2a801\u0027)"},{"line_number":139,"context_line":"    def test_impersonate_another_project(self):"},{"line_number":140,"context_line":"        LOG.info(\u0027Create zone \"A\" using primary client\u0027)"},{"line_number":141,"context_line":"        zone \u003d self.client.create_zone()[1]"},{"line_number":142,"context_line":"        self.addCleanup(self.wait_zone_delete, self.client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"e23884e1_1e92e820","line":139,"range":{"start_line":139,"start_character":8,"end_line":139,"end_character":40},"in_reply_to":"b6895d82_c6393320","updated":"2021-04-25 17:39:58.000000000","message":"Done","commit_id":"7c035f42d62343683a7d5e0551405e746c081700"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"22b705bb47871722a0603382ca5291e433b998f4","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        LOG.info(\u0027As admin user impersonate another project\u0027)"},{"line_number":145,"context_line":"        body \u003d self.admin_client.show_zone("},{"line_number":146,"context_line":"            uuid\u003dNone, headers\u003d{"},{"line_number":147,"context_line":"                \u0027x-auth-sudo-project-id\u0027: zone[\u0027project_id\u0027]})[1]"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        LOG.info(\u0027Ensure the fetched response matches the impersonated\u0027"},{"line_number":150,"context_line":"                 \u0027 project, it means the ID of zone \"A\"\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff456973_7c50437e","line":147,"updated":"2021-04-23 22:33:21.000000000","message":"We could add a negative test here to show you get 404 if you do not use the sudo header.","commit_id":"7c035f42d62343683a7d5e0551405e746c081700"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"e1a011e3a558dcab9b241cfe4076004c25667570","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        LOG.info(\u0027As admin user impersonate another project\u0027)"},{"line_number":145,"context_line":"        body \u003d self.admin_client.show_zone("},{"line_number":146,"context_line":"            uuid\u003dNone, headers\u003d{"},{"line_number":147,"context_line":"                \u0027x-auth-sudo-project-id\u0027: zone[\u0027project_id\u0027]})[1]"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        LOG.info(\u0027Ensure the fetched response matches the impersonated\u0027"},{"line_number":150,"context_line":"                 \u0027 project, it means the ID of zone \"A\"\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7fb1c309_4ab81ada","line":147,"in_reply_to":"ff456973_7c50437e","updated":"2021-04-25 17:39:58.000000000","message":"Done","commit_id":"7c035f42d62343683a7d5e0551405e746c081700"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"22b705bb47871722a0603382ca5291e433b998f4","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        created_zone_ids.append(zone[\u0027id\u0027])"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        LOG.info(\u0027As admin user list all projects zones\u0027)"},{"line_number":173,"context_line":"        body \u003d self.admin_client.show_zone("},{"line_number":174,"context_line":"            uuid\u003dNone, headers\u003d{"},{"line_number":175,"context_line":"                \u0027x-auth-all-projects\u0027: True})[1][\u0027zones\u0027]"},{"line_number":176,"context_line":"        listed_zone_ids \u003d [item[\u0027id\u0027] for item in body]"}],"source_content_type":"text/x-python","patch_set":3,"id":"cd79d517_7ef872f6","line":173,"range":{"start_line":173,"start_character":33,"end_line":173,"end_character":42},"updated":"2021-04-23 22:33:21.000000000","message":"This is calling show, not list_zone.","commit_id":"7c035f42d62343683a7d5e0551405e746c081700"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"e1a011e3a558dcab9b241cfe4076004c25667570","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        created_zone_ids.append(zone[\u0027id\u0027])"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        LOG.info(\u0027As admin user list all projects zones\u0027)"},{"line_number":173,"context_line":"        body \u003d self.admin_client.show_zone("},{"line_number":174,"context_line":"            uuid\u003dNone, headers\u003d{"},{"line_number":175,"context_line":"                \u0027x-auth-all-projects\u0027: True})[1][\u0027zones\u0027]"},{"line_number":176,"context_line":"        listed_zone_ids \u003d [item[\u0027id\u0027] for item in body]"}],"source_content_type":"text/x-python","patch_set":3,"id":"55039db3_d7a2b187","line":173,"range":{"start_line":173,"start_character":33,"end_line":173,"end_character":42},"in_reply_to":"cd79d517_7ef872f6","updated":"2021-04-25 17:39:58.000000000","message":"Done","commit_id":"7c035f42d62343683a7d5e0551405e746c081700"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e681bc7aaf1dfb2fd32515572eda3fda26b62a34","unresolved":true,"context_lines":[{"line_number":145,"context_line":"        LOG.info(\u0027As Alt tenant show zone created by Primary tenant. \u0027"},{"line_number":146,"context_line":"                 \u0027Expected: 404 NotFound\u0027)"},{"line_number":147,"context_line":"        self.assertRaises("},{"line_number":148,"context_line":"            lib_exc.NotFound, self.alt_client.show_zone, uuid\u003dzone[\u0027id\u0027])"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        LOG.info(\u0027As Alt tenant show zone created by Primary tenant using \u0027"},{"line_number":151,"context_line":"                 \u0027\"x-auth-sudo-project-id\" HTTP header. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"8b0f516f_8c5e31ba","line":148,"range":{"start_line":148,"start_character":35,"end_line":148,"end_character":45},"updated":"2021-04-26 21:57:16.000000000","message":"This is a valid test as well, but I was thinking of an additional test with the admin client attempting to show the zone without the sudo header.","commit_id":"da9564ab3c04595df5e3385c1dfd681e48002580"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6eccc87e25d10c57a1a380af94099f2656b8dad1","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        LOG.info(\u0027As Alt tenant show zone created by Primary tenant. \u0027"},{"line_number":146,"context_line":"                 \u0027Expected: 404 NotFound\u0027)"},{"line_number":147,"context_line":"        self.assertRaises("},{"line_number":148,"context_line":"            lib_exc.NotFound, self.alt_client.show_zone, uuid\u003dzone[\u0027id\u0027])"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        LOG.info(\u0027As Alt tenant show zone created by Primary tenant using \u0027"},{"line_number":151,"context_line":"                 \u0027\"x-auth-sudo-project-id\" HTTP header. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"64eef0f5_975230ad","line":148,"range":{"start_line":148,"start_character":35,"end_line":148,"end_character":45},"in_reply_to":"8b0f516f_8c5e31ba","updated":"2021-04-27 09:07:03.000000000","message":"Done","commit_id":"da9564ab3c04595df5e3385c1dfd681e48002580"}]}
