)]}'
{"designate_tempest_plugin/tests/api/v2/test_zones_imports.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"25d54f778e19f552c41107fbc0a17a2201307bec","unresolved":true,"context_lines":[{"line_number":71,"context_line":"            zonefile_data\u003ddns_data_utils.rand_zonefile_data(ttl\u003d\u0027zahlabut\u0027))[1]"},{"line_number":72,"context_line":"        self.addCleanup(self.clean_up_resources, zone_import[\u0027id\u0027])"},{"line_number":73,"context_line":"        self.assertEqual("},{"line_number":74,"context_line":"            \u0027ERROR\u0027,"},{"line_number":75,"context_line":"            self.client.show_zone_import(zone_import[\u0027id\u0027])[1][\u0027status\u0027],"},{"line_number":76,"context_line":"            \u0027Failed, expected status is: ERROR\u0027)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"56b4c676_493965d7","line":74,"range":{"start_line":74,"start_character":12,"end_line":74,"end_character":19},"updated":"2021-04-23 22:27:16.000000000","message":"We should consider creating a constants file for these strings.\nIt will ensure consistency, save some RAM, and speed up the tests (ever so slightly).","commit_id":"1de1a12b1b0738ad3d321dfe08eb91f72708425b"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6316bfec56dff83971f6e403127c7f93d7d32d99","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            zonefile_data\u003ddns_data_utils.rand_zonefile_data(ttl\u003d\u0027zahlabut\u0027))[1]"},{"line_number":72,"context_line":"        self.addCleanup(self.clean_up_resources, zone_import[\u0027id\u0027])"},{"line_number":73,"context_line":"        self.assertEqual("},{"line_number":74,"context_line":"            \u0027ERROR\u0027,"},{"line_number":75,"context_line":"            self.client.show_zone_import(zone_import[\u0027id\u0027])[1][\u0027status\u0027],"},{"line_number":76,"context_line":"            \u0027Failed, expected status is: ERROR\u0027)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7acf4533_99ce1538","line":74,"range":{"start_line":74,"start_character":12,"end_line":74,"end_character":19},"in_reply_to":"56b4c676_493965d7","updated":"2021-04-25 11:56:22.000000000","message":"Done","commit_id":"1de1a12b1b0738ad3d321dfe08eb91f72708425b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"25d54f778e19f552c41107fbc0a17a2201307bec","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @decorators.idempotent_id(\u002731eaf25a-9532-11eb-a55d-74e5f9e2a801\u0027)"},{"line_number":79,"context_line":"    def test_create_zone_import_invalid_name(self):"},{"line_number":80,"context_line":"        LOG.info(\u0027Try to create a zone import using invalid TTL value\u0027)"},{"line_number":81,"context_line":"        zone_import \u003d self.client.create_zone_import("},{"line_number":82,"context_line":"            zonefile_data\u003ddns_data_utils.rand_zonefile_data(name\u003d\u0027@@@\u0027))[1]"},{"line_number":83,"context_line":"        self.addCleanup(self.clean_up_resources, zone_import[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"f2cae1f3_44e9762b","line":80,"range":{"start_line":80,"start_character":59,"end_line":80,"end_character":64},"updated":"2021-04-23 22:27:16.000000000","message":"TTL -\u003e name","commit_id":"1de1a12b1b0738ad3d321dfe08eb91f72708425b"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6316bfec56dff83971f6e403127c7f93d7d32d99","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @decorators.idempotent_id(\u002731eaf25a-9532-11eb-a55d-74e5f9e2a801\u0027)"},{"line_number":79,"context_line":"    def test_create_zone_import_invalid_name(self):"},{"line_number":80,"context_line":"        LOG.info(\u0027Try to create a zone import using invalid TTL value\u0027)"},{"line_number":81,"context_line":"        zone_import \u003d self.client.create_zone_import("},{"line_number":82,"context_line":"            zonefile_data\u003ddns_data_utils.rand_zonefile_data(name\u003d\u0027@@@\u0027))[1]"},{"line_number":83,"context_line":"        self.addCleanup(self.clean_up_resources, zone_import[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"b4383a7f_a3a4ebc6","line":80,"range":{"start_line":80,"start_character":59,"end_line":80,"end_character":64},"in_reply_to":"f2cae1f3_44e9762b","updated":"2021-04-25 11:56:22.000000000","message":"Done","commit_id":"1de1a12b1b0738ad3d321dfe08eb91f72708425b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"25d54f778e19f552c41107fbc0a17a2201307bec","unresolved":true,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        LOG.info(\u0027Re-Fetch the zone import with Admin client\u0027)"},{"line_number":143,"context_line":"        resp_body \u003d self.admin_client.show_zone_import(uuid\u003dNone, headers\u003d{"},{"line_number":144,"context_line":"                \u0027x-auth-sudo-project-id\u0027: primary_project_id})[1]"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        LOG.info(\u0027Ensure the fetched response matches the expected one\u0027)"},{"line_number":147,"context_line":"        self.assertExpected("}],"source_content_type":"text/x-python","patch_set":3,"id":"d9d6ef12_5574a7b3","line":144,"updated":"2021-04-23 22:27:16.000000000","message":"Bonus points if we add a negative case here, show the zone without the sudo header and confirm it comes back 404.","commit_id":"1de1a12b1b0738ad3d321dfe08eb91f72708425b"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6316bfec56dff83971f6e403127c7f93d7d32d99","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        LOG.info(\u0027Re-Fetch the zone import with Admin client\u0027)"},{"line_number":143,"context_line":"        resp_body \u003d self.admin_client.show_zone_import(uuid\u003dNone, headers\u003d{"},{"line_number":144,"context_line":"                \u0027x-auth-sudo-project-id\u0027: primary_project_id})[1]"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        LOG.info(\u0027Ensure the fetched response matches the expected one\u0027)"},{"line_number":147,"context_line":"        self.assertExpected("}],"source_content_type":"text/x-python","patch_set":3,"id":"56996ef1_a60c301f","line":144,"in_reply_to":"d9d6ef12_5574a7b3","updated":"2021-04-25 11:56:22.000000000","message":"Done","commit_id":"1de1a12b1b0738ad3d321dfe08eb91f72708425b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"25d54f778e19f552c41107fbc0a17a2201307bec","unresolved":true,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        LOG.info(\u0027As admin user list import zones for all projects\u0027)"},{"line_number":157,"context_line":"        body \u003d self.admin_client.list_zone_imports(headers\u003d{"},{"line_number":158,"context_line":"                \u0027x-auth-all-projects\u0027: True})[1][\u0027imports\u0027]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        LOG.info(\u0027Ensure the fetched response includes previously \u0027"},{"line_number":161,"context_line":"                 \u0027created import ID\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ec257935_fb0a6eb5","line":158,"updated":"2021-04-23 22:27:16.000000000","message":"Same here, we could expand this to check that without the all-projects header, we get no imports.","commit_id":"1de1a12b1b0738ad3d321dfe08eb91f72708425b"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6316bfec56dff83971f6e403127c7f93d7d32d99","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        LOG.info(\u0027As admin user list import zones for all projects\u0027)"},{"line_number":157,"context_line":"        body \u003d self.admin_client.list_zone_imports(headers\u003d{"},{"line_number":158,"context_line":"                \u0027x-auth-all-projects\u0027: True})[1][\u0027imports\u0027]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        LOG.info(\u0027Ensure the fetched response includes previously \u0027"},{"line_number":161,"context_line":"                 \u0027created import ID\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"950479fe_591c9918","line":158,"in_reply_to":"ec257935_fb0a6eb5","updated":"2021-04-25 11:56:22.000000000","message":"Done","commit_id":"1de1a12b1b0738ad3d321dfe08eb91f72708425b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6bdb584163784ff37951b21c4531d93718297813","unresolved":true,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        LOG.info(\u0027Show a zone import for a Primary tenant, using Admin \u0027"},{"line_number":160,"context_line":"                 \u0027tenant and \"x-auth-sudo-project-id\" HTTP header.\u0027)"},{"line_number":161,"context_line":"        resp_body \u003d self.admin_client.show_zone_import(uuid\u003dNone, headers\u003d{"},{"line_number":162,"context_line":"                \u0027x-auth-sudo-project-id\u0027: zone_import[\u0027project_id\u0027]})[1]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        LOG.info(\u0027Ensure that the shown response matches the expected one\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ea1f7d1e_1195668a","line":161,"updated":"2021-04-26 22:07:15.000000000","message":"I still think it might be nice to test with admin_client but without sudo project_id, it should 404.","commit_id":"0c7ff1636503064290c39954eafbad4fc63fb1ea"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"17393d86278ba4090cd5885a09edc2bc877a9203","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        LOG.info(\u0027Show a zone import for a Primary tenant, using Admin \u0027"},{"line_number":160,"context_line":"                 \u0027tenant and \"x-auth-sudo-project-id\" HTTP header.\u0027)"},{"line_number":161,"context_line":"        resp_body \u003d self.admin_client.show_zone_import(uuid\u003dNone, headers\u003d{"},{"line_number":162,"context_line":"                \u0027x-auth-sudo-project-id\u0027: zone_import[\u0027project_id\u0027]})[1]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        LOG.info(\u0027Ensure that the shown response matches the expected one\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"27881d2f_4720761d","line":161,"in_reply_to":"ea1f7d1e_1195668a","updated":"2021-04-27 08:54:52.000000000","message":"Done","commit_id":"0c7ff1636503064290c39954eafbad4fc63fb1ea"}]}