)]}'
{"designate_tempest_plugin/tests/api/v2/test_zones_exports.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f7d2fbbf56d6eca67d9b488e91a998b14fc036ad","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    def test_create_zone_export_using_invalid_zone_id(self):"},{"line_number":64,"context_line":"        self.assertRaises("},{"line_number":65,"context_line":"            lib_exc.NotFound, self.client.create_zone_export,"},{"line_number":66,"context_line":"            str(uuid.uuid1()))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @decorators.attr(type\u003d\u0027smoke\u0027)"},{"line_number":69,"context_line":"    @decorators.idempotent_id(\u00272d29a2a9-1941-4b7e-9d8a-ad6c2140ea68\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"8361d69d_6990acac","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":29},"updated":"2021-04-07 22:49:11.000000000","message":"Do we need to make these calls or can we just use a static string \"FAKE\" or \"NOT_A_ZONE\"?\n\nThis would avoid the uuid module import and save two calls.","commit_id":"290c5df896a731914bc9f1763bc24799aeb083d0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0d7113754d86501272b61a3cceb11ff1b67ee359","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    def test_create_zone_export_using_invalid_zone_id(self):"},{"line_number":64,"context_line":"        self.assertRaises("},{"line_number":65,"context_line":"            lib_exc.NotFound, self.client.create_zone_export,"},{"line_number":66,"context_line":"            str(uuid.uuid1()))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @decorators.attr(type\u003d\u0027smoke\u0027)"},{"line_number":69,"context_line":"    @decorators.idempotent_id(\u00272d29a2a9-1941-4b7e-9d8a-ad6c2140ea68\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"db2b1ba3_05a42432","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":29},"in_reply_to":"8361d69d_6990acac","updated":"2021-04-08 08:44:23.000000000","message":"Actually this is what I\u0027ve tried to do before using uuid module, but then the received Error was about invalid UUID string and this is not what I wanted to cover.\nI\u0027ll remove UUID module and will use a string of generated VALID uuid instead.","commit_id":"290c5df896a731914bc9f1763bc24799aeb083d0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f7d2fbbf56d6eca67d9b488e91a998b14fc036ad","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        resp, zone_export \u003d self.client.create_zone_export(zone[\u0027id\u0027])"},{"line_number":93,"context_line":"        self.addCleanup(self.client.delete_zone_export, zone_export[\u0027id\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        LOG.info(\u0027Impersonate \"admin\" client, to show created zone exports\u0027)"},{"line_number":96,"context_line":"        body \u003d self.admin_client.show_zone_export(uuid\u003dNone, headers\u003d{"},{"line_number":97,"context_line":"            \u0027x-auth-sudo-project-id\u0027: zone[\u0027project_id\u0027]})[1][\u0027exports\u0027]"},{"line_number":98,"context_line":"        listed_export_ids \u003d [item[\u0027id\u0027] for item in body]"}],"source_content_type":"text/x-python","patch_set":3,"id":"51b387f8_bba8d82f","line":95,"range":{"start_line":95,"start_character":30,"end_line":95,"end_character":37},"updated":"2021-04-07 22:49:11.000000000","message":"This is impersonating the \"primary\" right?","commit_id":"290c5df896a731914bc9f1763bc24799aeb083d0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0d7113754d86501272b61a3cceb11ff1b67ee359","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        resp, zone_export \u003d self.client.create_zone_export(zone[\u0027id\u0027])"},{"line_number":93,"context_line":"        self.addCleanup(self.client.delete_zone_export, zone_export[\u0027id\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        LOG.info(\u0027Impersonate \"admin\" client, to show created zone exports\u0027)"},{"line_number":96,"context_line":"        body \u003d self.admin_client.show_zone_export(uuid\u003dNone, headers\u003d{"},{"line_number":97,"context_line":"            \u0027x-auth-sudo-project-id\u0027: zone[\u0027project_id\u0027]})[1][\u0027exports\u0027]"},{"line_number":98,"context_line":"        listed_export_ids \u003d [item[\u0027id\u0027] for item in body]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ec26c295_674c5eb7","line":95,"range":{"start_line":95,"start_character":30,"end_line":95,"end_character":37},"in_reply_to":"51b387f8_bba8d82f","updated":"2021-04-08 08:44:23.000000000","message":"Yep,good catch this is definitely should be primary.\nWill be fixed.","commit_id":"290c5df896a731914bc9f1763bc24799aeb083d0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f7d2fbbf56d6eca67d9b488e91a998b14fc036ad","unresolved":true,"context_lines":[{"line_number":178,"context_line":"            primary_zone[\u0027id\u0027])"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    @decorators.idempotent_id(\u0027518dc308-9604-11eb-b1cd-74e5f9e2a801\u0027)"},{"line_number":181,"context_line":"    def test_create_zone_export_using_not_existing_zone_id(self):"},{"line_number":182,"context_line":"        LOG.info(\u0027Create a zone\u0027)"},{"line_number":183,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"},{"line_number":184,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"33f7160c_a07dc135","line":181,"range":{"start_line":181,"start_character":8,"end_line":181,"end_character":58},"updated":"2021-04-07 22:49:11.000000000","message":"This test description seems similar to the test \"test_create_zone_export_using_invalid_zone_id\", maybe we should update this to say \"deleted zone\"?","commit_id":"290c5df896a731914bc9f1763bc24799aeb083d0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0d7113754d86501272b61a3cceb11ff1b67ee359","unresolved":true,"context_lines":[{"line_number":178,"context_line":"            primary_zone[\u0027id\u0027])"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    @decorators.idempotent_id(\u0027518dc308-9604-11eb-b1cd-74e5f9e2a801\u0027)"},{"line_number":181,"context_line":"    def test_create_zone_export_using_not_existing_zone_id(self):"},{"line_number":182,"context_line":"        LOG.info(\u0027Create a zone\u0027)"},{"line_number":183,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"},{"line_number":184,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"38100c0d_b26805d2","line":181,"range":{"start_line":181,"start_character":8,"end_line":181,"end_character":58},"in_reply_to":"33f7160c_a07dc135","updated":"2021-04-08 08:44:23.000000000","message":"Will be changed to: test_create_zone_export_using_deleted_zone","commit_id":"290c5df896a731914bc9f1763bc24799aeb083d0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f7d2fbbf56d6eca67d9b488e91a998b14fc036ad","unresolved":true,"context_lines":[{"line_number":193,"context_line":"            lib_exc.NotFound, self.client.create_zone_export, zone[\u0027id\u0027])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    @decorators.idempotent_id(\u00278d851e64-9619-11eb-b1cd-74e5f9e2a801\u0027)"},{"line_number":196,"context_line":"    def test_list_zone_exports_filter_results(self):"},{"line_number":197,"context_line":"        # Create zone export for primary and alt clients and delete them"},{"line_number":198,"context_line":"        # Use admin client to filter the results by status or name"},{"line_number":199,"context_line":"        # Expected: listed result should match used filter."}],"source_content_type":"text/x-python","patch_set":3,"id":"52eefcae_3f632ddc","line":196,"range":{"start_line":196,"start_character":8,"end_line":196,"end_character":45},"updated":"2021-04-07 22:49:11.000000000","message":"I\u0027m not sure how to filter on the \"message\" field, but maybe add a \"zone_id\" filter test here?","commit_id":"290c5df896a731914bc9f1763bc24799aeb083d0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0d7113754d86501272b61a3cceb11ff1b67ee359","unresolved":true,"context_lines":[{"line_number":193,"context_line":"            lib_exc.NotFound, self.client.create_zone_export, zone[\u0027id\u0027])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    @decorators.idempotent_id(\u00278d851e64-9619-11eb-b1cd-74e5f9e2a801\u0027)"},{"line_number":196,"context_line":"    def test_list_zone_exports_filter_results(self):"},{"line_number":197,"context_line":"        # Create zone export for primary and alt clients and delete them"},{"line_number":198,"context_line":"        # Use admin client to filter the results by status or name"},{"line_number":199,"context_line":"        # Expected: listed result should match used filter."}],"source_content_type":"text/x-python","patch_set":3,"id":"463e9d17_c74cf9f8","line":196,"range":{"start_line":196,"start_character":8,"end_line":196,"end_character":45},"in_reply_to":"52eefcae_3f632ddc","updated":"2021-04-08 08:44:23.000000000","message":"I\u0027ve tried to use all possible fields option given in documentation we have: zone_id, message, status.\nNon of them seems to be worked, it\u0027s always responds with a full list of values, but that list is expected to be empty basing on used filter.","commit_id":"290c5df896a731914bc9f1763bc24799aeb083d0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f7d2fbbf56d6eca67d9b488e91a998b14fc036ad","unresolved":true,"context_lines":[{"line_number":206,"context_line":"        self.client.delete_zone_export(primary_export[\u0027id\u0027])"},{"line_number":207,"context_line":"        LOG.info(\u0027Ensure the zone export has been successfully deleted\u0027)"},{"line_number":208,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":209,"context_line":"            lambda: self.client.show_zone_export(primary_export[\u0027id\u0027]))"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        LOG.info(\u0027Create an alt zone, its export and delete it\u0027)"},{"line_number":212,"context_line":"        alt_zone \u003d self.alt_zone_client.create_zone()[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"852b27a5_5e75db04","line":209,"updated":"2021-04-07 22:49:11.000000000","message":"It seems like this is testing functionality outside the scope of this test case.\nWe should try to make sure the test case is only testing the exact functionality and not additional features.\nIt just makes the tests run longer and duplicates test scenarios.","commit_id":"290c5df896a731914bc9f1763bc24799aeb083d0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0d7113754d86501272b61a3cceb11ff1b67ee359","unresolved":true,"context_lines":[{"line_number":206,"context_line":"        self.client.delete_zone_export(primary_export[\u0027id\u0027])"},{"line_number":207,"context_line":"        LOG.info(\u0027Ensure the zone export has been successfully deleted\u0027)"},{"line_number":208,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":209,"context_line":"            lambda: self.client.show_zone_export(primary_export[\u0027id\u0027]))"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        LOG.info(\u0027Create an alt zone, its export and delete it\u0027)"},{"line_number":212,"context_line":"        alt_zone \u003d self.alt_zone_client.create_zone()[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"c4c00dbd_a6c0f19a","line":209,"in_reply_to":"852b27a5_5e75db04","updated":"2021-04-08 08:44:23.000000000","message":"The purpose of the test was to filter all \"zone exports\" with the status DELETED (assuming that this is a proper string to filter that), so we need to be 100% sure that those \"exports\" have been actually delete and this is why we need to wait to see it happens.","commit_id":"290c5df896a731914bc9f1763bc24799aeb083d0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f7d2fbbf56d6eca67d9b488e91a998b14fc036ad","unresolved":true,"context_lines":[{"line_number":213,"context_line":"        self.addCleanup("},{"line_number":214,"context_line":"            self.wait_zone_delete, self.alt_zone_client, alt_zone[\u0027id\u0027])"},{"line_number":215,"context_line":"        alt_export \u003d self.alt_client.create_zone_export(alt_zone[\u0027id\u0027])[1]"},{"line_number":216,"context_line":"        self.alt_client.delete_zone_export(alt_export[\u0027id\u0027])"},{"line_number":217,"context_line":"        LOG.info(\u0027Ensure the zone export has been successfully deleted\u0027)"},{"line_number":218,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":219,"context_line":"            lambda: self.alt_client.show_zone_export(alt_export[\u0027id\u0027]))"}],"source_content_type":"text/x-python","patch_set":3,"id":"28a50b9e_ae828057","line":216,"updated":"2021-04-07 22:49:11.000000000","message":"What value does the delete add here? Why are both deleted?\nYou should be able to test list of zone exports without needing the extra call to delete the zone.","commit_id":"290c5df896a731914bc9f1763bc24799aeb083d0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0d7113754d86501272b61a3cceb11ff1b67ee359","unresolved":true,"context_lines":[{"line_number":213,"context_line":"        self.addCleanup("},{"line_number":214,"context_line":"            self.wait_zone_delete, self.alt_zone_client, alt_zone[\u0027id\u0027])"},{"line_number":215,"context_line":"        alt_export \u003d self.alt_client.create_zone_export(alt_zone[\u0027id\u0027])[1]"},{"line_number":216,"context_line":"        self.alt_client.delete_zone_export(alt_export[\u0027id\u0027])"},{"line_number":217,"context_line":"        LOG.info(\u0027Ensure the zone export has been successfully deleted\u0027)"},{"line_number":218,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":219,"context_line":"            lambda: self.alt_client.show_zone_export(alt_export[\u0027id\u0027]))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f721350_494eb7ac","line":216,"in_reply_to":"28a50b9e_ae828057","updated":"2021-04-08 08:44:23.000000000","message":"I\u0027d expect to get 2 DELETED \"zone export\", one of alt and on of primary in filtered by (status DELETES) in list output result, it could be done with only one client, I mean only primary or alt, but I (as QE) prefer to have 2 filtered values.","commit_id":"290c5df896a731914bc9f1763bc24799aeb083d0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f7d2fbbf56d6eca67d9b488e91a998b14fc036ad","unresolved":true,"context_lines":[{"line_number":219,"context_line":"            lambda: self.alt_client.show_zone_export(alt_export[\u0027id\u0027]))"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        self.assertEqual("},{"line_number":222,"context_line":"            0, self.admin_client.list_zone_exports("},{"line_number":223,"context_line":"                headers\u003d{\u0027x-auth-all-projects\u0027: True},"},{"line_number":224,"context_line":"                params\u003d{\u0027status\u0027: \u0027ZAHLABUT\u0027})[1][\u0027exports\u0027],"},{"line_number":225,"context_line":"            \u0027Failed, filtered result is expected to be empty.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"860ef63e_4f4bc513","line":222,"updated":"2021-04-07 22:49:11.000000000","message":"So, this assertion is not valid.\n\nThe list_zone_exports call will always return a list, which will never be equal to an integer of 0.\nA proper test would check assertEqual([], list_zone_exports())","commit_id":"290c5df896a731914bc9f1763bc24799aeb083d0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0d7113754d86501272b61a3cceb11ff1b67ee359","unresolved":true,"context_lines":[{"line_number":219,"context_line":"            lambda: self.alt_client.show_zone_export(alt_export[\u0027id\u0027]))"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        self.assertEqual("},{"line_number":222,"context_line":"            0, self.admin_client.list_zone_exports("},{"line_number":223,"context_line":"                headers\u003d{\u0027x-auth-all-projects\u0027: True},"},{"line_number":224,"context_line":"                params\u003d{\u0027status\u0027: \u0027ZAHLABUT\u0027})[1][\u0027exports\u0027],"},{"line_number":225,"context_line":"            \u0027Failed, filtered result is expected to be empty.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3313d573_25e0fef4","line":222,"in_reply_to":"860ef63e_4f4bc513","updated":"2021-04-08 08:44:23.000000000","message":"Yep, my bad I had to use \"len\" or empty list as you\u0027ve mentioned, thanks!","commit_id":"290c5df896a731914bc9f1763bc24799aeb083d0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1d22f5ba2a50874b21ca4d5c92d66db05abdac83","unresolved":true,"context_lines":[{"line_number":165,"context_line":"                \u0027listed IDs:{}\u0027.format(id, listed_exports_ids))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    @decorators.idempotent_id(\u0027943dad4a-9617-11eb-b1cd-74e5f9e2a801\u0027)"},{"line_number":168,"context_line":"    def test_export_not_yours_zone(self):"},{"line_number":169,"context_line":"        LOG.info(\u0027Create a primary zone.\u0027)"},{"line_number":170,"context_line":"        primary_zone \u003d self.zone_client.create_zone()[1]"},{"line_number":171,"context_line":"        self.addCleanup("}],"source_content_type":"text/x-python","patch_set":5,"id":"ff4ebbe5_a817603a","line":168,"range":{"start_line":168,"start_character":24,"end_line":168,"end_character":29},"updated":"2021-04-23 22:12:04.000000000","message":"nit: yours-\u003eyour","commit_id":"db055fff6631a70c88d2a3ab2b15072c3163f169"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"b5b39913d557ce763a72484758bd76d26e9f84e8","unresolved":true,"context_lines":[{"line_number":165,"context_line":"                \u0027listed IDs:{}\u0027.format(id, listed_exports_ids))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    @decorators.idempotent_id(\u0027943dad4a-9617-11eb-b1cd-74e5f9e2a801\u0027)"},{"line_number":168,"context_line":"    def test_export_not_yours_zone(self):"},{"line_number":169,"context_line":"        LOG.info(\u0027Create a primary zone.\u0027)"},{"line_number":170,"context_line":"        primary_zone \u003d self.zone_client.create_zone()[1]"},{"line_number":171,"context_line":"        self.addCleanup("}],"source_content_type":"text/x-python","patch_set":5,"id":"a39893fb_1f7d4568","line":168,"range":{"start_line":168,"start_character":24,"end_line":168,"end_character":29},"in_reply_to":"ff4ebbe5_a817603a","updated":"2021-04-25 08:43:11.000000000","message":"done 😂","commit_id":"db055fff6631a70c88d2a3ab2b15072c3163f169"}]}