)]}'
{"designate_tempest_plugin/tests/api/v2/test_transfer_request.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e8c42c80f9e45f5b503f384caa7e3a2d394458b0","unresolved":true,"context_lines":[{"line_number":123,"context_line":"        LOG.info(\u0027Fetch the transfer_request\u0027)"},{"line_number":124,"context_line":"        body \u003d self.admin_client.show_transfer_request("},{"line_number":125,"context_line":"            transfer_request[\u0027id\u0027],"},{"line_number":126,"context_line":"            headers\u003d{\u0027x-auth-sudo-project-id\u0027: zone[\u0027project_id\u0027]})[1]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        LOG.info(\u0027Ensure the fetched response matches the \u0027"},{"line_number":129,"context_line":"                 \u0027created transfer_request\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b52562b2_49e16233","line":126,"updated":"2021-04-27 22:07:30.000000000","message":"Same pattern here, we could also validate that not specifying the project ID header returns 404.","commit_id":"40d6ea28ef69ee767b73f32bfa6bc2fa7aa84e1a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e8c42c80f9e45f5b503f384caa7e3a2d394458b0","unresolved":true,"context_lines":[{"line_number":215,"context_line":"        LOG.info(\u0027List transfer_requests for all projects using Admin client\u0027)"},{"line_number":216,"context_line":"        request_ids \u003d ["},{"line_number":217,"context_line":"            item[\u0027id\u0027] for item in self.admin_client.list_transfer_requests("},{"line_number":218,"context_line":"                headers\u003d{\u0027x-auth-all-projects\u0027: True})[1][\u0027transfer_requests\u0027]]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        for request_id in [primary_transfer_request[\u0027id\u0027],"},{"line_number":221,"context_line":"                           alt_transfer_request[\u0027id\u0027]]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"8607edb1_21ffc34d","line":218,"updated":"2021-04-27 22:07:30.000000000","message":"Same, we could add a test for list without all-projects to expect [].","commit_id":"40d6ea28ef69ee767b73f32bfa6bc2fa7aa84e1a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"60a02b0d9f1109fdcd1361c27b0d499999e93439","unresolved":true,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        LOG.info(\u0027List transfer_requests for all projects using Admin tenant \u0027"},{"line_number":223,"context_line":"                 \u0027without \"x-auth-all-projects\" HTTP header. Expected: 404\u0027)"},{"line_number":224,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":225,"context_line":"                          lambda: self.admin_client.list_transfer_requests())"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        LOG.info(\u0027List transfer_requests for all projects using Admin tenant \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3c914acd_aa25e6d5","line":224,"updated":"2021-04-28 17:15:18.000000000","message":"As I mentioned in my comment, \"list\" calls will always return a list, in this case it will be an empty list \"[]\". So this check should not be 404, but instead that the result is an empty list.","commit_id":"756eae0807d32ec677d02346cfa2a2bf97e8546d"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"8b3754670b9119b075aaf8b0cbdab410046fc5e3","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        LOG.info(\u0027List transfer_requests for all projects using Admin tenant \u0027"},{"line_number":223,"context_line":"                 \u0027without \"x-auth-all-projects\" HTTP header. Expected: 404\u0027)"},{"line_number":224,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":225,"context_line":"                          lambda: self.admin_client.list_transfer_requests())"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        LOG.info(\u0027List transfer_requests for all projects using Admin tenant \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"c08d6eab_1c8e3bf0","line":224,"in_reply_to":"3c914acd_aa25e6d5","updated":"2021-04-29 08:23:01.000000000","message":"Done","commit_id":"756eae0807d32ec677d02346cfa2a2bf97e8546d"}]}