)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"35d8e0ce1b9c3f0aaeaf58de94f5463e3729ce64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"fdf20cd3_e79887ad","updated":"2021-10-29 19:51:00.000000000","message":"A few minor items here.","commit_id":"fdd7700b66b57e715c2f9a9867b3a03809da819a"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"8de6adf78571dedc4d9af46e4416ad1042bd7f9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"03b6bbb1_ffbf2b58","updated":"2021-10-25 15:55:06.000000000","message":"recheck","commit_id":"fdd7700b66b57e715c2f9a9867b3a03809da819a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c1f48c2fab80c95c7732f6608068d79cda77681a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"75b07e05_dd8a2156","updated":"2021-11-25 16:26:36.000000000","message":"We need to keep the Negative tests in dedicated classes so that we can exclude them in certain jobs","commit_id":"9fc43523a71c28c087b2b347fd2a76239718c5fc"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4d5ba30946848785abec3dd8386b18c00e6dad33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"1f291fea_e3e8235b","updated":"2021-11-14 10:19:06.000000000","message":"recheck","commit_id":"9fc43523a71c28c087b2b347fd2a76239718c5fc"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"12bfac24da207032ee327478a05da2936b6895ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"5cefec81_20b30386","in_reply_to":"75b07e05_dd8a2156","updated":"2021-11-25 18:18:44.000000000","message":"Done","commit_id":"9fc43523a71c28c087b2b347fd2a76239718c5fc"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"60e8f044fbe981435eade9bc3466c82f0eb820ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"97b66187_438e1744","updated":"2021-11-28 07:35:00.000000000","message":"I think we need a way to run only tests without expected errors in order to be able to find real errors in the logs. The idea would be to run with *Negative* excluded first, and stop there, if an issue occurs. For this to work we need all tests that produce expected errors marked as such.","commit_id":"1a29a3160cee1edfcf4905051a67cb070a92d070"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"069ec5f285971a60c879529d70c66ef40adbcd29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"c24c43e6_2be9592e","updated":"2021-12-05 11:14:11.000000000","message":"Dr.Jens - hoping that everything looks good to you now, may I ask you (as a core) to review/score and maybe trigger workflow +1 to get this patch finally merged?","commit_id":"b8ea4cafc8a82f9ba3ff5839575a7b53343bf3b1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2a151656854f116099f4a7533369bc336375709b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"16e012f6_f4360367","updated":"2021-12-01 17:20:41.000000000","message":"Hmm, o.k., maybe it was just bad luck.","commit_id":"b8ea4cafc8a82f9ba3ff5839575a7b53343bf3b1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0f02bc53ad59588ebd0cc11171fa4a489cce5a31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"f2db43f3_29795795","updated":"2021-12-02 00:21:54.000000000","message":"It looks like this patch has a better track record that we are having without it, so I\u0027m willing to +2 it. I would have preferred the fix to be a separate patch from the adding new tests.","commit_id":"b8ea4cafc8a82f9ba3ff5839575a7b53343bf3b1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b2ad5a6b8d6065f9ba109ce8d3410ac4c073f8a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"07b9e681_38069677","updated":"2021-12-01 10:13:17.000000000","message":"The failures in https://zuul.opendev.org/t/openstack/build/5826c4dd967440a0bdceddec8478f2bc were for two of the new tests, which makes me think that they are not as stable as we might wish for.\n\nSeeing also the recent discussion in IRC about possibly deprecating the PTR API, maybe only patch the existing tests and leave adding new tests as a step to be done once we have stable testing again? Or agree that we do not need to test deprecated features so intensely?","commit_id":"b8ea4cafc8a82f9ba3ff5839575a7b53343bf3b1"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"26622746c8bc9f85ec491982d9558fed3e54b893","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"0177b4f6_d289df4a","updated":"2021-12-01 11:09:27.000000000","message":"recheck","commit_id":"b8ea4cafc8a82f9ba3ff5839575a7b53343bf3b1"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"820d8df437bd7f54e87a32a6298ccd156102edd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"0a0658b5_4fcb6aa9","updated":"2021-12-01 07:37:36.000000000","message":"recheck","commit_id":"b8ea4cafc8a82f9ba3ff5839575a7b53343bf3b1"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5b03b0cdce79780c4da2a4533c3392096498d362","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"6054da97_c60cebcf","updated":"2021-12-01 12:55:44.000000000","message":"recheck","commit_id":"b8ea4cafc8a82f9ba3ff5839575a7b53343bf3b1"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9feb067435bface0962d673e7b36ebd7e4219085","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"d3a08ee3_3f87847e","updated":"2021-12-01 09:22:06.000000000","message":"recheck","commit_id":"b8ea4cafc8a82f9ba3ff5839575a7b53343bf3b1"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"e31e358ffba6bc07310babcc5409f65055a7aa44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"dacca171_7999ffad","updated":"2021-12-01 14:33:50.000000000","message":"recheck","commit_id":"b8ea4cafc8a82f9ba3ff5839575a7b53343bf3b1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"89bd3d11e41a940b761bbac6ada093b4a9bef4f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"de686782_5ebf2574","updated":"2021-11-30 17:55:06.000000000","message":"recheck\nGetting an additional run","commit_id":"b8ea4cafc8a82f9ba3ff5839575a7b53343bf3b1"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d87e4bc167a67fa4c1b8dc07b74eceda66e2ea5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"25a802f0_f065eae6","in_reply_to":"07b9e681_38069677","updated":"2021-12-01 11:34:01.000000000","message":"Dr.Jeans - do you know why \"504 timeout\" was reached on the Designate side? \n\nhttps://zuul.opendev.org/t/openstack/build/5826c4dd967440a0bdceddec8478f2bc:\n2021-11-30 18:58:06.430490 | controller |     Response - Headers: {\u0027date\u0027: \u0027Tue, 30 Nov 2021 18:57:05 GMT\u0027, \u0027server\u0027: \u0027Apache/2.4.41 (Ubuntu)\u0027, \u0027content-length\u0027: \u002790\u0027, \u0027x-openstack-request-id\u0027: \u0027req-8d3765d2-3e41-49f0-a1a2-6c3d6932987e\u0027, \u0027connection\u0027: \u0027close\u0027, \u0027content-type\u0027: \u0027application/json\u0027, \u0027status\u0027: \u0027504\u0027, \u0027content-location\u0027: \u0027http://10.209.0.40/dns/v2/reverse/floatingips/RegionOne:59773bf6-7eac-46e7-93e6-3e2a09ea81b0\u0027}\n2021-11-30 18:58:06.430534 | controller |         Body: b\u0027{\"code\": 504, \"type\": \"timeout\", \"request_id\": \"req-8d3765d2-3e41-49f0-a1a2-6c3d6932987e\"}\u0027\n\nI wasn\u0027t able to find something in Designate logs [1], maybe can you help with that?\n\nSorry, but I think that at this point we don\u0027t have enough details to get into the conclusion that the new tests are not stable.\n\nBTW - you could also see that I\u0027m \"rechecking\" this patch trying to understand the real status.\n\n[1] - https://zuul.opendev.org/t/openstack/build/5826c4dd967440a0bdceddec8478f2bc/artifacts (Download all logs)\n\nThanks!","commit_id":"b8ea4cafc8a82f9ba3ff5839575a7b53343bf3b1"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"969fd7aa3f8eaf059c5d9bb7f24f6b5c9ced7786","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"5a70dec7_157e6d73","in_reply_to":"16e012f6_f4360367","updated":"2021-12-01 17:22:39.000000000","message":"Yep, seems so.","commit_id":"b8ea4cafc8a82f9ba3ff5839575a7b53343bf3b1"}],"designate_tempest_plugin/data_utils.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"35d8e0ce1b9c3f0aaeaf58de94f5463e3729ce64","unresolved":true,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":"import random"},{"line_number":15,"context_line":"from random import choice"},{"line_number":16,"context_line":"from string import ascii_lowercase"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import netaddr"}],"source_content_type":"text/x-python","patch_set":22,"id":"fe992e5f_be2b88c6","line":15,"updated":"2021-10-29 19:51:00.000000000","message":"This isn\u0027t needed.","commit_id":"fdd7700b66b57e715c2f9a9867b3a03809da819a"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"cf3233ccda6abb2e2586e01a02de04ef879c491c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":"import random"},{"line_number":15,"context_line":"from random import choice"},{"line_number":16,"context_line":"from string import ascii_lowercase"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import netaddr"}],"source_content_type":"text/x-python","patch_set":22,"id":"ae029132_977f53b4","line":15,"in_reply_to":"fe992e5f_be2b88c6","updated":"2021-11-01 09:02:13.000000000","message":"Done","commit_id":"fdd7700b66b57e715c2f9a9867b3a03809da819a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"35d8e0ce1b9c3f0aaeaf58de94f5463e3729ce64","unresolved":true,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"def rand_string(size):"},{"line_number":267,"context_line":"    return \u0027\u0027.join(choice(ascii_lowercase) for _ in range(size))"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"def create_random_domain_name(tld\u003dNone):"}],"source_content_type":"text/x-python","patch_set":22,"id":"a3897831_82273884","line":267,"updated":"2021-10-29 19:51:00.000000000","message":"This can change to random.choice like the function below.","commit_id":"fdd7700b66b57e715c2f9a9867b3a03809da819a"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"cf3233ccda6abb2e2586e01a02de04ef879c491c","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"def rand_string(size):"},{"line_number":267,"context_line":"    return \u0027\u0027.join(choice(ascii_lowercase) for _ in range(size))"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"def create_random_domain_name(tld\u003dNone):"}],"source_content_type":"text/x-python","patch_set":22,"id":"fdb3cbbd_eb6579cc","line":267,"in_reply_to":"a3897831_82273884","updated":"2021-11-01 09:02:13.000000000","message":"Done","commit_id":"fdd7700b66b57e715c2f9a9867b3a03809da819a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"45725792e0f68eb509ba7b24cf5876afdb962fa4","unresolved":true,"context_lines":[{"line_number":262,"context_line":"    return func(zone_name)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"def rand_string(size):"},{"line_number":266,"context_line":"    return \u0027\u0027.join(random.choice(ascii_lowercase) for _ in range(size))"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"19c105cf_b6b16a3d","line":265,"updated":"2021-11-01 18:26:06.000000000","message":"A help string would seem useful","commit_id":"7c967f118217ee48ef6c7f14ceaa435e000de22e"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d5b344710af32bd0378675e5bfc06ff34307c54b","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    return func(zone_name)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"def rand_string(size):"},{"line_number":266,"context_line":"    return \u0027\u0027.join(random.choice(ascii_lowercase) for _ in range(size))"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"06bf06e0_eb604bb1","line":265,"in_reply_to":"19c105cf_b6b16a3d","updated":"2021-11-03 13:27:34.000000000","message":"Done","commit_id":"7c967f118217ee48ef6c7f14ceaa435e000de22e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"45725792e0f68eb509ba7b24cf5876afdb962fa4","unresolved":true,"context_lines":[{"line_number":266,"context_line":"    return \u0027\u0027.join(random.choice(ascii_lowercase) for _ in range(size))"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"def create_random_domain_name(tld\u003dNone):"},{"line_number":270,"context_line":"    domain_tld \u003d tld or random.choice(rand_string(3))"},{"line_number":271,"context_line":"    return rand_string(4) + \u0027.\u0027 + rand_string(6) + \u0027.\u0027 + domain_tld + \u0027.\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"69af8481_824162cf","line":269,"updated":"2021-11-01 18:26:06.000000000","message":"Can we keep the function name to be \"rand_domain_name\" for consistency? Also a help string would be nice","commit_id":"7c967f118217ee48ef6c7f14ceaa435e000de22e"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d5b344710af32bd0378675e5bfc06ff34307c54b","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    return \u0027\u0027.join(random.choice(ascii_lowercase) for _ in range(size))"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"def create_random_domain_name(tld\u003dNone):"},{"line_number":270,"context_line":"    domain_tld \u003d tld or random.choice(rand_string(3))"},{"line_number":271,"context_line":"    return rand_string(4) + \u0027.\u0027 + rand_string(6) + \u0027.\u0027 + domain_tld + \u0027.\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"0554942a_61db1e31","line":269,"in_reply_to":"69af8481_824162cf","updated":"2021-11-03 13:27:34.000000000","message":"Done","commit_id":"7c967f118217ee48ef6c7f14ceaa435e000de22e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"45725792e0f68eb509ba7b24cf5876afdb962fa4","unresolved":true,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"def create_random_domain_name(tld\u003dNone):"},{"line_number":270,"context_line":"    domain_tld \u003d tld or random.choice(rand_string(3))"},{"line_number":271,"context_line":"    return rand_string(4) + \u0027.\u0027 + rand_string(6) + \u0027.\u0027 + domain_tld + \u0027.\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"2e89f66a_cd725daf","line":270,"range":{"start_line":270,"start_character":24,"end_line":270,"end_character":53},"updated":"2021-11-01 18:26:06.000000000","message":"This chooses one char from a random 3-char-string? Just rand_string(3) would seem more useful.","commit_id":"7c967f118217ee48ef6c7f14ceaa435e000de22e"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d5b344710af32bd0378675e5bfc06ff34307c54b","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"def create_random_domain_name(tld\u003dNone):"},{"line_number":270,"context_line":"    domain_tld \u003d tld or random.choice(rand_string(3))"},{"line_number":271,"context_line":"    return rand_string(4) + \u0027.\u0027 + rand_string(6) + \u0027.\u0027 + domain_tld + \u0027.\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"1b355fc9_206f134a","line":270,"range":{"start_line":270,"start_character":24,"end_line":270,"end_character":53},"in_reply_to":"2e89f66a_cd725daf","updated":"2021-11-03 13:27:34.000000000","message":"Done","commit_id":"7c967f118217ee48ef6c7f14ceaa435e000de22e"}],"designate_tempest_plugin/services/dns/v2/json/ptr_client.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2d9b4aa741c78d43b8471497b2fe5b30b06eed03","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        ptr \u003d {"},{"line_number":38,"context_line":"            \u0027ptrdname\u0027: ptr_name or dns_data_utils.rand_zone_name("},{"line_number":39,"context_line":"                prefix\u003d\u0027test\u0027),"},{"line_number":40,"context_line":"            \u0027ttl\u0027: ttl or dns_data_utils.rand_ttl(),"},{"line_number":41,"context_line":"            \u0027description\u0027: description or data_utils.rand_name("},{"line_number":42,"context_line":"                \u0027test-ptr\u0027)}"}],"source_content_type":"text/x-python","patch_set":1,"id":"6424a1c5_ad443bca","line":39,"updated":"2021-06-04 07:05:04.000000000","message":"To me this is a bug in rand_zone_name. It shouldn\u0027t need an explicit prefix, the desc says the default prefix would be \"rand\" but instead it uses None. https://opendev.org/openstack/designate-tempest-plugin/src/branch/master/designate_tempest_plugin/data_utils.py#L40","commit_id":"858051d110639eb3922dcf40ebb2bbad6a97f3f8"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"eb5edd03f8c7eb32aa1655f83f33588dc1f726b5","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        ptr \u003d {"},{"line_number":38,"context_line":"            \u0027ptrdname\u0027: ptr_name or dns_data_utils.rand_zone_name("},{"line_number":39,"context_line":"                prefix\u003d\u0027test\u0027),"},{"line_number":40,"context_line":"            \u0027ttl\u0027: ttl or dns_data_utils.rand_ttl(),"},{"line_number":41,"context_line":"            \u0027description\u0027: description or data_utils.rand_name("},{"line_number":42,"context_line":"                \u0027test-ptr\u0027)}"}],"source_content_type":"text/x-python","patch_set":1,"id":"93a7b5a2_cea27e03","line":39,"in_reply_to":"6424a1c5_ad443bca","updated":"2021-06-04 11:47:12.000000000","message":"Good catch :-)\nThanks Jean, I\u0027ll fix that!","commit_id":"858051d110639eb3922dcf40ebb2bbad6a97f3f8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"45725792e0f68eb509ba7b24cf5876afdb962fa4","unresolved":true,"context_lines":[{"line_number":41,"context_line":"                tld), \u0027ttl\u0027: ttl or dns_data_utils.rand_ttl(),"},{"line_number":42,"context_line":"            \u0027description\u0027: description or data_utils.rand_name(\u0027test-ptr\u0027)}"},{"line_number":43,"context_line":"        if ptr_name \u003d\u003d \u0027\u0027:"},{"line_number":44,"context_line":"            ptr[\u0027ptrdname\u0027] \u003d \u0027\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        return self._update_request("},{"line_number":47,"context_line":"            resource\u003d\u0027reverse/floatingips/{}\u0027.format(CONF.identity.region),"}],"source_content_type":"text/x-python","patch_set":24,"id":"08688cfe_38d22cfc","line":44,"updated":"2021-11-01 18:26:06.000000000","message":"This logic is strange, you set a random name just to overwrite it again. Maybe leave ptrdname out of the above initialization and have an if/else here checking if ptr_name \u003d\u003d None.","commit_id":"7c967f118217ee48ef6c7f14ceaa435e000de22e"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d5b344710af32bd0378675e5bfc06ff34307c54b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                tld), \u0027ttl\u0027: ttl or dns_data_utils.rand_ttl(),"},{"line_number":42,"context_line":"            \u0027description\u0027: description or data_utils.rand_name(\u0027test-ptr\u0027)}"},{"line_number":43,"context_line":"        if ptr_name \u003d\u003d \u0027\u0027:"},{"line_number":44,"context_line":"            ptr[\u0027ptrdname\u0027] \u003d \u0027\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        return self._update_request("},{"line_number":47,"context_line":"            resource\u003d\u0027reverse/floatingips/{}\u0027.format(CONF.identity.region),"}],"source_content_type":"text/x-python","patch_set":24,"id":"97639c47_8551c4ca","line":44,"in_reply_to":"08688cfe_38d22cfc","updated":"2021-11-03 13:27:34.000000000","message":"Done","commit_id":"7c967f118217ee48ef6c7f14ceaa435e000de22e"}],"designate_tempest_plugin/tests/api/v2/test_ptrs.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"35d8e0ce1b9c3f0aaeaf58de94f5463e3729ce64","unresolved":true,"context_lines":[{"line_number":150,"context_line":"    @decorators.skip_because(bug\u003d\"1932026\")"},{"line_number":151,"context_line":"    def test_unset_floatingip_ptr(self):"},{"line_number":152,"context_line":"        fip_id, ptr \u003d self._set_ptr()"},{"line_number":153,"context_line":"        self.primary_ptr_client.unset_ptr_record(fip_id)"},{"line_number":154,"context_line":"        self._unset_ptr(fip_id)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @decorators.idempotent_id(\u00278392db50-cdd0-11eb-a00f-74e5f9e2a801\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"407f02fa_aa1cfc14","line":153,"updated":"2021-10-29 19:51:00.000000000","message":"This line is duplicate to the functional call _unset_ptr(), it could be removed.","commit_id":"fdd7700b66b57e715c2f9a9867b3a03809da819a"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"cf3233ccda6abb2e2586e01a02de04ef879c491c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    @decorators.skip_because(bug\u003d\"1932026\")"},{"line_number":151,"context_line":"    def test_unset_floatingip_ptr(self):"},{"line_number":152,"context_line":"        fip_id, ptr \u003d self._set_ptr()"},{"line_number":153,"context_line":"        self.primary_ptr_client.unset_ptr_record(fip_id)"},{"line_number":154,"context_line":"        self._unset_ptr(fip_id)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @decorators.idempotent_id(\u00278392db50-cdd0-11eb-a00f-74e5f9e2a801\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"64f5dda3_a5bc0d75","line":153,"in_reply_to":"407f02fa_aa1cfc14","updated":"2021-11-01 09:02:13.000000000","message":"Done","commit_id":"fdd7700b66b57e715c2f9a9867b3a03809da819a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"45725792e0f68eb509ba7b24cf5876afdb962fa4","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        self.primary_ptr_client.unset_ptr_record(fip_id)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class DesignatePtrRecordNegative(BasePtrTest, tempest.test.BaseTestCase):"},{"line_number":91,"context_line":"    credentials \u003d [\"primary\"]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":24,"id":"ad2ce397_7753290d","side":"PARENT","line":90,"updated":"2021-11-01 18:26:06.000000000","message":"What\u0027s the reason to drop this class?","commit_id":"09ca0a366b49bd7c6cc2f93f2b45b687448a8254"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"45725792e0f68eb509ba7b24cf5876afdb962fa4","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class DesignatePtrRecord(BasePtrTest, tempest.test.BaseTestCase):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":24,"id":"bcb060a1_8a2779ab","line":40,"updated":"2021-11-01 18:26:06.000000000","message":"I think it would be useful to keep the basic tests to be able to be run without an admin user, so I\u0027d prefer if you could place the tests that need admin into a new class.","commit_id":"7c967f118217ee48ef6c7f14ceaa435e000de22e"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d5b344710af32bd0378675e5bfc06ff34307c54b","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class DesignatePtrRecord(BasePtrTest, tempest.test.BaseTestCase):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":24,"id":"0e0cfeec_6ac8872a","line":40,"in_reply_to":"bcb060a1_8a2779ab","updated":"2021-11-03 13:27:34.000000000","message":"Agree, but the impact would be duplicating code because of 2 tests only, I would prefer not changing this particular class.","commit_id":"7c967f118217ee48ef6c7f14ceaa435e000de22e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"60e8f044fbe981435eade9bc3466c82f0eb820ab","unresolved":true,"context_lines":[{"line_number":95,"context_line":"                 \u0027 user, without including \"x-auth-sudo-project-id\" \u0027"},{"line_number":96,"context_line":"                 \u0027HTTP header in request.\u0027)"},{"line_number":97,"context_line":"        with self.assertRaisesDns(lib_exc.NotFound, \u0027not_found\u0027, 404):"},{"line_number":98,"context_line":"            self.admin_ptr_client.show_ptr_record(floatingip_id\u003dfip_id)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        LOG.info(\u0027As Admin user, show PTR record created by Primary\u0027"},{"line_number":101,"context_line":"                 \u0027 user by including \"x-auth-sudo-project-id\" HTTP header\u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"4ef29c79_ae51ea93","line":98,"updated":"2021-11-28 07:35:00.000000000","message":"I think this part of the test should also be moved into a negative test.","commit_id":"1a29a3160cee1edfcf4905051a67cb070a92d070"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"60e8f044fbe981435eade9bc3466c82f0eb820ab","unresolved":true,"context_lines":[{"line_number":132,"context_line":"        received_ptr_ids \u003d ["},{"line_number":133,"context_line":"            item[\u0027id\u0027] for item in self.admin_ptr_client.list_ptr_records()]"},{"line_number":134,"context_line":"        self.assertEqual([], received_ptr_ids,"},{"line_number":135,"context_line":"                         \u0027Failed, \"received_ptr_ids\" list should be empty\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        LOG.info(\u0027As Admin user, try to list PTR record for all projects \u0027"},{"line_number":138,"context_line":"                 \u0027by including \"x-auth-all-projects\" HTTP header.\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"d3d74da4_99e40e18","line":135,"updated":"2021-11-28 07:35:00.000000000","message":"Dito","commit_id":"1a29a3160cee1edfcf4905051a67cb070a92d070"}]}