)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7084ecb632e0d5f589e973d96cd6df51965f8add","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"02954b79_473d0012","updated":"2021-10-12 10:52:06.000000000","message":"recheck","commit_id":"9b908724089f48bc1b4784b71ff0d45a1529e526"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"901d56216361772584af47ab20d8fd8f92b450dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"67258588_5a2540ae","updated":"2021-10-12 16:20:56.000000000","message":"recheck","commit_id":"9b908724089f48bc1b4784b71ff0d45a1529e526"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"e0c6578dbdb3b472bfa28b06fa721de71dc71746","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a2901a75_56914edb","updated":"2021-10-12 14:17:13.000000000","message":"recheck","commit_id":"9b908724089f48bc1b4784b71ff0d45a1529e526"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"e5828d4600c0a89e2e98a038fc2a8eaa6ad99eca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b337924f_479856cb","updated":"2021-10-12 20:03:45.000000000","message":"recheck","commit_id":"9b908724089f48bc1b4784b71ff0d45a1529e526"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9e70ec948b37772d04f0e0de10ce1c07161e9db1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d3391b75_d9edec4a","updated":"2021-10-12 11:59:17.000000000","message":"recheck","commit_id":"9b908724089f48bc1b4784b71ff0d45a1529e526"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"cd860c799c8fae6b2a0649a67b15734872f27ee6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"054e26d1_c494815c","updated":"2021-10-13 11:28:42.000000000","message":"recheck","commit_id":"d8559a493ffa5b2118da196448d0770cdac8c5a6"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0692d25c5743119950ff2bdac2627b78b993a0b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ccc0db8b_7ead4f58","updated":"2021-10-13 10:02:38.000000000","message":"recheck","commit_id":"d8559a493ffa5b2118da196448d0770cdac8c5a6"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"8d0180bf4411da44105d421e4d7434cfcb3833c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d5e9aa8b_b76c151f","updated":"2021-10-13 08:19:53.000000000","message":"recheck","commit_id":"d8559a493ffa5b2118da196448d0770cdac8c5a6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b6f933b77811273e0258682f35083023f72cde6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"95b95261_48a05f8d","updated":"2021-10-28 17:07:00.000000000","message":"LGTM","commit_id":"5bfaa3f80bb7cdc355a622ad3cc1e38f6e678812"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9d3668619070e4a10eb45c2d596f791544959454","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a9eb5410_4665ccf7","updated":"2022-01-07 23:23:18.000000000","message":"There are some duplicate assertEqual here.","commit_id":"1caccadbb86e3bba93c7d414c702e8c9c4371123"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7a7b865b8cda390aafd0936369533225688d2939","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"60677836_f9a437b0","updated":"2021-12-12 14:24:55.000000000","message":"recheck","commit_id":"1caccadbb86e3bba93c7d414c702e8c9c4371123"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"27b2fec8da3bcb99922fd94ca93de36e441224b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a9ff63cb_97900c15","updated":"2021-11-11 09:32:30.000000000","message":"recheck","commit_id":"1caccadbb86e3bba93c7d414c702e8c9c4371123"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ff5b4bfd81cf3f6770c8f86e250a385264c81f6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e42a9bf5_a9efc289","updated":"2022-01-07 07:35:16.000000000","message":"recheck","commit_id":"1caccadbb86e3bba93c7d414c702e8c9c4371123"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"8d6670578db234f4a437a74e2dd880805a1dfebb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"eab565d2_5f22a6a4","updated":"2022-01-06 21:01:58.000000000","message":"recheck","commit_id":"1caccadbb86e3bba93c7d414c702e8c9c4371123"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"a240cfe9b64619233e1851f71119895ab008c8b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"315e6039_4c24a1a3","updated":"2022-03-10 08:43:00.000000000","message":"recheck","commit_id":"861284f92631e6079a61acef87db52aeb7cb291a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e50956a57369692eecbc163d47fc0f9b5a309a07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0336ed64_2e95b8ce","updated":"2022-05-09 23:49:36.000000000","message":"This test is broken","commit_id":"c5f5e286e789cfd48f3d54825348e352fc911e69"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a6812ef8abd2bc3881ab1be5856bcb27bf72111a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ac26a9d8_bd55b823","updated":"2022-05-11 22:08:24.000000000","message":"Looks fine to me","commit_id":"3c66e7c8dcd164eec3f53873c5c5c04d7337e46a"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"2959447f94ab424179c4621eebf667dc038229f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"34f77333_f4587cb3","updated":"2022-05-13 08:58:50.000000000","message":"recheck","commit_id":"3c66e7c8dcd164eec3f53873c5c5c04d7337e46a"}],"designate_tempest_plugin/tests/api/v2/test_recordset.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"3d1704fee2c9a6cab82aeafbb7787d9ca31e2958","unresolved":true,"context_lines":[{"line_number":579,"context_line":"                    record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":580,"context_line":"                resp, body \u003d self.client.create_recordset("},{"line_number":581,"context_line":"                    zone[\u0027id\u0027], recordset_data)"},{"line_number":582,"context_line":"                self.addCleanup(self.client.delete_recordset,"},{"line_number":583,"context_line":"                                zone[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":584,"context_line":"                self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027],"},{"line_number":585,"context_line":"                                 \u0027Failed, expected status is PENDING\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d6c92224_b08b5754","line":582,"updated":"2021-06-22 06:58:33.000000000","message":"This isn\u0027t actually needed because the zone is cleaned up (deleted).\n\u003e                 self.addCleanup(self.wait_zone_delete,\n\u003e                                 self.zone_client,\n\u003e                                 zone[\u0027id\u0027])","commit_id":"0d92ff37522e1c194242af2d9ee83302a0ee509a"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"a7acf13ac8470b4a8295e27b52dca4c2a6a0cd8f","unresolved":true,"context_lines":[{"line_number":579,"context_line":"                    record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":580,"context_line":"                resp, body \u003d self.client.create_recordset("},{"line_number":581,"context_line":"                    zone[\u0027id\u0027], recordset_data)"},{"line_number":582,"context_line":"                self.addCleanup(self.client.delete_recordset,"},{"line_number":583,"context_line":"                                zone[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":584,"context_line":"                self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027],"},{"line_number":585,"context_line":"                                 \u0027Failed, expected status is PENDING\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"898733b0_a9ebd641","line":582,"in_reply_to":"12ede4a9_e4b97f01","updated":"2021-06-22 07:17:03.000000000","message":"The only reason I don\u0027t fully agree with you is because if the zone fails to delete we have a bigger problem. The zone deletion will delete all the records created along with it, if the zone somehow survives we want to know, but either way we are stuck with unwanted objects.","commit_id":"0d92ff37522e1c194242af2d9ee83302a0ee509a"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6890d8fafb6ee53343fc7e3452ab27e0a3155d9a","unresolved":true,"context_lines":[{"line_number":579,"context_line":"                    record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":580,"context_line":"                resp, body \u003d self.client.create_recordset("},{"line_number":581,"context_line":"                    zone[\u0027id\u0027], recordset_data)"},{"line_number":582,"context_line":"                self.addCleanup(self.client.delete_recordset,"},{"line_number":583,"context_line":"                                zone[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":584,"context_line":"                self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027],"},{"line_number":585,"context_line":"                                 \u0027Failed, expected status is PENDING\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"e59ecaf5_3a6da6de","line":582,"in_reply_to":"323054d5_01aeb071","updated":"2021-07-14 08:38:42.000000000","message":"Hi Eric and Michael!\n\nSo it looks like recordset is not removed automatically after Zone deletion.\nHere is a piece of code I\u0027m working on:\n\n    @decorators.idempotent_id(\u0027f15e583e-e479-11eb-8e5a-74e5f9e2a801\u0027)\n    def test_delete_zone_with_existing_recordset(self):\n\n        LOG.info(\u0027Create a Zone\u0027)\n        zone \u003d self.zone_client.create_zone()[1]\n        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])\n\n        LOG.info(\u0027Create a Recordset\u0027)\n        recordset_data \u003d data_utils.rand_recordset_data(\n            record_type\u003d\u0027A\u0027, zone_name\u003dself.zone[\u0027name\u0027])\n        record \u003d self.client.create_recordset(\n            self.zone[\u0027id\u0027], recordset_data)[1]\n\n        LOG.info(\"Delete a Zone and wait till it\u0027s done\")\n        body \u003d self.zone_client.delete_zone(zone[\u0027id\u0027])[1]\n        LOG.info(\u0027Ensure we respond with DELETE+PENDING\u0027)\n        self.assertEqual(\u0027DELETE\u0027, body[\u0027action\u0027])\n        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])\n\n        LOG.info(\u0027Ensure successful deletion of Recordset\u0027)\n        self.assertRaises(lib_exc.NotFound,\n            lambda: self.client.show_recordset(self.zone[\u0027id\u0027], record[\u0027id\u0027]))\n\n\nTest fails with:\nTraceback (most recent call last):\n  File \"/opt/stack/designate-tempest-plugin/designate_tempest_plugin/tests/api/v2/test_recordset.py\", line 315, in test_delete_zone_with_existing_recordset\n    self.assertRaises(lib_exc.NotFound,\n  File \"/usr/local/lib/python3.8/dist-packages/testtools/testcase.py\", line 489, in assertRaises\n    self.assertThat(our_callable, matcher)\n  File \"/usr/local/lib/python3.8/dist-packages/testtools/testcase.py\", line 502, in assertThat\n    raise mismatch_error\ntesttools.matchers._impl.MismatchError: \u003cfunction RecordsetsTest.test_delete_zone_with_existing_recordset.\u003clocals\u003e.\u003clambda\u003e at 0x7fb20edc7ca0\u003e returned ({\u0027date\u0027: \u0027Wed, 14 Jul 2021 08:17:27 GMT\u0027, \u0027server\u0027: \u0027Apache/2.4.41 (Ubuntu)\u0027, \u0027content-length\u0027: \u0027553\u0027, \u0027x-openstack-request-id\u0027: \u0027req-7d58aa0f-dc0a-4815-805d-55b72ff99300\u0027, \u0027connection\u0027: \u0027close\u0027, \u0027content-type\u0027: \u0027application/json\u0027, \u0027status\u0027: \u0027200\u0027, \u0027content-location\u0027: \u0027http://10.35.64.8/dns/v2/zones/8fc1fe37-840d-44e1-998a-d700770a0f17/recordsets/8d46425b-aba0-4017-b105-7a221f1da971\u0027}, {\u0027id\u0027: \u00278d46425b-aba0-4017-b105-7a221f1da971\u0027, \u0027zone_id\u0027: \u00278fc1fe37-840d-44e1-998a-d700770a0f17\u0027, \u0027project_id\u0027: \u00272c6d8055179647bc83e17604f362dff0\u0027, \u0027name\u0027: \u0027A-993846933.1564686487.com.\u0027, \u0027zone_name\u0027: \u00271564686487.com.\u0027, \u0027type\u0027: \u0027A\u0027, \u0027records\u0027: [\u0027130.144.26.58\u0027], \u0027description\u0027: None, \u0027ttl\u0027: 51898, \u0027status\u0027: \u0027PENDING\u0027, \u0027action\u0027: \u0027CREATE\u0027, \u0027version\u0027: 1, \u0027created_at\u0027: \u00272021-07-14T08:17:27.000000\u0027, \u0027updated_at\u0027: None, \u0027links\u0027: {\u0027self\u0027: \u0027http://10.35.64.8/dns/v2/zones/8fc1fe37-840d-44e1-998a-d700770a0f17/recordsets/8d46425b-aba0-4017-b105-7a221f1da971\u0027}})\n\n\nTest failure is expected as the API for recorset after zone delete is 200 OK:\n2021-07-14 11:17:27,157 965334 INFO     [designate_tempest_plugin.tests.api.v2.test_recordset] Ensure successful deletion of Recordset\n2021-07-14 11:17:27,206 965334 INFO     [tempest.lib.common.rest_client] Request (RecordsetsTest:test_delete_zone_with_existing_recordset): 200 GET http://10.35.64.8/dns/v2/zones/8fc1fe37-840d-44e1-998a-d700770a0f17/recordsets/8d46425b-aba0-4017-b105-7a221f1da971 0.048s\n2021-07-14 11:17:27,207 965334 DEBUG    [tempest.lib.common.rest_client] Request - Headers: {\u0027Content-Type\u0027: \u0027application/json\u0027, \u0027Accept\u0027: \u0027application/json\u0027, \u0027X-Auth-Token\u0027: \u0027\u003comitted\u003e\u0027}\n        Body: None\n    Response - Headers: {\u0027date\u0027: \u0027Wed, 14 Jul 2021 08:17:27 GMT\u0027, \u0027server\u0027: \u0027Apache/2.4.41 (Ubuntu)\u0027, \u0027content-length\u0027: \u0027553\u0027, \u0027x-openstack-request-id\u0027: \u0027req-7d58aa0f-dc0a-4815-805d-55b72ff99300\u0027, \u0027connection\u0027: \u0027close\u0027, \u0027content-type\u0027: \u0027application/json\u0027, \u0027status\u0027: \u0027200\u0027, \u0027content-location\u0027: \u0027http://10.35.64.8/dns/v2/zones/8fc1fe37-840d-44e1-998a-d700770a0f17/recordsets/8d46425b-aba0-4017-b105-7a221f1da971\u0027}\n        Body: b\u0027{\"id\": \"8d46425b-aba0-4017-b105-7a221f1da971\", \"zone_id\": \"8fc1fe37-840d-44e1-998a-d700770a0f17\", \"project_id\": \"2c6d8055179647bc83e17604f362dff0\", \"name\": \"A-993846933.1564686487.com.\", \"zone_name\": \"1564686487.com.\", \"type\": \"A\", \"records\": [\"130.144.26.58\"], \"description\": null, \"ttl\": 51898, \"status\": \"PENDING\", \"action\": \"CREATE\", \"version\": 1, \"created_at\": \"2021-07-14T08:17:27.000000\", \"updated_at\": null, \"links\": {\"self\": \"http://10.35.64.8/dns/v2/zones/8fc1fe37-840d-44e1-998a-d700770a0f17/recordsets/8d46425b-aba0-4017-b105-7a221f1da971\"}}\u0027\n\n\nSo my question is if such a behaviour is Designate bug (Recordset for not existing Zone doesn\u0027t make sense to exist) or maybe it\u0027s OK?\n\n\nThanks and sorry if my comment is to long 😊","commit_id":"0d92ff37522e1c194242af2d9ee83302a0ee509a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"35b01711cacb08024ebd14634e96240a38506f53","unresolved":true,"context_lines":[{"line_number":579,"context_line":"                    record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":580,"context_line":"                resp, body \u003d self.client.create_recordset("},{"line_number":581,"context_line":"                    zone[\u0027id\u0027], recordset_data)"},{"line_number":582,"context_line":"                self.addCleanup(self.client.delete_recordset,"},{"line_number":583,"context_line":"                                zone[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":584,"context_line":"                self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027],"},{"line_number":585,"context_line":"                                 \u0027Failed, expected status is PENDING\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"323054d5_01aeb071","line":582,"in_reply_to":"5615025d_c6eb1c4f","updated":"2021-07-13 21:17:52.000000000","message":"Yeah, this is one of the odd cases to deal with tempest.\n\nPer the tempest writing guide, we should clean up all resources created. This also tests delete sequencing and deletion of an empty zone (I call it the Terraform test scenario, grin).\n\nOn the flip side, it takes extra test run time and doesn\u0027t necessarily test deleting a zone that contains records.\n\nSo, personally, I would leave this and add the explicit test for deleting a zone that contains records.","commit_id":"0d92ff37522e1c194242af2d9ee83302a0ee509a"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3900524a03edb4af1f21be9bec0a02f65bf5f97f","unresolved":true,"context_lines":[{"line_number":579,"context_line":"                    record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":580,"context_line":"                resp, body \u003d self.client.create_recordset("},{"line_number":581,"context_line":"                    zone[\u0027id\u0027], recordset_data)"},{"line_number":582,"context_line":"                self.addCleanup(self.client.delete_recordset,"},{"line_number":583,"context_line":"                                zone[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":584,"context_line":"                self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027],"},{"line_number":585,"context_line":"                                 \u0027Failed, expected status is PENDING\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5615025d_c6eb1c4f","line":582,"in_reply_to":"898733b0_a9ebd641","updated":"2021-06-22 07:39:53.000000000","message":"So maybe it would make sense adding a test that will try to delete a zone with associated recordset without without deleting the recordset prior to zone delete?\nI can add such a test into this patch, makes sense?","commit_id":"0d92ff37522e1c194242af2d9ee83302a0ee509a"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"50b044292e9df4928efe1826a2e61bcf27599872","unresolved":true,"context_lines":[{"line_number":579,"context_line":"                    record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":580,"context_line":"                resp, body \u003d self.client.create_recordset("},{"line_number":581,"context_line":"                    zone[\u0027id\u0027], recordset_data)"},{"line_number":582,"context_line":"                self.addCleanup(self.client.delete_recordset,"},{"line_number":583,"context_line":"                                zone[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":584,"context_line":"                self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027],"},{"line_number":585,"context_line":"                                 \u0027Failed, expected status is PENDING\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"12ede4a9_e4b97f01","line":582,"in_reply_to":"d6c92224_b08b5754","updated":"2021-06-22 07:14:30.000000000","message":"Hi Erik!\n\nThat was quick 😊\n\nYep, I\u0027m agree that\u0027s correct, but just like tempest coding guide says and based on my own \"sad\" experience (missing cleanups in tests), we need to take care of deletion created entities within the test.\nSo this \"recordset\" cleaunup seems to be in place here.\n\nThanks!","commit_id":"0d92ff37522e1c194242af2d9ee83302a0ee509a"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"ce3e2504ddc972961a219f0d5ec1b2f4db7c3b9e","unresolved":true,"context_lines":[{"line_number":304,"context_line":"        recordset_data \u003d data_utils.rand_recordset_data("},{"line_number":305,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dself.zone[\u0027name\u0027])"},{"line_number":306,"context_line":"        record \u003d self.client.create_recordset("},{"line_number":307,"context_line":"            self.zone[\u0027id\u0027], recordset_data)[1]"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        LOG.info(\"Delete a Zone and wait till it\u0027s done\")"},{"line_number":310,"context_line":"        body \u003d self.zone_client.delete_zone(zone[\u0027id\u0027])[1]"}],"source_content_type":"text/x-python","patch_set":4,"id":"6cc89f0c_2a6b7525","line":307,"updated":"2021-10-08 09:31:27.000000000","message":"Do we have a cleanup for this recordset?","commit_id":"48552f94db4658f37269369a06106b378f27cc42"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4827fee800d265f50ffc2aa076772f8d8ff04f0c","unresolved":true,"context_lines":[{"line_number":304,"context_line":"        recordset_data \u003d data_utils.rand_recordset_data("},{"line_number":305,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dself.zone[\u0027name\u0027])"},{"line_number":306,"context_line":"        record \u003d self.client.create_recordset("},{"line_number":307,"context_line":"            self.zone[\u0027id\u0027], recordset_data)[1]"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        LOG.info(\"Delete a Zone and wait till it\u0027s done\")"},{"line_number":310,"context_line":"        body \u003d self.zone_client.delete_zone(zone[\u0027id\u0027])[1]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9b719c7b_8ef64119","line":307,"in_reply_to":"6cc89f0c_2a6b7525","updated":"2021-10-12 09:27:09.000000000","message":"It\u0027s not necessary here as this recordset is supposed to be deleted within the Zoned delete, but I\u0027ll add a cleanup in the next patchset anyway. \nThanks!","commit_id":"48552f94db4658f37269369a06106b378f27cc42"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"13f6b519ae12edacd5ac25664bd4b8c025364454","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        recordset_data \u003d data_utils.rand_recordset_data("},{"line_number":305,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dself.zone[\u0027name\u0027])"},{"line_number":306,"context_line":"        record \u003d self.client.create_recordset("},{"line_number":307,"context_line":"            self.zone[\u0027id\u0027], recordset_data)[1]"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        LOG.info(\"Delete a Zone and wait till it\u0027s done\")"},{"line_number":310,"context_line":"        body \u003d self.zone_client.delete_zone(zone[\u0027id\u0027])[1]"}],"source_content_type":"text/x-python","patch_set":4,"id":"f4a08c7c_b2912bce","line":307,"in_reply_to":"9b719c7b_8ef64119","updated":"2022-05-11 12:24:36.000000000","message":"Done","commit_id":"48552f94db4658f37269369a06106b378f27cc42"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c4588b519928e5ce1632841dd2f3376f85d038f4","unresolved":true,"context_lines":[{"line_number":315,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        LOG.info(\u0027Ensure successful deletion of Recordset\u0027)"},{"line_number":318,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":319,"context_line":"            lambda: self.client.show_recordset(self.zone[\u0027id\u0027], record[\u0027id\u0027]))"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"937005ca_7c526d39","line":318,"updated":"2021-10-27 19:53:02.000000000","message":"Why not use the waiter function for this?\n\nhttps://github.com/openstack/designate-tempest-plugin/blob/master/designate_tempest_plugin/common/waiters.py#L24","commit_id":"d8559a493ffa5b2118da196448d0770cdac8c5a6"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"633eabf30396cec60e5f32e2711dac73b00a6268","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        LOG.info(\u0027Ensure successful deletion of Recordset\u0027)"},{"line_number":318,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":319,"context_line":"            lambda: self.client.show_recordset(self.zone[\u0027id\u0027], record[\u0027id\u0027]))"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"6f38adf3_019dec80","line":318,"in_reply_to":"937005ca_7c526d39","updated":"2021-10-28 15:57:43.000000000","message":"Done","commit_id":"d8559a493ffa5b2118da196448d0770cdac8c5a6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9d3668619070e4a10eb45c2d596f791544959454","unresolved":true,"context_lines":[{"line_number":683,"context_line":""},{"line_number":684,"context_line":"                self.addCleanup(self.client.delete_recordset,"},{"line_number":685,"context_line":"                                zone[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":686,"context_line":"                self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027],"},{"line_number":687,"context_line":"                                 \u0027Failed, expected status is PENDING\u0027)"},{"line_number":688,"context_line":"                LOG.info(\u0027Wait until the recordset is active\u0027)"},{"line_number":689,"context_line":"                waiters.wait_for_recordset_status("}],"source_content_type":"text/x-python","patch_set":8,"id":"e39eafd2_33782b5a","line":686,"updated":"2022-01-07 23:23:18.000000000","message":"This is duplicate to line 681","commit_id":"1caccadbb86e3bba93c7d414c702e8c9c4371123"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"aa39dfe7248678aafe74d9c51cc3936f05907675","unresolved":true,"context_lines":[{"line_number":683,"context_line":""},{"line_number":684,"context_line":"                self.addCleanup(self.client.delete_recordset,"},{"line_number":685,"context_line":"                                zone[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":686,"context_line":"                self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027],"},{"line_number":687,"context_line":"                                 \u0027Failed, expected status is PENDING\u0027)"},{"line_number":688,"context_line":"                LOG.info(\u0027Wait until the recordset is active\u0027)"},{"line_number":689,"context_line":"                waiters.wait_for_recordset_status("}],"source_content_type":"text/x-python","patch_set":8,"id":"a6e0484f_26b6d0e0","line":686,"in_reply_to":"e39eafd2_33782b5a","updated":"2022-01-10 16:13:12.000000000","message":"Good catch, thanks!","commit_id":"1caccadbb86e3bba93c7d414c702e8c9c4371123"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9d3668619070e4a10eb45c2d596f791544959454","unresolved":true,"context_lines":[{"line_number":717,"context_line":""},{"line_number":718,"context_line":"                self.addCleanup(self.alt_client.delete_recordset,"},{"line_number":719,"context_line":"                                alt_zone[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":720,"context_line":"                self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027],"},{"line_number":721,"context_line":"                                 \u0027Failed, expected status is PENDING\u0027)"},{"line_number":722,"context_line":"                LOG.info(\u0027Wait until the recordset is active\u0027)"},{"line_number":723,"context_line":"                waiters.wait_for_recordset_status("}],"source_content_type":"text/x-python","patch_set":8,"id":"e22db5ba_cc50941d","line":720,"updated":"2022-01-07 23:23:18.000000000","message":"This is duplicate to line 715","commit_id":"1caccadbb86e3bba93c7d414c702e8c9c4371123"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"aa39dfe7248678aafe74d9c51cc3936f05907675","unresolved":true,"context_lines":[{"line_number":717,"context_line":""},{"line_number":718,"context_line":"                self.addCleanup(self.alt_client.delete_recordset,"},{"line_number":719,"context_line":"                                alt_zone[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":720,"context_line":"                self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027],"},{"line_number":721,"context_line":"                                 \u0027Failed, expected status is PENDING\u0027)"},{"line_number":722,"context_line":"                LOG.info(\u0027Wait until the recordset is active\u0027)"},{"line_number":723,"context_line":"                waiters.wait_for_recordset_status("}],"source_content_type":"text/x-python","patch_set":8,"id":"4c162de0_ca9cb254","line":720,"in_reply_to":"e22db5ba_cc50941d","updated":"2022-01-10 16:13:12.000000000","message":"Good catch, thanks!","commit_id":"1caccadbb86e3bba93c7d414c702e8c9c4371123"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e50956a57369692eecbc163d47fc0f9b5a309a07","unresolved":true,"context_lines":[{"line_number":401,"context_line":"            body[\u0027id\u0027], const.ACTIVE)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    @decorators.idempotent_id(\u0027f15e583e-e479-11eb-8e5a-74e5f9e2a801\u0027)"},{"line_number":404,"context_line":"    @decorators.skip_because(bug\u003d\u00271938264\u0027)"},{"line_number":405,"context_line":"    def test_delete_zone_with_existing_recordset(self):"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        LOG.info(\u0027Create a Zone\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"f0404a98_8baf164d","line":404,"range":{"start_line":404,"start_character":34,"end_line":404,"end_character":41},"updated":"2022-05-09 23:49:36.000000000","message":"I don\u0027t think there is a bug here. Please mark the bug invalid if you agree.","commit_id":"c5f5e286e789cfd48f3d54825348e352fc911e69"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"13f6b519ae12edacd5ac25664bd4b8c025364454","unresolved":true,"context_lines":[{"line_number":401,"context_line":"            body[\u0027id\u0027], const.ACTIVE)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    @decorators.idempotent_id(\u0027f15e583e-e479-11eb-8e5a-74e5f9e2a801\u0027)"},{"line_number":404,"context_line":"    @decorators.skip_because(bug\u003d\u00271938264\u0027)"},{"line_number":405,"context_line":"    def test_delete_zone_with_existing_recordset(self):"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        LOG.info(\u0027Create a Zone\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"e52cf33c_513136bf","line":404,"range":{"start_line":404,"start_character":34,"end_line":404,"end_character":41},"in_reply_to":"f0404a98_8baf164d","updated":"2022-05-11 12:24:36.000000000","message":"Yep, the there was a mismatch in this test 😞\nDone, BZ has been changed to invalid","commit_id":"c5f5e286e789cfd48f3d54825348e352fc911e69"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e50956a57369692eecbc163d47fc0f9b5a309a07","unresolved":true,"context_lines":[{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        LOG.info(\u0027Create a Recordset\u0027)"},{"line_number":412,"context_line":"        recordset_data \u003d data_utils.rand_recordset_data("},{"line_number":413,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dself.zone[\u0027name\u0027])"},{"line_number":414,"context_line":"        record \u003d self.client.create_recordset("},{"line_number":415,"context_line":"            self.zone[\u0027id\u0027], recordset_data)[1]"},{"line_number":416,"context_line":"        self.addCleanup(self.client.delete_recordset,"}],"source_content_type":"text/x-python","patch_set":10,"id":"40b10a23_fb696fba","line":413,"range":{"start_line":413,"start_character":39,"end_line":413,"end_character":48},"updated":"2022-05-09 23:49:36.000000000","message":"This test is broken because it is mixing the zone from the parent class and  the zone created for the test.","commit_id":"c5f5e286e789cfd48f3d54825348e352fc911e69"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"13f6b519ae12edacd5ac25664bd4b8c025364454","unresolved":true,"context_lines":[{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        LOG.info(\u0027Create a Recordset\u0027)"},{"line_number":412,"context_line":"        recordset_data \u003d data_utils.rand_recordset_data("},{"line_number":413,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dself.zone[\u0027name\u0027])"},{"line_number":414,"context_line":"        record \u003d self.client.create_recordset("},{"line_number":415,"context_line":"            self.zone[\u0027id\u0027], recordset_data)[1]"},{"line_number":416,"context_line":"        self.addCleanup(self.client.delete_recordset,"}],"source_content_type":"text/x-python","patch_set":10,"id":"99fbecca_21512a5f","line":413,"range":{"start_line":413,"start_character":39,"end_line":413,"end_character":48},"in_reply_to":"40b10a23_fb696fba","updated":"2022-05-11 12:24:36.000000000","message":"Agree, will be fixed.","commit_id":"c5f5e286e789cfd48f3d54825348e352fc911e69"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e50956a57369692eecbc163d47fc0f9b5a309a07","unresolved":true,"context_lines":[{"line_number":412,"context_line":"        recordset_data \u003d data_utils.rand_recordset_data("},{"line_number":413,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dself.zone[\u0027name\u0027])"},{"line_number":414,"context_line":"        record \u003d self.client.create_recordset("},{"line_number":415,"context_line":"            self.zone[\u0027id\u0027], recordset_data)[1]"},{"line_number":416,"context_line":"        self.addCleanup(self.client.delete_recordset,"},{"line_number":417,"context_line":"                        zone[\u0027id\u0027], record[\u0027id\u0027])"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"13950a69_f687dea4","line":415,"range":{"start_line":415,"start_character":12,"end_line":415,"end_character":21},"updated":"2022-05-09 23:49:36.000000000","message":"Wrong zone","commit_id":"c5f5e286e789cfd48f3d54825348e352fc911e69"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"13f6b519ae12edacd5ac25664bd4b8c025364454","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        recordset_data \u003d data_utils.rand_recordset_data("},{"line_number":413,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dself.zone[\u0027name\u0027])"},{"line_number":414,"context_line":"        record \u003d self.client.create_recordset("},{"line_number":415,"context_line":"            self.zone[\u0027id\u0027], recordset_data)[1]"},{"line_number":416,"context_line":"        self.addCleanup(self.client.delete_recordset,"},{"line_number":417,"context_line":"                        zone[\u0027id\u0027], record[\u0027id\u0027])"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"56f08141_69006fcf","line":415,"range":{"start_line":415,"start_character":12,"end_line":415,"end_character":21},"in_reply_to":"13950a69_f687dea4","updated":"2022-05-11 12:24:36.000000000","message":"Done","commit_id":"c5f5e286e789cfd48f3d54825348e352fc911e69"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e50956a57369692eecbc163d47fc0f9b5a309a07","unresolved":true,"context_lines":[{"line_number":423,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        LOG.info(\u0027Ensure successful deletion of Recordset\u0027)"},{"line_number":426,"context_line":"        waiters.wait_for_zone_404(self.client, self.zone[\u0027id\u0027])"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":10,"id":"b582b3b7_fd2a0087","line":426,"range":{"start_line":426,"start_character":47,"end_line":426,"end_character":56},"updated":"2022-05-09 23:49:36.000000000","message":"Wrong zone","commit_id":"c5f5e286e789cfd48f3d54825348e352fc911e69"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e50956a57369692eecbc163d47fc0f9b5a309a07","unresolved":true,"context_lines":[{"line_number":423,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        LOG.info(\u0027Ensure successful deletion of Recordset\u0027)"},{"line_number":426,"context_line":"        waiters.wait_for_zone_404(self.client, self.zone[\u0027id\u0027])"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":10,"id":"a4d4b988_3d53b930","line":426,"range":{"start_line":426,"start_character":34,"end_line":426,"end_character":45},"updated":"2022-05-09 23:49:36.000000000","message":"zone_client","commit_id":"c5f5e286e789cfd48f3d54825348e352fc911e69"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"13f6b519ae12edacd5ac25664bd4b8c025364454","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        LOG.info(\u0027Ensure successful deletion of Recordset\u0027)"},{"line_number":426,"context_line":"        waiters.wait_for_zone_404(self.client, self.zone[\u0027id\u0027])"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":10,"id":"aa3eba39_a222afa5","line":426,"range":{"start_line":426,"start_character":34,"end_line":426,"end_character":45},"in_reply_to":"a4d4b988_3d53b930","updated":"2022-05-11 12:24:36.000000000","message":"Done","commit_id":"c5f5e286e789cfd48f3d54825348e352fc911e69"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"13f6b519ae12edacd5ac25664bd4b8c025364454","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        LOG.info(\u0027Ensure successful deletion of Recordset\u0027)"},{"line_number":426,"context_line":"        waiters.wait_for_zone_404(self.client, self.zone[\u0027id\u0027])"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":10,"id":"68b1b0e9_6399667c","line":426,"range":{"start_line":426,"start_character":47,"end_line":426,"end_character":56},"in_reply_to":"b582b3b7_fd2a0087","updated":"2022-05-11 12:24:36.000000000","message":"Done","commit_id":"c5f5e286e789cfd48f3d54825348e352fc911e69"}]}