)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c8764d4a1535cdbd65135a6f93092834702cf48f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"060639d3_953aca90","updated":"2021-10-12 09:29:36.000000000","message":"recheck","commit_id":"5ceadfbefc0e94a5419879808ca437ca68a1fe68"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"171bc5daf36528d7f95d10dc8f31a92ba8ae2ebe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fd6f0f14_b102a3bf","updated":"2021-10-12 10:51:48.000000000","message":"recheck","commit_id":"5ceadfbefc0e94a5419879808ca437ca68a1fe68"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ad7bee36baf9e80815af9ba878348a069012811a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1ec01b7b_9168d5ec","updated":"2021-10-18 18:29:16.000000000","message":"recheck","commit_id":"7b8e9a9dc7164ace3c492c0c24912a7874e47137"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f902ccdf1d04741a886947d7d13dc467b3363c10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"62b5f752_eef7e5d9","updated":"2021-10-18 21:53:24.000000000","message":"recheck","commit_id":"7b8e9a9dc7164ace3c492c0c24912a7874e47137"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ad9dad48aeec80d1273f4d0f7c8ed4f5d449639a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a5a91a35_400e919e","updated":"2021-10-18 19:39:43.000000000","message":"recheck","commit_id":"7b8e9a9dc7164ace3c492c0c24912a7874e47137"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"21562a8c55c0bbf0e60e4a4992471829a9509d75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bc727eb6_28aa700e","updated":"2021-10-25 23:00:23.000000000","message":"I still think this test is not actually testing the order of the results.","commit_id":"da9f34d4a220284ef82b523f9c50e05f9a80eaa4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5b0bc56d9167826b39520125f14eca35539e1875","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7201bdff_2b1f5670","updated":"2021-10-26 10:52:57.000000000","message":"recheck","commit_id":"b1c4bbff19401c0378434644a9b7c7996ac3fdb4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"add66666c1eb5736d3151b93324558fc443e83eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a075a5a0_904339b2","updated":"2022-01-13 10:28:45.000000000","message":"Erik, Michael \n\nThere is an RBAC related staff I\u0027ve missed, that explains \"designate-bind9-scoped-tokens\" failure.\nI\u0027m about to upload a new patch to fix that.\n\nThanks!\n\n","commit_id":"e93f3c0573be0fa8ab1997468ca0d0ce8934ff26"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"824398fbadcdb484fa7ee896000038ea32c001dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"858f99cd_6f13223a","updated":"2021-10-28 17:16:31.000000000","message":"LGTM","commit_id":"e93f3c0573be0fa8ab1997468ca0d0ce8934ff26"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c57ad1b9a8cedd3df6a33f569f9b5119cd102f45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"67648394_1b433b42","updated":"2021-12-12 14:26:47.000000000","message":"recheck","commit_id":"e93f3c0573be0fa8ab1997468ca0d0ce8934ff26"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7179ab9712660c73cbefadac9a4f0cddcbaba19b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"82c9c8b0_8fc13bd1","updated":"2021-10-26 18:44:36.000000000","message":"recheck","commit_id":"e93f3c0573be0fa8ab1997468ca0d0ce8934ff26"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3dee78b07d202a3a34af9d44c57103327f95a25d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a108ca71_892feb29","updated":"2021-12-12 20:50:51.000000000","message":"recheck","commit_id":"e93f3c0573be0fa8ab1997468ca0d0ce8934ff26"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f1f891274f7035ab7225776fd2d9639105e98096","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a14466c2_08fa7f43","updated":"2021-12-12 18:02:46.000000000","message":"recheck","commit_id":"e93f3c0573be0fa8ab1997468ca0d0ce8934ff26"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"49b1d5b4fe1261eda39861cff4d184fb548d3034","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c99464de_fbb67570","updated":"2022-01-13 06:59:17.000000000","message":"recheck","commit_id":"e93f3c0573be0fa8ab1997468ca0d0ce8934ff26"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2f92123f240f196cdf36daf90bc602a8aa08b9da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"46d82fea_372de0cd","updated":"2022-05-09 22:35:57.000000000","message":"I have provided more information about the \"next\u0027 link and the marker for pagination.","commit_id":"a6060841b0f7d23401f96d9aaeb8f0265af4c84d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0bd1a24b8be59d0ebe560b158d7d8dd23dc89d02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"183e32a4_43d1896e","updated":"2022-05-11 22:05:29.000000000","message":"recheck\nChecking stability of the patch and the DNS failure in the fips job","commit_id":"37925b2540b39ebb365887d09c7349c98b7b1871"}],"designate_tempest_plugin/tests/api/v2/test_tsigkey.py":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c9773a454c19a14ada5d423ca493ea0e913deeb3","unresolved":true,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @decorators.idempotent_id(\u00270dfbc2f8-d8bb-11eb-b95a-74e5f9e2a801\u0027)"},{"line_number":187,"context_line":"    def test_create_tsigkey_for_pool_with_scope_zone(self):"},{"line_number":188,"context_line":"        # Note: are we expecting such a scenario PASS?"},{"line_number":189,"context_line":"        pool \u003d self.pool_admin_client.create_pool()[1]"},{"line_number":190,"context_line":"        self.addCleanup(self.pool_admin_client.delete_pool, pool[\u0027id\u0027])"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4cd33dcd_d7af5797","line":188,"range":{"start_line":188,"start_character":1,"end_line":188,"end_character":54},"updated":"2021-06-29 09:57:36.000000000","message":"There is a kind of conflict in this test scenario.\nProvided resource_id is a pool, but scope is set to ZONE.\nIt\u0027s PASS, is that OK, don\u0027t we expect failure?\nI\u0027ll fix the test (will be removed if PASS is expected) based on your answer.","commit_id":"fbb3db10883b7d1944dcbbbf23b21b25416f5e46"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"68397449b7a2f33a34e9f2f736f18b1a9844fc37","unresolved":true,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @decorators.idempotent_id(\u00270dfbc2f8-d8bb-11eb-b95a-74e5f9e2a801\u0027)"},{"line_number":187,"context_line":"    def test_create_tsigkey_for_pool_with_scope_zone(self):"},{"line_number":188,"context_line":"        # Note: are we expecting such a scenario PASS?"},{"line_number":189,"context_line":"        pool \u003d self.pool_admin_client.create_pool()[1]"},{"line_number":190,"context_line":"        self.addCleanup(self.pool_admin_client.delete_pool, pool[\u0027id\u0027])"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6d02b1ae_f4f87a06","line":188,"range":{"start_line":188,"start_character":1,"end_line":188,"end_character":54},"in_reply_to":"4cd33dcd_d7af5797","updated":"2021-06-29 23:13:19.000000000","message":"I agree, this should fail on a validation error.\nLet\u0027s open a launchpad bug.","commit_id":"fbb3db10883b7d1944dcbbbf23b21b25416f5e46"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"76d51649a7e46f02d1c39964faf255d9c5471021","unresolved":true,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @decorators.idempotent_id(\u00270dfbc2f8-d8bb-11eb-b95a-74e5f9e2a801\u0027)"},{"line_number":187,"context_line":"    def test_create_tsigkey_for_pool_with_scope_zone(self):"},{"line_number":188,"context_line":"        # Note: are we expecting such a scenario PASS?"},{"line_number":189,"context_line":"        pool \u003d self.pool_admin_client.create_pool()[1]"},{"line_number":190,"context_line":"        self.addCleanup(self.pool_admin_client.delete_pool, pool[\u0027id\u0027])"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dade4bb3_4c4d09b3","line":188,"range":{"start_line":188,"start_character":1,"end_line":188,"end_character":54},"in_reply_to":"6d02b1ae_f4f87a06","updated":"2021-06-30 12:31:30.000000000","message":"Done: https://bugs.launchpad.net/designate/+bug/1934120","commit_id":"fbb3db10883b7d1944dcbbbf23b21b25416f5e46"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c9773a454c19a14ada5d423ca493ea0e913deeb3","unresolved":true,"context_lines":[{"line_number":222,"context_line":"        self.assertEqual(len(body[\u0027tsigkeys\u0027]), 2)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @decorators.idempotent_id(\u0027f31447b0-d817-11eb-b95a-74e5f9e2a801\u0027)"},{"line_number":225,"context_line":"    # NOTE: I don\u0027t understand the meaning of Marker and how to use it."},{"line_number":226,"context_line":"    # This test will be fixed, oce I\u0027ll know the answer."},{"line_number":227,"context_line":"    def test_list_tsigkey_limit_results_use_marker(self):"},{"line_number":228,"context_line":"        created_tsigkeys \u003d []"},{"line_number":229,"context_line":"        for i in range(3):"}],"source_content_type":"text/x-python","patch_set":2,"id":"47d87fed_df9b6601","line":226,"range":{"start_line":225,"start_character":0,"end_line":226,"end_character":56},"updated":"2021-06-29 09:57:36.000000000","message":"This test is not yet completed, from the Doc that we have for \"marker\":\nhttps://docs.openstack.org/api-ref/dns/?expanded\u003dlist-tsigkeys-detail#create-tsigkeys it\u0027s not so clear to me how to use it and why do we need it?\n:(\nI need some explanations on this and maybe that the current explanations we have should be improved, I\u0027ll open a Doc Bug if it make sense to you.","commit_id":"fbb3db10883b7d1944dcbbbf23b21b25416f5e46"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"68397449b7a2f33a34e9f2f736f18b1a9844fc37","unresolved":true,"context_lines":[{"line_number":222,"context_line":"        self.assertEqual(len(body[\u0027tsigkeys\u0027]), 2)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @decorators.idempotent_id(\u0027f31447b0-d817-11eb-b95a-74e5f9e2a801\u0027)"},{"line_number":225,"context_line":"    # NOTE: I don\u0027t understand the meaning of Marker and how to use it."},{"line_number":226,"context_line":"    # This test will be fixed, oce I\u0027ll know the answer."},{"line_number":227,"context_line":"    def test_list_tsigkey_limit_results_use_marker(self):"},{"line_number":228,"context_line":"        created_tsigkeys \u003d []"},{"line_number":229,"context_line":"        for i in range(3):"}],"source_content_type":"text/x-python","patch_set":2,"id":"6bd78daf_30b3ec95","line":226,"range":{"start_line":225,"start_character":0,"end_line":226,"end_character":56},"in_reply_to":"47d87fed_df9b6601","updated":"2021-06-29 23:13:19.000000000","message":"This is referring to \"pagination\" that OpenStack list APIs support. Basically we limit the number of results returned by default and allow repeated API calls to get the rest of the rows.\n\nAll of the \"list\" methods in the Designate API should support pagination and have marker/limit in the request query string docs.\n\nThe OpenStack API working group doc is here:\nhttps://specs.openstack.org/openstack/api-wg/guidelines/pagination_filter_sort.html\n\nMy documentation for the Octavia API is here:\nhttps://docs.openstack.org/api-ref/load-balancer/v2/index.html#pagination\n\nDesignate should have an API reference guide that includes a section on how to use pagination with the designate API. I agree we can open a launchpad and BZ doc bug for this (or a meta bug for \"missing API guide\".","commit_id":"fbb3db10883b7d1944dcbbbf23b21b25416f5e46"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"76d51649a7e46f02d1c39964faf255d9c5471021","unresolved":true,"context_lines":[{"line_number":222,"context_line":"        self.assertEqual(len(body[\u0027tsigkeys\u0027]), 2)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @decorators.idempotent_id(\u0027f31447b0-d817-11eb-b95a-74e5f9e2a801\u0027)"},{"line_number":225,"context_line":"    # NOTE: I don\u0027t understand the meaning of Marker and how to use it."},{"line_number":226,"context_line":"    # This test will be fixed, oce I\u0027ll know the answer."},{"line_number":227,"context_line":"    def test_list_tsigkey_limit_results_use_marker(self):"},{"line_number":228,"context_line":"        created_tsigkeys \u003d []"},{"line_number":229,"context_line":"        for i in range(3):"}],"source_content_type":"text/x-python","patch_set":2,"id":"8b3bfdde_18ad0434","line":226,"range":{"start_line":225,"start_character":0,"end_line":226,"end_character":56},"in_reply_to":"6bd78daf_30b3ec95","updated":"2021-06-30 12:31:30.000000000","message":"Done: https://bugs.launchpad.net/designate/+bug/1934128 + \"marker\" functionality is now in the test.","commit_id":"fbb3db10883b7d1944dcbbbf23b21b25416f5e46"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c9773a454c19a14ada5d423ca493ea0e913deeb3","unresolved":true,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    @decorators.idempotent_id(\u0027c06b1fd6-d74b-11eb-beba-74e5f9e2a801\u0027)"},{"line_number":422,"context_line":"    def test_show_tsigkey_impersonate_user(self):"},{"line_number":423,"context_line":"        # Note: seems like the only user that is able to create"},{"line_number":424,"context_line":"        # tsigkey is Admin, therefore could be that the Doc"},{"line_number":425,"context_line":"        # is needed to be fixed, otherwise it\u0027s a bug."},{"line_number":426,"context_line":"        LOG.info(\u0027As Primary user create a zone\u0027)"},{"line_number":427,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"},{"line_number":428,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"848e1d6a_761a967a","line":425,"range":{"start_line":423,"start_character":0,"end_line":425,"end_character":54},"updated":"2021-06-29 09:57:36.000000000","message":"Designate bug? \nDoc bug?\nAm I missing something?","commit_id":"fbb3db10883b7d1944dcbbbf23b21b25416f5e46"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"76d51649a7e46f02d1c39964faf255d9c5471021","unresolved":true,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    @decorators.idempotent_id(\u0027c06b1fd6-d74b-11eb-beba-74e5f9e2a801\u0027)"},{"line_number":422,"context_line":"    def test_show_tsigkey_impersonate_user(self):"},{"line_number":423,"context_line":"        # Note: seems like the only user that is able to create"},{"line_number":424,"context_line":"        # tsigkey is Admin, therefore could be that the Doc"},{"line_number":425,"context_line":"        # is needed to be fixed, otherwise it\u0027s a bug."},{"line_number":426,"context_line":"        LOG.info(\u0027As Primary user create a zone\u0027)"},{"line_number":427,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"},{"line_number":428,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"da4151e5_3d5a31a0","line":425,"range":{"start_line":423,"start_character":0,"end_line":425,"end_character":54},"in_reply_to":"07482dbd_aa712edf","updated":"2021-06-30 12:31:30.000000000","message":"OK, so according [1] this API is available for Admin only users, so I\u0027ll open a launchpad bug to remove: \"x-auth-all-projects (Optional)\"  and \"x-auth-sudo-project-id (Optional)\" from the Doc.\nDoc bug for that is here: https://bugs.launchpad.net/designate/+bug/1934138\n\n\"test_show_tsigkey_impersonate_user\" is not relevant and will be removed.","commit_id":"fbb3db10883b7d1944dcbbbf23b21b25416f5e46"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"68397449b7a2f33a34e9f2f736f18b1a9844fc37","unresolved":true,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    @decorators.idempotent_id(\u0027c06b1fd6-d74b-11eb-beba-74e5f9e2a801\u0027)"},{"line_number":422,"context_line":"    def test_show_tsigkey_impersonate_user(self):"},{"line_number":423,"context_line":"        # Note: seems like the only user that is able to create"},{"line_number":424,"context_line":"        # tsigkey is Admin, therefore could be that the Doc"},{"line_number":425,"context_line":"        # is needed to be fixed, otherwise it\u0027s a bug."},{"line_number":426,"context_line":"        LOG.info(\u0027As Primary user create a zone\u0027)"},{"line_number":427,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"},{"line_number":428,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"07482dbd_aa712edf","line":425,"range":{"start_line":423,"start_character":0,"end_line":425,"end_character":54},"in_reply_to":"848e1d6a_761a967a","updated":"2021-06-29 23:13:19.000000000","message":"Looking in the RBAC doc[1], for create_tsigkey, I see that it is currently only available for users with the an admin role.\n\nWhich doc were you looking at that implied it could be used by an end user?\n\n[1] https://docs.openstack.org/designate/latest/admin/policy.html","commit_id":"fbb3db10883b7d1944dcbbbf23b21b25416f5e46"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ca3cb08cfa32b9ea9340f2fa425778266ab9ce6a","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        tsigkey_data \u003d {"},{"line_number":104,"context_line":"                        \"name\": \"Patch tsigkey\","},{"line_number":105,"context_line":"                        \"secret\": \"NewSecretKey\","},{"line_number":106,"context_line":"                        \"scope\": \"POOL\"}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        LOG.info(\u0027Update the tsigkey\u0027)"},{"line_number":109,"context_line":"        _, patch_tsigkey \u003d self.admin_client.update_tsigkey(tsigkey[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf7073f7_fbe0ad07","side":"PARENT","line":106,"updated":"2021-10-06 23:37:55.000000000","message":"Why was this removed from this update test?","commit_id":"da27a70ae2b39695ef6f03bbefb55afeacf1cdf3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ca3cb08cfa32b9ea9340f2fa425778266ab9ce6a","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        tsigkey_data \u003d {"},{"line_number":54,"context_line":"                        \"name\": dns_data_utils.rand_zone_name(\u0027Example_Key\u0027),"},{"line_number":55,"context_line":"                        \"algorithm\": \"hmac-sha256\","},{"line_number":56,"context_line":"                        \"secret\": \"SomeSecretKey\","},{"line_number":57,"context_line":"                        \"scope\": \"ZONE\","}],"source_content_type":"text/x-python","patch_set":3,"id":"439435ae_e73fd65b","line":54,"updated":"2021-10-06 23:37:55.000000000","message":"I would like to switch these over to include the test name for easier test debugging.","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ed6318c19b96ad22efd30d185a56a72fca9fc0e9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        tsigkey_data \u003d {"},{"line_number":54,"context_line":"                        \"name\": dns_data_utils.rand_zone_name(\u0027Example_Key\u0027),"},{"line_number":55,"context_line":"                        \"algorithm\": \"hmac-sha256\","},{"line_number":56,"context_line":"                        \"secret\": \"SomeSecretKey\","},{"line_number":57,"context_line":"                        \"scope\": \"ZONE\","}],"source_content_type":"text/x-python","patch_set":3,"id":"39f383ed_21f4ed8a","line":54,"in_reply_to":"439435ae_e73fd65b","updated":"2021-10-08 06:17:48.000000000","message":"Done","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ca3cb08cfa32b9ea9340f2fa425778266ab9ce6a","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @decorators.idempotent_id(\u0027f94af13a-d743-11eb-beba-74e5f9e2a801\u0027)"},{"line_number":70,"context_line":"    def test_create_tsigkey_for_zone_invalid_algorithm(self):"},{"line_number":71,"context_line":"        LOG.info(\u0027Create a zone resource\u0027)"},{"line_number":72,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"},{"line_number":73,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":74,"context_line":"        tsigkey_data \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"1164f411_087abb7f","line":71,"updated":"2021-10-06 23:37:55.000000000","message":"I\u0027m not sure what value this log statement brings to this test. Do we need it, or is it just noise in the tempest log file?","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ed6318c19b96ad22efd30d185a56a72fca9fc0e9","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @decorators.idempotent_id(\u0027f94af13a-d743-11eb-beba-74e5f9e2a801\u0027)"},{"line_number":70,"context_line":"    def test_create_tsigkey_for_zone_invalid_algorithm(self):"},{"line_number":71,"context_line":"        LOG.info(\u0027Create a zone resource\u0027)"},{"line_number":72,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"},{"line_number":73,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":74,"context_line":"        tsigkey_data \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"aa153442_b80dac18","line":71,"in_reply_to":"1164f411_087abb7f","updated":"2021-10-08 06:17:48.000000000","message":"Agree, I\u0027ll remove it.","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ca3cb08cfa32b9ea9340f2fa425778266ab9ce6a","unresolved":true,"context_lines":[{"line_number":193,"context_line":"        tsigkey \u003d self.admin_client.create_tsigkey("},{"line_number":194,"context_line":"            resource_id\u003dpool[\u0027id\u0027], scope\u003d\u0027ZONE\u0027)[1]"},{"line_number":195,"context_line":"        self.addCleanup(self.admin_client.delete_tsigkey, tsigkey[\u0027id\u0027])"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    @decorators.idempotent_id(\u0027d46e5e86-a18c-4315-aa0c-95a00e816fbf\u0027)"},{"line_number":198,"context_line":"    def test_list_tsigkey(self):"},{"line_number":199,"context_line":"        LOG.info(\u0027Create a resource\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"acb7349e_7adcea03","line":196,"updated":"2021-10-06 23:37:55.000000000","message":"No assert here? Can we at least check the scope in the returned key?","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d5acefafa186dbfef8a1af75067337b892e673a8","unresolved":true,"context_lines":[{"line_number":193,"context_line":"        tsigkey \u003d self.admin_client.create_tsigkey("},{"line_number":194,"context_line":"            resource_id\u003dpool[\u0027id\u0027], scope\u003d\u0027ZONE\u0027)[1]"},{"line_number":195,"context_line":"        self.addCleanup(self.admin_client.delete_tsigkey, tsigkey[\u0027id\u0027])"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    @decorators.idempotent_id(\u0027d46e5e86-a18c-4315-aa0c-95a00e816fbf\u0027)"},{"line_number":198,"context_line":"    def test_list_tsigkey(self):"},{"line_number":199,"context_line":"        LOG.info(\u0027Create a resource\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"49164d48_1873dfac","line":196,"in_reply_to":"acb7349e_7adcea03","updated":"2022-05-09 12:18:12.000000000","message":"This test doesn\u0027t expect the key to be created (because of incorrect scope value used, ZONE instead of POOL).\nThere are other tests where scope validation could be added to: test_create_tsigkey_for_pool and test_create_tsigkey_for_zone \nI\u0027ll do that in my next patch","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ca3cb08cfa32b9ea9340f2fa425778266ab9ce6a","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        body \u003d self.admin_client.list_tsigkeys("},{"line_number":243,"context_line":"            params\u003d{\u0027limit\u0027: 2})[1][\u0027tsigkeys\u0027]"},{"line_number":244,"context_line":"        first_set_of_ids \u003d [item[\u0027id\u0027] for item in body]"},{"line_number":245,"context_line":"        marker \u003d [item[\u0027id\u0027] for item in body][-1]"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        LOG.info(\u0027Initiate list API request containing: \"marker\" to \u0027"},{"line_number":248,"context_line":"                 \u0027get the rest of tsigkeys)\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f1f3c332_20684439","line":245,"updated":"2021-10-06 23:37:55.000000000","message":"You cannot assume that the marker is going to be next to last. We should access the json document by json key. You are looking for the \"next\" link.","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d5acefafa186dbfef8a1af75067337b892e673a8","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        body \u003d self.admin_client.list_tsigkeys("},{"line_number":243,"context_line":"            params\u003d{\u0027limit\u0027: 2})[1][\u0027tsigkeys\u0027]"},{"line_number":244,"context_line":"        first_set_of_ids \u003d [item[\u0027id\u0027] for item in body]"},{"line_number":245,"context_line":"        marker \u003d [item[\u0027id\u0027] for item in body][-1]"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        LOG.info(\u0027Initiate list API request containing: \"marker\" to \u0027"},{"line_number":248,"context_line":"                 \u0027get the rest of tsigkeys)\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"cbb3bd60_30dbea99","line":245,"in_reply_to":"be018590_7aa49615","updated":"2022-05-09 12:18:12.000000000","message":"If I\u0027m not mistaken this is what the Doc says, I mean \"last-seen item\" here:\n\nhttps://docs.openstack.org/api-ref/dns/?expanded\u003dget-the-name-servers-for-a-zone-detail,list-tsigkeys-detail#:~:text\u003dThe%20ID%20of%20the%20last%2Dseen%20item.%20Use%20the%20limit%20parameter%20to%20make%20an%20initial%20limited%20request%20and%20use%20the%20ID%20of%20the%20last%2Dseen%20item%20from%20the%20response%20as%20the%20marker%20parameter%20value%20in%20a%20subsequent%20limited%20request.\n\nso that is why negative index [-1] is used here, to get the \"last-seen item\".","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ed6318c19b96ad22efd30d185a56a72fca9fc0e9","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        body \u003d self.admin_client.list_tsigkeys("},{"line_number":243,"context_line":"            params\u003d{\u0027limit\u0027: 2})[1][\u0027tsigkeys\u0027]"},{"line_number":244,"context_line":"        first_set_of_ids \u003d [item[\u0027id\u0027] for item in body]"},{"line_number":245,"context_line":"        marker \u003d [item[\u0027id\u0027] for item in body][-1]"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        LOG.info(\u0027Initiate list API request containing: \"marker\" to \u0027"},{"line_number":248,"context_line":"                 \u0027get the rest of tsigkeys)\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"be018590_7aa49615","line":245,"in_reply_to":"f1f3c332_20684439","updated":"2021-10-08 06:17:48.000000000","message":"Yep, seems like the test logic should be changed.\nWill do.","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ca3cb08cfa32b9ea9340f2fa425778266ab9ce6a","unresolved":true,"context_lines":[{"line_number":253,"context_line":"        LOG.info(\u0027Check that the length of received tsigkesy is: greater than \u0027"},{"line_number":254,"context_line":"                 \u0027\"2\" and that the previous listed tsigkeys IDs are not \u0027"},{"line_number":255,"context_line":"                 \u0027included in it\u0027)"},{"line_number":256,"context_line":"        self.assertGreaterEqual("},{"line_number":257,"context_line":"            2, len(second_set_of_ids),"},{"line_number":258,"context_line":"            \u0027Failed, we expecting to get at least 2 tsigkeys using \"marker\" \u0027"},{"line_number":259,"context_line":"            \u0027in URL query.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"22fca1ba_b2f6afc4","line":256,"updated":"2021-10-06 23:37:55.000000000","message":"line 250 is limiting the results to 2, so if the result set is larger than 2 we have a failure. Maybe this should be assertEqual?","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ed6318c19b96ad22efd30d185a56a72fca9fc0e9","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        LOG.info(\u0027Check that the length of received tsigkesy is: greater than \u0027"},{"line_number":254,"context_line":"                 \u0027\"2\" and that the previous listed tsigkeys IDs are not \u0027"},{"line_number":255,"context_line":"                 \u0027included in it\u0027)"},{"line_number":256,"context_line":"        self.assertGreaterEqual("},{"line_number":257,"context_line":"            2, len(second_set_of_ids),"},{"line_number":258,"context_line":"            \u0027Failed, we expecting to get at least 2 tsigkeys using \"marker\" \u0027"},{"line_number":259,"context_line":"            \u0027in URL query.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d9eece47_184b0792","line":256,"in_reply_to":"22fca1ba_b2f6afc4","updated":"2021-10-08 06:17:48.000000000","message":"Done","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ca3cb08cfa32b9ea9340f2fa425778266ab9ce6a","unresolved":true,"context_lines":[{"line_number":299,"context_line":"        LOG.info(\u0027As Admin, list all tsigkeys using \"asc\" to sort by \u0027"},{"line_number":300,"context_line":"                 \u0027ID (which is a default value for \"sort_key\")\u0027)"},{"line_number":301,"context_line":"        sorted_tsigkeys \u003d self.admin_client.list_tsigkeys("},{"line_number":302,"context_line":"            params\u003d{\u0027sort_dir\u0027: \u0027asc\u0027, \u0027sort_key\u0027: \u0027name\u0027})[1][\u0027tsigkeys\u0027]"},{"line_number":303,"context_line":"        sorted_by_ids \u003d [item[\u0027id\u0027] for item in sorted_tsigkeys]"},{"line_number":304,"context_line":"        self.assertTrue("},{"line_number":305,"context_line":"            set(sorted(created_tsigkey_ids)).issubset(set(sorted_by_ids)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"6b0731cf_b6a94560","line":302,"updated":"2021-10-06 23:37:55.000000000","message":"You could also add a check here for desc sort order.","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ed6318c19b96ad22efd30d185a56a72fca9fc0e9","unresolved":true,"context_lines":[{"line_number":299,"context_line":"        LOG.info(\u0027As Admin, list all tsigkeys using \"asc\" to sort by \u0027"},{"line_number":300,"context_line":"                 \u0027ID (which is a default value for \"sort_key\")\u0027)"},{"line_number":301,"context_line":"        sorted_tsigkeys \u003d self.admin_client.list_tsigkeys("},{"line_number":302,"context_line":"            params\u003d{\u0027sort_dir\u0027: \u0027asc\u0027, \u0027sort_key\u0027: \u0027name\u0027})[1][\u0027tsigkeys\u0027]"},{"line_number":303,"context_line":"        sorted_by_ids \u003d [item[\u0027id\u0027] for item in sorted_tsigkeys]"},{"line_number":304,"context_line":"        self.assertTrue("},{"line_number":305,"context_line":"            set(sorted(created_tsigkey_ids)).issubset(set(sorted_by_ids)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"009ada2d_285f3a3b","line":302,"in_reply_to":"6b0731cf_b6a94560","updated":"2021-10-08 06:17:48.000000000","message":"\"desc\" option is covered in L292","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ca3cb08cfa32b9ea9340f2fa425778266ab9ce6a","unresolved":true,"context_lines":[{"line_number":302,"context_line":"            params\u003d{\u0027sort_dir\u0027: \u0027asc\u0027, \u0027sort_key\u0027: \u0027name\u0027})[1][\u0027tsigkeys\u0027]"},{"line_number":303,"context_line":"        sorted_by_ids \u003d [item[\u0027id\u0027] for item in sorted_tsigkeys]"},{"line_number":304,"context_line":"        self.assertTrue("},{"line_number":305,"context_line":"            set(sorted(created_tsigkey_ids)).issubset(set(sorted_by_ids)),"},{"line_number":306,"context_line":"            \u0027Failed, tsgikeys IDs are not sorted in \"asc\" as expected\u0027)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        LOG.info(\u0027As Admin, list all tsigkeys using \"zababun\" direction \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"65eeffa9_a28a6a21","line":305,"updated":"2021-10-06 23:37:55.000000000","message":"Sets in python are unordered. This is not a valid test for sort order.\nhttps://docs.python.org/3.8/library/stdtypes.html#set-types-set-frozenset","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ed6318c19b96ad22efd30d185a56a72fca9fc0e9","unresolved":true,"context_lines":[{"line_number":302,"context_line":"            params\u003d{\u0027sort_dir\u0027: \u0027asc\u0027, \u0027sort_key\u0027: \u0027name\u0027})[1][\u0027tsigkeys\u0027]"},{"line_number":303,"context_line":"        sorted_by_ids \u003d [item[\u0027id\u0027] for item in sorted_tsigkeys]"},{"line_number":304,"context_line":"        self.assertTrue("},{"line_number":305,"context_line":"            set(sorted(created_tsigkey_ids)).issubset(set(sorted_by_ids)),"},{"line_number":306,"context_line":"            \u0027Failed, tsgikeys IDs are not sorted in \"asc\" as expected\u0027)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        LOG.info(\u0027As Admin, list all tsigkeys using \"zababun\" direction \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fdd89944_63d9d1cf","line":305,"in_reply_to":"65eeffa9_a28a6a21","updated":"2021-10-08 06:17:48.000000000","message":"That\u0027s correct, but in this case casting to set is for using its \"issubset\" method.\n\nFor example to check that this set:\n{\u0027tempest-aaa_tsgikey-340095022\u0027, \u0027tempest-bbb_tsgikey-283021586\u0027, \u0027tempest-ccc_tsgikey-1216767910\u0027}\nis a subset of:\n{\u0027tempest-test-tsig-76489441\u0027, \u0027tempest-test-tsig-1867975961\u0027, \u0027tempest-aaa_tsgikey-340095022\u0027, \u0027tempest-bbb_tsgikey-283021586\u0027, \u0027tempest-ccc_tsgikey-1216767910\u0027}","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ca3cb08cfa32b9ea9340f2fa425778266ab9ce6a","unresolved":true,"context_lines":[{"line_number":320,"context_line":"            params\u003d{\u0027sort_dir\u0027: \u0027asc\u0027, \u0027sort_key\u0027: \u0027zababun\u0027})"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @decorators.idempotent_id(\u00274162a840-d8b2-11eb-b95a-74e5f9e2a801\u0027)"},{"line_number":323,"context_line":"    def test_list_tsigkey_sort_by_name(self):"},{"line_number":324,"context_line":"        tsigkey_name \u003d data_utils.rand_name(\u0027ddd_tsgikey\u0027)"},{"line_number":325,"context_line":"        LOG.info(\u0027As Primary user create a zone for: {} \u0027.format(tsigkey_name))"},{"line_number":326,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"d36716d1_73289595","line":323,"updated":"2021-10-06 23:37:55.000000000","message":"This is testing filtering by name, so maybe a better title is:\ntest_list_tsigkey_filter_by_name?","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ed6318c19b96ad22efd30d185a56a72fca9fc0e9","unresolved":false,"context_lines":[{"line_number":320,"context_line":"            params\u003d{\u0027sort_dir\u0027: \u0027asc\u0027, \u0027sort_key\u0027: \u0027zababun\u0027})"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @decorators.idempotent_id(\u00274162a840-d8b2-11eb-b95a-74e5f9e2a801\u0027)"},{"line_number":323,"context_line":"    def test_list_tsigkey_sort_by_name(self):"},{"line_number":324,"context_line":"        tsigkey_name \u003d data_utils.rand_name(\u0027ddd_tsgikey\u0027)"},{"line_number":325,"context_line":"        LOG.info(\u0027As Primary user create a zone for: {} \u0027.format(tsigkey_name))"},{"line_number":326,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f535bc7_45103b94","line":323,"in_reply_to":"d36716d1_73289595","updated":"2021-10-08 06:17:48.000000000","message":"Done","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ca3cb08cfa32b9ea9340f2fa425778266ab9ce6a","unresolved":true,"context_lines":[{"line_number":345,"context_line":"            0, len(listed_tsigkeys), \u0027Failed, no tsigkey should be listed\u0027)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    @decorators.idempotent_id(\u0027e8bcf80a-d8b4-11eb-b95a-74e5f9e2a801\u0027)"},{"line_number":348,"context_line":"    def test_list_tsigkey_sort_by_scope(self):"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        LOG.info(\u0027Create tsigkey for a pool\u0027)"},{"line_number":351,"context_line":"        pool \u003d self.pool_admin_client.create_pool()[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"6e5bf14a_c1c25fca","line":348,"updated":"2021-10-06 23:37:55.000000000","message":"Again, I think this is a filter test.","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ed6318c19b96ad22efd30d185a56a72fca9fc0e9","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            0, len(listed_tsigkeys), \u0027Failed, no tsigkey should be listed\u0027)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    @decorators.idempotent_id(\u0027e8bcf80a-d8b4-11eb-b95a-74e5f9e2a801\u0027)"},{"line_number":348,"context_line":"    def test_list_tsigkey_sort_by_scope(self):"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        LOG.info(\u0027Create tsigkey for a pool\u0027)"},{"line_number":351,"context_line":"        pool \u003d self.pool_admin_client.create_pool()[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"0d98f5cc_0f88f2b3","line":348,"in_reply_to":"6e5bf14a_c1c25fca","updated":"2021-10-08 06:17:48.000000000","message":"Done","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ca3cb08cfa32b9ea9340f2fa425778266ab9ce6a","unresolved":true,"context_lines":[{"line_number":369,"context_line":"            {\u0027POOL\u0027}, set(listed_pool_scopes),"},{"line_number":370,"context_line":"            \u0027Failed, the only scopes expected to be listed are: \"POOL\"\u0027)"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        LOG.info(\u0027List all \"scope\u003dZONEL\" tsigkeys\u0027)"},{"line_number":373,"context_line":"        listed_zone_scopes \u003d ["},{"line_number":374,"context_line":"            item[\u0027scope\u0027] for item in self.admin_client.list_tsigkeys("},{"line_number":375,"context_line":"                params\u003d{\u0027scope\u0027: \u0027ZONE\u0027})[1][\u0027tsigkeys\u0027]]"}],"source_content_type":"text/x-python","patch_set":3,"id":"a659c433_907b3118","line":372,"range":{"start_line":372,"start_character":34,"end_line":372,"end_character":39},"updated":"2021-10-06 23:37:55.000000000","message":"Typo","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ed6318c19b96ad22efd30d185a56a72fca9fc0e9","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            {\u0027POOL\u0027}, set(listed_pool_scopes),"},{"line_number":370,"context_line":"            \u0027Failed, the only scopes expected to be listed are: \"POOL\"\u0027)"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        LOG.info(\u0027List all \"scope\u003dZONEL\" tsigkeys\u0027)"},{"line_number":373,"context_line":"        listed_zone_scopes \u003d ["},{"line_number":374,"context_line":"            item[\u0027scope\u0027] for item in self.admin_client.list_tsigkeys("},{"line_number":375,"context_line":"                params\u003d{\u0027scope\u0027: \u0027ZONE\u0027})[1][\u0027tsigkeys\u0027]]"}],"source_content_type":"text/x-python","patch_set":3,"id":"4e2b2b67_17c3fbb3","line":372,"range":{"start_line":372,"start_character":34,"end_line":372,"end_character":39},"in_reply_to":"a659c433_907b3118","updated":"2021-10-08 06:17:48.000000000","message":"Done","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ca3cb08cfa32b9ea9340f2fa425778266ab9ce6a","unresolved":true,"context_lines":[{"line_number":386,"context_line":"            \u0027Failed, no tsigkey is expected to be listed\u0027)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    @decorators.idempotent_id(\u0027794554f0-d8b8-11eb-b95a-74e5f9e2a801\u0027)"},{"line_number":389,"context_line":"    def test_list_tsigkey_sort_by_algorithm(self):"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        LOG.info(\u0027Create tsigkey for a pool\u0027)"},{"line_number":392,"context_line":"        algorithm \u003d \u0027hmac-sha256\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ef90d43e_d3f794f2","line":389,"updated":"2021-10-06 23:37:55.000000000","message":"This is a filter test.","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ed6318c19b96ad22efd30d185a56a72fca9fc0e9","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            \u0027Failed, no tsigkey is expected to be listed\u0027)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    @decorators.idempotent_id(\u0027794554f0-d8b8-11eb-b95a-74e5f9e2a801\u0027)"},{"line_number":389,"context_line":"    def test_list_tsigkey_sort_by_algorithm(self):"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        LOG.info(\u0027Create tsigkey for a pool\u0027)"},{"line_number":392,"context_line":"        algorithm \u003d \u0027hmac-sha256\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3e4d23c7_d2c46ac2","line":389,"in_reply_to":"ef90d43e_d3f794f2","updated":"2021-10-08 06:17:48.000000000","message":"Done","commit_id":"a3bfd682c727e2bc549d3fb16c1f6ae0bb0b47d2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"21562a8c55c0bbf0e60e4a4992471829a9509d75","unresolved":true,"context_lines":[{"line_number":280,"context_line":"            \u0027Failed, tsigkeys IDs received in two phases are not as expected\u0027)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    @decorators.idempotent_id(\u0027d5c6dfcc-d8af-11eb-b95a-74e5f9e2a801\u0027)"},{"line_number":283,"context_line":"    def test_list_tsigkey_sort_key_with_sort_direction(self):"},{"line_number":284,"context_line":"        names_to_create \u003d [data_utils.rand_name(name) for name in"},{"line_number":285,"context_line":"                           [\u0027bbb_tsgikey\u0027, \u0027aaa_tsgikey\u0027, \u0027ccc_tsgikey\u0027]]"},{"line_number":286,"context_line":"        created_tsigkey_ids \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"80025f76_bd0a3c6f","line":283,"updated":"2021-10-25 23:00:23.000000000","message":"This test is not testing that the results are sorted correctly. It appears to only be using issubset to check that the correct results are returned, but not the ordering.","commit_id":"da9f34d4a220284ef82b523f9c50e05f9a80eaa4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d2490a64399078f44b8a15e01271bead4dbc13e3","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            \u0027Failed, tsigkeys IDs received in two phases are not as expected\u0027)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    @decorators.idempotent_id(\u0027d5c6dfcc-d8af-11eb-b95a-74e5f9e2a801\u0027)"},{"line_number":283,"context_line":"    def test_list_tsigkey_sort_key_with_sort_direction(self):"},{"line_number":284,"context_line":"        names_to_create \u003d [data_utils.rand_name(name) for name in"},{"line_number":285,"context_line":"                           [\u0027bbb_tsgikey\u0027, \u0027aaa_tsgikey\u0027, \u0027ccc_tsgikey\u0027]]"},{"line_number":286,"context_line":"        created_tsigkey_ids \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"4af9010f_dce66dff","line":283,"in_reply_to":"80025f76_bd0a3c6f","updated":"2021-10-26 09:31:20.000000000","message":"Done","commit_id":"da9f34d4a220284ef82b523f9c50e05f9a80eaa4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"21562a8c55c0bbf0e60e4a4992471829a9509d75","unresolved":true,"context_lines":[{"line_number":319,"context_line":"        sorted_by_ids \u003d [item[\u0027id\u0027] for item in sorted_tsigkeys]"},{"line_number":320,"context_line":"        self.assertTrue("},{"line_number":321,"context_line":"            set(sorted(created_tsigkey_ids)).issubset(set(sorted_by_ids)),"},{"line_number":322,"context_line":"            \u0027Failed, tsgikeys IDs are not sorted in \"asc\" as expected\u0027)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        LOG.info(\u0027As Admin, list all tsigkeys using \"zababun\" direction \u0027"},{"line_number":325,"context_line":"                 \u0027to sort by names, expected: \"invalid_sort_dir\"\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"875911a0_2b446509","line":322,"updated":"2021-10-25 23:00:23.000000000","message":"If this use of sets here is not intended to test that the API returned the results in the correct order, then this assert message is incorrect.","commit_id":"da9f34d4a220284ef82b523f9c50e05f9a80eaa4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d2490a64399078f44b8a15e01271bead4dbc13e3","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        sorted_by_ids \u003d [item[\u0027id\u0027] for item in sorted_tsigkeys]"},{"line_number":320,"context_line":"        self.assertTrue("},{"line_number":321,"context_line":"            set(sorted(created_tsigkey_ids)).issubset(set(sorted_by_ids)),"},{"line_number":322,"context_line":"            \u0027Failed, tsgikeys IDs are not sorted in \"asc\" as expected\u0027)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        LOG.info(\u0027As Admin, list all tsigkeys using \"zababun\" direction \u0027"},{"line_number":325,"context_line":"                 \u0027to sort by names, expected: \"invalid_sort_dir\"\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"f8db540b_894641c3","line":322,"in_reply_to":"875911a0_2b446509","updated":"2021-10-26 09:31:20.000000000","message":"Done","commit_id":"da9f34d4a220284ef82b523f9c50e05f9a80eaa4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"11423d9d6da8e1c8d9be0ceea8396ac58939216c","unresolved":true,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        LOG.info(\u0027Get the marker to be used for subsequent request\u0027)"},{"line_number":268,"context_line":"        first_set_of_ids \u003d [item[\u0027id\u0027] for item in body]"},{"line_number":269,"context_line":"        marker \u003d [item[\u0027id\u0027] for item in body][-1]"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        LOG.info(\u0027Use marker for subsequent request to get the rest of \u0027"},{"line_number":272,"context_line":"                 \u0027tsigkeys that contains \"{}*\" in their \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"72fc70c4_77f46e8b","line":269,"range":{"start_line":269,"start_character":7,"end_line":269,"end_character":50},"updated":"2022-05-05 23:10:10.000000000","message":"The comment from patchset 3 is still valid I think.\nWe should be looking for the \"next\" link in the response and not guessing that it\u0027s the -1 item in the response.","commit_id":"b4e5bc9f48b24e37be7b7d52dabd031f5cdd9360"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2f92123f240f196cdf36daf90bc602a8aa08b9da","unresolved":true,"context_lines":[{"line_number":157,"context_line":"                 \u0027and \"name\u003d{}*\"\u0027.format(test_tsigkeys_name))"},{"line_number":158,"context_line":"        body \u003d self.admin_client.list_tsigkeys("},{"line_number":159,"context_line":"            params\u003d{"},{"line_number":160,"context_line":"                \u0027limit\u0027: 2, \u0027name\u0027: test_tsigkeys_name + \u0027*\u0027})[1][\u0027tsigkeys\u0027]"},{"line_number":161,"context_line":"        self.assertEqual(2, len(body),"},{"line_number":162,"context_line":"                         \u0027Failed, response is not limited as expected\u0027)"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"a15502c5_09cdec9b","line":160,"range":{"start_line":160,"start_character":65,"end_line":160,"end_character":77},"updated":"2022-05-09 22:35:57.000000000","message":"This is part of the issue, it\u0027s pulling out only the tsigkeys in the \"body\" variable.\n\nHere is the data from a list_tsigkeys call:\nhttps://paste.openstack.org/show/814245/\n\nThe links section at the bottom has the \"next\" link that provides the marker that would be used to get the next \"page\" of data.","commit_id":"a6060841b0f7d23401f96d9aaeb8f0265af4c84d"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"cd0bd985f512f452897663a965eda01ace032c9e","unresolved":true,"context_lines":[{"line_number":157,"context_line":"                 \u0027and \"name\u003d{}*\"\u0027.format(test_tsigkeys_name))"},{"line_number":158,"context_line":"        body \u003d self.admin_client.list_tsigkeys("},{"line_number":159,"context_line":"            params\u003d{"},{"line_number":160,"context_line":"                \u0027limit\u0027: 2, \u0027name\u0027: test_tsigkeys_name + \u0027*\u0027})[1][\u0027tsigkeys\u0027]"},{"line_number":161,"context_line":"        self.assertEqual(2, len(body),"},{"line_number":162,"context_line":"                         \u0027Failed, response is not limited as expected\u0027)"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"217679e5_197adf94","line":160,"range":{"start_line":160,"start_character":65,"end_line":160,"end_character":77},"in_reply_to":"a15502c5_09cdec9b","updated":"2022-05-10 08:06:37.000000000","message":"OK, got it, thanks!\nWill be added into the next patchset.","commit_id":"a6060841b0f7d23401f96d9aaeb8f0265af4c84d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f88c284b1fa17fec93f4ec6ae53d6e8f3924714e","unresolved":true,"context_lines":[{"line_number":81,"context_line":"            \"name\": dns_data_utils.rand_zone_name(\u0027test_pool\u0027),"},{"line_number":82,"context_line":"            \"ns_records\": [{\"hostname\": \"ns1.example.org.\", \"priority\": 1}]}"},{"line_number":83,"context_line":"        LOG.info(\u0027Create a pool resource\u0027)"},{"line_number":84,"context_line":"        pool \u003d self.pool_admin_client.create_pool("},{"line_number":85,"context_line":"            pool_name\u003dpool_data[\"name\"],"},{"line_number":86,"context_line":"            ns_records\u003dpool_data[\"ns_records\"],"},{"line_number":87,"context_line":"            project_id\u003dself.os_admin.credentials.project_id)[1]"}],"source_content_type":"text/x-python","patch_set":11,"id":"0097ebde_d1880152","line":84,"updated":"2022-05-10 22:14:10.000000000","message":"This concerns me as the pool create API is marked deprecated and is not used in any other test.\nhttps://github.com/openstack/designate/blob/master/designate/api/v2/controllers/pools.py#L69\nI wonder if we can figure out another way to test this. Maybe setup another pool as part of tempest/devstack?","commit_id":"3dc770238aff33975da8b61204d7a30a94a6ef8d"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f1973b216e1b6a602fba10b29db5236c418d94c8","unresolved":true,"context_lines":[{"line_number":81,"context_line":"            \"name\": dns_data_utils.rand_zone_name(\u0027test_pool\u0027),"},{"line_number":82,"context_line":"            \"ns_records\": [{\"hostname\": \"ns1.example.org.\", \"priority\": 1}]}"},{"line_number":83,"context_line":"        LOG.info(\u0027Create a pool resource\u0027)"},{"line_number":84,"context_line":"        pool \u003d self.pool_admin_client.create_pool("},{"line_number":85,"context_line":"            pool_name\u003dpool_data[\"name\"],"},{"line_number":86,"context_line":"            ns_records\u003dpool_data[\"ns_records\"],"},{"line_number":87,"context_line":"            project_id\u003dself.os_admin.credentials.project_id)[1]"}],"source_content_type":"text/x-python","patch_set":11,"id":"a07dfe14_5ede667a","line":84,"in_reply_to":"0097ebde_d1880152","updated":"2022-05-11 07:22:53.000000000","message":"OK, I\u0027ll use \"list_pool\" API instead, to get the first available existing pool ID (as by now we have the default pool only) so the default pool ID will be used in this test.","commit_id":"3dc770238aff33975da8b61204d7a30a94a6ef8d"}]}