)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de5073cffd8b1e21544634bda44d0dc8f42a09ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"54100b5c_fb17f74a","updated":"2021-10-19 11:39:45.000000000","message":"recheck","commit_id":"85dce8e4c34a03e664491401beb4ba3b40a55128"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9badce744f08bdf13d8b3420c92a7e3734a6745b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6a2312f5_2c5bba85","updated":"2021-10-26 21:29:42.000000000","message":"LGTM","commit_id":"f0afa236668b9315ed6e05bf11a4efc278727d76"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7fe12e764d3522557351b07c6cc79f13de677762","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"047d4dfb_bfde7969","updated":"2021-10-30 17:26:25.000000000","message":"recheck","commit_id":"f0afa236668b9315ed6e05bf11a4efc278727d76"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4fc1f0050bb14d8b42596686c7636d5b09e52f71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"22cc7830_2f004575","updated":"2021-10-30 09:31:07.000000000","message":"recheck","commit_id":"f0afa236668b9315ed6e05bf11a4efc278727d76"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"371c65bac82768487da9e3bc67092be31f2910b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"31fe8e9e_6314d951","updated":"2021-10-30 19:36:20.000000000","message":"recheck","commit_id":"f0afa236668b9315ed6e05bf11a4efc278727d76"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ed6fda46f0ea270ec950ea5b7e12eea2bb8c3f48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"960d5f4d_6e1565f6","updated":"2021-10-30 05:34:22.000000000","message":"recheck","commit_id":"f0afa236668b9315ed6e05bf11a4efc278727d76"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"634f9551c0bc8ad0f3f4e9deff7c9f253b4cae9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a46afc0a_444e5ce0","updated":"2021-10-30 14:21:02.000000000","message":"recheck","commit_id":"f0afa236668b9315ed6e05bf11a4efc278727d76"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"d50cf082aafab5f98912eddacbd795c3845b3900","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6fd2b435_f56af509","updated":"2021-10-30 05:23:38.000000000","message":"recheck DesignatePtrRecord","commit_id":"f0afa236668b9315ed6e05bf11a4efc278727d76"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"99be4db9aaa6308cb3303f0433b6c7c9de83751e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d6e7485f_3943fa01","updated":"2021-10-30 22:10:55.000000000","message":"recheck The read operation timed out","commit_id":"f0afa236668b9315ed6e05bf11a4efc278727d76"}],"designate_tempest_plugin/tests/api/v2/test_blacklists.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e02e6829b9d00f0dded334734c0e10fe3058d93e","unresolved":true,"context_lines":[{"line_number":224,"context_line":"    def test_create_zone_fails_if_matches_blacklist_regex(self):"},{"line_number":225,"context_line":"        LOG.info(\u0027Create a blacklist\u0027)"},{"line_number":226,"context_line":"        blacklist \u003d {"},{"line_number":227,"context_line":"            \u0027pattern\u0027: \u0027^a\u0027,"},{"line_number":228,"context_line":"            \u0027description\u0027: \u0027All zone names starts with \"a\" \u0027"},{"line_number":229,"context_line":"                           \u0027character are blocked\u0027}"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a978a491_d33cd980","line":227,"updated":"2021-06-29 23:49:42.000000000","message":"This regex is not doing what you think it is.\nThis regex will match only the letter \u0027a\u0027.\nYou probably want \u0027^a.*\u0027","commit_id":"d6b1b10f0d074dd934dd00112cf8eb3b1126f510"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"a0d8c7f3121c5ed57a49fb417e26cc1aff610931","unresolved":true,"context_lines":[{"line_number":224,"context_line":"    def test_create_zone_fails_if_matches_blacklist_regex(self):"},{"line_number":225,"context_line":"        LOG.info(\u0027Create a blacklist\u0027)"},{"line_number":226,"context_line":"        blacklist \u003d {"},{"line_number":227,"context_line":"            \u0027pattern\u0027: \u0027^a\u0027,"},{"line_number":228,"context_line":"            \u0027description\u0027: \u0027All zone names starts with \"a\" \u0027"},{"line_number":229,"context_line":"                           \u0027character are blocked\u0027}"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"023c5a49_355a228b","line":227,"in_reply_to":"a978a491_d33cd980","updated":"2021-06-30 09:32:59.000000000","message":"Yep, regex was incorrect + I had to use Primary user to crate a zone.\nFixed.","commit_id":"d6b1b10f0d074dd934dd00112cf8eb3b1126f510"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e02e6829b9d00f0dded334734c0e10fe3058d93e","unresolved":true,"context_lines":[{"line_number":237,"context_line":"        # name\u003d\u0027a\u0027+dns_data_utils.rand_zone_name())"},{"line_number":238,"context_line":"        self.assertRaisesDns("},{"line_number":239,"context_line":"            lib_exc.BadRequest, \u0027invalid_zone_name\u0027, 400,"},{"line_number":240,"context_line":"            self.admin_zone_client.create_zone,"},{"line_number":241,"context_line":"            name\u003d\u0027a\u0027 + dns_data_utils.rand_zone_name())"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @decorators.idempotent_id(\u00276956f20c-d8d5-11eb-bcdc-74e5f9e2a801\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4fe8a8c3_ae53ac29","line":240,"updated":"2021-06-29 23:49:42.000000000","message":"Users with the Admin role bypass the denylist check.","commit_id":"d6b1b10f0d074dd934dd00112cf8eb3b1126f510"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"a0d8c7f3121c5ed57a49fb417e26cc1aff610931","unresolved":true,"context_lines":[{"line_number":237,"context_line":"        # name\u003d\u0027a\u0027+dns_data_utils.rand_zone_name())"},{"line_number":238,"context_line":"        self.assertRaisesDns("},{"line_number":239,"context_line":"            lib_exc.BadRequest, \u0027invalid_zone_name\u0027, 400,"},{"line_number":240,"context_line":"            self.admin_zone_client.create_zone,"},{"line_number":241,"context_line":"            name\u003d\u0027a\u0027 + dns_data_utils.rand_zone_name())"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @decorators.idempotent_id(\u00276956f20c-d8d5-11eb-bcdc-74e5f9e2a801\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d0ec6b8e_69959a54","line":240,"in_reply_to":"4fe8a8c3_ae53ac29","updated":"2021-06-30 09:32:59.000000000","message":"Fixed, works for a Primary user as expected.","commit_id":"d6b1b10f0d074dd934dd00112cf8eb3b1126f510"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e02e6829b9d00f0dded334734c0e10fe3058d93e","unresolved":true,"context_lines":[{"line_number":258,"context_line":"        # self.admin_zone_client.create_zone(name\u003dzone_name)"},{"line_number":259,"context_line":"        self.assertRaisesDns("},{"line_number":260,"context_line":"            lib_exc.BadRequest, \u0027invalid_zone_name\u0027, 400,"},{"line_number":261,"context_line":"            self.admin_zone_client.create_zone, name\u003dzone_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a3d752da_f67bdfff","line":261,"updated":"2021-06-29 23:49:42.000000000","message":"Users with an Admin role bypass the zone denylist.\n\nMichael just fixed this missing information in the documentation here:\nhttps://review.opendev.org/c/openstack/designate/+/793325/4/doc/source/admin/blacklists.rst#65","commit_id":"d6b1b10f0d074dd934dd00112cf8eb3b1126f510"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"a0d8c7f3121c5ed57a49fb417e26cc1aff610931","unresolved":true,"context_lines":[{"line_number":258,"context_line":"        # self.admin_zone_client.create_zone(name\u003dzone_name)"},{"line_number":259,"context_line":"        self.assertRaisesDns("},{"line_number":260,"context_line":"            lib_exc.BadRequest, \u0027invalid_zone_name\u0027, 400,"},{"line_number":261,"context_line":"            self.admin_zone_client.create_zone, name\u003dzone_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7b2b03ea_d680a844","line":261,"in_reply_to":"a3d752da_f67bdfff","updated":"2021-06-30 09:32:59.000000000","message":"Great, I\u0027ve added a dedicated test for that in a new patchset.","commit_id":"d6b1b10f0d074dd934dd00112cf8eb3b1126f510"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1fdf87756ac62374f556cace93ba410167944577","unresolved":true,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        LOG.info(\u0027As Admin user try to create zones that are \u0027"},{"line_number":270,"context_line":"                 \u0027supposed to be blocked\u0027)"},{"line_number":271,"context_line":"        self.admin_zone_client.create_zone("},{"line_number":272,"context_line":"            name\u003d\u0027a\u0027 + dns_data_utils.rand_zone_name())"},{"line_number":273,"context_line":"        self.admin_zone_client.create_zone(name\u003dzone_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aefb441_072fc15b","line":271,"updated":"2021-06-30 23:04:27.000000000","message":"This needs an addCleanup hook.","commit_id":"f0b2ded213e7afecab0fb1c87a7caf549391fe77"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"186746ac554a616a0942e15ff2d1560dfc6b7f49","unresolved":true,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        LOG.info(\u0027As Admin user try to create zones that are \u0027"},{"line_number":270,"context_line":"                 \u0027supposed to be blocked\u0027)"},{"line_number":271,"context_line":"        self.admin_zone_client.create_zone("},{"line_number":272,"context_line":"            name\u003d\u0027a\u0027 + dns_data_utils.rand_zone_name())"},{"line_number":273,"context_line":"        self.admin_zone_client.create_zone(name\u003dzone_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d3e13c54_dfc7a319","line":271,"in_reply_to":"5aefb441_072fc15b","updated":"2021-07-01 08:53:37.000000000","message":"Yep, I missed that, thanks!","commit_id":"f0b2ded213e7afecab0fb1c87a7caf549391fe77"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1fdf87756ac62374f556cace93ba410167944577","unresolved":true,"context_lines":[{"line_number":270,"context_line":"                 \u0027supposed to be blocked\u0027)"},{"line_number":271,"context_line":"        self.admin_zone_client.create_zone("},{"line_number":272,"context_line":"            name\u003d\u0027a\u0027 + dns_data_utils.rand_zone_name())"},{"line_number":273,"context_line":"        self.admin_zone_client.create_zone(name\u003dzone_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0ff7c5f3_ec905318","line":273,"updated":"2021-06-30 23:04:27.000000000","message":"This needs an addCleanup hook.","commit_id":"f0b2ded213e7afecab0fb1c87a7caf549391fe77"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"186746ac554a616a0942e15ff2d1560dfc6b7f49","unresolved":true,"context_lines":[{"line_number":270,"context_line":"                 \u0027supposed to be blocked\u0027)"},{"line_number":271,"context_line":"        self.admin_zone_client.create_zone("},{"line_number":272,"context_line":"            name\u003d\u0027a\u0027 + dns_data_utils.rand_zone_name())"},{"line_number":273,"context_line":"        self.admin_zone_client.create_zone(name\u003dzone_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a41f80ff_47c4dd1d","line":273,"in_reply_to":"0ff7c5f3_ec905318","updated":"2021-07-01 08:53:37.000000000","message":"Yep, I missed that, thanks!","commit_id":"f0b2ded213e7afecab0fb1c87a7caf549391fe77"}]}