)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"34ca7e9f2375616fec6fa4eef5950553eb3601cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d3089b1d_232d38a3","updated":"2021-10-13 16:30:50.000000000","message":"I think it would be good to have Ghanshyam take a look from a tempest config perspetive.","commit_id":"a3a236331c95b1a4cfb5975a0ef7f216feef15b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5af95e8b678553b63fac8fdae3908030170c667e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e37214b2_47d91f19","updated":"2021-10-15 15:02:40.000000000","message":"configuration looks fine but we should add a non-voting job with enforce_new_defaults and enforce_scope True so that we can verify if system scoped calls are passing.","commit_id":"a3a236331c95b1a4cfb5975a0ef7f216feef15b4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d525a57941a82d9aedc904b6ddfb21e1543c9c26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fff0bb39_9452bab4","in_reply_to":"956a7f0a_a32a0953","updated":"2021-10-16 14:46:29.000000000","message":"That job exists, it is added in https://review.opendev.org/c/openstack/designate/+/800727 and run in the patch https://review.opendev.org/c/openstack/designate-tempest-plugin/+/806291/6 which is on top of this one","commit_id":"a3a236331c95b1a4cfb5975a0ef7f216feef15b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c06332daab20f7c16dd009ae67281b9daf9b5b62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"956a7f0a_a32a0953","in_reply_to":"e37214b2_47d91f19","updated":"2021-10-15 15:04:32.000000000","message":"this is example of job - https://github.com/openstack/devstack/blob/82facd6edf7cefac1ab68de4fe9054d7c4cb50db/.zuul.yaml#L583\n\nwe can set it via a var in devstack plugin.","commit_id":"a3a236331c95b1a4cfb5975a0ef7f216feef15b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b586820e4743dc0e8bb0d98e3dbde2b9ff6111c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0206ac38_b45cb9c0","in_reply_to":"fff0bb39_9452bab4","updated":"2021-10-17 16:16:40.000000000","message":"thanks, I too verified that API calls are with system scoped token\n\nexample: https://zuul.opendev.org/t/openstack/build/37a51cd85c7042039ca8af73c0d55589/log/controller/logs/tempest_log.txt#16753-16756","commit_id":"a3a236331c95b1a4cfb5975a0ef7f216feef15b4"}],"designate_tempest_plugin/config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5af95e8b678553b63fac8fdae3908030170c667e","unresolved":true,"context_lines":[{"line_number":79,"context_line":"                default\u003dTrue,"},{"line_number":80,"context_line":"                help\u003d\"Is https://bugs.launchpad.net/designate/+bug/1573141 \""},{"line_number":81,"context_line":"                \"fixed\"),"},{"line_number":82,"context_line":"    # Note: Also see the enforce_scope section (from tempest) for Designate API"},{"line_number":83,"context_line":"    #       scope checking setting."},{"line_number":84,"context_line":"    cfg.BoolOpt(\u0027enforce_new_defaults\u0027,"},{"line_number":85,"context_line":"                default\u003dFalse,"},{"line_number":86,"context_line":"                help\u003d\u0027Does the dns service API policies enforce \u0027"},{"line_number":87,"context_line":"                     \u0027the new keystone default roles? This configuration \u0027"},{"line_number":88,"context_line":"                     \u0027value should be same as designate.conf: \u0027"},{"line_number":89,"context_line":"                     \u0027[oslo_policy].enforce_new_defaults option.\u0027),"},{"line_number":90,"context_line":"]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"# Extending this enforce_scope group defined in tempest"}],"source_content_type":"text/x-python","patch_set":10,"id":"70d2ce39_767630b5","line":89,"range":{"start_line":82,"start_character":0,"end_line":89,"end_character":67},"updated":"2021-10-15 15:02:40.000000000","message":"for reviewer, if you are wondering where this is used. This is used in later patch in this series-  https://review.opendev.org/c/openstack/designate-tempest-plugin/+/806291/6/designate_tempest_plugin/tests/api/v2/test_blacklists.py#60","commit_id":"a3a236331c95b1a4cfb5975a0ef7f216feef15b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5af95e8b678553b63fac8fdae3908030170c667e","unresolved":true,"context_lines":[{"line_number":89,"context_line":"                     \u0027[oslo_policy].enforce_new_defaults option.\u0027),"},{"line_number":90,"context_line":"]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"# Extending this enforce_scope group defined in tempest"},{"line_number":93,"context_line":"enforce_scope_group \u003d cfg.OptGroup(name\u003d\"enforce_scope\","},{"line_number":94,"context_line":"                                   title\u003d\"OpenStack Services with \""},{"line_number":95,"context_line":"                                         \"enforce scope\")"},{"line_number":96,"context_line":"EnforceScopeGroup \u003d ["},{"line_number":97,"context_line":"    cfg.BoolOpt(\u0027designate\u0027,"},{"line_number":98,"context_line":"                default\u003dFalse,"},{"line_number":99,"context_line":"                help\u003d\u0027Does the dns service API policies enforce \u0027"},{"line_number":100,"context_line":"                     \u0027scope? This configuration value should be same as \u0027"},{"line_number":101,"context_line":"                     \u0027designate.conf: [oslo_policy].enforce_scope option.\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"ea2dc6c9_93673ab8","line":98,"range":{"start_line":92,"start_character":0,"end_line":98,"end_character":30},"updated":"2021-10-15 15:02:40.000000000","message":"+1.","commit_id":"a3a236331c95b1a4cfb5975a0ef7f216feef15b4"}],"designate_tempest_plugin/tests/api/v2/test_pool.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d525a57941a82d9aedc904b6ddfb21e1543c9c26","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    def test_create_pool(self):"},{"line_number":57,"context_line":"        pool_data \u003d {"},{"line_number":58,"context_line":"                      \"name\": \"Example Pool\","},{"line_number":59,"context_line":"                      \"project_id\": \"1\","},{"line_number":60,"context_line":"                      \"ns_records\": [{"},{"line_number":61,"context_line":"                          \"hostname\": \"ns1.example.org.\","},{"line_number":62,"context_line":"                          \"priority\": 1}"}],"source_content_type":"text/x-python","patch_set":10,"id":"1670daef_7ec96721","line":59,"updated":"2021-10-16 14:46:29.000000000","message":"Use some FakeID here, too?","commit_id":"a3a236331c95b1a4cfb5975a0ef7f216feef15b4"}],"designate_tempest_plugin/tests/api/v2/test_quotas.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c53148d0725bacef009b6f388d0652c9be75a118","unresolved":true,"context_lines":[{"line_number":26,"context_line":"class QuotasV2Test(base.BaseDnsV2Test):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    credentials \u003d [\"primary\", \"admin\", \"system_admin\", \"alt\"]"},{"line_number":29,"context_line":"    all_projects_header \u003d {\u0027X-Auth-All-Projects\u0027: True}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"b208c117_dfaaa08c","line":29,"updated":"2021-09-23 20:11:15.000000000","message":"As this is also used elsewhere, maybe move it into BaseDnsV2Test and reduce duplication?","commit_id":"3bec16c4ca1aa2eede190fd9d2694e30054c253d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ebaebbbaceeaf82e4e48746ed9949a1f80cf7f8f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class QuotasV2Test(base.BaseDnsV2Test):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    credentials \u003d [\"primary\", \"admin\", \"system_admin\", \"alt\"]"},{"line_number":29,"context_line":"    all_projects_header \u003d {\u0027X-Auth-All-Projects\u0027: True}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"493d14af_d2eeb71d","line":29,"in_reply_to":"b208c117_dfaaa08c","updated":"2021-09-23 21:35:26.000000000","message":"Done","commit_id":"3bec16c4ca1aa2eede190fd9d2694e30054c253d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c53148d0725bacef009b6f388d0652c9be75a118","unresolved":true,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _store_quotas(self, project_id, cleanup\u003dTrue):"},{"line_number":58,"context_line":"        \"\"\"Remember current quotas and reset them after the test\"\"\""},{"line_number":59,"context_line":"        params \u003d {}"},{"line_number":60,"context_line":"        params[\u0027project_id\u0027] \u003d project_id"},{"line_number":61,"context_line":"        params[\u0027headers\u0027] \u003d self.all_projects_header"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"8f497913_9a78fe2c","line":59,"updated":"2021-09-23 20:11:15.000000000","message":"Since the next two lines are unconditional now, you could move them into the initialization here directly.","commit_id":"3bec16c4ca1aa2eede190fd9d2694e30054c253d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ebaebbbaceeaf82e4e48746ed9949a1f80cf7f8f","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _store_quotas(self, project_id, cleanup\u003dTrue):"},{"line_number":58,"context_line":"        \"\"\"Remember current quotas and reset them after the test\"\"\""},{"line_number":59,"context_line":"        params \u003d {}"},{"line_number":60,"context_line":"        params[\u0027project_id\u0027] \u003d project_id"},{"line_number":61,"context_line":"        params[\u0027headers\u0027] \u003d self.all_projects_header"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"2e73c30a_cc1f4bac","line":59,"in_reply_to":"8f497913_9a78fe2c","updated":"2021-09-23 21:35:26.000000000","message":"Done","commit_id":"3bec16c4ca1aa2eede190fd9d2694e30054c253d"}],"designate_tempest_plugin/tests/api/v2/test_zones.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c53148d0725bacef009b6f388d0652c9be75a118","unresolved":true,"context_lines":[{"line_number":270,"context_line":"            self.alt_client, alt_zone[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        LOG.info(\u0027Create zone \"C\" using Admin client\u0027)"},{"line_number":273,"context_line":"        admin_zone \u003d self.admin_client.create_zone(project_id\u003d\"1\")[1]"},{"line_number":274,"context_line":"        self.addCleanup("},{"line_number":275,"context_line":"            self.wait_zone_delete, self.admin_client, admin_zone[\u0027id\u0027],"},{"line_number":276,"context_line":"            headers\u003d{\u0027x-auth-all-projects\u0027: True})"}],"source_content_type":"text/x-python","patch_set":8,"id":"f259efd3_4cf95576","line":273,"updated":"2021-09-23 20:11:15.000000000","message":"Where does this project_id come from? If it can be any value, maybe use something like \"dummy\" instead to make it more obvious? Or add an explaining comment?","commit_id":"3bec16c4ca1aa2eede190fd9d2694e30054c253d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ebaebbbaceeaf82e4e48746ed9949a1f80cf7f8f","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            self.alt_client, alt_zone[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        LOG.info(\u0027Create zone \"C\" using Admin client\u0027)"},{"line_number":273,"context_line":"        admin_zone \u003d self.admin_client.create_zone(project_id\u003d\"1\")[1]"},{"line_number":274,"context_line":"        self.addCleanup("},{"line_number":275,"context_line":"            self.wait_zone_delete, self.admin_client, admin_zone[\u0027id\u0027],"},{"line_number":276,"context_line":"            headers\u003d{\u0027x-auth-all-projects\u0027: True})"}],"source_content_type":"text/x-python","patch_set":8,"id":"717b0f67_b3c871e9","line":273,"in_reply_to":"f259efd3_4cf95576","updated":"2021-09-23 21:35:26.000000000","message":"Done","commit_id":"3bec16c4ca1aa2eede190fd9d2694e30054c253d"}]}