)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f3e2311681a7c7204d3dd8058ef0a5fcb2982053","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6e900eaa_1992b0ab","updated":"2021-10-12 09:18:13.000000000","message":"recheck","commit_id":"e5cae730eb8b9e99805dd95e66b7982351719b52"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"bcdd6fc7acb726b949d77761848cf3660ebd5b9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"70ed61a7_9873f709","updated":"2021-10-12 10:48:24.000000000","message":"recheck","commit_id":"e5cae730eb8b9e99805dd95e66b7982351719b52"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"5e13de5beffec1ba4bb02670c4475d9d79971116","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"72c35440_e367cda4","updated":"2021-10-18 10:27:47.000000000","message":"Looks good to me","commit_id":"1262939212ea80b2b6001a1648685e1d851bffc4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6f7f7fe205c603b93b12b14b760d3f398e8864c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2ae496b2_ca940b8e","updated":"2021-10-29 19:53:10.000000000","message":"LGTM","commit_id":"919aa2834289c23ed406d119489a08649adec3f3"}],"designate_tempest_plugin/tests/api/v2/test_enabled_api_version.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b546efeea5472394a11214024e72f3c706ee4743","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class DesignateApiVersion(base.BaseDnsV2Test):"},{"line_number":23,"context_line":"    credentials \u003d [\u0027admin\u0027, \u0027primary\u0027]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"a3bf0230_808e6daf","line":23,"updated":"2021-10-08 09:12:25.000000000","message":"From what I see, it is not being used in the rest of the module.","commit_id":"5fc33fe6e45dc58bfad624c159a7ae86d90f53af"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d7df3e5c9de57d3cd3fd300f286f7f526790c217","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class DesignateApiVersion(base.BaseDnsV2Test):"},{"line_number":23,"context_line":"    credentials \u003d [\u0027admin\u0027, \u0027primary\u0027]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"13c4adc8_26c35596","line":23,"in_reply_to":"a3bf0230_808e6daf","updated":"2021-10-08 15:42:08.000000000","message":"It\u0027s not used directly, I mean you won\u0027t see \"credentials\" used in this module directly, but without defining this list, setup_clients (L32) will fail to initiate admin and primary clients","commit_id":"5fc33fe6e45dc58bfad624c159a7ae86d90f53af"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b546efeea5472394a11214024e72f3c706ee4743","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @decorators.idempotent_id(\u0027aa84986e-f2ad-11eb-b58d-74e5f9e2a801\u0027)"},{"line_number":39,"context_line":"    def test_list_enabled_api_versions(self):"},{"line_number":40,"context_line":"        for user in [\u0027admin\u0027, \u0027primary\u0027]:"},{"line_number":41,"context_line":"            if user \u003d\u003d \u0027admin\u0027:"},{"line_number":42,"context_line":"                versions \u003d self.admin_client.list_enabled_api_versions()[1]["},{"line_number":43,"context_line":"                    \u0027versions\u0027][\u0027values\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"b7ab7da1_52c7910e","line":40,"updated":"2021-10-08 09:12:25.000000000","message":"Maybe we could save some code with a for loop like this:\nfor version in [self.admin_client...versions, self.primary_client....versions]","commit_id":"5fc33fe6e45dc58bfad624c159a7ae86d90f53af"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d7df3e5c9de57d3cd3fd300f286f7f526790c217","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @decorators.idempotent_id(\u0027aa84986e-f2ad-11eb-b58d-74e5f9e2a801\u0027)"},{"line_number":39,"context_line":"    def test_list_enabled_api_versions(self):"},{"line_number":40,"context_line":"        for user in [\u0027admin\u0027, \u0027primary\u0027]:"},{"line_number":41,"context_line":"            if user \u003d\u003d \u0027admin\u0027:"},{"line_number":42,"context_line":"                versions \u003d self.admin_client.list_enabled_api_versions()[1]["},{"line_number":43,"context_line":"                    \u0027versions\u0027][\u0027values\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"d4ccc5ed_3ec63225","line":40,"in_reply_to":"b7ab7da1_52c7910e","updated":"2021-10-08 15:42:08.000000000","message":"It\u0027s not critical + code is readable.","commit_id":"5fc33fe6e45dc58bfad624c159a7ae86d90f53af"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b546efeea5472394a11214024e72f3c706ee4743","unresolved":true,"context_lines":[{"line_number":44,"context_line":"            if user \u003d\u003d \u0027primary\u0027:"},{"line_number":45,"context_line":"                versions \u003d self.primary_client.list_enabled_api_versions()[1]["},{"line_number":46,"context_line":"                    \u0027versions\u0027][\u0027values\u0027]"},{"line_number":47,"context_line":"            LOG.info(\u0027Received enabled API versions are:\u0027.format(versions))"},{"line_number":48,"context_line":"            for item in versions:"},{"line_number":49,"context_line":"                enabled_ids \u003d ["},{"line_number":50,"context_line":"                    item[\u0027id\u0027] for key in item.keys() if key \u003d\u003d \u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"2f2d816e_7bebb08f","line":47,"updated":"2021-10-08 09:12:25.000000000","message":"I think there is a missing {} here.","commit_id":"5fc33fe6e45dc58bfad624c159a7ae86d90f53af"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d7df3e5c9de57d3cd3fd300f286f7f526790c217","unresolved":true,"context_lines":[{"line_number":44,"context_line":"            if user \u003d\u003d \u0027primary\u0027:"},{"line_number":45,"context_line":"                versions \u003d self.primary_client.list_enabled_api_versions()[1]["},{"line_number":46,"context_line":"                    \u0027versions\u0027][\u0027values\u0027]"},{"line_number":47,"context_line":"            LOG.info(\u0027Received enabled API versions are:\u0027.format(versions))"},{"line_number":48,"context_line":"            for item in versions:"},{"line_number":49,"context_line":"                enabled_ids \u003d ["},{"line_number":50,"context_line":"                    item[\u0027id\u0027] for key in item.keys() if key \u003d\u003d \u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1e466853_05d6f8c1","line":47,"in_reply_to":"2f2d816e_7bebb08f","updated":"2021-10-08 15:42:08.000000000","message":"Agree, will be fixed in the next patch.","commit_id":"5fc33fe6e45dc58bfad624c159a7ae86d90f53af"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"de6aede6b46e3d766f9f26da4019622357303c88","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @decorators.idempotent_id(\u0027aa84986e-f2ad-11eb-b58d-74e5f9e2a801\u0027)"},{"line_number":39,"context_line":"    def test_list_enabled_api_versions(self):"},{"line_number":40,"context_line":"        for user in [\u0027admin\u0027, \u0027primary\u0027]:"},{"line_number":41,"context_line":"            if user \u003d\u003d \u0027admin\u0027:"},{"line_number":42,"context_line":"                versions \u003d self.admin_client.list_enabled_api_versions()[1]["},{"line_number":43,"context_line":"                    \u0027versions\u0027][\u0027values\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"78fcf2ae_dd1d6f83","line":40,"updated":"2021-10-27 20:35:26.000000000","message":"Listing the API versions does not require a token, so calling the client without a token is also an option.","commit_id":"1262939212ea80b2b6001a1648685e1d851bffc4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3164c58fb6e379d8efe6aafcbb8f505ca43d0e56","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @decorators.idempotent_id(\u0027aa84986e-f2ad-11eb-b58d-74e5f9e2a801\u0027)"},{"line_number":39,"context_line":"    def test_list_enabled_api_versions(self):"},{"line_number":40,"context_line":"        for user in [\u0027admin\u0027, \u0027primary\u0027]:"},{"line_number":41,"context_line":"            if user \u003d\u003d \u0027admin\u0027:"},{"line_number":42,"context_line":"                versions \u003d self.admin_client.list_enabled_api_versions()[1]["},{"line_number":43,"context_line":"                    \u0027versions\u0027][\u0027values\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"0d86ce5b_9a93225f","line":40,"in_reply_to":"78fcf2ae_dd1d6f83","updated":"2021-10-28 15:56:02.000000000","message":"Done","commit_id":"1262939212ea80b2b6001a1648685e1d851bffc4"}]}