)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c2c894412f0cdd84d32bbe2d5b3b10e2c9497e0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2e5f2a33_e63f7e5e","updated":"2021-11-05 18:02:55.000000000","message":"LGTM","commit_id":"5260227cc78b68c07cc4876d74b980f6fd8efff9"}],"designate_tempest_plugin/data_utils.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bc0c4152f5fb1fc753ba408fcdf291826c9b59b9","unresolved":true,"context_lines":[{"line_number":141,"context_line":"        \u0027ttl\u0027: ttl}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"def rand_a_recordset(zone_name, ip\u003dNone, number_of_ips\u003dNone, **kwargs):"},{"line_number":145,"context_line":"    if number_of_ips is not None:"},{"line_number":146,"context_line":"        records \u003d [rand_ip() for _ in range(number_of_ips)]"},{"line_number":147,"context_line":"        return rand_recordset_data(\u0027A\u0027, zone_name, records\u003drecords, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"85958f5c_1fab456b","line":144,"updated":"2021-10-27 19:46:03.000000000","message":"I don\u0027t see this function being used anywhere other than this patch.\nI think we should just change it to take the number of IPs and simplify this function.","commit_id":"2cf737d6b0ef61ee166106b52a56ceba5e2588e7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c6c9a24cfa26dd6df84c867dee5c1167a269690b","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        \u0027ttl\u0027: ttl}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"def rand_a_recordset(zone_name, ip\u003dNone, number_of_ips\u003dNone, **kwargs):"},{"line_number":145,"context_line":"    if number_of_ips is not None:"},{"line_number":146,"context_line":"        records \u003d [rand_ip() for _ in range(number_of_ips)]"},{"line_number":147,"context_line":"        return rand_recordset_data(\u0027A\u0027, zone_name, records\u003drecords, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"8254b861_14753d34","line":144,"in_reply_to":"85958f5c_1fab456b","updated":"2021-10-28 15:56:26.000000000","message":"Done","commit_id":"2cf737d6b0ef61ee166106b52a56ceba5e2588e7"}],"designate_tempest_plugin/tests/api/v2/test_recordset.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bc0c4152f5fb1fc753ba408fcdf291826c9b59b9","unresolved":true,"context_lines":[{"line_number":297,"context_line":"                \u0027recordsets: {}\u0027.format(recordset_id, primary_recordsets_ids))"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    @decorators.idempotent_id(\u002748013b7c-f526-11eb-b04f-74e5f9e2a801\u0027)"},{"line_number":300,"context_line":"    def test_create_a_recordset_multiply_ips(self):"},{"line_number":301,"context_line":"        recordset_data \u003d data_utils.rand_a_recordset("},{"line_number":302,"context_line":"            zone_name\u003dself.zone[\u0027name\u0027], number_of_ips\u003d10)"},{"line_number":303,"context_line":"        LOG.info(\u0027Create A type Recordset using a list of IPs as\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"36ecb59a_61b85197","line":300,"updated":"2021-10-27 19:46:03.000000000","message":"test_create_a_recordset_multiply_ips -\u003e test_create_A_recordset_multiple_ips","commit_id":"2cf737d6b0ef61ee166106b52a56ceba5e2588e7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c6c9a24cfa26dd6df84c867dee5c1167a269690b","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                \u0027recordsets: {}\u0027.format(recordset_id, primary_recordsets_ids))"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    @decorators.idempotent_id(\u002748013b7c-f526-11eb-b04f-74e5f9e2a801\u0027)"},{"line_number":300,"context_line":"    def test_create_a_recordset_multiply_ips(self):"},{"line_number":301,"context_line":"        recordset_data \u003d data_utils.rand_a_recordset("},{"line_number":302,"context_line":"            zone_name\u003dself.zone[\u0027name\u0027], number_of_ips\u003d10)"},{"line_number":303,"context_line":"        LOG.info(\u0027Create A type Recordset using a list of IPs as\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"c6906385_6bc591c6","line":300,"in_reply_to":"36ecb59a_61b85197","updated":"2021-10-28 15:56:26.000000000","message":"Done","commit_id":"2cf737d6b0ef61ee166106b52a56ceba5e2588e7"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"bce53ab8fd05856991d47a7a9a5b11531f689942","unresolved":true,"context_lines":[{"line_number":303,"context_line":"        LOG.info(\u0027Create A type Recordset using a list of IPs as\u0027"},{"line_number":304,"context_line":"                 \u0027 records:{}\u0027.format(recordset_data))"},{"line_number":305,"context_line":"        resp, body \u003d self.client.create_recordset("},{"line_number":306,"context_line":"            self.zone[\u0027id\u0027], recordset_data)"},{"line_number":307,"context_line":"        LOG.info(\u0027Ensure we respond with PENDING\u0027)"},{"line_number":308,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"00944be3_df9d0ff1","line":306,"updated":"2021-10-08 09:59:36.000000000","message":"Do we have a cleanup for this recordset?","commit_id":"2cf737d6b0ef61ee166106b52a56ceba5e2588e7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bc0c4152f5fb1fc753ba408fcdf291826c9b59b9","unresolved":true,"context_lines":[{"line_number":303,"context_line":"        LOG.info(\u0027Create A type Recordset using a list of IPs as\u0027"},{"line_number":304,"context_line":"                 \u0027 records:{}\u0027.format(recordset_data))"},{"line_number":305,"context_line":"        resp, body \u003d self.client.create_recordset("},{"line_number":306,"context_line":"            self.zone[\u0027id\u0027], recordset_data)"},{"line_number":307,"context_line":"        LOG.info(\u0027Ensure we respond with PENDING\u0027)"},{"line_number":308,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1959eb97_d0a148c8","line":306,"in_reply_to":"00944be3_df9d0ff1","updated":"2021-10-27 19:46:03.000000000","message":"+1, this needs a cleanup","commit_id":"2cf737d6b0ef61ee166106b52a56ceba5e2588e7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c6c9a24cfa26dd6df84c867dee5c1167a269690b","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        LOG.info(\u0027Create A type Recordset using a list of IPs as\u0027"},{"line_number":304,"context_line":"                 \u0027 records:{}\u0027.format(recordset_data))"},{"line_number":305,"context_line":"        resp, body \u003d self.client.create_recordset("},{"line_number":306,"context_line":"            self.zone[\u0027id\u0027], recordset_data)"},{"line_number":307,"context_line":"        LOG.info(\u0027Ensure we respond with PENDING\u0027)"},{"line_number":308,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"86300c96_ba50d198","line":306,"in_reply_to":"1959eb97_d0a148c8","updated":"2021-10-28 15:56:26.000000000","message":"Done","commit_id":"2cf737d6b0ef61ee166106b52a56ceba5e2588e7"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"087736134ccaaa3ae4eaf4212aa869cfbc648140","unresolved":true,"context_lines":[{"line_number":305,"context_line":"        resp, body \u003d self.client.create_recordset("},{"line_number":306,"context_line":"            self.zone[\u0027id\u0027], recordset_data)"},{"line_number":307,"context_line":"        LOG.info(\u0027Ensure we respond with PENDING\u0027)"},{"line_number":308,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":1,"id":"7e950a21_846f51e4","line":308,"updated":"2021-10-08 10:03:51.000000000","message":"nit: switch \u0027PENDING\u0027 with common.PENDING","commit_id":"2cf737d6b0ef61ee166106b52a56ceba5e2588e7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bc0c4152f5fb1fc753ba408fcdf291826c9b59b9","unresolved":true,"context_lines":[{"line_number":305,"context_line":"        resp, body \u003d self.client.create_recordset("},{"line_number":306,"context_line":"            self.zone[\u0027id\u0027], recordset_data)"},{"line_number":307,"context_line":"        LOG.info(\u0027Ensure we respond with PENDING\u0027)"},{"line_number":308,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":1,"id":"d443941e_586f0dc6","line":308,"in_reply_to":"7e950a21_846f51e4","updated":"2021-10-27 19:46:03.000000000","message":"+1, there is a constant for this.","commit_id":"2cf737d6b0ef61ee166106b52a56ceba5e2588e7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c6c9a24cfa26dd6df84c867dee5c1167a269690b","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        resp, body \u003d self.client.create_recordset("},{"line_number":306,"context_line":"            self.zone[\u0027id\u0027], recordset_data)"},{"line_number":307,"context_line":"        LOG.info(\u0027Ensure we respond with PENDING\u0027)"},{"line_number":308,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":1,"id":"d1f4f8c4_21c54fd1","line":308,"in_reply_to":"d443941e_586f0dc6","updated":"2021-10-28 15:56:26.000000000","message":"Done","commit_id":"2cf737d6b0ef61ee166106b52a56ceba5e2588e7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bc0c4152f5fb1fc753ba408fcdf291826c9b59b9","unresolved":true,"context_lines":[{"line_number":306,"context_line":"            self.zone[\u0027id\u0027], recordset_data)"},{"line_number":307,"context_line":"        LOG.info(\u0027Ensure we respond with PENDING\u0027)"},{"line_number":308,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"@ddt.ddt"},{"line_number":312,"context_line":"class RecordsetsNegativeTest(BaseRecordsetsTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3e1437d4_373428d8","line":309,"updated":"2021-10-27 19:46:03.000000000","message":"Maybe we should also do some validation of the response from the call?","commit_id":"2cf737d6b0ef61ee166106b52a56ceba5e2588e7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c6c9a24cfa26dd6df84c867dee5c1167a269690b","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            self.zone[\u0027id\u0027], recordset_data)"},{"line_number":307,"context_line":"        LOG.info(\u0027Ensure we respond with PENDING\u0027)"},{"line_number":308,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"@ddt.ddt"},{"line_number":312,"context_line":"class RecordsetsNegativeTest(BaseRecordsetsTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"516a5e0d_11a0a85d","line":309,"in_reply_to":"3e1437d4_373428d8","updated":"2021-10-28 15:56:26.000000000","message":"Done","commit_id":"2cf737d6b0ef61ee166106b52a56ceba5e2588e7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c2c894412f0cdd84d32bbe2d5b3b10e2c9497e0b","unresolved":true,"context_lines":[{"line_number":334,"context_line":"                \u0027recordsets: {}\u0027.format(recordset_id, primary_recordsets_ids))"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    @decorators.idempotent_id(\u002748013b7c-f526-11eb-b04f-74e5f9e2a801\u0027)"},{"line_number":337,"context_line":"    def test_create_A_recordset_multiply_ips(self):"},{"line_number":338,"context_line":"        LOG.info(\u0027Create A type Recordset using a list of random IPs\u0027)"},{"line_number":339,"context_line":"        recordset_data \u003d data_utils.rand_a_recordset("},{"line_number":340,"context_line":"            zone_name\u003dself.zone[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"731edd9c_887414c3","line":337,"updated":"2021-11-05 18:02:55.000000000","message":"nit: multiply-\u003emultiple was my original comment.","commit_id":"5260227cc78b68c07cc4876d74b980f6fd8efff9"}]}