)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"36b5d86aaa35291ba5cd4c59fce3140bf9cbe314","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new test cases for TLD test suite"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) \"test_create_tld_as_primary_fails\""},{"line_number":10,"context_line":"   Only Admin user is supposed to be able to manage TLDs."},{"line_number":11,"context_line":"   Ensure that Primary is not authorized to use TLDs API."},{"line_number":12,"context_line":"2) \"test_zone_creation_fails_for_not_existing_tld\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"8e4f2af3_605791cc","line":9,"updated":"2021-10-28 23:02:11.000000000","message":"This commit message needs to be updated as well.","commit_id":"f64c0c2298ca9e55344adda7cab5cf8ca3a4282f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"152e135e7163d1f7fc3688814d11026703f65510","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d27f03b8_e0532d13","updated":"2021-10-12 10:49:23.000000000","message":"recheck","commit_id":"13d2cb00afee8a570f67fb846eaaccd7f4843930"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"97739a81b38632e45263c267dde75589a07f81fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de903017_9abd5bbb","updated":"2021-10-12 09:30:43.000000000","message":"recheck","commit_id":"13d2cb00afee8a570f67fb846eaaccd7f4843930"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8358f958c06bda1452d457c9218664e8451f1d4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"753bf076_1294ecc8","updated":"2021-10-28 23:01:38.000000000","message":"Two comments here, otherwise looks good.","commit_id":"f64c0c2298ca9e55344adda7cab5cf8ca3a4282f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"87857264a739275d1fa5ab299c26cac1b764209e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"acbbb573_56610639","updated":"2022-01-07 18:01:28.000000000","message":"LGTM","commit_id":"766fab8ca397733d0009478877353ec5d4194360"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"782862fb36b5a1c9de5f6d94395a1a60c7711628","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5f2775c1_81c2c8e3","updated":"2022-01-07 18:06:09.000000000","message":"Opps, missed an admin client that isn\u0027t setup right for the new scoped tokens changes.","commit_id":"766fab8ca397733d0009478877353ec5d4194360"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4a17c4a70ced9b43e034f329bdc87e919edf4f37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a00f3472_36803f33","updated":"2021-12-12 14:26:06.000000000","message":"recheck","commit_id":"766fab8ca397733d0009478877353ec5d4194360"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"3f7bda1ee515b49f190f9fa64481f11ecf969318","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d40deeb0_84b17f72","updated":"2022-04-01 16:09:17.000000000","message":"LGTM","commit_id":"e366890644742818ae61b9a330b2cf3670c76d58"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9dca57a506cb021377e9c9c90774a29e666e3437","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d3068747_59e4b17a","updated":"2022-04-03 11:24:29.000000000","message":"Michael is right, this test is a duplication of \"https://github.com/openstack/designate-tempest-plugin/blob/master/designate_tempest_plugin/tests/api/v2/test_tld.py#L120\".\nI\u0027ll abandon this patch.","commit_id":"e366890644742818ae61b9a330b2cf3670c76d58"}],"designate_tempest_plugin/tests/api/v2/test_tld.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b5d24d75328322121c7bd4d150765c5f36390c15","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        self.assertEqual(tld_data[\"name\"], tld[\u0027name\u0027])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @decorators.idempotent_id(\u00277b0058f2-f5e7-11eb-9cf6-74e5f9e2a801\u0027)"},{"line_number":73,"context_line":"    def test_create_tld_as_primary_fails(self):"},{"line_number":74,"context_line":"        LOG.info(\u0027Try to create a TLD as Primary user\u0027)"},{"line_number":75,"context_line":"        tld_data \u003d {"},{"line_number":76,"context_line":"                     \"name\": \"org\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3996ceb0_3841e95e","line":73,"updated":"2021-10-06 21:53:09.000000000","message":"This is duplicate to the test \"test_create_tld_as_primary_user\" in patch https://review.opendev.org/c/openstack/designate-tempest-plugin/+/797904","commit_id":"5b6163436e3bf3f61a250d579abc18147bd09403"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5030d4b8522b92a895bdd35ddb0edba4fb8d1035","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        self.assertEqual(tld_data[\"name\"], tld[\u0027name\u0027])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @decorators.idempotent_id(\u00277b0058f2-f5e7-11eb-9cf6-74e5f9e2a801\u0027)"},{"line_number":73,"context_line":"    def test_create_tld_as_primary_fails(self):"},{"line_number":74,"context_line":"        LOG.info(\u0027Try to create a TLD as Primary user\u0027)"},{"line_number":75,"context_line":"        tld_data \u003d {"},{"line_number":76,"context_line":"                     \"name\": \"org\","}],"source_content_type":"text/x-python","patch_set":1,"id":"d753fc1d_ecef1814","line":73,"in_reply_to":"3996ceb0_3841e95e","updated":"2021-10-08 06:40:41.000000000","message":"Yep, it\u0027s duplicated and will be removed.","commit_id":"5b6163436e3bf3f61a250d579abc18147bd09403"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9dca57a506cb021377e9c9c90774a29e666e3437","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.assertEqual(tld_data[\"name\"], tld[\u0027name\u0027])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @decorators.idempotent_id(\u00277b0058f2-f5e7-11eb-9cf6-74e5f9e2a801\u0027)"},{"line_number":73,"context_line":"    def test_create_tld_as_primary_fails(self):"},{"line_number":74,"context_line":"        LOG.info(\u0027Try to create a TLD as Primary user\u0027)"},{"line_number":75,"context_line":"        tld_data \u003d {"},{"line_number":76,"context_line":"                     \"name\": \"org\","}],"source_content_type":"text/x-python","patch_set":1,"id":"471c7723_c018f5b2","line":73,"in_reply_to":"d753fc1d_ecef1814","updated":"2022-04-03 11:24:29.000000000","message":"Done","commit_id":"5b6163436e3bf3f61a250d579abc18147bd09403"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b5d24d75328322121c7bd4d150765c5f36390c15","unresolved":true,"context_lines":[{"line_number":141,"context_line":"            lambda: self.admin_client.get(uri))"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @decorators.idempotent_id(\u002711c1bbf8-f5db-11eb-9cf6-74e5f9e2a801\u0027)"},{"line_number":144,"context_line":"    def test_zone_creation_fails_with_invalid_tld(self):"},{"line_number":145,"context_line":"        LOG.info(\u0027Create a \"zah\" TLD\u0027)"},{"line_number":146,"context_line":"        tld_data \u003d {"},{"line_number":147,"context_line":"                     \"name\": \"zah\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5036f154_bda28dd3","line":144,"updated":"2021-10-06 21:53:09.000000000","message":"Isn\u0027t this also a duplicate to https://review.opendev.org/c/openstack/designate-tempest-plugin/+/797904 \ntest_create_zone_for_not_existing_tld ?","commit_id":"5b6163436e3bf3f61a250d579abc18147bd09403"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5030d4b8522b92a895bdd35ddb0edba4fb8d1035","unresolved":true,"context_lines":[{"line_number":141,"context_line":"            lambda: self.admin_client.get(uri))"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @decorators.idempotent_id(\u002711c1bbf8-f5db-11eb-9cf6-74e5f9e2a801\u0027)"},{"line_number":144,"context_line":"    def test_zone_creation_fails_with_invalid_tld(self):"},{"line_number":145,"context_line":"        LOG.info(\u0027Create a \"zah\" TLD\u0027)"},{"line_number":146,"context_line":"        tld_data \u003d {"},{"line_number":147,"context_line":"                     \"name\": \"zah\","}],"source_content_type":"text/x-python","patch_set":1,"id":"27c18826_05d7ce52","line":144,"in_reply_to":"5036f154_bda28dd3","updated":"2021-10-08 06:40:41.000000000","message":"This test is not duplicated.\n\nUnlike \"test_create_invalid_tld\" that is trying to create not valid TLDs only, this test\nis trying to create a Zone using mot existing TLD.\nSo, it\u0027s about Zone creation, I\u0027ll rename test name to avoid misleading.","commit_id":"5b6163436e3bf3f61a250d579abc18147bd09403"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8358f958c06bda1452d457c9218664e8451f1d4b","unresolved":true,"context_lines":[{"line_number":48,"context_line":"            cls.admin_client \u003d cls.os_admin.dns_v2.TldClient()"},{"line_number":49,"context_line":"        cls.primary_client \u003d cls.os_primary.dns_v2.TldClient()"},{"line_number":50,"context_line":"        cls.primary_zone_client \u003d cls.os_primary.dns_v2.ZonesClient()"},{"line_number":51,"context_line":"        cls.primary_client \u003d cls.os_primary.dns_v2.TldClient()"},{"line_number":52,"context_line":"        cls.admin_zone_client \u003d cls.os_admin.dns_v2.ZonesClient()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"5b32ddb6_589e39b9","line":51,"updated":"2021-10-28 23:01:38.000000000","message":"This is duplicate to line 49","commit_id":"f64c0c2298ca9e55344adda7cab5cf8ca3a4282f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"22043222d7fa5211dd2be989e6477e6ccc070d75","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            cls.admin_client \u003d cls.os_admin.dns_v2.TldClient()"},{"line_number":49,"context_line":"        cls.primary_client \u003d cls.os_primary.dns_v2.TldClient()"},{"line_number":50,"context_line":"        cls.primary_zone_client \u003d cls.os_primary.dns_v2.ZonesClient()"},{"line_number":51,"context_line":"        cls.primary_client \u003d cls.os_primary.dns_v2.TldClient()"},{"line_number":52,"context_line":"        cls.admin_zone_client \u003d cls.os_admin.dns_v2.ZonesClient()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"c909665f_2fe96510","line":51,"in_reply_to":"5b32ddb6_589e39b9","updated":"2021-10-29 18:42:43.000000000","message":"Done","commit_id":"f64c0c2298ca9e55344adda7cab5cf8ca3a4282f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8358f958c06bda1452d457c9218664e8451f1d4b","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        not_existing_tld \u003d \u0027zah\u0027"},{"line_number":229,"context_line":"        while not_existing_tld in existing_tlds:"},{"line_number":230,"context_line":"            not_existing_tld \u003d \u0027\u0027.join("},{"line_number":231,"context_line":"                [random.choice(string.ascii_lowercase) for _ in range(3)])"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        LOG.info(\u0027Ensure Zone creation FAIL when used TLD:{} does\u0027"},{"line_number":234,"context_line":"                 \u0027 not exist\u0027.format(not_existing_tld))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ec8f4d85_3b0c09ae","line":231,"updated":"2021-10-28 23:01:38.000000000","message":"Is this section really necessary? Could you just use \"nonexistenttld\" instead and save this test run time?","commit_id":"f64c0c2298ca9e55344adda7cab5cf8ca3a4282f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"3f7bda1ee515b49f190f9fa64481f11ecf969318","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        not_existing_tld \u003d \u0027zah\u0027"},{"line_number":229,"context_line":"        while not_existing_tld in existing_tlds:"},{"line_number":230,"context_line":"            not_existing_tld \u003d \u0027\u0027.join("},{"line_number":231,"context_line":"                [random.choice(string.ascii_lowercase) for _ in range(3)])"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        LOG.info(\u0027Ensure Zone creation FAIL when used TLD:{} does\u0027"},{"line_number":234,"context_line":"                 \u0027 not exist\u0027.format(not_existing_tld))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ea5ecbe_32b20259","line":231,"in_reply_to":"e0c69304_580686e7","updated":"2022-04-01 16:09:17.000000000","message":"2022-04-01 16:06:08.756 1810466 DEBUG designate_tempest_plugin.tests.api.v2.test_tld [-] dkehn **** loop time: 14046      ns total: 37134034 ns test_zone_creation_fails_for_not_existing_tld /opt/stack/designate-tempest-plugin/designate_tem     pest_plugin/tests/api/v2/test_tld.py:291","commit_id":"f64c0c2298ca9e55344adda7cab5cf8ca3a4282f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"22043222d7fa5211dd2be989e6477e6ccc070d75","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        not_existing_tld \u003d \u0027zah\u0027"},{"line_number":229,"context_line":"        while not_existing_tld in existing_tlds:"},{"line_number":230,"context_line":"            not_existing_tld \u003d \u0027\u0027.join("},{"line_number":231,"context_line":"                [random.choice(string.ascii_lowercase) for _ in range(3)])"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        LOG.info(\u0027Ensure Zone creation FAIL when used TLD:{} does\u0027"},{"line_number":234,"context_line":"                 \u0027 not exist\u0027.format(not_existing_tld))"}],"source_content_type":"text/x-python","patch_set":4,"id":"e0c69304_580686e7","line":231,"in_reply_to":"ec8f4d85_3b0c09ae","updated":"2021-10-29 18:42:43.000000000","message":"I would prefer not to remove this part.\nIt doesn\u0027t affect the execution time drastically and what is more important is that the TLD will be unique and not in use by some other test running in parallel.","commit_id":"f64c0c2298ca9e55344adda7cab5cf8ca3a4282f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"782862fb36b5a1c9de5f6d94395a1a60c7711628","unresolved":true,"context_lines":[{"line_number":48,"context_line":"            cls.admin_client \u003d cls.os_admin.dns_v2.TldClient()"},{"line_number":49,"context_line":"        cls.primary_zone_client \u003d cls.os_primary.dns_v2.ZonesClient()"},{"line_number":50,"context_line":"        cls.primary_client \u003d cls.os_primary.dns_v2.TldClient()"},{"line_number":51,"context_line":"        cls.admin_zone_client \u003d cls.os_admin.dns_v2.ZonesClient()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @classmethod"},{"line_number":54,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"a03e3ae3_e78f4da1","line":51,"updated":"2022-01-07 18:06:09.000000000","message":"This needs to be moved up in to the enforce_scope check above.","commit_id":"766fab8ca397733d0009478877353ec5d4194360"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"a66e3a07b0d3f8802cda52eb45ce9600fd0c6e95","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            cls.admin_client \u003d cls.os_admin.dns_v2.TldClient()"},{"line_number":49,"context_line":"        cls.primary_zone_client \u003d cls.os_primary.dns_v2.ZonesClient()"},{"line_number":50,"context_line":"        cls.primary_client \u003d cls.os_primary.dns_v2.TldClient()"},{"line_number":51,"context_line":"        cls.admin_zone_client \u003d cls.os_admin.dns_v2.ZonesClient()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @classmethod"},{"line_number":54,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"97eb82f7_1966b1b4","line":51,"in_reply_to":"a03e3ae3_e78f4da1","updated":"2022-01-09 11:41:46.000000000","message":"Done","commit_id":"766fab8ca397733d0009478877353ec5d4194360"}]}
