)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a15ad1816b5d97d983066579b7ac0635face6011","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b89d589f_3bea9e46","updated":"2021-10-18 22:57:08.000000000","message":"Marking WIP until the PTG discussion on this topic.","commit_id":"89dc6679503bc446c31a510ec5d08a1887efab55"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"09b21d7c50d0a9334514d02650a22a1e9d60f33d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"77a71f5a_c158989d","updated":"2021-10-23 11:43:53.000000000","message":"Not directly related, but we should consider what we actually want to require in refstack testing. Like should a deployment not be certified if it denylists the \"example.org\" domain? Or if it has a TLD list that doesn\u0027t include \".org\"?","commit_id":"89dc6679503bc446c31a510ec5d08a1887efab55"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"98847dfb38d9443186c2c7163ed1744e5ff3dbe4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a95ac810_8723ba88","updated":"2021-10-27 19:39:39.000000000","message":"recheck","commit_id":"f871a0e74f91e417adae5d7dd2a6cc17a62ba347"}],"designate_tempest_plugin/tests/api/v2/test_recordset.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"09b21d7c50d0a9334514d02650a22a1e9d60f33d","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # We cannot use DDT here as these tests are part of the refstack"},{"line_number":85,"context_line":"    # interoperability test suite and need to be unique for traceability."},{"line_number":86,"context_line":"    def _test_create_all_recordset_types(self, name, type, records):"},{"line_number":87,"context_line":"        if name is not None:"},{"line_number":88,"context_line":"            recordset_name \u003d name + \".\" + self.zone[\u0027name\u0027]"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"38a689a5_ff6558a2","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":40},"updated":"2021-10-23 11:43:53.000000000","message":"Actually this function now only does one type, not all. Maybe name it just \"_test_create_recordset_type()\"?","commit_id":"89dc6679503bc446c31a510ec5d08a1887efab55"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8084d137d42e407a0a7b562c515debc89ead657b","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # We cannot use DDT here as these tests are part of the refstack"},{"line_number":85,"context_line":"    # interoperability test suite and need to be unique for traceability."},{"line_number":86,"context_line":"    def _test_create_all_recordset_types(self, name, type, records):"},{"line_number":87,"context_line":"        if name is not None:"},{"line_number":88,"context_line":"            recordset_name \u003d name + \".\" + self.zone[\u0027name\u0027]"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6d3bed34_cd800ad7","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":40},"in_reply_to":"25f6d4b5_34a67707","updated":"2021-10-26 20:47:33.000000000","message":"I think we should just do this right now, I have updated the patch to remove _all.","commit_id":"89dc6679503bc446c31a510ec5d08a1887efab55"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"45de71196f953c5c41b536f4540658f8d527209e","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # We cannot use DDT here as these tests are part of the refstack"},{"line_number":85,"context_line":"    # interoperability test suite and need to be unique for traceability."},{"line_number":86,"context_line":"    def _test_create_all_recordset_types(self, name, type, records):"},{"line_number":87,"context_line":"        if name is not None:"},{"line_number":88,"context_line":"            recordset_name \u003d name + \".\" + self.zone[\u0027name\u0027]"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"25f6d4b5_34a67707","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":40},"in_reply_to":"38a689a5_ff6558a2","updated":"2021-10-26 07:15:00.000000000","message":"My comment mainly was about dropping the \"_all_\" part of the names, not \"type\" vs. \"types\". But we can also do that in a followup.","commit_id":"89dc6679503bc446c31a510ec5d08a1887efab55"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"09b21d7c50d0a9334514d02650a22a1e9d60f33d","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @decorators.idempotent_id(\u0027d03b69a5-5052-43bc-a38a-b511b6b34304\u0027)"},{"line_number":107,"context_line":"    def test_create_all_recordset_types_A(self):"},{"line_number":108,"context_line":"        self._test_create_all_recordset_types("},{"line_number":109,"context_line":"            \"www\", \"A\", [\"192.0.2.1\", \"192.0.2.2\", \"192.0.2.3\"])"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1667cfbf_c534c099","line":107,"range":{"start_line":107,"start_character":8,"end_line":107,"end_character":41},"updated":"2021-10-23 11:43:53.000000000","message":"Same for these or do we need to keep the old names for refstack? Otherwise \"test_create_recordset_type_A\" would seem to fit better.","commit_id":"89dc6679503bc446c31a510ec5d08a1887efab55"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ed218d2a4528a454acc32486fb26d09a2032c061","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        self.assertEqual(\u0027PENDING\u0027, body[\u0027status\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @decorators.idempotent_id(\u0027d03b69a5-5052-43bc-a38a-b511b6b34304\u0027)"},{"line_number":107,"context_line":"    def test_create_all_recordset_types_A(self):"},{"line_number":108,"context_line":"        self._test_create_all_recordset_types("},{"line_number":109,"context_line":"            \"www\", \"A\", [\"192.0.2.1\", \"192.0.2.2\", \"192.0.2.3\"])"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e2d2adb3_f08b0efb","line":107,"range":{"start_line":107,"start_character":8,"end_line":107,"end_character":41},"in_reply_to":"1667cfbf_c534c099","updated":"2021-10-25 19:22:26.000000000","message":"I did leave it simply for consistency, but given they are all getting IDs now and the test names will no longer have numerical elements, we might as well change them now.","commit_id":"89dc6679503bc446c31a510ec5d08a1887efab55"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"09b21d7c50d0a9334514d02650a22a1e9d60f33d","unresolved":true,"context_lines":[{"line_number":153,"context_line":"            \"www\", \"TXT\", [\"\\\"Any Old Text Goes Here\\\"\"])"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @decorators.idempotent_id(\u002769f002e5-6511-43d3-abae-7abdd45ae03e\u0027)"},{"line_number":156,"context_line":"    @ddt.file_data(\"recordset_wildcard_data.json\")"},{"line_number":157,"context_line":"    def test_create_wildcard_recordset(self, name, type, records):"},{"line_number":158,"context_line":"        if name is not None:"},{"line_number":159,"context_line":"            recordset_name \u003d name + \".\" + self.zone[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"0cc9d801_089f6f9e","line":156,"updated":"2021-10-23 11:43:53.000000000","message":"What about these?","commit_id":"89dc6679503bc446c31a510ec5d08a1887efab55"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5a6b13225ea2804b6db0b74f2e4d7662388e6158","unresolved":true,"context_lines":[{"line_number":153,"context_line":"            \"www\", \"TXT\", [\"\\\"Any Old Text Goes Here\\\"\"])"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @decorators.idempotent_id(\u002769f002e5-6511-43d3-abae-7abdd45ae03e\u0027)"},{"line_number":156,"context_line":"    @ddt.file_data(\"recordset_wildcard_data.json\")"},{"line_number":157,"context_line":"    def test_create_wildcard_recordset(self, name, type, records):"},{"line_number":158,"context_line":"        if name is not None:"},{"line_number":159,"context_line":"            recordset_name \u003d name + \".\" + self.zone[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"addca614_89a2523e","line":156,"in_reply_to":"0cc9d801_089f6f9e","updated":"2021-10-25 18:23:39.000000000","message":"In this patch I only unrolled the tests that are part of the refstack list.\n\nI think we should consider removing DDT usage all together in a future patch to simplify the tests and allow better tracking.","commit_id":"89dc6679503bc446c31a510ec5d08a1887efab55"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"45de71196f953c5c41b536f4540658f8d527209e","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            \"www\", \"TXT\", [\"\\\"Any Old Text Goes Here\\\"\"])"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @decorators.idempotent_id(\u002769f002e5-6511-43d3-abae-7abdd45ae03e\u0027)"},{"line_number":156,"context_line":"    @ddt.file_data(\"recordset_wildcard_data.json\")"},{"line_number":157,"context_line":"    def test_create_wildcard_recordset(self, name, type, records):"},{"line_number":158,"context_line":"        if name is not None:"},{"line_number":159,"context_line":"            recordset_name \u003d name + \".\" + self.zone[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"df1f4fa4_bd0baae6","line":156,"in_reply_to":"addca614_89a2523e","updated":"2021-10-26 07:15:00.000000000","message":"Too bad that refstack doesn\u0027t test wildcards, but o.k.","commit_id":"89dc6679503bc446c31a510ec5d08a1887efab55"}]}