)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30678,"name":"Emanuel Andrecut","email":"emanuel.andrecut@fleio.com","username":"andrecutm"},"change_message_id":"c60b272a4732437d62057ba92b754fef39e24005","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b2aeed91_2dced99d","updated":"2021-10-25 17:13:20.000000000","message":"recheck\n","commit_id":"f8ab059e9c44d6d0abec605d8f2c70a7d7833f05"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0b8274624a72aa6d14c79f6497b9d76e48bdb7ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"566f1ecd_69254397","updated":"2021-10-21 16:56:54.000000000","message":"recheck\nmain patch was updated","commit_id":"f8ab059e9c44d6d0abec605d8f2c70a7d7833f05"},{"author":{"_account_id":30678,"name":"Emanuel Andrecut","email":"emanuel.andrecut@fleio.com","username":"andrecutm"},"change_message_id":"2563e9f831d5b9d71b3b3b871e65d907f7edd14e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c07629b6_51bd0db9","updated":"2021-10-27 11:57:32.000000000","message":"recheck","commit_id":"92289ac91a8f96bcd2cec1f78c338aa62e471d2e"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"854bcf6d2bef2909ac61adf8fab2cea74b478d66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b8d95ab7_ac2e3299","updated":"2022-02-25 21:36:59.000000000","message":"See comment.","commit_id":"82f156e6f75522af60b485b4d82df0767a76ccce"},{"author":{"_account_id":30678,"name":"Emanuel Andrecut","email":"emanuel.andrecut@fleio.com","username":"andrecutm"},"change_message_id":"eeea3c85bb1002dcbd82cd281359cb2599bd6dbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3520ddd6_2ef92d7d","updated":"2021-12-03 08:34:08.000000000","message":"recheck","commit_id":"82f156e6f75522af60b485b4d82df0767a76ccce"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"bb1617ccdaa4d4f8aef21d8c8100c3a03a8326bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7c536880_5c4ddb1d","updated":"2023-08-01 16:05:04.000000000","message":"We\u0027ve recently removed ddt module from the code, so now each test is implemented individually with its own idempotent_id.\nThis patch (2 years old) is based on ddt (all json files modified doesn\u0027t exist anymore).\nCheck latest master and consider adding the tests in a new code manner.","commit_id":"92cf0ac144f52f31b2e7fe7c5c6a39611e07accf"},{"author":{"_account_id":30678,"name":"Emanuel Andrecut","email":"emanuel.andrecut@fleio.com","username":"andrecutm"},"change_message_id":"f64e2be7b12572b7a70e5c1782c0ff9b0d03edb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a5985c8f_c833383b","updated":"2022-03-01 07:29:41.000000000","message":"recheck","commit_id":"92cf0ac144f52f31b2e7fe7c5c6a39611e07accf"}],"designate_tempest_plugin/tests/api/v2/invalid_txt_dataset.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d8c04dbf1958ba612d8e8419e2ec4a0406d684d","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  \"trailing_double_slash\": {\"data\": \"\\\\\\\\\"},"},{"line_number":4,"context_line":"  \"trailing_slash_after_text\": {\"data\": \"testtext\\\\\"},"},{"line_number":5,"context_line":"  \"space_in_unwrapped_text\": {\"data\": \"test test\"},"},{"line_number":6,"context_line":"  \"unescaped_quotes_inside_text\": {\"data\": \"test\\\"test\"},"},{"line_number":7,"context_line":"  \"long_data_without_being_split\": {\"data\": \"looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongtextlooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongtext\"}"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"0724d9d6_256c0717","line":6,"updated":"2021-10-25 17:46:49.000000000","message":"This test is failing.","commit_id":"f8ab059e9c44d6d0abec605d8f2c70a7d7833f05"},{"author":{"_account_id":30678,"name":"Emanuel Andrecut","email":"emanuel.andrecut@fleio.com","username":"andrecutm"},"change_message_id":"f713a7dd296775d069c37e6f0deab736c7da670a","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  \"trailing_double_slash\": {\"data\": \"\\\\\\\\\"},"},{"line_number":4,"context_line":"  \"trailing_slash_after_text\": {\"data\": \"testtext\\\\\"},"},{"line_number":5,"context_line":"  \"space_in_unwrapped_text\": {\"data\": \"test test\"},"},{"line_number":6,"context_line":"  \"unescaped_quotes_inside_text\": {\"data\": \"test\\\"test\"},"},{"line_number":7,"context_line":"  \"long_data_without_being_split\": {\"data\": \"looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongtextlooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongtext\"}"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"86288604_b1ddfe3d","line":6,"in_reply_to":"0724d9d6_256c0717","updated":"2021-11-20 12:15:17.000000000","message":"Hi, I\u0027m not sure why it fails, for me it looks like the test is not run with the code from the other commit on designate (that I added in Depends-On), am I missing something? Thanks","commit_id":"f8ab059e9c44d6d0abec605d8f2c70a7d7833f05"},{"author":{"_account_id":30678,"name":"Emanuel Andrecut","email":"emanuel.andrecut@fleio.com","username":"andrecutm"},"change_message_id":"4150e629c28cf9276983ae68895c7b1338cda2c0","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  \"trailing_double_slash\": {\"data\": \"\\\\\\\\\"},"},{"line_number":4,"context_line":"  \"trailing_slash_after_text\": {\"data\": \"testtext\\\\\"},"},{"line_number":5,"context_line":"  \"space_in_unwrapped_text\": {\"data\": \"test test\"},"},{"line_number":6,"context_line":"  \"unescaped_quotes_inside_text\": {\"data\": \"test\\\"test\"},"},{"line_number":7,"context_line":"  \"long_data_without_being_split\": {\"data\": \"looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongtextlooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongtext\"}"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"da43879c_0f2dac1c","line":6,"in_reply_to":"5d3d8787_969b7f44","updated":"2021-11-23 13:32:00.000000000","message":"\u003e The test that is failing is grenade which means it is running on xena first, then will run with yoga and your patch. We either need to backport the fix in designate or skip the test for xena and older deployments.\n\nThanks for clarification, added backport here https://review.opendev.org/c/openstack/designate/+/818888","commit_id":"f8ab059e9c44d6d0abec605d8f2c70a7d7833f05"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e4866f7fe3eb3a4102d93ddeb37265befa39416c","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  \"trailing_double_slash\": {\"data\": \"\\\\\\\\\"},"},{"line_number":4,"context_line":"  \"trailing_slash_after_text\": {\"data\": \"testtext\\\\\"},"},{"line_number":5,"context_line":"  \"space_in_unwrapped_text\": {\"data\": \"test test\"},"},{"line_number":6,"context_line":"  \"unescaped_quotes_inside_text\": {\"data\": \"test\\\"test\"},"},{"line_number":7,"context_line":"  \"long_data_without_being_split\": {\"data\": \"looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongtextlooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongtext\"}"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"5d3d8787_969b7f44","line":6,"in_reply_to":"86288604_b1ddfe3d","updated":"2021-11-22 18:47:31.000000000","message":"The test that is failing is grenade which means it is running on xena first, then will run with yoga and your patch. We either need to backport the fix in designate or skip the test for xena and older deployments.","commit_id":"f8ab059e9c44d6d0abec605d8f2c70a7d7833f05"},{"author":{"_account_id":30678,"name":"Emanuel Andrecut","email":"emanuel.andrecut@fleio.com","username":"andrecutm"},"change_message_id":"26737daf9517b386f2b9e4f508d98bc87fddf37d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  \"trailing_double_slash\": {\"data\": \"\\\\\\\\\"},"},{"line_number":4,"context_line":"  \"trailing_slash_after_text\": {\"data\": \"testtext\\\\\"},"},{"line_number":5,"context_line":"  \"space_in_unwrapped_text\": {\"data\": \"test test\"},"},{"line_number":6,"context_line":"  \"unescaped_quotes_inside_text\": {\"data\": \"test\\\"test\"},"},{"line_number":7,"context_line":"  \"long_data_without_being_split\": {\"data\": \"looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongtextlooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongtext\"}"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"efbd70e8_33cbb176","line":6,"in_reply_to":"da43879c_0f2dac1c","updated":"2022-02-23 14:36:49.000000000","message":"Done","commit_id":"f8ab059e9c44d6d0abec605d8f2c70a7d7833f05"}],"designate_tempest_plugin/tests/api/v2/test_recordset_validation.py":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"854bcf6d2bef2909ac61adf8fab2cea74b478d66","unresolved":true,"context_lines":[{"line_number":150,"context_line":"    @ddt.file_data(\"valid_spf_dataset.json\")"},{"line_number":151,"context_line":"    def test_create_SPF_with(self, data):"},{"line_number":152,"context_line":"        post_model \u003d data_utils.rand_spf_recordset(self.zone[\u0027name\u0027], data)"},{"line_number":153,"context_line":"        recordset \u003d self.create_recordset(post_model)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        waiters.wait_for_recordset_status("},{"line_number":156,"context_line":"            self.recordset_client, self.zone[\u0027id\u0027], recordset[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9e417379_911c567f","line":153,"updated":"2022-02-25 21:36:59.000000000","message":"Would it not be better to se the client\u0027s create_recordset wait_until option instead? See designate-tempest-plugin/services/dns/v2/json/recordset_client.py:#37.. By using the wait_until feature L155 goes away.","commit_id":"82f156e6f75522af60b485b4d82df0767a76ccce"},{"author":{"_account_id":30678,"name":"Emanuel Andrecut","email":"emanuel.andrecut@fleio.com","username":"andrecutm"},"change_message_id":"acd9b18f03fab2349780904e8d0f2bfd757bea85","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    @ddt.file_data(\"valid_spf_dataset.json\")"},{"line_number":151,"context_line":"    def test_create_SPF_with(self, data):"},{"line_number":152,"context_line":"        post_model \u003d data_utils.rand_spf_recordset(self.zone[\u0027name\u0027], data)"},{"line_number":153,"context_line":"        recordset \u003d self.create_recordset(post_model)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        waiters.wait_for_recordset_status("},{"line_number":156,"context_line":"            self.recordset_client, self.zone[\u0027id\u0027], recordset[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"e5cff971_3217d99d","line":153,"in_reply_to":"9e417379_911c567f","updated":"2022-03-01 07:39:34.000000000","message":"Done","commit_id":"82f156e6f75522af60b485b4d82df0767a76ccce"}]}