)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3e471f248295e46127f126422e3f40bee877b060","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3240568f_41dfead2","updated":"2022-01-07 18:20:12.000000000","message":"I think this test will have false failures on valid cloud configurations. We need to work on this a bit more.","commit_id":"a3065d9a0da4ca78d83594d2c858ba7d6317f95f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ed7c463b469da9313b17b2b6a2a31595ade609bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ed89a47d_5c89028c","updated":"2022-01-09 18:49:31.000000000","message":"recheck","commit_id":"9a0cc8199ec2c604adb6729ac50f8a10519368fe"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"949585ba3702ca5884bbcd7b3786552014109e89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"391fd9e3_b3fe4695","updated":"2022-12-29 08:22:09.000000000","message":"recheck","commit_id":"24bdab1ca85e0b5c52d5f7b5507ee9a17dfa8953"}],"designate_tempest_plugin/tests/api/v2/test_pool.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3e471f248295e46127f126422e3f40bee877b060","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    @classmethod"},{"line_number":49,"context_line":"    def setup_clients(cls):"},{"line_number":50,"context_line":"        super(PoolAdminTest, cls).setup_clients()"},{"line_number":51,"context_line":"        cls.zone_client \u003d cls.os_admin.dns_v2.ZonesClient()"},{"line_number":52,"context_line":"        if CONF.enforce_scope.designate:"},{"line_number":53,"context_line":"            cls.admin_client \u003d cls.os_system_admin.dns_v2.PoolClient()"},{"line_number":54,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"acb22c56_4c4d1298","line":51,"updated":"2022-01-07 18:20:12.000000000","message":"This needs to move down into the scoped tokens conditional.\nAdmin credentials need a scope when using keystone scoped tokens.","commit_id":"a3065d9a0da4ca78d83594d2c858ba7d6317f95f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4a2cfbf0c24dada49704e704f5781c8c97a8235f","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    @classmethod"},{"line_number":49,"context_line":"    def setup_clients(cls):"},{"line_number":50,"context_line":"        super(PoolAdminTest, cls).setup_clients()"},{"line_number":51,"context_line":"        cls.zone_client \u003d cls.os_admin.dns_v2.ZonesClient()"},{"line_number":52,"context_line":"        if CONF.enforce_scope.designate:"},{"line_number":53,"context_line":"            cls.admin_client \u003d cls.os_system_admin.dns_v2.PoolClient()"},{"line_number":54,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5d66f18e_3d2ed680","line":51,"in_reply_to":"acb22c56_4c4d1298","updated":"2022-01-09 13:48:18.000000000","message":"Will be fixed.","commit_id":"a3065d9a0da4ca78d83594d2c858ba7d6317f95f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3e471f248295e46127f126422e3f40bee877b060","unresolved":true,"context_lines":[{"line_number":123,"context_line":"    def test_default_pool(self):"},{"line_number":124,"context_line":"        # When the Zone is being created within not existing \"attributes\","},{"line_number":125,"context_line":"        # the expected behaviour would be landing this zone into"},{"line_number":126,"context_line":"        # the Default Pool."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # We need to have more than a single(default) Pool for this test"},{"line_number":129,"context_line":"        LOG.info(\u0027Admin user creates pool\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"19427955_a7ac8eba","line":126,"updated":"2022-01-07 18:20:12.000000000","message":"This test is making an assumption about the configuration of the designate deployment. If the cloud under test is using a different pool scheduler configuration this test will fail even though the cloud configuration could be valid.\nhttps://docs.openstack.org/designate/latest/admin/config.html#service:central.scheduler_filters\nhttps://docs.openstack.org/designate/latest/admin/pool-scheduler.html\n\nAt the very least, we would need to add a tempest config setting that defaults to false that skips this test. This could then be set to true for specific gate test runs where the scheduler_filters is configured to match this test case.","commit_id":"a3065d9a0da4ca78d83594d2c858ba7d6317f95f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4a2cfbf0c24dada49704e704f5781c8c97a8235f","unresolved":true,"context_lines":[{"line_number":123,"context_line":"    def test_default_pool(self):"},{"line_number":124,"context_line":"        # When the Zone is being created within not existing \"attributes\","},{"line_number":125,"context_line":"        # the expected behaviour would be landing this zone into"},{"line_number":126,"context_line":"        # the Default Pool."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # We need to have more than a single(default) Pool for this test"},{"line_number":129,"context_line":"        LOG.info(\u0027Admin user creates pool\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b0a5a05f_69144f2e","line":126,"in_reply_to":"19427955_a7ac8eba","updated":"2022-01-09 13:48:18.000000000","message":"Makes sense, I\u0027ll use \"designate-manage\" to skip this test when the only pool available is a default pool.","commit_id":"a3065d9a0da4ca78d83594d2c858ba7d6317f95f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f92cc4c8fc215cb7c073c070706f958c4946eb2c","unresolved":true,"context_lines":[{"line_number":123,"context_line":"    def test_default_pool(self):"},{"line_number":124,"context_line":"        # When the Zone is being created within not existing \"attributes\","},{"line_number":125,"context_line":"        # the expected behaviour would be landing this zone into"},{"line_number":126,"context_line":"        # the Default Pool."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # We need to have more than a single(default) Pool for this test"},{"line_number":129,"context_line":"        LOG.info(\u0027Admin user creates pool\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e7ab8239_ac7d284b","line":126,"in_reply_to":"b0a5a05f_69144f2e","updated":"2022-01-11 17:34:32.000000000","message":"Well, even that doesn\u0027t solve the problem. What if the cloud is configured for the \"random pool scheduler\"?\nhttps://docs.openstack.org/designate/latest/admin/pool-scheduler.html#random-filter","commit_id":"a3065d9a0da4ca78d83594d2c858ba7d6317f95f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"a1b45122cf1e7606d1a3ce87090e5d5f027700f2","unresolved":true,"context_lines":[{"line_number":123,"context_line":"    def test_default_pool(self):"},{"line_number":124,"context_line":"        # When the Zone is being created within not existing \"attributes\","},{"line_number":125,"context_line":"        # the expected behaviour would be landing this zone into"},{"line_number":126,"context_line":"        # the Default Pool."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # We need to have more than a single(default) Pool for this test"},{"line_number":129,"context_line":"        LOG.info(\u0027Admin user creates pool\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"04886e45_ce5cdb33","line":126,"in_reply_to":"e7ab8239_ac7d284b","updated":"2022-01-11 18:54:09.000000000","message":"Brrr..\n\nWith the \"designate manage\" tool I cannot get the filter type used, can I?\nHere is its output:\nstack@ubuntu-0104-1338:~/tempest$ designate-manage \nusage: designate [-h] [--config-dir DIR] [--config-file PATH] [--debug] [--log-config-append PATH] [--log-date-format DATE_FORMAT] [--log-dir LOG_DIR] [--log-file PATH] [--nodebug] [--nouse-journal]\n                 [--nouse-json] [--nouse-syslog] [--nowatch-log-file] [--syslog-log-facility SYSLOG_LOG_FACILITY] [--use-journal] [--use-json] [--use-syslog] [--watch-log-file]\n                 {database,pool,tlds} ...\ndesignate: error: the following arguments are required: category\nstack@ubuntu-0104-1338:~/tempest$ designate-manage pool show_config\nPool Configuration:\n-------------------\nalso_notifies: []\nattributes: {}\ndescription: DevStack BIND Pool\nid: 794ccc2c-d751-44fe-b57f-8894c9f5c842\nname: default\nnameservers:\n- host: 192.168.122.120\n  port: 53\nns_records:\n- hostname: ns1.devstack.org.\n  priority: 1\ntargets:\n- description: BIND Instance\n  masters:\n  - host: 192.168.122.120\n    port: 5354\n  options:\n    host: 192.168.122.120\n    port: \u002753\u0027\n    rndc_config_file: /etc/bind/rndc.conf\n    rndc_host: 192.168.122.120\n    rndc_key_file: /etc/bind/rndc.key\n    rndc_port: \u0027953\u0027\n  type: bind9\n\n\nSo, do I have to get this info from configuration files?","commit_id":"a3065d9a0da4ca78d83594d2c858ba7d6317f95f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3e471f248295e46127f126422e3f40bee877b060","unresolved":true,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # We need to have more than a single(default) Pool for this test"},{"line_number":129,"context_line":"        LOG.info(\u0027Admin user creates pool\u0027)"},{"line_number":130,"context_line":"        pool \u003d self.admin_client.create_pool(project_id\u003d\"1\")[1]"},{"line_number":131,"context_line":"        self.addCleanup(self.admin_client.delete_pool, pool[\u0027id\u0027],"},{"line_number":132,"context_line":"                        headers\u003dself.all_projects_header)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5e24e0df_6700cb1a","line":130,"updated":"2022-01-07 18:20:12.000000000","message":"Using this API concerns me as it is marked DEPRECATED here:\nhttps://github.com/openstack/designate/blob/master/designate/api/v2/controllers/pools.py#L69\nRight now, outside of the \"test_pool\" API tests, no tests are using this API.\nMaybe we need to switch this to use the designate-manage pool commands?","commit_id":"a3065d9a0da4ca78d83594d2c858ba7d6317f95f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4a2cfbf0c24dada49704e704f5781c8c97a8235f","unresolved":true,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # We need to have more than a single(default) Pool for this test"},{"line_number":129,"context_line":"        LOG.info(\u0027Admin user creates pool\u0027)"},{"line_number":130,"context_line":"        pool \u003d self.admin_client.create_pool(project_id\u003d\"1\")[1]"},{"line_number":131,"context_line":"        self.addCleanup(self.admin_client.delete_pool, pool[\u0027id\u0027],"},{"line_number":132,"context_line":"                        headers\u003dself.all_projects_header)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"273e65f9_418883cf","line":130,"in_reply_to":"5e24e0df_6700cb1a","updated":"2022-01-09 13:48:18.000000000","message":"There will be no need to add a pool if the skip didn\u0027t occur.\nWhen code reaches to here, it means that there are already more then a single \"default\" pool exists. so we can then try to create a Zone that should go to \"Default\" as it won\u0027t fit any of the existing pools.","commit_id":"a3065d9a0da4ca78d83594d2c858ba7d6317f95f"}]}