)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5cbbc0084f289241e30b6d11f9faca2eb1cda202","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c861783c_1f297d6b","updated":"2022-01-07 18:24:47.000000000","message":"We need to update this for the scoped token tests.","commit_id":"fc41f8b815878f5b0ee09ffa134bf663544164f1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ba7df078c9816af085574cdfa3b011e03ffc5e57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3f3bfb6a_a9a6f5e4","updated":"2022-01-10 21:11:29.000000000","message":"LGTM","commit_id":"a0ed64ed870f97714c572814ddf31371b0089bec"}],"designate_tempest_plugin/tests/scenario/v2/test_recordsets.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"702d1063781abe47bacb10231f0fe11ad28f7ff1","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            \u0027records\u0027: records,"},{"line_number":76,"context_line":"        }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if recordset_data[\u0027type\u0027].lower() in [\u0027soa\u0027]:"},{"line_number":79,"context_line":"            # SOA record is automatically created for a zone, no user"},{"line_number":80,"context_line":"            # should be able to create a SOA record."},{"line_number":81,"context_line":"            LOG.info(\u0027Primary tries to create a Recordset on \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"76ae864e_088b8166","line":78,"updated":"2021-12-27 00:08:46.000000000","message":"This feels odd. I would prefer this just being a new json file with maybe admin only record types?","commit_id":"1f05b0f72a03afcce83d3198f03f567a9112be8e"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6b672e2028afc5c2579d2f14a068834081ebff04","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            \u0027records\u0027: records,"},{"line_number":76,"context_line":"        }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if recordset_data[\u0027type\u0027].lower() in [\u0027soa\u0027]:"},{"line_number":79,"context_line":"            # SOA record is automatically created for a zone, no user"},{"line_number":80,"context_line":"            # should be able to create a SOA record."},{"line_number":81,"context_line":"            LOG.info(\u0027Primary tries to create a Recordset on \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"445ca2b9_20dc0f1c","line":78,"in_reply_to":"76ae864e_088b8166","updated":"2021-12-27 08:55:58.000000000","message":"Good catch, thanks!!!\n\nYep, the only recordset that behaves differently is SOA.\nHaving SOA covered in a dedicated test case would make sense.","commit_id":"1f05b0f72a03afcce83d3198f03f567a9112be8e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5cbbc0084f289241e30b6d11f9faca2eb1cda202","unresolved":true,"context_lines":[{"line_number":28,"context_line":"@ddt.ddt"},{"line_number":29,"context_line":"class RecordsetsTest(base.BaseDnsV2Test):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    credentials \u003d [\"admin\", \"primary\"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1b239481_e422c627","line":31,"updated":"2022-01-07 18:24:47.000000000","message":"This needs to be updated for the keystone scoped tokens.\nSee this line for an example: https://github.com/openstack/designate-tempest-plugin/blob/master/designate_tempest_plugin/tests/api/v2/test_recordset.py#L54","commit_id":"fc41f8b815878f5b0ee09ffa134bf663544164f1"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"424666b640f559225cbcb81715566a2ba2012b9d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"@ddt.ddt"},{"line_number":29,"context_line":"class RecordsetsTest(base.BaseDnsV2Test):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    credentials \u003d [\"admin\", \"primary\"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"21080d01_793758e8","line":31,"in_reply_to":"1b239481_e422c627","updated":"2022-01-09 09:46:21.000000000","message":"Done","commit_id":"fc41f8b815878f5b0ee09ffa134bf663544164f1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5cbbc0084f289241e30b6d11f9faca2eb1cda202","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZonesClient()"},{"line_number":38,"context_line":"        cls.recordset_client \u003d cls.os_primary.dns_v2.RecordsetClient()"},{"line_number":39,"context_line":"        cls.admin_recordset_client \u003d cls.os_admin.dns_v2.RecordsetClient()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"49413c9f_52fb7061","line":39,"updated":"2022-01-07 18:24:47.000000000","message":"This needs to be updated for the keystone scoped tokens.\nAny time we are using an \"admin\" credential, we need to check if it also needs a scope.\nSee this line for an example:\nhttps://github.com/openstack/designate-tempest-plugin/blob/master/designate_tempest_plugin/tests/api/v2/test_recordset.py#L65","commit_id":"fc41f8b815878f5b0ee09ffa134bf663544164f1"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"424666b640f559225cbcb81715566a2ba2012b9d","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZonesClient()"},{"line_number":38,"context_line":"        cls.recordset_client \u003d cls.os_primary.dns_v2.RecordsetClient()"},{"line_number":39,"context_line":"        cls.admin_recordset_client \u003d cls.os_admin.dns_v2.RecordsetClient()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"b748ae09_b1724af5","line":39,"in_reply_to":"49413c9f_52fb7061","updated":"2022-01-09 09:46:21.000000000","message":"Done","commit_id":"fc41f8b815878f5b0ee09ffa134bf663544164f1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"b818cfbb04c0e21aa276ff98d06633baf42a3a27","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    def test_create_soa_record_not_permitted(self):"},{"line_number":108,"context_line":"        # SOA record is automatically created for a zone, no user"},{"line_number":109,"context_line":"        # should be able to create a SOA record."},{"line_number":110,"context_line":"        soa_record \u003d \"s1.devstack.org. admin.example.net. 1510721487 \" \\"},{"line_number":111,"context_line":"                     \"3510 600 86400 3600\""},{"line_number":112,"context_line":"        LOG.info(\u0027Primary tries to create a Recordset on \u0027"},{"line_number":113,"context_line":"                 \u0027the existing zone\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"59562710_f69d6a64","line":110,"updated":"2021-12-27 19:06:00.000000000","message":"Nit: Much prefer brackets over backslash \\\n\u003e soa_record \u003d (\"s1.devstack.org. admin.example.net. 1510721487 \"\n\u003e               \"3510 600 86400 3600\")","commit_id":"fc41f8b815878f5b0ee09ffa134bf663544164f1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5cbbc0084f289241e30b6d11f9faca2eb1cda202","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    def test_create_soa_record_not_permitted(self):"},{"line_number":108,"context_line":"        # SOA record is automatically created for a zone, no user"},{"line_number":109,"context_line":"        # should be able to create a SOA record."},{"line_number":110,"context_line":"        soa_record \u003d \"s1.devstack.org. admin.example.net. 1510721487 \" \\"},{"line_number":111,"context_line":"                     \"3510 600 86400 3600\""},{"line_number":112,"context_line":"        LOG.info(\u0027Primary tries to create a Recordset on \u0027"},{"line_number":113,"context_line":"                 \u0027the existing zone\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"834d8246_ba68925f","line":110,"in_reply_to":"59562710_f69d6a64","updated":"2022-01-07 18:24:47.000000000","message":"nit: +1","commit_id":"fc41f8b815878f5b0ee09ffa134bf663544164f1"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"424666b640f559225cbcb81715566a2ba2012b9d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def test_create_soa_record_not_permitted(self):"},{"line_number":108,"context_line":"        # SOA record is automatically created for a zone, no user"},{"line_number":109,"context_line":"        # should be able to create a SOA record."},{"line_number":110,"context_line":"        soa_record \u003d \"s1.devstack.org. admin.example.net. 1510721487 \" \\"},{"line_number":111,"context_line":"                     \"3510 600 86400 3600\""},{"line_number":112,"context_line":"        LOG.info(\u0027Primary tries to create a Recordset on \u0027"},{"line_number":113,"context_line":"                 \u0027the existing zone\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"8654d900_3d4a436e","line":110,"in_reply_to":"834d8246_ba68925f","updated":"2022-01-09 09:46:21.000000000","message":"Done","commit_id":"fc41f8b815878f5b0ee09ffa134bf663544164f1"}]}