)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9e13c282ef31da6b3286bef2b2c70766458e9e8b","unresolved":true,"context_lines":[{"line_number":11,"context_line":"       and to \"show\" created by tenant exports."},{"line_number":12,"context_line":"       Note: based on: \u0027x-auth-sudo-project-id\u0027 HTTP header."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    2) \"test_show_exported_zonefile_all_projects_headers\""},{"line_number":15,"context_line":"       Use admin client to show zone export file of"},{"line_number":16,"context_line":"       all tenants."},{"line_number":17,"context_line":"       Note: based on: \"x-auth-all-projects\" HTTP header."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bec182bf_d1001930","line":14,"range":{"start_line":14,"start_character":8,"end_line":14,"end_character":56},"updated":"2022-01-06 15:42:23.000000000","message":"Was it renamed? Where is this test?","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":11,"context_line":"       and to \"show\" created by tenant exports."},{"line_number":12,"context_line":"       Note: based on: \u0027x-auth-sudo-project-id\u0027 HTTP header."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    2) \"test_show_exported_zonefile_all_projects_headers\""},{"line_number":15,"context_line":"       Use admin client to show zone export file of"},{"line_number":16,"context_line":"       all tenants."},{"line_number":17,"context_line":"       Note: based on: \"x-auth-all-projects\" HTTP header."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"5dad92ca_70ef4e01","line":14,"range":{"start_line":14,"start_character":8,"end_line":14,"end_character":56},"in_reply_to":"bec182bf_d1001930","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9e13c282ef31da6b3286bef2b2c70766458e9e8b","unresolved":true,"context_lines":[{"line_number":17,"context_line":"       Note: based on: \"x-auth-all-projects\" HTTP header."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    3) \"test_show_exported_zonefile_any_mime_type\""},{"line_number":20,"context_line":"       Validate that 200 OK is received when client"},{"line_number":21,"context_line":"       sends \"Accept: */*\"."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    4) \"test_missing_accept_headers\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"c754394b_2699c69a","line":20,"range":{"start_line":20,"start_character":21,"end_line":20,"end_character":27},"updated":"2022-01-06 15:42:23.000000000","message":"200 ok and Content-Type: text/dns","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":17,"context_line":"       Note: based on: \"x-auth-all-projects\" HTTP header."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    3) \"test_show_exported_zonefile_any_mime_type\""},{"line_number":20,"context_line":"       Validate that 200 OK is received when client"},{"line_number":21,"context_line":"       sends \"Accept: */*\"."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    4) \"test_missing_accept_headers\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"c78e7a57_5ec743a5","line":20,"range":{"start_line":20,"start_character":21,"end_line":20,"end_character":27},"in_reply_to":"c754394b_2699c69a","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9e13c282ef31da6b3286bef2b2c70766458e9e8b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"       sends \"Accept: */*\"."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    4) \"test_missing_accept_headers\""},{"line_number":24,"context_line":"       Client request is missing Accept header."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    5) \"test_show_zonefile_using_not_existing_zone_export_id\""},{"line_number":27,"context_line":"       \"404 Not Found\" is expected when not existing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"d0ecd690_4dd4a0a4","line":24,"updated":"2022-01-06 15:42:23.000000000","message":"Ensure that server responds with its default: Content-Type: text/dns","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":21,"context_line":"       sends \"Accept: */*\"."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    4) \"test_missing_accept_headers\""},{"line_number":24,"context_line":"       Client request is missing Accept header."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    5) \"test_show_zonefile_using_not_existing_zone_export_id\""},{"line_number":27,"context_line":"       \"404 Not Found\" is expected when not existing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"af309748_cd92450d","line":24,"in_reply_to":"d0ecd690_4dd4a0a4","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9e13c282ef31da6b3286bef2b2c70766458e9e8b","unresolved":true,"context_lines":[{"line_number":28,"context_line":"       ID is used by client."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    6)\"test_show_zonefile_not_supported_accept_value\""},{"line_number":31,"context_line":"      The client try to show file of zone export with"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: I8aa5dfe12781f21b9f41e0df19afb0e46eab31d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bc91b6e5_a80ff3a6","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":53},"updated":"2022-01-06 15:42:23.000000000","message":"Test scenario + expected result is missing in this description.","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":28,"context_line":"       ID is used by client."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    6)\"test_show_zonefile_not_supported_accept_value\""},{"line_number":31,"context_line":"      The client try to show file of zone export with"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: I8aa5dfe12781f21b9f41e0df19afb0e46eab31d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"077c0f35_5a38a881","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":53},"in_reply_to":"bc91b6e5_a80ff3a6","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"928cd5790d710cf10f8767761a4a0385dcf230e0","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    4) \"test_missing_accept_headers\""},{"line_number":25,"context_line":"       Client request is missing Accept header."},{"line_number":26,"context_line":"       The header will be send with empty dict."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    5) \"test_show_zonefile_using_not_existing_zone_export_id\""},{"line_number":29,"context_line":"       \"404 Not Found\" is expected when not existing"},{"line_number":30,"context_line":"       ID is used by client."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"48452ee2_96c51b42","line":27,"updated":"2022-01-09 18:47:21.000000000","message":"What about Expected?","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    4) \"test_missing_accept_headers\""},{"line_number":25,"context_line":"       Client request is missing Accept header."},{"line_number":26,"context_line":"       The header will be send with empty dict."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    5) \"test_show_zonefile_using_not_existing_zone_export_id\""},{"line_number":29,"context_line":"       \"404 Not Found\" is expected when not existing"},{"line_number":30,"context_line":"       ID is used by client."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"e2543cd4_0a42ab7c","line":27,"in_reply_to":"48452ee2_96c51b42","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"928cd5790d710cf10f8767761a4a0385dcf230e0","unresolved":true,"context_lines":[{"line_number":30,"context_line":"       ID is used by client."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    6)\"test_show_zonefile_not_supported_accept_value\""},{"line_number":33,"context_line":"      The client try to show file of zone export with"},{"line_number":34,"context_line":"      value are different from text/dns in Accept header."},{"line_number":35,"context_line":"      Expect to get Error 406."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Change-Id: I8aa5dfe12781f21b9f41e0df19afb0e46eab31d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7d8512cc_f65e6109","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":30},"updated":"2022-01-09 18:47:21.000000000","message":"Maybe \n\nClient sends \u0027Accept\u0027:\u0027image/jpeg\u0027 for ShowZoneFile API.\nExpected: 406 Not Acceptable.","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"       ID is used by client."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    6)\"test_show_zonefile_not_supported_accept_value\""},{"line_number":33,"context_line":"      The client try to show file of zone export with"},{"line_number":34,"context_line":"      value are different from text/dns in Accept header."},{"line_number":35,"context_line":"      Expect to get Error 406."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Change-Id: I8aa5dfe12781f21b9f41e0df19afb0e46eab31d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1f3b026c_34bd7287","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":30},"in_reply_to":"7d8512cc_f65e6109","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"fef54481027449a8530a7ef28d1f6f5d1108c35c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9c3d696a_1322013e","updated":"2022-01-05 07:54:21.000000000","message":"recheck","commit_id":"cfa0c52df31378d09d2fd363f614ee2e51234064"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9e13c282ef31da6b3286bef2b2c70766458e9e8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fd9c9d26_524e26a5","updated":"2022-01-06 15:42:23.000000000","message":"Hi Lilach,there is still stuff that is needed to be fixed, sorry :-(","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9eef5e29fca6854bb4d80b05f74462d7bd9be59f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9ba666c5_4b93fe1c","updated":"2022-01-07 23:55:19.000000000","message":"Just a few comments, otherwise looks good.","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9eef5e29fca6854bb4d80b05f74462d7bd9be59f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"572c2735_3aaf1ebb","in_reply_to":"fd9c9d26_524e26a5","updated":"2022-01-07 23:55:19.000000000","message":"Fixing is learning! grin","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4f7e3d10_eb1aa16c","updated":"2022-01-09 17:47:30.000000000","message":"recheck","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d090eb63a127e09ee097521383f91418d06e8a66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9685f589_207559b2","updated":"2022-01-10 21:22:22.000000000","message":"Just one thing we can clean up and this will be good to go.","commit_id":"0d4de19ab4ed7b0d919fa8382f7184dd0bcf07b8"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"71377005_6ca2d496","updated":"2022-01-16 20:45:48.000000000","message":"There is still some stuff needed to be fixed 😞","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"47344a4a70c5c64fdc23b1521dd547c7ca5dee32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3fb610bd_c228417b","updated":"2022-01-17 18:48:33.000000000","message":"Looks good to me and only few things are still needed to be fixed.","commit_id":"affbe3fc7bba3a6c85674b76887e22b6dd9e0b41"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bbc3e85ca9c90436c533d92db6a54a0e3f2aa9b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"fde96b0b_6990c1c6","updated":"2022-01-26 18:25:56.000000000","message":"A couple of comments on the new test, otherwise looks good.","commit_id":"75687ccb7855828f642571d2e2e973dd0902fc8e"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"d084d8c6237b60846465f309c4d70120f598710b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"967837f8_c4b8e1f0","updated":"2022-01-19 21:48:55.000000000","message":"Look correct to me.","commit_id":"75687ccb7855828f642571d2e2e973dd0902fc8e"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"95d26ea3766e4552d50f31a3c11c900b2e070405","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"64f751f4_eff15699","updated":"2022-01-18 11:02:07.000000000","message":"Looks good to me!!!\nLet\u0027s add Designate folks to review your patch 😂","commit_id":"75687ccb7855828f642571d2e2e973dd0902fc8e"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"727b4d054cf7128c3e9baabffb7190be1568f35b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"2b5c0358_f80aa001","updated":"2022-01-18 08:57:20.000000000","message":"recheck","commit_id":"75687ccb7855828f642571d2e2e973dd0902fc8e"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f1e29347534a5255862368fe1c3a267f3c76b971","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"9b980f24_a0e88d49","updated":"2022-01-17 22:25:39.000000000","message":"recheck","commit_id":"75687ccb7855828f642571d2e2e973dd0902fc8e"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"b46c107429b4b029fd44867d0cd1fbe69f9f880d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"243ece9e_fe4fa912","in_reply_to":"fde96b0b_6990c1c6","updated":"2022-02-01 11:50:15.000000000","message":"Hi Michael,\nI changed the test I hope it will be better 😊","commit_id":"75687ccb7855828f642571d2e2e973dd0902fc8e"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"eec8ffacf9583ac8994d9a9245ab9d66bc91d3b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"a3ecce9a_51d82f7e","updated":"2022-01-28 22:26:40.000000000","message":"It looks good, with only a small nit on spelling corrections.","commit_id":"ba61e0c283dff30373de7f8fad1240b959791df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"b46c107429b4b029fd44867d0cd1fbe69f9f880d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"5baa78e1_4beef360","in_reply_to":"a3ecce9a_51d82f7e","updated":"2022-02-01 11:50:15.000000000","message":"I didn\u0027t use them, but I\u0027ll change them :)","commit_id":"ba61e0c283dff30373de7f8fad1240b959791df4"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"6b4ffb356bb42920ddc5a571f924276f5ec6e44f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"ea4c822f_9d161bbb","updated":"2022-02-09 00:08:15.000000000","message":"Looks good, thanks for fixing the spelling nits.","commit_id":"a160cf494f8050670372f812290793a4f7a471c4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ded6d74982c995cb6ee91fd261746a1efa0af8a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"d9192b2f_1de97a70","updated":"2022-02-23 23:14:45.000000000","message":"This last test can be simplified, removing a try/except block and a duplicate assertion.","commit_id":"a160cf494f8050670372f812290793a4f7a471c4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"798871e5e423d85e679a9595b33e6faa570b4003","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"26eeaaa6_da07fc79","updated":"2022-02-01 14:56:45.000000000","message":"recheck","commit_id":"a160cf494f8050670372f812290793a4f7a471c4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"b2100e4646356fdebfe988a0347cc0037ad3f55a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"41c5dbf5_76f1c935","updated":"2022-02-03 13:02:33.000000000","message":"recheck","commit_id":"a160cf494f8050670372f812290793a4f7a471c4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"c36a8b602fe035806107c023c958626ab5dd21a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"ab06499c_de20ef35","updated":"2022-02-02 07:55:19.000000000","message":"recheck","commit_id":"a160cf494f8050670372f812290793a4f7a471c4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"7036fe7be3180b1ab5f48cdff82635d30506c493","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"b35c3dd3_2410d384","updated":"2022-02-01 19:09:15.000000000","message":"recheck","commit_id":"a160cf494f8050670372f812290793a4f7a471c4"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"a94fa993c0bf812c20097e51d3476a9e38dba70c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"1db7c225_40455146","updated":"2022-03-09 16:22:15.000000000","message":"LGTM","commit_id":"3260299829eecf9b50321beaaffdb905c6aca723"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"d7351f70454b2965726872ed4b99f2b36c4d59d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"3a060189_2d316233","updated":"2022-02-25 18:43:57.000000000","message":"LGTM","commit_id":"3260299829eecf9b50321beaaffdb905c6aca723"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"08aab65bbaacb36a7f6931b139639d2a3844894a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"f117a075_b8d0a836","updated":"2022-02-25 00:17:38.000000000","message":"LGTM","commit_id":"3260299829eecf9b50321beaaffdb905c6aca723"}],"designate_tempest_plugin/services/dns/v2/json/zone_exports_client.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9eef5e29fca6854bb4d80b05f74462d7bd9be59f","unresolved":true,"context_lines":[{"line_number":65,"context_line":"        :param headers: (dict) The headers to use for the request."},{"line_number":66,"context_line":"        :return: Serialized exported zone as a dictionary."},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        if bool(headers) is True:"},{"line_number":69,"context_line":"            if \u0027accept\u0027 not in [key.lower() for key in headers.keys()]:"},{"line_number":70,"context_line":"                headers[\u0027Accept\u0027] \u003d \u0027text/dns\u0027"},{"line_number":71,"context_line":"        elif bool(headers) is False:"}],"source_content_type":"text/x-python","patch_set":11,"id":"26668e03_3b924136","line":68,"range":{"start_line":68,"start_character":11,"end_line":68,"end_character":32},"updated":"2022-01-07 23:55:19.000000000","message":"It\u0027s more pythonic to just write:\n    if headers:","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        :param headers: (dict) The headers to use for the request."},{"line_number":66,"context_line":"        :return: Serialized exported zone as a dictionary."},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        if bool(headers) is True:"},{"line_number":69,"context_line":"            if \u0027accept\u0027 not in [key.lower() for key in headers.keys()]:"},{"line_number":70,"context_line":"                headers[\u0027Accept\u0027] \u003d \u0027text/dns\u0027"},{"line_number":71,"context_line":"        elif bool(headers) is False:"}],"source_content_type":"text/x-python","patch_set":11,"id":"2793a33d_848dac9b","line":68,"range":{"start_line":68,"start_character":11,"end_line":68,"end_character":32},"in_reply_to":"26668e03_3b924136","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9eef5e29fca6854bb4d80b05f74462d7bd9be59f","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        if bool(headers) is True:"},{"line_number":69,"context_line":"            if \u0027accept\u0027 not in [key.lower() for key in headers.keys()]:"},{"line_number":70,"context_line":"                headers[\u0027Accept\u0027] \u003d \u0027text/dns\u0027"},{"line_number":71,"context_line":"        elif bool(headers) is False:"},{"line_number":72,"context_line":"            headers \u003d {}"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            headers \u003d {\u0027Accept\u0027: \u0027text/dns\u0027}"}],"source_content_type":"text/x-python","patch_set":11,"id":"a8ed3881_b7227b08","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":36},"updated":"2022-01-07 23:55:19.000000000","message":"This evaluates to the same as \"else:\"\n\n\u003e\u003e\u003e foo \u003d None\n\u003e\u003e\u003e if foo:\n...     print(\"True\")\n... else:\n...     print(\"False\")\n... \nFalse\n\u003e\u003e\u003e foo \u003d False\n\u003e\u003e\u003e if foo:\n...     print(\"True\")\n... else:\n...     print(\"False\")\n... \nFalse","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        if bool(headers) is True:"},{"line_number":69,"context_line":"            if \u0027accept\u0027 not in [key.lower() for key in headers.keys()]:"},{"line_number":70,"context_line":"                headers[\u0027Accept\u0027] \u003d \u0027text/dns\u0027"},{"line_number":71,"context_line":"        elif bool(headers) is False:"},{"line_number":72,"context_line":"            headers \u003d {}"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            headers \u003d {\u0027Accept\u0027: \u0027text/dns\u0027}"}],"source_content_type":"text/x-python","patch_set":11,"id":"4cc02bf0_33d3fe0d","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":36},"in_reply_to":"a8ed3881_b7227b08","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9eef5e29fca6854bb4d80b05f74462d7bd9be59f","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        return self._show_request("},{"line_number":76,"context_line":"            \u0027zones/tasks/exports/{0}/export\u0027.format(uuid),"},{"line_number":77,"context_line":"            uuid\u003d\u0027\u0027, headers\u003dheaders, params\u003dparams,"},{"line_number":78,"context_line":"            extra_headers\u003dFalse)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @base.handle_errors"},{"line_number":81,"context_line":"    def list_zone_exports(self, params\u003dNone, headers\u003dNone):"}],"source_content_type":"text/x-python","patch_set":11,"id":"329f1cb7_0b0275e0","line":78,"range":{"start_line":78,"start_character":12,"end_line":78,"end_character":31},"updated":"2022-01-07 23:55:19.000000000","message":"False is the default for this keyword parameter, so you don\u0027t need to specify it here.\nhttps://github.com/openstack/designate-tempest-plugin/blob/master/designate_tempest_plugin/services/dns/json/base.py#L152","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        return self._show_request("},{"line_number":76,"context_line":"            \u0027zones/tasks/exports/{0}/export\u0027.format(uuid),"},{"line_number":77,"context_line":"            uuid\u003d\u0027\u0027, headers\u003dheaders, params\u003dparams,"},{"line_number":78,"context_line":"            extra_headers\u003dFalse)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @base.handle_errors"},{"line_number":81,"context_line":"    def list_zone_exports(self, params\u003dNone, headers\u003dNone):"}],"source_content_type":"text/x-python","patch_set":11,"id":"b617486f_046ea373","line":78,"range":{"start_line":78,"start_character":12,"end_line":78,"end_character":31},"in_reply_to":"329f1cb7_0b0275e0","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"928cd5790d710cf10f8767761a4a0385dcf230e0","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        :param uuid: Unique identifier of the zone export task in UUID format."},{"line_number":50,"context_line":"        :param params: A Python dict that represents the query paramaters to"},{"line_number":51,"context_line":"                       include in the request URI."},{"line_number":52,"context_line":"        :param headers: 3 options to send headers:"},{"line_number":53,"context_line":"                        1) If headers dict provided is missing \"Accept\" key -"},{"line_number":54,"context_line":"                         \"{Accept:text/dns}\" will be added."},{"line_number":55,"context_line":"                        2) If headers is None - headers will be empty"},{"line_number":56,"context_line":"                          (empty dictionary)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        :return: Serialized exported zone as a dictionary."},{"line_number":59,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"75dacdcf_60f20aeb","line":56,"range":{"start_line":52,"start_character":0,"end_line":56,"end_character":44},"updated":"2022-01-09 18:47:21.000000000","message":"3 options, but only 2 explained?","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        :param uuid: Unique identifier of the zone export task in UUID format."},{"line_number":50,"context_line":"        :param params: A Python dict that represents the query paramaters to"},{"line_number":51,"context_line":"                       include in the request URI."},{"line_number":52,"context_line":"        :param headers: 3 options to send headers:"},{"line_number":53,"context_line":"                        1) If headers dict provided is missing \"Accept\" key -"},{"line_number":54,"context_line":"                         \"{Accept:text/dns}\" will be added."},{"line_number":55,"context_line":"                        2) If headers is None - headers will be empty"},{"line_number":56,"context_line":"                          (empty dictionary)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        :return: Serialized exported zone as a dictionary."},{"line_number":59,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"6965daca_cc1d3b4c","line":56,"range":{"start_line":52,"start_character":0,"end_line":56,"end_character":44},"in_reply_to":"75dacdcf_60f20aeb","updated":"2022-01-18 11:44:34.000000000","message":"My mistake, I need to replace between them.\nL52 \u003e\u003e L70","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"928cd5790d710cf10f8767761a4a0385dcf230e0","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        :param uuid: Unique identifier of the zone exprot task in UUID format."},{"line_number":68,"context_line":"        :param params: A Python dict that represents the query paramaters to"},{"line_number":69,"context_line":"                       include in the request URI."},{"line_number":70,"context_line":"        :param headers: (dict) The headers to use for the request."},{"line_number":71,"context_line":"        :return: Serialized exported zone as a dictionary."},{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"769b6cc8_d62522de","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":66},"updated":"2022-01-09 18:47:21.000000000","message":"Duplicated to L52","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        :param uuid: Unique identifier of the zone exprot task in UUID format."},{"line_number":68,"context_line":"        :param params: A Python dict that represents the query paramaters to"},{"line_number":69,"context_line":"                       include in the request URI."},{"line_number":70,"context_line":"        :param headers: (dict) The headers to use for the request."},{"line_number":71,"context_line":"        :return: Serialized exported zone as a dictionary."},{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"81b12344_bd601b85","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":66},"in_reply_to":"769b6cc8_d62522de","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"928cd5790d710cf10f8767761a4a0385dcf230e0","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        :return: Serialized exported zone as a dictionary."},{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        if headers:"},{"line_number":75,"context_line":"            if \u0027accept\u0027 not in [key.lower() for key in headers.keys()]:"},{"line_number":76,"context_line":"                headers[\u0027Accept\u0027] \u003d \u0027text/dns\u0027"},{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            headers \u003d {}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        resp, body \u003d self._show_request("},{"line_number":81,"context_line":"            \u0027zones/tasks/exports/{0}/export\u0027.format(uuid),"}],"source_content_type":"text/x-python","patch_set":12,"id":"66ad0471_e6d27b5f","line":78,"range":{"start_line":74,"start_character":0,"end_line":78,"end_character":24},"updated":"2022-01-09 18:47:21.000000000","message":"Th old code was taking care about adding {\u0027Accept\u0027:text/dns} when no headers have been provided in function call.\nhttps://github.com/openstack/designate-tempest-plugin/blob/master/designate_tempest_plugin/services/dns/v2/json/zone_exports_client.py#L67\nYour code sends {} instead of {\u0027Accept\u0027:text/dns}","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        :return: Serialized exported zone as a dictionary."},{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        if headers:"},{"line_number":75,"context_line":"            if \u0027accept\u0027 not in [key.lower() for key in headers.keys()]:"},{"line_number":76,"context_line":"                headers[\u0027Accept\u0027] \u003d \u0027text/dns\u0027"},{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            headers \u003d {}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        resp, body \u003d self._show_request("},{"line_number":81,"context_line":"            \u0027zones/tasks/exports/{0}/export\u0027.format(uuid),"}],"source_content_type":"text/x-python","patch_set":12,"id":"8b2066d0_2b8412ef","line":78,"range":{"start_line":74,"start_character":0,"end_line":78,"end_character":24},"in_reply_to":"66ad0471_e6d27b5f","updated":"2022-01-18 11:44:34.000000000","message":"We talked about it","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        resp, body \u003d self._create_request("},{"line_number":35,"context_line":"            export_uri, params\u003dparams)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # Create Zone Export should Return an HTTP 202"},{"line_number":38,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        if wait_until:"}],"source_content_type":"text/x-python","patch_set":14,"id":"1853df73_452a2486","line":37,"range":{"start_line":37,"start_character":44,"end_line":37,"end_character":45},"updated":"2022-01-16 20:45:48.000000000","message":"Nit\n\"a\" was in place here.","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        resp, body \u003d self._create_request("},{"line_number":35,"context_line":"            export_uri, params\u003dparams)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # Create Zone Export should Return an HTTP 202"},{"line_number":38,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        if wait_until:"}],"source_content_type":"text/x-python","patch_set":14,"id":"bfff2d61_c5589b43","line":37,"range":{"start_line":37,"start_character":44,"end_line":37,"end_character":45},"in_reply_to":"1853df73_452a2486","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    @base.handle_errors"},{"line_number":46,"context_line":"    def show_zone_export(self, uuid, params\u003dNone, headers\u003dNone):"},{"line_number":47,"context_line":"        \"\"\"Get the zone export task"},{"line_number":48,"context_line":"        :param headers: (dict) The headers to use for the request."},{"line_number":49,"context_line":"        :param uuid: Unique identifier of the zone export task in UUID format."},{"line_number":50,"context_line":"        :param params: A Python dict that represents the query parameters to"},{"line_number":51,"context_line":"                       include in the request URI."}],"source_content_type":"text/x-python","patch_set":14,"id":"1d4729ca_a86feeb7","line":48,"range":{"start_line":48,"start_character":7,"end_line":48,"end_character":66},"updated":"2022-01-16 20:45:48.000000000","message":"Nit\nAny reason for removing empty line?","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    @base.handle_errors"},{"line_number":46,"context_line":"    def show_zone_export(self, uuid, params\u003dNone, headers\u003dNone):"},{"line_number":47,"context_line":"        \"\"\"Get the zone export task"},{"line_number":48,"context_line":"        :param headers: (dict) The headers to use for the request."},{"line_number":49,"context_line":"        :param uuid: Unique identifier of the zone export task in UUID format."},{"line_number":50,"context_line":"        :param params: A Python dict that represents the query parameters to"},{"line_number":51,"context_line":"                       include in the request URI."}],"source_content_type":"text/x-python","patch_set":14,"id":"7ca900a4_b76aba1f","line":48,"range":{"start_line":48,"start_character":7,"end_line":48,"end_character":66},"in_reply_to":"1d4729ca_a86feeb7","updated":"2022-01-18 11:44:34.000000000","message":"I\u0027m not understand what are you mean,\nI didn\u0027t used on this function","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        :param params: A Python dict that represents the query parameters to"},{"line_number":65,"context_line":"                       include in the request URI."},{"line_number":66,"context_line":"        :param headers: 3 options to send headers:"},{"line_number":67,"context_line":"                       1) If headers dict provided is missing \"Accept\" key -"},{"line_number":68,"context_line":"                        \"{Accept:text/dns}\" will be added."},{"line_number":69,"context_line":"                       2) If header is None -"},{"line_number":70,"context_line":"                       \"{Accept:text/dns}\" will be sent."},{"line_number":71,"context_line":"                       3) If headers send empty dict -"},{"line_number":72,"context_line":"                       headers will be empty (empty dictionary)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        :return: Serialized exported zone as a dictionary."},{"line_number":75,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"4d93bdc8_c1c3c3c2","line":72,"range":{"start_line":67,"start_character":0,"end_line":72,"end_character":63},"updated":"2022-01-16 20:45:48.000000000","message":"Make an order with spaces, I mean:\n\n                       1) If headers dict provided is missing \"Accept\" key -\n                          \"{Accept:text/dns}\" will be added.\n                       2) If header is None -\n                          \"{Accept:text/dns}\" will be sent.\n\nalso, #3 needed to be rephrased, It\u0027s not so clear.","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        :param params: A Python dict that represents the query parameters to"},{"line_number":65,"context_line":"                       include in the request URI."},{"line_number":66,"context_line":"        :param headers: 3 options to send headers:"},{"line_number":67,"context_line":"                       1) If headers dict provided is missing \"Accept\" key -"},{"line_number":68,"context_line":"                        \"{Accept:text/dns}\" will be added."},{"line_number":69,"context_line":"                       2) If header is None -"},{"line_number":70,"context_line":"                       \"{Accept:text/dns}\" will be sent."},{"line_number":71,"context_line":"                       3) If headers send empty dict -"},{"line_number":72,"context_line":"                       headers will be empty (empty dictionary)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        :return: Serialized exported zone as a dictionary."},{"line_number":75,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"5c67e297_18cd1ddc","line":72,"range":{"start_line":67,"start_character":0,"end_line":72,"end_character":63},"in_reply_to":"4d93bdc8_c1c3c3c2","updated":"2022-01-18 11:44:34.000000000","message":"3) If client send request with no headers (send empty dict) -\n                          no headers will be sent (empty dictionary)","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":79,"context_line":"                headers[\u0027Accept\u0027] \u003d \u0027text/dns\u0027"},{"line_number":80,"context_line":"        elif headers is None:"},{"line_number":81,"context_line":"            headers \u003d {\u0027Accept\u0027: \u0027text/dns\u0027}"},{"line_number":82,"context_line":"        elif headers is {}:"},{"line_number":83,"context_line":"            headers \u003d {}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        resp, body \u003d self._show_request("},{"line_number":86,"context_line":"            \u0027zones/tasks/exports/{0}/export\u0027.format(uuid),"}],"source_content_type":"text/x-python","patch_set":14,"id":"13893bb3_17dfc7e9","line":83,"range":{"start_line":82,"start_character":0,"end_line":83,"end_character":24},"updated":"2022-01-16 20:45:48.000000000","message":"This \"elif\" should be replaced by else.\n\nSee \"elif Condition: example here:https://www.tutorialsteacher.com/python/python-if-elif","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                headers[\u0027Accept\u0027] \u003d \u0027text/dns\u0027"},{"line_number":80,"context_line":"        elif headers is None:"},{"line_number":81,"context_line":"            headers \u003d {\u0027Accept\u0027: \u0027text/dns\u0027}"},{"line_number":82,"context_line":"        elif headers is {}:"},{"line_number":83,"context_line":"            headers \u003d {}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        resp, body \u003d self._show_request("},{"line_number":86,"context_line":"            \u0027zones/tasks/exports/{0}/export\u0027.format(uuid),"}],"source_content_type":"text/x-python","patch_set":14,"id":"9907d409_a14accfa","line":83,"range":{"start_line":82,"start_character":0,"end_line":83,"end_character":24},"in_reply_to":"13893bb3_17dfc7e9","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        elif headers is {}:"},{"line_number":83,"context_line":"            headers \u003d {}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        resp, body \u003d self._show_request("},{"line_number":86,"context_line":"            \u0027zones/tasks/exports/{0}/export\u0027.format(uuid),"},{"line_number":87,"context_line":"            uuid\u003d\u0027\u0027, headers\u003dheaders, params\u003dparams)"},{"line_number":88,"context_line":"        return resp, body"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @base.handle_errors"},{"line_number":91,"context_line":"    def list_zone_exports(self, params\u003dNone, headers\u003dNone):"}],"source_content_type":"text/x-python","patch_set":14,"id":"f4bb492d_20707529","line":88,"range":{"start_line":85,"start_character":0,"end_line":88,"end_character":25},"updated":"2022-01-16 20:45:48.000000000","message":"I think that we don\u0027t need: resp, body parameters here.\nThe old \"return\" does the same job, it will return the same tuple.","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        elif headers is {}:"},{"line_number":83,"context_line":"            headers \u003d {}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        resp, body \u003d self._show_request("},{"line_number":86,"context_line":"            \u0027zones/tasks/exports/{0}/export\u0027.format(uuid),"},{"line_number":87,"context_line":"            uuid\u003d\u0027\u0027, headers\u003dheaders, params\u003dparams)"},{"line_number":88,"context_line":"        return resp, body"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @base.handle_errors"},{"line_number":91,"context_line":"    def list_zone_exports(self, params\u003dNone, headers\u003dNone):"}],"source_content_type":"text/x-python","patch_set":14,"id":"fbb055a8_df99b569","line":88,"range":{"start_line":85,"start_character":0,"end_line":88,"end_character":25},"in_reply_to":"f4bb492d_20707529","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":91,"context_line":"    def list_zone_exports(self, params\u003dNone, headers\u003dNone):"},{"line_number":92,"context_line":"        \"\"\"List zone export tasks"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        :param params: A Python dict that represents the query parameters to"},{"line_number":95,"context_line":"                       include in the request URI."},{"line_number":96,"context_line":"        :param headers (dict): The headers to use for the request."},{"line_number":97,"context_line":"        :return: Serialized exported zone as a list."}],"source_content_type":"text/x-python","patch_set":14,"id":"23d80d21_5b01b07c","line":94,"range":{"start_line":94,"start_character":68,"end_line":94,"end_character":69},"updated":"2022-01-16 20:45:48.000000000","message":"😊","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def list_zone_exports(self, params\u003dNone, headers\u003dNone):"},{"line_number":92,"context_line":"        \"\"\"List zone export tasks"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        :param params: A Python dict that represents the query parameters to"},{"line_number":95,"context_line":"                       include in the request URI."},{"line_number":96,"context_line":"        :param headers (dict): The headers to use for the request."},{"line_number":97,"context_line":"        :return: Serialized exported zone as a list."}],"source_content_type":"text/x-python","patch_set":14,"id":"6cdc1404_3f6ce52a","line":94,"range":{"start_line":94,"start_character":68,"end_line":94,"end_character":69},"in_reply_to":"23d80d21_5b01b07c","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"eec8ffacf9583ac8994d9a9245ab9d66bc91d3b4","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param uuid: Unique identifier of the zone export task in UUID format."},{"line_number":50,"context_line":"        :param params: A Python dict that represents the query paramaters to"},{"line_number":51,"context_line":"                       include in the request URI."},{"line_number":52,"context_line":"        :param headers (dict): The headers to use for the request."},{"line_number":53,"context_line":"        :return: Serialized exported zone as a dictionary."},{"line_number":54,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"73594961_8561097b","line":51,"updated":"2022-01-28 22:26:40.000000000","message":"If your going to change the above L26: paramaters to parameters should change them all.","commit_id":"ba61e0c283dff30373de7f8fad1240b959791df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"b46c107429b4b029fd44867d0cd1fbe69f9f880d","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param uuid: Unique identifier of the zone export task in UUID format."},{"line_number":50,"context_line":"        :param params: A Python dict that represents the query paramaters to"},{"line_number":51,"context_line":"                       include in the request URI."},{"line_number":52,"context_line":"        :param headers (dict): The headers to use for the request."},{"line_number":53,"context_line":"        :return: Serialized exported zone as a dictionary."},{"line_number":54,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"6d300729_b857205a","line":51,"in_reply_to":"73594961_8561097b","updated":"2022-02-01 11:50:15.000000000","message":"Done","commit_id":"ba61e0c283dff30373de7f8fad1240b959791df4"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"eec8ffacf9583ac8994d9a9245ab9d66bc91d3b4","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        \"\"\"Deletes the zone export task with the specified UUID."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        :param uuid: The unique identifier of the exported zone."},{"line_number":107,"context_line":"        :param params: A Python dict that represents the query paramaters to"},{"line_number":108,"context_line":"                       include in the request URI."},{"line_number":109,"context_line":"        :return: A tuple with the server response and the response body."},{"line_number":110,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"758b8f17_a755b697","line":107,"updated":"2022-01-28 22:26:40.000000000","message":"If your going to change the above L26: paramaters to parameters should change them all.","commit_id":"ba61e0c283dff30373de7f8fad1240b959791df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"b46c107429b4b029fd44867d0cd1fbe69f9f880d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        \"\"\"Deletes the zone export task with the specified UUID."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        :param uuid: The unique identifier of the exported zone."},{"line_number":107,"context_line":"        :param params: A Python dict that represents the query paramaters to"},{"line_number":108,"context_line":"                       include in the request URI."},{"line_number":109,"context_line":"        :return: A tuple with the server response and the response body."},{"line_number":110,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"a8025c9b_c264c091","line":107,"in_reply_to":"758b8f17_a755b697","updated":"2022-02-01 11:50:15.000000000","message":"Done","commit_id":"ba61e0c283dff30373de7f8fad1240b959791df4"}],"designate_tempest_plugin/tests/api/v2/test_zones_exports.py":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c0d287837c9a0f432ed5b226046ed6c1a1dcd039","unresolved":true,"context_lines":[{"line_number":326,"context_line":"        LOG.info(\u0027The resource could not be generated\u0027"},{"line_number":327,"context_line":"                 \u0027that was acceptable to your browser\u0027"},{"line_number":328,"context_line":"                 \u0027(content of type image/jpeg).\u0027"},{"line_number":329,"context_line":"                 \u0027Expected: 406\u0027)404"},{"line_number":330,"context_line":"        self.assertRaises("},{"line_number":331,"context_line":"            lib_exc.UnexpectedResponseCode,"},{"line_number":332,"context_line":"            lambda: self.client.show_exported_zonefile("}],"source_content_type":"text/x-python","patch_set":1,"id":"636abd99_0b9f777d","line":329,"updated":"2021-12-30 14:39:47.000000000","message":"You have a syntax issue, I didn\u0027t check all the gates (all failed) but the reason is probably the same. Here is some example from Gate\u0027s log:\n\n\n2021-12-30 13:03:30.192789 | controller | Failed to import test module: designate_tempest_plugin.tests.scenario.v2.test_zones_export\n2021-12-30 13:03:30.192798 | controller | Traceback (most recent call last):\n2021-12-30 13:03:30.192808 | controller |   File \"/usr/lib/python3.8/unittest/loader.py\", line 436, in _find_test_path\n2021-12-30 13:03:30.192818 | controller |     module \u003d self._get_module_from_name(name)\n2021-12-30 13:03:30.192827 | controller |   File \"/usr/lib/python3.8/unittest/loader.py\", line 377, in _get_module_from_name\n2021-12-30 13:03:30.192837 | controller |     __import__(name)\n2021-12-30 13:03:30.192847 | controller |   File \"/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/designate_tempest_plugin/tests/scenario/v2/test_zones_export.py\", line 19, in \u003cmodule\u003e\n2021-12-30 13:03:30.192858 | controller |     from designate_tempest_plugin.tests.api.v2.test_zones_exports import \\\n2021-12-30 13:03:30.192868 | controller |   File \"/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/designate_tempest_plugin/tests/api/v2/test_zones_exports.py\", line 329\n2021-12-30 13:03:30.192913 | controller |     \u0027Expected: 406\u0027)404\n2021-12-30 13:03:30.192928 | controller |                     ^\n2021-12-30 13:03:30.192938 | controller | SyntaxError: invalid syntax","commit_id":"bea691cfffd64598341fe08f993ff8cfd958a35e"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        LOG.info(\u0027The resource could not be generated\u0027"},{"line_number":327,"context_line":"                 \u0027that was acceptable to your browser\u0027"},{"line_number":328,"context_line":"                 \u0027(content of type image/jpeg).\u0027"},{"line_number":329,"context_line":"                 \u0027Expected: 406\u0027)404"},{"line_number":330,"context_line":"        self.assertRaises("},{"line_number":331,"context_line":"            lib_exc.UnexpectedResponseCode,"},{"line_number":332,"context_line":"            lambda: self.client.show_exported_zonefile("}],"source_content_type":"text/x-python","patch_set":1,"id":"39ed8574_808bb1ff","line":329,"in_reply_to":"636abd99_0b9f777d","updated":"2022-01-09 17:47:30.000000000","message":"I fix that","commit_id":"bea691cfffd64598341fe08f993ff8cfd958a35e"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7e88ebee2d08377443becbee7d57b94549da8c92","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZoneExportsClient()"},{"line_number":51,"context_line":"        cls.alt_client \u003d cls.os_alt.dns_v2.ZoneExportsClient()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _creating_a_zone_and_exporting_it(self):"},{"line_number":54,"context_line":"        LOG.info(\u0027Create a zone\u0027)"},{"line_number":55,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"},{"line_number":56,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"0910f220_f4821328","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":41},"updated":"2021-12-30 16:13:19.000000000","message":"Let\u0027s change to \"_create_zone_export\"","commit_id":"0c1e3c941ccd8888a0402d0116687f1b32168e03"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZoneExportsClient()"},{"line_number":51,"context_line":"        cls.alt_client \u003d cls.os_alt.dns_v2.ZoneExportsClient()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _creating_a_zone_and_exporting_it(self):"},{"line_number":54,"context_line":"        LOG.info(\u0027Create a zone\u0027)"},{"line_number":55,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"},{"line_number":56,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"be4dc04e_9421b304","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":41},"in_reply_to":"0910f220_f4821328","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"0c1e3c941ccd8888a0402d0116687f1b32168e03"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7e88ebee2d08377443becbee7d57b94549da8c92","unresolved":true,"context_lines":[{"line_number":218,"context_line":"        zone, zone_export \u003d self._creating_a_zone_and_exporting_it()"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        LOG.info(\u0027Impersonate \"primary\" client, to show exported zone file\u0027)"},{"line_number":221,"context_line":"        response \u003d self.admin_client.show_exported_zonefile("},{"line_number":222,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{"},{"line_number":223,"context_line":"                \u0027x-auth-sudo-project-id\u0027: zone[\u0027project_id\u0027]})[1]"},{"line_number":224,"context_line":"        self.assertEqual(zone[\u0027name\u0027], response.origin)"},{"line_number":225,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], response.ttl)"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b59e752b_2e4ca676","line":223,"range":{"start_line":221,"start_character":0,"end_line":223,"end_character":65},"updated":"2021-12-30 16:13:19.000000000","message":"With the current implementation (where client doesn\u0027t care if Accept header presents or not in provided headers, like it\u0027s done here) Accept header (that seems to be mandatory for this API) won\u0027t be sent.\nThis needed to be fixed on client side, you need to check all provided headers keys and if \"Accept\" is missing, you\u0027ll need to add it with appropriate value.","commit_id":"0c1e3c941ccd8888a0402d0116687f1b32168e03"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        zone, zone_export \u003d self._creating_a_zone_and_exporting_it()"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        LOG.info(\u0027Impersonate \"primary\" client, to show exported zone file\u0027)"},{"line_number":221,"context_line":"        response \u003d self.admin_client.show_exported_zonefile("},{"line_number":222,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{"},{"line_number":223,"context_line":"                \u0027x-auth-sudo-project-id\u0027: zone[\u0027project_id\u0027]})[1]"},{"line_number":224,"context_line":"        self.assertEqual(zone[\u0027name\u0027], response.origin)"},{"line_number":225,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], response.ttl)"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c73423ee_e78cef5e","line":223,"range":{"start_line":221,"start_character":0,"end_line":223,"end_character":65},"in_reply_to":"b59e752b_2e4ca676","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"0c1e3c941ccd8888a0402d0116687f1b32168e03"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9eef5e29fca6854bb4d80b05f74462d7bd9be59f","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZoneExportsClient()"},{"line_number":52,"context_line":"        cls.alt_client \u003d cls.os_alt.dns_v2.ZoneExportsClient()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _create_zone_export(self):"},{"line_number":55,"context_line":"        LOG.info(\u0027Create a zone\u0027)"},{"line_number":56,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"},{"line_number":57,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"a0027e7c_ebd131ba","line":54,"updated":"2022-01-07 23:55:19.000000000","message":"Nice removing the duplicate code here!","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZoneExportsClient()"},{"line_number":52,"context_line":"        cls.alt_client \u003d cls.os_alt.dns_v2.ZoneExportsClient()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _create_zone_export(self):"},{"line_number":55,"context_line":"        LOG.info(\u0027Create a zone\u0027)"},{"line_number":56,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"},{"line_number":57,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"a05ef552_5099e9cd","line":54,"in_reply_to":"a0027e7c_ebd131ba","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9e13c282ef31da6b3286bef2b2c70766458e9e8b","unresolved":true,"context_lines":[{"line_number":235,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZoneExportsClient()"},{"line_number":236,"context_line":"        cls.alt_client \u003d cls.os_alt.dns_v2.ZoneExportsClient()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _create_zone_export(self):"},{"line_number":239,"context_line":"        LOG.info(\u0027Create a zone\u0027)"},{"line_number":240,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"},{"line_number":241,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"0515f768_18d13afa","line":238,"updated":"2022-01-06 15:42:23.000000000","message":"Do we really need this method for ZonesExportTestNegative class?\nWhere do we use it in this calss?","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9eef5e29fca6854bb4d80b05f74462d7bd9be59f","unresolved":true,"context_lines":[{"line_number":235,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZoneExportsClient()"},{"line_number":236,"context_line":"        cls.alt_client \u003d cls.os_alt.dns_v2.ZoneExportsClient()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _create_zone_export(self):"},{"line_number":239,"context_line":"        LOG.info(\u0027Create a zone\u0027)"},{"line_number":240,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"},{"line_number":241,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"64305539_6be4555c","line":238,"in_reply_to":"0515f768_18d13afa","updated":"2022-01-07 23:55:19.000000000","message":"+1, I don\u0027t see this used in this class. It can probably be removed.","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZoneExportsClient()"},{"line_number":236,"context_line":"        cls.alt_client \u003d cls.os_alt.dns_v2.ZoneExportsClient()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _create_zone_export(self):"},{"line_number":239,"context_line":"        LOG.info(\u0027Create a zone\u0027)"},{"line_number":240,"context_line":"        zone \u003d self.zone_client.create_zone()[1]"},{"line_number":241,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"423eb915_b64a1186","line":238,"in_reply_to":"64305539_6be4555c","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":182,"context_line":"        alt_export \u003d self.alt_client.create_zone_export(alt_zone[\u0027id\u0027])[1]"},{"line_number":183,"context_line":"        self.alt_client.delete_zone_export(alt_export[\u0027id\u0027])"},{"line_number":184,"context_line":"        LOG.info(\u0027Ensure the zone export has been successfully deleted\u0027)"},{"line_number":185,"context_line":"        self.assertRaises("},{"line_number":186,"context_line":"            lib_exc.NotFound,"},{"line_number":187,"context_line":"            lambda: self.alt_client.show_zone_export(alt_export[\u0027id\u0027]))"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        LOG.info(\u0027Filter out \"export zones\" in status:ZAHLABUT,\u0027"},{"line_number":190,"context_line":"                 \u0027 expected: empty list\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"deab14bb_c725b293","line":187,"range":{"start_line":185,"start_character":0,"end_line":187,"end_character":71},"updated":"2022-01-16 20:45:48.000000000","message":"Removing \"lambda\" (just as you\u0027ve done in your new test) is in place here.\nI\u0027ve seen the same issue in some other existing test in this script","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        alt_export \u003d self.alt_client.create_zone_export(alt_zone[\u0027id\u0027])[1]"},{"line_number":183,"context_line":"        self.alt_client.delete_zone_export(alt_export[\u0027id\u0027])"},{"line_number":184,"context_line":"        LOG.info(\u0027Ensure the zone export has been successfully deleted\u0027)"},{"line_number":185,"context_line":"        self.assertRaises("},{"line_number":186,"context_line":"            lib_exc.NotFound,"},{"line_number":187,"context_line":"            lambda: self.alt_client.show_zone_export(alt_export[\u0027id\u0027]))"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        LOG.info(\u0027Filter out \"export zones\" in status:ZAHLABUT,\u0027"},{"line_number":190,"context_line":"                 \u0027 expected: empty list\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"d08b01cb_8c8318ff","line":187,"range":{"start_line":185,"start_character":0,"end_line":187,"end_character":71},"in_reply_to":"deab14bb_c725b293","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":294,"context_line":"            resp_header, resp_body \u003d self.client.show_exported_zonefile("},{"line_number":295,"context_line":"                zone_export[\u0027id\u0027],"},{"line_number":296,"context_line":"                headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"},{"line_number":297,"context_line":"            if resp_header.status \u003d\u003d 200:"},{"line_number":298,"context_line":"                self.assertTrue("},{"line_number":299,"context_line":"                    False,"},{"line_number":300,"context_line":"                    msg\u003d\u0027Response code receive status {0}, \u0027"},{"line_number":301,"context_line":"                        \u0027expected status code is 406\u0027"},{"line_number":302,"context_line":"                        .format(resp_header.status))"},{"line_number":303,"context_line":"        except Exception as err:"},{"line_number":304,"context_line":"            LOG.info(\u0027Expected: 406 Unexpected response code received\u0027)"},{"line_number":305,"context_line":"            self.assertEqual(406, err.resp.status,"}],"source_content_type":"text/x-python","patch_set":14,"id":"0a5d5062_fd46803c","line":302,"range":{"start_line":297,"start_character":0,"end_line":302,"end_character":52},"updated":"2022-01-16 20:45:48.000000000","message":"We don\u0027t need \"if\" here.\nself.assertNotEqual(200, resp_header.status, msg) will probably do the same.","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            resp_header, resp_body \u003d self.client.show_exported_zonefile("},{"line_number":295,"context_line":"                zone_export[\u0027id\u0027],"},{"line_number":296,"context_line":"                headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"},{"line_number":297,"context_line":"            if resp_header.status \u003d\u003d 200:"},{"line_number":298,"context_line":"                self.assertTrue("},{"line_number":299,"context_line":"                    False,"},{"line_number":300,"context_line":"                    msg\u003d\u0027Response code receive status {0}, \u0027"},{"line_number":301,"context_line":"                        \u0027expected status code is 406\u0027"},{"line_number":302,"context_line":"                        .format(resp_header.status))"},{"line_number":303,"context_line":"        except Exception as err:"},{"line_number":304,"context_line":"            LOG.info(\u0027Expected: 406 Unexpected response code received\u0027)"},{"line_number":305,"context_line":"            self.assertEqual(406, err.resp.status,"}],"source_content_type":"text/x-python","patch_set":14,"id":"523a6569_8df331b3","line":302,"range":{"start_line":297,"start_character":0,"end_line":302,"end_character":52},"in_reply_to":"0a5d5062_fd46803c","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":301,"context_line":"                        \u0027expected status code is 406\u0027"},{"line_number":302,"context_line":"                        .format(resp_header.status))"},{"line_number":303,"context_line":"        except Exception as err:"},{"line_number":304,"context_line":"            LOG.info(\u0027Expected: 406 Unexpected response code received\u0027)"},{"line_number":305,"context_line":"            self.assertEqual(406, err.resp.status,"},{"line_number":306,"context_line":"                            \"Response code didn\u0027t receive error 406\")"},{"line_number":307,"context_line":"            self.assertEqual(\u0027Not Acceptable\u0027, err.resp.reason,"}],"source_content_type":"text/x-python","patch_set":14,"id":"65c88471_0d040dc9","line":304,"range":{"start_line":304,"start_character":22,"end_line":304,"end_character":70},"updated":"2022-01-16 20:45:48.000000000","message":"Expected: 406 Unexpected response code received","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                        \u0027expected status code is 406\u0027"},{"line_number":302,"context_line":"                        .format(resp_header.status))"},{"line_number":303,"context_line":"        except Exception as err:"},{"line_number":304,"context_line":"            LOG.info(\u0027Expected: 406 Unexpected response code received\u0027)"},{"line_number":305,"context_line":"            self.assertEqual(406, err.resp.status,"},{"line_number":306,"context_line":"                            \"Response code didn\u0027t receive error 406\")"},{"line_number":307,"context_line":"            self.assertEqual(\u0027Not Acceptable\u0027, err.resp.reason,"}],"source_content_type":"text/x-python","patch_set":14,"id":"00cc1539_804b0959","line":304,"range":{"start_line":304,"start_character":22,"end_line":304,"end_character":70},"in_reply_to":"65c88471_0d040dc9","updated":"2022-01-18 11:44:34.000000000","message":"Expected: 406 Not Acceptable","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":303,"context_line":"        except Exception as err:"},{"line_number":304,"context_line":"            LOG.info(\u0027Expected: 406 Unexpected response code received\u0027)"},{"line_number":305,"context_line":"            self.assertEqual(406, err.resp.status,"},{"line_number":306,"context_line":"                            \"Response code didn\u0027t receive error 406\")"},{"line_number":307,"context_line":"            self.assertEqual(\u0027Not Acceptable\u0027, err.resp.reason,"},{"line_number":308,"context_line":"                       \"Response code didn\u0027t receive error 406\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"e3d82b7b_43884e59","line":306,"range":{"start_line":306,"start_character":29,"end_line":306,"end_character":67},"updated":"2022-01-16 20:45:48.000000000","message":"Something like this:\n\n\"Failed, actual response code is:{} but expected is: 406\".format(err.resp.status)\n\nwill be better.","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        except Exception as err:"},{"line_number":304,"context_line":"            LOG.info(\u0027Expected: 406 Unexpected response code received\u0027)"},{"line_number":305,"context_line":"            self.assertEqual(406, err.resp.status,"},{"line_number":306,"context_line":"                            \"Response code didn\u0027t receive error 406\")"},{"line_number":307,"context_line":"            self.assertEqual(\u0027Not Acceptable\u0027, err.resp.reason,"},{"line_number":308,"context_line":"                       \"Response code didn\u0027t receive error 406\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"5ac2cb8f_c8adce51","line":306,"range":{"start_line":306,"start_character":29,"end_line":306,"end_character":67},"in_reply_to":"e3d82b7b_43884e59","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":305,"context_line":"            self.assertEqual(406, err.resp.status,"},{"line_number":306,"context_line":"                            \"Response code didn\u0027t receive error 406\")"},{"line_number":307,"context_line":"            self.assertEqual(\u0027Not Acceptable\u0027, err.resp.reason,"},{"line_number":308,"context_line":"                       \"Response code didn\u0027t receive error 406\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"827c40c0_90221ca6","line":308,"range":{"start_line":308,"start_character":24,"end_line":308,"end_character":62},"updated":"2022-01-16 20:45:48.000000000","message":"Similar to L305, just rephrase it for HTTP response body.","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":305,"context_line":"            self.assertEqual(406, err.resp.status,"},{"line_number":306,"context_line":"                            \"Response code didn\u0027t receive error 406\")"},{"line_number":307,"context_line":"            self.assertEqual(\u0027Not Acceptable\u0027, err.resp.reason,"},{"line_number":308,"context_line":"                       \"Response code didn\u0027t receive error 406\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"0967b0ec_3020728c","line":308,"range":{"start_line":308,"start_character":24,"end_line":308,"end_character":62},"in_reply_to":"827c40c0_90221ca6","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"47344a4a70c5c64fdc23b1521dd547c7ca5dee32","unresolved":true,"context_lines":[{"line_number":121,"context_line":"        LOG.info(\u0027Ensure the zone export has been successfully deleted\u0027)"},{"line_number":122,"context_line":"        self.assertRaises("},{"line_number":123,"context_line":"            lib_exc.NotFound,"},{"line_number":124,"context_line":"            lambda: self.client.show_zone_export(zone_export[\u0027id\u0027]))"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    @decorators.idempotent_id(\u0027476bfdfe-58c8-46e2-b376-8403c0fff440\u0027)"},{"line_number":127,"context_line":"    def test_list_zone_exports(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"f6f2b4a7_88adb36e","line":124,"range":{"start_line":124,"start_character":12,"end_line":124,"end_character":18},"updated":"2022-01-17 18:48:33.000000000","message":"Do we need lambda here? Seems like you\u0027ve missed to remove that one.","commit_id":"affbe3fc7bba3a6c85674b76887e22b6dd9e0b41"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        LOG.info(\u0027Ensure the zone export has been successfully deleted\u0027)"},{"line_number":122,"context_line":"        self.assertRaises("},{"line_number":123,"context_line":"            lib_exc.NotFound,"},{"line_number":124,"context_line":"            lambda: self.client.show_zone_export(zone_export[\u0027id\u0027]))"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    @decorators.idempotent_id(\u0027476bfdfe-58c8-46e2-b376-8403c0fff440\u0027)"},{"line_number":127,"context_line":"    def test_list_zone_exports(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"8dc5cfe7_5af11f1b","line":124,"range":{"start_line":124,"start_character":12,"end_line":124,"end_character":18},"in_reply_to":"f6f2b4a7_88adb36e","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"affbe3fc7bba3a6c85674b76887e22b6dd9e0b41"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"47344a4a70c5c64fdc23b1521dd547c7ca5dee32","unresolved":true,"context_lines":[{"line_number":296,"context_line":"                zone_export[\u0027id\u0027],"},{"line_number":297,"context_line":"                headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"},{"line_number":298,"context_line":"            self.assertNotEqual(200, resp_header.status,"},{"line_number":299,"context_line":"                                \u0027Response code receive status {0}, \u0027"},{"line_number":300,"context_line":"                                \u0027expected status code is 406\u0027"},{"line_number":301,"context_line":"                                .format(resp_header.status))"},{"line_number":302,"context_line":"        except Exception as err:"}],"source_content_type":"text/x-python","patch_set":15,"id":"e39cef87_b17c0e27","line":299,"range":{"start_line":299,"start_character":33,"end_line":299,"end_character":61},"updated":"2022-01-17 18:48:33.000000000","message":"Nit\n\n\"Received status code is:\" instead of \"Response code receive status\", would be be better.","commit_id":"affbe3fc7bba3a6c85674b76887e22b6dd9e0b41"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                zone_export[\u0027id\u0027],"},{"line_number":297,"context_line":"                headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"},{"line_number":298,"context_line":"            self.assertNotEqual(200, resp_header.status,"},{"line_number":299,"context_line":"                                \u0027Response code receive status {0}, \u0027"},{"line_number":300,"context_line":"                                \u0027expected status code is 406\u0027"},{"line_number":301,"context_line":"                                .format(resp_header.status))"},{"line_number":302,"context_line":"        except Exception as err:"}],"source_content_type":"text/x-python","patch_set":15,"id":"4565da8e_8d5fda61","line":299,"range":{"start_line":299,"start_character":33,"end_line":299,"end_character":61},"in_reply_to":"e39cef87_b17c0e27","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"affbe3fc7bba3a6c85674b76887e22b6dd9e0b41"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bbc3e85ca9c90436c533d92db6a54a0e3f2aa9b5","unresolved":true,"context_lines":[{"line_number":295,"context_line":"            resp_header, resp_body \u003d self.client.show_exported_zonefile("},{"line_number":296,"context_line":"                zone_export[\u0027id\u0027],"},{"line_number":297,"context_line":"                headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"},{"line_number":298,"context_line":"            self.assertNotEqual(200, resp_header.status,"},{"line_number":299,"context_line":"                                \u0027Received status code is: {0}, \u0027"},{"line_number":300,"context_line":"                                \u0027expected status code is 406\u0027"},{"line_number":301,"context_line":"                                .format(resp_header.status))"}],"source_content_type":"text/x-python","patch_set":16,"id":"4fbfa80f_31e897ca","line":298,"updated":"2022-01-26 18:25:56.000000000","message":"Should this ever run? It seems like this test is going to always expect an exception raised.\nMaybe this could be simplified to an assertRaises/assertRaisesRegex?","commit_id":"75687ccb7855828f642571d2e2e973dd0902fc8e"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"b3f32663f304f933bcf0a6625c552c0f40cf1553","unresolved":true,"context_lines":[{"line_number":295,"context_line":"            resp_header, resp_body \u003d self.client.show_exported_zonefile("},{"line_number":296,"context_line":"                zone_export[\u0027id\u0027],"},{"line_number":297,"context_line":"                headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"},{"line_number":298,"context_line":"            self.assertNotEqual(200, resp_header.status,"},{"line_number":299,"context_line":"                                \u0027Received status code is: {0}, \u0027"},{"line_number":300,"context_line":"                                \u0027expected status code is 406\u0027"},{"line_number":301,"context_line":"                                .format(resp_header.status))"}],"source_content_type":"text/x-python","patch_set":16,"id":"e104e505_3deaf594","line":298,"in_reply_to":"4fbfa80f_31e897ca","updated":"2022-01-26 19:41:53.000000000","message":"Yes, we expect the Designate not to response with 200 OK when client sends: Accept:image/jpeg, but (bug) if it does, then this assertion will be raised.","commit_id":"75687ccb7855828f642571d2e2e973dd0902fc8e"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"ee14921d39d47ae3bb435571217d72bf060d78c7","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            resp_header, resp_body \u003d self.client.show_exported_zonefile("},{"line_number":296,"context_line":"                zone_export[\u0027id\u0027],"},{"line_number":297,"context_line":"                headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"},{"line_number":298,"context_line":"            self.assertNotEqual(200, resp_header.status,"},{"line_number":299,"context_line":"                                \u0027Received status code is: {0}, \u0027"},{"line_number":300,"context_line":"                                \u0027expected status code is 406\u0027"},{"line_number":301,"context_line":"                                .format(resp_header.status))"}],"source_content_type":"text/x-python","patch_set":16,"id":"c3ed0cf2_90c5b078","line":298,"in_reply_to":"e104e505_3deaf594","updated":"2022-02-24 12:26:17.000000000","message":"Done","commit_id":"75687ccb7855828f642571d2e2e973dd0902fc8e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bbc3e85ca9c90436c533d92db6a54a0e3f2aa9b5","unresolved":true,"context_lines":[{"line_number":297,"context_line":"                headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"},{"line_number":298,"context_line":"            self.assertNotEqual(200, resp_header.status,"},{"line_number":299,"context_line":"                                \u0027Received status code is: {0}, \u0027"},{"line_number":300,"context_line":"                                \u0027expected status code is 406\u0027"},{"line_number":301,"context_line":"                                .format(resp_header.status))"},{"line_number":302,"context_line":"        except Exception as err:"},{"line_number":303,"context_line":"            LOG.info(\u0027Expected: 406 Not Acceptable\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"8fc5c569_a9c5223d","line":300,"updated":"2022-01-26 18:25:56.000000000","message":"The test here is for the status code to not equal 200, but the assert message says it is testing for 406.\nEither this assert needs to switch to assertEqual(406, or the message needs to be updated.","commit_id":"75687ccb7855828f642571d2e2e973dd0902fc8e"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"b46c107429b4b029fd44867d0cd1fbe69f9f880d","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"},{"line_number":298,"context_line":"            self.assertNotEqual(200, resp_header.status,"},{"line_number":299,"context_line":"                                \u0027Received status code is: {0}, \u0027"},{"line_number":300,"context_line":"                                \u0027expected status code is 406\u0027"},{"line_number":301,"context_line":"                                .format(resp_header.status))"},{"line_number":302,"context_line":"        except Exception as err:"},{"line_number":303,"context_line":"            LOG.info(\u0027Expected: 406 Not Acceptable\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"91d5834d_d17fe5c8","line":300,"in_reply_to":"1e505018_85253720","updated":"2022-02-01 11:50:15.000000000","message":"Done","commit_id":"75687ccb7855828f642571d2e2e973dd0902fc8e"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"b3f32663f304f933bcf0a6625c552c0f40cf1553","unresolved":true,"context_lines":[{"line_number":297,"context_line":"                headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"},{"line_number":298,"context_line":"            self.assertNotEqual(200, resp_header.status,"},{"line_number":299,"context_line":"                                \u0027Received status code is: {0}, \u0027"},{"line_number":300,"context_line":"                                \u0027expected status code is 406\u0027"},{"line_number":301,"context_line":"                                .format(resp_header.status))"},{"line_number":302,"context_line":"        except Exception as err:"},{"line_number":303,"context_line":"            LOG.info(\u0027Expected: 406 Not Acceptable\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1e505018_85253720","line":300,"in_reply_to":"8fc5c569_a9c5223d","updated":"2022-01-26 19:41:53.000000000","message":"+1 I missed that one 😞\n\nSure, this should be changed to \"assertEqual(406,\", we\u0027ve spoke more than once about this, actually the main idea of this test is catching 406 status 😊","commit_id":"75687ccb7855828f642571d2e2e973dd0902fc8e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1052e674fa49b1e98605e21be2466519f8717153","unresolved":true,"context_lines":[{"line_number":293,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":294,"context_line":"        LOG.info(\u0027Unexpected response code\u0027)"},{"line_number":295,"context_line":"        self.assertRaises("},{"line_number":296,"context_line":"            lib_exc.UnexpectedResponseCode,"},{"line_number":297,"context_line":"            self.client.show_exported_zonefile,"},{"line_number":298,"context_line":"            zone_export[\u0027id\u0027],"},{"line_number":299,"context_line":"            headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"}],"source_content_type":"text/x-python","patch_set":18,"id":"1536fef1_0ff262fa","line":296,"updated":"2022-02-01 01:16:14.000000000","message":"This is testing the test framework. UnexpectedResponseCode is coming from tempest and not the API.\nhttps://opendev.org/openstack/tempest-lib/src/branch/master/tempest_lib/common/rest_client.py#L764","commit_id":"3933225d834a262e863056f66b0607db5d25c974"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"b46c107429b4b029fd44867d0cd1fbe69f9f880d","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":294,"context_line":"        LOG.info(\u0027Unexpected response code\u0027)"},{"line_number":295,"context_line":"        self.assertRaises("},{"line_number":296,"context_line":"            lib_exc.UnexpectedResponseCode,"},{"line_number":297,"context_line":"            self.client.show_exported_zonefile,"},{"line_number":298,"context_line":"            zone_export[\u0027id\u0027],"},{"line_number":299,"context_line":"            headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"}],"source_content_type":"text/x-python","patch_set":18,"id":"e8c14e4f_0d4209a3","line":296,"in_reply_to":"1536fef1_0ff262fa","updated":"2022-02-01 11:50:15.000000000","message":"Done","commit_id":"3933225d834a262e863056f66b0607db5d25c974"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ded6d74982c995cb6ee91fd261746a1efa0af8a4","unresolved":true,"context_lines":[{"line_number":291,"context_line":"    @decorators.idempotent_id(\u002752a1fee0-c338-4ed9-b9f9-41ee7fd73375\u0027)"},{"line_number":292,"context_line":"    def test_show_zonefile_not_supported_accept_value(self):"},{"line_number":293,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":294,"context_line":"        try:"},{"line_number":295,"context_line":"            resp_header, resp_body \u003d self.client.show_exported_zonefile("},{"line_number":296,"context_line":"                zone_export[\u0027id\u0027],"},{"line_number":297,"context_line":"                headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"}],"source_content_type":"text/x-python","patch_set":21,"id":"ae493d1a_7f7f2b44","line":294,"updated":"2022-02-23 23:14:45.000000000","message":"This try/except block isn\u0027t needed. You can remove it and move the two assertEqual up.\n            self.assertEqual(406, resp.status,\n                             \"Failed, actual response code is:{0}\"\n                             \"but expected is: 406\"\n                             .format(resp.status))\n            self.assertEqual(\u0027Not Acceptable\u0027, resp.reason,\n                             \"Failed, actual response body received:{0}\"\n                             \"but expected is: Not Acceptable\"\n                             .format(resp.reason))","commit_id":"a160cf494f8050670372f812290793a4f7a471c4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"08aab65bbaacb36a7f6931b139639d2a3844894a","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    @decorators.idempotent_id(\u002752a1fee0-c338-4ed9-b9f9-41ee7fd73375\u0027)"},{"line_number":292,"context_line":"    def test_show_zonefile_not_supported_accept_value(self):"},{"line_number":293,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":294,"context_line":"        try:"},{"line_number":295,"context_line":"            resp_header, resp_body \u003d self.client.show_exported_zonefile("},{"line_number":296,"context_line":"                zone_export[\u0027id\u0027],"},{"line_number":297,"context_line":"                headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff67572e_4ac93cfc","line":294,"in_reply_to":"4e005d50_281c9a64","updated":"2022-02-25 00:17:38.000000000","message":"I posted a patch with what I was thinking. It is more consistent with other tests, such as test_tld.py. I also removed the check for the \"reason\" field as \"Not Acceptable\" is just a string table lookup for 406 in the library (i.e. does not come from Designate), so it\u0027s really a redundant test with the check for 406.","commit_id":"a160cf494f8050670372f812290793a4f7a471c4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"ee14921d39d47ae3bb435571217d72bf060d78c7","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    @decorators.idempotent_id(\u002752a1fee0-c338-4ed9-b9f9-41ee7fd73375\u0027)"},{"line_number":292,"context_line":"    def test_show_zonefile_not_supported_accept_value(self):"},{"line_number":293,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":294,"context_line":"        try:"},{"line_number":295,"context_line":"            resp_header, resp_body \u003d self.client.show_exported_zonefile("},{"line_number":296,"context_line":"                zone_export[\u0027id\u0027],"},{"line_number":297,"context_line":"                headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"}],"source_content_type":"text/x-python","patch_set":21,"id":"4e005d50_281c9a64","line":294,"in_reply_to":"ae493d1a_7f7f2b44","updated":"2022-02-24 12:26:17.000000000","message":"Hi Michael,\n\nI have 2 options to do the test for zone_export with image/jpeg in the header:\n1) to put the \"show_export_zonefile\" into the assertion (However, I don\u0027t know exactly which assertion I need).\n2) to use try/except and in the except use \"assertEqual\" to compare the \"resp.status\" to \"406\" and the \"resp.reason\" to \"NotAcceptable\".\n\nAnything else gives me an error.\nHowever, if I change it, it fails even before doing the test, because I need to wrap it with Try.","commit_id":"a160cf494f8050670372f812290793a4f7a471c4"}],"designate_tempest_plugin/tests/scenario/v2/test_zones_export.py":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9e13c282ef31da6b3286bef2b2c70766458e9e8b","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ZonesExportTest(BaseZoneExportsTest):"},{"line_number":30,"context_line":"    credentials \u003d [\"primary\", \"admin\", \"system_admin\", \"alt\"]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":11,"id":"fc4f72a2_20379d84","line":30,"range":{"start_line":30,"start_character":56,"end_line":30,"end_character":59},"updated":"2022-01-06 15:42:23.000000000","message":"Alt is not in use, so we can remove it from credentials list.","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ZonesExportTest(BaseZoneExportsTest):"},{"line_number":30,"context_line":"    credentials \u003d [\"primary\", \"admin\", \"system_admin\", \"alt\"]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":11,"id":"63444d9e_53decd12","line":30,"range":{"start_line":30,"start_character":56,"end_line":30,"end_character":59},"in_reply_to":"30b7ffa1_3e950d58","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9eef5e29fca6854bb4d80b05f74462d7bd9be59f","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ZonesExportTest(BaseZoneExportsTest):"},{"line_number":30,"context_line":"    credentials \u003d [\"primary\", \"admin\", \"system_admin\", \"alt\"]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":11,"id":"30b7ffa1_3e950d58","line":30,"range":{"start_line":30,"start_character":56,"end_line":30,"end_character":59},"in_reply_to":"fc4f72a2_20379d84","updated":"2022-01-07 23:55:19.000000000","message":"+1","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9e13c282ef31da6b3286bef2b2c70766458e9e8b","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    def test_create_zone_export_and_show_exported_zonefile(self):"},{"line_number":63,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self.assertEqual(\u0027PENDING\u0027, zone_export[\u0027status\u0027])"},{"line_number":66,"context_line":"        self.assertEqual(zone[\u0027id\u0027], zone_export[\u0027zone_id\u0027])"},{"line_number":67,"context_line":"        self.assertIsNone(zone_export[\u0027links\u0027].get(\u0027export\u0027))"},{"line_number":68,"context_line":"        self.assertIsNone(zone_export[\u0027location\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"a2d4d6f0_e1b271ae","line":65,"range":{"start_line":65,"start_character":26,"end_line":65,"end_character":33},"updated":"2022-01-06 15:42:23.000000000","message":"Not related to your patch, but some refactoring would be great here to replace all stuff like: \u0027ACTIVE\u0027, \u0027COMPLETE\u0027 ... e.t.c. to const.ACTIVE const.COMPLETE and so on.\nPlease do :-)","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def test_create_zone_export_and_show_exported_zonefile(self):"},{"line_number":63,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self.assertEqual(\u0027PENDING\u0027, zone_export[\u0027status\u0027])"},{"line_number":66,"context_line":"        self.assertEqual(zone[\u0027id\u0027], zone_export[\u0027zone_id\u0027])"},{"line_number":67,"context_line":"        self.assertIsNone(zone_export[\u0027links\u0027].get(\u0027export\u0027))"},{"line_number":68,"context_line":"        self.assertIsNone(zone_export[\u0027location\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"c78455ee_a44e5959","line":65,"range":{"start_line":65,"start_character":26,"end_line":65,"end_character":33},"in_reply_to":"a2d4d6f0_e1b271ae","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9e13c282ef31da6b3286bef2b2c70766458e9e8b","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        LOG.info(\u0027Check the zone export looks good\u0027)"},{"line_number":71,"context_line":"        _, zone_export \u003d self.client.show_zone_export(zone_export[\u0027id\u0027])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        self.assertEqual(\u0027COMPLETE\u0027, zone_export[\u0027status\u0027])"},{"line_number":74,"context_line":"        self.assertEqual(zone[\u0027id\u0027], zone_export[\u0027zone_id\u0027])"},{"line_number":75,"context_line":"        self.assertIsNotNone(zone_export[\u0027links\u0027].get(\u0027export\u0027))"},{"line_number":76,"context_line":"        self.assertIsNotNone(zone_export[\u0027location\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"72bc2763_cd43f2b3","line":73,"range":{"start_line":73,"start_character":26,"end_line":73,"end_character":34},"updated":"2022-01-06 15:42:23.000000000","message":"Same as in L65","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        LOG.info(\u0027Check the zone export looks good\u0027)"},{"line_number":71,"context_line":"        _, zone_export \u003d self.client.show_zone_export(zone_export[\u0027id\u0027])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        self.assertEqual(\u0027COMPLETE\u0027, zone_export[\u0027status\u0027])"},{"line_number":74,"context_line":"        self.assertEqual(zone[\u0027id\u0027], zone_export[\u0027zone_id\u0027])"},{"line_number":75,"context_line":"        self.assertIsNotNone(zone_export[\u0027links\u0027].get(\u0027export\u0027))"},{"line_number":76,"context_line":"        self.assertIsNotNone(zone_export[\u0027location\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"2c2a0c45_dff67642","line":73,"range":{"start_line":73,"start_character":26,"end_line":73,"end_character":34},"in_reply_to":"72bc2763_cd43f2b3","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9e13c282ef31da6b3286bef2b2c70766458e9e8b","unresolved":true,"context_lines":[{"line_number":99,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{"},{"line_number":100,"context_line":"                \u0027x-auth-all-projects\u0027: \u0027True\u0027"},{"line_number":101,"context_line":"            })"},{"line_number":102,"context_line":"        LOG.info(\u0027Ensure status 200 OK\u0027)"},{"line_number":103,"context_line":"        self.assertEqual(\u0027200\u0027, resp_headers[\u0027status\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"},{"line_number":106,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], resp_data.ttl)"}],"source_content_type":"text/x-python","patch_set":11,"id":"0eb4b841_1817b608","line":103,"range":{"start_line":102,"start_character":0,"end_line":103,"end_character":55},"updated":"2022-01-06 15:42:23.000000000","message":"This is not the place to validate 200 OK, such a validations needed to be done on client itself, for example: https://github.com/openstack/designate-tempest-plugin/blob/master/designate_tempest_plugin/services/dns/v2/json/zone_exports_client.py#L98","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9eef5e29fca6854bb4d80b05f74462d7bd9be59f","unresolved":true,"context_lines":[{"line_number":99,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{"},{"line_number":100,"context_line":"                \u0027x-auth-all-projects\u0027: \u0027True\u0027"},{"line_number":101,"context_line":"            })"},{"line_number":102,"context_line":"        LOG.info(\u0027Ensure status 200 OK\u0027)"},{"line_number":103,"context_line":"        self.assertEqual(\u0027200\u0027, resp_headers[\u0027status\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"},{"line_number":106,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], resp_data.ttl)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1fe8d474_b8f9c243","line":103,"range":{"start_line":102,"start_character":0,"end_line":103,"end_character":55},"in_reply_to":"0eb4b841_1817b608","updated":"2022-01-07 23:55:19.000000000","message":"No necessarily. There are cases where 404 is expected from a show_exported_zonefile() call. So, you could either extend the parameters for show_exported_zonefile() to include expected_status \u003d 200, or do what Lilach did here.\nI don\u0027t have a problem with this check.","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{"},{"line_number":100,"context_line":"                \u0027x-auth-all-projects\u0027: \u0027True\u0027"},{"line_number":101,"context_line":"            })"},{"line_number":102,"context_line":"        LOG.info(\u0027Ensure status 200 OK\u0027)"},{"line_number":103,"context_line":"        self.assertEqual(\u0027200\u0027, resp_headers[\u0027status\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"},{"line_number":106,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], resp_data.ttl)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ad081b74_5469141b","line":103,"range":{"start_line":102,"start_character":0,"end_line":103,"end_character":55},"in_reply_to":"1fe8d474_b8f9c243","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9e13c282ef31da6b3286bef2b2c70766458e9e8b","unresolved":true,"context_lines":[{"line_number":111,"context_line":"        resp_headers, resp_data \u003d self.client.show_exported_zonefile("},{"line_number":112,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{\u0027Accept\u0027: \u0027*/*\u0027})"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        LOG.info(\u0027Ensure 200 OK and Content-Type: text/dns\u0027)"},{"line_number":115,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027])"},{"line_number":116,"context_line":"        self.assertEqual(\u0027200\u0027, resp_headers[\u0027status\u0027])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"},{"line_number":119,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7bb2a5d1_1291f0ea","line":116,"range":{"start_line":114,"start_character":0,"end_line":116,"end_character":55},"updated":"2022-01-06 15:42:23.000000000","message":"Remove 200 OK related stuff, after modifying client according to my comment in L103","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        resp_headers, resp_data \u003d self.client.show_exported_zonefile("},{"line_number":112,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{\u0027Accept\u0027: \u0027*/*\u0027})"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        LOG.info(\u0027Ensure 200 OK and Content-Type: text/dns\u0027)"},{"line_number":115,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027])"},{"line_number":116,"context_line":"        self.assertEqual(\u0027200\u0027, resp_headers[\u0027status\u0027])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"},{"line_number":119,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1b1d9d55_daa15ed8","line":116,"range":{"start_line":114,"start_character":0,"end_line":116,"end_character":55},"in_reply_to":"7bb2a5d1_1291f0ea","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9e13c282ef31da6b3286bef2b2c70766458e9e8b","unresolved":true,"context_lines":[{"line_number":124,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":125,"context_line":"        resp_headers, resp_data \u003d self.client.show_exported_zonefile("},{"line_number":126,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{})"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        LOG.info(\u0027Ensure 200 OK and Content-Type: text/dns\u0027)"},{"line_number":129,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027])"},{"line_number":130,"context_line":"        self.assertEqual(\u0027200\u0027, resp_headers[\u0027status\u0027])"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"},{"line_number":133,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"}],"source_content_type":"text/x-python","patch_set":11,"id":"af29077b_fe292cc4","line":130,"range":{"start_line":127,"start_character":0,"end_line":130,"end_character":55},"updated":"2022-01-06 15:42:23.000000000","message":"Remove 200 OK related stuff, after modifying client according to my comment in L103","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":125,"context_line":"        resp_headers, resp_data \u003d self.client.show_exported_zonefile("},{"line_number":126,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{})"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        LOG.info(\u0027Ensure 200 OK and Content-Type: text/dns\u0027)"},{"line_number":129,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027])"},{"line_number":130,"context_line":"        self.assertEqual(\u0027200\u0027, resp_headers[\u0027status\u0027])"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"},{"line_number":133,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a7acdf6_d50d2193","line":130,"range":{"start_line":127,"start_character":0,"end_line":130,"end_character":55},"in_reply_to":"af29077b_fe292cc4","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9e13c282ef31da6b3286bef2b2c70766458e9e8b","unresolved":true,"context_lines":[{"line_number":165,"context_line":"    @decorators.idempotent_id(\u00279a878646-f66b-4fa4-ae95-f3ac3f8e3d31\u0027)"},{"line_number":166,"context_line":"    def test_show_zonefile_using_not_existing_zone_export_id(self):"},{"line_number":167,"context_line":"        LOG.info(\u0027Expected: 404 Not Found zone export\u0027)"},{"line_number":168,"context_line":"        e \u003d self.assertRaises("},{"line_number":169,"context_line":"            lib_exc.NotFound,"},{"line_number":170,"context_line":"            self.client.show_zone_export,"},{"line_number":171,"context_line":"            data_utils.rand_uuid())"},{"line_number":172,"context_line":"        self.assertEqual("},{"line_number":173,"context_line":"            404, e.resp_body[\u0027code\u0027],"},{"line_number":174,"context_line":"            \u0027Failed, zone export exists\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @decorators.idempotent_id(\u002752a1fee0-c338-4ed9-b9f9-41ee7fd73375\u0027)"},{"line_number":177,"context_line":"    def test_show_zonefile_not_supported_accept_value(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"2001e938_c05236e3","line":174,"range":{"start_line":168,"start_character":0,"end_line":174,"end_character":41},"updated":"2022-01-06 15:42:23.000000000","message":"All this could be done with a single line, please check the existing examples for 404 not found  and do the same here.","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    @decorators.idempotent_id(\u00279a878646-f66b-4fa4-ae95-f3ac3f8e3d31\u0027)"},{"line_number":166,"context_line":"    def test_show_zonefile_using_not_existing_zone_export_id(self):"},{"line_number":167,"context_line":"        LOG.info(\u0027Expected: 404 Not Found zone export\u0027)"},{"line_number":168,"context_line":"        e \u003d self.assertRaises("},{"line_number":169,"context_line":"            lib_exc.NotFound,"},{"line_number":170,"context_line":"            self.client.show_zone_export,"},{"line_number":171,"context_line":"            data_utils.rand_uuid())"},{"line_number":172,"context_line":"        self.assertEqual("},{"line_number":173,"context_line":"            404, e.resp_body[\u0027code\u0027],"},{"line_number":174,"context_line":"            \u0027Failed, zone export exists\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @decorators.idempotent_id(\u002752a1fee0-c338-4ed9-b9f9-41ee7fd73375\u0027)"},{"line_number":177,"context_line":"    def test_show_zonefile_not_supported_accept_value(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"6ab68c7d_b429968f","line":174,"range":{"start_line":168,"start_character":0,"end_line":174,"end_character":41},"in_reply_to":"2001e938_c05236e3","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9e13c282ef31da6b3286bef2b2c70766458e9e8b","unresolved":true,"context_lines":[{"line_number":174,"context_line":"            \u0027Failed, zone export exists\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @decorators.idempotent_id(\u002752a1fee0-c338-4ed9-b9f9-41ee7fd73375\u0027)"},{"line_number":177,"context_line":"    def test_show_zonefile_not_supported_accept_value(self):"},{"line_number":178,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            self.client.show_exported_zonefile("},{"line_number":182,"context_line":"                zone_export[\u0027id\u0027],"},{"line_number":183,"context_line":"                headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"},{"line_number":184,"context_line":"        except Exception as err:"},{"line_number":185,"context_line":"            LOG.info(\u0027Expected: 406 Unexpected response code received \u0027)"},{"line_number":186,"context_line":"            self.assertEqual("},{"line_number":187,"context_line":"                \u0027406\u0027, err.resp_body,"},{"line_number":188,"context_line":"                \u0027Failed, response code should be received error 406\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bd100ed7_c0f9eaeb","line":188,"range":{"start_line":177,"start_character":0,"end_line":188,"end_character":69},"updated":"2022-01-06 15:42:23.000000000","message":"We need 2 assertions here:\n1) assertion for 406\n2) assertion for error message itself: The resource could not be generated that was acceptable to your browser (content of type image/jpeg. \\n\\n \n\n2 - is not covered in this test.","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"36a1e9c05d09c96f0f2b851c07ecfdf2d6fb0935","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            \u0027Failed, zone export exists\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @decorators.idempotent_id(\u002752a1fee0-c338-4ed9-b9f9-41ee7fd73375\u0027)"},{"line_number":177,"context_line":"    def test_show_zonefile_not_supported_accept_value(self):"},{"line_number":178,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            self.client.show_exported_zonefile("},{"line_number":182,"context_line":"                zone_export[\u0027id\u0027],"},{"line_number":183,"context_line":"                headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027})"},{"line_number":184,"context_line":"        except Exception as err:"},{"line_number":185,"context_line":"            LOG.info(\u0027Expected: 406 Unexpected response code received \u0027)"},{"line_number":186,"context_line":"            self.assertEqual("},{"line_number":187,"context_line":"                \u0027406\u0027, err.resp_body,"},{"line_number":188,"context_line":"                \u0027Failed, response code should be received error 406\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"65303788_d49a6150","line":188,"range":{"start_line":177,"start_character":0,"end_line":188,"end_character":69},"in_reply_to":"bd100ed7_c0f9eaeb","updated":"2022-01-09 17:47:30.000000000","message":"Done","commit_id":"73a4e6961922bbaa073efc99bedd53c365c8c736"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"928cd5790d710cf10f8767761a4a0385dcf230e0","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{\u0027Accept\u0027: \u0027*/*\u0027})"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        LOG.info(\u0027Ensure Content-Type: text/dns\u0027)"},{"line_number":113,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027])"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"},{"line_number":116,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"}],"source_content_type":"text/x-python","patch_set":12,"id":"b6662b30_76a2a004","line":113,"updated":"2022-01-09 18:47:21.000000000","message":"What about adding the assertion message as we\u0027ve already agreed?","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{\u0027Accept\u0027: \u0027*/*\u0027})"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        LOG.info(\u0027Ensure Content-Type: text/dns\u0027)"},{"line_number":113,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027])"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"},{"line_number":116,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"}],"source_content_type":"text/x-python","patch_set":12,"id":"749ca6c1_26ee509d","line":113,"in_reply_to":"b6662b30_76a2a004","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"928cd5790d710cf10f8767761a4a0385dcf230e0","unresolved":true,"context_lines":[{"line_number":123,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{})"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        LOG.info(\u0027Ensure Content-Type: text/dns\u0027)"},{"line_number":126,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027])"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"},{"line_number":129,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dc37a2e7_aebf1413","line":126,"updated":"2022-01-09 18:47:21.000000000","message":"Same as in L113","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{})"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        LOG.info(\u0027Ensure Content-Type: text/dns\u0027)"},{"line_number":126,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027])"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"},{"line_number":129,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"}],"source_content_type":"text/x-python","patch_set":12,"id":"e1edb0df_3826687e","line":126,"in_reply_to":"dc37a2e7_aebf1413","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"928cd5790d710cf10f8767761a4a0385dcf230e0","unresolved":true,"context_lines":[{"line_number":159,"context_line":"        return zone, zone_export"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @decorators.idempotent_id(\u00279a878646-f66b-4fa4-ae95-f3ac3f8e3d31\u0027)"},{"line_number":162,"context_line":"    def test_show_zonefile_using_not_existing_zone_export_id(self):"},{"line_number":163,"context_line":"        LOG.info(\u0027Expected: 404 Not Found zone export\u0027)"},{"line_number":164,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":165,"context_line":"                          lambda: self.client.show_zone_export("}],"source_content_type":"text/x-python","patch_set":12,"id":"163ad96e_0161714c","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":2},"updated":"2022-01-09 18:47:21.000000000","message":"Do we expect export file to be created within this test? Why it\u0027s a scenario test?","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        return zone, zone_export"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @decorators.idempotent_id(\u00279a878646-f66b-4fa4-ae95-f3ac3f8e3d31\u0027)"},{"line_number":162,"context_line":"    def test_show_zonefile_using_not_existing_zone_export_id(self):"},{"line_number":163,"context_line":"        LOG.info(\u0027Expected: 404 Not Found zone export\u0027)"},{"line_number":164,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":165,"context_line":"                          lambda: self.client.show_zone_export("}],"source_content_type":"text/x-python","patch_set":12,"id":"d4403ded_8ec0483c","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":2},"in_reply_to":"163ad96e_0161714c","updated":"2022-01-18 11:44:34.000000000","message":"No, There is a mistake here, I need to show zonefile exported with random zone export ID and not to show zone export .","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"928cd5790d710cf10f8767761a4a0385dcf230e0","unresolved":true,"context_lines":[{"line_number":166,"context_line":"                              data_utils.rand_uuid()))"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    @decorators.idempotent_id(\u002752a1fee0-c338-4ed9-b9f9-41ee7fd73375\u0027)"},{"line_number":169,"context_line":"    def test_show_zonefile_not_supported_accept_value(self):"},{"line_number":170,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        LOG.info(\u0027Expected: 406 Unexpected response code received \u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"52ac7133_398c82c7","line":169,"range":{"start_line":169,"start_character":8,"end_line":169,"end_character":53},"updated":"2022-01-09 18:47:21.000000000","message":"Same as in L162","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                              data_utils.rand_uuid()))"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    @decorators.idempotent_id(\u002752a1fee0-c338-4ed9-b9f9-41ee7fd73375\u0027)"},{"line_number":169,"context_line":"    def test_show_zonefile_not_supported_accept_value(self):"},{"line_number":170,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        LOG.info(\u0027Expected: 406 Unexpected response code received \u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"983e69ea_2bf51b71","line":169,"range":{"start_line":169,"start_character":8,"end_line":169,"end_character":53},"in_reply_to":"52ac7133_398c82c7","updated":"2022-01-18 11:44:34.000000000","message":"We need to create zone export and after that we try to see the file with unsupported accept value","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"928cd5790d710cf10f8767761a4a0385dcf230e0","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        LOG.info(\u0027Expected: 406 Unexpected response code received \u0027)"},{"line_number":173,"context_line":"        self.assertRaises(lib_exc.UnexpectedResponseCode,"},{"line_number":174,"context_line":"                          lambda: self.client.show_exported_zonefile("},{"line_number":175,"context_line":"                              zone_export[\u0027id\u0027],"},{"line_number":176,"context_line":"                              headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027}))"}],"source_content_type":"text/x-python","patch_set":12,"id":"396465a6_d44b1ade","line":173,"updated":"2022-01-09 18:47:21.000000000","message":"Unlike 404 in previous test this one doesn\u0027t catch the 406 status code.\nFrom tempest code:\n\nFor 404 we have:\nclass NotFound(ClientRestClientException):\n    status_code \u003d 404\n    message \u003d \"Object not found\"\n\nIn you case we don\u0027t have 406 (It\u0027s seems to be something generic)\nclass UnexpectedResponseCode(OtherRestClientException):\n    message \u003d \"Unexpected response code received\"\n\nWe need to improve this test by adding:\n1) Assertion for 406 status\n2) Assertion for \"Not Acceptable\"\n3) Assertion for \"The resource could not be generated that was acceptable to your browser (content of type image/jpeg\"\n\nNote: if 3 is not doable, I\u0027m OK with 1 and 2 only.\n\n\nThis is the error we see in console:\nBody: b\u0027406 Not Acceptable\\n\\nThe resource could not be generated that was acceptable to your browser (content of type image/jpeg. \\n\\n \u0027 _log_request_full /opt/stack/tempest/tempest/lib/common/rest_client.py:450.","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        LOG.info(\u0027Expected: 406 Unexpected response code received \u0027)"},{"line_number":173,"context_line":"        self.assertRaises(lib_exc.UnexpectedResponseCode,"},{"line_number":174,"context_line":"                          lambda: self.client.show_exported_zonefile("},{"line_number":175,"context_line":"                              zone_export[\u0027id\u0027],"},{"line_number":176,"context_line":"                              headers\u003d{\u0027Accept\u0027: \u0027image/jpeg\u0027}))"}],"source_content_type":"text/x-python","patch_set":12,"id":"992817b8_3b11b9e0","line":173,"in_reply_to":"396465a6_d44b1ade","updated":"2022-01-18 11:44:34.000000000","message":"We talked about it.","commit_id":"173e4565076e5ac402d4ae67e6070f79764e61e3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d090eb63a127e09ee097521383f91418d06e8a66","unresolved":true,"context_lines":[{"line_number":163,"context_line":"    def test_show_zonefile_using_not_existing_zone_export_id(self):"},{"line_number":164,"context_line":"        LOG.info(\u0027Expected: 404 Not Found zone export\u0027)"},{"line_number":165,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":166,"context_line":"                          lambda: self.client.show_exported_zonefile("},{"line_number":167,"context_line":"                              data_utils.rand_uuid()))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    @decorators.idempotent_id(\u002752a1fee0-c338-4ed9-b9f9-41ee7fd73375\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"cf74c120_c606d709","line":166,"range":{"start_line":166,"start_character":26,"end_line":166,"end_character":33},"updated":"2022-01-10 21:22:22.000000000","message":"This lambda isn\u0027t really needed here.\n\n self.assertRaises(lib_exc.NotFound,                     \n                self.client.show_exported_zonefile, data_utils.rand_uuid())\n\nhttps://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRaises","commit_id":"0d4de19ab4ed7b0d919fa8382f7184dd0bcf07b8"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    def test_show_zonefile_using_not_existing_zone_export_id(self):"},{"line_number":164,"context_line":"        LOG.info(\u0027Expected: 404 Not Found zone export\u0027)"},{"line_number":165,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":166,"context_line":"                          lambda: self.client.show_exported_zonefile("},{"line_number":167,"context_line":"                              data_utils.rand_uuid()))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    @decorators.idempotent_id(\u002752a1fee0-c338-4ed9-b9f9-41ee7fd73375\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3cef1a8f_fd27d66e","line":166,"range":{"start_line":166,"start_character":26,"end_line":166,"end_character":33},"in_reply_to":"cf74c120_c606d709","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"0d4de19ab4ed7b0d919fa8382f7184dd0bcf07b8"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            self.client, zone_export[\u0027id\u0027], const.COMPLETE)"},{"line_number":56,"context_line":"        return zone, zone_export"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u00270484c3c4-df57-458e-a6e5-6eb63e0475e0\u0027)"},{"line_number":60,"context_line":"    def test_create_zone_export_and_show_exported_zonefile(self):"},{"line_number":61,"context_line":"        zone, zone_export \u003d self._create_zone_export()"}],"source_content_type":"text/x-python","patch_set":14,"id":"49d42192_d3b8309e","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":33},"updated":"2022-01-16 20:45:48.000000000","message":"Any reason for having \"slow\" decorator?\nCould you check the execution time of this test.","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            self.client, zone_export[\u0027id\u0027], const.COMPLETE)"},{"line_number":56,"context_line":"        return zone, zone_export"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u00270484c3c4-df57-458e-a6e5-6eb63e0475e0\u0027)"},{"line_number":60,"context_line":"    def test_create_zone_export_and_show_exported_zonefile(self):"},{"line_number":61,"context_line":"        zone, zone_export \u003d self._create_zone_export()"}],"source_content_type":"text/x-python","patch_set":14,"id":"56613eb9_dd51b8f6","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":33},"in_reply_to":"49d42192_d3b8309e","updated":"2022-01-18 11:44:34.000000000","message":"Removed.\nThe test run time is : 0.018418410999999968 sec","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":96,"context_line":"        resp_headers, resp_data \u003d self.admin_client.show_exported_zonefile("},{"line_number":97,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{"},{"line_number":98,"context_line":"                \u0027x-auth-all-projects\u0027: \u0027True\u0027"},{"line_number":99,"context_line":"            })"},{"line_number":100,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"},{"line_number":101,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], resp_data.ttl)"}],"source_content_type":"text/x-python","patch_set":14,"id":"768aee10_937b770c","line":98,"updated":"2022-01-16 20:45:48.000000000","message":"Failed, the expected \"Content-Type: text/dns\" wasn\u0027t received.","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":96,"context_line":"        resp_headers, resp_data \u003d self.admin_client.show_exported_zonefile("},{"line_number":97,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{"},{"line_number":98,"context_line":"                \u0027x-auth-all-projects\u0027: \u0027True\u0027"},{"line_number":99,"context_line":"            })"},{"line_number":100,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"},{"line_number":101,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], resp_data.ttl)"}],"source_content_type":"text/x-python","patch_set":14,"id":"dbd1be22_7f8cfa64","line":98,"range":{"start_line":98,"start_character":40,"end_line":98,"end_character":44},"updated":"2022-01-16 20:45:48.000000000","message":"This can be supplied as boolean.","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":96,"context_line":"        resp_headers, resp_data \u003d self.admin_client.show_exported_zonefile("},{"line_number":97,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{"},{"line_number":98,"context_line":"                \u0027x-auth-all-projects\u0027: \u0027True\u0027"},{"line_number":99,"context_line":"            })"},{"line_number":100,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"},{"line_number":101,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], resp_data.ttl)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ec774486_f5a89379","line":98,"in_reply_to":"768aee10_937b770c","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        zone, zone_export \u003d self._create_zone_export()"},{"line_number":96,"context_line":"        resp_headers, resp_data \u003d self.admin_client.show_exported_zonefile("},{"line_number":97,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{"},{"line_number":98,"context_line":"                \u0027x-auth-all-projects\u0027: \u0027True\u0027"},{"line_number":99,"context_line":"            })"},{"line_number":100,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"},{"line_number":101,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], resp_data.ttl)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1db49cfa_3e5ae540","line":98,"range":{"start_line":98,"start_character":40,"end_line":98,"end_character":44},"in_reply_to":"dbd1be22_7f8cfa64","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        LOG.info(\u0027Ensure Content-Type: text/dns\u0027)"},{"line_number":110,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027],"},{"line_number":111,"context_line":"                      \"Content-Type: text/dns didn\u0027t send\")"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"},{"line_number":114,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a569085_3639044f","line":111,"range":{"start_line":111,"start_character":22,"end_line":111,"end_character":59},"updated":"2022-01-16 20:45:48.000000000","message":"Failed, the expected \"Content-Type: text/dns\" wasn\u0027t received.","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        LOG.info(\u0027Ensure Content-Type: text/dns\u0027)"},{"line_number":110,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027],"},{"line_number":111,"context_line":"                      \"Content-Type: text/dns didn\u0027t send\")"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"},{"line_number":114,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"}],"source_content_type":"text/x-python","patch_set":14,"id":"87eb7812_96f58892","line":111,"range":{"start_line":111,"start_character":22,"end_line":111,"end_character":59},"in_reply_to":"7a569085_3639044f","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1831e6af693efc8c49227272167c814eaabf2257","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{})"},{"line_number":122,"context_line":"        LOG.info(\u0027Ensure Content-Type: text/dns\u0027)"},{"line_number":123,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027],"},{"line_number":124,"context_line":"                      \"Content-Type: text/dns didn\u0027t send\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"},{"line_number":127,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"}],"source_content_type":"text/x-python","patch_set":14,"id":"65895e00_576ef29f","line":124,"range":{"start_line":124,"start_character":23,"end_line":124,"end_character":57},"updated":"2022-01-16 20:45:48.000000000","message":"Failed, the expected \"Content-Type: text/dns\" wasn\u0027t received.","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{})"},{"line_number":122,"context_line":"        LOG.info(\u0027Ensure Content-Type: text/dns\u0027)"},{"line_number":123,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027],"},{"line_number":124,"context_line":"                      \"Content-Type: text/dns didn\u0027t send\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"},{"line_number":127,"context_line":"        self.assertEqual(zone[\u0027name\u0027], resp_data.origin)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fffd927f_0ad321de","line":124,"range":{"start_line":124,"start_character":23,"end_line":124,"end_character":57},"in_reply_to":"65895e00_576ef29f","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"dfc10df6c791f7d5c82a1a3b9306aa3285952df4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"47344a4a70c5c64fdc23b1521dd547c7ca5dee32","unresolved":true,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        LOG.info(\u0027Ensure Content-Type: text/dns\u0027)"},{"line_number":109,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027],"},{"line_number":110,"context_line":"                      \"Failed,\""},{"line_number":111,"context_line":"                      \"the expected \u0027Content-type:text/dns wasn\u0027t received.\")"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3431e3df_1bf755a7","line":110,"range":{"start_line":110,"start_character":23,"end_line":110,"end_character":29},"updated":"2022-01-17 18:48:33.000000000","message":"Nit\n\nJust about the visibility, this option would be better I think:\n\n        LOG.info(\u0027Ensure Content-Type: text/dns\u0027)\n        self.assertIn(\n            \u0027text/dns\u0027, resp_headers[\u0027content-type\u0027],\n            \"Failed, the expected \u0027Content-type:text/dns wasn\u0027t received.\")","commit_id":"affbe3fc7bba3a6c85674b76887e22b6dd9e0b41"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        LOG.info(\u0027Ensure Content-Type: text/dns\u0027)"},{"line_number":109,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027],"},{"line_number":110,"context_line":"                      \"Failed,\""},{"line_number":111,"context_line":"                      \"the expected \u0027Content-type:text/dns wasn\u0027t received.\")"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"30da46b1_f29f924d","line":110,"range":{"start_line":110,"start_character":23,"end_line":110,"end_character":29},"in_reply_to":"3431e3df_1bf755a7","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"affbe3fc7bba3a6c85674b76887e22b6dd9e0b41"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"47344a4a70c5c64fdc23b1521dd547c7ca5dee32","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{})"},{"line_number":122,"context_line":"        LOG.info(\u0027Ensure Content-Type: text/dns\u0027)"},{"line_number":123,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027],"},{"line_number":124,"context_line":"                      \"Failed,\""},{"line_number":125,"context_line":"                      \"the expected \u0027Content-type:text/dns wasn\u0027t received.\")"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7ee75230_54b9270d","line":124,"range":{"start_line":124,"start_character":23,"end_line":124,"end_character":29},"updated":"2022-01-17 18:48:33.000000000","message":"Same as in L110","commit_id":"affbe3fc7bba3a6c85674b76887e22b6dd9e0b41"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"5a2a6e88dbb3e9ce9d1dba181b8d50012677515b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            zone_export[\u0027id\u0027], headers\u003d{})"},{"line_number":122,"context_line":"        LOG.info(\u0027Ensure Content-Type: text/dns\u0027)"},{"line_number":123,"context_line":"        self.assertIn(\u0027text/dns\u0027, resp_headers[\u0027content-type\u0027],"},{"line_number":124,"context_line":"                      \"Failed,\""},{"line_number":125,"context_line":"                      \"the expected \u0027Content-type:text/dns wasn\u0027t received.\")"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        LOG.info(\u0027Ensure exported data ia as expected\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"8a760cfd_4bc98679","line":124,"range":{"start_line":124,"start_character":23,"end_line":124,"end_character":29},"in_reply_to":"7ee75230_54b9270d","updated":"2022-01-18 11:44:34.000000000","message":"Done","commit_id":"affbe3fc7bba3a6c85674b76887e22b6dd9e0b41"}]}