)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"dd0dd9b8e8a13d41a7271ff83d7529503ae89d81","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Arkady Shtempler \u003carkadysh@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-06 14:34:14 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Import zone API cahnges: some refactoring and new test case"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) Client\u0027s \"create_zone_import\" had to be imroved."},{"line_number":10,"context_line":"2) Refactoring the existing tests by adding \"wait_until\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6400e51d_7dbe94e3","line":7,"updated":"2022-02-01 23:27:28.000000000","message":"cahanges -\u003e changes","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"dd0dd9b8e8a13d41a7271ff83d7529503ae89d81","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Import zone API cahnges: some refactoring and new test case"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) Client\u0027s \"create_zone_import\" had to be imroved."},{"line_number":10,"context_line":"2) Refactoring the existing tests by adding \"wait_until\""},{"line_number":11,"context_line":"   that wasn\u0027t in use."},{"line_number":12,"context_line":"3) \"test_create_zone_import_invalid_content_type\" to test"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fcfe6b4_5aeca9b0","line":9,"updated":"2022-02-01 23:27:28.000000000","message":"imrorved -\u003e improved","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"74f8e2c2991e3f0acc876c4fbd554c5b214086ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b4119fe7_f3d99c40","updated":"2022-02-02 00:20:49.000000000","message":"I have a few questions here.","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"955d6d3a6f23406f8a4ec9a556f9301d843e1a75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b4fdb0e2_d06af055","updated":"2022-02-01 23:27:54.000000000","message":"Other than some spelling looks good.","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"c51abbdacc929f35b846e57922bfd31e31b6719a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fc1b8eaa_19942aa4","updated":"2022-02-01 23:28:44.000000000","message":"Other than some spelling looks good.","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"871a4821d96a9b7cda13ba0c72d4e68875bdb426","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55eb0c57_769a00d4","updated":"2022-01-06 14:48:24.000000000","message":"recheck","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ed5855142a2264f4af4bf2aa9bd50837fa6ad1fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"829b8c64_af6571bd","updated":"2022-03-02 01:27:16.000000000","message":"Sorry, one more thing on this one.","commit_id":"d722ce5c53ae5f0bb1bc5b00f2f4b8e7f326f8d4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"48b54fe131e35e9ae548593f77cc13bd1dc865d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0f156f08_8b119730","updated":"2022-02-03 08:08:27.000000000","message":"recheck","commit_id":"d722ce5c53ae5f0bb1bc5b00f2f4b8e7f326f8d4"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"7201631b39b35b65b473c8324cc80febf8b9d23b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"55cca133_c6a440ce","updated":"2022-03-18 18:28:37.000000000","message":"LGTM","commit_id":"c8c14b29da817f6112bbbba7e436ef496672762e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ee891ff5a7a32a047a6f06369f200297c441a70f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0b091fcd_b74795fe","updated":"2022-05-06 17:41:52.000000000","message":"This patch is highly duplicate with https://review.opendev.org/c/openstack/designate-tempest-plugin/+/832215\n\nCan we merge the two patches or stack them to eliminate the duplicate code changes?","commit_id":"c8c14b29da817f6112bbbba7e436ef496672762e"}],"designate_tempest_plugin/tests/api/v2/test_zones_imports.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"74f8e2c2991e3f0acc876c4fbd554c5b214086ba","unresolved":true,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class ZonesImportTestNegative(BaseZonesImportTest):"},{"line_number":195,"context_line":"    credentials \u003d [\"primary\", \"admin\", \"system_admin\", \"alt\"]"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    @classmethod"},{"line_number":198,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"cedde2fb_470fd8eb","line":195,"updated":"2022-02-02 00:20:49.000000000","message":"Do you really need all of these here? I looks like only primary is being used.","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"2d158a9550610a66ccf136a857420de260aad972","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class ZonesImportTestNegative(BaseZonesImportTest):"},{"line_number":195,"context_line":"    credentials \u003d [\"primary\", \"admin\", \"system_admin\", \"alt\"]"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    @classmethod"},{"line_number":198,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dcf95ab2_af5090d0","line":195,"in_reply_to":"cedde2fb_470fd8eb","updated":"2022-02-02 20:05:33.000000000","message":"Done","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"74f8e2c2991e3f0acc876c4fbd554c5b214086ba","unresolved":true,"context_lines":[{"line_number":205,"context_line":"        super(ZonesImportTestNegative, cls).setup_clients()"},{"line_number":206,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZoneImportsClient()"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def clean_up_resources(self, zone_import_id):"},{"line_number":209,"context_line":"        zone_import \u003d self.client.show_zone_import(zone_import_id)[1]"},{"line_number":210,"context_line":"        if zone_import[\u0027zone_id\u0027]:  # A zone was actually created."},{"line_number":211,"context_line":"            waiters.wait_for_zone_import_status("}],"source_content_type":"text/x-python","patch_set":1,"id":"0e569bc0_e9f91a4d","line":208,"range":{"start_line":208,"start_character":8,"end_line":208,"end_character":27},"updated":"2022-02-02 00:20:49.000000000","message":"This should be _clean_up_resources as it is a private method for this test class.","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"2d158a9550610a66ccf136a857420de260aad972","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        super(ZonesImportTestNegative, cls).setup_clients()"},{"line_number":206,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZoneImportsClient()"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def clean_up_resources(self, zone_import_id):"},{"line_number":209,"context_line":"        zone_import \u003d self.client.show_zone_import(zone_import_id)[1]"},{"line_number":210,"context_line":"        if zone_import[\u0027zone_id\u0027]:  # A zone was actually created."},{"line_number":211,"context_line":"            waiters.wait_for_zone_import_status("}],"source_content_type":"text/x-python","patch_set":1,"id":"1ec7ea52_39572d86","line":208,"range":{"start_line":208,"start_character":8,"end_line":208,"end_character":27},"in_reply_to":"0e569bc0_e9f91a4d","updated":"2022-02-02 20:05:33.000000000","message":"Done","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"74f8e2c2991e3f0acc876c4fbd554c5b214086ba","unresolved":true,"context_lines":[{"line_number":206,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZoneImportsClient()"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def clean_up_resources(self, zone_import_id):"},{"line_number":209,"context_line":"        zone_import \u003d self.client.show_zone_import(zone_import_id)[1]"},{"line_number":210,"context_line":"        if zone_import[\u0027zone_id\u0027]:  # A zone was actually created."},{"line_number":211,"context_line":"            waiters.wait_for_zone_import_status("},{"line_number":212,"context_line":"                self.client, zone_import_id, const.COMPLETE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9c15790b_ad43cebe","line":209,"updated":"2022-02-02 00:20:49.000000000","message":"Won\u0027t this raise a NotFound exception? I think InvalidContentType is also a possibility.","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"2d158a9550610a66ccf136a857420de260aad972","unresolved":true,"context_lines":[{"line_number":206,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZoneImportsClient()"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def clean_up_resources(self, zone_import_id):"},{"line_number":209,"context_line":"        zone_import \u003d self.client.show_zone_import(zone_import_id)[1]"},{"line_number":210,"context_line":"        if zone_import[\u0027zone_id\u0027]:  # A zone was actually created."},{"line_number":211,"context_line":"            waiters.wait_for_zone_import_status("},{"line_number":212,"context_line":"                self.client, zone_import_id, const.COMPLETE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d041fae8_b17e2475","line":209,"in_reply_to":"9c15790b_ad43cebe","updated":"2022-02-02 20:05:33.000000000","message":"Yes, I have to handle this situation.","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"74f8e2c2991e3f0acc876c4fbd554c5b214086ba","unresolved":true,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def clean_up_resources(self, zone_import_id):"},{"line_number":209,"context_line":"        zone_import \u003d self.client.show_zone_import(zone_import_id)[1]"},{"line_number":210,"context_line":"        if zone_import[\u0027zone_id\u0027]:  # A zone was actually created."},{"line_number":211,"context_line":"            waiters.wait_for_zone_import_status("},{"line_number":212,"context_line":"                self.client, zone_import_id, const.COMPLETE)"},{"line_number":213,"context_line":"            self.client.delete_zone_import(zone_import[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"b2064a19_db896d7d","line":210,"updated":"2022-02-02 00:20:49.000000000","message":"zone_import can be \"None\", so this would raise a KeyError instead of going to the else conditional right?\nhttps://github.com/openstack/designate-tempest-plugin/blob/61ffae7d1628f0551e77e1a2853209ff24c1f1bb/designate_tempest_plugin/services/dns/json/base.py#L74","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"2d158a9550610a66ccf136a857420de260aad972","unresolved":true,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def clean_up_resources(self, zone_import_id):"},{"line_number":209,"context_line":"        zone_import \u003d self.client.show_zone_import(zone_import_id)[1]"},{"line_number":210,"context_line":"        if zone_import[\u0027zone_id\u0027]:  # A zone was actually created."},{"line_number":211,"context_line":"            waiters.wait_for_zone_import_status("},{"line_number":212,"context_line":"                self.client, zone_import_id, const.COMPLETE)"},{"line_number":213,"context_line":"            self.client.delete_zone_import(zone_import[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"e4946f6f_a09a25c3","line":210,"in_reply_to":"b2064a19_db896d7d","updated":"2022-02-02 20:05:33.000000000","message":"Correct, will be fixed.","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"74f8e2c2991e3f0acc876c4fbd554c5b214086ba","unresolved":true,"context_lines":[{"line_number":208,"context_line":"    def clean_up_resources(self, zone_import_id):"},{"line_number":209,"context_line":"        zone_import \u003d self.client.show_zone_import(zone_import_id)[1]"},{"line_number":210,"context_line":"        if zone_import[\u0027zone_id\u0027]:  # A zone was actually created."},{"line_number":211,"context_line":"            waiters.wait_for_zone_import_status("},{"line_number":212,"context_line":"                self.client, zone_import_id, const.COMPLETE)"},{"line_number":213,"context_line":"            self.client.delete_zone_import(zone_import[\u0027id\u0027])"},{"line_number":214,"context_line":"            self.wait_zone_delete(self.zone_client, zone_import[\u0027zone_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"80f44fc2_ac28d5b1","line":211,"updated":"2022-02-02 00:20:49.000000000","message":"What if the zone_import is stuck in ERROR. Do we need this wait or can we just delete?","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"2d158a9550610a66ccf136a857420de260aad972","unresolved":true,"context_lines":[{"line_number":208,"context_line":"    def clean_up_resources(self, zone_import_id):"},{"line_number":209,"context_line":"        zone_import \u003d self.client.show_zone_import(zone_import_id)[1]"},{"line_number":210,"context_line":"        if zone_import[\u0027zone_id\u0027]:  # A zone was actually created."},{"line_number":211,"context_line":"            waiters.wait_for_zone_import_status("},{"line_number":212,"context_line":"                self.client, zone_import_id, const.COMPLETE)"},{"line_number":213,"context_line":"            self.client.delete_zone_import(zone_import[\u0027id\u0027])"},{"line_number":214,"context_line":"            self.wait_zone_delete(self.zone_client, zone_import[\u0027zone_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5bac84ec_31d3fd8e","line":211,"in_reply_to":"80f44fc2_ac28d5b1","updated":"2022-02-02 20:05:33.000000000","message":"Correct, no need to wait.\nWill be fixed","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"74f8e2c2991e3f0acc876c4fbd554c5b214086ba","unresolved":true,"context_lines":[{"line_number":213,"context_line":"            self.client.delete_zone_import(zone_import[\u0027id\u0027])"},{"line_number":214,"context_line":"            self.wait_zone_delete(self.zone_client, zone_import[\u0027zone_id\u0027])"},{"line_number":215,"context_line":"        else:  # Import has failed and zone wasn\u0027t created."},{"line_number":216,"context_line":"            self.client.delete_zone_import(zone_import[\u0027id\u0027])"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @decorators.idempotent_id(\u002731eaf25a-9532-11eb-a55d-74e5f9e2a801\u0027)"},{"line_number":219,"context_line":"    def test_create_zone_import_invalid_ttl(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"91c67e03_98712e63","line":216,"updated":"2022-02-02 00:20:49.000000000","message":"Why wouldn\u0027t you also wait for this delete to complete like line 214?","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"2d158a9550610a66ccf136a857420de260aad972","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            self.client.delete_zone_import(zone_import[\u0027id\u0027])"},{"line_number":214,"context_line":"            self.wait_zone_delete(self.zone_client, zone_import[\u0027zone_id\u0027])"},{"line_number":215,"context_line":"        else:  # Import has failed and zone wasn\u0027t created."},{"line_number":216,"context_line":"            self.client.delete_zone_import(zone_import[\u0027id\u0027])"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @decorators.idempotent_id(\u002731eaf25a-9532-11eb-a55d-74e5f9e2a801\u0027)"},{"line_number":219,"context_line":"    def test_create_zone_import_invalid_ttl(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ccafd513_74e49e1f","line":216,"in_reply_to":"91c67e03_98712e63","updated":"2022-02-02 20:05:33.000000000","message":"Done","commit_id":"e775781bd8446aa6f0a846eb53dd11011bf739e5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ed5855142a2264f4af4bf2aa9bd50837fa6ad1fc","unresolved":true,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def _clean_up_resources(self, zone_import_id):"},{"line_number":209,"context_line":"        try:"},{"line_number":210,"context_line":"            zone_import \u003d self.client.show_zone_import(zone_import_id)[1]"},{"line_number":211,"context_line":"            if zone_import:"},{"line_number":212,"context_line":"                self.client.delete_zone_import(zone_import[\u0027id\u0027])"},{"line_number":213,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ed682eb6_1618bcd3","line":210,"updated":"2022-03-02 01:27:16.000000000","message":"It is more pythonic to call the delete and catch the Not Found exception.","commit_id":"d722ce5c53ae5f0bb1bc5b00f2f4b8e7f326f8d4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c0a348071689e75c64783520ca37a6ecb8d3ae02","unresolved":true,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def _clean_up_resources(self, zone_import_id):"},{"line_number":209,"context_line":"        try:"},{"line_number":210,"context_line":"            zone_import \u003d self.client.show_zone_import(zone_import_id)[1]"},{"line_number":211,"context_line":"            if zone_import:"},{"line_number":212,"context_line":"                self.client.delete_zone_import(zone_import[\u0027id\u0027])"},{"line_number":213,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"8d94e2ce_912c6d77","line":210,"in_reply_to":"ed682eb6_1618bcd3","updated":"2022-03-02 09:59:02.000000000","message":"Yep, that\u0027s correct, will be fixed in the in the next patchset.","commit_id":"d722ce5c53ae5f0bb1bc5b00f2f4b8e7f326f8d4"}]}