)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"eead7f3a9f28ca2f3f45828da86abd8e9fb4d30e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"257f5d50_cccf0806","updated":"2022-02-07 19:53:25.000000000","message":"LGTM","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"c9099baf0dbd966bbd108e69a61c969cd9215b41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eb5a510a_05761778","updated":"2022-02-08 18:49:27.000000000","message":"See comments.","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"456f1d8b76f69b1cce75353d1844faedde339790","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"36b95515_ec98becb","updated":"2022-02-22 23:05:08.000000000","message":"LGTM","commit_id":"d61e4c5eb6c8544b768b9ee6d19ebfeeec4759e7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d7acca43fb643947efb5fc0eb00ef1e2e37022d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"32293a0e_ecf2ef4f","updated":"2022-06-28 21:32:36.000000000","message":"LGTM","commit_id":"8060d1cf56c293145bd6501bbd40d7d32ef5e783"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"3586008ac1c9d305b1619ffaaabe54f6e9d7f98e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fbabd3e1_74d8c8ef","updated":"2022-06-07 18:35:47.000000000","message":"LGTM","commit_id":"8060d1cf56c293145bd6501bbd40d7d32ef5e783"}],"designate_tempest_plugin/tests/scenario/v2/test_zones.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"880e56e00666a3275e184a56ff0e88b08ac306e6","unresolved":true,"context_lines":[{"line_number":121,"context_line":"    @testtools.skipUnless("},{"line_number":122,"context_line":"        config.CONF.dns.nameservers,"},{"line_number":123,"context_line":"        \"Config option dns.nameservers is missing or empty\")"},{"line_number":124,"context_line":"    def test_notify_msg_sent_to_nameservers(self):"},{"line_number":125,"context_line":"        LOG.info(\u0027Create a zone and wait till ACTIVE\u0027)"},{"line_number":126,"context_line":"        zone \u003d self.client.create_zone(wait_until\u003d\u0027ACTIVE\u0027)[1]"},{"line_number":127,"context_line":"        org_serial \u003d zone[\u0027serial\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"126cdf04_a52c5a55","line":124,"updated":"2022-02-08 17:48:35.000000000","message":"I think this is a valid test, to confirm a zone update propagates to the DNS servers, but nothing here is actually confirming it was a NOTIFY that triggered the serial number update. It could be regularly timed sync for example. So, maybe we should rename this test.","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"43736a9aca0eac9b0d7a475fbfd35c85b2731bbf","unresolved":true,"context_lines":[{"line_number":121,"context_line":"    @testtools.skipUnless("},{"line_number":122,"context_line":"        config.CONF.dns.nameservers,"},{"line_number":123,"context_line":"        \"Config option dns.nameservers is missing or empty\")"},{"line_number":124,"context_line":"    def test_notify_msg_sent_to_nameservers(self):"},{"line_number":125,"context_line":"        LOG.info(\u0027Create a zone and wait till ACTIVE\u0027)"},{"line_number":126,"context_line":"        zone \u003d self.client.create_zone(wait_until\u003d\u0027ACTIVE\u0027)[1]"},{"line_number":127,"context_line":"        org_serial \u003d zone[\u0027serial\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"848dfea8_406ea418","line":124,"in_reply_to":"126cdf04_a52c5a55","updated":"2022-02-09 11:14:39.000000000","message":"As agreed, I\u0027ll check the SOA Refresh value within the test.\nBTW, by default it seems that the default SOA Refresh is 3600 (one hour)\nThe test will be skipped if the Zone under test will have a SOA Refresh that is not close to at least one hour.\nI\u0027ll also add a comment in test explaining why do we need it.","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6381b8432e1ae59ef60b56e3c15e50dcc7832c16","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    @testtools.skipUnless("},{"line_number":122,"context_line":"        config.CONF.dns.nameservers,"},{"line_number":123,"context_line":"        \"Config option dns.nameservers is missing or empty\")"},{"line_number":124,"context_line":"    def test_notify_msg_sent_to_nameservers(self):"},{"line_number":125,"context_line":"        LOG.info(\u0027Create a zone and wait till ACTIVE\u0027)"},{"line_number":126,"context_line":"        zone \u003d self.client.create_zone(wait_until\u003d\u0027ACTIVE\u0027)[1]"},{"line_number":127,"context_line":"        org_serial \u003d zone[\u0027serial\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"86d4329e_8a677c76","line":124,"in_reply_to":"848dfea8_406ea418","updated":"2022-02-09 11:18:26.000000000","message":"Done","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"880e56e00666a3275e184a56ff0e88b08ac306e6","unresolved":true,"context_lines":[{"line_number":130,"context_line":"        LOG.info(\"Update Zone\u0027s description, wait till ACTIVE and\""},{"line_number":131,"context_line":"                 \" ensure Zone\u0027s Serial has changed\")"},{"line_number":132,"context_line":"        updated_zone \u003d self.client.update_zone("},{"line_number":133,"context_line":"            zone[\u0027id\u0027], description\u003d\u0027Updated Zone\u0027, wait_until\u003d\u0027ACTIVE\u0027)[1]"},{"line_number":134,"context_line":"        new_serial \u003d updated_zone[\u0027serial\u0027]"},{"line_number":135,"context_line":"        self.assertNotEqual("},{"line_number":136,"context_line":"            new_serial, org_serial,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4cb7f50c_3a90cb99","line":133,"updated":"2022-02-08 17:48:35.000000000","message":"Updating the description causing a zone update seems like a bug.\nThe description is a metadata field only known to Designate. This should not cause a serial number bump and NOTIFY.","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6381b8432e1ae59ef60b56e3c15e50dcc7832c16","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        LOG.info(\"Update Zone\u0027s description, wait till ACTIVE and\""},{"line_number":131,"context_line":"                 \" ensure Zone\u0027s Serial has changed\")"},{"line_number":132,"context_line":"        updated_zone \u003d self.client.update_zone("},{"line_number":133,"context_line":"            zone[\u0027id\u0027], description\u003d\u0027Updated Zone\u0027, wait_until\u003d\u0027ACTIVE\u0027)[1]"},{"line_number":134,"context_line":"        new_serial \u003d updated_zone[\u0027serial\u0027]"},{"line_number":135,"context_line":"        self.assertNotEqual("},{"line_number":136,"context_line":"            new_serial, org_serial,"}],"source_content_type":"text/x-python","patch_set":1,"id":"14dde951_b8cb5c42","line":133,"in_reply_to":"1df7d28e_99c34012","updated":"2022-02-09 11:18:26.000000000","message":"Done","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"43736a9aca0eac9b0d7a475fbfd35c85b2731bbf","unresolved":true,"context_lines":[{"line_number":130,"context_line":"        LOG.info(\"Update Zone\u0027s description, wait till ACTIVE and\""},{"line_number":131,"context_line":"                 \" ensure Zone\u0027s Serial has changed\")"},{"line_number":132,"context_line":"        updated_zone \u003d self.client.update_zone("},{"line_number":133,"context_line":"            zone[\u0027id\u0027], description\u003d\u0027Updated Zone\u0027, wait_until\u003d\u0027ACTIVE\u0027)[1]"},{"line_number":134,"context_line":"        new_serial \u003d updated_zone[\u0027serial\u0027]"},{"line_number":135,"context_line":"        self.assertNotEqual("},{"line_number":136,"context_line":"            new_serial, org_serial,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1df7d28e_99c34012","line":133,"in_reply_to":"4cb7f50c_3a90cb99","updated":"2022-02-09 11:14:39.000000000","message":"Yep, makes sense to file a BZ for that one + adding a NEW negative (Update Zone Description) test case (with skip on bug)","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"880e56e00666a3275e184a56ff0e88b08ac306e6","unresolved":true,"context_lines":[{"line_number":146,"context_line":"            while not serial_detected:"},{"line_number":147,"context_line":"                ns_obj \u003d SingleQueryClient(ns, config.CONF.dns.query_timeout)"},{"line_number":148,"context_line":"                ns_soa_record \u003d ns_obj.query(zone[\u0027name\u0027], rdatatype\u003d\u0027SOA\u0027)"},{"line_number":149,"context_line":"                if str(new_serial) in str(ns_soa_record):"},{"line_number":150,"context_line":"                    serial_detected \u003d True"},{"line_number":151,"context_line":"                if time.time() - start \u003e\u003d config.CONF.dns.build_timeout:"},{"line_number":152,"context_line":"                    raise lib_exc.TimeoutException("}],"source_content_type":"text/x-python","patch_set":1,"id":"4b827721_5829ccc3","line":149,"updated":"2022-02-08 17:48:35.000000000","message":"I wonder if the batched serial number update patch would impact this test.\nhttps://review.opendev.org/c/openstack/designate/+/823325","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"74736b6d928058a1da2b36e071abb9b395ba8b55","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            while not serial_detected:"},{"line_number":147,"context_line":"                ns_obj \u003d SingleQueryClient(ns, config.CONF.dns.query_timeout)"},{"line_number":148,"context_line":"                ns_soa_record \u003d ns_obj.query(zone[\u0027name\u0027], rdatatype\u003d\u0027SOA\u0027)"},{"line_number":149,"context_line":"                if str(new_serial) in str(ns_soa_record):"},{"line_number":150,"context_line":"                    serial_detected \u003d True"},{"line_number":151,"context_line":"                if time.time() - start \u003e\u003d config.CONF.dns.build_timeout:"},{"line_number":152,"context_line":"                    raise lib_exc.TimeoutException("}],"source_content_type":"text/x-python","patch_set":1,"id":"a074e4b8_10701089","line":149,"in_reply_to":"10b015b6_8e10144a","updated":"2022-02-09 14:36:23.000000000","message":"I\u0027ve switched(fetch) Designate code to: https://review.opendev.org/c/openstack/designate/+/823325.\nTest result is the same (PAASS) means that the \"Serial\" was changed on Zone Description update.","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6381b8432e1ae59ef60b56e3c15e50dcc7832c16","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            while not serial_detected:"},{"line_number":147,"context_line":"                ns_obj \u003d SingleQueryClient(ns, config.CONF.dns.query_timeout)"},{"line_number":148,"context_line":"                ns_soa_record \u003d ns_obj.query(zone[\u0027name\u0027], rdatatype\u003d\u0027SOA\u0027)"},{"line_number":149,"context_line":"                if str(new_serial) in str(ns_soa_record):"},{"line_number":150,"context_line":"                    serial_detected \u003d True"},{"line_number":151,"context_line":"                if time.time() - start \u003e\u003d config.CONF.dns.build_timeout:"},{"line_number":152,"context_line":"                    raise lib_exc.TimeoutException("}],"source_content_type":"text/x-python","patch_set":1,"id":"10b015b6_8e10144a","line":149,"in_reply_to":"15432bbf_4f32def7","updated":"2022-02-09 11:18:26.000000000","message":"Done","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"43736a9aca0eac9b0d7a475fbfd35c85b2731bbf","unresolved":true,"context_lines":[{"line_number":146,"context_line":"            while not serial_detected:"},{"line_number":147,"context_line":"                ns_obj \u003d SingleQueryClient(ns, config.CONF.dns.query_timeout)"},{"line_number":148,"context_line":"                ns_soa_record \u003d ns_obj.query(zone[\u0027name\u0027], rdatatype\u003d\u0027SOA\u0027)"},{"line_number":149,"context_line":"                if str(new_serial) in str(ns_soa_record):"},{"line_number":150,"context_line":"                    serial_detected \u003d True"},{"line_number":151,"context_line":"                if time.time() - start \u003e\u003d config.CONF.dns.build_timeout:"},{"line_number":152,"context_line":"                    raise lib_exc.TimeoutException("}],"source_content_type":"text/x-python","patch_set":1,"id":"15432bbf_4f32def7","line":149,"in_reply_to":"4b827721_5829ccc3","updated":"2022-02-09 11:14:39.000000000","message":"I\u0027ll check it out","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"880e56e00666a3275e184a56ff0e88b08ac306e6","unresolved":true,"context_lines":[{"line_number":147,"context_line":"                ns_obj \u003d SingleQueryClient(ns, config.CONF.dns.query_timeout)"},{"line_number":148,"context_line":"                ns_soa_record \u003d ns_obj.query(zone[\u0027name\u0027], rdatatype\u003d\u0027SOA\u0027)"},{"line_number":149,"context_line":"                if str(new_serial) in str(ns_soa_record):"},{"line_number":150,"context_line":"                    serial_detected \u003d True"},{"line_number":151,"context_line":"                if time.time() - start \u003e\u003d config.CONF.dns.build_timeout:"},{"line_number":152,"context_line":"                    raise lib_exc.TimeoutException("},{"line_number":153,"context_line":"                        \u0027Failed, expected Serial:{} for a Zone was not\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"e65f9d52_2b07ddf4","line":150,"updated":"2022-02-08 17:48:35.000000000","message":"You could just return from the test here.","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"43736a9aca0eac9b0d7a475fbfd35c85b2731bbf","unresolved":true,"context_lines":[{"line_number":147,"context_line":"                ns_obj \u003d SingleQueryClient(ns, config.CONF.dns.query_timeout)"},{"line_number":148,"context_line":"                ns_soa_record \u003d ns_obj.query(zone[\u0027name\u0027], rdatatype\u003d\u0027SOA\u0027)"},{"line_number":149,"context_line":"                if str(new_serial) in str(ns_soa_record):"},{"line_number":150,"context_line":"                    serial_detected \u003d True"},{"line_number":151,"context_line":"                if time.time() - start \u003e\u003d config.CONF.dns.build_timeout:"},{"line_number":152,"context_line":"                    raise lib_exc.TimeoutException("},{"line_number":153,"context_line":"                        \u0027Failed, expected Serial:{} for a Zone was not\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"e988d99c_4cc84394","line":150,"in_reply_to":"e65f9d52_2b07ddf4","updated":"2022-02-09 11:14:39.000000000","message":":) \nSure, will fix that.","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6381b8432e1ae59ef60b56e3c15e50dcc7832c16","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                ns_obj \u003d SingleQueryClient(ns, config.CONF.dns.query_timeout)"},{"line_number":148,"context_line":"                ns_soa_record \u003d ns_obj.query(zone[\u0027name\u0027], rdatatype\u003d\u0027SOA\u0027)"},{"line_number":149,"context_line":"                if str(new_serial) in str(ns_soa_record):"},{"line_number":150,"context_line":"                    serial_detected \u003d True"},{"line_number":151,"context_line":"                if time.time() - start \u003e\u003d config.CONF.dns.build_timeout:"},{"line_number":152,"context_line":"                    raise lib_exc.TimeoutException("},{"line_number":153,"context_line":"                        \u0027Failed, expected Serial:{} for a Zone was not\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"c8632369_0f4b361a","line":150,"in_reply_to":"e988d99c_4cc84394","updated":"2022-02-09 11:18:26.000000000","message":"Done","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"c9099baf0dbd966bbd108e69a61c969cd9215b41","unresolved":true,"context_lines":[{"line_number":148,"context_line":"                ns_soa_record \u003d ns_obj.query(zone[\u0027name\u0027], rdatatype\u003d\u0027SOA\u0027)"},{"line_number":149,"context_line":"                if str(new_serial) in str(ns_soa_record):"},{"line_number":150,"context_line":"                    serial_detected \u003d True"},{"line_number":151,"context_line":"                if time.time() - start \u003e\u003d config.CONF.dns.build_timeout:"},{"line_number":152,"context_line":"                    raise lib_exc.TimeoutException("},{"line_number":153,"context_line":"                        \u0027Failed, expected Serial:{} for a Zone was not\u0027"},{"line_number":154,"context_line":"                        \u0027 detected on Nameserver:{} within a timeout of:{}\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"08f397a2_b9ead58d","line":151,"updated":"2022-02-08 18:49:27.000000000","message":"In 149 if the test is True there would be no need to perform #151?","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"43736a9aca0eac9b0d7a475fbfd35c85b2731bbf","unresolved":true,"context_lines":[{"line_number":148,"context_line":"                ns_soa_record \u003d ns_obj.query(zone[\u0027name\u0027], rdatatype\u003d\u0027SOA\u0027)"},{"line_number":149,"context_line":"                if str(new_serial) in str(ns_soa_record):"},{"line_number":150,"context_line":"                    serial_detected \u003d True"},{"line_number":151,"context_line":"                if time.time() - start \u003e\u003d config.CONF.dns.build_timeout:"},{"line_number":152,"context_line":"                    raise lib_exc.TimeoutException("},{"line_number":153,"context_line":"                        \u0027Failed, expected Serial:{} for a Zone was not\u0027"},{"line_number":154,"context_line":"                        \u0027 detected on Nameserver:{} within a timeout of:{}\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"475b19d2_a546aeab","line":151,"in_reply_to":"08f397a2_b9ead58d","updated":"2022-02-09 11:14:39.000000000","message":"+1\nI\u0027ll fix that in the next patchset.","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6381b8432e1ae59ef60b56e3c15e50dcc7832c16","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                ns_soa_record \u003d ns_obj.query(zone[\u0027name\u0027], rdatatype\u003d\u0027SOA\u0027)"},{"line_number":149,"context_line":"                if str(new_serial) in str(ns_soa_record):"},{"line_number":150,"context_line":"                    serial_detected \u003d True"},{"line_number":151,"context_line":"                if time.time() - start \u003e\u003d config.CONF.dns.build_timeout:"},{"line_number":152,"context_line":"                    raise lib_exc.TimeoutException("},{"line_number":153,"context_line":"                        \u0027Failed, expected Serial:{} for a Zone was not\u0027"},{"line_number":154,"context_line":"                        \u0027 detected on Nameserver:{} within a timeout of:{}\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"b300e2fb_97ad6542","line":151,"in_reply_to":"475b19d2_a546aeab","updated":"2022-02-09 11:18:26.000000000","message":"Done","commit_id":"a9fc8da4d7eaf8a344eb8fb5b8c955ad2d6be408"}]}