)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e6b5298c_e4848ff5","updated":"2022-02-10 01:32:53.000000000","message":"I have a few comments here.\nIt does appear that test_recordset_records_quota is catching a bug, so awesome!","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"b9e7a62f688b61bb26cfa0b69cdfd0289c423684","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"50c122a6_4da014e3","updated":"2022-02-18 05:11:47.000000000","message":"Don, I\u0027m absolutely agree with you that we need to avoid using the \u0027_\u0027 in cases you\u0027ve commented.\nBTW, It was already raised by folks more than once in the past and I\u0027m always using \"indexing\" instead in my code.\n\nWe have ~171 cases in the existing code where \"-,\" is used.\nstack@ubuntu-0217-1325:~/designate-tempest-plugin$ grep -ir \"_,\" | wc -l\n171\nThis (as well as replacing all statuses\u0026actions strings like ACTIVE to const.ACTIVE) needs some general refactoring patch and we (QE) can jump into that.  \n\nAs for this specific \"quota\" patch, I don\u0027t think that the \"-1\" because of underscores in the existing code is in place here 😞","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"0636b0bd5195b1965e1f59bd4756f636493cabb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f51a76d3_8a6bc4e6","updated":"2022-02-21 17:35:17.000000000","message":"I agree with you on the python\u0027_\u0027 comments that this is out of scope for this patch.","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0f75c6997f7669cc5f535197864ffe3d80ef93e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9cd5c358_25acf55b","updated":"2022-02-23 22:58:32.000000000","message":"I have some comments on this one.","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9a5d6377994015d9b260525e2c21cfde211d4fc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3f4e607b_5c7dbcbd","in_reply_to":"f51a76d3_8a6bc4e6","updated":"2022-02-21 17:42:05.000000000","message":"That\u0027s fine :)\nWe\u0027ll propose a patch to fix that all. \nThanks!","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"eab40ace8a29d3274df337474d57f93e9aff1e87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"62d5924a_18f40815","updated":"2022-03-02 01:17:10.000000000","message":"Arkady, this is too many rechecks.\n\nI have addressed the CentOS 9 Stream breakage (made it non-voting here and published a patch for devstack to fix the root cause).\nHowever, the Ussuri branch test will not pass until I get this merged:\nhttps://review.opendev.org/c/openstack/designate/+/830921\n\nThere is something odd in the quotas back on that branch I need to look into.","commit_id":"dc09d1ed5278258b3f244fa70531da71abfaf2f7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4bf3f028831cbf95a83bd9eb3da3011538825040","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"01256973_2d66a4e2","updated":"2022-02-24 15:26:36.000000000","message":"recheck","commit_id":"dc09d1ed5278258b3f244fa70531da71abfaf2f7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"e8d9b4b45c7376837eab3aede6ff77efd7d896b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"261135f1_79169fdf","updated":"2022-02-27 08:32:06.000000000","message":"recheck","commit_id":"dc09d1ed5278258b3f244fa70531da71abfaf2f7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"bb1c56716ecc82b4828545bc1954f1b25d201120","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2f97e858_e2073969","updated":"2022-02-28 07:31:38.000000000","message":"recheck","commit_id":"dc09d1ed5278258b3f244fa70531da71abfaf2f7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7a4b20fd1e4f9d85dd6f51631f888bef3d7a1dbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fc2bab80_00911f14","updated":"2022-02-27 10:29:41.000000000","message":"recheck","commit_id":"dc09d1ed5278258b3f244fa70531da71abfaf2f7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cc119d45dca9da181f18dce61974361a3e754913","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"af36ff32_866cf847","updated":"2022-06-28 21:39:57.000000000","message":"LGTM","commit_id":"356c5ae37d7ac06c8ea26344531019076cb4788e"}],"designate_tempest_plugin/common/waiters.py":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"fca6d309770539f46dbf88442ef5df40b1ef5b90","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        time.sleep(client.build_interval)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        try:"},{"line_number":36,"context_line":"            _, zone \u003d client.show_zone(zone_id)"},{"line_number":37,"context_line":"        except lib_exc.NotFound:"},{"line_number":38,"context_line":"            LOG.info(\u0027Zone %s is 404ing\u0027, zone_id)"},{"line_number":39,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":9,"id":"ad9822c2_9549fccc","line":36,"updated":"2022-02-17 21:12:21.000000000","message":"see L135 comment, basically should probably change them all in this file, I believe there are 9 cases.","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"77c46afbbfeba09e301d0cd77d77186631fa3e53","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        time.sleep(client.build_interval)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        try:"},{"line_number":36,"context_line":"            _, zone \u003d client.show_zone(zone_id)"},{"line_number":37,"context_line":"        except lib_exc.NotFound:"},{"line_number":38,"context_line":"            LOG.info(\u0027Zone %s is 404ing\u0027, zone_id)"},{"line_number":39,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":9,"id":"d5a0cd4f_4313c74e","line":36,"in_reply_to":"ad9822c2_9549fccc","updated":"2022-02-21 17:36:30.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"fca6d309770539f46dbf88442ef5df40b1ef5b90","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    \"\"\"Waits for a zone to reach given status.\"\"\""},{"line_number":63,"context_line":"    LOG.info(\u0027Waiting for zone %s to reach %s\u0027, zone_id, status)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    _, zone \u003d client.show_zone(zone_id, headers\u003dheaders)"},{"line_number":66,"context_line":"    start \u003d int(time.time())"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    while zone[\u0027status\u0027] !\u003d status:"}],"source_content_type":"text/x-python","patch_set":9,"id":"4c5d278c_a21be9b9","line":65,"updated":"2022-02-17 21:12:21.000000000","message":"SAme as L135","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"77c46afbbfeba09e301d0cd77d77186631fa3e53","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    \"\"\"Waits for a zone to reach given status.\"\"\""},{"line_number":63,"context_line":"    LOG.info(\u0027Waiting for zone %s to reach %s\u0027, zone_id, status)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    _, zone \u003d client.show_zone(zone_id, headers\u003dheaders)"},{"line_number":66,"context_line":"    start \u003d int(time.time())"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    while zone[\u0027status\u0027] !\u003d status:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ef82c835_a05627ac","line":65,"in_reply_to":"4c5d278c_a21be9b9","updated":"2022-02-21 17:36:30.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"fca6d309770539f46dbf88442ef5df40b1ef5b90","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    while zone[\u0027status\u0027] !\u003d status:"},{"line_number":69,"context_line":"        time.sleep(client.build_interval)"},{"line_number":70,"context_line":"        _, zone \u003d client.show_zone(zone_id, headers\u003dheaders)"},{"line_number":71,"context_line":"        status_curr \u003d zone[\u0027status\u0027]"},{"line_number":72,"context_line":"        if status_curr \u003d\u003d status:"},{"line_number":73,"context_line":"            LOG.info(\u0027Zone %s reached %s\u0027, zone_id, status)"}],"source_content_type":"text/x-python","patch_set":9,"id":"0b756c6e_99d78762","line":70,"updated":"2022-02-17 21:12:21.000000000","message":"SAme as L135","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"77c46afbbfeba09e301d0cd77d77186631fa3e53","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    while zone[\u0027status\u0027] !\u003d status:"},{"line_number":69,"context_line":"        time.sleep(client.build_interval)"},{"line_number":70,"context_line":"        _, zone \u003d client.show_zone(zone_id, headers\u003dheaders)"},{"line_number":71,"context_line":"        status_curr \u003d zone[\u0027status\u0027]"},{"line_number":72,"context_line":"        if status_curr \u003d\u003d status:"},{"line_number":73,"context_line":"            LOG.info(\u0027Zone %s reached %s\u0027, zone_id, status)"}],"source_content_type":"text/x-python","patch_set":9,"id":"94478c25_f1a6dc3b","line":70,"in_reply_to":"0b756c6e_99d78762","updated":"2022-02-21 17:36:30.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"fca6d309770539f46dbf88442ef5df40b1ef5b90","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    \"\"\"Waits for an imported zone to reach the given status.\"\"\""},{"line_number":95,"context_line":"    LOG.info(\u0027Waiting for zone import %s to reach %s\u0027, zone_import_id, status)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    _, zone_import \u003d client.show_zone_import(zone_import_id)"},{"line_number":98,"context_line":"    start \u003d int(time.time())"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    while zone_import[\u0027status\u0027] !\u003d status:"}],"source_content_type":"text/x-python","patch_set":9,"id":"542812c4_6399ba0c","line":97,"updated":"2022-02-17 21:12:21.000000000","message":"SAme as L135.","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"77c46afbbfeba09e301d0cd77d77186631fa3e53","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    \"\"\"Waits for an imported zone to reach the given status.\"\"\""},{"line_number":95,"context_line":"    LOG.info(\u0027Waiting for zone import %s to reach %s\u0027, zone_import_id, status)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    _, zone_import \u003d client.show_zone_import(zone_import_id)"},{"line_number":98,"context_line":"    start \u003d int(time.time())"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    while zone_import[\u0027status\u0027] !\u003d status:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3dfa9ae8_d2ee2ec1","line":97,"in_reply_to":"542812c4_6399ba0c","updated":"2022-02-21 17:36:30.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"fca6d309770539f46dbf88442ef5df40b1ef5b90","unresolved":true,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    while zone_import[\u0027status\u0027] !\u003d status:"},{"line_number":101,"context_line":"        time.sleep(client.build_interval)"},{"line_number":102,"context_line":"        _, zone_import \u003d client.show_zone_import(zone_import_id)"},{"line_number":103,"context_line":"        status_curr \u003d zone_import[\u0027status\u0027]"},{"line_number":104,"context_line":"        if status_curr \u003d\u003d status:"},{"line_number":105,"context_line":"            LOG.info(\u0027Zone import %s reached %s\u0027, zone_import_id, status)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5dc3fe_ff6d99eb","line":102,"updated":"2022-02-17 21:12:21.000000000","message":"Same as L135","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"77c46afbbfeba09e301d0cd77d77186631fa3e53","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    while zone_import[\u0027status\u0027] !\u003d status:"},{"line_number":101,"context_line":"        time.sleep(client.build_interval)"},{"line_number":102,"context_line":"        _, zone_import \u003d client.show_zone_import(zone_import_id)"},{"line_number":103,"context_line":"        status_curr \u003d zone_import[\u0027status\u0027]"},{"line_number":104,"context_line":"        if status_curr \u003d\u003d status:"},{"line_number":105,"context_line":"            LOG.info(\u0027Zone import %s reached %s\u0027, zone_import_id, status)"}],"source_content_type":"text/x-python","patch_set":9,"id":"4c869eb0_32f5e4a8","line":102,"in_reply_to":"ba5dc3fe_ff6d99eb","updated":"2022-02-21 17:36:30.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"fca6d309770539f46dbf88442ef5df40b1ef5b90","unresolved":true,"context_lines":[{"line_number":127,"context_line":"    \"\"\"Waits for an exported zone to reach the given status.\"\"\""},{"line_number":128,"context_line":"    LOG.info(\u0027Waiting for zone export %s to reach %s\u0027, zone_export_id, status)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    _, zone_export \u003d client.show_zone_export(zone_export_id, headers\u003dheaders)"},{"line_number":131,"context_line":"    start \u003d int(time.time())"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    while zone_export[\u0027status\u0027] !\u003d status:"}],"source_content_type":"text/x-python","patch_set":9,"id":"25d64ef8_d8cb89b7","line":130,"updated":"2022-02-17 21:12:21.000000000","message":"same as L135 comment","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"77c46afbbfeba09e301d0cd77d77186631fa3e53","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    \"\"\"Waits for an exported zone to reach the given status.\"\"\""},{"line_number":128,"context_line":"    LOG.info(\u0027Waiting for zone export %s to reach %s\u0027, zone_export_id, status)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    _, zone_export \u003d client.show_zone_export(zone_export_id, headers\u003dheaders)"},{"line_number":131,"context_line":"    start \u003d int(time.time())"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    while zone_export[\u0027status\u0027] !\u003d status:"}],"source_content_type":"text/x-python","patch_set":9,"id":"cb51d784_977c1971","line":130,"in_reply_to":"25d64ef8_d8cb89b7","updated":"2022-02-21 17:36:30.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"fca6d309770539f46dbf88442ef5df40b1ef5b90","unresolved":true,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    while zone_export[\u0027status\u0027] !\u003d status:"},{"line_number":134,"context_line":"        time.sleep(client.build_interval)"},{"line_number":135,"context_line":"        _, zone_export \u003d client.show_zone_export("},{"line_number":136,"context_line":"            zone_export_id, headers\u003dheaders)"},{"line_number":137,"context_line":"        status_curr \u003d zone_export[\u0027status\u0027]"},{"line_number":138,"context_line":"        if status_curr \u003d\u003d status:"}],"source_content_type":"text/x-python","patch_set":9,"id":"27896b93_0b899d80","line":135,"updated":"2022-02-17 21:12:21.000000000","message":"Can one change the \u0027_\u0027 to a variable like \u0027dummy\u0027. It\u0027s highly discouraged:\n 1) \u0027_\u0027 is used in the internationalization libraries which can cause conflicts, etc.\n 2) \u0027_\u0027 is overloaded in python, it also hold the previous result as is the case here\n\nJust use [index] into the tuple or the word \u0027dummy\u0027","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"77c46afbbfeba09e301d0cd77d77186631fa3e53","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    while zone_export[\u0027status\u0027] !\u003d status:"},{"line_number":134,"context_line":"        time.sleep(client.build_interval)"},{"line_number":135,"context_line":"        _, zone_export \u003d client.show_zone_export("},{"line_number":136,"context_line":"            zone_export_id, headers\u003dheaders)"},{"line_number":137,"context_line":"        status_curr \u003d zone_export[\u0027status\u0027]"},{"line_number":138,"context_line":"        if status_curr \u003d\u003d status:"}],"source_content_type":"text/x-python","patch_set":9,"id":"d9556f77_9410c948","line":135,"in_reply_to":"27896b93_0b899d80","updated":"2022-02-21 17:36:30.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"fca6d309770539f46dbf88442ef5df40b1ef5b90","unresolved":true,"context_lines":[{"line_number":163,"context_line":"    LOG.info(\u0027Waiting for recordset %s to reach %s\u0027,"},{"line_number":164,"context_line":"             recordset_id, status)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    _, recordset \u003d client.show_recordset("},{"line_number":167,"context_line":"        zone_id, recordset_id, headers\u003dheaders)"},{"line_number":168,"context_line":"    start \u003d int(time.time())"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"a9275b64_14c4c2bc","line":166,"updated":"2022-02-17 21:12:21.000000000","message":"Same as L135","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"77c46afbbfeba09e301d0cd77d77186631fa3e53","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    LOG.info(\u0027Waiting for recordset %s to reach %s\u0027,"},{"line_number":164,"context_line":"             recordset_id, status)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    _, recordset \u003d client.show_recordset("},{"line_number":167,"context_line":"        zone_id, recordset_id, headers\u003dheaders)"},{"line_number":168,"context_line":"    start \u003d int(time.time())"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"771690ae_41bb8a76","line":166,"in_reply_to":"a9275b64_14c4c2bc","updated":"2022-02-21 17:36:30.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"fca6d309770539f46dbf88442ef5df40b1ef5b90","unresolved":true,"context_lines":[{"line_number":170,"context_line":"    while recordset[\u0027status\u0027] !\u003d status:"},{"line_number":171,"context_line":"        time.sleep(client.build_interval)"},{"line_number":172,"context_line":"        _, recordset \u003d client.show_recordset("},{"line_number":173,"context_line":"            zone_id, recordset_id, headers\u003dheaders)"},{"line_number":174,"context_line":"        status_curr \u003d recordset[\u0027status\u0027]"},{"line_number":175,"context_line":"        if status_curr \u003d\u003d status:"},{"line_number":176,"context_line":"            LOG.info(\u0027Recordset %s reached %s\u0027, recordset_id, status)"}],"source_content_type":"text/x-python","patch_set":9,"id":"51b2e746_ef56a641","line":173,"updated":"2022-02-17 21:12:21.000000000","message":"same as the L135 comment.","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"77c46afbbfeba09e301d0cd77d77186631fa3e53","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    while recordset[\u0027status\u0027] !\u003d status:"},{"line_number":171,"context_line":"        time.sleep(client.build_interval)"},{"line_number":172,"context_line":"        _, recordset \u003d client.show_recordset("},{"line_number":173,"context_line":"            zone_id, recordset_id, headers\u003dheaders)"},{"line_number":174,"context_line":"        status_curr \u003d recordset[\u0027status\u0027]"},{"line_number":175,"context_line":"        if status_curr \u003d\u003d status:"},{"line_number":176,"context_line":"            LOG.info(\u0027Recordset %s reached %s\u0027, recordset_id, status)"}],"source_content_type":"text/x-python","patch_set":9,"id":"b947d863_4003418a","line":173,"in_reply_to":"51b2e746_ef56a641","updated":"2022-02-21 17:36:30.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"}],"designate_tempest_plugin/tests/scenario/v2/test_quotas.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":78,"context_line":"                attempt_number +\u003d 1"},{"line_number":79,"context_line":"                LOG.info(\u0027Attempt No:{} \u0027.format(attempt_number))"},{"line_number":80,"context_line":"                if quota_type \u003d\u003d \u0027zones\u0027:"},{"line_number":81,"context_line":"                    zone \u003d self.zone_client.create_zone()[1]"},{"line_number":82,"context_line":"                    self.addCleanup("},{"line_number":83,"context_line":"                        self.wait_zone_delete,"},{"line_number":84,"context_line":"                        self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"e9c0b180_3377e446","line":81,"updated":"2022-02-10 01:32:53.000000000","message":"It would be nice to have a description here that describes which test created this zone.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                attempt_number +\u003d 1"},{"line_number":79,"context_line":"                LOG.info(\u0027Attempt No:{} \u0027.format(attempt_number))"},{"line_number":80,"context_line":"                if quota_type \u003d\u003d \u0027zones\u0027:"},{"line_number":81,"context_line":"                    zone \u003d self.zone_client.create_zone()[1]"},{"line_number":82,"context_line":"                    self.addCleanup("},{"line_number":83,"context_line":"                        self.wait_zone_delete,"},{"line_number":84,"context_line":"                        self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"4208393b_aee4ee0a","line":81,"in_reply_to":"e68c7a18_d6aee4b2","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":78,"context_line":"                attempt_number +\u003d 1"},{"line_number":79,"context_line":"                LOG.info(\u0027Attempt No:{} \u0027.format(attempt_number))"},{"line_number":80,"context_line":"                if quota_type \u003d\u003d \u0027zones\u0027:"},{"line_number":81,"context_line":"                    zone \u003d self.zone_client.create_zone()[1]"},{"line_number":82,"context_line":"                    self.addCleanup("},{"line_number":83,"context_line":"                        self.wait_zone_delete,"},{"line_number":84,"context_line":"                        self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"e68c7a18_d6aee4b2","line":81,"in_reply_to":"e9c0b180_3377e446","updated":"2022-02-10 13:21:20.000000000","message":"I\u0027ll use \"description\u003d\" on zone create","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":82,"context_line":"                    self.addCleanup("},{"line_number":83,"context_line":"                        self.wait_zone_delete,"},{"line_number":84,"context_line":"                        self.zone_client, zone[\u0027id\u0027])"},{"line_number":85,"context_line":"                if quota_type in [\u0027zone_recordsets\u0027, \u0027zone_records\u0027]:"},{"line_number":86,"context_line":"                    if quota_type \u003d\u003d \u0027zone_recordsets\u0027:"},{"line_number":87,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":88,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"d88aa4b0_6658a1c0","line":85,"updated":"2022-02-10 01:32:53.000000000","message":"This could be simplified to just be a four branch if:else, removing the \"in\" check.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                    self.addCleanup("},{"line_number":83,"context_line":"                        self.wait_zone_delete,"},{"line_number":84,"context_line":"                        self.zone_client, zone[\u0027id\u0027])"},{"line_number":85,"context_line":"                if quota_type in [\u0027zone_recordsets\u0027, \u0027zone_records\u0027]:"},{"line_number":86,"context_line":"                    if quota_type \u003d\u003d \u0027zone_recordsets\u0027:"},{"line_number":87,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":88,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"bdbe43c9_84c10ead","line":85,"in_reply_to":"7989e91e_a2cfeaaa","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":82,"context_line":"                    self.addCleanup("},{"line_number":83,"context_line":"                        self.wait_zone_delete,"},{"line_number":84,"context_line":"                        self.zone_client, zone[\u0027id\u0027])"},{"line_number":85,"context_line":"                if quota_type in [\u0027zone_recordsets\u0027, \u0027zone_records\u0027]:"},{"line_number":86,"context_line":"                    if quota_type \u003d\u003d \u0027zone_recordsets\u0027:"},{"line_number":87,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":88,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"7989e91e_a2cfeaaa","line":85,"in_reply_to":"d88aa4b0_6658a1c0","updated":"2022-02-10 13:21:20.000000000","message":"The \"in\" will be removed and replaced","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":85,"context_line":"                if quota_type in [\u0027zone_recordsets\u0027, \u0027zone_records\u0027]:"},{"line_number":86,"context_line":"                    if quota_type \u003d\u003d \u0027zone_recordsets\u0027:"},{"line_number":87,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":88,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":89,"context_line":"                            number_of_records\u003drandom.randint(1, 10))"},{"line_number":90,"context_line":"                    else:"},{"line_number":91,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("}],"source_content_type":"text/x-python","patch_set":4,"id":"c87e9b37_9f48223a","line":88,"updated":"2022-02-10 01:32:53.000000000","message":"It would be nice to have a description here that describes which test created this.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5515573d6e52b107aad6ec8b4d306806965d4577","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                if quota_type in [\u0027zone_recordsets\u0027, \u0027zone_records\u0027]:"},{"line_number":86,"context_line":"                    if quota_type \u003d\u003d \u0027zone_recordsets\u0027:"},{"line_number":87,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":88,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":89,"context_line":"                            number_of_records\u003drandom.randint(1, 10))"},{"line_number":90,"context_line":"                    else:"},{"line_number":91,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("}],"source_content_type":"text/x-python","patch_set":4,"id":"39700b1e_e692cea5","line":88,"in_reply_to":"38be8cb8_63fd0004","updated":"2022-02-13 11:20:20.000000000","message":"\u003e recordset_data is just a dict returned from rand_recordset_data, so you can easily add it after the rand_recordset_data:\n\u003e recordset_data[\"description\"] \u003d \"qouta test xyz\"\n\u003e Log messages are not helpful here as those just go out to tempest.\n\n\n\nI\u0027ve tried to add the description by as suggested, but the \"recordset create\" fails because of that:\n\n2022-02-13 13:12:56,600 729828 INFO     [tempest.lib.common.rest_client] Request (QuotasV2Test:test_zone_recordsets_quota): 400 POST https://10.35.64.8/dns/v2/zones/06d5285d-7412-4826-8e04-85db0d4df890/recordsets 0.011s\n2022-02-13 13:12:56,601 729828 DEBUG    [tempest.lib.common.rest_client] Request - Headers: {\u0027Content-Type\u0027: \u0027application/json\u0027, \u0027Accept\u0027: \u0027application/json\u0027, \u0027X-Auth-Token\u0027: \u0027\u003comitted\u003e\u0027}\n        Body: {\"type\": \"A\", \"name\": \"A-709563406.rand-1184462075.com.\", \"records\": [\"120.35.110.229\", \"156.124.126.91\", \"204.197.46.238\", \"243.138.76.118\", \"141.137.5.196\", \"175.71.135.136\", \"79.88.129.88\", \"93.140.181.147\", \"183.184.25.12\"], \"ttl\": 5967, \"Description\": \"Quota type:zone_recordsets\"}\n    Response - Headers: {\u0027date\u0027: \u0027Sun, 13 Feb 2022 11:12:56 GMT\u0027, \u0027server\u0027: \u0027Apache/2.4.41 (Ubuntu)\u0027, \u0027content-type\u0027: \u0027application/json\u0027, \u0027content-length\u0027: \u0027200\u0027, \u0027x-openstack-request-id\u0027: \u0027req-847d585f-e494-4b5a-b872-7908acf5acba\u0027, \u0027connection\u0027: \u0027close\u0027, \u0027status\u0027: \u0027400\u0027, \u0027content-location\u0027: \u0027https://10.35.64.8/dns/v2/zones/06d5285d-7412-4826-8e04-85db0d4df890/recordsets\u0027}\n        Body: b\u0027{\"code\": 400, \"type\": \"invalid_object\", \"message\": \"Provided object does not match schema.  Keys [\\\u0027Description\\\u0027] are not valid for recordset\", \"request_id\": \"req-847d585f-e494-4b5a-b872-7908acf5acba\"}\u0027","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6387316352db77147fc6d4f6faf7e4bb07b1652a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                if quota_type in [\u0027zone_recordsets\u0027, \u0027zone_records\u0027]:"},{"line_number":86,"context_line":"                    if quota_type \u003d\u003d \u0027zone_recordsets\u0027:"},{"line_number":87,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":88,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":89,"context_line":"                            number_of_records\u003drandom.randint(1, 10))"},{"line_number":90,"context_line":"                    else:"},{"line_number":91,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("}],"source_content_type":"text/x-python","patch_set":4,"id":"38be8cb8_63fd0004","line":88,"in_reply_to":"6d3f888c_4a00dd8a","updated":"2022-02-10 18:22:08.000000000","message":"recordset_data is just a dict returned from rand_recordset_data, so you can easily add it after the rand_recordset_data:\nrecordset_data[\"description\"] \u003d \"qouta test xyz\"\nLog messages are not helpful here as those just go out to tempest.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                if quota_type in [\u0027zone_recordsets\u0027, \u0027zone_records\u0027]:"},{"line_number":86,"context_line":"                    if quota_type \u003d\u003d \u0027zone_recordsets\u0027:"},{"line_number":87,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":88,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":89,"context_line":"                            number_of_records\u003drandom.randint(1, 10))"},{"line_number":90,"context_line":"                    else:"},{"line_number":91,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("}],"source_content_type":"text/x-python","patch_set":4,"id":"6d3f888c_4a00dd8a","line":88,"in_reply_to":"866be429_ed09220d","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":85,"context_line":"                if quota_type in [\u0027zone_recordsets\u0027, \u0027zone_records\u0027]:"},{"line_number":86,"context_line":"                    if quota_type \u003d\u003d \u0027zone_recordsets\u0027:"},{"line_number":87,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":88,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":89,"context_line":"                            number_of_records\u003drandom.randint(1, 10))"},{"line_number":90,"context_line":"                    else:"},{"line_number":91,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("}],"source_content_type":"text/x-python","patch_set":4,"id":"866be429_ed09220d","line":88,"in_reply_to":"c87e9b37_9f48223a","updated":"2022-02-10 13:21:20.000000000","message":"We cannot add \"description\u003d\" to \"rand_recordset_data\", but since we\u0027ll have \"description\u003d\" in zone create + LOG messages that would be fine.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":86,"context_line":"                    if quota_type \u003d\u003d \u0027zone_recordsets\u0027:"},{"line_number":87,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":88,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":89,"context_line":"                            number_of_records\u003drandom.randint(1, 10))"},{"line_number":90,"context_line":"                    else:"},{"line_number":91,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":92,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"d6bb449a_bb588ce8","line":89,"updated":"2022-02-10 01:32:53.000000000","message":"This should check the recordset_records setting for the project and pick a number that will not exceed that.\nA cloud under test may have changed the recordset_records quota for all users.\nhttps://docs.openstack.org/designate/latest/admin/quotas.html#default-quotas","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                    if quota_type \u003d\u003d \u0027zone_recordsets\u0027:"},{"line_number":87,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":88,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":89,"context_line":"                            number_of_records\u003drandom.randint(1, 10))"},{"line_number":90,"context_line":"                    else:"},{"line_number":91,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":92,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"4c940d85_5b87df7a","line":89,"in_reply_to":"d6174b62_c7a2c855","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":86,"context_line":"                    if quota_type \u003d\u003d \u0027zone_recordsets\u0027:"},{"line_number":87,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":88,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":89,"context_line":"                            number_of_records\u003drandom.randint(1, 10))"},{"line_number":90,"context_line":"                    else:"},{"line_number":91,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":92,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"d6174b62_c7a2c855","line":89,"in_reply_to":"d6bb449a_bb588ce8","updated":"2022-02-10 13:21:20.000000000","message":"Yep, good catch!\nWill be checked.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":88,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":89,"context_line":"                            number_of_records\u003drandom.randint(1, 10))"},{"line_number":90,"context_line":"                    else:"},{"line_number":91,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":92,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":93,"context_line":"                    recordset \u003d self.recordset_client.create_recordset("},{"line_number":94,"context_line":"                        zone[\u0027id\u0027], recordset_data\u003drecordset_data,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1895b79c_3f958ee9","line":91,"updated":"2022-02-10 01:32:53.000000000","message":"It would be nice to have a description here that describes which test created this.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":88,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":89,"context_line":"                            number_of_records\u003drandom.randint(1, 10))"},{"line_number":90,"context_line":"                    else:"},{"line_number":91,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":92,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":93,"context_line":"                    recordset \u003d self.recordset_client.create_recordset("},{"line_number":94,"context_line":"                        zone[\u0027id\u0027], recordset_data\u003drecordset_data,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fecbf0bb_f128bd06","line":91,"in_reply_to":"1895b79c_3f958ee9","updated":"2022-02-10 13:21:20.000000000","message":"We cannot add \"description\u003d\" to \"rand_recordset_data\", but since we\u0027ll have \"description\u003d\" in zone create + LOG messages that would be fine.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6387316352db77147fc6d4f6faf7e4bb07b1652a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":89,"context_line":"                            number_of_records\u003drandom.randint(1, 10))"},{"line_number":90,"context_line":"                    else:"},{"line_number":91,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":92,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":93,"context_line":"                    recordset \u003d self.recordset_client.create_recordset("},{"line_number":94,"context_line":"                        zone[\u0027id\u0027], recordset_data\u003drecordset_data,"}],"source_content_type":"text/x-python","patch_set":4,"id":"2101f6a5_5d659d62","line":91,"in_reply_to":"dc91d86c_24c85ee9","updated":"2022-02-10 18:22:08.000000000","message":"recordset_data is just a dict returned from rand_recordset_data, so you can easily add it after the rand_recordset_data:\nrecordset_data[\"description\"] \u003d \"qouta test xyz\"\nLog messages are not helpful here as those just go out to tempest.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":89,"context_line":"                            number_of_records\u003drandom.randint(1, 10))"},{"line_number":90,"context_line":"                    else:"},{"line_number":91,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":92,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":93,"context_line":"                    recordset \u003d self.recordset_client.create_recordset("},{"line_number":94,"context_line":"                        zone[\u0027id\u0027], recordset_data\u003drecordset_data,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dc91d86c_24c85ee9","line":91,"in_reply_to":"fecbf0bb_f128bd06","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":102,"context_line":"            except Exception as e:"},{"line_number":103,"context_line":"                raised_err \u003d str(e).replace(\u0027 \u0027, \u0027\u0027)"},{"line_number":104,"context_line":"                if not_raised_msg in str(e):"},{"line_number":105,"context_line":"                    raise AssertionError"},{"line_number":106,"context_line":"                elif \"\u0027code\u0027:413\" in raised_err and \\"},{"line_number":107,"context_line":"                        \"\u0027type\u0027:\u0027over_quota\u0027\" in raised_err:"},{"line_number":108,"context_line":"                    LOG.info(\"OK, type\u0027:\u0027over_quota\u0027 was raised\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"d21d61a1_38c29fa7","line":105,"updated":"2022-02-10 01:32:53.000000000","message":"It would be nice if this raised an exception that described what went wrong rather than a generic AssertionError.\nAssertionError(\"Created number of {quota_type} exceeded the quota.\") or something similar.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            except Exception as e:"},{"line_number":103,"context_line":"                raised_err \u003d str(e).replace(\u0027 \u0027, \u0027\u0027)"},{"line_number":104,"context_line":"                if not_raised_msg in str(e):"},{"line_number":105,"context_line":"                    raise AssertionError"},{"line_number":106,"context_line":"                elif \"\u0027code\u0027:413\" in raised_err and \\"},{"line_number":107,"context_line":"                        \"\u0027type\u0027:\u0027over_quota\u0027\" in raised_err:"},{"line_number":108,"context_line":"                    LOG.info(\"OK, type\u0027:\u0027over_quota\u0027 was raised\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"a8d3907e_15bdf0f8","line":105,"in_reply_to":"225a090e_0521380e","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":102,"context_line":"            except Exception as e:"},{"line_number":103,"context_line":"                raised_err \u003d str(e).replace(\u0027 \u0027, \u0027\u0027)"},{"line_number":104,"context_line":"                if not_raised_msg in str(e):"},{"line_number":105,"context_line":"                    raise AssertionError"},{"line_number":106,"context_line":"                elif \"\u0027code\u0027:413\" in raised_err and \\"},{"line_number":107,"context_line":"                        \"\u0027type\u0027:\u0027over_quota\u0027\" in raised_err:"},{"line_number":108,"context_line":"                    LOG.info(\"OK, type\u0027:\u0027over_quota\u0027 was raised\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"225a090e_0521380e","line":105,"in_reply_to":"d21d61a1_38c29fa7","updated":"2022-02-10 13:21:20.000000000","message":"I\u0027ll modify the \"not_raised_msg\" with type this message will be raised here as suggested.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        LOG.info(\u0027Create a Zone, wait until ACTIVE and add:{}\u0027"},{"line_number":125,"context_line":"                 \u0027 Recordsets\u0027.format(self.test_quota_limit + 1))"},{"line_number":126,"context_line":"        zone \u003d self.zone_client.create_zone("},{"line_number":127,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"},{"line_number":128,"context_line":"        self.addCleanup("},{"line_number":129,"context_line":"            self.wait_zone_delete,"}],"source_content_type":"text/x-python","patch_set":4,"id":"08a29ae0_e43cb1bb","line":126,"updated":"2022-02-10 01:32:53.000000000","message":"It would be nice to add a description that calls out the test that created this.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        LOG.info(\u0027Create a Zone, wait until ACTIVE and add:{}\u0027"},{"line_number":125,"context_line":"                 \u0027 Recordsets\u0027.format(self.test_quota_limit + 1))"},{"line_number":126,"context_line":"        zone \u003d self.zone_client.create_zone("},{"line_number":127,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"},{"line_number":128,"context_line":"        self.addCleanup("},{"line_number":129,"context_line":"            self.wait_zone_delete,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ecd5ebf4_94acbf84","line":126,"in_reply_to":"08a29ae0_e43cb1bb","updated":"2022-02-10 13:21:20.000000000","message":"I\u0027ll use \"description\u003d\" on zone create","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        LOG.info(\u0027Create a Zone, wait until ACTIVE and add:{}\u0027"},{"line_number":125,"context_line":"                 \u0027 Recordsets\u0027.format(self.test_quota_limit + 1))"},{"line_number":126,"context_line":"        zone \u003d self.zone_client.create_zone("},{"line_number":127,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"},{"line_number":128,"context_line":"        self.addCleanup("},{"line_number":129,"context_line":"            self.wait_zone_delete,"}],"source_content_type":"text/x-python","patch_set":4,"id":"a1f017b6_bb5795a3","line":126,"in_reply_to":"ecd5ebf4_94acbf84","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":128,"context_line":"        self.addCleanup("},{"line_number":129,"context_line":"            self.wait_zone_delete,"},{"line_number":130,"context_line":"            self.zone_client, zone[\u0027id\u0027])"},{"line_number":131,"context_line":"        for _ in range(self.test_quota_limit + 1):"},{"line_number":132,"context_line":"            recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":133,"context_line":"                record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":134,"context_line":"            recordset \u003d self.recordset_client.create_recordset("}],"source_content_type":"text/x-python","patch_set":4,"id":"ee117de7_1446576d","line":131,"range":{"start_line":131,"start_character":12,"end_line":131,"end_character":13},"updated":"2022-02-10 01:32:53.000000000","message":"Please don\u0027t use _ for indexes. Use \"index\" or something more descriptive and not ambiguous in python (_ is used for i18n, last result, etc.).","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        self.addCleanup("},{"line_number":129,"context_line":"            self.wait_zone_delete,"},{"line_number":130,"context_line":"            self.zone_client, zone[\u0027id\u0027])"},{"line_number":131,"context_line":"        for _ in range(self.test_quota_limit + 1):"},{"line_number":132,"context_line":"            recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":133,"context_line":"                record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":134,"context_line":"            recordset \u003d self.recordset_client.create_recordset("}],"source_content_type":"text/x-python","patch_set":4,"id":"8853fd18_531e33d1","line":131,"range":{"start_line":131,"start_character":12,"end_line":131,"end_character":13},"in_reply_to":"1c18ebc6_511da738","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":128,"context_line":"        self.addCleanup("},{"line_number":129,"context_line":"            self.wait_zone_delete,"},{"line_number":130,"context_line":"            self.zone_client, zone[\u0027id\u0027])"},{"line_number":131,"context_line":"        for _ in range(self.test_quota_limit + 1):"},{"line_number":132,"context_line":"            recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":133,"context_line":"                record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":134,"context_line":"            recordset \u003d self.recordset_client.create_recordset("}],"source_content_type":"text/x-python","patch_set":4,"id":"1c18ebc6_511da738","line":131,"range":{"start_line":131,"start_character":12,"end_line":131,"end_character":13},"in_reply_to":"ee117de7_1446576d","updated":"2022-02-10 13:21:20.000000000","message":"Yep, will use \"i\" instead.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":129,"context_line":"            self.wait_zone_delete,"},{"line_number":130,"context_line":"            self.zone_client, zone[\u0027id\u0027])"},{"line_number":131,"context_line":"        for _ in range(self.test_quota_limit + 1):"},{"line_number":132,"context_line":"            recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":133,"context_line":"                record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":134,"context_line":"            recordset \u003d self.recordset_client.create_recordset("},{"line_number":135,"context_line":"                zone[\u0027id\u0027], recordset_data\u003drecordset_data,"}],"source_content_type":"text/x-python","patch_set":4,"id":"d692198a_840e83ee","line":132,"updated":"2022-02-10 01:32:53.000000000","message":"Can you add a description field that includes the index number of the recordset?\ni.e. description: \"test_api_export_size_quota_recordset_1\", \"test_api_export_size_quota_recordset_2\", etc.\nThis makes it easier for us to track them in the test logs.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6387316352db77147fc6d4f6faf7e4bb07b1652a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            self.wait_zone_delete,"},{"line_number":130,"context_line":"            self.zone_client, zone[\u0027id\u0027])"},{"line_number":131,"context_line":"        for _ in range(self.test_quota_limit + 1):"},{"line_number":132,"context_line":"            recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":133,"context_line":"                record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":134,"context_line":"            recordset \u003d self.recordset_client.create_recordset("},{"line_number":135,"context_line":"                zone[\u0027id\u0027], recordset_data\u003drecordset_data,"}],"source_content_type":"text/x-python","patch_set":4,"id":"89ab7330_ffbd2834","line":132,"in_reply_to":"09ae3426_5aca4d6e","updated":"2022-02-10 18:22:08.000000000","message":"A log message isn\u0027t helpful here as that goes to tempest. Adding it to the description means it\u0027s in the server side logs.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            self.wait_zone_delete,"},{"line_number":130,"context_line":"            self.zone_client, zone[\u0027id\u0027])"},{"line_number":131,"context_line":"        for _ in range(self.test_quota_limit + 1):"},{"line_number":132,"context_line":"            recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":133,"context_line":"                record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":134,"context_line":"            recordset \u003d self.recordset_client.create_recordset("},{"line_number":135,"context_line":"                zone[\u0027id\u0027], recordset_data\u003drecordset_data,"}],"source_content_type":"text/x-python","patch_set":4,"id":"09ae3426_5aca4d6e","line":132,"in_reply_to":"132de005_c78c7995","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":129,"context_line":"            self.wait_zone_delete,"},{"line_number":130,"context_line":"            self.zone_client, zone[\u0027id\u0027])"},{"line_number":131,"context_line":"        for _ in range(self.test_quota_limit + 1):"},{"line_number":132,"context_line":"            recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":133,"context_line":"                record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":134,"context_line":"            recordset \u003d self.recordset_client.create_recordset("},{"line_number":135,"context_line":"                zone[\u0027id\u0027], recordset_data\u003drecordset_data,"}],"source_content_type":"text/x-python","patch_set":4,"id":"132de005_c78c7995","line":132,"in_reply_to":"d692198a_840e83ee","updated":"2022-02-10 13:21:20.000000000","message":"I\u0027ll add LOG.info() with informative message that will include the attempt number (i)","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":150,"context_line":"            \u0027 trigger \"413 over quota\" on Zone Export\u0027)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        LOG.info(\u0027Try to export Zone. Expected:\"413 over_quota\"\u0027)"},{"line_number":153,"context_line":"        with self.assertRaisesDns("},{"line_number":154,"context_line":"                lib_exc.OverLimit, \u0027over_quota\u0027, 413):"},{"line_number":155,"context_line":"            self.export_zone_client.create_zone_export(zone[\u0027id\u0027])"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ee355d2_f465926f","line":153,"updated":"2022-02-10 01:32:53.000000000","message":"So, this is an asynchronous API. You get 202 back here because it has accepted the export request.\nSubsequent calls to \"zone export show\" will indicate that the export went into ERROR because it was over the export quota.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":150,"context_line":"            \u0027 trigger \"413 over quota\" on Zone Export\u0027)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        LOG.info(\u0027Try to export Zone. Expected:\"413 over_quota\"\u0027)"},{"line_number":153,"context_line":"        with self.assertRaisesDns("},{"line_number":154,"context_line":"                lib_exc.OverLimit, \u0027over_quota\u0027, 413):"},{"line_number":155,"context_line":"            self.export_zone_client.create_zone_export(zone[\u0027id\u0027])"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ffc4d251_3f28f40f","line":153,"in_reply_to":"7ee355d2_f465926f","updated":"2022-02-10 13:21:20.000000000","message":"https://bugs.launchpad.net/designate/+bug/1960495 \nwill be used in \"decorators.skip_because\"","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            \u0027 trigger \"413 over quota\" on Zone Export\u0027)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        LOG.info(\u0027Try to export Zone. Expected:\"413 over_quota\"\u0027)"},{"line_number":153,"context_line":"        with self.assertRaisesDns("},{"line_number":154,"context_line":"                lib_exc.OverLimit, \u0027over_quota\u0027, 413):"},{"line_number":155,"context_line":"            self.export_zone_client.create_zone_export(zone[\u0027id\u0027])"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b1021c7b_7b48487b","line":153,"in_reply_to":"ffc4d251_3f28f40f","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        LOG.info(\u0027Create a Zone and wait until ACTIVE\u0027)"},{"line_number":169,"context_line":"        zone \u003d self.zone_client.create_zone("},{"line_number":170,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"},{"line_number":171,"context_line":"        self.addCleanup("},{"line_number":172,"context_line":"            self.wait_zone_delete,"},{"line_number":173,"context_line":"            self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"e396ffbd_857817bd","line":170,"updated":"2022-02-10 01:32:53.000000000","message":"Same, would be nice to have a description that tracks the test.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        LOG.info(\u0027Create a Zone and wait until ACTIVE\u0027)"},{"line_number":169,"context_line":"        zone \u003d self.zone_client.create_zone("},{"line_number":170,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"},{"line_number":171,"context_line":"        self.addCleanup("},{"line_number":172,"context_line":"            self.wait_zone_delete,"},{"line_number":173,"context_line":"            self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fcdf3290_3a34cc7b","line":170,"in_reply_to":"e396ffbd_857817bd","updated":"2022-02-10 13:21:20.000000000","message":"I\u0027ll use \"description\u003d\" on zone create","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        LOG.info(\u0027Create a Zone and wait until ACTIVE\u0027)"},{"line_number":169,"context_line":"        zone \u003d self.zone_client.create_zone("},{"line_number":170,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"},{"line_number":171,"context_line":"        self.addCleanup("},{"line_number":172,"context_line":"            self.wait_zone_delete,"},{"line_number":173,"context_line":"            self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"65b09165_f40adcc4","line":170,"in_reply_to":"fcdf3290_3a34cc7b","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":177,"context_line":"            \u0027 a recordset. Expected:\"413 over_quota\"\u0027.format("},{"line_number":178,"context_line":"                self.test_quota_limit + 1))"},{"line_number":179,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":180,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":181,"context_line":"            number_of_records\u003dself.test_quota_limit + 1)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        LOG.info(\u0027Ensure that the number of records in recordset is bigger\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"119a54c3_8fa86e1b","line":180,"updated":"2022-02-10 01:32:53.000000000","message":"Same, would be nice to have a description that tracks the test.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":177,"context_line":"            \u0027 a recordset. Expected:\"413 over_quota\"\u0027.format("},{"line_number":178,"context_line":"                self.test_quota_limit + 1))"},{"line_number":179,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":180,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":181,"context_line":"            number_of_records\u003dself.test_quota_limit + 1)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        LOG.info(\u0027Ensure that the number of records in recordset is bigger\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"416cb8ff_7f70a472","line":180,"in_reply_to":"119a54c3_8fa86e1b","updated":"2022-02-10 13:21:20.000000000","message":"We cannot add \"description\u003d\" to \"rand_recordset_data\", but since we\u0027ll have \"description\u003d\" in zone create + LOG messages that would be fine.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            \u0027 a recordset. Expected:\"413 over_quota\"\u0027.format("},{"line_number":178,"context_line":"                self.test_quota_limit + 1))"},{"line_number":179,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":180,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":181,"context_line":"            number_of_records\u003dself.test_quota_limit + 1)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        LOG.info(\u0027Ensure that the number of records in recordset is bigger\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"4a5d43f2_a7445124","line":180,"in_reply_to":"416cb8ff_7f70a472","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6387316352db77147fc6d4f6faf7e4bb07b1652a","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            \u0027 a recordset. Expected:\"413 over_quota\"\u0027.format("},{"line_number":178,"context_line":"                self.test_quota_limit + 1))"},{"line_number":179,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":180,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":181,"context_line":"            number_of_records\u003dself.test_quota_limit + 1)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        LOG.info(\u0027Ensure that the number of records in recordset is bigger\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"fb916756_fb387bc6","line":180,"in_reply_to":"4a5d43f2_a7445124","updated":"2022-02-10 18:22:08.000000000","message":"recordset_data is just a dict returned from rand_recordset_data, so you can easily add it after the rand_recordset_data:\nrecordset_data[\"description\"] \u003d \"qouta test xyz\"\nLog messages are not helpful here as those just go out to tempest.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        LOG.info(\u0027Ensure that the number of records in recordset is bigger\u0027"},{"line_number":184,"context_line":"                 \u0027 than configured \"recordset_records\"\u0027)"},{"line_number":185,"context_line":"        self.assertGreater("},{"line_number":186,"context_line":"            len(recordset_data[\u0027records\u0027]),"},{"line_number":187,"context_line":"            self.test_quota_limit,"},{"line_number":188,"context_line":"            \u0027Failed, the number of records in a recordset is not enough to\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"a3c32d85_f3e1d03b","line":185,"updated":"2022-02-10 01:32:53.000000000","message":"This seems unnecessary giving line 181.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        LOG.info(\u0027Ensure that the number of records in recordset is bigger\u0027"},{"line_number":184,"context_line":"                 \u0027 than configured \"recordset_records\"\u0027)"},{"line_number":185,"context_line":"        self.assertGreater("},{"line_number":186,"context_line":"            len(recordset_data[\u0027records\u0027]),"},{"line_number":187,"context_line":"            self.test_quota_limit,"},{"line_number":188,"context_line":"            \u0027Failed, the number of records in a recordset is not enough to\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"576edb6c_66ce687d","line":185,"in_reply_to":"63539464_62e6eed1","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        LOG.info(\u0027Ensure that the number of records in recordset is bigger\u0027"},{"line_number":184,"context_line":"                 \u0027 than configured \"recordset_records\"\u0027)"},{"line_number":185,"context_line":"        self.assertGreater("},{"line_number":186,"context_line":"            len(recordset_data[\u0027records\u0027]),"},{"line_number":187,"context_line":"            self.test_quota_limit,"},{"line_number":188,"context_line":"            \u0027Failed, the number of records in a recordset is not enough to\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"63539464_62e6eed1","line":185,"in_reply_to":"a3c32d85_f3e1d03b","updated":"2022-02-10 13:21:20.000000000","message":"Will be removed.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":199,"context_line":"    def test_zone_records_quota(self):"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        LOG.info(\u0027Create a Zone and wait until ACTIVE\u0027)"},{"line_number":202,"context_line":"        zone \u003d self.zone_client.create_zone(wait_until\u003dconst.ACTIVE)[1]"},{"line_number":203,"context_line":"        self.addCleanup("},{"line_number":204,"context_line":"            self.wait_zone_delete,"},{"line_number":205,"context_line":"            self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"c29a382c_639830ee","line":202,"updated":"2022-02-10 01:32:53.000000000","message":"Same, would be nice to have a description that tracks the test.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    def test_zone_records_quota(self):"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        LOG.info(\u0027Create a Zone and wait until ACTIVE\u0027)"},{"line_number":202,"context_line":"        zone \u003d self.zone_client.create_zone(wait_until\u003dconst.ACTIVE)[1]"},{"line_number":203,"context_line":"        self.addCleanup("},{"line_number":204,"context_line":"            self.wait_zone_delete,"},{"line_number":205,"context_line":"            self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"a1d7040f_9176b03f","line":202,"in_reply_to":"3507f5c9_87f41eb6","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":199,"context_line":"    def test_zone_records_quota(self):"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        LOG.info(\u0027Create a Zone and wait until ACTIVE\u0027)"},{"line_number":202,"context_line":"        zone \u003d self.zone_client.create_zone(wait_until\u003dconst.ACTIVE)[1]"},{"line_number":203,"context_line":"        self.addCleanup("},{"line_number":204,"context_line":"            self.wait_zone_delete,"},{"line_number":205,"context_line":"            self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3507f5c9_87f41eb6","line":202,"in_reply_to":"c29a382c_639830ee","updated":"2022-02-10 13:21:20.000000000","message":"I\u0027ll use \"description\u003d\" on zone create","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        LOG.info(\"Count the total number of existing records in existing\""},{"line_number":208,"context_line":"                 \" Zone\u0027s recordsets\")"},{"line_number":209,"context_line":"        records_number \u003d sum("},{"line_number":210,"context_line":"            [len(recordset[\u0027records\u0027]) for recordset in"},{"line_number":211,"context_line":"             self.recordset_client.list_recordset("},{"line_number":212,"context_line":"                 zone[\u0027id\u0027])[1][\u0027recordsets\u0027]])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ecd383e2_d55ffeb3","line":209,"updated":"2022-02-10 01:32:53.000000000","message":"Technically, \"managed\" records such as the SOA and NS records do not count against the quota. So, this number will be larger than the quota check will use.\nIf you intend to test n+1, this step can be skipped as you are creating the zone in line 202, so it will have zero recordsets that count against this quota.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        LOG.info(\"Count the total number of existing records in existing\""},{"line_number":208,"context_line":"                 \" Zone\u0027s recordsets\")"},{"line_number":209,"context_line":"        records_number \u003d sum("},{"line_number":210,"context_line":"            [len(recordset[\u0027records\u0027]) for recordset in"},{"line_number":211,"context_line":"             self.recordset_client.list_recordset("},{"line_number":212,"context_line":"                 zone[\u0027id\u0027])[1][\u0027recordsets\u0027]])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fc0b6552_68537f33","line":209,"in_reply_to":"ecd383e2_d55ffeb3","updated":"2022-02-10 13:21:20.000000000","message":"OK, I\u0027ll remove this kind of \"+2\" offset.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        LOG.info(\"Count the total number of existing records in existing\""},{"line_number":208,"context_line":"                 \" Zone\u0027s recordsets\")"},{"line_number":209,"context_line":"        records_number \u003d sum("},{"line_number":210,"context_line":"            [len(recordset[\u0027records\u0027]) for recordset in"},{"line_number":211,"context_line":"             self.recordset_client.list_recordset("},{"line_number":212,"context_line":"                 zone[\u0027id\u0027])[1][\u0027recordsets\u0027]])"}],"source_content_type":"text/x-python","patch_set":4,"id":"c6a3c59a_3932e110","line":209,"in_reply_to":"fc0b6552_68537f33","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":221,"context_line":"        LOG.info("},{"line_number":222,"context_line":"            \u0027Try to add:{} recordsets (with a single record) to the Zone in\u0027"},{"line_number":223,"context_line":"            \u0027 loop. Expected:\"413 over_quota\"\u0027.format("},{"line_number":224,"context_line":"                self.test_quota_limit + records_number + 1))"},{"line_number":225,"context_line":"        self._reach_quota_limit("},{"line_number":226,"context_line":"            self.test_quota_limit + records_number + 1, \u0027zone_records\u0027, zone)"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ad305a4a_7e9e59da","line":224,"updated":"2022-02-10 01:32:53.000000000","message":"See the comment above about removing \"records_number\" here.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        LOG.info("},{"line_number":222,"context_line":"            \u0027Try to add:{} recordsets (with a single record) to the Zone in\u0027"},{"line_number":223,"context_line":"            \u0027 loop. Expected:\"413 over_quota\"\u0027.format("},{"line_number":224,"context_line":"                self.test_quota_limit + records_number + 1))"},{"line_number":225,"context_line":"        self._reach_quota_limit("},{"line_number":226,"context_line":"            self.test_quota_limit + records_number + 1, \u0027zone_records\u0027, zone)"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"0b035a78_f8a998fe","line":224,"in_reply_to":"ad305a4a_7e9e59da","updated":"2022-02-10 13:21:20.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":230,"context_line":"    def test_zone_recordsets_quota(self):"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        LOG.info(\u0027Create a Zone and wait until ACTIVE\u0027)"},{"line_number":233,"context_line":"        zone \u003d self.zone_client.create_zone(wait_until\u003dconst.ACTIVE)[1]"},{"line_number":234,"context_line":"        self.addCleanup("},{"line_number":235,"context_line":"            self.wait_zone_delete,"},{"line_number":236,"context_line":"            self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"99ffb8f9_db35532e","line":233,"updated":"2022-02-10 01:32:53.000000000","message":"It would be nice to have a description field with the test name.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":230,"context_line":"    def test_zone_recordsets_quota(self):"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        LOG.info(\u0027Create a Zone and wait until ACTIVE\u0027)"},{"line_number":233,"context_line":"        zone \u003d self.zone_client.create_zone(wait_until\u003dconst.ACTIVE)[1]"},{"line_number":234,"context_line":"        self.addCleanup("},{"line_number":235,"context_line":"            self.wait_zone_delete,"},{"line_number":236,"context_line":"            self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"e1a757a5_93fc5bc0","line":233,"in_reply_to":"99ffb8f9_db35532e","updated":"2022-02-10 13:21:20.000000000","message":"I\u0027ll use \"description\u003d\" on zone create","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    def test_zone_recordsets_quota(self):"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        LOG.info(\u0027Create a Zone and wait until ACTIVE\u0027)"},{"line_number":233,"context_line":"        zone \u003d self.zone_client.create_zone(wait_until\u003dconst.ACTIVE)[1]"},{"line_number":234,"context_line":"        self.addCleanup("},{"line_number":235,"context_line":"            self.wait_zone_delete,"},{"line_number":236,"context_line":"            self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"4abc6e29_fbd008ea","line":233,"in_reply_to":"e1a757a5_93fc5bc0","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47c258044838c0d35ce0ce1097cb8743546790c9","unresolved":true,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        LOG.info(\"Count the total number of existing recordsets in Zone\")"},{"line_number":239,"context_line":"        recordsets_number \u003d len("},{"line_number":240,"context_line":"            [recordset for recordset in self.recordset_client.list_recordset("},{"line_number":241,"context_line":"                zone[\u0027id\u0027])[1][\u0027recordsets\u0027]])"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        LOG.info(\u0027Admin sets \"zone_recordsets:{}\" quota for Primary \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"cd4bc285_634a9dd0","line":240,"updated":"2022-02-10 01:32:53.000000000","message":"This is the same as above, since this is a new zone, and \"managed\" records don\u0027t count against quota, this should not be needed.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"143ee617e7c572e8612e9c96a552c0a8e63a2781","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        LOG.info(\"Count the total number of existing recordsets in Zone\")"},{"line_number":239,"context_line":"        recordsets_number \u003d len("},{"line_number":240,"context_line":"            [recordset for recordset in self.recordset_client.list_recordset("},{"line_number":241,"context_line":"                zone[\u0027id\u0027])[1][\u0027recordsets\u0027]])"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        LOG.info(\u0027Admin sets \"zone_recordsets:{}\" quota for Primary \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"34a98e35_13350d23","line":240,"in_reply_to":"7f4a778f_933baf5f","updated":"2022-02-10 13:21:55.000000000","message":"Done","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"de97e71e3b2bbc3211f66e3aec26071e6c179525","unresolved":true,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        LOG.info(\"Count the total number of existing recordsets in Zone\")"},{"line_number":239,"context_line":"        recordsets_number \u003d len("},{"line_number":240,"context_line":"            [recordset for recordset in self.recordset_client.list_recordset("},{"line_number":241,"context_line":"                zone[\u0027id\u0027])[1][\u0027recordsets\u0027]])"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        LOG.info(\u0027Admin sets \"zone_recordsets:{}\" quota for Primary \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f4a778f_933baf5f","line":240,"in_reply_to":"cd4bc285_634a9dd0","updated":"2022-02-10 13:21:20.000000000","message":"OK, I\u0027ll remove this kind of \"+2\" offset.","commit_id":"dc2e5d7620534d703428615c64f04164897d3958"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"10593c8aac6c4555f52924404efd7e82582d2258","unresolved":true,"context_lines":[{"line_number":140,"context_line":"            self.wait_zone_delete,"},{"line_number":141,"context_line":"            self.zone_client, zone[\u0027id\u0027])"},{"line_number":142,"context_line":"        for i in range(self.test_quota_limit + 1):"},{"line_number":143,"context_line":"            recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":144,"context_line":"                record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":145,"context_line":"            LOG.info(\u0027Try to create a recordset No:{}\u0027.format(i))"},{"line_number":146,"context_line":"            recordset \u003d self.recordset_client.create_recordset("}],"source_content_type":"text/x-python","patch_set":5,"id":"d26a0f1d_f48d6273","line":143,"updated":"2022-02-10 18:25:12.000000000","message":"recordset_data is just a dict returned from rand_recordset_data, so you can easily add it after the rand_recordset_data:\nrecordset_data[\"description\"] \u003d \"qouta test xyz\"\nLog messages are not helpful here as those just go out to tempest.","commit_id":"154767e9f48a55eeab85262e217e847be0f1dc3d"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"aa167a73e12b9e734dca371bbe73dd61ae02d978","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            self.wait_zone_delete,"},{"line_number":141,"context_line":"            self.zone_client, zone[\u0027id\u0027])"},{"line_number":142,"context_line":"        for i in range(self.test_quota_limit + 1):"},{"line_number":143,"context_line":"            recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":144,"context_line":"                record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":145,"context_line":"            LOG.info(\u0027Try to create a recordset No:{}\u0027.format(i))"},{"line_number":146,"context_line":"            recordset \u003d self.recordset_client.create_recordset("}],"source_content_type":"text/x-python","patch_set":5,"id":"80a87118_32616662","line":143,"in_reply_to":"d26a0f1d_f48d6273","updated":"2022-02-13 11:20:55.000000000","message":"Done","commit_id":"154767e9f48a55eeab85262e217e847be0f1dc3d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0f75c6997f7669cc5f535197864ffe3d80ef93e9","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":21,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import tempest.test"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from designate_tempest_plugin.tests import base"}],"source_content_type":"text/x-python","patch_set":9,"id":"b44c8d68_35123ab3","line":23,"updated":"2022-02-23 22:58:32.000000000","message":"These blank lines should not be here.","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"afee071b3fda0d5ef03b1d19f1fd431d9bcdc058","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":21,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import tempest.test"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from designate_tempest_plugin.tests import base"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff799207_14451b8b","line":23,"in_reply_to":"b44c8d68_35123ab3","updated":"2022-02-24 12:27:43.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0f75c6997f7669cc5f535197864ffe3d80ef93e9","unresolved":true,"context_lines":[{"line_number":89,"context_line":"                    self.addCleanup("},{"line_number":90,"context_line":"                        self.wait_zone_delete,"},{"line_number":91,"context_line":"                        self.zone_client, zone[\u0027id\u0027])"},{"line_number":92,"context_line":"                if quota_type !\u003d \"zones_quota\":"},{"line_number":93,"context_line":"                    if quota_type \u003d\u003d \u0027zone_recordsets\u0027:"},{"line_number":94,"context_line":"                        max_number_of_records \u003d 10"},{"line_number":95,"context_line":"                        prj_quota \u003d self.admin_client.show_quotas("}],"source_content_type":"text/x-python","patch_set":9,"id":"c617b78b_0ee790d6","line":92,"updated":"2022-02-23 22:58:32.000000000","message":"This could be just an else:","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"afee071b3fda0d5ef03b1d19f1fd431d9bcdc058","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                    self.addCleanup("},{"line_number":90,"context_line":"                        self.wait_zone_delete,"},{"line_number":91,"context_line":"                        self.zone_client, zone[\u0027id\u0027])"},{"line_number":92,"context_line":"                if quota_type !\u003d \"zones_quota\":"},{"line_number":93,"context_line":"                    if quota_type \u003d\u003d \u0027zone_recordsets\u0027:"},{"line_number":94,"context_line":"                        max_number_of_records \u003d 10"},{"line_number":95,"context_line":"                        prj_quota \u003d self.admin_client.show_quotas("}],"source_content_type":"text/x-python","patch_set":9,"id":"a16b3440_63dee7f3","line":92,"in_reply_to":"c617b78b_0ee790d6","updated":"2022-02-24 12:27:43.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0f75c6997f7669cc5f535197864ffe3d80ef93e9","unresolved":true,"context_lines":[{"line_number":100,"context_line":"                            max_number_of_records \u003d prj_quota"},{"line_number":101,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":102,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":103,"context_line":"                            number_of_records\u003drandom.randint("},{"line_number":104,"context_line":"                                1, max_number_of_records))"},{"line_number":105,"context_line":"                    else:"},{"line_number":106,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("}],"source_content_type":"text/x-python","patch_set":9,"id":"c2f76b4d_254bbc21","line":103,"updated":"2022-02-23 22:58:32.000000000","message":"I don\u0027t understand why we need a random number of records here.\nIsn\u0027t this supposed to be testing the recordsets in a zone quota?","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"afee071b3fda0d5ef03b1d19f1fd431d9bcdc058","unresolved":true,"context_lines":[{"line_number":100,"context_line":"                            max_number_of_records \u003d prj_quota"},{"line_number":101,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":102,"context_line":"                            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027],"},{"line_number":103,"context_line":"                            number_of_records\u003drandom.randint("},{"line_number":104,"context_line":"                                1, max_number_of_records))"},{"line_number":105,"context_line":"                    else:"},{"line_number":106,"context_line":"                        recordset_data \u003d dns_data_utils.rand_recordset_data("}],"source_content_type":"text/x-python","patch_set":9,"id":"c02ac31e_7a2592f9","line":103,"in_reply_to":"c2f76b4d_254bbc21","updated":"2022-02-24 12:27:43.000000000","message":"Yep, that\u0027s correct this is needed for testing the recordsets in a zone quota.\n\nI think that for testing recordsets quota in Zone it would be better that each recordset will be created with a different number of records.\n\nPerhaps records do impact somehow and they should not, as a tester I think that\u0027s this test logic is in place here.","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0f75c6997f7669cc5f535197864ffe3d80ef93e9","unresolved":true,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":176,"context_line":"    @decorators.idempotent_id(\u00272513cb6e-85ec-11ec-bf7f-201e8823901f\u0027)"},{"line_number":177,"context_line":"    @decorators.skip_because(bug\u003d\"1960497\")"},{"line_number":178,"context_line":"    def test_recordset_records_quota(self):"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        LOG.info(\u0027Admin sets \"recordset_records:{}\" quota for Primary\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"bd344ae2_cee8df91","line":177,"updated":"2022-02-23 22:58:32.000000000","message":"This fix has been released and the skip can be removed.","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"afee071b3fda0d5ef03b1d19f1fd431d9bcdc058","unresolved":true,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":176,"context_line":"    @decorators.idempotent_id(\u00272513cb6e-85ec-11ec-bf7f-201e8823901f\u0027)"},{"line_number":177,"context_line":"    @decorators.skip_because(bug\u003d\"1960497\")"},{"line_number":178,"context_line":"    def test_recordset_records_quota(self):"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        LOG.info(\u0027Admin sets \"recordset_records:{}\" quota for Primary\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"e21213c4_ec68a63e","line":177,"in_reply_to":"bd344ae2_cee8df91","updated":"2022-02-24 12:27:43.000000000","message":"OK, will be removed.","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"023f4671d31d484b59e835502308312e290efa75","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":176,"context_line":"    @decorators.idempotent_id(\u00272513cb6e-85ec-11ec-bf7f-201e8823901f\u0027)"},{"line_number":177,"context_line":"    @decorators.skip_because(bug\u003d\"1960497\")"},{"line_number":178,"context_line":"    def test_recordset_records_quota(self):"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        LOG.info(\u0027Admin sets \"recordset_records:{}\" quota for Primary\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"c67ac2d3_23554391","line":177,"in_reply_to":"e21213c4_ec68a63e","updated":"2022-06-14 13:24:16.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0f75c6997f7669cc5f535197864ffe3d80ef93e9","unresolved":true,"context_lines":[{"line_number":315,"context_line":"        super(QuotasBoundary, cls).resource_setup()"},{"line_number":316,"context_line":"        raise cls.skipException(\u0027Skip on bugs:1960495 1960497\u0027)"},{"line_number":317,"context_line":"        # Create a dedicated Project for Boundary tests"},{"line_number":318,"context_line":"        cls.tenant_id \u003d cls.project_client.create_project("},{"line_number":319,"context_line":"            name\u003ddata_utils.rand_name("},{"line_number":320,"context_line":"                name\u003d\u0027BoundaryQuotaTenant\u0027))[\u0027project\u0027][\u0027id\u0027]"},{"line_number":321,"context_line":"        cls.sudo_header \u003d {\u0027x-auth-sudo-project-id\u0027: cls.tenant_id}"}],"source_content_type":"text/x-python","patch_set":9,"id":"9417c010_c242b588","line":318,"updated":"2022-02-23 22:58:32.000000000","message":"We should not do this. We should use tempest credentials instead.\nWhy not just add a \"primary\" credential to this test suite and use that project_id?","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"afee071b3fda0d5ef03b1d19f1fd431d9bcdc058","unresolved":true,"context_lines":[{"line_number":315,"context_line":"        super(QuotasBoundary, cls).resource_setup()"},{"line_number":316,"context_line":"        raise cls.skipException(\u0027Skip on bugs:1960495 1960497\u0027)"},{"line_number":317,"context_line":"        # Create a dedicated Project for Boundary tests"},{"line_number":318,"context_line":"        cls.tenant_id \u003d cls.project_client.create_project("},{"line_number":319,"context_line":"            name\u003ddata_utils.rand_name("},{"line_number":320,"context_line":"                name\u003d\u0027BoundaryQuotaTenant\u0027))[\u0027project\u0027][\u0027id\u0027]"},{"line_number":321,"context_line":"        cls.sudo_header \u003d {\u0027x-auth-sudo-project-id\u0027: cls.tenant_id}"}],"source_content_type":"text/x-python","patch_set":9,"id":"a741a3a8_5480a91d","line":318,"in_reply_to":"9417c010_c242b588","updated":"2022-02-24 12:27:43.000000000","message":"Well, I have thought that scenario test (especially Boundary) must be very accurate and shouldn\u0027t be affected by any other test.\n\nIf I was using a primary instead, this would mean that any other test that is using a primary and running in parallel (tempest concurrency) could affect the quota test logic.\n\nAm I missing something?","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"023f4671d31d484b59e835502308312e290efa75","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        super(QuotasBoundary, cls).resource_setup()"},{"line_number":316,"context_line":"        raise cls.skipException(\u0027Skip on bugs:1960495 1960497\u0027)"},{"line_number":317,"context_line":"        # Create a dedicated Project for Boundary tests"},{"line_number":318,"context_line":"        cls.tenant_id \u003d cls.project_client.create_project("},{"line_number":319,"context_line":"            name\u003ddata_utils.rand_name("},{"line_number":320,"context_line":"                name\u003d\u0027BoundaryQuotaTenant\u0027))[\u0027project\u0027][\u0027id\u0027]"},{"line_number":321,"context_line":"        cls.sudo_header \u003d {\u0027x-auth-sudo-project-id\u0027: cls.tenant_id}"}],"source_content_type":"text/x-python","patch_set":9,"id":"d15983c4_4eeaaa4d","line":318,"in_reply_to":"a741a3a8_5480a91d","updated":"2022-06-14 13:24:16.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0f75c6997f7669cc5f535197864ffe3d80ef93e9","unresolved":true,"context_lines":[{"line_number":329,"context_line":"            headers\u003dcls.sudo_header)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        # Create Zone \"A\""},{"line_number":332,"context_line":"        cls.zone \u003d cls.zone_client.create_zone("},{"line_number":333,"context_line":"            description\u003d\u0027Zone \"A\" created in SetUp\u0027,"},{"line_number":334,"context_line":"            project_id\u003dcls.tenant_id,"},{"line_number":335,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"}],"source_content_type":"text/x-python","patch_set":9,"id":"8e7ad403_ec8673ed","line":332,"updated":"2022-02-23 22:58:32.000000000","message":"This is missing the addClassResourceCleanup to cleanup the zone after this test suite is complete.","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"023f4671d31d484b59e835502308312e290efa75","unresolved":false,"context_lines":[{"line_number":329,"context_line":"            headers\u003dcls.sudo_header)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        # Create Zone \"A\""},{"line_number":332,"context_line":"        cls.zone \u003d cls.zone_client.create_zone("},{"line_number":333,"context_line":"            description\u003d\u0027Zone \"A\" created in SetUp\u0027,"},{"line_number":334,"context_line":"            project_id\u003dcls.tenant_id,"},{"line_number":335,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a446361_fa62fa03","line":332,"in_reply_to":"3a8d6133_b20efdd8","updated":"2022-06-14 13:24:16.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"afee071b3fda0d5ef03b1d19f1fd431d9bcdc058","unresolved":true,"context_lines":[{"line_number":329,"context_line":"            headers\u003dcls.sudo_header)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        # Create Zone \"A\""},{"line_number":332,"context_line":"        cls.zone \u003d cls.zone_client.create_zone("},{"line_number":333,"context_line":"            description\u003d\u0027Zone \"A\" created in SetUp\u0027,"},{"line_number":334,"context_line":"            project_id\u003dcls.tenant_id,"},{"line_number":335,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a8d6133_b20efdd8","line":332,"in_reply_to":"8e7ad403_ec8673ed","updated":"2022-02-24 12:27:43.000000000","message":"OK, I\u0027m going to remove the whole \"QuotasBoundary\" in my next patchset.\nThis patch seems to be long enough withot this.\n\nOnce we\u0027ll have this initial quota scenario tests merged I\u0027ll start working on \"QuotasBoundary\" by taking to the consideration all your comments.","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0f75c6997f7669cc5f535197864ffe3d80ef93e9","unresolved":true,"context_lines":[{"line_number":337,"context_line":"        # Add Recordset to zone \"A\""},{"line_number":338,"context_line":"        cls.recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":339,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dcls.zone[\u0027name\u0027])"},{"line_number":340,"context_line":"        cls.recordset \u003d cls.recordset_client.create_recordset("},{"line_number":341,"context_line":"            cls.zone[\u0027id\u0027], recordset_data\u003dcls.recordset_data,"},{"line_number":342,"context_line":"            headers\u003dcls.sudo_header,"},{"line_number":343,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"}],"source_content_type":"text/x-python","patch_set":9,"id":"9750ffac_614a2562","line":340,"updated":"2022-02-23 22:58:32.000000000","message":"This is missing the addClassResourceCleanup to cleanup the recordset after this test suite is complete.","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"023f4671d31d484b59e835502308312e290efa75","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        # Add Recordset to zone \"A\""},{"line_number":338,"context_line":"        cls.recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":339,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dcls.zone[\u0027name\u0027])"},{"line_number":340,"context_line":"        cls.recordset \u003d cls.recordset_client.create_recordset("},{"line_number":341,"context_line":"            cls.zone[\u0027id\u0027], recordset_data\u003dcls.recordset_data,"},{"line_number":342,"context_line":"            headers\u003dcls.sudo_header,"},{"line_number":343,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"}],"source_content_type":"text/x-python","patch_set":9,"id":"445bf93f_d0ea659a","line":340,"in_reply_to":"16e5f9ac_dc6523f8","updated":"2022-06-14 13:24:16.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"afee071b3fda0d5ef03b1d19f1fd431d9bcdc058","unresolved":true,"context_lines":[{"line_number":337,"context_line":"        # Add Recordset to zone \"A\""},{"line_number":338,"context_line":"        cls.recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":339,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dcls.zone[\u0027name\u0027])"},{"line_number":340,"context_line":"        cls.recordset \u003d cls.recordset_client.create_recordset("},{"line_number":341,"context_line":"            cls.zone[\u0027id\u0027], recordset_data\u003dcls.recordset_data,"},{"line_number":342,"context_line":"            headers\u003dcls.sudo_header,"},{"line_number":343,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"}],"source_content_type":"text/x-python","patch_set":9,"id":"16e5f9ac_dc6523f8","line":340,"in_reply_to":"9750ffac_614a2562","updated":"2022-02-24 12:27:43.000000000","message":"See L332","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0f75c6997f7669cc5f535197864ffe3d80ef93e9","unresolved":true,"context_lines":[{"line_number":343,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    @classmethod"},{"line_number":346,"context_line":"    def resource_cleanup(cls):"},{"line_number":347,"context_line":"        cls.quota_client.delete_quotas("},{"line_number":348,"context_line":"            project_id\u003dcls.tenant_id, headers\u003dcls.sudo_header)"},{"line_number":349,"context_line":"        cls.recordset_client.delete_recordset("}],"source_content_type":"text/x-python","patch_set":9,"id":"5f088c1e_924d4230","line":346,"updated":"2022-02-23 22:58:32.000000000","message":"This is not an \"official\" setUp class phase in tempest. We should not use it directly.\nhttps://docs.openstack.org/tempest/latest/write_tests.html#setupclass","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"023f4671d31d484b59e835502308312e290efa75","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    @classmethod"},{"line_number":346,"context_line":"    def resource_cleanup(cls):"},{"line_number":347,"context_line":"        cls.quota_client.delete_quotas("},{"line_number":348,"context_line":"            project_id\u003dcls.tenant_id, headers\u003dcls.sudo_header)"},{"line_number":349,"context_line":"        cls.recordset_client.delete_recordset("}],"source_content_type":"text/x-python","patch_set":9,"id":"a5b52687_9caeed40","line":346,"in_reply_to":"0b19d99d_0bac1257","updated":"2022-06-14 13:24:16.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"afee071b3fda0d5ef03b1d19f1fd431d9bcdc058","unresolved":true,"context_lines":[{"line_number":343,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    @classmethod"},{"line_number":346,"context_line":"    def resource_cleanup(cls):"},{"line_number":347,"context_line":"        cls.quota_client.delete_quotas("},{"line_number":348,"context_line":"            project_id\u003dcls.tenant_id, headers\u003dcls.sudo_header)"},{"line_number":349,"context_line":"        cls.recordset_client.delete_recordset("}],"source_content_type":"text/x-python","patch_set":9,"id":"0b19d99d_0bac1257","line":346,"in_reply_to":"5f088c1e_924d4230","updated":"2022-02-24 12:27:43.000000000","message":"See L332","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0f75c6997f7669cc5f535197864ffe3d80ef93e9","unresolved":true,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":376,"context_line":"    @decorators.idempotent_id(\u002767720c8c-8cc2-11ec-b65b-201e8823901f\u0027)"},{"line_number":377,"context_line":"    def test_boundary_limit_all_quota_types(self):"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        # Boundary for \"zones\" quota --\u003e [zones:2]"},{"line_number":380,"context_line":"        LOG.info(\u0027Create Zone \"B\", should PASS\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3bf9c9dc_cf1e56d3","line":377,"updated":"2022-02-23 22:58:32.000000000","message":"It seems like these should either be split out into individual tests or just added to the test cases above.","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"afee071b3fda0d5ef03b1d19f1fd431d9bcdc058","unresolved":true,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":376,"context_line":"    @decorators.idempotent_id(\u002767720c8c-8cc2-11ec-b65b-201e8823901f\u0027)"},{"line_number":377,"context_line":"    def test_boundary_limit_all_quota_types(self):"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        # Boundary for \"zones\" quota --\u003e [zones:2]"},{"line_number":380,"context_line":"        LOG.info(\u0027Create Zone \"B\", should PASS\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"c57933c4_45afc2bb","line":377,"in_reply_to":"3bf9c9dc_cf1e56d3","updated":"2022-02-24 12:27:43.000000000","message":"See L332","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"023f4671d31d484b59e835502308312e290efa75","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":376,"context_line":"    @decorators.idempotent_id(\u002767720c8c-8cc2-11ec-b65b-201e8823901f\u0027)"},{"line_number":377,"context_line":"    def test_boundary_limit_all_quota_types(self):"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        # Boundary for \"zones\" quota --\u003e [zones:2]"},{"line_number":380,"context_line":"        LOG.info(\u0027Create Zone \"B\", should PASS\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"8ba691a7_9b871d14","line":377,"in_reply_to":"c57933c4_45afc2bb","updated":"2022-06-14 13:24:16.000000000","message":"Done","commit_id":"4398a347ed0b4ab991248564f6eb8b94a5f67a4f"}]}