)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"724b3936a1e3a82ffe84162a20df131587cf73cb","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Adding new test case for zone test suite"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) test_serial_changes_on_update"},{"line_number":10,"context_line":"   Update values in zone and expect Serial to be changed"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7461326d795221c1da4b7ac627d1ffec7c9212df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f2834d86_8ebc73c3","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":24},"updated":"2022-02-10 18:53:31.000000000","message":"Test Scenario:\n  Update Zone\u0027s fields: Email, TTL and Description\n  Validate that the Serial is changed only for TTL and Email\n  Note: The description is a metadata field only known to Designate.","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"eb56dbd24e776c8fcbfac9438d5a2bc39f905d4f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding new test case for zone test suite"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) test_serial_changes_on_update"},{"line_number":10,"context_line":"   Update values in zone and expect Serial to be changed"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7461326d795221c1da4b7ac627d1ffec7c9212df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"913f3ed4_17df9b2f","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":24},"in_reply_to":"f2834d86_8ebc73c3","updated":"2022-02-16 10:54:57.000000000","message":"Done","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0c1116f3a4b5184bb945d0f5d0eb7e97eb3c4b65","unresolved":true,"context_lines":[{"line_number":12,"context_line":"        # Update TTL - Serial has changed"},{"line_number":13,"context_line":"        # Update Combination (Email+Description) - Serial has changed"},{"line_number":14,"context_line":"        # Update Description - Serial remained the same"},{"line_number":15,"context_line":"   Note: The Description is a metadata filed only known to Designate"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7461326d795221c1da4b7ac627d1ffec7c9212df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9c73f89d_4af18962","line":15,"range":{"start_line":15,"start_character":39,"end_line":15,"end_character":44},"updated":"2022-02-16 15:18:31.000000000","message":"field","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        # Update TTL - Serial has changed"},{"line_number":13,"context_line":"        # Update Combination (Email+Description) - Serial has changed"},{"line_number":14,"context_line":"        # Update Description - Serial remained the same"},{"line_number":15,"context_line":"   Note: The Description is a metadata filed only known to Designate"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7461326d795221c1da4b7ac627d1ffec7c9212df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"28077f0b_d6c66d62","line":15,"range":{"start_line":15,"start_character":39,"end_line":15,"end_character":44},"in_reply_to":"9c73f89d_4af18962","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"7e0ca69df2069a3f62932406626e8827b3fcbb29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"14396cb9_00408dcc","updated":"2022-02-11 21:06:26.000000000","message":"See comments, probably should be using the wait_until option on the create_zone client.","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"724b3936a1e3a82ffe84162a20df131587cf73cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9828173e_a651acde","updated":"2022-02-10 18:53:31.000000000","message":"This would be a proper logic for this test.\n\n1) Update TTL --\u003e Serial has changed\n2) Update Email --\u003e Serial has changed\n3) Update Description --\u003e Serial remained the same\n4) Update TTL + Description --\u003e Serial has changed\n\nBTW - consider replacing all string like \"ACTIVE\", \"PENDING\" ... to const.ACTIVE e.t.c. in all the existing tests + yours new test case, as you\u0027ve already done in you previous patch.","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0c1116f3a4b5184bb945d0f5d0eb7e97eb3c4b65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"70f70395_147bc228","updated":"2022-02-16 15:18:31.000000000","message":"1) Some minor stuff: grammar, indentation e.t.c. are needed to be fixed.\n2) Now, when I look at your code one more time it seems to me that the better practice for this test case, would be changing the \"if elif elif else\" statement to a simple \"4 * if\" 😞","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fd39e6535d54ccbee9fb45ced72a0a79ec74fa79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c31920c6_c15361c8","updated":"2022-02-16 12:15:25.000000000","message":"recheck","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"eb56dbd24e776c8fcbfac9438d5a2bc39f905d4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d3ef3939_ede5b102","updated":"2022-02-16 10:54:57.000000000","message":"recheck","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8e2161d50295ec38b8d2d3fd5396a7d6826095bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"76230836_a9bf8491","updated":"2022-02-23 23:06:21.000000000","message":"This test isn\u0027t correctly testing the scenario.","commit_id":"968550bf209a1547a78467c2d3055fa0c26544e2"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"4f4bf56d41478835e10b49899fef34ccb507df5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2a073080_ae2c1a44","updated":"2022-02-27 13:12:52.000000000","message":"recheck","commit_id":"b1b2f81171a61275d844180c81748dcf3ac1408f"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"456c41e6aff768b7366e0c0561f0545b1960f233","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"855dca62_2affeba1","updated":"2022-02-27 14:40:06.000000000","message":"recheck","commit_id":"b1b2f81171a61275d844180c81748dcf3ac1408f"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"314373aa2014754d653be9f690512d95f1586da5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9edd413e_f425cb6c","updated":"2022-02-27 12:05:24.000000000","message":"recheck","commit_id":"b1b2f81171a61275d844180c81748dcf3ac1408f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"782a1725a5dae990b6cbcacbf430dce1b903b6a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c6347e42_a334e43e","updated":"2022-03-01 01:10:22.000000000","message":"LGTM","commit_id":"10eaa470f2f492e4fe1280fb19c24fdb7746b120"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"bd843a8def2259676f3ac4745b03e4275358c4e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9564cd47_e7983da9","updated":"2022-02-28 19:40:24.000000000","message":"recheck","commit_id":"10eaa470f2f492e4fe1280fb19c24fdb7746b120"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0df32361ac548670ed6ccc6400d605f6f5584ff6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2c35c5d4_30dc96d1","updated":"2022-05-06 17:48:14.000000000","message":"LGTM","commit_id":"ceb0c0e64d60ab2d997eb5acaa488324d94b519d"}],"designate_tempest_plugin/tests/api/v2/test_zones.py":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"7e0ca69df2069a3f62932406626e8827b3fcbb29","unresolved":true,"context_lines":[{"line_number":24,"context_line":"from designate_tempest_plugin import data_utils as dns_data_utils"},{"line_number":25,"context_line":"from designate_tempest_plugin.tests import base"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from designate_tempest_plugin.common import waiters"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d config.CONF"},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4ec6f855_83b01d3f","line":27,"updated":"2022-02-11 21:06:26.000000000","message":"Assuming you\u0027ll be using the wait_until parameter of the zone_client \u0027wait_until\u0027, this can be removed.","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"eb56dbd24e776c8fcbfac9438d5a2bc39f905d4f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from designate_tempest_plugin import data_utils as dns_data_utils"},{"line_number":25,"context_line":"from designate_tempest_plugin.tests import base"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from designate_tempest_plugin.common import waiters"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d config.CONF"},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"86e368d2_5a6fa06e","line":27,"in_reply_to":"4ec6f855_83b01d3f","updated":"2022-02-16 10:54:57.000000000","message":"Done","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"7e0ca69df2069a3f62932406626e8827b3fcbb29","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(\u0027PENDING\u0027, zone[\u0027status\u0027])"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        LOG.info(\u0027Wait till the zone is Active\u0027)"},{"line_number":94,"context_line":"        waiters.wait_for_zone_status(self.client, zone[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        LOG.info(\u0027Ensure that SOA and NS recordsets types has been created.\u0027)"},{"line_number":97,"context_line":"        recordsets \u003d self.recordset_client.list_recordset("}],"source_content_type":"text/x-python","patch_set":2,"id":"0845a56c_6e05113f","line":94,"updated":"2022-02-11 21:06:26.000000000","message":"Probably should be using the wait_until parameter on the create_zone client.","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"eb56dbd24e776c8fcbfac9438d5a2bc39f905d4f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(\u0027PENDING\u0027, zone[\u0027status\u0027])"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        LOG.info(\u0027Wait till the zone is Active\u0027)"},{"line_number":94,"context_line":"        waiters.wait_for_zone_status(self.client, zone[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        LOG.info(\u0027Ensure that SOA and NS recordsets types has been created.\u0027)"},{"line_number":97,"context_line":"        recordsets \u003d self.recordset_client.list_recordset("}],"source_content_type":"text/x-python","patch_set":2,"id":"2699cac6_ded4eced","line":94,"in_reply_to":"0845a56c_6e05113f","updated":"2022-02-16 10:54:57.000000000","message":"Done","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"724b3936a1e3a82ffe84162a20df131587cf73cb","unresolved":true,"context_lines":[{"line_number":186,"context_line":"    @decorators.skip_because(bug\u003d\"1950118\")"},{"line_number":187,"context_line":"    def test_serial_changes_on_update(self):"},{"line_number":188,"context_line":"        LOG.info(\u0027Create a zone\u0027)"},{"line_number":189,"context_line":"        _, create_zone \u003d self.client.create_zone()"},{"line_number":190,"context_line":"        self.addCleanup(self.wait_zone_delete, self.client, create_zone[\u0027id\u0027])"},{"line_number":191,"context_line":"        waiters.wait_for_zone_status("},{"line_number":192,"context_line":"            self.client, create_zone[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2bfb6c20_fdfecb6e","line":189,"range":{"start_line":189,"start_character":8,"end_line":189,"end_character":10},"updated":"2022-02-10 18:53:31.000000000","message":"Avoid using \"_\" use indexing instead.","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"eb56dbd24e776c8fcbfac9438d5a2bc39f905d4f","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    @decorators.skip_because(bug\u003d\"1950118\")"},{"line_number":187,"context_line":"    def test_serial_changes_on_update(self):"},{"line_number":188,"context_line":"        LOG.info(\u0027Create a zone\u0027)"},{"line_number":189,"context_line":"        _, create_zone \u003d self.client.create_zone()"},{"line_number":190,"context_line":"        self.addCleanup(self.wait_zone_delete, self.client, create_zone[\u0027id\u0027])"},{"line_number":191,"context_line":"        waiters.wait_for_zone_status("},{"line_number":192,"context_line":"            self.client, create_zone[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4f90c7b8_40c980a5","line":189,"range":{"start_line":189,"start_character":8,"end_line":189,"end_character":10},"in_reply_to":"2bfb6c20_fdfecb6e","updated":"2022-02-16 10:54:57.000000000","message":"Done","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"724b3936a1e3a82ffe84162a20df131587cf73cb","unresolved":true,"context_lines":[{"line_number":188,"context_line":"        LOG.info(\u0027Create a zone\u0027)"},{"line_number":189,"context_line":"        _, create_zone \u003d self.client.create_zone()"},{"line_number":190,"context_line":"        self.addCleanup(self.wait_zone_delete, self.client, create_zone[\u0027id\u0027])"},{"line_number":191,"context_line":"        waiters.wait_for_zone_status("},{"line_number":192,"context_line":"            self.client, create_zone[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        LOG.info(\u0027Update the zone\u0027)"},{"line_number":195,"context_line":"        email \u003d dns_data_utils.rand_email()"}],"source_content_type":"text/x-python","patch_set":2,"id":"cc8f028e_c8dd3938","line":192,"range":{"start_line":191,"start_character":0,"end_line":192,"end_character":53},"updated":"2022-02-10 18:53:31.000000000","message":"You can remove this and to use \"wait_until\" in L189","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"eb56dbd24e776c8fcbfac9438d5a2bc39f905d4f","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        LOG.info(\u0027Create a zone\u0027)"},{"line_number":189,"context_line":"        _, create_zone \u003d self.client.create_zone()"},{"line_number":190,"context_line":"        self.addCleanup(self.wait_zone_delete, self.client, create_zone[\u0027id\u0027])"},{"line_number":191,"context_line":"        waiters.wait_for_zone_status("},{"line_number":192,"context_line":"            self.client, create_zone[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        LOG.info(\u0027Update the zone\u0027)"},{"line_number":195,"context_line":"        email \u003d dns_data_utils.rand_email()"}],"source_content_type":"text/x-python","patch_set":2,"id":"910e31e0_ad065d82","line":192,"range":{"start_line":191,"start_character":0,"end_line":192,"end_character":53},"in_reply_to":"cc8f028e_c8dd3938","updated":"2022-02-16 10:54:57.000000000","message":"Done","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"724b3936a1e3a82ffe84162a20df131587cf73cb","unresolved":true,"context_lines":[{"line_number":197,"context_line":"        description \u003d data_utils.rand_name()"},{"line_number":198,"context_line":"        _, update_zone \u003d self.client.update_zone("},{"line_number":199,"context_line":"            create_zone[\u0027id\u0027], email\u003demail, ttl\u003dttl, description\u003ddescription)"},{"line_number":200,"context_line":"        waiters.wait_for_zone_status("},{"line_number":201,"context_line":"            self.client, update_zone[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        LOG.info(\u0027Ensure we respond with updated values\u0027)"},{"line_number":204,"context_line":"        self.assertEqual(email, update_zone[\u0027email\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"720c250d_1ba5a43c","line":201,"range":{"start_line":200,"start_character":0,"end_line":201,"end_character":53},"updated":"2022-02-10 18:53:31.000000000","message":"Same as in L191, you use \"wait_until\" in update_zone","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"eb56dbd24e776c8fcbfac9438d5a2bc39f905d4f","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        description \u003d data_utils.rand_name()"},{"line_number":198,"context_line":"        _, update_zone \u003d self.client.update_zone("},{"line_number":199,"context_line":"            create_zone[\u0027id\u0027], email\u003demail, ttl\u003dttl, description\u003ddescription)"},{"line_number":200,"context_line":"        waiters.wait_for_zone_status("},{"line_number":201,"context_line":"            self.client, update_zone[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        LOG.info(\u0027Ensure we respond with updated values\u0027)"},{"line_number":204,"context_line":"        self.assertEqual(email, update_zone[\u0027email\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"c8ca1cbe_cf5885dc","line":201,"range":{"start_line":200,"start_character":0,"end_line":201,"end_character":53},"in_reply_to":"720c250d_1ba5a43c","updated":"2022-02-16 10:54:57.000000000","message":"Done","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"724b3936a1e3a82ffe84162a20df131587cf73cb","unresolved":true,"context_lines":[{"line_number":204,"context_line":"        self.assertEqual(email, update_zone[\u0027email\u0027])"},{"line_number":205,"context_line":"        self.assertEqual(ttl, update_zone[\u0027ttl\u0027])"},{"line_number":206,"context_line":"        self.assertEqual(description, update_zone[\u0027description\u0027])"},{"line_number":207,"context_line":"        self.assertNotEqual(create_zone[\u0027serial\u0027], update_zone[\u0027serial\u0027])"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @decorators.idempotent_id(\u0027e391e30a-92e0-11eb-9d02-74e5f9e2a801\u0027)"},{"line_number":210,"context_line":"    def test_update_non_existing_zone(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"b600971a_d952e074","line":207,"updated":"2022-02-10 18:53:31.000000000","message":"It would be nice to have the assertion message here.","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"724b3936a1e3a82ffe84162a20df131587cf73cb","unresolved":true,"context_lines":[{"line_number":201,"context_line":"            self.client, update_zone[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        LOG.info(\u0027Ensure we respond with updated values\u0027)"},{"line_number":204,"context_line":"        self.assertEqual(email, update_zone[\u0027email\u0027])"},{"line_number":205,"context_line":"        self.assertEqual(ttl, update_zone[\u0027ttl\u0027])"},{"line_number":206,"context_line":"        self.assertEqual(description, update_zone[\u0027description\u0027])"},{"line_number":207,"context_line":"        self.assertNotEqual(create_zone[\u0027serial\u0027], update_zone[\u0027serial\u0027])"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @decorators.idempotent_id(\u0027e391e30a-92e0-11eb-9d02-74e5f9e2a801\u0027)"},{"line_number":210,"context_line":"    def test_update_non_existing_zone(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"c7d3e58e_a944f6df","line":207,"range":{"start_line":204,"start_character":0,"end_line":207,"end_character":73},"updated":"2022-02-10 18:53:31.000000000","message":"The only purpose of this specific test is to validate \"Serial\" changes, the rest is already covered and not needed here.","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"eb56dbd24e776c8fcbfac9438d5a2bc39f905d4f","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        self.assertEqual(email, update_zone[\u0027email\u0027])"},{"line_number":205,"context_line":"        self.assertEqual(ttl, update_zone[\u0027ttl\u0027])"},{"line_number":206,"context_line":"        self.assertEqual(description, update_zone[\u0027description\u0027])"},{"line_number":207,"context_line":"        self.assertNotEqual(create_zone[\u0027serial\u0027], update_zone[\u0027serial\u0027])"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @decorators.idempotent_id(\u0027e391e30a-92e0-11eb-9d02-74e5f9e2a801\u0027)"},{"line_number":210,"context_line":"    def test_update_non_existing_zone(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae24392_a46c2943","line":207,"in_reply_to":"b600971a_d952e074","updated":"2022-02-16 10:54:57.000000000","message":"Done","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"eb56dbd24e776c8fcbfac9438d5a2bc39f905d4f","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            self.client, update_zone[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        LOG.info(\u0027Ensure we respond with updated values\u0027)"},{"line_number":204,"context_line":"        self.assertEqual(email, update_zone[\u0027email\u0027])"},{"line_number":205,"context_line":"        self.assertEqual(ttl, update_zone[\u0027ttl\u0027])"},{"line_number":206,"context_line":"        self.assertEqual(description, update_zone[\u0027description\u0027])"},{"line_number":207,"context_line":"        self.assertNotEqual(create_zone[\u0027serial\u0027], update_zone[\u0027serial\u0027])"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @decorators.idempotent_id(\u0027e391e30a-92e0-11eb-9d02-74e5f9e2a801\u0027)"},{"line_number":210,"context_line":"    def test_update_non_existing_zone(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"83c17e5c_b8aaa5c3","line":207,"range":{"start_line":204,"start_character":0,"end_line":207,"end_character":73},"in_reply_to":"c7d3e58e_a944f6df","updated":"2022-02-16 10:54:57.000000000","message":"Done","commit_id":"fa90cb551a84c656319440963773cd58b5f6a4a9"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0c1116f3a4b5184bb945d0f5d0eb7e97eb3c4b65","unresolved":true,"context_lines":[{"line_number":188,"context_line":"            if option \u003d\u003d \"email\":"},{"line_number":189,"context_line":"                update_email \u003d self.client.update_zone("},{"line_number":190,"context_line":"                    create_zone[\u0027id\u0027], email\u003ddns_data_utils.rand_email())[1]"},{"line_number":191,"context_line":"                LOG.info(\u0027Ensure that the Serial is changed\u0027)"},{"line_number":192,"context_line":"                self.assertNotEqual(create_zone[\u0027serial\u0027],"},{"line_number":193,"context_line":"                                    update_email[\u0027serial\u0027],"},{"line_number":194,"context_line":"                                    \"Failed, expect the Serial to change \""}],"source_content_type":"text/x-python","patch_set":4,"id":"ae173f8f_7f388cd3","line":191,"range":{"start_line":191,"start_character":0,"end_line":191,"end_character":61},"updated":"2022-02-16 15:18:31.000000000","message":"Looks like the assertion message only would be enough.","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            if option \u003d\u003d \"email\":"},{"line_number":189,"context_line":"                update_email \u003d self.client.update_zone("},{"line_number":190,"context_line":"                    create_zone[\u0027id\u0027], email\u003ddns_data_utils.rand_email())[1]"},{"line_number":191,"context_line":"                LOG.info(\u0027Ensure that the Serial is changed\u0027)"},{"line_number":192,"context_line":"                self.assertNotEqual(create_zone[\u0027serial\u0027],"},{"line_number":193,"context_line":"                                    update_email[\u0027serial\u0027],"},{"line_number":194,"context_line":"                                    \"Failed, expect the Serial to change \""}],"source_content_type":"text/x-python","patch_set":4,"id":"49da9b95_c6efcd0c","line":191,"range":{"start_line":191,"start_character":0,"end_line":191,"end_character":61},"in_reply_to":"ae173f8f_7f388cd3","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0c1116f3a4b5184bb945d0f5d0eb7e97eb3c4b65","unresolved":true,"context_lines":[{"line_number":189,"context_line":"                update_email \u003d self.client.update_zone("},{"line_number":190,"context_line":"                    create_zone[\u0027id\u0027], email\u003ddns_data_utils.rand_email())[1]"},{"line_number":191,"context_line":"                LOG.info(\u0027Ensure that the Serial is changed\u0027)"},{"line_number":192,"context_line":"                self.assertNotEqual(create_zone[\u0027serial\u0027],"},{"line_number":193,"context_line":"                                    update_email[\u0027serial\u0027],"},{"line_number":194,"context_line":"                                    \"Failed, expect the Serial to change \""},{"line_number":195,"context_line":"                                    \"when the Email is updated\""},{"line_number":196,"context_line":"                                    )"},{"line_number":197,"context_line":"            elif option \u003d\u003d \"ttl\":"},{"line_number":198,"context_line":"                update_ttl \u003d self.client.update_zone("},{"line_number":199,"context_line":"                    create_zone[\u0027id\u0027], ttl\u003ddns_data_utils.rand_ttl())[1]"}],"source_content_type":"text/x-python","patch_set":4,"id":"e61a6ef2_fc935022","line":196,"range":{"start_line":192,"start_character":0,"end_line":196,"end_character":37},"updated":"2022-02-16 15:18:31.000000000","message":"Nit\n\n1) Indentation \nself.assertNotEqual(\n    create_zone[\u0027serial\u0027], update_email[\u0027serial\u0027],\n    \"Failed, expect the Serial to change when the Email is updated\"\n\n2) Grammar\n   Failed, expected: \u0027Serial\u0027 is supposed to be changed on Email update.","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                update_email \u003d self.client.update_zone("},{"line_number":190,"context_line":"                    create_zone[\u0027id\u0027], email\u003ddns_data_utils.rand_email())[1]"},{"line_number":191,"context_line":"                LOG.info(\u0027Ensure that the Serial is changed\u0027)"},{"line_number":192,"context_line":"                self.assertNotEqual(create_zone[\u0027serial\u0027],"},{"line_number":193,"context_line":"                                    update_email[\u0027serial\u0027],"},{"line_number":194,"context_line":"                                    \"Failed, expect the Serial to change \""},{"line_number":195,"context_line":"                                    \"when the Email is updated\""},{"line_number":196,"context_line":"                                    )"},{"line_number":197,"context_line":"            elif option \u003d\u003d \"ttl\":"},{"line_number":198,"context_line":"                update_ttl \u003d self.client.update_zone("},{"line_number":199,"context_line":"                    create_zone[\u0027id\u0027], ttl\u003ddns_data_utils.rand_ttl())[1]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a967d62_7eca10f5","line":196,"range":{"start_line":192,"start_character":0,"end_line":196,"end_character":37},"in_reply_to":"e61a6ef2_fc935022","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0c1116f3a4b5184bb945d0f5d0eb7e97eb3c4b65","unresolved":true,"context_lines":[{"line_number":197,"context_line":"            elif option \u003d\u003d \"ttl\":"},{"line_number":198,"context_line":"                update_ttl \u003d self.client.update_zone("},{"line_number":199,"context_line":"                    create_zone[\u0027id\u0027], ttl\u003ddns_data_utils.rand_ttl())[1]"},{"line_number":200,"context_line":"                LOG.info(\u0027Ensure that the Serial is changed\u0027)"},{"line_number":201,"context_line":"                self.assertNotEqual("},{"line_number":202,"context_line":"                    create_zone[\u0027serial\u0027], update_ttl[\u0027serial\u0027],"},{"line_number":203,"context_line":"                    \"Failed, expect the Serial to change \""}],"source_content_type":"text/x-python","patch_set":4,"id":"789a37d7_0c0c8f77","line":200,"range":{"start_line":200,"start_character":0,"end_line":200,"end_character":61},"updated":"2022-02-16 15:18:31.000000000","message":"Same as in #191","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            elif option \u003d\u003d \"ttl\":"},{"line_number":198,"context_line":"                update_ttl \u003d self.client.update_zone("},{"line_number":199,"context_line":"                    create_zone[\u0027id\u0027], ttl\u003ddns_data_utils.rand_ttl())[1]"},{"line_number":200,"context_line":"                LOG.info(\u0027Ensure that the Serial is changed\u0027)"},{"line_number":201,"context_line":"                self.assertNotEqual("},{"line_number":202,"context_line":"                    create_zone[\u0027serial\u0027], update_ttl[\u0027serial\u0027],"},{"line_number":203,"context_line":"                    \"Failed, expect the Serial to change \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7edc1ebe_f00f5738","line":200,"range":{"start_line":200,"start_character":0,"end_line":200,"end_character":61},"in_reply_to":"789a37d7_0c0c8f77","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0c1116f3a4b5184bb945d0f5d0eb7e97eb3c4b65","unresolved":true,"context_lines":[{"line_number":200,"context_line":"                LOG.info(\u0027Ensure that the Serial is changed\u0027)"},{"line_number":201,"context_line":"                self.assertNotEqual("},{"line_number":202,"context_line":"                    create_zone[\u0027serial\u0027], update_ttl[\u0027serial\u0027],"},{"line_number":203,"context_line":"                    \"Failed, expect the Serial to change \""},{"line_number":204,"context_line":"                    \"when the TTL is updated\""},{"line_number":205,"context_line":"                )"},{"line_number":206,"context_line":"            elif option \u003d\u003d \"combination\":"},{"line_number":207,"context_line":"                update_combination \u003d self.client.update_zone("}],"source_content_type":"text/x-python","patch_set":4,"id":"90f99549_faeb737c","line":204,"range":{"start_line":203,"start_character":0,"end_line":204,"end_character":45},"updated":"2022-02-16 15:18:31.000000000","message":"Same as in #196 (message rephrase)","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                LOG.info(\u0027Ensure that the Serial is changed\u0027)"},{"line_number":201,"context_line":"                self.assertNotEqual("},{"line_number":202,"context_line":"                    create_zone[\u0027serial\u0027], update_ttl[\u0027serial\u0027],"},{"line_number":203,"context_line":"                    \"Failed, expect the Serial to change \""},{"line_number":204,"context_line":"                    \"when the TTL is updated\""},{"line_number":205,"context_line":"                )"},{"line_number":206,"context_line":"            elif option \u003d\u003d \"combination\":"},{"line_number":207,"context_line":"                update_combination \u003d self.client.update_zone("}],"source_content_type":"text/x-python","patch_set":4,"id":"16334fdc_5588c5d5","line":204,"range":{"start_line":203,"start_character":0,"end_line":204,"end_character":45},"in_reply_to":"90f99549_faeb737c","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0c1116f3a4b5184bb945d0f5d0eb7e97eb3c4b65","unresolved":true,"context_lines":[{"line_number":209,"context_line":"                    email\u003ddns_data_utils.rand_email(),"},{"line_number":210,"context_line":"                    description\u003ddata_utils.rand_name()"},{"line_number":211,"context_line":"                )[1]"},{"line_number":212,"context_line":"                LOG.info(\u0027Ensure that the Serial is changed\u0027)"},{"line_number":213,"context_line":"                self.assertNotEqual("},{"line_number":214,"context_line":"                    create_zone[\u0027serial\u0027], update_combination[\u0027serial\u0027]),"},{"line_number":215,"context_line":"                \"Failed, expect the Serial to change \""}],"source_content_type":"text/x-python","patch_set":4,"id":"b68ba438_cd548a19","line":212,"range":{"start_line":212,"start_character":0,"end_line":212,"end_character":61},"updated":"2022-02-16 15:18:31.000000000","message":"Same as in #191","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                    email\u003ddns_data_utils.rand_email(),"},{"line_number":210,"context_line":"                    description\u003ddata_utils.rand_name()"},{"line_number":211,"context_line":"                )[1]"},{"line_number":212,"context_line":"                LOG.info(\u0027Ensure that the Serial is changed\u0027)"},{"line_number":213,"context_line":"                self.assertNotEqual("},{"line_number":214,"context_line":"                    create_zone[\u0027serial\u0027], update_combination[\u0027serial\u0027]),"},{"line_number":215,"context_line":"                \"Failed, expect the Serial to change \""}],"source_content_type":"text/x-python","patch_set":4,"id":"dfc90618_af0e12bc","line":212,"range":{"start_line":212,"start_character":0,"end_line":212,"end_character":61},"in_reply_to":"b68ba438_cd548a19","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0c1116f3a4b5184bb945d0f5d0eb7e97eb3c4b65","unresolved":true,"context_lines":[{"line_number":212,"context_line":"                LOG.info(\u0027Ensure that the Serial is changed\u0027)"},{"line_number":213,"context_line":"                self.assertNotEqual("},{"line_number":214,"context_line":"                    create_zone[\u0027serial\u0027], update_combination[\u0027serial\u0027]),"},{"line_number":215,"context_line":"                \"Failed, expect the Serial to change \""},{"line_number":216,"context_line":"                \"when the Email and Description are updated\""},{"line_number":217,"context_line":"            else:"},{"line_number":218,"context_line":"                update_description \u003d self.client.update_zone("},{"line_number":219,"context_line":"                    create_zone[\u0027id\u0027], description\u003ddata_utils.rand_name())[1]"}],"source_content_type":"text/x-python","patch_set":4,"id":"280b7cd2_63dff0a0","line":216,"range":{"start_line":215,"start_character":0,"end_line":216,"end_character":60},"updated":"2022-02-16 15:18:31.000000000","message":"Same as in #196","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                LOG.info(\u0027Ensure that the Serial is changed\u0027)"},{"line_number":213,"context_line":"                self.assertNotEqual("},{"line_number":214,"context_line":"                    create_zone[\u0027serial\u0027], update_combination[\u0027serial\u0027]),"},{"line_number":215,"context_line":"                \"Failed, expect the Serial to change \""},{"line_number":216,"context_line":"                \"when the Email and Description are updated\""},{"line_number":217,"context_line":"            else:"},{"line_number":218,"context_line":"                update_description \u003d self.client.update_zone("},{"line_number":219,"context_line":"                    create_zone[\u0027id\u0027], description\u003ddata_utils.rand_name())[1]"}],"source_content_type":"text/x-python","patch_set":4,"id":"32196379_5535be73","line":216,"range":{"start_line":215,"start_character":0,"end_line":216,"end_character":60},"in_reply_to":"280b7cd2_63dff0a0","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0c1116f3a4b5184bb945d0f5d0eb7e97eb3c4b65","unresolved":true,"context_lines":[{"line_number":217,"context_line":"            else:"},{"line_number":218,"context_line":"                update_description \u003d self.client.update_zone("},{"line_number":219,"context_line":"                    create_zone[\u0027id\u0027], description\u003ddata_utils.rand_name())[1]"},{"line_number":220,"context_line":"                LOG.info(\u0027Ensure that the Serial is not changed\u0027)"},{"line_number":221,"context_line":"                self.assertEqual("},{"line_number":222,"context_line":"                    create_zone[\u0027serial\u0027], update_description[\u0027serial\u0027],"},{"line_number":223,"context_line":"                    \"Failed, expect the Serial to not change\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3d5fc099_badd0852","line":220,"range":{"start_line":220,"start_character":0,"end_line":220,"end_character":65},"updated":"2022-02-16 15:18:31.000000000","message":"Same as in #191","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            else:"},{"line_number":218,"context_line":"                update_description \u003d self.client.update_zone("},{"line_number":219,"context_line":"                    create_zone[\u0027id\u0027], description\u003ddata_utils.rand_name())[1]"},{"line_number":220,"context_line":"                LOG.info(\u0027Ensure that the Serial is not changed\u0027)"},{"line_number":221,"context_line":"                self.assertEqual("},{"line_number":222,"context_line":"                    create_zone[\u0027serial\u0027], update_description[\u0027serial\u0027],"},{"line_number":223,"context_line":"                    \"Failed, expect the Serial to not change\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3e8dbf05_86b5fb5c","line":220,"range":{"start_line":220,"start_character":0,"end_line":220,"end_character":65},"in_reply_to":"3d5fc099_badd0852","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0c1116f3a4b5184bb945d0f5d0eb7e97eb3c4b65","unresolved":true,"context_lines":[{"line_number":220,"context_line":"                LOG.info(\u0027Ensure that the Serial is not changed\u0027)"},{"line_number":221,"context_line":"                self.assertEqual("},{"line_number":222,"context_line":"                    create_zone[\u0027serial\u0027], update_description[\u0027serial\u0027],"},{"line_number":223,"context_line":"                    \"Failed, expect the Serial to not change\""},{"line_number":224,"context_line":"                    \"when the Description is updated\""},{"line_number":225,"context_line":"                )"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @decorators.idempotent_id(\u0027e391e30a-92e0-11eb-9d02-74e5f9e2a801\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"762d8659_8d5862bb","line":224,"range":{"start_line":223,"start_character":0,"end_line":224,"end_character":53},"updated":"2022-02-16 15:18:31.000000000","message":"Same as in #196","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                LOG.info(\u0027Ensure that the Serial is not changed\u0027)"},{"line_number":221,"context_line":"                self.assertEqual("},{"line_number":222,"context_line":"                    create_zone[\u0027serial\u0027], update_description[\u0027serial\u0027],"},{"line_number":223,"context_line":"                    \"Failed, expect the Serial to not change\""},{"line_number":224,"context_line":"                    \"when the Description is updated\""},{"line_number":225,"context_line":"                )"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @decorators.idempotent_id(\u0027e391e30a-92e0-11eb-9d02-74e5f9e2a801\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4f27f692_f2e07dfc","line":224,"range":{"start_line":223,"start_character":0,"end_line":224,"end_character":53},"in_reply_to":"762d8659_8d5862bb","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"8ddfaee2b3cd7b1339e065f43cd25d67ae386f72"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3310b0710d21ca5eef37f6509ccbc95e70151695","unresolved":true,"context_lines":[{"line_number":185,"context_line":"        self.addCleanup(self.wait_zone_delete, self.client, zone[\u0027id\u0027])"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        # Generate a random email, ttl and description"},{"line_number":188,"context_line":"        email \u003d dns_data_utils.rand_email()"},{"line_number":189,"context_line":"        ttl \u003d dns_data_utils.rand_ttl()"},{"line_number":190,"context_line":"        description \u003d data_utils.rand_name()"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        LOG.info(\u0027Update the Email\u0027)"},{"line_number":193,"context_line":"        self.assertNotEqual("}],"source_content_type":"text/x-python","patch_set":5,"id":"fdd3944c_e3cf9d29","line":190,"range":{"start_line":188,"start_character":0,"end_line":190,"end_character":44},"updated":"2022-02-16 18:15:10.000000000","message":"I think that we can remove this lines and to simply generate each relevant field inside the assertion, for example:\n\n        self.assertNotEqual(\n            zone[\u0027serial\u0027],\n            self.client.update_zone(zone[\u0027id\u0027],\n            email\u003ddns_data_utils.rand_email()[1][\u0027serial\u0027],\n            \"Failed, expected: \u0027Serial\u0027 is supposed to be changed \"\n            \"on Email update.\"","commit_id":"679f97e767c5cf405066d1d15bd48f5e65cf0639"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        self.addCleanup(self.wait_zone_delete, self.client, zone[\u0027id\u0027])"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        # Generate a random email, ttl and description"},{"line_number":188,"context_line":"        email \u003d dns_data_utils.rand_email()"},{"line_number":189,"context_line":"        ttl \u003d dns_data_utils.rand_ttl()"},{"line_number":190,"context_line":"        description \u003d data_utils.rand_name()"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        LOG.info(\u0027Update the Email\u0027)"},{"line_number":193,"context_line":"        self.assertNotEqual("}],"source_content_type":"text/x-python","patch_set":5,"id":"9ce83d44_3729c598","line":190,"range":{"start_line":188,"start_character":0,"end_line":190,"end_character":44},"in_reply_to":"fdd3944c_e3cf9d29","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"679f97e767c5cf405066d1d15bd48f5e65cf0639"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3310b0710d21ca5eef37f6509ccbc95e70151695","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        ttl \u003d dns_data_utils.rand_ttl()"},{"line_number":190,"context_line":"        description \u003d data_utils.rand_name()"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        LOG.info(\u0027Update the Email\u0027)"},{"line_number":193,"context_line":"        self.assertNotEqual("},{"line_number":194,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":195,"context_line":"            self.client.update_zone(zone[\u0027id\u0027], email\u003demail)[1][\u0027serial\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"f27c2a2e_35efd9d8","line":192,"range":{"start_line":192,"start_character":18,"end_line":192,"end_character":34},"updated":"2022-02-16 18:15:10.000000000","message":"Update Zone\u0027s email","commit_id":"679f97e767c5cf405066d1d15bd48f5e65cf0639"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        ttl \u003d dns_data_utils.rand_ttl()"},{"line_number":190,"context_line":"        description \u003d data_utils.rand_name()"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        LOG.info(\u0027Update the Email\u0027)"},{"line_number":193,"context_line":"        self.assertNotEqual("},{"line_number":194,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":195,"context_line":"            self.client.update_zone(zone[\u0027id\u0027], email\u003demail)[1][\u0027serial\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"0519636e_bb173795","line":192,"range":{"start_line":192,"start_character":18,"end_line":192,"end_character":34},"in_reply_to":"f27c2a2e_35efd9d8","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"679f97e767c5cf405066d1d15bd48f5e65cf0639"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3310b0710d21ca5eef37f6509ccbc95e70151695","unresolved":true,"context_lines":[{"line_number":197,"context_line":"            \"on Email update.\""},{"line_number":198,"context_line":"        )"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        LOG.info(\u0027Update the TTL\u0027)"},{"line_number":201,"context_line":"        self.assertNotEqual("},{"line_number":202,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":203,"context_line":"            self.client.update_zone(zone[\u0027id\u0027], ttl\u003dttl)[1][\u0027serial\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"9d4208b3_43dfcdc2","line":200,"range":{"start_line":200,"start_character":0,"end_line":200,"end_character":34},"updated":"2022-02-16 18:15:10.000000000","message":"Update Zone\u0027s TTL","commit_id":"679f97e767c5cf405066d1d15bd48f5e65cf0639"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            \"on Email update.\""},{"line_number":198,"context_line":"        )"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        LOG.info(\u0027Update the TTL\u0027)"},{"line_number":201,"context_line":"        self.assertNotEqual("},{"line_number":202,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":203,"context_line":"            self.client.update_zone(zone[\u0027id\u0027], ttl\u003dttl)[1][\u0027serial\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"36c4a879_844a7c86","line":200,"range":{"start_line":200,"start_character":0,"end_line":200,"end_character":34},"in_reply_to":"9d4208b3_43dfcdc2","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"679f97e767c5cf405066d1d15bd48f5e65cf0639"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3310b0710d21ca5eef37f6509ccbc95e70151695","unresolved":true,"context_lines":[{"line_number":205,"context_line":"            \"on TTL update.\""},{"line_number":206,"context_line":"        )"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        LOG.info(\u0027Update the Email and Description\u0027)"},{"line_number":209,"context_line":"        self.assertNotEqual("},{"line_number":210,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":211,"context_line":"            self.client.update_zone("}],"source_content_type":"text/x-python","patch_set":5,"id":"2dc3038a_1f9e7470","line":208,"range":{"start_line":208,"start_character":0,"end_line":208,"end_character":52},"updated":"2022-02-16 18:15:10.000000000","message":"Update Zone\u0027s Email and Description","commit_id":"679f97e767c5cf405066d1d15bd48f5e65cf0639"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            \"on TTL update.\""},{"line_number":206,"context_line":"        )"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        LOG.info(\u0027Update the Email and Description\u0027)"},{"line_number":209,"context_line":"        self.assertNotEqual("},{"line_number":210,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":211,"context_line":"            self.client.update_zone("}],"source_content_type":"text/x-python","patch_set":5,"id":"d60e493b_5851f1e6","line":208,"range":{"start_line":208,"start_character":0,"end_line":208,"end_character":52},"in_reply_to":"2dc3038a_1f9e7470","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"679f97e767c5cf405066d1d15bd48f5e65cf0639"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3310b0710d21ca5eef37f6509ccbc95e70151695","unresolved":true,"context_lines":[{"line_number":213,"context_line":"            \"Failed, expected: \u0027Serial\u0027 is supposed to be changed \""},{"line_number":214,"context_line":"            \"on Email and Description update.\")"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        LOG.info(\u0027Update the Description\u0027)"},{"line_number":217,"context_line":"        self.assertEqual("},{"line_number":218,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":219,"context_line":"            self.client.update_zone("}],"source_content_type":"text/x-python","patch_set":5,"id":"a8fcf9d8_61d4cce5","line":216,"range":{"start_line":216,"start_character":0,"end_line":216,"end_character":3},"updated":"2022-02-16 18:15:10.000000000","message":"Update Zone\u0027s description","commit_id":"679f97e767c5cf405066d1d15bd48f5e65cf0639"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            \"Failed, expected: \u0027Serial\u0027 is supposed to be changed \""},{"line_number":214,"context_line":"            \"on Email and Description update.\")"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        LOG.info(\u0027Update the Description\u0027)"},{"line_number":217,"context_line":"        self.assertEqual("},{"line_number":218,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":219,"context_line":"            self.client.update_zone("}],"source_content_type":"text/x-python","patch_set":5,"id":"5b444c47_075dc252","line":216,"range":{"start_line":216,"start_character":0,"end_line":216,"end_character":3},"in_reply_to":"a8fcf9d8_61d4cce5","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"679f97e767c5cf405066d1d15bd48f5e65cf0639"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3310b0710d21ca5eef37f6509ccbc95e70151695","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        self.assertEqual("},{"line_number":218,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":219,"context_line":"            self.client.update_zone("},{"line_number":220,"context_line":"                zone[\u0027id\u0027], description\u003ddescription)[1][\u0027serial\u0027],"},{"line_number":221,"context_line":"            \"Failed, expected: \u0027Serial\u0027 is supposed to be not changed \""},{"line_number":222,"context_line":"            \"on Description update.\")"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"60ff2e8a_22cc8c2e","line":220,"range":{"start_line":220,"start_character":0,"end_line":220,"end_character":7},"updated":"2022-02-16 18:15:10.000000000","message":"Logic seems to be broken here as the Description string is the same as in L212.\nYou are using the same description string (generated in L190) for both updates.","commit_id":"679f97e767c5cf405066d1d15bd48f5e65cf0639"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"922a42600564f0f6996e5a91cffdc8c4a8aec237","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        self.assertEqual("},{"line_number":218,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":219,"context_line":"            self.client.update_zone("},{"line_number":220,"context_line":"                zone[\u0027id\u0027], description\u003ddescription)[1][\u0027serial\u0027],"},{"line_number":221,"context_line":"            \"Failed, expected: \u0027Serial\u0027 is supposed to be not changed \""},{"line_number":222,"context_line":"            \"on Description update.\")"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"251e8bac_5923f7c1","line":220,"updated":"2022-02-16 22:43:11.000000000","message":"Technically, if it works it is doing an update, but you would never know, you should change the description to something different to ensure it changed.","commit_id":"679f97e767c5cf405066d1d15bd48f5e65cf0639"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        self.assertEqual("},{"line_number":218,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":219,"context_line":"            self.client.update_zone("},{"line_number":220,"context_line":"                zone[\u0027id\u0027], description\u003ddescription)[1][\u0027serial\u0027],"},{"line_number":221,"context_line":"            \"Failed, expected: \u0027Serial\u0027 is supposed to be not changed \""},{"line_number":222,"context_line":"            \"on Description update.\")"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1b6ef395_5eaa8127","line":220,"in_reply_to":"251e8bac_5923f7c1","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"679f97e767c5cf405066d1d15bd48f5e65cf0639"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        self.assertEqual("},{"line_number":218,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":219,"context_line":"            self.client.update_zone("},{"line_number":220,"context_line":"                zone[\u0027id\u0027], description\u003ddescription)[1][\u0027serial\u0027],"},{"line_number":221,"context_line":"            \"Failed, expected: \u0027Serial\u0027 is supposed to be not changed \""},{"line_number":222,"context_line":"            \"on Description update.\")"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e3f9aa80_5bcab928","line":220,"range":{"start_line":220,"start_character":0,"end_line":220,"end_character":7},"in_reply_to":"60ff2e8a_22cc8c2e","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"679f97e767c5cf405066d1d15bd48f5e65cf0639"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"717a71b53e37d15b7254356ab3803b2b304a035a","unresolved":true,"context_lines":[{"line_number":213,"context_line":"            \"on Email and Description update.\")"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        LOG.info(\"Update Zone\u0027s description\")"},{"line_number":216,"context_line":"        self.assertNotEqual("},{"line_number":217,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":218,"context_line":"            self.client.update_zone("},{"line_number":219,"context_line":"                zone[\u0027id\u0027], description\u003ddata_utils.rand_name())[1][\u0027serial\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"22eb73e0_511a40bc","line":216,"range":{"start_line":216,"start_character":13,"end_line":216,"end_character":27},"updated":"2022-02-17 10:27:22.000000000","message":"Does it fit test\u0027s logic?","commit_id":"c7b3fbb45e91d3704472cdba90bd3cd3d8dc2dd2"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"fa7c1d1728e44fbed5aff8af76dffecc853b5592","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            \"on Email and Description update.\")"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        LOG.info(\"Update Zone\u0027s description\")"},{"line_number":216,"context_line":"        self.assertNotEqual("},{"line_number":217,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":218,"context_line":"            self.client.update_zone("},{"line_number":219,"context_line":"                zone[\u0027id\u0027], description\u003ddata_utils.rand_name())[1][\u0027serial\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"a5d4d210_c35ee09f","line":216,"range":{"start_line":216,"start_character":13,"end_line":216,"end_character":27},"in_reply_to":"22eb73e0_511a40bc","updated":"2022-02-17 10:55:55.000000000","message":"Done","commit_id":"c7b3fbb45e91d3704472cdba90bd3cd3d8dc2dd2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8e2161d50295ec38b8d2d3fd5396a7d6826095bc","unresolved":true,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        LOG.info(\"Update Zone\u0027s TTL\")"},{"line_number":197,"context_line":"        self.assertNotEqual("},{"line_number":198,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":199,"context_line":"            self.client.update_zone("},{"line_number":200,"context_line":"                zone[\u0027id\u0027],"},{"line_number":201,"context_line":"                ttl\u003ddns_data_utils.rand_ttl())[1][\u0027serial\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"0e7c3fa6_7cfb8717","line":198,"updated":"2022-02-23 23:06:21.000000000","message":"By using the zone serial number from the initial create request, this test could pass if the \"email\" test above incremented the serial number, but this test, updating the \"TTL\", did not.","commit_id":"968550bf209a1547a78467c2d3055fa0c26544e2"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"18c25e7c349759e2015729cf7cef15914838f6c0","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        LOG.info(\"Update Zone\u0027s TTL\")"},{"line_number":197,"context_line":"        self.assertNotEqual("},{"line_number":198,"context_line":"            zone[\u0027serial\u0027],"},{"line_number":199,"context_line":"            self.client.update_zone("},{"line_number":200,"context_line":"                zone[\u0027id\u0027],"},{"line_number":201,"context_line":"                ttl\u003ddns_data_utils.rand_ttl())[1][\u0027serial\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"b6bb81af_99a3288a","line":198,"in_reply_to":"0e7c3fa6_7cfb8717","updated":"2022-02-27 10:57:34.000000000","message":"Done","commit_id":"968550bf209a1547a78467c2d3055fa0c26544e2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8e2161d50295ec38b8d2d3fd5396a7d6826095bc","unresolved":true,"context_lines":[{"line_number":333,"context_line":"        self.addCleanup("},{"line_number":334,"context_line":"            self.wait_zone_delete, self.admin_client, admin_zone[\u0027id\u0027],"},{"line_number":335,"context_line":"            headers\u003dself.all_projects_header)"},{"line_number":336,"context_line":"        LOG.info(\u0027Wait till the zone is ACTIVE\u0027)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        LOG.info(\u0027As admin user list all projects zones\u0027)"},{"line_number":339,"context_line":"        # Note: This is an all-projects list call, so other tests running"}],"source_content_type":"text/x-python","patch_set":8,"id":"4d1d983e_4b70712b","line":336,"updated":"2022-02-23 23:06:21.000000000","message":"This log message can be removed now.","commit_id":"968550bf209a1547a78467c2d3055fa0c26544e2"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"314373aa2014754d653be9f690512d95f1586da5","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        self.addCleanup("},{"line_number":334,"context_line":"            self.wait_zone_delete, self.admin_client, admin_zone[\u0027id\u0027],"},{"line_number":335,"context_line":"            headers\u003dself.all_projects_header)"},{"line_number":336,"context_line":"        LOG.info(\u0027Wait till the zone is ACTIVE\u0027)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        LOG.info(\u0027As admin user list all projects zones\u0027)"},{"line_number":339,"context_line":"        # Note: This is an all-projects list call, so other tests running"}],"source_content_type":"text/x-python","patch_set":8,"id":"a3776c6f_20a5ac19","line":336,"in_reply_to":"4d1d983e_4b70712b","updated":"2022-02-27 12:05:24.000000000","message":"Done","commit_id":"968550bf209a1547a78467c2d3055fa0c26544e2"}]}