)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"e1fc34029cf01a47cd8fe45586ef304187c7c050","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"67cb1e70_0f571b08","updated":"2022-03-15 18:08:20.000000000","message":"LGTM","commit_id":"a5c05e4ddea4bf8f3ec7774a690ec4fb8a1576cb"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"6d71cebeca2e88b9139122472db0992345e7fef0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aa337991_ad4caec3","updated":"2022-03-08 21:00:05.000000000","message":"LGTM","commit_id":"a5c05e4ddea4bf8f3ec7774a690ec4fb8a1576cb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5ea9c575d1385c6e01c5b5217d107d6773669ae4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"428ec20e_8b6b2c56","updated":"2022-05-06 17:40:59.000000000","message":"This patch is highly duplicate to https://review.opendev.org/c/openstack/designate-tempest-plugin/+/823682\n\nCan we either merge them or stack that patches to eliminate the duplicated code?","commit_id":"a5c05e4ddea4bf8f3ec7774a690ec4fb8a1576cb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"582f88a8d90467dfcfd4f762729c33212b47ee74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6ba9bedc_437eea51","updated":"2022-05-06 17:34:00.000000000","message":"Two minor issues, but there is a one missing cleanup hook.","commit_id":"a5c05e4ddea4bf8f3ec7774a690ec4fb8a1576cb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3c5e15b7c7207ac667abb799accd53b3d7afb582","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6d5b49b6_7e4d7a33","in_reply_to":"6ba9bedc_437eea51","updated":"2022-05-10 13:48:55.000000000","message":"Yep, makes sense, I\u0027ll merge the: https://review.opendev.org/c/openstack/designate-tempest-plugin/+/823682 into this one.","commit_id":"a5c05e4ddea4bf8f3ec7774a690ec4fb8a1576cb"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"1905fd3e9a356a488a4df4818510d61e865cdd21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5b49545c_1d51e1d2","updated":"2022-05-11 19:23:35.000000000","message":"LGTM","commit_id":"392ebbcea15715f3d3289f1bb27e38b6336e005b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0ccfb8dc0142fc82447713d104af750dcff59701","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2c7b7894_d7a9e3d1","updated":"2022-06-13 22:18:42.000000000","message":"I think something went wrong here, this patch removes the RBAC testing.","commit_id":"7e635376989c2d4fc5bac5576ce65f2defbd2879"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"fb6b68553417a4d575ead928a2d3ce209bf82708","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f1a6df86_38bd93ab","in_reply_to":"2c7b7894_d7a9e3d1","updated":"2022-06-14 07:26:24.000000000","message":"Yep, the rebase went wrong, will be fixed.\nThanks Michael!","commit_id":"7e635376989c2d4fc5bac5576ce65f2defbd2879"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"f2f93fd825c7c27f9d539a9e9e3b639e1f618b0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a69de839_0132b8f0","updated":"2022-06-29 14:12:39.000000000","message":"LGTM","commit_id":"3b5d149cf3de56aaa8d9f56d0dfb92b474e2e596"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9b1023ee8f04f68980b5454510e5bef18a142cbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ccc13a04_42ecd6a2","updated":"2022-06-28 18:13:42.000000000","message":"LGTM","commit_id":"3b5d149cf3de56aaa8d9f56d0dfb92b474e2e596"}],"designate_tempest_plugin/tests/api/v2/test_zones_imports.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"582f88a8d90467dfcfd4f762729c33212b47ee74","unresolved":true,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class ZonesImportTestNegative(BaseZonesImportTest):"},{"line_number":206,"context_line":"    credentials \u003d [\"primary\", \"alt\"]"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    @classmethod"},{"line_number":209,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9971f77c_3b4ecaa4","line":206,"updated":"2022-05-06 17:34:00.000000000","message":"nit: \"alt\" is not used here.","commit_id":"a5c05e4ddea4bf8f3ec7774a690ec4fb8a1576cb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3c5e15b7c7207ac667abb799accd53b3d7afb582","unresolved":true,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class ZonesImportTestNegative(BaseZonesImportTest):"},{"line_number":206,"context_line":"    credentials \u003d [\"primary\", \"alt\"]"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    @classmethod"},{"line_number":209,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da549b49_cdea3375","line":206,"in_reply_to":"9971f77c_3b4ecaa4","updated":"2022-05-10 13:48:55.000000000","message":"Yep, no need in alt here.","commit_id":"a5c05e4ddea4bf8f3ec7774a690ec4fb8a1576cb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"fb6b68553417a4d575ead928a2d3ce209bf82708","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class ZonesImportTestNegative(BaseZonesImportTest):"},{"line_number":206,"context_line":"    credentials \u003d [\"primary\", \"alt\"]"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    @classmethod"},{"line_number":209,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"2263b4c9_89475dc7","line":206,"in_reply_to":"da549b49_cdea3375","updated":"2022-06-14 07:26:24.000000000","message":"Done","commit_id":"a5c05e4ddea4bf8f3ec7774a690ec4fb8a1576cb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"582f88a8d90467dfcfd4f762729c33212b47ee74","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        cls.zone_client \u003d cls.os_primary.dns_v2.ZonesClient()"},{"line_number":218,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZoneImportsClient()"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def clean_up_resources(self, zone_import_id):"},{"line_number":221,"context_line":"        zone_import \u003d self.client.show_zone_import(zone_import_id)[1]"},{"line_number":222,"context_line":"        if zone_import[\u0027zone_id\u0027]:  # A zone was actually created."},{"line_number":223,"context_line":"            waiters.wait_for_zone_import_status("}],"source_content_type":"text/x-python","patch_set":2,"id":"0ab5e775_aa50982c","line":220,"updated":"2022-05-06 17:34:00.000000000","message":"nit: _clean_up_resources would be best since this is really a private method for the class.","commit_id":"a5c05e4ddea4bf8f3ec7774a690ec4fb8a1576cb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3c5e15b7c7207ac667abb799accd53b3d7afb582","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        cls.zone_client \u003d cls.os_primary.dns_v2.ZonesClient()"},{"line_number":218,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZoneImportsClient()"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def clean_up_resources(self, zone_import_id):"},{"line_number":221,"context_line":"        zone_import \u003d self.client.show_zone_import(zone_import_id)[1]"},{"line_number":222,"context_line":"        if zone_import[\u0027zone_id\u0027]:  # A zone was actually created."},{"line_number":223,"context_line":"            waiters.wait_for_zone_import_status("}],"source_content_type":"text/x-python","patch_set":2,"id":"472e8f78_9febec1e","line":220,"in_reply_to":"0ab5e775_aa50982c","updated":"2022-05-10 13:48:55.000000000","message":"Yep, I saw that too in https://review.opendev.org/c/openstack/designate-tempest-plugin/+/823682","commit_id":"a5c05e4ddea4bf8f3ec7774a690ec4fb8a1576cb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"fb6b68553417a4d575ead928a2d3ce209bf82708","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        cls.zone_client \u003d cls.os_primary.dns_v2.ZonesClient()"},{"line_number":218,"context_line":"        cls.client \u003d cls.os_primary.dns_v2.ZoneImportsClient()"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def clean_up_resources(self, zone_import_id):"},{"line_number":221,"context_line":"        zone_import \u003d self.client.show_zone_import(zone_import_id)[1]"},{"line_number":222,"context_line":"        if zone_import[\u0027zone_id\u0027]:  # A zone was actually created."},{"line_number":223,"context_line":"            waiters.wait_for_zone_import_status("}],"source_content_type":"text/x-python","patch_set":2,"id":"b79037a4_a5e9f70c","line":220,"in_reply_to":"472e8f78_9febec1e","updated":"2022-06-14 07:26:24.000000000","message":"Done","commit_id":"a5c05e4ddea4bf8f3ec7774a690ec4fb8a1576cb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"582f88a8d90467dfcfd4f762729c33212b47ee74","unresolved":true,"context_lines":[{"line_number":265,"context_line":"        LOG.info(\u0027Use zone import to update an existing zone, expected: zone\u0027"},{"line_number":266,"context_line":"                 \u0027 import gets into the ERROR status \u0027)"},{"line_number":267,"context_line":"        zone_import_data \u003d dns_data_utils.rand_zonefile_data(name\u003dzone_name)"},{"line_number":268,"context_line":"        zone_import \u003d self.client.create_zone_import(zone_import_data)[1]"},{"line_number":269,"context_line":"        waiters.wait_for_zone_import_status("},{"line_number":270,"context_line":"            self.client, zone_import[\u0027id\u0027], const.ERROR)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7886251f_2cc6f21a","line":268,"updated":"2022-05-06 17:34:00.000000000","message":"The cleanup for this zone import is missing.","commit_id":"a5c05e4ddea4bf8f3ec7774a690ec4fb8a1576cb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"fb6b68553417a4d575ead928a2d3ce209bf82708","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        LOG.info(\u0027Use zone import to update an existing zone, expected: zone\u0027"},{"line_number":266,"context_line":"                 \u0027 import gets into the ERROR status \u0027)"},{"line_number":267,"context_line":"        zone_import_data \u003d dns_data_utils.rand_zonefile_data(name\u003dzone_name)"},{"line_number":268,"context_line":"        zone_import \u003d self.client.create_zone_import(zone_import_data)[1]"},{"line_number":269,"context_line":"        waiters.wait_for_zone_import_status("},{"line_number":270,"context_line":"            self.client, zone_import[\u0027id\u0027], const.ERROR)"}],"source_content_type":"text/x-python","patch_set":2,"id":"013b2241_6916db33","line":268,"in_reply_to":"48199cad_d70c5d0b","updated":"2022-06-14 07:26:24.000000000","message":"Done","commit_id":"a5c05e4ddea4bf8f3ec7774a690ec4fb8a1576cb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3c5e15b7c7207ac667abb799accd53b3d7afb582","unresolved":true,"context_lines":[{"line_number":265,"context_line":"        LOG.info(\u0027Use zone import to update an existing zone, expected: zone\u0027"},{"line_number":266,"context_line":"                 \u0027 import gets into the ERROR status \u0027)"},{"line_number":267,"context_line":"        zone_import_data \u003d dns_data_utils.rand_zonefile_data(name\u003dzone_name)"},{"line_number":268,"context_line":"        zone_import \u003d self.client.create_zone_import(zone_import_data)[1]"},{"line_number":269,"context_line":"        waiters.wait_for_zone_import_status("},{"line_number":270,"context_line":"            self.client, zone_import[\u0027id\u0027], const.ERROR)"}],"source_content_type":"text/x-python","patch_set":2,"id":"48199cad_d70c5d0b","line":268,"in_reply_to":"7886251f_2cc6f21a","updated":"2022-05-10 13:48:55.000000000","message":"Will be added","commit_id":"a5c05e4ddea4bf8f3ec7774a690ec4fb8a1576cb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0ccfb8dc0142fc82447713d104af750dcff59701","unresolved":true,"context_lines":[{"line_number":104,"context_line":"            expected_allowed.append(\u0027os_system_admin\u0027)"},{"line_number":105,"context_line":"            expected_allowed.append(\u0027os_project_member\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.check_CUD_RBAC_enforcement("},{"line_number":108,"context_line":"            \u0027ZoneImportsClient\u0027, \u0027create_zone_import\u0027, expected_allowed, False)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @decorators.idempotent_id(\u002731eaf25a-9532-11eb-a55d-74e5f9e2a801\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"6e485f20_8b277209","side":"PARENT","line":107,"updated":"2022-06-13 22:18:42.000000000","message":"Why was the RBAC testing removed here?\nThis looks like a bad rebase.","commit_id":"1852668517a2ba1b43dc7076e452301e6ded09e3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"fb6b68553417a4d575ead928a2d3ce209bf82708","unresolved":true,"context_lines":[{"line_number":104,"context_line":"            expected_allowed.append(\u0027os_system_admin\u0027)"},{"line_number":105,"context_line":"            expected_allowed.append(\u0027os_project_member\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.check_CUD_RBAC_enforcement("},{"line_number":108,"context_line":"            \u0027ZoneImportsClient\u0027, \u0027create_zone_import\u0027, expected_allowed, False)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @decorators.idempotent_id(\u002731eaf25a-9532-11eb-a55d-74e5f9e2a801\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"a530a35c_3b1e2853","side":"PARENT","line":107,"in_reply_to":"6e485f20_8b277209","updated":"2022-06-14 07:26:24.000000000","message":"Yep, the rebase went wrong, will be fixed.\nThanks Michael!","commit_id":"1852668517a2ba1b43dc7076e452301e6ded09e3"}]}
