)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"e79d769697d41fa39065900b21170359bb514764","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"76c2dffc_9a267f63","updated":"2022-03-24 12:45:26.000000000","message":"Failed on:designate_tempest_plugin.tests.api.v2.test_ptrs.DesignatePtrRecord.test_list_floatingip_ptr_records[id-9187a9c6-87d4-11eb-9f9a-74e5f9e2a801]\"\n2022-03-24 00:24:39.531369 | controller | Details: {\u0027code\u0027: 400, \u0027type\u0027: \u0027invalid_zone_name\u0027, \u0027message\u0027: \u0027Invalid TLD\u0027, \u0027request_id\u0027: \u0027req-db2d1134-bb95-4098-9c68-0870d7225d70\u0027}\nI\u0027ll try to recheck.\n","commit_id":"27e22c2ca2930ae3a9195f6df79025e1388ec387"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"dd1edbc56622a14b701892faa9195a3e32a7930a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e6a5043b_432db2fa","updated":"2022-03-29 21:16:48.000000000","message":"Minor nit","commit_id":"27e22c2ca2930ae3a9195f6df79025e1388ec387"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"23b0ecd90856b70284673e76c1a1dc833cfd0b0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"11a13674_4bd9cc22","updated":"2022-03-24 12:45:39.000000000","message":"recheck","commit_id":"27e22c2ca2930ae3a9195f6df79025e1388ec387"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"72c7b026b8a326092c32ecd7814aa041a96a17a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7e81daa1_e65fd518","updated":"2022-06-07 00:41:25.000000000","message":"LGTM","commit_id":"1eb2c4f7c235084229834f57d2a0896da525516c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0c45ffe9e0060f1486feecb6266ce17b0cf0a5a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8aaf023d_9d30d032","updated":"2022-05-26 21:37:29.000000000","message":"recheck\npip/mirror/CDN issue with scrypt package","commit_id":"1eb2c4f7c235084229834f57d2a0896da525516c"}],"designate_tempest_plugin/tests/api/v2/test_quotas.py":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"dd1edbc56622a14b701892faa9195a3e32a7930a","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        self._store_quotas(project_id\u003dself.quotas_client.project_id)"},{"line_number":118,"context_line":"        LOG.info(\"Updating quotas\")"},{"line_number":119,"context_line":"        quotas \u003d dns_data_utils.rand_quotas()"},{"line_number":120,"context_line":"        _, body \u003d self.admin_client.update_quotas("},{"line_number":121,"context_line":"            project_id\u003dself.quotas_client.project_id,"},{"line_number":122,"context_line":"            **quotas, headers\u003dself.all_projects_header)"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9e50d5e7_27126310","line":120,"updated":"2022-03-29 21:16:48.000000000","message":"Can remove the \u0027_\u0027 return and use the index \u0027[1]\u0027","commit_id":"27e22c2ca2930ae3a9195f6df79025e1388ec387"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"898c0d100c6380131919603899ce07ed9560c030","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        self._store_quotas(project_id\u003dself.quotas_client.project_id)"},{"line_number":118,"context_line":"        LOG.info(\"Updating quotas\")"},{"line_number":119,"context_line":"        quotas \u003d dns_data_utils.rand_quotas()"},{"line_number":120,"context_line":"        _, body \u003d self.admin_client.update_quotas("},{"line_number":121,"context_line":"            project_id\u003dself.quotas_client.project_id,"},{"line_number":122,"context_line":"            **quotas, headers\u003dself.all_projects_header)"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b621272e_fb4966a6","line":120,"in_reply_to":"1acbd0e5_82ddc537","updated":"2022-03-31 22:37:52.000000000","message":"Understand","commit_id":"27e22c2ca2930ae3a9195f6df79025e1388ec387"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2548aec0529d43aa1a77012361a913a3f588c48b","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        self._store_quotas(project_id\u003dself.quotas_client.project_id)"},{"line_number":118,"context_line":"        LOG.info(\"Updating quotas\")"},{"line_number":119,"context_line":"        quotas \u003d dns_data_utils.rand_quotas()"},{"line_number":120,"context_line":"        _, body \u003d self.admin_client.update_quotas("},{"line_number":121,"context_line":"            project_id\u003dself.quotas_client.project_id,"},{"line_number":122,"context_line":"            **quotas, headers\u003dself.all_projects_header)"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1acbd0e5_82ddc537","line":120,"in_reply_to":"9e50d5e7_27126310","updated":"2022-03-29 22:51:55.000000000","message":"This patch does not change that code, it would be an unrelated change.","commit_id":"27e22c2ca2930ae3a9195f6df79025e1388ec387"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b7b7f28e1ef7073f3c473c03501528ef8c002077","unresolved":true,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        self.check_CUD_RBAC_enforcement("},{"line_number":137,"context_line":"            \u0027QuotasClient\u0027, \u0027update_quotas\u0027, expected_allowed, False,"},{"line_number":138,"context_line":"            project_id\u003dself.quotas_client.project_id,"},{"line_number":139,"context_line":"            **quotas, headers\u003dself.all_projects_header)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        LOG.info(\"Ensuring the response has all quota types\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"219434ac_fd0a32f6","line":138,"range":{"start_line":138,"start_character":12,"end_line":138,"end_character":52},"updated":"2022-06-01 14:03:05.000000000","message":"If I get it right, you are passing the project_id to check_CUD_RBAC_enforcement, but check_CUD_RBAC_enforcement calls\nself._check_disallowed(client_str, method_str, allowed_list, expect_404, False, *args, **kwargs)\nwith project_id\u003dFalse","commit_id":"1eb2c4f7c235084229834f57d2a0896da525516c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2f5dda07271dff227a61062b3f880635842d979a","unresolved":true,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        self.check_CUD_RBAC_enforcement("},{"line_number":137,"context_line":"            \u0027QuotasClient\u0027, \u0027update_quotas\u0027, expected_allowed, False,"},{"line_number":138,"context_line":"            project_id\u003dself.quotas_client.project_id,"},{"line_number":139,"context_line":"            **quotas, headers\u003dself.all_projects_header)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        LOG.info(\"Ensuring the response has all quota types\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"54d9019d_d2aeff85","line":138,"range":{"start_line":138,"start_character":12,"end_line":138,"end_character":52},"in_reply_to":"219434ac_fd0a32f6","updated":"2022-06-03 23:01:13.000000000","message":"This is correct. _check_disallowed has \"with_project\" set to False, but I am injecting project_id into the kwargs for the update_quotas call.\n\"with_project\" is used for methods that have positional args for the project_id.","commit_id":"1eb2c4f7c235084229834f57d2a0896da525516c"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a9de61142080a902756e34e0ab50aae10c114922","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        self.check_CUD_RBAC_enforcement("},{"line_number":137,"context_line":"            \u0027QuotasClient\u0027, \u0027update_quotas\u0027, expected_allowed, False,"},{"line_number":138,"context_line":"            project_id\u003dself.quotas_client.project_id,"},{"line_number":139,"context_line":"            **quotas, headers\u003dself.all_projects_header)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        LOG.info(\"Ensuring the response has all quota types\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"62a19b62_9ad8fc1c","line":138,"range":{"start_line":138,"start_character":12,"end_line":138,"end_character":52},"in_reply_to":"54d9019d_d2aeff85","updated":"2022-06-06 08:12:08.000000000","message":"Ack, LGTM.","commit_id":"1eb2c4f7c235084229834f57d2a0896da525516c"}]}