)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"adba456b0990d0d662eb6b79a41abd53b55d96eb","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding new test case to \"zone export\" scenario test suite"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) test_all_recordset_types_exist_in_show_zonefile"},{"line_number":10,"context_line":"   Verifies: \"All types of recordsets that are exported"},{"line_number":11,"context_line":"              to the zone are in the zonefile\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6b657ef83f04a84526ca7ba29a5b7d0d756402f0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"134d8050_4f95a2f9","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":46},"updated":"2022-04-04 11:47:37.000000000","message":"Maybe something like:\nAll zone\u0027s recordsets (vary of types and number of records) presents in the zonefile export.","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"f0212b5fcba9777b4feae559e5c4f1ff6e1cb3ab","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding new test case to \"zone export\" scenario test suite"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) test_all_recordset_types_exist_in_show_zonefile"},{"line_number":10,"context_line":"   Verifies: \"All types of recordsets that are exported"},{"line_number":11,"context_line":"              to the zone are in the zonefile\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6b657ef83f04a84526ca7ba29a5b7d0d756402f0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7e9ff823_be3de8d6","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":46},"in_reply_to":"134d8050_4f95a2f9","updated":"2022-04-05 13:48:21.000000000","message":"Done","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"3ca09b246cd0455a98af1f44ea61c7750b3cac72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e19cffe3_5a5706a1","updated":"2022-03-31 17:53:55.000000000","message":"recheck","commit_id":"6aca7d2ceb0c9e117dcf6a637cd63e200790cd7f"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d7aebb9313e4ab48a4d6d0b9f6c246edd0341afb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e2ac4747_1ed79b12","updated":"2022-04-05 15:17:40.000000000","message":"There are few things that I\u0027m concern about:\n1) This test assumes that all records in \"designate_tempest_plugin/tests/api/v2/recordset_wildcard_data.json\" will always be created  successfully, what if some of them won\u0027t? \n2) As by now export does not include NS and SOA (both are created by default for each zone), what is for some reason (potential bug or design change) they will do?\nIn another words, I\u0027m a bit skeptic about having this test based on counter. \n3) I think that adding a dedicated *.json file to \"scenario\" folder, that will include a single type for each supported recordset type (recordset_wildcard_data.json has multiplied A, AAA e.t.c) with a proper name (not wildcard) and only valid records, could be in place here.\n\n","commit_id":"b401ab8e77ef5b59d36b5afc8f6b1f356e521740"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"589d7f3dd305520485501f0aabc1e40dcdc4dd17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f8c868e8_4aba470b","updated":"2022-04-18 05:57:25.000000000","message":"recheck","commit_id":"525ad47213f83eb23c6d30bb5ffba70a447bd4dc"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"12120790a4a77c4c7e182e3386f520abea21e4e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"92b0d889_392476d5","updated":"2022-05-11 21:04:00.000000000","message":"LGTM","commit_id":"e5957b60d3ec506156de6f3df3fe29929518671b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"67f5aa551b817e8ec589fa4a7e049619abb0eb35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"cffab53f_dfec7db2","updated":"2022-05-06 22:47:12.000000000","message":"LGTM, minor nit","commit_id":"e5957b60d3ec506156de6f3df3fe29929518671b"}],"designate_tempest_plugin/tests/scenario/v2/test_zones_export.py":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"adba456b0990d0d662eb6b79a41abd53b55d96eb","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from designate_tempest_plugin.tests.api.v2.test_zones_exports import \\"},{"line_number":20,"context_line":"    BaseZoneExportsTest"},{"line_number":21,"context_line":"from designate_tempest_plugin.common import constants as const"},{"line_number":22,"context_line":"import json"},{"line_number":23,"context_line":"import os"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"69d35b6a_cd689488","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":9},"updated":"2022-04-04 11:47:37.000000000","message":"I think that these two are supposed to be on the top of the imports as both are built in Python\u0027s libraries. In fact, I don\u0027t know why it wasn\u0027t raised by PEP8.","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"f0212b5fcba9777b4feae559e5c4f1ff6e1cb3ab","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from designate_tempest_plugin.tests.api.v2.test_zones_exports import \\"},{"line_number":20,"context_line":"    BaseZoneExportsTest"},{"line_number":21,"context_line":"from designate_tempest_plugin.common import constants as const"},{"line_number":22,"context_line":"import json"},{"line_number":23,"context_line":"import os"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"2dada29e_1e883d7e","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":9},"in_reply_to":"69d35b6a_cd689488","updated":"2022-04-05 13:48:21.000000000","message":"Done","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"adba456b0990d0d662eb6b79a41abd53b55d96eb","unresolved":true,"context_lines":[{"line_number":132,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], resp_data.ttl)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @decorators.idempotent_id(\u0027d8f444aa-a645-4a03-b366-46836f57dc69\u0027)"},{"line_number":135,"context_line":"    def test_all_recordset_types_exist_in_show_zonefile(self):"},{"line_number":136,"context_line":"        LOG.info(\u0027create a zone\u0027)"},{"line_number":137,"context_line":"        zone \u003d self.zones_client.create_zone()[1]"},{"line_number":138,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zones_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"0b8e746e_c5a84f27","line":135,"range":{"start_line":135,"start_character":8,"end_line":135,"end_character":55},"updated":"2022-04-04 11:47:37.000000000","message":"Maybe \ntest_export_zone_with_all_recordset_types?","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"f0212b5fcba9777b4feae559e5c4f1ff6e1cb3ab","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], resp_data.ttl)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @decorators.idempotent_id(\u0027d8f444aa-a645-4a03-b366-46836f57dc69\u0027)"},{"line_number":135,"context_line":"    def test_all_recordset_types_exist_in_show_zonefile(self):"},{"line_number":136,"context_line":"        LOG.info(\u0027create a zone\u0027)"},{"line_number":137,"context_line":"        zone \u003d self.zones_client.create_zone()[1]"},{"line_number":138,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zones_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"45272041_e8032a76","line":135,"range":{"start_line":135,"start_character":8,"end_line":135,"end_character":55},"in_reply_to":"0b8e746e_c5a84f27","updated":"2022-04-05 13:48:21.000000000","message":"I think the name of the test is clear because the point is to create all the record sets and see that they go to an export zone file","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"adba456b0990d0d662eb6b79a41abd53b55d96eb","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @decorators.idempotent_id(\u0027d8f444aa-a645-4a03-b366-46836f57dc69\u0027)"},{"line_number":135,"context_line":"    def test_all_recordset_types_exist_in_show_zonefile(self):"},{"line_number":136,"context_line":"        LOG.info(\u0027create a zone\u0027)"},{"line_number":137,"context_line":"        zone \u003d self.zones_client.create_zone()[1]"},{"line_number":138,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zones_client, zone[\u0027id\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        json_path \u003d os.path.join("},{"line_number":141,"context_line":"            os.path.dirname(__file__),"}],"source_content_type":"text/x-python","patch_set":3,"id":"80a0d006_5a1aa118","line":138,"range":{"start_line":136,"start_character":0,"end_line":138,"end_character":77},"updated":"2022-04-04 11:47:37.000000000","message":"This should be done after the skip, see my comment for lines:  L144-148","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"f0212b5fcba9777b4feae559e5c4f1ff6e1cb3ab","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @decorators.idempotent_id(\u0027d8f444aa-a645-4a03-b366-46836f57dc69\u0027)"},{"line_number":135,"context_line":"    def test_all_recordset_types_exist_in_show_zonefile(self):"},{"line_number":136,"context_line":"        LOG.info(\u0027create a zone\u0027)"},{"line_number":137,"context_line":"        zone \u003d self.zones_client.create_zone()[1]"},{"line_number":138,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zones_client, zone[\u0027id\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        json_path \u003d os.path.join("},{"line_number":141,"context_line":"            os.path.dirname(__file__),"}],"source_content_type":"text/x-python","patch_set":3,"id":"35c93e93_80fcf335","line":138,"range":{"start_line":136,"start_character":0,"end_line":138,"end_character":77},"in_reply_to":"80a0d006_5a1aa118","updated":"2022-04-05 13:48:21.000000000","message":"You\u0027re right.","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"adba456b0990d0d662eb6b79a41abd53b55d96eb","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        zone \u003d self.zones_client.create_zone()[1]"},{"line_number":138,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zones_client, zone[\u0027id\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        json_path \u003d os.path.join("},{"line_number":141,"context_line":"            os.path.dirname(__file__),"},{"line_number":142,"context_line":"            \u0027recordset_wildcard_data.json\u0027).replace(\u0027scenario\u0027, \u0027api\u0027)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        isFileExits \u003d os.path.exists(json_path)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d3e7e897_5fe63595","line":142,"range":{"start_line":140,"start_character":0,"end_line":142,"end_character":70},"updated":"2022-04-04 11:47:37.000000000","message":"Michael - we didn\u0027t want to add the additional *yaml file to \"scenario\" directive  for this particular test case, as all needed recordsets are already exists in \"api/recordset_wildcard_data.json\" so why nor reusing this.\nIf\u0027 it\u0027s not OK, please suggest how to proceed.","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"589d7f3dd305520485501f0aabc1e40dcdc4dd17","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        zone \u003d self.zones_client.create_zone()[1]"},{"line_number":138,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zones_client, zone[\u0027id\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        json_path \u003d os.path.join("},{"line_number":141,"context_line":"            os.path.dirname(__file__),"},{"line_number":142,"context_line":"            \u0027recordset_wildcard_data.json\u0027).replace(\u0027scenario\u0027, \u0027api\u0027)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        isFileExits \u003d os.path.exists(json_path)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9bbd752d_e4848ed6","line":142,"range":{"start_line":140,"start_character":0,"end_line":142,"end_character":70},"in_reply_to":"d3e7e897_5fe63595","updated":"2022-04-18 05:57:25.000000000","message":"Done","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"adba456b0990d0d662eb6b79a41abd53b55d96eb","unresolved":true,"context_lines":[{"line_number":141,"context_line":"            os.path.dirname(__file__),"},{"line_number":142,"context_line":"            \u0027recordset_wildcard_data.json\u0027).replace(\u0027scenario\u0027, \u0027api\u0027)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        isFileExits \u003d os.path.exists(json_path)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if not isFileExits:"},{"line_number":147,"context_line":"            raise self.skipException("},{"line_number":148,"context_line":"                \"Could not find \u0027recordset_wildcard_data.json\u0027\")"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        file \u003d open(json_path, \"r\")"},{"line_number":151,"context_line":"        load_file \u003d json.loads(file.read())"}],"source_content_type":"text/x-python","patch_set":3,"id":"19f3f7b1_9854e186","line":148,"range":{"start_line":144,"start_character":0,"end_line":148,"end_character":64},"updated":"2022-04-04 11:47:37.000000000","message":"1) We don\u0027t really need \"isFileExits\", so I think that we can simply do:\n\n        if not os.path.exists(json_path):\n            raise self.skipException(\n                \"Could not find \u0027recordset_wildcard_data.json\u0027\")\n2) This \"skip\" check is supposed to be the first thing that is done in your test. \nCurrent code (assuming that not *json is exists) will create a zone first and only then will skip the test (cleanup will run as well) and we must to avoid any stuff creation that might be not relevant.","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"f0212b5fcba9777b4feae559e5c4f1ff6e1cb3ab","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            os.path.dirname(__file__),"},{"line_number":142,"context_line":"            \u0027recordset_wildcard_data.json\u0027).replace(\u0027scenario\u0027, \u0027api\u0027)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        isFileExits \u003d os.path.exists(json_path)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if not isFileExits:"},{"line_number":147,"context_line":"            raise self.skipException("},{"line_number":148,"context_line":"                \"Could not find \u0027recordset_wildcard_data.json\u0027\")"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        file \u003d open(json_path, \"r\")"},{"line_number":151,"context_line":"        load_file \u003d json.loads(file.read())"}],"source_content_type":"text/x-python","patch_set":3,"id":"3770670f_105f32d8","line":148,"range":{"start_line":144,"start_character":0,"end_line":148,"end_character":64},"in_reply_to":"19f3f7b1_9854e186","updated":"2022-04-05 13:48:21.000000000","message":"Done","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"adba456b0990d0d662eb6b79a41abd53b55d96eb","unresolved":true,"context_lines":[{"line_number":151,"context_line":"        load_file \u003d json.loads(file.read())"},{"line_number":152,"context_line":"        count_records \u003d 0"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        for record_type, record_data in load_file.items():"},{"line_number":155,"context_line":"            if record_data[\u0027name\u0027] is not None:"},{"line_number":156,"context_line":"                record_name \u003d record_data[\u0027name\u0027] + \".\" + zone[\u0027name\u0027]"},{"line_number":157,"context_line":"                count_records +\u003d len(record_data[\u0027records\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"2860fedf_15630ac2","line":154,"range":{"start_line":154,"start_character":12,"end_line":154,"end_character":23},"updated":"2022-04-04 11:47:37.000000000","message":"I don\u0027t see that the \"record_type\" is used anywhere.","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"f0212b5fcba9777b4feae559e5c4f1ff6e1cb3ab","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        load_file \u003d json.loads(file.read())"},{"line_number":152,"context_line":"        count_records \u003d 0"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        for record_type, record_data in load_file.items():"},{"line_number":155,"context_line":"            if record_data[\u0027name\u0027] is not None:"},{"line_number":156,"context_line":"                record_name \u003d record_data[\u0027name\u0027] + \".\" + zone[\u0027name\u0027]"},{"line_number":157,"context_line":"                count_records +\u003d len(record_data[\u0027records\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"40385638_2d3ecb76","line":154,"range":{"start_line":154,"start_character":12,"end_line":154,"end_character":23},"in_reply_to":"2860fedf_15630ac2","updated":"2022-04-05 13:48:21.000000000","message":"Done","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"adba456b0990d0d662eb6b79a41abd53b55d96eb","unresolved":true,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        for record_type, record_data in load_file.items():"},{"line_number":155,"context_line":"            if record_data[\u0027name\u0027] is not None:"},{"line_number":156,"context_line":"                record_name \u003d record_data[\u0027name\u0027] + \".\" + zone[\u0027name\u0027]"},{"line_number":157,"context_line":"                count_records +\u003d len(record_data[\u0027records\u0027])"},{"line_number":158,"context_line":"            else:"},{"line_number":159,"context_line":"                record_name \u003d zone[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"87850f0f_9e8ff241","line":156,"range":{"start_line":156,"start_character":0,"end_line":156,"end_character":70},"updated":"2022-04-04 11:47:37.000000000","message":"What\u0027s the purpose of checking the record name?\nAFAIU, \"recordset_wildcard_data.json\" is used for a valid tests only and we don\u0027t expect empty names in it.","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"f0212b5fcba9777b4feae559e5c4f1ff6e1cb3ab","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        for record_type, record_data in load_file.items():"},{"line_number":155,"context_line":"            if record_data[\u0027name\u0027] is not None:"},{"line_number":156,"context_line":"                record_name \u003d record_data[\u0027name\u0027] + \".\" + zone[\u0027name\u0027]"},{"line_number":157,"context_line":"                count_records +\u003d len(record_data[\u0027records\u0027])"},{"line_number":158,"context_line":"            else:"},{"line_number":159,"context_line":"                record_name \u003d zone[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"31c4d04d_597eac4e","line":156,"range":{"start_line":156,"start_character":0,"end_line":156,"end_character":70},"in_reply_to":"87850f0f_9e8ff241","updated":"2022-04-05 13:48:21.000000000","message":"Done","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"adba456b0990d0d662eb6b79a41abd53b55d96eb","unresolved":true,"context_lines":[{"line_number":157,"context_line":"                count_records +\u003d len(record_data[\u0027records\u0027])"},{"line_number":158,"context_line":"            else:"},{"line_number":159,"context_line":"                record_name \u003d zone[\u0027name\u0027]"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            recordset_data \u003d {"},{"line_number":162,"context_line":"                \u0027name\u0027: record_name,"},{"line_number":163,"context_line":"                \u0027type\u0027: record_data[\u0027type\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"37392946_b1549c3a","line":160,"updated":"2022-04-04 11:47:37.000000000","message":"Increasing count_records counter is not relevant here?","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"f0212b5fcba9777b4feae559e5c4f1ff6e1cb3ab","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                count_records +\u003d len(record_data[\u0027records\u0027])"},{"line_number":158,"context_line":"            else:"},{"line_number":159,"context_line":"                record_name \u003d zone[\u0027name\u0027]"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            recordset_data \u003d {"},{"line_number":162,"context_line":"                \u0027name\u0027: record_name,"},{"line_number":163,"context_line":"                \u0027type\u0027: record_data[\u0027type\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"6aba5a87_24d2344e","line":160,"in_reply_to":"37392946_b1549c3a","updated":"2022-04-05 13:48:21.000000000","message":"Done","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"adba456b0990d0d662eb6b79a41abd53b55d96eb","unresolved":true,"context_lines":[{"line_number":158,"context_line":"            else:"},{"line_number":159,"context_line":"                record_name \u003d zone[\u0027name\u0027]"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            recordset_data \u003d {"},{"line_number":162,"context_line":"                \u0027name\u0027: record_name,"},{"line_number":163,"context_line":"                \u0027type\u0027: record_data[\u0027type\u0027],"},{"line_number":164,"context_line":"                \u0027records\u0027: record_data[\u0027records\u0027],"},{"line_number":165,"context_line":"            }"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"            LOG.info(\u0027Create a Recordset\u0027)"},{"line_number":168,"context_line":"            recordset \u003d self.recordset_client.create_recordset("},{"line_number":169,"context_line":"                zone[\u0027id\u0027], recordset_data)[1]"},{"line_number":170,"context_line":"            self.addCleanup(self.wait_recordset_delete,"},{"line_number":171,"context_line":"                            self.recordset_client, zone[\u0027id\u0027],"},{"line_number":172,"context_line":"                            recordset[\u0027id\u0027])"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        LOG.info(\u0027Create a zone export\u0027)"},{"line_number":175,"context_line":"        zone_export \u003d self.client.create_zone_export(zone[\u0027id\u0027])[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"30302e8c_54ca9415","line":172,"range":{"start_line":161,"start_character":0,"end_line":172,"end_character":44},"updated":"2022-04-04 11:47:37.000000000","message":"I think that the lines: 155-160 are not needed at all and that you just have to increase the \"count_records\" on any time when the recordset (L168) was successfully created.\nOtherwise, if you think that potentially it may fail (empty name as you have though) then consider adding \"try except clause\" or maybe creating a dedicated *json file under scenario test + removing \"patch and skip\" code.\n\nThink about that, maybe that our initiative to reuse the existing *.json form API was a bad idea 😞","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"f0212b5fcba9777b4feae559e5c4f1ff6e1cb3ab","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            else:"},{"line_number":159,"context_line":"                record_name \u003d zone[\u0027name\u0027]"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            recordset_data \u003d {"},{"line_number":162,"context_line":"                \u0027name\u0027: record_name,"},{"line_number":163,"context_line":"                \u0027type\u0027: record_data[\u0027type\u0027],"},{"line_number":164,"context_line":"                \u0027records\u0027: record_data[\u0027records\u0027],"},{"line_number":165,"context_line":"            }"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"            LOG.info(\u0027Create a Recordset\u0027)"},{"line_number":168,"context_line":"            recordset \u003d self.recordset_client.create_recordset("},{"line_number":169,"context_line":"                zone[\u0027id\u0027], recordset_data)[1]"},{"line_number":170,"context_line":"            self.addCleanup(self.wait_recordset_delete,"},{"line_number":171,"context_line":"                            self.recordset_client, zone[\u0027id\u0027],"},{"line_number":172,"context_line":"                            recordset[\u0027id\u0027])"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        LOG.info(\u0027Create a zone export\u0027)"},{"line_number":175,"context_line":"        zone_export \u003d self.client.create_zone_export(zone[\u0027id\u0027])[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"c4841b91_dcccb95a","line":172,"range":{"start_line":161,"start_character":0,"end_line":172,"end_character":44},"in_reply_to":"30302e8c_54ca9415","updated":"2022-04-05 13:48:21.000000000","message":"Done","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"adba456b0990d0d662eb6b79a41abd53b55d96eb","unresolved":true,"context_lines":[{"line_number":183,"context_line":"        self.assertEqual(zone[\u0027name\u0027], show_file.origin)"},{"line_number":184,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], show_file.ttl)"},{"line_number":185,"context_line":"        self.assertEqual("},{"line_number":186,"context_line":"            len(show_file.records), count_records,"},{"line_number":187,"context_line":"            \"The Recordsets count from JSON file don\u0027t match\""},{"line_number":188,"context_line":"            \"to the recordset are displayed in an exported zone file\")"},{"line_number":189,"context_line":"        file.close()"}],"source_content_type":"text/x-python","patch_set":3,"id":"6d4ee9e9_86fdfe90","line":186,"range":{"start_line":186,"start_character":0,"end_line":186,"end_character":50},"updated":"2022-04-04 11:47:37.000000000","message":"Bad order of the compared values.\nAn EXPECTED value (count_records in your case) is always coming first, I mean it should be changed to: len(count_records, show_file.records), ...","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"f0212b5fcba9777b4feae559e5c4f1ff6e1cb3ab","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.assertEqual(zone[\u0027name\u0027], show_file.origin)"},{"line_number":184,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], show_file.ttl)"},{"line_number":185,"context_line":"        self.assertEqual("},{"line_number":186,"context_line":"            len(show_file.records), count_records,"},{"line_number":187,"context_line":"            \"The Recordsets count from JSON file don\u0027t match\""},{"line_number":188,"context_line":"            \"to the recordset are displayed in an exported zone file\")"},{"line_number":189,"context_line":"        file.close()"}],"source_content_type":"text/x-python","patch_set":3,"id":"6d8bdd42_33b666cf","line":186,"range":{"start_line":186,"start_character":0,"end_line":186,"end_character":50},"in_reply_to":"6d4ee9e9_86fdfe90","updated":"2022-04-05 13:48:21.000000000","message":"my mistake, I\u0027ll change it to: ...count_records,len(show_file.records)","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"adba456b0990d0d662eb6b79a41abd53b55d96eb","unresolved":true,"context_lines":[{"line_number":184,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], show_file.ttl)"},{"line_number":185,"context_line":"        self.assertEqual("},{"line_number":186,"context_line":"            len(show_file.records), count_records,"},{"line_number":187,"context_line":"            \"The Recordsets count from JSON file don\u0027t match\""},{"line_number":188,"context_line":"            \"to the recordset are displayed in an exported zone file\")"},{"line_number":189,"context_line":"        file.close()"}],"source_content_type":"text/x-python","patch_set":3,"id":"476a4def_4b4c65cd","line":188,"range":{"start_line":187,"start_character":0,"end_line":188,"end_character":70},"updated":"2022-04-04 11:47:37.000000000","message":"Once fails, this message may mislead, why do you have to mention JSON file at all?\nThe message should say something like: \"The total number of records in exported zone file is not the same as the number of existing records within the test zone\"","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"f0212b5fcba9777b4feae559e5c4f1ff6e1cb3ab","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], show_file.ttl)"},{"line_number":185,"context_line":"        self.assertEqual("},{"line_number":186,"context_line":"            len(show_file.records), count_records,"},{"line_number":187,"context_line":"            \"The Recordsets count from JSON file don\u0027t match\""},{"line_number":188,"context_line":"            \"to the recordset are displayed in an exported zone file\")"},{"line_number":189,"context_line":"        file.close()"}],"source_content_type":"text/x-python","patch_set":3,"id":"d7a8ef25_bfd0397c","line":188,"range":{"start_line":187,"start_character":0,"end_line":188,"end_character":70},"in_reply_to":"476a4def_4b4c65cd","updated":"2022-04-05 13:48:21.000000000","message":"Done","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"adba456b0990d0d662eb6b79a41abd53b55d96eb","unresolved":true,"context_lines":[{"line_number":186,"context_line":"            len(show_file.records), count_records,"},{"line_number":187,"context_line":"            \"The Recordsets count from JSON file don\u0027t match\""},{"line_number":188,"context_line":"            \"to the recordset are displayed in an exported zone file\")"},{"line_number":189,"context_line":"        file.close()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ca214199_e40f4d03","line":189,"range":{"start_line":189,"start_character":0,"end_line":189,"end_character":20},"updated":"2022-04-04 11:47:37.000000000","message":"Any special reason for closing a file here, at the end of the test?","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"f0212b5fcba9777b4feae559e5c4f1ff6e1cb3ab","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            len(show_file.records), count_records,"},{"line_number":187,"context_line":"            \"The Recordsets count from JSON file don\u0027t match\""},{"line_number":188,"context_line":"            \"to the recordset are displayed in an exported zone file\")"},{"line_number":189,"context_line":"        file.close()"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfae2a08_fcd8f1e6","line":189,"range":{"start_line":189,"start_character":0,"end_line":189,"end_character":20},"in_reply_to":"ca214199_e40f4d03","updated":"2022-04-05 13:48:21.000000000","message":"Done","commit_id":"8cff86de3a4cef7447b9f7c267e40c01db23b7a0"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d7aebb9313e4ab48a4d6d0b9f6c246edd0341afb","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from designate_tempest_plugin.tests.api.v2.test_zones_exports import \\"},{"line_number":20,"context_line":"    BaseZoneExportsTest"},{"line_number":21,"context_line":"from designate_tempest_plugin.common import constants as const"},{"line_number":22,"context_line":"import json"},{"line_number":23,"context_line":"import os"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":4,"id":"8763781a_83b4df88","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":9},"updated":"2022-04-05 15:17:40.000000000","message":"You\u0027ve answered \"done\" for that one, but the \"imports\" order have remained the same as it was in #3, why?","commit_id":"b401ab8e77ef5b59d36b5afc8f6b1f356e521740"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"589d7f3dd305520485501f0aabc1e40dcdc4dd17","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from designate_tempest_plugin.tests.api.v2.test_zones_exports import \\"},{"line_number":20,"context_line":"    BaseZoneExportsTest"},{"line_number":21,"context_line":"from designate_tempest_plugin.common import constants as const"},{"line_number":22,"context_line":"import json"},{"line_number":23,"context_line":"import os"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e6bb01bb_225b268e","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":9},"in_reply_to":"8763781a_83b4df88","updated":"2022-04-18 05:57:25.000000000","message":"Done","commit_id":"b401ab8e77ef5b59d36b5afc8f6b1f356e521740"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d7aebb9313e4ab48a4d6d0b9f6c246edd0341afb","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        file \u003d open(json_path, \"r\")"},{"line_number":145,"context_line":"        load_file \u003d json.loads(file.read())"},{"line_number":146,"context_line":"        file.close()"},{"line_number":147,"context_line":"        count_records \u003d 0"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        LOG.info(\u0027create a zone\u0027)"},{"line_number":150,"context_line":"        zone \u003d self.zones_client.create_zone()[1]"}],"source_content_type":"text/x-python","patch_set":4,"id":"64aa5387_2ff990c8","line":147,"range":{"start_line":147,"start_character":0,"end_line":147,"end_character":25},"updated":"2022-04-05 15:17:40.000000000","message":"I think that it makes more sense moving this counter initiation beforre the loop, where it\u0027s actually used, means L152","commit_id":"b401ab8e77ef5b59d36b5afc8f6b1f356e521740"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"589d7f3dd305520485501f0aabc1e40dcdc4dd17","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        file \u003d open(json_path, \"r\")"},{"line_number":145,"context_line":"        load_file \u003d json.loads(file.read())"},{"line_number":146,"context_line":"        file.close()"},{"line_number":147,"context_line":"        count_records \u003d 0"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        LOG.info(\u0027create a zone\u0027)"},{"line_number":150,"context_line":"        zone \u003d self.zones_client.create_zone()[1]"}],"source_content_type":"text/x-python","patch_set":4,"id":"48230dfd_50dd6fee","line":147,"range":{"start_line":147,"start_character":0,"end_line":147,"end_character":25},"in_reply_to":"64aa5387_2ff990c8","updated":"2022-04-18 05:57:25.000000000","message":"Done","commit_id":"b401ab8e77ef5b59d36b5afc8f6b1f356e521740"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d7aebb9313e4ab48a4d6d0b9f6c246edd0341afb","unresolved":true,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        for record_data in load_file.values():"},{"line_number":154,"context_line":"            recordset_data \u003d {"},{"line_number":155,"context_line":"                \u0027name\u0027: record_data[\u0027name\u0027] + \".\" + zone[\u0027name\u0027],"},{"line_number":156,"context_line":"                \u0027type\u0027: record_data[\u0027type\u0027],"},{"line_number":157,"context_line":"                \u0027records\u0027: record_data[\u0027records\u0027],"},{"line_number":158,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":4,"id":"036b8ce0_66b5c99e","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":65},"updated":"2022-04-05 15:17:40.000000000","message":"I would recommend to replace to use \"format\" and not \"+\" here.","commit_id":"b401ab8e77ef5b59d36b5afc8f6b1f356e521740"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"589d7f3dd305520485501f0aabc1e40dcdc4dd17","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        for record_data in load_file.values():"},{"line_number":154,"context_line":"            recordset_data \u003d {"},{"line_number":155,"context_line":"                \u0027name\u0027: record_data[\u0027name\u0027] + \".\" + zone[\u0027name\u0027],"},{"line_number":156,"context_line":"                \u0027type\u0027: record_data[\u0027type\u0027],"},{"line_number":157,"context_line":"                \u0027records\u0027: record_data[\u0027records\u0027],"},{"line_number":158,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":4,"id":"f42db52f_2b0f84b1","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":65},"in_reply_to":"036b8ce0_66b5c99e","updated":"2022-04-18 05:57:25.000000000","message":"Done","commit_id":"b401ab8e77ef5b59d36b5afc8f6b1f356e521740"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d7aebb9313e4ab48a4d6d0b9f6c246edd0341afb","unresolved":true,"context_lines":[{"line_number":156,"context_line":"                \u0027type\u0027: record_data[\u0027type\u0027],"},{"line_number":157,"context_line":"                \u0027records\u0027: record_data[\u0027records\u0027],"},{"line_number":158,"context_line":"            }"},{"line_number":159,"context_line":"            count_records +\u003d len(record_data[\u0027records\u0027])"},{"line_number":160,"context_line":"            LOG.info(\u0027Create a Recordset\u0027)"},{"line_number":161,"context_line":"            recordset \u003d self.recordset_client.create_recordset("},{"line_number":162,"context_line":"                zone[\u0027id\u0027], recordset_data)[1]"}],"source_content_type":"text/x-python","patch_set":4,"id":"12265048_09f1f94a","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":56},"updated":"2022-04-05 15:17:40.000000000","message":"I think that this counter should be increased only after recordset create is PASS.","commit_id":"b401ab8e77ef5b59d36b5afc8f6b1f356e521740"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"589d7f3dd305520485501f0aabc1e40dcdc4dd17","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                \u0027type\u0027: record_data[\u0027type\u0027],"},{"line_number":157,"context_line":"                \u0027records\u0027: record_data[\u0027records\u0027],"},{"line_number":158,"context_line":"            }"},{"line_number":159,"context_line":"            count_records +\u003d len(record_data[\u0027records\u0027])"},{"line_number":160,"context_line":"            LOG.info(\u0027Create a Recordset\u0027)"},{"line_number":161,"context_line":"            recordset \u003d self.recordset_client.create_recordset("},{"line_number":162,"context_line":"                zone[\u0027id\u0027], recordset_data)[1]"}],"source_content_type":"text/x-python","patch_set":4,"id":"cf5d5a71_fad96860","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":56},"in_reply_to":"12265048_09f1f94a","updated":"2022-04-18 05:57:25.000000000","message":"Done","commit_id":"b401ab8e77ef5b59d36b5afc8f6b1f356e521740"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d7aebb9313e4ab48a4d6d0b9f6c246edd0341afb","unresolved":true,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        LOG.info(\u0027Show exported zonefile\u0027)"},{"line_number":175,"context_line":"        show_file \u003d self.client.show_exported_zonefile(zone_export[\u0027id\u0027])[1]"},{"line_number":176,"context_line":"        self.assertEqual(zone[\u0027name\u0027], show_file.origin)"},{"line_number":177,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], show_file.ttl)"},{"line_number":178,"context_line":"        self.assertEqual("},{"line_number":179,"context_line":"            count_records, len(show_file.records),"},{"line_number":180,"context_line":"            \"The total number of records in exported zone file\""}],"source_content_type":"text/x-python","patch_set":4,"id":"d524946b_2438c07f","line":177,"range":{"start_line":176,"start_character":0,"end_line":177,"end_character":52},"updated":"2022-04-05 15:17:40.000000000","message":"These two assertions are not really related to your test logic + both are already tested in other scenario test, so I think that it would have made more sense to remove them and to save some test time execution.","commit_id":"b401ab8e77ef5b59d36b5afc8f6b1f356e521740"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"589d7f3dd305520485501f0aabc1e40dcdc4dd17","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        LOG.info(\u0027Show exported zonefile\u0027)"},{"line_number":175,"context_line":"        show_file \u003d self.client.show_exported_zonefile(zone_export[\u0027id\u0027])[1]"},{"line_number":176,"context_line":"        self.assertEqual(zone[\u0027name\u0027], show_file.origin)"},{"line_number":177,"context_line":"        self.assertEqual(zone[\u0027ttl\u0027], show_file.ttl)"},{"line_number":178,"context_line":"        self.assertEqual("},{"line_number":179,"context_line":"            count_records, len(show_file.records),"},{"line_number":180,"context_line":"            \"The total number of records in exported zone file\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9b89f2a3_7c2d4d47","line":177,"range":{"start_line":176,"start_character":0,"end_line":177,"end_character":52},"in_reply_to":"d524946b_2438c07f","updated":"2022-04-18 05:57:25.000000000","message":"Done","commit_id":"b401ab8e77ef5b59d36b5afc8f6b1f356e521740"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"72bad9b4df6ac5d15139acf1620ad705b8e8a42e","unresolved":true,"context_lines":[{"line_number":157,"context_line":"                \u0027records\u0027: record_data[\u0027records\u0027],"},{"line_number":158,"context_line":"            }"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"            LOG.info(\u0027Create a Recordset\u0027)"},{"line_number":161,"context_line":"            recordset \u003d self.recordset_client.create_recordset("},{"line_number":162,"context_line":"                zone[\u0027id\u0027], recordset_data)[1]"},{"line_number":163,"context_line":"            waiters.wait_for_recordset_status(self.recordset_client,"},{"line_number":164,"context_line":"                                          zone[\u0027id\u0027], recordset[\u0027id\u0027],"},{"line_number":165,"context_line":"                                          const.ACTIVE)"},{"line_number":166,"context_line":"            created_records.append("},{"line_number":167,"context_line":"                tuple([recordset[\u0027type\u0027], recordset[\u0027records\u0027]]))"},{"line_number":168,"context_line":"        self.addCleanup(self.wait_recordset_delete,"}],"source_content_type":"text/x-python","patch_set":5,"id":"d0fccb3b_760f0089","line":165,"range":{"start_line":160,"start_character":0,"end_line":165,"end_character":55},"updated":"2022-04-18 08:13:59.000000000","message":"I still think that we need \"try except\" here to avoid this test failure if some type failed to be created. We have a dedicated test to validate the creation of all types and this test is supposed to check something else (all successfully created records presents in zonefile).","commit_id":"525ad47213f83eb23c6d30bb5ffba70a447bd4dc"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"c9fd610ab0d338adf577721ebac8c546e9373faf","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                \u0027records\u0027: record_data[\u0027records\u0027],"},{"line_number":158,"context_line":"            }"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"            LOG.info(\u0027Create a Recordset\u0027)"},{"line_number":161,"context_line":"            recordset \u003d self.recordset_client.create_recordset("},{"line_number":162,"context_line":"                zone[\u0027id\u0027], recordset_data)[1]"},{"line_number":163,"context_line":"            waiters.wait_for_recordset_status(self.recordset_client,"},{"line_number":164,"context_line":"                                          zone[\u0027id\u0027], recordset[\u0027id\u0027],"},{"line_number":165,"context_line":"                                          const.ACTIVE)"},{"line_number":166,"context_line":"            created_records.append("},{"line_number":167,"context_line":"                tuple([recordset[\u0027type\u0027], recordset[\u0027records\u0027]]))"},{"line_number":168,"context_line":"        self.addCleanup(self.wait_recordset_delete,"}],"source_content_type":"text/x-python","patch_set":5,"id":"6da1fb0b_0a10e1c0","line":165,"range":{"start_line":160,"start_character":0,"end_line":165,"end_character":55},"in_reply_to":"d0fccb3b_760f0089","updated":"2022-04-25 11:31:44.000000000","message":"Done","commit_id":"525ad47213f83eb23c6d30bb5ffba70a447bd4dc"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"72bad9b4df6ac5d15139acf1620ad705b8e8a42e","unresolved":true,"context_lines":[{"line_number":164,"context_line":"                                          zone[\u0027id\u0027], recordset[\u0027id\u0027],"},{"line_number":165,"context_line":"                                          const.ACTIVE)"},{"line_number":166,"context_line":"            created_records.append("},{"line_number":167,"context_line":"                tuple([recordset[\u0027type\u0027], recordset[\u0027records\u0027]]))"},{"line_number":168,"context_line":"        self.addCleanup(self.wait_recordset_delete,"},{"line_number":169,"context_line":"                        self.recordset_client, zone[\u0027id\u0027],"},{"line_number":170,"context_line":"                        recordset[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"52e32ea2_044e6b53","line":167,"range":{"start_line":167,"start_character":16,"end_line":167,"end_character":21},"updated":"2022-04-18 08:13:59.000000000","message":"Why casting to a tuple is needed here?\nThis is not the way to define tuple in python.","commit_id":"525ad47213f83eb23c6d30bb5ffba70a447bd4dc"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"c9fd610ab0d338adf577721ebac8c546e9373faf","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                          zone[\u0027id\u0027], recordset[\u0027id\u0027],"},{"line_number":165,"context_line":"                                          const.ACTIVE)"},{"line_number":166,"context_line":"            created_records.append("},{"line_number":167,"context_line":"                tuple([recordset[\u0027type\u0027], recordset[\u0027records\u0027]]))"},{"line_number":168,"context_line":"        self.addCleanup(self.wait_recordset_delete,"},{"line_number":169,"context_line":"                        self.recordset_client, zone[\u0027id\u0027],"},{"line_number":170,"context_line":"                        recordset[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"47444ee3_fd10ab61","line":167,"range":{"start_line":167,"start_character":16,"end_line":167,"end_character":21},"in_reply_to":"52e32ea2_044e6b53","updated":"2022-04-25 11:31:44.000000000","message":"Done","commit_id":"525ad47213f83eb23c6d30bb5ffba70a447bd4dc"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"72bad9b4df6ac5d15139acf1620ad705b8e8a42e","unresolved":true,"context_lines":[{"line_number":165,"context_line":"                                          const.ACTIVE)"},{"line_number":166,"context_line":"            created_records.append("},{"line_number":167,"context_line":"                tuple([recordset[\u0027type\u0027], recordset[\u0027records\u0027]]))"},{"line_number":168,"context_line":"        self.addCleanup(self.wait_recordset_delete,"},{"line_number":169,"context_line":"                        self.recordset_client, zone[\u0027id\u0027],"},{"line_number":170,"context_line":"                        recordset[\u0027id\u0027])"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        LOG.info(\u0027Create a zone export\u0027)"},{"line_number":173,"context_line":"        zone_export \u003d self.client.create_zone_export("}],"source_content_type":"text/x-python","patch_set":5,"id":"2cd70a3c_1cab286b","line":170,"range":{"start_line":168,"start_character":0,"end_line":170,"end_character":40},"updated":"2022-04-18 08:13:59.000000000","message":"Why this cleanup is out of \"for loop?\"","commit_id":"525ad47213f83eb23c6d30bb5ffba70a447bd4dc"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"c9fd610ab0d338adf577721ebac8c546e9373faf","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                                          const.ACTIVE)"},{"line_number":166,"context_line":"            created_records.append("},{"line_number":167,"context_line":"                tuple([recordset[\u0027type\u0027], recordset[\u0027records\u0027]]))"},{"line_number":168,"context_line":"        self.addCleanup(self.wait_recordset_delete,"},{"line_number":169,"context_line":"                        self.recordset_client, zone[\u0027id\u0027],"},{"line_number":170,"context_line":"                        recordset[\u0027id\u0027])"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        LOG.info(\u0027Create a zone export\u0027)"},{"line_number":173,"context_line":"        zone_export \u003d self.client.create_zone_export("}],"source_content_type":"text/x-python","patch_set":5,"id":"080a0c9b_17e4dede","line":170,"range":{"start_line":168,"start_character":0,"end_line":170,"end_character":40},"in_reply_to":"2cd70a3c_1cab286b","updated":"2022-04-25 11:31:44.000000000","message":"Done","commit_id":"525ad47213f83eb23c6d30bb5ffba70a447bd4dc"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"72bad9b4df6ac5d15139acf1620ad705b8e8a42e","unresolved":true,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        zonefile_list \u003d []"},{"line_number":182,"context_line":"        for t in created_zonefile.records:"},{"line_number":183,"context_line":"            zonefile_list.append(tuple([t.type, t.data]))"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        for record in created_records:"},{"line_number":186,"context_line":"            self.assertIn("}],"source_content_type":"text/x-python","patch_set":5,"id":"f222f041_0247b4f9","line":183,"range":{"start_line":183,"start_character":33,"end_line":183,"end_character":38},"updated":"2022-04-18 08:13:59.000000000","message":"Same as in L167","commit_id":"525ad47213f83eb23c6d30bb5ffba70a447bd4dc"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"c9fd610ab0d338adf577721ebac8c546e9373faf","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        zonefile_list \u003d []"},{"line_number":182,"context_line":"        for t in created_zonefile.records:"},{"line_number":183,"context_line":"            zonefile_list.append(tuple([t.type, t.data]))"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        for record in created_records:"},{"line_number":186,"context_line":"            self.assertIn("}],"source_content_type":"text/x-python","patch_set":5,"id":"32efb0f4_b5cd46fc","line":183,"range":{"start_line":183,"start_character":33,"end_line":183,"end_character":38},"in_reply_to":"f222f041_0247b4f9","updated":"2022-04-25 11:31:44.000000000","message":"Done","commit_id":"525ad47213f83eb23c6d30bb5ffba70a447bd4dc"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"72bad9b4df6ac5d15139acf1620ad705b8e8a42e","unresolved":true,"context_lines":[{"line_number":185,"context_line":"        for record in created_records:"},{"line_number":186,"context_line":"            self.assertIn("},{"line_number":187,"context_line":"                record[0], [item[0] for item in zonefile_list],"},{"line_number":188,"context_line":"                f\"Failed, expected type: {record[0]} in zone file\")"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"            for r in record[1]:"},{"line_number":191,"context_line":"                self.assertIn(r, [item[1] for item in zonefile_list],"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf44e973_b7b8efff","line":188,"range":{"start_line":188,"start_character":0,"end_line":188,"end_character":67},"updated":"2022-04-18 08:13:59.000000000","message":"This message is incorrect, maybe \"not in\" or missing.","commit_id":"525ad47213f83eb23c6d30bb5ffba70a447bd4dc"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"c9fd610ab0d338adf577721ebac8c546e9373faf","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        for record in created_records:"},{"line_number":186,"context_line":"            self.assertIn("},{"line_number":187,"context_line":"                record[0], [item[0] for item in zonefile_list],"},{"line_number":188,"context_line":"                f\"Failed, expected type: {record[0]} in zone file\")"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"            for r in record[1]:"},{"line_number":191,"context_line":"                self.assertIn(r, [item[1] for item in zonefile_list],"}],"source_content_type":"text/x-python","patch_set":5,"id":"006ed246_26feecb2","line":188,"range":{"start_line":188,"start_character":0,"end_line":188,"end_character":67},"in_reply_to":"bf44e973_b7b8efff","updated":"2022-04-25 11:31:44.000000000","message":"Done","commit_id":"525ad47213f83eb23c6d30bb5ffba70a447bd4dc"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"72bad9b4df6ac5d15139acf1620ad705b8e8a42e","unresolved":true,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"            for r in record[1]:"},{"line_number":191,"context_line":"                self.assertIn(r, [item[1] for item in zonefile_list],"},{"line_number":192,"context_line":"                              f\"Failed, expected record: {r} in zone file\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"88819758_e0dbb0da","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":75},"updated":"2022-04-18 08:13:59.000000000","message":"Same as in L188","commit_id":"525ad47213f83eb23c6d30bb5ffba70a447bd4dc"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"c9fd610ab0d338adf577721ebac8c546e9373faf","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"            for r in record[1]:"},{"line_number":191,"context_line":"                self.assertIn(r, [item[1] for item in zonefile_list],"},{"line_number":192,"context_line":"                              f\"Failed, expected record: {r} in zone file\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"97d7f4f9_878948c5","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":75},"in_reply_to":"88819758_e0dbb0da","updated":"2022-04-25 11:31:44.000000000","message":"Done","commit_id":"525ad47213f83eb23c6d30bb5ffba70a447bd4dc"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"72bad9b4df6ac5d15139acf1620ad705b8e8a42e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"da4d797e_a4096810","line":193,"range":{"start_line":180,"start_character":0,"end_line":193,"end_character":0},"updated":"2022-04-18 08:13:59.000000000","message":"This is not the most efficient way to check what we need.\nhttp://pastebin.test.redhat.com/1045382","commit_id":"525ad47213f83eb23c6d30bb5ffba70a447bd4dc"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"c9fd610ab0d338adf577721ebac8c546e9373faf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"081ab0e9_44d08787","line":193,"range":{"start_line":180,"start_character":0,"end_line":193,"end_character":0},"in_reply_to":"da4d797e_a4096810","updated":"2022-04-25 11:31:44.000000000","message":"Done","commit_id":"525ad47213f83eb23c6d30bb5ffba70a447bd4dc"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"87c25e4f4f134839478a276b489968b90bdba4b9","unresolved":true,"context_lines":[{"line_number":134,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":135,"context_line":"    @decorators.idempotent_id(\u0027d8f444aa-a645-4a03-b366-46836f57dc69\u0027)"},{"line_number":136,"context_line":"    def test_all_recordset_types_exist_in_show_zonefile(self):"},{"line_number":137,"context_line":"        file_path \u003d os.path.join("},{"line_number":138,"context_line":"            os.path.dirname(__file__), \u0027recordset_data.json\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        if not os.path.exists(file_path):"}],"source_content_type":"text/x-python","patch_set":6,"id":"d3514c0b_b439ae1b","line":137,"range":{"start_line":137,"start_character":8,"end_line":137,"end_character":17},"updated":"2022-04-24 10:19:21.000000000","message":"Nit\n\nInstead of \"file_path\" it cold be something more informative, like \"recorsets_data_file\" or something like that.","commit_id":"1d5bc9a6efef5aaac344d7d74ff5a75687ed05b9"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"4815652aeb2c633f2452a4a2371812fff963d4d7","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":135,"context_line":"    @decorators.idempotent_id(\u0027d8f444aa-a645-4a03-b366-46836f57dc69\u0027)"},{"line_number":136,"context_line":"    def test_all_recordset_types_exist_in_show_zonefile(self):"},{"line_number":137,"context_line":"        file_path \u003d os.path.join("},{"line_number":138,"context_line":"            os.path.dirname(__file__), \u0027recordset_data.json\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        if not os.path.exists(file_path):"}],"source_content_type":"text/x-python","patch_set":6,"id":"78fd24a4_ad286759","line":137,"range":{"start_line":137,"start_character":8,"end_line":137,"end_character":17},"in_reply_to":"d3514c0b_b439ae1b","updated":"2022-04-25 11:31:07.000000000","message":"Done","commit_id":"1d5bc9a6efef5aaac344d7d74ff5a75687ed05b9"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"87c25e4f4f134839478a276b489968b90bdba4b9","unresolved":true,"context_lines":[{"line_number":165,"context_line":"                                                  zone[\u0027id\u0027], recordset[\u0027id\u0027],"},{"line_number":166,"context_line":"                                                  const.ACTIVE)"},{"line_number":167,"context_line":"            except Exception as err:"},{"line_number":168,"context_line":"                LOG.warning(f\"Record of type {recordset[\u0027type\u0027]} could not be\""},{"line_number":169,"context_line":"                            f\" created failed with error: {err}\")"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"            created_records.append(recordset[\u0027records\u0027])"},{"line_number":172,"context_line":"            self.addCleanup(self.wait_recordset_delete,"}],"source_content_type":"text/x-python","patch_set":6,"id":"697c9ecf_539d0c39","line":169,"range":{"start_line":168,"start_character":0,"end_line":169,"end_character":65},"updated":"2022-04-24 10:19:21.000000000","message":"\"...created failed...\", maybe \"...created and failed...\" ?","commit_id":"1d5bc9a6efef5aaac344d7d74ff5a75687ed05b9"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"4815652aeb2c633f2452a4a2371812fff963d4d7","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                                                  zone[\u0027id\u0027], recordset[\u0027id\u0027],"},{"line_number":166,"context_line":"                                                  const.ACTIVE)"},{"line_number":167,"context_line":"            except Exception as err:"},{"line_number":168,"context_line":"                LOG.warning(f\"Record of type {recordset[\u0027type\u0027]} could not be\""},{"line_number":169,"context_line":"                            f\" created failed with error: {err}\")"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"            created_records.append(recordset[\u0027records\u0027])"},{"line_number":172,"context_line":"            self.addCleanup(self.wait_recordset_delete,"}],"source_content_type":"text/x-python","patch_set":6,"id":"4e2c69a8_5f1163a1","line":169,"range":{"start_line":168,"start_character":0,"end_line":169,"end_character":65},"in_reply_to":"697c9ecf_539d0c39","updated":"2022-04-25 11:31:07.000000000","message":"Done","commit_id":"1d5bc9a6efef5aaac344d7d74ff5a75687ed05b9"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"87c25e4f4f134839478a276b489968b90bdba4b9","unresolved":true,"context_lines":[{"line_number":168,"context_line":"                LOG.warning(f\"Record of type {recordset[\u0027type\u0027]} could not be\""},{"line_number":169,"context_line":"                            f\" created failed with error: {err}\")"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"            created_records.append(recordset[\u0027records\u0027])"},{"line_number":172,"context_line":"            self.addCleanup(self.wait_recordset_delete,"},{"line_number":173,"context_line":"                            self.recordset_client, zone[\u0027id\u0027],"},{"line_number":174,"context_line":"                            recordset[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"8faa20a5_95b11605","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":56},"updated":"2022-04-24 10:19:21.000000000","message":"This should come after the cleanup","commit_id":"1d5bc9a6efef5aaac344d7d74ff5a75687ed05b9"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"4815652aeb2c633f2452a4a2371812fff963d4d7","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                LOG.warning(f\"Record of type {recordset[\u0027type\u0027]} could not be\""},{"line_number":169,"context_line":"                            f\" created failed with error: {err}\")"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"            created_records.append(recordset[\u0027records\u0027])"},{"line_number":172,"context_line":"            self.addCleanup(self.wait_recordset_delete,"},{"line_number":173,"context_line":"                            self.recordset_client, zone[\u0027id\u0027],"},{"line_number":174,"context_line":"                            recordset[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"4ea793b1_77eaed59","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":56},"in_reply_to":"8faa20a5_95b11605","updated":"2022-04-25 11:31:07.000000000","message":"Done","commit_id":"1d5bc9a6efef5aaac344d7d74ff5a75687ed05b9"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"87c25e4f4f134839478a276b489968b90bdba4b9","unresolved":true,"context_lines":[{"line_number":169,"context_line":"                            f\" created failed with error: {err}\")"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"            created_records.append(recordset[\u0027records\u0027])"},{"line_number":172,"context_line":"            self.addCleanup(self.wait_recordset_delete,"},{"line_number":173,"context_line":"                            self.recordset_client, zone[\u0027id\u0027],"},{"line_number":174,"context_line":"                            recordset[\u0027id\u0027])"},{"line_number":175,"context_line":"        LOG.info(\u0027Create a zone export\u0027)"},{"line_number":176,"context_line":"        zone_export \u003d self.client.create_zone_export("},{"line_number":177,"context_line":"            zone[\u0027id\u0027], wait_until\u003dconst.COMPLETE)[1]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3e821fca_1e88b5f7","line":174,"range":{"start_line":172,"start_character":0,"end_line":174,"end_character":44},"updated":"2022-04-24 10:19:21.000000000","message":"This should come immediately after creation, it means L:163","commit_id":"1d5bc9a6efef5aaac344d7d74ff5a75687ed05b9"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"4815652aeb2c633f2452a4a2371812fff963d4d7","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                            f\" created failed with error: {err}\")"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"            created_records.append(recordset[\u0027records\u0027])"},{"line_number":172,"context_line":"            self.addCleanup(self.wait_recordset_delete,"},{"line_number":173,"context_line":"                            self.recordset_client, zone[\u0027id\u0027],"},{"line_number":174,"context_line":"                            recordset[\u0027id\u0027])"},{"line_number":175,"context_line":"        LOG.info(\u0027Create a zone export\u0027)"},{"line_number":176,"context_line":"        zone_export \u003d self.client.create_zone_export("},{"line_number":177,"context_line":"            zone[\u0027id\u0027], wait_until\u003dconst.COMPLETE)[1]"}],"source_content_type":"text/x-python","patch_set":6,"id":"4e2643ac_6df3890f","line":174,"range":{"start_line":172,"start_character":0,"end_line":174,"end_character":44},"in_reply_to":"3e821fca_1e88b5f7","updated":"2022-04-25 11:31:07.000000000","message":"Done","commit_id":"1d5bc9a6efef5aaac344d7d74ff5a75687ed05b9"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"87c25e4f4f134839478a276b489968b90bdba4b9","unresolved":true,"context_lines":[{"line_number":181,"context_line":"        created_zonefile \u003d self.client.show_exported_zonefile("},{"line_number":182,"context_line":"            zone_export[\u0027id\u0027])[1]"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        file_records \u003d [item.data for item in created_zonefile.records]"},{"line_number":185,"context_line":"        for record in created_records:"},{"line_number":186,"context_line":"            for r in record:"},{"line_number":187,"context_line":"                self.assertIn(r, [item for item in file_records],"},{"line_number":188,"context_line":"                            f\"Failed, missing record: {r} in zone file\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"ddf37bf6_650af9cd","line":188,"range":{"start_line":184,"start_character":0,"end_line":188,"end_character":72},"updated":"2022-04-24 10:19:21.000000000","message":"I don\u0027t think that the assertion is supposed to be so much complicated.\nDouble loop that includes \"list comprehension\" and that is regenerated all the time.\n\nThe assertion we need, could be done in a single loop as my suggestion was in: \nhttp://pastebin.test.redhat.com/1045382","commit_id":"1d5bc9a6efef5aaac344d7d74ff5a75687ed05b9"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"4815652aeb2c633f2452a4a2371812fff963d4d7","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        created_zonefile \u003d self.client.show_exported_zonefile("},{"line_number":182,"context_line":"            zone_export[\u0027id\u0027])[1]"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        file_records \u003d [item.data for item in created_zonefile.records]"},{"line_number":185,"context_line":"        for record in created_records:"},{"line_number":186,"context_line":"            for r in record:"},{"line_number":187,"context_line":"                self.assertIn(r, [item for item in file_records],"},{"line_number":188,"context_line":"                            f\"Failed, missing record: {r} in zone file\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"6e52e79c_9d25be58","line":188,"range":{"start_line":184,"start_character":0,"end_line":188,"end_character":72},"in_reply_to":"ddf37bf6_650af9cd","updated":"2022-04-25 11:31:07.000000000","message":"Hi Arkady,\nI know it looks complicated but we have list inside list and when we create the recordset, she create record for each index inside the list .\nso to make sure the record exist in \"file_records\" we need to use loop for each index inside record and compare it to the \"file_records\".\n\nUnfortunately, your suggestion does half work:\nhttp://pastebin.test.redhat.com/1047046\n\n\nI prefer to keep it that way because it does make sure that all the records do exist 😊","commit_id":"1d5bc9a6efef5aaac344d7d74ff5a75687ed05b9"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"bcf13b1ca749a0d5e14507760798bc086293beda","unresolved":true,"context_lines":[{"line_number":183,"context_line":"        file_records \u003d [item.data for item in created_zonefile.records]"},{"line_number":184,"context_line":"        for record in created_records:"},{"line_number":185,"context_line":"            for r in record:"},{"line_number":186,"context_line":"                self.assertIn(r, [item for item in file_records],"},{"line_number":187,"context_line":"                            f\"Failed, missing record: {r} in zone file\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"ddfd0f0c_1a2b485a","line":186,"range":{"start_line":186,"start_character":33,"end_line":186,"end_character":64},"updated":"2022-04-25 13:12:45.000000000","message":"Why do we need this list comprehensions here?\nIt could be just:\n\nfor record in created_records:\n    for r in record:\n        self.assertIn(r, file_records, f\"Failed, missing record: {r} in zone file\")","commit_id":"8ffc57d3c20652fd28a1a6cfd8db7e28b7c1f369"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"67f5aa551b817e8ec589fa4a7e049619abb0eb35","unresolved":true,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import json"},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":"from oslo_log import log as logging"},{"line_number":18,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":8,"id":"af9075cb_50bb4f12","line":15,"updated":"2022-05-06 22:47:12.000000000","message":"nit: It\u0027s preferable to use the oslo serialization library than directly using json.\n\nfrom oslo_serialization import jsonutils\n\nhttps://docs.openstack.org/oslo.serialization/latest/reference/index.html#oslo_serialization.jsonutils.loads\n\nIt\u0027s a nit as this isn\u0027t as important in the test suite.","commit_id":"e5957b60d3ec506156de6f3df3fe29929518671b"}]}