)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"428b9c1373a0a402270a94b16848148e3a4cf9ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"945e47ae_e181a4fc","updated":"2022-05-06 18:20:31.000000000","message":"These tests are setup wrong and that is why they are failing.","commit_id":"e812ec5f35b03f9fd2a23b3392748265b2ed2aca"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"640fb645c84573df2bbc5fb29d7ff66966529f66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e1141fbd_1e26970b","updated":"2022-04-11 15:21:45.000000000","message":"recheck","commit_id":"e812ec5f35b03f9fd2a23b3392748265b2ed2aca"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"3b7e7f740ef7e6bbfaea6ba6fc620d38a896636c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"eebffe68_a6e3f7ae","updated":"2023-01-11 19:21:57.000000000","message":"See comment:","commit_id":"6aeed0d90567408179b4ea319871b789e8d75970"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"79ac6dfc36219e454b86b9751c0befeed8e73543","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4eafe263_3554f8fb","updated":"2023-07-20 11:47:45.000000000","message":"The implementation has incorrect behavior for some edge cases.","commit_id":"6aeed0d90567408179b4ea319871b789e8d75970"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"2c73535d467455de9958041ab72d678cbaa97fc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a1ddcd10_eca12843","updated":"2023-06-20 09:09:22.000000000","message":"recheck","commit_id":"6aeed0d90567408179b4ea319871b789e8d75970"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5ced7143719d9533d5b41b5a1f7027922ad9fd8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a1e2a4b3_666fe4f9","updated":"2022-12-29 08:22:39.000000000","message":"recheck","commit_id":"6aeed0d90567408179b4ea319871b789e8d75970"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1fb2053c905edc7a9ddad88cad960de8a2620791","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b5870352_d0100335","updated":"2023-04-16 16:31:35.000000000","message":"recheck","commit_id":"6aeed0d90567408179b4ea319871b789e8d75970"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5cfdf7f8a837459774e24c19ab98b7043d920beb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cebd3e00_8b7e8c23","updated":"2022-08-09 09:34:20.000000000","message":"recheck \nRecreating results","commit_id":"6aeed0d90567408179b4ea319871b789e8d75970"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"017f03e5e6e4f637bb8b1b96df96068246754352","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2219fb5b_9693ad11","updated":"2025-08-25 13:55:13.000000000","message":"I am not a fan of merging tests that will get skipped periodically. In the latest build they got skipped.\nIn this patch we would have fixed the mentioned bug (1974143) and directly get 2 failing tests. Let\u0027s merge it when we fix the bug.","commit_id":"f1ed0a5fee654b2d29bcaa2c5a1f4ec9ccf189bb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"b9a78c186fd6c195c36beddbaf3fa465c6b4873b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"86b439dc_6294a9e3","updated":"2023-08-01 10:49:46.000000000","message":"Thanks for review!!!\nThis patch is missing workflow to get it merged.","commit_id":"f1ed0a5fee654b2d29bcaa2c5a1f4ec9ccf189bb"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"71b0f409500d75ce590fd54f95718f7ca1b31987","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e7a618e6_b65b714c","updated":"2025-04-01 13:06:59.000000000","message":"it looks like both designate-grenade-bind9 and designate-grenade-pdns4 are broken\nhttps://e87df84ed2b14c9ab3f1-516e31288e88eecbd573b1260d9dd1d0.ssl.cf5.rackcdn.com/openstack/7ea46b83fa5f4b2db9de22d362e834ee/controller/logs/grenade.sh_log.txt\nhttps://c6504d891c6e5770e1f7-7e442437877d0250002746a0f7839df4.ssl.cf5.rackcdn.com/openstack/ebfc109b3ec14094a902fa94cd921ca4/controller/logs/grenade.sh_log.txt\nit doesn\u0027t print the error though, and I don\u0027t know if there is a way I could get the logs","commit_id":"f1ed0a5fee654b2d29bcaa2c5a1f4ec9ccf189bb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"cf2186fd599639cf15193292dfbe09c638154916","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2cbda638_a5949200","updated":"2025-03-27 18:13:38.000000000","message":"recheck","commit_id":"f1ed0a5fee654b2d29bcaa2c5a1f4ec9ccf189bb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"32abb516504fdfab4a9b0a5a2ae6db102bb69b50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"33079315_904afdc3","updated":"2025-03-27 16:32:45.000000000","message":"recheck","commit_id":"f1ed0a5fee654b2d29bcaa2c5a1f4ec9ccf189bb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"2c5703e4c5d9629faefff77bf4b8719917c68d8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4bb0f62f_750c7084","updated":"2025-08-25 08:08:51.000000000","message":"recheck","commit_id":"f1ed0a5fee654b2d29bcaa2c5a1f4ec9ccf189bb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ec95e236301cdaf75d0b93ca1e789c7ece76bb99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a7c61836_daa0c570","updated":"2025-03-30 10:51:16.000000000","message":"recheck","commit_id":"f1ed0a5fee654b2d29bcaa2c5a1f4ec9ccf189bb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d17b7fee7c8e5be1aab1322bd9a9d0a832556937","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c60694cc_0a388c46","updated":"2025-03-27 15:03:21.000000000","message":"recheck","commit_id":"f1ed0a5fee654b2d29bcaa2c5a1f4ec9ccf189bb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"95d28f162cc37a887840c42dfef618b321876ffc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ae79c3dd_2877a031","updated":"2025-07-23 13:06:42.000000000","message":"recheck\n\nThis patch is already has 2 +2 and only Workflow wasn\u0027t set, so if \"recheck\" is OK, we can make a progress to get it merged.","commit_id":"f1ed0a5fee654b2d29bcaa2c5a1f4ec9ccf189bb"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"8813ac91a8be55809bd1585e58c90eca6b961d2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d3d06c7e_c4aa8492","updated":"2025-04-02 08:25:28.000000000","message":"recheck https://review.opendev.org/c/openstack/designate/+/946058 fixed the gates","commit_id":"f1ed0a5fee654b2d29bcaa2c5a1f4ec9ccf189bb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3e77d16b06e35e7d7d73eb946caf32d42ae71e6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f638228f_c9d53944","in_reply_to":"2219fb5b_9693ad11","updated":"2025-09-09 08:00:33.000000000","message":"This is our standard procedure for handling upstream bugs. We merge the test with a @skip_because decorator to prevent it from failing our CI pipeline.\nOnce the upstream bug is fixed and validated (also by executing skipped test), we\u0027ll remove the decorator in a follow-up patch to re-enable the test.","commit_id":"f1ed0a5fee654b2d29bcaa2c5a1f4ec9ccf189bb"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"1096626771f72b49c6727b3a4da5a82c9d5c145b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"286ad7e5_5d57beb8","updated":"2025-09-12 10:55:34.000000000","message":"You might want to run these tests with a Depends-On of this fix https://review.opendev.org/c/openstack/designate/+/960758 and delete the skip decorator from the tests, they are not being run in the check pipeline","commit_id":"d3b80589079410d074d2ea07778aa3215b89b2cc"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"451a68137f97a3d72114d1ec162a92f57c22b82e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2dc979d0_af20d2fd","updated":"2025-09-15 15:33:31.000000000","message":"Hi @oschwart@redhat.com!\n\nI\u0027ve added \"depends-on\" FIX patch.\n\nFrom what I\u0027ve seen in some of the failed Gate, is that the zone name of 255 characters (max_zone_name_length is set to 255) is accepted by Designate API (should fail) and gets into ERROR status latter on. The reason seems to be \"rndc addzone\" command that fails with:\n\n-------------------------------------------------------------------------------\nSep 15 14:51:00.541357 np7b0b3874edda4 designate-worker[188191]: Exit code: 1\nSep 15 14:51:00.541357 np7b0b3874edda4 designate-worker[188191]: Stdout: \u0027\u0027\nSep 15 14:51:00.541357 np7b0b3874edda4 designate-worker[188191]: Stderr: \"rndc: \u0027addzone\u0027 failed: ran out of space\\n\"\nSep 15 14:51:00.621901 np7b0b3874edda4 sudo[216741]: pam_unix(sudo:session): session closed for user root\n-------------------------------------------------------------------------------\n\nAnyway I think that it shouldn\u0027t get there and should have failed on API level.","commit_id":"280b570cdfa033b0acfb05088f824660e3a42584"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"9e3d566753788693b699be45217b5f97558278a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f69ee2d6_6acd4c3a","updated":"2025-09-16 10:37:43.000000000","message":"Hi Arkady, I have abandoned that patch and closed that bug https://bugs.launchpad.net/designate/+bug/1974143 as both were invalid. Designate complies with the RFC 1035 specifications. Please see in the bug.","commit_id":"280b570cdfa033b0acfb05088f824660e3a42584"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"a217bedafb00f70939d7df420e09cee07325b9f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d384c3e0_186aa624","updated":"2025-09-17 15:02:24.000000000","message":"recheck\nError doesn\u0027t seem to be related","commit_id":"b4d58d122e8b577fde856a36862b7794e115df08"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"53494597cd591711a22ee309d46102d26c54d8cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"620bb9f2_6471f60e","updated":"2025-09-17 12:58:58.000000000","message":"recheck failure is not related to the patch","commit_id":"b4d58d122e8b577fde856a36862b7794e115df08"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"e8dd66dea71f050d1bfc411ebfd9c60313a5ae79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"dc8dd8b1_12d0b979","updated":"2025-10-07 20:32:40.000000000","message":"LGTM","commit_id":"5ed36ffac277e781e14f02ebc9b84102ad431b21"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"da19b41a5ad5b991ef321ea12514bec64cd99096","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"f724eef8_b95642ae","updated":"2025-09-22 13:10:32.000000000","message":"LGTM","commit_id":"5ed36ffac277e781e14f02ebc9b84102ad431b21"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"96ded7fa1f7184ca953fb894437fcbeea094b239","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"22b98156_fbdf1a96","updated":"2025-09-18 14:07:04.000000000","message":"recheck","commit_id":"5ed36ffac277e781e14f02ebc9b84102ad431b21"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"32a0c4cb673e9e2dc7793f636e55c34ec855b5a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"12af6b9b_9b04ec6e","updated":"2025-09-18 15:34:17.000000000","message":"recheck zuul CI node failure, not related to the patch","commit_id":"5ed36ffac277e781e14f02ebc9b84102ad431b21"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6199061f6e868ca52b585d85bb665a9324b39a2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"d883dada_e31f7f31","updated":"2025-09-18 13:52:24.000000000","message":"recheck zuul CI node failure, not related to the patch","commit_id":"5ed36ffac277e781e14f02ebc9b84102ad431b21"}],"designate_tempest_plugin/data_utils.py":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"3b7e7f740ef7e6bbfaea6ba6fc620d38a896636c","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    return name + suffix"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def rand_dns_name_by_size(name_size, label_size\u003d63):"},{"line_number":51,"context_line":"    \"\"\"Generates label based DNS name, by given characters size"},{"line_number":52,"context_line":"    :param name_size: size in characters"},{"line_number":53,"context_line":"    :param label_size: the max number of characters to be used"}],"source_content_type":"text/x-python","patch_set":5,"id":"a29cc03a_9e8c793a","line":50,"updated":"2023-01-11 19:21:57.000000000","message":"Not sure I follow this, but no matter what the name_size is it is returned to the caller, the label_size doesne\u0027t seem to limit the return value. I\u0027m assuming that the label_size as stated should return the name_size if \u003c or \u003d to label_size?\n\nFor example:\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n    zn \u003d rand_dns_name_by_size(263)\n    print(\"zn: %s:%d\" % (zn, len(zn)))\n    \n    returns:\n    263\n    \n /u02/devl/RedHat/t1.py(36)main()\n-\u003e zn \u003d rand_dns_name_by_size(263)\n(Pdb) n\n\u003e /u02/devl/RedHat/t1.py(37)main()\n-\u003e print(\"zn: %s:%d\" % (zn, len(zn)))\n(Pdb) \nzn: xrkchnjvsdsongvmjxjcxhleubgedjtazqkuvjdhgvfifvvchwfaiwaertwddbp.mljhyiylavndfagytopoogsjlmrkljoattknyanugfuzqpeoikqemgnmllsmhtf.mhooxnedllxvlgfyipkvxucsibrxoccyerkrauxsrnkpmjjutkopqtwdhmwvfbm.tkskzcimlvytlrnpljexmnsrzzwssmtnorhexlhvallttngyrfsedpxzxvbddks.smfcnk.:263\n\u003e /u02/devl/RedHat/t1.py(38)main()\n-\u003e zn \u003d rand_dns_name_by_size(6)\n(Pdb) \n\u003e /u02/devl/RedHat/t1.py(39)main()\n-\u003e print(\"zn: %s:%d\" % (zn, len(zn)))\n(Pdb) \nzn: zhcbq.:6\n\u003e /u02/devl/RedHat/t1.py(40)main()\n-\u003e zn \u003d rand_dns_name_by_size(63)\n(Pdb) \n\u003e /u02/devl/RedHat/t1.py(41)main()\n-\u003e print(\"zn: %s:%d\" % (zn, len(zn)))\n(Pdb) \nzn: zeorlqsyzxruqcpxtrvwufbhaapihaeqherhewrrseqnvrznhiowjbufpfhshx.:63\n\u003e /u02/devl/RedHat/t1.py(43)main()","commit_id":"6aeed0d90567408179b4ea319871b789e8d75970"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"48d9768c4a794c291ee6cfaba9391ea1aa82aadb","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    return name + suffix"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def rand_dns_name_by_size(name_size, label_size\u003d63):"},{"line_number":51,"context_line":"    \"\"\"Generates label based DNS name, by given characters size"},{"line_number":52,"context_line":"    :param name_size: size in characters"},{"line_number":53,"context_line":"    :param label_size: the max number of characters to be used"}],"source_content_type":"text/x-python","patch_set":5,"id":"b7af5007_7291b1a6","line":50,"in_reply_to":"a29cc03a_9e8c793a","updated":"2023-02-07 10:06:19.000000000","message":"Hi Don!\n\nI don\u0027t understand what\u0027s wrong here 😞\nThis function gets 2 parameters: name _size and label_size, the last (label) is set to 63 by default.\n\nHere are my attempts and all looks good to me:\n\n### Test Code ###\nprint(\u002710,3\u0027)\nprint(dns_data_utils.rand_dns_name_by_size(10,3))\nprint(\u002720,5\u0027)\nprint(dns_data_utils.rand_dns_name_by_size(20,5))\nprint(\u002740,10\u0027)\nprint(dns_data_utils.rand_dns_name_by_size(40,10))\nprint(\u002750,15\u0027)\nprint(dns_data_utils.rand_dns_name_by_size(50,15))\n\n\n### Prompted Output ###\n10,3\nccj.adf.j.\n20,5\nefyuu.rpjst.medkr.j.\n40,10\nyvahqqowyp.gdhzbothjz.gwwltlbeof.ijehrh.\n50,15\nfzomapovewzydan.pbjhzdfqzdqpapa.dwifprwrywqpdih.e.\n\nThanks!","commit_id":"6aeed0d90567408179b4ea319871b789e8d75970"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6483a734ec85eab94ae81bc23bf2019077608fa3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    return name + suffix"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def rand_dns_name_by_size(name_size, label_size\u003d63):"},{"line_number":51,"context_line":"    \"\"\"Generates label based DNS name, by given characters size"},{"line_number":52,"context_line":"    :param name_size: size in characters"},{"line_number":53,"context_line":"    :param label_size: the max number of characters to be used"}],"source_content_type":"text/x-python","patch_set":5,"id":"55dffa98_0d967b71","line":50,"in_reply_to":"b7af5007_7291b1a6","updated":"2023-02-07 10:06:36.000000000","message":"Done","commit_id":"6aeed0d90567408179b4ea319871b789e8d75970"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"79ac6dfc36219e454b86b9751c0befeed8e73543","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            template +\u003d rand_string(1)"},{"line_number":68,"context_line":"        return \u0027{}.\u0027.format(template[:-2])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def rand_email(domain\u003dNone):"},{"line_number":72,"context_line":"    \"\"\"Generate a random zone name"},{"line_number":73,"context_line":"    :return: a random zone name e.g. example.org."}],"source_content_type":"text/x-python","patch_set":5,"id":"5d03416a_cece9bc1","line":70,"updated":"2023-07-20 11:47:45.000000000","message":"Your implementation has edge cases that produce illegal results. For example,\n\nrand_dns_name_by_size(5, 3) -\u003e nsq..\n\nYou can simplify this implementation:\n\n```python\ndef rand_dns_name_by_size(name_size, label_size\u003d63):\n    \"\"\"Generates label based DNS name with limited total size\n    :param name_size: maximum total size in characters\n    :param label_size: the maximum number of characters to be used\n                       per label. Max value according the RFC is 63\n                       https://datatracker.ietf.org/doc/html/rfc1035#\n                       section-2.3.4in\n    :return: DNS name\n    \"\"\"\n    template \u003d \u0027\u0027\n    while len(template) \u003c name_size:\n        remaining_length \u003d name_size - len(template)\n        template +\u003d \u0027{}.\u0027.format(rand_string(min(remaining_length, label_size)))\n    return template\n```","commit_id":"6aeed0d90567408179b4ea319871b789e8d75970"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5c89c05efaed2ba3daba1b33edfd1b7820100715","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            template +\u003d rand_string(1)"},{"line_number":68,"context_line":"        return \u0027{}.\u0027.format(template[:-2])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def rand_email(domain\u003dNone):"},{"line_number":72,"context_line":"    \"\"\"Generate a random zone name"},{"line_number":73,"context_line":"    :return: a random zone name e.g. example.org."}],"source_content_type":"text/x-python","patch_set":5,"id":"c0ddd333_da1a9d5c","line":70,"in_reply_to":"5d03416a_cece9bc1","updated":"2023-07-23 14:44:31.000000000","message":"Yep, this code is much more simple, I just added:\n1) \"-1\" here: min(remaining_length - 1, label_size)))to discount the dot.\n2) Raise exception. In some cases we simply cannot generate a valid DNS name, for \n   example: rand_dns_name_by_size(10,2) --\u003e dp.qm.cp..\n   So it will now throw the exception, asking developer changing the values.","commit_id":"6aeed0d90567408179b4ea319871b789e8d75970"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"9cd9f8b5246fb8eae3e13d4c356091e1be8abbb6","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            template +\u003d rand_string(1)"},{"line_number":68,"context_line":"        return \u0027{}.\u0027.format(template[:-2])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def rand_email(domain\u003dNone):"},{"line_number":72,"context_line":"    \"\"\"Generate a random zone name"},{"line_number":73,"context_line":"    :return: a random zone name e.g. example.org."}],"source_content_type":"text/x-python","patch_set":5,"id":"31f01e26_2136dc1f","line":70,"in_reply_to":"c0ddd333_da1a9d5c","updated":"2023-07-23 14:44:42.000000000","message":"Done","commit_id":"6aeed0d90567408179b4ea319871b789e8d75970"}],"designate_tempest_plugin/tests/scenario/v2/test_limits.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"428b9c1373a0a402270a94b16848148e3a4cf9ec","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        LOG.info(\u0027Zone with name length:{} is successfully created\u0027.format("},{"line_number":47,"context_line":"            allowed_limit))"},{"line_number":48,"context_line":"        zone_name \u003d dns_data_utils.rand_string("},{"line_number":49,"context_line":"            allowed_limit - len(zone_suffix)) + zone_suffix"},{"line_number":50,"context_line":"        zone \u003d self.zone_client.create_zone(name\u003dzone_name)[1]"},{"line_number":51,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a79b0c7_8e69d120","line":48,"updated":"2022-05-06 18:20:31.000000000","message":"Ok, this test is setup wrong. Per the RFC[1] the maximum size of a DNS label is 63 characters.\n\nThe test, as it is current written creates a label of 251 characters.\nSo, the API is actually rejecting this create call before it even gets to the zone name length check.\n\nThis test will need to be updated to build up the zone name to the maximum character length in 63 or less characters per label.\n\n[1] https://datatracker.ietf.org/doc/html/rfc1035#section-2.3.4","commit_id":"e812ec5f35b03f9fd2a23b3392748265b2ed2aca"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6199061f6e868ca52b585d85bb665a9324b39a2e","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        LOG.info(\u0027Zone with name length:{} is successfully created\u0027.format("},{"line_number":47,"context_line":"            allowed_limit))"},{"line_number":48,"context_line":"        zone_name \u003d dns_data_utils.rand_string("},{"line_number":49,"context_line":"            allowed_limit - len(zone_suffix)) + zone_suffix"},{"line_number":50,"context_line":"        zone \u003d self.zone_client.create_zone(name\u003dzone_name)[1]"},{"line_number":51,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"db09b4e3_38b2c88b","line":48,"in_reply_to":"74620796_79fb5d45","updated":"2025-09-18 13:52:24.000000000","message":"Done","commit_id":"e812ec5f35b03f9fd2a23b3392748265b2ed2aca"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1dcd50b6c75be2cd505132702b159b14e9791d6b","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        LOG.info(\u0027Zone with name length:{} is successfully created\u0027.format("},{"line_number":47,"context_line":"            allowed_limit))"},{"line_number":48,"context_line":"        zone_name \u003d dns_data_utils.rand_string("},{"line_number":49,"context_line":"            allowed_limit - len(zone_suffix)) + zone_suffix"},{"line_number":50,"context_line":"        zone \u003d self.zone_client.create_zone(name\u003dzone_name)[1]"},{"line_number":51,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"74620796_79fb5d45","line":48,"in_reply_to":"792c6ead_027398fb","updated":"2022-05-18 13:43:11.000000000","message":"OK, got it.\nWill be fixed in the next patchset.\nThanks Michael!","commit_id":"e812ec5f35b03f9fd2a23b3392748265b2ed2aca"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"82c2dc2d00b694ebcdb7fc760e1a9836699517f6","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        LOG.info(\u0027Zone with name length:{} is successfully created\u0027.format("},{"line_number":47,"context_line":"            allowed_limit))"},{"line_number":48,"context_line":"        zone_name \u003d dns_data_utils.rand_string("},{"line_number":49,"context_line":"            allowed_limit - len(zone_suffix)) + zone_suffix"},{"line_number":50,"context_line":"        zone \u003d self.zone_client.create_zone(name\u003dzone_name)[1]"},{"line_number":51,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"f643190c_82c32498","line":48,"in_reply_to":"9a79b0c7_8e69d120","updated":"2022-05-16 09:32:09.000000000","message":"Hi Michael!\n\nYep, that\u0027s correct and I\u0027ve also seen that the limit is somewhere about 6X while trying to find the reason of tests\u0027 failure.\n\nIn fact, this test is just trying to use 254 characters because this is the actual limit number for: max_zone_name_length returned from the Designate (see L38) is 255: \ncls.project_limits is:\n{\u0027max_zones\u0027: 10, \u0027max_zone_recordsets\u0027: 500, \u0027max_zone_records\u0027: 500, \u0027max_recordset_records\u0027: 20, \u0027min_ttl\u0027: None, \u0027max_zone_name_length\u0027: 255, \u0027max_recordset_name_length\u0027: 255, \u0027max_page_limit\u0027: 1000}\n\n\nThe test logic is based on the actual limit numbers received for a project (primary), so if the limit number of characters received from the Designate was 63, then the test would try using: 62 (expected PASS) and 63 (expected: FAIL) accordingly.","commit_id":"e812ec5f35b03f9fd2a23b3392748265b2ed2aca"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"576f6d671d5a94b8aa1693ae14d235fe73da57ae","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        LOG.info(\u0027Zone with name length:{} is successfully created\u0027.format("},{"line_number":47,"context_line":"            allowed_limit))"},{"line_number":48,"context_line":"        zone_name \u003d dns_data_utils.rand_string("},{"line_number":49,"context_line":"            allowed_limit - len(zone_suffix)) + zone_suffix"},{"line_number":50,"context_line":"        zone \u003d self.zone_client.create_zone(name\u003dzone_name)[1]"},{"line_number":51,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"792c6ead_027398fb","line":48,"in_reply_to":"f643190c_82c32498","updated":"2022-05-17 00:02:56.000000000","message":"My point on these to tests is that it\u0027s not getting to the 255 character check, because it is failing the 63 character, per label, check first.\n\nI.e. \u003clabel up to 63 chars\u003e.\u003clabel up to 63 chars\u003e.\u003clabel up to 63 chars\u003e.... cannot exceed 255.","commit_id":"e812ec5f35b03f9fd2a23b3392748265b2ed2aca"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"428b9c1373a0a402270a94b16848148e3a4cf9ec","unresolved":true,"context_lines":[{"line_number":76,"context_line":"                 \u0027created\u0027.format(allowed_limit))"},{"line_number":77,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":78,"context_line":"            record_type\u003d\u0027A\u0027,"},{"line_number":79,"context_line":"            name\u003d\u0027{}.{}\u0027.format(dns_data_utils.rand_string("},{"line_number":80,"context_line":"                allowed_limit - len(zone_name) - 1), zone_name),"},{"line_number":81,"context_line":"            zone_name\u003dzone[\u0027name\u0027])"},{"line_number":82,"context_line":"        recorset \u003d self.recordset_client.create_recordset("}],"source_content_type":"text/x-python","patch_set":3,"id":"d91e2d15_0881b3a5","line":79,"updated":"2022-05-06 18:20:31.000000000","message":"Same issue here, the label is too long and you are getting a correct error before it gets to the recordset name check.","commit_id":"e812ec5f35b03f9fd2a23b3392748265b2ed2aca"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1dcd50b6c75be2cd505132702b159b14e9791d6b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                 \u0027created\u0027.format(allowed_limit))"},{"line_number":77,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":78,"context_line":"            record_type\u003d\u0027A\u0027,"},{"line_number":79,"context_line":"            name\u003d\u0027{}.{}\u0027.format(dns_data_utils.rand_string("},{"line_number":80,"context_line":"                allowed_limit - len(zone_name) - 1), zone_name),"},{"line_number":81,"context_line":"            zone_name\u003dzone[\u0027name\u0027])"},{"line_number":82,"context_line":"        recorset \u003d self.recordset_client.create_recordset("}],"source_content_type":"text/x-python","patch_set":3,"id":"84bdfbb8_6f5f9ec6","line":79,"in_reply_to":"7b112e53_5d3769c1","updated":"2022-05-18 13:43:11.000000000","message":"Done","commit_id":"e812ec5f35b03f9fd2a23b3392748265b2ed2aca"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"82c2dc2d00b694ebcdb7fc760e1a9836699517f6","unresolved":true,"context_lines":[{"line_number":76,"context_line":"                 \u0027created\u0027.format(allowed_limit))"},{"line_number":77,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":78,"context_line":"            record_type\u003d\u0027A\u0027,"},{"line_number":79,"context_line":"            name\u003d\u0027{}.{}\u0027.format(dns_data_utils.rand_string("},{"line_number":80,"context_line":"                allowed_limit - len(zone_name) - 1), zone_name),"},{"line_number":81,"context_line":"            zone_name\u003dzone[\u0027name\u0027])"},{"line_number":82,"context_line":"        recorset \u003d self.recordset_client.create_recordset("}],"source_content_type":"text/x-python","patch_set":3,"id":"7b112e53_5d3769c1","line":79,"in_reply_to":"d91e2d15_0881b3a5","updated":"2022-05-16 09:32:09.000000000","message":"Same as for test_max_zone_name_length","commit_id":"e812ec5f35b03f9fd2a23b3392748265b2ed2aca"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"017f03e5e6e4f637bb8b1b96df96068246754352","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        LOG.info(\u0027Zone of length:{} is failed to be created\u0027.format("},{"line_number":51,"context_line":"            allowed_limit + 1))"},{"line_number":52,"context_line":"        zone_name \u003d dns_data_utils.rand_dns_name_by_size(allowed_limit)"},{"line_number":53,"context_line":"        self.assertRaisesDns("},{"line_number":54,"context_line":"            lib_exc.BadRequest, \u0027invalid_object\u0027, 400,"},{"line_number":55,"context_line":"            self.zone_client.create_zone,"}],"source_content_type":"text/x-python","patch_set":7,"id":"e211d6e2_0d5912dc","line":52,"updated":"2025-08-25 13:55:13.000000000","message":"This zone_name should probably be of length allowed_limit + 1 to fail. It is the same one as line #46","commit_id":"f1ed0a5fee654b2d29bcaa2c5a1f4ec9ccf189bb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3e77d16b06e35e7d7d73eb946caf32d42ae71e6d","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        LOG.info(\u0027Zone of length:{} is failed to be created\u0027.format("},{"line_number":51,"context_line":"            allowed_limit + 1))"},{"line_number":52,"context_line":"        zone_name \u003d dns_data_utils.rand_dns_name_by_size(allowed_limit)"},{"line_number":53,"context_line":"        self.assertRaisesDns("},{"line_number":54,"context_line":"            lib_exc.BadRequest, \u0027invalid_object\u0027, 400,"},{"line_number":55,"context_line":"            self.zone_client.create_zone,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bc0f8972_08dd4c25","line":52,"in_reply_to":"e211d6e2_0d5912dc","updated":"2025-09-09 08:00:33.000000000","message":"Done","commit_id":"f1ed0a5fee654b2d29bcaa2c5a1f4ec9ccf189bb"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"017f03e5e6e4f637bb8b1b96df96068246754352","unresolved":true,"context_lines":[{"line_number":84,"context_line":"                 \u0027to be created\u0027.format(allowed_limit + 1))"},{"line_number":85,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":86,"context_line":"            record_type\u003d\u0027A\u0027,"},{"line_number":87,"context_line":"            name\u003ddns_data_utils.rand_string(4) + \u0027.\u0027 + zone_name,"},{"line_number":88,"context_line":"            zone_name\u003dzone[\u0027name\u0027])"},{"line_number":89,"context_line":"        self.assertRaisesDns("},{"line_number":90,"context_line":"            lib_exc.BadRequest, \u0027invalid_object\u0027, 400,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1331444e_ea7fcba7","line":87,"updated":"2025-08-25 13:55:13.000000000","message":"ditto longer name","commit_id":"f1ed0a5fee654b2d29bcaa2c5a1f4ec9ccf189bb"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3e77d16b06e35e7d7d73eb946caf32d42ae71e6d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                 \u0027to be created\u0027.format(allowed_limit + 1))"},{"line_number":85,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":86,"context_line":"            record_type\u003d\u0027A\u0027,"},{"line_number":87,"context_line":"            name\u003ddns_data_utils.rand_string(4) + \u0027.\u0027 + zone_name,"},{"line_number":88,"context_line":"            zone_name\u003dzone[\u0027name\u0027])"},{"line_number":89,"context_line":"        self.assertRaisesDns("},{"line_number":90,"context_line":"            lib_exc.BadRequest, \u0027invalid_object\u0027, 400,"}],"source_content_type":"text/x-python","patch_set":7,"id":"d35477ad_98c8cd8d","line":87,"in_reply_to":"1331444e_ea7fcba7","updated":"2025-09-09 08:00:33.000000000","message":"Done","commit_id":"f1ed0a5fee654b2d29bcaa2c5a1f4ec9ccf189bb"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"011c1ca30a59b179a9b3a90955f64706e2eebbde","unresolved":true,"context_lines":[{"line_number":66,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        LOG.info("},{"line_number":69,"context_line":"            \u0027Attempting to create of length:{}, expected: zone is failed\u0027"},{"line_number":70,"context_line":"            \u0027 to be created\u0027.format(allowed_limit + 1))"},{"line_number":71,"context_line":"        zone_name \u003d dns_data_utils.rand_dns_name_by_size(allowed_limit + 1)"},{"line_number":72,"context_line":"        self.assertRaisesDns("}],"source_content_type":"text/x-python","patch_set":15,"id":"4d073312_70c61d4d","line":69,"range":{"start_line":69,"start_character":27,"end_line":69,"end_character":33},"updated":"2025-09-17 10:10:49.000000000","message":"typo: create a Zone","commit_id":"a07c260349571f3e76da0d4f3c9ef02e46323448"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6199061f6e868ca52b585d85bb665a9324b39a2e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        LOG.info("},{"line_number":69,"context_line":"            \u0027Attempting to create of length:{}, expected: zone is failed\u0027"},{"line_number":70,"context_line":"            \u0027 to be created\u0027.format(allowed_limit + 1))"},{"line_number":71,"context_line":"        zone_name \u003d dns_data_utils.rand_dns_name_by_size(allowed_limit + 1)"},{"line_number":72,"context_line":"        self.assertRaisesDns("}],"source_content_type":"text/x-python","patch_set":15,"id":"331c1e4c_d0bf5a44","line":69,"range":{"start_line":69,"start_character":27,"end_line":69,"end_character":33},"in_reply_to":"40360b1e_565ea822","updated":"2025-09-18 13:52:24.000000000","message":"Done","commit_id":"a07c260349571f3e76da0d4f3c9ef02e46323448"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"cb62cc5ce085fa8128aab220b422915dd6cb8e80","unresolved":true,"context_lines":[{"line_number":66,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        LOG.info("},{"line_number":69,"context_line":"            \u0027Attempting to create of length:{}, expected: zone is failed\u0027"},{"line_number":70,"context_line":"            \u0027 to be created\u0027.format(allowed_limit + 1))"},{"line_number":71,"context_line":"        zone_name \u003d dns_data_utils.rand_dns_name_by_size(allowed_limit + 1)"},{"line_number":72,"context_line":"        self.assertRaisesDns("}],"source_content_type":"text/x-python","patch_set":15,"id":"40360b1e_565ea822","line":69,"range":{"start_line":69,"start_character":27,"end_line":69,"end_character":33},"in_reply_to":"4d073312_70c61d4d","updated":"2025-09-17 11:07:54.000000000","message":"Fixed.","commit_id":"a07c260349571f3e76da0d4f3c9ef02e46323448"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"011c1ca30a59b179a9b3a90955f64706e2eebbde","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        allowed_recordset_limit \u003d self.project_limits["},{"line_number":84,"context_line":"            \u0027max_recordset_name_length\u0027] - 1  # The final root null byte"},{"line_number":85,"context_line":"        zone_name \u003d dns_data_utils.rand_dns_name_by_size("},{"line_number":86,"context_line":"            name_size\u003dallowed_recordset_limit - 10, label_size\u003d50)"},{"line_number":87,"context_line":"        # Use class TLD at the end of generated Zone Name"},{"line_number":88,"context_line":"        zone_name \u003d zone_name[:-("},{"line_number":89,"context_line":"                len(self.tld[\u0027name\u0027]) + 2)] + \u0027.\u0027 + self.tld[\u0027name\u0027] + \u0027.\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"c2028b6b_948a509e","line":86,"range":{"start_line":86,"start_character":48,"end_line":86,"end_character":65},"updated":"2025-09-17 10:10:49.000000000","message":"why 10 and 50?","commit_id":"a07c260349571f3e76da0d4f3c9ef02e46323448"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6199061f6e868ca52b585d85bb665a9324b39a2e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        allowed_recordset_limit \u003d self.project_limits["},{"line_number":84,"context_line":"            \u0027max_recordset_name_length\u0027] - 1  # The final root null byte"},{"line_number":85,"context_line":"        zone_name \u003d dns_data_utils.rand_dns_name_by_size("},{"line_number":86,"context_line":"            name_size\u003dallowed_recordset_limit - 10, label_size\u003d50)"},{"line_number":87,"context_line":"        # Use class TLD at the end of generated Zone Name"},{"line_number":88,"context_line":"        zone_name \u003d zone_name[:-("},{"line_number":89,"context_line":"                len(self.tld[\u0027name\u0027]) + 2)] + \u0027.\u0027 + self.tld[\u0027name\u0027] + \u0027.\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"b1c7ecda_4c15a25b","line":86,"range":{"start_line":86,"start_character":48,"end_line":86,"end_character":65},"in_reply_to":"b173c196_70efefe2","updated":"2025-09-18 13:52:24.000000000","message":"Done","commit_id":"a07c260349571f3e76da0d4f3c9ef02e46323448"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"cb62cc5ce085fa8128aab220b422915dd6cb8e80","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        allowed_recordset_limit \u003d self.project_limits["},{"line_number":84,"context_line":"            \u0027max_recordset_name_length\u0027] - 1  # The final root null byte"},{"line_number":85,"context_line":"        zone_name \u003d dns_data_utils.rand_dns_name_by_size("},{"line_number":86,"context_line":"            name_size\u003dallowed_recordset_limit - 10, label_size\u003d50)"},{"line_number":87,"context_line":"        # Use class TLD at the end of generated Zone Name"},{"line_number":88,"context_line":"        zone_name \u003d zone_name[:-("},{"line_number":89,"context_line":"                len(self.tld[\u0027name\u0027]) + 2)] + \u0027.\u0027 + self.tld[\u0027name\u0027] + \u0027.\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"b173c196_70efefe2","line":86,"range":{"start_line":86,"start_character":48,"end_line":86,"end_character":65},"in_reply_to":"c2028b6b_948a509e","updated":"2025-09-17 11:07:54.000000000","message":"I\u0027ve edited the code as follow:\n(10) - reserved_recordset_length \u003d 10  # Reserved for recordset\u0027s host part.\n(50) - removed","commit_id":"a07c260349571f3e76da0d4f3c9ef02e46323448"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b39fa04ee9aad60e48daac975947c9e863beb3d5","unresolved":true,"context_lines":[{"line_number":111,"context_line":"            self.wait_recordset_delete, self.recordset_client,"},{"line_number":112,"context_line":"            zone[\u0027id\u0027], recordset[\u0027id\u0027])"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        LOG.info(\u0027Recordset name of length:{} is failed to be created\u0027.format("},{"line_number":115,"context_line":"            allowed_recordset_limit + 1))"},{"line_number":116,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":117,"context_line":"            record_type\u003d\u0027A\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"859a80dd_c1d4ea71","line":114,"updated":"2025-09-18 09:19:06.000000000","message":"nit: I prefer the same format of the last test (lines 58-59 or 69-70, both have the word \"expected\"). Otherwise, one might think the test failed but didn\u0027t raise an exception.","commit_id":"b4d58d122e8b577fde856a36862b7794e115df08"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6199061f6e868ca52b585d85bb665a9324b39a2e","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            self.wait_recordset_delete, self.recordset_client,"},{"line_number":112,"context_line":"            zone[\u0027id\u0027], recordset[\u0027id\u0027])"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        LOG.info(\u0027Recordset name of length:{} is failed to be created\u0027.format("},{"line_number":115,"context_line":"            allowed_recordset_limit + 1))"},{"line_number":116,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":117,"context_line":"            record_type\u003d\u0027A\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1e7294b5_13b1e911","line":114,"in_reply_to":"0fc55bd1_4ddc29db","updated":"2025-09-18 13:52:24.000000000","message":"Done","commit_id":"b4d58d122e8b577fde856a36862b7794e115df08"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1e298a80ddac584d7906110eeb94ca5f8b1a0645","unresolved":true,"context_lines":[{"line_number":111,"context_line":"            self.wait_recordset_delete, self.recordset_client,"},{"line_number":112,"context_line":"            zone[\u0027id\u0027], recordset[\u0027id\u0027])"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        LOG.info(\u0027Recordset name of length:{} is failed to be created\u0027.format("},{"line_number":115,"context_line":"            allowed_recordset_limit + 1))"},{"line_number":116,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":117,"context_line":"            record_type\u003d\u0027A\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"0fc55bd1_4ddc29db","line":114,"in_reply_to":"859a80dd_c1d4ea71","updated":"2025-09-18 12:00:48.000000000","message":"Yep, makes sense, I\u0027ll fix this nit.","commit_id":"b4d58d122e8b577fde856a36862b7794e115df08"}]}