)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c76b0fd794d7af1170db9be61ac7940ffe39c115","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"281fa170_6d48722a","updated":"2022-04-26 10:34:39.000000000","message":"Good catch Omer, thanks!","commit_id":"00ec65a09bf6a2a430fa832eee11449e5ab2ecf3"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"def1aeae84a17cc2bbcf55d0bebd34bc1fae8e63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c6f7b02b_53ccb53f","updated":"2022-04-25 16:53:56.000000000","message":"LGTM","commit_id":"00ec65a09bf6a2a430fa832eee11449e5ab2ecf3"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a4acb4b3f56866b04eb3fedccf1454e8afba38a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ea63e419_77bbc116","updated":"2022-04-26 10:12:13.000000000","message":"Thanks Arkady.","commit_id":"00ec65a09bf6a2a430fa832eee11449e5ab2ecf3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"36ef610dc12b04081c5a9aef2c4acbdea110e8fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a976eaee_7c6a55c3","updated":"2022-04-12 11:58:01.000000000","message":"recheck","commit_id":"00ec65a09bf6a2a430fa832eee11449e5ab2ecf3"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"eddb42fe69a2965ce33f21f48a4ec3e2983d684f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c4eee9ba_c7bf8cab","updated":"2022-04-27 21:26:44.000000000","message":"LGTM","commit_id":"74faf076b1acd7852fd261e781eb5465392c15d7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9b08cdc962eb71d0faa7bf2b046f1a0366441bd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3fbbe6dd_a37258da","updated":"2022-05-06 22:56:54.000000000","message":"LGTM, a few nits but nothing major.","commit_id":"74faf076b1acd7852fd261e781eb5465392c15d7"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"ff7a3ff5e5cf7523ca2a6fc3bd654c94f7c92f51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f77ab33b_41d13f2c","updated":"2022-05-11 19:41:23.000000000","message":"LGTM","commit_id":"73b6ae5a8d322cd85175c4b02baf347a336a186d"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1590e7b7c0da97d31b9e4307d5c4fc01c153c8c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c1a0326b_41071826","updated":"2022-05-11 19:25:29.000000000","message":"recheck","commit_id":"73b6ae5a8d322cd85175c4b02baf347a336a186d"}],"designate_tempest_plugin/tests/scenario/v2/test_zones.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a4acb4b3f56866b04eb3fedccf1454e8afba38a5","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        LOG.info(\u0027Ensure we respond with NONE+PENDING\u0027)"},{"line_number":54,"context_line":"        self.assertEqual(const.NONE, zone[\u0027action\u0027])"},{"line_number":55,"context_line":"        self.assertEqual(const.ACTIVE, zone[\u0027status\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        LOG.info(\u0027Delete the zone\u0027)"},{"line_number":58,"context_line":"        zone \u003d self.client.delete_zone(zone[\u0027id\u0027])[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"64ffcd80_4d790693","line":55,"range":{"start_line":55,"start_character":25,"end_line":55,"end_character":37},"updated":"2022-04-26 10:12:13.000000000","message":"Should this value be PENDING? (From what I see in line 53)","commit_id":"00ec65a09bf6a2a430fa832eee11449e5ab2ecf3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c76b0fd794d7af1170db9be61ac7940ffe39c115","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        LOG.info(\u0027Ensure we respond with NONE+PENDING\u0027)"},{"line_number":54,"context_line":"        self.assertEqual(const.NONE, zone[\u0027action\u0027])"},{"line_number":55,"context_line":"        self.assertEqual(const.ACTIVE, zone[\u0027status\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        LOG.info(\u0027Delete the zone\u0027)"},{"line_number":58,"context_line":"        zone \u003d self.client.delete_zone(zone[\u0027id\u0027])[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"a76d3cdf_77be0a44","line":55,"range":{"start_line":55,"start_character":25,"end_line":55,"end_character":37},"in_reply_to":"64ffcd80_4d790693","updated":"2022-04-26 10:34:39.000000000","message":"Yep, the LOG message is incorrect and I\u0027l fix that.\nThere is a waiter in L47 that waits till the zone becomes ACTIVE.","commit_id":"00ec65a09bf6a2a430fa832eee11449e5ab2ecf3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0a7426683e0c9411d759aa1aacf58af0befc624d","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        LOG.info(\u0027Ensure we respond with NONE+PENDING\u0027)"},{"line_number":54,"context_line":"        self.assertEqual(const.NONE, zone[\u0027action\u0027])"},{"line_number":55,"context_line":"        self.assertEqual(const.ACTIVE, zone[\u0027status\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        LOG.info(\u0027Delete the zone\u0027)"},{"line_number":58,"context_line":"        zone \u003d self.client.delete_zone(zone[\u0027id\u0027])[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"6beabc0f_2d2fb77c","line":55,"range":{"start_line":55,"start_character":25,"end_line":55,"end_character":37},"in_reply_to":"a76d3cdf_77be0a44","updated":"2022-05-11 17:58:48.000000000","message":"Done","commit_id":"00ec65a09bf6a2a430fa832eee11449e5ab2ecf3"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a4acb4b3f56866b04eb3fedccf1454e8afba38a5","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        self.addCleanup(self.wait_zone_delete, self.client, zone[\u0027id\u0027])"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        waiters.wait_for_zone_status(self.client, zone[\u0027id\u0027], const.ACTIVE)"},{"line_number":132,"context_line":"        waiters.wait_for_query(self.query_client, zone[\u0027name\u0027], \"SOA\")"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":135,"context_line":"    @decorators.idempotent_id(\u0027d13d3095-c78f-4aae-8fe3-a74ccc335c84\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b864b940_478022cf","line":132,"range":{"start_line":132,"start_character":65,"end_line":132,"end_character":68},"updated":"2022-04-26 10:12:13.000000000","message":"Would this string change during future changes/lines? In case it won\u0027t, maybe it could be a constant.","commit_id":"00ec65a09bf6a2a430fa832eee11449e5ab2ecf3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9b08cdc962eb71d0faa7bf2b046f1a0366441bd3","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        self.addCleanup(self.wait_zone_delete, self.client, zone[\u0027id\u0027])"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        waiters.wait_for_zone_status(self.client, zone[\u0027id\u0027], const.ACTIVE)"},{"line_number":132,"context_line":"        waiters.wait_for_query(self.query_client, zone[\u0027name\u0027], \"SOA\")"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":135,"context_line":"    @decorators.idempotent_id(\u0027d13d3095-c78f-4aae-8fe3-a74ccc335c84\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"63ce6ef7_9ffaca11","line":132,"range":{"start_line":132,"start_character":65,"end_line":132,"end_character":68},"in_reply_to":"2d828963_33666742","updated":"2022-05-06 22:56:54.000000000","message":"nit: +1 I agree this should be a constant for the test suite.","commit_id":"00ec65a09bf6a2a430fa832eee11449e5ab2ecf3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c76b0fd794d7af1170db9be61ac7940ffe39c115","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        self.addCleanup(self.wait_zone_delete, self.client, zone[\u0027id\u0027])"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        waiters.wait_for_zone_status(self.client, zone[\u0027id\u0027], const.ACTIVE)"},{"line_number":132,"context_line":"        waiters.wait_for_query(self.query_client, zone[\u0027name\u0027], \"SOA\")"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":135,"context_line":"    @decorators.idempotent_id(\u0027d13d3095-c78f-4aae-8fe3-a74ccc335c84\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"2d828963_33666742","line":132,"range":{"start_line":132,"start_character":65,"end_line":132,"end_character":68},"in_reply_to":"b864b940_478022cf","updated":"2022-04-26 10:34:39.000000000","message":"I don\u0027t think so, SOA is a standard DNS record type: https://en.wikipedia.org/wiki/SOA_record","commit_id":"00ec65a09bf6a2a430fa832eee11449e5ab2ecf3"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a4acb4b3f56866b04eb3fedccf1454e8afba38a5","unresolved":true,"context_lines":[{"line_number":143,"context_line":"                        ignore_errors\u003dlib_exc.NotFound)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        waiters.wait_for_zone_status(self.client, zone[\u0027id\u0027], const.ACTIVE)"},{"line_number":146,"context_line":"        waiters.wait_for_query(self.query_client, zone[\u0027name\u0027], \"SOA\")"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        LOG.info(\u0027Delete the zone\u0027)"},{"line_number":149,"context_line":"        self.client.delete_zone(zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"0745ec35_461bae02","line":146,"range":{"start_line":146,"start_character":65,"end_line":146,"end_character":68},"updated":"2022-04-26 10:12:13.000000000","message":"Would this string change during future changes/lines? In case it won\u0027t, maybe it could be a constant.","commit_id":"00ec65a09bf6a2a430fa832eee11449e5ab2ecf3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c76b0fd794d7af1170db9be61ac7940ffe39c115","unresolved":true,"context_lines":[{"line_number":143,"context_line":"                        ignore_errors\u003dlib_exc.NotFound)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        waiters.wait_for_zone_status(self.client, zone[\u0027id\u0027], const.ACTIVE)"},{"line_number":146,"context_line":"        waiters.wait_for_query(self.query_client, zone[\u0027name\u0027], \"SOA\")"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        LOG.info(\u0027Delete the zone\u0027)"},{"line_number":149,"context_line":"        self.client.delete_zone(zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f89b139_47d54353","line":146,"range":{"start_line":146,"start_character":65,"end_line":146,"end_character":68},"in_reply_to":"0745ec35_461bae02","updated":"2022-04-26 10:34:39.000000000","message":"same as in L132","commit_id":"00ec65a09bf6a2a430fa832eee11449e5ab2ecf3"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a4acb4b3f56866b04eb3fedccf1454e8afba38a5","unresolved":true,"context_lines":[{"line_number":149,"context_line":"        self.client.delete_zone(zone[\u0027id\u0027])"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        waiters.wait_for_zone_404(self.client, zone[\u0027id\u0027])"},{"line_number":152,"context_line":"        waiters.wait_for_query(self.query_client, zone[\u0027name\u0027], \"SOA\","},{"line_number":153,"context_line":"                               found\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"abe5e5fb_ce897bc1","line":152,"range":{"start_line":152,"start_character":65,"end_line":152,"end_character":68},"updated":"2022-04-26 10:12:13.000000000","message":"Would this string change during future changes/lines? In case it won\u0027t, maybe it could be a constant.","commit_id":"00ec65a09bf6a2a430fa832eee11449e5ab2ecf3"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c76b0fd794d7af1170db9be61ac7940ffe39c115","unresolved":true,"context_lines":[{"line_number":149,"context_line":"        self.client.delete_zone(zone[\u0027id\u0027])"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        waiters.wait_for_zone_404(self.client, zone[\u0027id\u0027])"},{"line_number":152,"context_line":"        waiters.wait_for_query(self.query_client, zone[\u0027name\u0027], \"SOA\","},{"line_number":153,"context_line":"                               found\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"64e1f19c_af5ff2e0","line":152,"range":{"start_line":152,"start_character":65,"end_line":152,"end_character":68},"in_reply_to":"abe5e5fb_ce897bc1","updated":"2022-04-26 10:34:39.000000000","message":"same as in L132","commit_id":"00ec65a09bf6a2a430fa832eee11449e5ab2ecf3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9b08cdc962eb71d0faa7bf2b046f1a0366441bd3","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        LOG.info(\u0027Create a zone and wait until it becomes ACTIVE\u0027)"},{"line_number":71,"context_line":"        orig_ttl \u003d 666"},{"line_number":72,"context_line":"        orig_description \u003d dns_data_utils.rand_string(10)"},{"line_number":73,"context_line":"        zone \u003d self.client.create_zone("},{"line_number":74,"context_line":"            ttl\u003dorig_ttl, description\u003dorig_description,"},{"line_number":75,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ef1f8e72_b0bf153c","line":72,"updated":"2022-05-06 22:56:54.000000000","message":"nit: It\u0027s always nice to have the test name in the description field for debugging.","commit_id":"74faf076b1acd7852fd261e781eb5465392c15d7"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0a7426683e0c9411d759aa1aacf58af0befc624d","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        LOG.info(\u0027Create a zone and wait until it becomes ACTIVE\u0027)"},{"line_number":71,"context_line":"        orig_ttl \u003d 666"},{"line_number":72,"context_line":"        orig_description \u003d dns_data_utils.rand_string(10)"},{"line_number":73,"context_line":"        zone \u003d self.client.create_zone("},{"line_number":74,"context_line":"            ttl\u003dorig_ttl, description\u003dorig_description,"},{"line_number":75,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"d55fbf21_22dca04c","line":72,"in_reply_to":"294c1c1c_28cd657b","updated":"2022-05-11 17:58:48.000000000","message":"Done","commit_id":"74faf076b1acd7852fd261e781eb5465392c15d7"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"b7242792d510efb45186af36f34758dbf8758d95","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        LOG.info(\u0027Create a zone and wait until it becomes ACTIVE\u0027)"},{"line_number":71,"context_line":"        orig_ttl \u003d 666"},{"line_number":72,"context_line":"        orig_description \u003d dns_data_utils.rand_string(10)"},{"line_number":73,"context_line":"        zone \u003d self.client.create_zone("},{"line_number":74,"context_line":"            ttl\u003dorig_ttl, description\u003dorig_description,"},{"line_number":75,"context_line":"            wait_until\u003dconst.ACTIVE)[1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"294c1c1c_28cd657b","line":72,"in_reply_to":"ef1f8e72_b0bf153c","updated":"2022-05-11 14:35:14.000000000","message":"Arkady, do you want to quickly add what Michael is suggesting?","commit_id":"74faf076b1acd7852fd261e781eb5465392c15d7"}]}