)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ed8a4aa2d2f29f354b29f3a2bee308e990530582","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fd7aed6a_44687767","updated":"2022-04-12 20:15:32.000000000","message":"The NS recordset create test is bogus. It\u0027s creating an NS record for a different sub-zone that has no SOA.","commit_id":"2a3343b0b58e160ffea155411d6e215368a505e6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"519bb43b602bceeb92eb31f499535b76f5260073","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d644ea11_23a17054","updated":"2022-05-06 22:36:28.000000000","message":"recheck\nnotify updates in designate may impact this test result","commit_id":"8e72a370c8d0e4edf3e348c4af7563ee4b1ede75"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"cb8c70f5655e3c71955e4c44af84641c5c21acd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"aea84ba7_93601172","updated":"2022-06-03 14:56:18.000000000","message":"Thanks Arkady","commit_id":"02504df1a4bc3af172f246a8d21887099e3ceece"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"422018d05cd90a9fc11f12b4d412e13d2513fb44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9e06d571_3eacb1e6","updated":"2022-06-28 18:29:51.000000000","message":"LGTM","commit_id":"48658e851593116d138b29fcc09fa339e3d619c1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b4d934569d702ae21b6c907260f08f404b429b64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"dcaa6c90_6eacc515","updated":"2022-06-14 09:05:37.000000000","message":"LGTM","commit_id":"48658e851593116d138b29fcc09fa339e3d619c1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ef00fcbea0335f22d70975c285a334522c9e856d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"64acf4a2_1a4264ae","updated":"2022-08-08 19:40:24.000000000","message":"A little worried about this change. 4 CI failures. It is likely to be completely unrelated, but lets make sure it isn\u0027t related to this patch.","commit_id":"a2b08ee1b19ad034afa4fb784fdd0c4c6b6ae652"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"34e8b2735943a34b62b2ba3573dcb46a983c990b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a9a14093_1b491b22","updated":"2022-08-03 08:55:49.000000000","message":"Hi Eri","commit_id":"a2b08ee1b19ad034afa4fb784fdd0c4c6b6ae652"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"bbf06630c9b06add308a583d2d1c5e7271e9328a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1d0f0aac_6f4d743c","updated":"2022-08-15 15:19:34.000000000","message":"I think that maybe the \"remained TLDs\" by test_recordset_validation.py\ncaused to this instability. I\u0027ve proposed \"cleanup fix\" patch:\nhttps://review.opendev.org/c/openstack/designate-tempest-plugin/+/853172\nOn my Devstack host, when I\u0027m running the tests with the same concurrency 4\nand with both patches\u0027 code changes included, everything seems to work fine:\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 345 tests in 888.5228 sec.\n - Passed: 336\n - Skipped: 8\n - Expected Fail: 0\n - Unexpected Success: 1\n - Failed: 0\nSum of execute time for each test: 2197.6529 sec.","commit_id":"a2b08ee1b19ad034afa4fb784fdd0c4c6b6ae652"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a9ec5adde0857a205abad4660e7e3deb449f1441","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fca52cf4_cd1e9976","updated":"2022-08-02 21:32:06.000000000","message":"This still looks good to me.","commit_id":"a2b08ee1b19ad034afa4fb784fdd0c4c6b6ae652"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ad07eacbb62a89c5f76215614c7e35fc881f2d92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"063fcfdb_bb653a76","updated":"2022-08-17 08:47:48.000000000","message":"recheck\n\nRebuild the results.","commit_id":"a2b08ee1b19ad034afa4fb784fdd0c4c6b6ae652"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"e564d61f0a154d8fe70f90cf6adf7b6fbfd41b00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d5de91ed_4eeb0302","updated":"2022-08-17 08:49:21.000000000","message":"recheck\n\nRebuild the results.","commit_id":"a2b08ee1b19ad034afa4fb784fdd0c4c6b6ae652"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"14fda5fd5e54a7745d3708812826aecf59e50d19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"238f7b8d_9ce94e4a","updated":"2022-08-08 15:55:40.000000000","message":"recheck\nRe-approving workflow","commit_id":"a2b08ee1b19ad034afa4fb784fdd0c4c6b6ae652"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"0adf26e5589131828a0204422f40811e1860c2ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8bdcf271_d35b2015","updated":"2022-08-08 18:05:35.000000000","message":"recheck designate-api failed to start (port issue)","commit_id":"a2b08ee1b19ad034afa4fb784fdd0c4c6b6ae652"}],"designate_tempest_plugin/common/waiters.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"5fe3de30a178568825198da4fedc48cf4a06bfb2","unresolved":true,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"def wait_for_recordset_status(client, zone_id, recordset_id,"},{"line_number":172,"context_line":"                              status, headers\u003dNone):"},{"line_number":173,"context_line":"    \"\"\"Waits for a recordset to reach the given status.\"\"\""},{"line_number":174,"context_line":"    LOG.info(\u0027Waiting for recordset %s to reach %s\u0027,"},{"line_number":175,"context_line":"             recordset_id, status)"}],"source_content_type":"text/x-python","patch_set":9,"id":"531ae749_fbe135cf","line":172,"updated":"2022-08-02 22:35:19.000000000","message":"Is this spacing intentional? I feel like this is against pep, but maybe not since it isn\u0027t complaining?","commit_id":"48658e851593116d138b29fcc09fa339e3d619c1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"1c5985ae36d0b3eac3585747dfdd08cd93bfaf94","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"def wait_for_recordset_status(client, zone_id, recordset_id,"},{"line_number":172,"context_line":"                              status, headers\u003dNone):"},{"line_number":173,"context_line":"    \"\"\"Waits for a recordset to reach the given status.\"\"\""},{"line_number":174,"context_line":"    LOG.info(\u0027Waiting for recordset %s to reach %s\u0027,"},{"line_number":175,"context_line":"             recordset_id, status)"}],"source_content_type":"text/x-python","patch_set":9,"id":"65c0681d_25dbd7d7","line":172,"in_reply_to":"531ae749_fbe135cf","updated":"2022-08-02 22:36:03.000000000","message":"Oh my bad this is from another change.","commit_id":"48658e851593116d138b29fcc09fa339e3d619c1"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"34e8b2735943a34b62b2ba3573dcb46a983c990b","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"def wait_for_recordset_status(client, zone_id, recordset_id,"},{"line_number":172,"context_line":"                              status, headers\u003dNone):"},{"line_number":173,"context_line":"    \"\"\"Waits for a recordset to reach the given status.\"\"\""},{"line_number":174,"context_line":"    LOG.info(\u0027Waiting for recordset %s to reach %s\u0027,"},{"line_number":175,"context_line":"             recordset_id, status)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1307bd1c_90a47fe9","line":172,"in_reply_to":"65c0681d_25dbd7d7","updated":"2022-08-03 08:55:49.000000000","message":"Hi Erik\n\nIt\u0027s OK.\nCan you set the workflow back to 1 then? \n\nThanks!","commit_id":"48658e851593116d138b29fcc09fa339e3d619c1"}],"designate_tempest_plugin/services/dns/v2/json/recordset_client.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"cb8c70f5655e3c71955e4c44af84641c5c21acd9","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        :param headers (dict): The headers to use for the request."},{"line_number":47,"context_line":"        :return: A tuple with the server response and the created zone."},{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        if headers:"},{"line_number":50,"context_line":"            resp, body \u003d self._create_request("},{"line_number":51,"context_line":"                \"/zones/{0}/recordsets\".format(zone_uuid), params\u003dparams,"},{"line_number":52,"context_line":"                data\u003drecordset_data, extra_headers\u003dTrue, headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":8,"id":"44d43a32_61cff290","line":49,"updated":"2022-06-03 14:56:18.000000000","message":"Both create_recordset \u0026 update_recordset use the extra_headers \u0026 headers as parameters to the request which will be sent eventually.\n\nMaybe we could use them in the same way? (either receiving them as parameters or deciding by the if statement before passing them on).\n\nJust a suggestion...","commit_id":"02504df1a4bc3af172f246a8d21887099e3ceece"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0cb21091f453c13f5e6bb81da7b1b2741329a9d7","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        :param headers (dict): The headers to use for the request."},{"line_number":47,"context_line":"        :return: A tuple with the server response and the created zone."},{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        if headers:"},{"line_number":50,"context_line":"            resp, body \u003d self._create_request("},{"line_number":51,"context_line":"                \"/zones/{0}/recordsets\".format(zone_uuid), params\u003dparams,"},{"line_number":52,"context_line":"                data\u003drecordset_data, extra_headers\u003dTrue, headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff952c3f_d216a014","line":49,"in_reply_to":"44d43a32_61cff290","updated":"2022-06-13 12:57:32.000000000","message":"\"extra_headers\" is taken form Tempest and it takes care to add all necessary (HTTP headers for request like content-type e.t.c)","commit_id":"02504df1a4bc3af172f246a8d21887099e3ceece"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1ea6f976eedfae51d5292d928654633fc05581f9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        :param headers (dict): The headers to use for the request."},{"line_number":47,"context_line":"        :return: A tuple with the server response and the created zone."},{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        if headers:"},{"line_number":50,"context_line":"            resp, body \u003d self._create_request("},{"line_number":51,"context_line":"                \"/zones/{0}/recordsets\".format(zone_uuid), params\u003dparams,"},{"line_number":52,"context_line":"                data\u003drecordset_data, extra_headers\u003dTrue, headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":8,"id":"b37ba741_8e8f9087","line":49,"in_reply_to":"ff952c3f_d216a014","updated":"2022-06-13 12:59:26.000000000","message":"Done","commit_id":"02504df1a4bc3af172f246a8d21887099e3ceece"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"cb8c70f5655e3c71955e4c44af84641c5c21acd9","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @base.handle_errors"},{"line_number":68,"context_line":"    def update_recordset(self, zone_uuid, recordset_uuid,"},{"line_number":69,"context_line":"                         recordet_data, params\u003dNone,"},{"line_number":70,"context_line":"                         headers\u003dNone, extra_headers\u003dNone, wait_until\u003dFalse):"},{"line_number":71,"context_line":"        \"\"\"Update the recordset related to the specified zone."},{"line_number":72,"context_line":"        :param zone_uuid: Unique identifier of the zone in UUID format."}],"source_content_type":"text/x-python","patch_set":8,"id":"b21d2817_67967432","line":69,"range":{"start_line":69,"start_character":25,"end_line":69,"end_character":38},"updated":"2022-06-03 14:56:18.000000000","message":"I know it is not included in the spec of this change, but maybe we could fix this typo.","commit_id":"02504df1a4bc3af172f246a8d21887099e3ceece"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0cb21091f453c13f5e6bb81da7b1b2741329a9d7","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @base.handle_errors"},{"line_number":68,"context_line":"    def update_recordset(self, zone_uuid, recordset_uuid,"},{"line_number":69,"context_line":"                         recordet_data, params\u003dNone,"},{"line_number":70,"context_line":"                         headers\u003dNone, extra_headers\u003dNone, wait_until\u003dFalse):"},{"line_number":71,"context_line":"        \"\"\"Update the recordset related to the specified zone."},{"line_number":72,"context_line":"        :param zone_uuid: Unique identifier of the zone in UUID format."}],"source_content_type":"text/x-python","patch_set":8,"id":"cfae12c8_1da311c0","line":69,"range":{"start_line":69,"start_character":25,"end_line":69,"end_character":38},"in_reply_to":"b21d2817_67967432","updated":"2022-06-13 12:57:32.000000000","message":"Done","commit_id":"02504df1a4bc3af172f246a8d21887099e3ceece"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"cb8c70f5655e3c71955e4c44af84641c5c21acd9","unresolved":true,"context_lines":[{"line_number":83,"context_line":"                                     headers are needed in the request"},{"line_number":84,"context_line":"                                     pass them in as a dict."},{"line_number":85,"context_line":"        :param wait_until: Block until the recordset reaches the"},{"line_number":86,"context_line":"                           desiered status"},{"line_number":87,"context_line":"        :return: A tuple with the server response and the created zone."},{"line_number":88,"context_line":"        \"\"\""},{"line_number":89,"context_line":"        resp, body \u003d self._put_request("}],"source_content_type":"text/x-python","patch_set":8,"id":"214e8190_4d941d26","line":86,"range":{"start_line":86,"start_character":27,"end_line":86,"end_character":35},"updated":"2022-06-03 14:56:18.000000000","message":"Typo: desired","commit_id":"02504df1a4bc3af172f246a8d21887099e3ceece"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"0cb21091f453c13f5e6bb81da7b1b2741329a9d7","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                                     headers are needed in the request"},{"line_number":84,"context_line":"                                     pass them in as a dict."},{"line_number":85,"context_line":"        :param wait_until: Block until the recordset reaches the"},{"line_number":86,"context_line":"                           desiered status"},{"line_number":87,"context_line":"        :return: A tuple with the server response and the created zone."},{"line_number":88,"context_line":"        \"\"\""},{"line_number":89,"context_line":"        resp, body \u003d self._put_request("}],"source_content_type":"text/x-python","patch_set":8,"id":"7d34f42c_625499a1","line":86,"range":{"start_line":86,"start_character":27,"end_line":86,"end_character":35},"in_reply_to":"214e8190_4d941d26","updated":"2022-06-13 12:57:32.000000000","message":"Done","commit_id":"02504df1a4bc3af172f246a8d21887099e3ceece"}],"designate_tempest_plugin/tests/api/v2/test_recordset.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"519bb43b602bceeb92eb31f499535b76f5260073","unresolved":true,"context_lines":[{"line_number":892,"context_line":"        recordsets \u003d self.recordset_client.list_recordset("},{"line_number":893,"context_line":"            self.zone[\u0027id\u0027])[1][\u0027recordsets\u0027]"},{"line_number":894,"context_line":"        for recordset in recordsets:"},{"line_number":895,"context_line":"            if recordset[\u0027type\u0027].lower() \u003d\u003d \u0027ns\u0027:"},{"line_number":896,"context_line":"                ns_record_id \u003d recordset[\u0027id\u0027]"},{"line_number":897,"context_line":"                break"},{"line_number":898,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"69970d17_d3711969","line":895,"updated":"2022-05-06 22:36:28.000000000","message":"nit: These are always going to be capitalized, i.e. \u0027NS\u0027\nThe type codes are part of the RFC.","commit_id":"8e72a370c8d0e4edf3e348c4af7563ee4b1ede75"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5463ff8574ea8bb933b513f7b8d6f3197365e2cb","unresolved":false,"context_lines":[{"line_number":892,"context_line":"        recordsets \u003d self.recordset_client.list_recordset("},{"line_number":893,"context_line":"            self.zone[\u0027id\u0027])[1][\u0027recordsets\u0027]"},{"line_number":894,"context_line":"        for recordset in recordsets:"},{"line_number":895,"context_line":"            if recordset[\u0027type\u0027].lower() \u003d\u003d \u0027ns\u0027:"},{"line_number":896,"context_line":"                ns_record_id \u003d recordset[\u0027id\u0027]"},{"line_number":897,"context_line":"                break"},{"line_number":898,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"c462bce7_496738dc","line":895,"in_reply_to":"69970d17_d3711969","updated":"2022-05-12 09:24:42.000000000","message":"Done","commit_id":"8e72a370c8d0e4edf3e348c4af7563ee4b1ede75"}],"designate_tempest_plugin/tests/scenario/v2/test_recordsets.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ed8a4aa2d2f29f354b29f3a2bee308e990530582","unresolved":true,"context_lines":[{"line_number":9,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":"import ddt"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from oslo_log import log as logging"},{"line_number":15,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"d6981e13_6d34bf92","line":12,"updated":"2022-04-12 20:15:32.000000000","message":"ddt is not a python core module. It is a third party library, like the oslo_log and tempest.","commit_id":"2a3343b0b58e160ffea155411d6e215368a505e6"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5463ff8574ea8bb933b513f7b8d6f3197365e2cb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":"import ddt"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from oslo_log import log as logging"},{"line_number":15,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a03e31e_39edd737","line":12,"in_reply_to":"d6981e13_6d34bf92","updated":"2022-05-12 09:24:42.000000000","message":"Done","commit_id":"2a3343b0b58e160ffea155411d6e215368a505e6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"519bb43b602bceeb92eb31f499535b76f5260073","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    import SingleQueryClient"},{"line_number":26,"context_line":"from designate_tempest_plugin import data_utils as dns_data_utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"import ddt"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"e7c47265_15c4fd2a","line":28,"updated":"2022-05-06 22:36:28.000000000","message":"This should go back up into the section with oslo_log.","commit_id":"8e72a370c8d0e4edf3e348c4af7563ee4b1ede75"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5463ff8574ea8bb933b513f7b8d6f3197365e2cb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    import SingleQueryClient"},{"line_number":26,"context_line":"from designate_tempest_plugin import data_utils as dns_data_utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"import ddt"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"01729673_782c2019","line":28,"in_reply_to":"e7c47265_15c4fd2a","updated":"2022-05-12 09:24:42.000000000","message":"Done","commit_id":"8e72a370c8d0e4edf3e348c4af7563ee4b1ede75"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"519bb43b602bceeb92eb31f499535b76f5260073","unresolved":true,"context_lines":[{"line_number":114,"context_line":"    @decorators.idempotent_id(\u0027cbf756b0-ba64-11ec-93d4-201e8823901f\u0027)"},{"line_number":115,"context_line":"    @ddt.file_data(\"recordset_data.json\")"},{"line_number":116,"context_line":"    def test_update_records_propagated_to_backends(self, name, type, records):"},{"line_number":117,"context_line":"        if name is not None:"},{"line_number":118,"context_line":"            recordset_name \u003d name + \".\" + self.zone[\u0027name\u0027]"},{"line_number":119,"context_line":"        else:"},{"line_number":120,"context_line":"            recordset_name \u003d self.zone[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"c044cb45_5ecf158a","line":117,"updated":"2022-05-06 22:36:28.000000000","message":"nit: this can be simplified to just\nif name:\nelse:","commit_id":"8e72a370c8d0e4edf3e348c4af7563ee4b1ede75"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5463ff8574ea8bb933b513f7b8d6f3197365e2cb","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    @decorators.idempotent_id(\u0027cbf756b0-ba64-11ec-93d4-201e8823901f\u0027)"},{"line_number":115,"context_line":"    @ddt.file_data(\"recordset_data.json\")"},{"line_number":116,"context_line":"    def test_update_records_propagated_to_backends(self, name, type, records):"},{"line_number":117,"context_line":"        if name is not None:"},{"line_number":118,"context_line":"            recordset_name \u003d name + \".\" + self.zone[\u0027name\u0027]"},{"line_number":119,"context_line":"        else:"},{"line_number":120,"context_line":"            recordset_name \u003d self.zone[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"df9173e7_b8ebd12c","line":117,"in_reply_to":"c044cb45_5ecf158a","updated":"2022-05-12 09:24:42.000000000","message":"Done","commit_id":"8e72a370c8d0e4edf3e348c4af7563ee4b1ede75"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"519bb43b602bceeb92eb31f499535b76f5260073","unresolved":true,"context_lines":[{"line_number":171,"context_line":"        recordsets \u003d self.recordset_client.list_recordset("},{"line_number":172,"context_line":"            zone[\u0027id\u0027])[1][\u0027recordsets\u0027]"},{"line_number":173,"context_line":"        for recordset in recordsets:"},{"line_number":174,"context_line":"            if recordset[\u0027type\u0027].lower() \u003d\u003d \u0027ns\u0027:"},{"line_number":175,"context_line":"                ns_record_id \u003d recordset[\u0027id\u0027]"},{"line_number":176,"context_line":"                break"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"73eeb688_7966291a","line":174,"updated":"2022-05-06 22:36:28.000000000","message":"same nit here, it will always be \u0027NS\u0027","commit_id":"8e72a370c8d0e4edf3e348c4af7563ee4b1ede75"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5463ff8574ea8bb933b513f7b8d6f3197365e2cb","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        recordsets \u003d self.recordset_client.list_recordset("},{"line_number":172,"context_line":"            zone[\u0027id\u0027])[1][\u0027recordsets\u0027]"},{"line_number":173,"context_line":"        for recordset in recordsets:"},{"line_number":174,"context_line":"            if recordset[\u0027type\u0027].lower() \u003d\u003d \u0027ns\u0027:"},{"line_number":175,"context_line":"                ns_record_id \u003d recordset[\u0027id\u0027]"},{"line_number":176,"context_line":"                break"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"63ae58d6_936977a7","line":174,"in_reply_to":"73eeb688_7966291a","updated":"2022-05-12 09:24:42.000000000","message":"Done","commit_id":"8e72a370c8d0e4edf3e348c4af7563ee4b1ede75"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"519bb43b602bceeb92eb31f499535b76f5260073","unresolved":true,"context_lines":[{"line_number":183,"context_line":"            \"name\": \"NS_Record.{}\".format(zone[\u0027name\u0027]),"},{"line_number":184,"context_line":"            \"type\": \"NS\", \"records\": ["},{"line_number":185,"context_line":"                \"ns1.{}.org.\".format(dns_data_utils.rand_string(6))]}"},{"line_number":186,"context_line":"        self.admin_client.create_recordset("},{"line_number":187,"context_line":"            zone[\u0027id\u0027], ns_record,"},{"line_number":188,"context_line":"            headers\u003d{**self.all_projects_header, **self.managed_records},"},{"line_number":189,"context_line":"            wait_until\u003dconst.ACTIVE)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f19c0317_df1b80af","line":186,"updated":"2022-05-06 22:36:28.000000000","message":"Missing cleanup hook","commit_id":"8e72a370c8d0e4edf3e348c4af7563ee4b1ede75"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5463ff8574ea8bb933b513f7b8d6f3197365e2cb","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            \"name\": \"NS_Record.{}\".format(zone[\u0027name\u0027]),"},{"line_number":184,"context_line":"            \"type\": \"NS\", \"records\": ["},{"line_number":185,"context_line":"                \"ns1.{}.org.\".format(dns_data_utils.rand_string(6))]}"},{"line_number":186,"context_line":"        self.admin_client.create_recordset("},{"line_number":187,"context_line":"            zone[\u0027id\u0027], ns_record,"},{"line_number":188,"context_line":"            headers\u003d{**self.all_projects_header, **self.managed_records},"},{"line_number":189,"context_line":"            wait_until\u003dconst.ACTIVE)"}],"source_content_type":"text/x-python","patch_set":4,"id":"26647d77_137dde9c","line":186,"in_reply_to":"f19c0317_df1b80af","updated":"2022-05-12 09:24:42.000000000","message":"Done","commit_id":"8e72a370c8d0e4edf3e348c4af7563ee4b1ede75"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2f1109f927efcfd427612921fd1f2cfe4619a7aa","unresolved":true,"context_lines":[{"line_number":175,"context_line":"                break"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        LOG.info(\u0027As admin user delete NS Recordset\u0027)"},{"line_number":178,"context_line":"        self.admin_client.delete_recordset("},{"line_number":179,"context_line":"            zone[\u0027id\u0027], ns_record_id,"},{"line_number":180,"context_line":"            headers\u003d{**self.all_projects_header, **self.managed_records})"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"c86ece14_699ed5b2","line":178,"updated":"2022-05-12 23:41:44.000000000","message":"Deleting the only NS record in the zone means BIND will not know where to go for the zone transfer (I.e. doesn\u0027t know where miniDNS is anymore).\n\nSo, this test scenario is invalid.\n\nSee the log here: https://zuul.opendev.org/t/openstack/build/82751988c6c04690952dc8d0b4628eaa/log/controller/logs/bind9.txt#2819","commit_id":"570c3fe7458c94f7c230d05ee4cbf47cb016cc9a"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1ea6f976eedfae51d5292d928654633fc05581f9","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                break"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        LOG.info(\u0027As admin user delete NS Recordset\u0027)"},{"line_number":178,"context_line":"        self.admin_client.delete_recordset("},{"line_number":179,"context_line":"            zone[\u0027id\u0027], ns_record_id,"},{"line_number":180,"context_line":"            headers\u003d{**self.all_projects_header, **self.managed_records})"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e3fbbce9_9010f2c1","line":178,"in_reply_to":"c86ece14_699ed5b2","updated":"2022-06-13 12:59:26.000000000","message":"Done","commit_id":"570c3fe7458c94f7c230d05ee4cbf47cb016cc9a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fde252aa937ea68ad23a513c097163c73b43794b","unresolved":true,"context_lines":[{"line_number":180,"context_line":"            headers\u003d{**self.all_projects_header, **self.managed_records})"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        LOG.info(\u0027Ensure successful deletion of Recordset\u0027)"},{"line_number":183,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":184,"context_line":"            lambda: self.admin_client.show_recordset("},{"line_number":185,"context_line":"                zone[\u0027id\u0027], ns_record_id,"},{"line_number":186,"context_line":"                headers\u003d{**self.all_projects_header, **self.managed_records}))"}],"source_content_type":"text/x-python","patch_set":5,"id":"a46fdbbd_f569de4b","line":183,"updated":"2022-05-12 23:46:11.000000000","message":"So this check is showing it removed in the Designate DB, but BIND is refusing to update the zone on the BIND side as the zone it\u0027s trying to transfer in is invalid.","commit_id":"570c3fe7458c94f7c230d05ee4cbf47cb016cc9a"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5db5fe1f4ee791555f4dd14c443add070b8ee4de","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            headers\u003d{**self.all_projects_header, **self.managed_records})"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        LOG.info(\u0027Ensure successful deletion of Recordset\u0027)"},{"line_number":183,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":184,"context_line":"            lambda: self.admin_client.show_recordset("},{"line_number":185,"context_line":"                zone[\u0027id\u0027], ns_record_id,"},{"line_number":186,"context_line":"                headers\u003d{**self.all_projects_header, **self.managed_records}))"}],"source_content_type":"text/x-python","patch_set":5,"id":"8a635ae4_30f351f9","line":183,"in_reply_to":"a46fdbbd_f569de4b","updated":"2022-05-15 07:45:19.000000000","message":"Done","commit_id":"570c3fe7458c94f7c230d05ee4cbf47cb016cc9a"}]}