)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"08a2e67f_7fab1a73","updated":"2023-02-22 22:59:06.000000000","message":"I have added a few comments. I will rebase this as well to pull in the zones_client changes that merged today. Some will likely still need to be fixed here.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"42e0ac2050eb19b6a9d7524d2a29675d15d11b1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f39ecd48_2cf74b3d","updated":"2022-11-01 22:57:17.000000000","message":"LGTM - I even comment out the skips to make sure it still fails because of https://bugs.launchpad.net/designate/+bug/1992445\n\nall-plugin run-test: commands[3] | tempest run --regex designate_tempest_plugin.tests.scenario.v2.test_quotas\n{1} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasBoundary.test_api_export_size_boundary ... SKIPPED: Skipped until bug: https://launchpad.net/bugs/1960495 is resolved.\n{0} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasV2Test.test_api_export_size_quota ... SKIPPED: Skipped until bug: https://launchpad.net/bugs/1960495 is resolved.\n{1} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasBoundary.test_recordset_records_boundary [1.829618s] ... ok\n{1} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasBoundary.test_zone_quota_boundary [1.083670s] ... ok\n{1} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasBoundary.test_zone_records_boundary [1.593833s] ... ok\n{1} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasBoundary.test_zone_recordsets_boundary ... SKIPPED: Skipped until bug: https://launchpad.net/bugs/1992445 is resolved.\n{0} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasV2Test.test_recordset_records_quota [13.694860s] ... ok\n{0} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasV2Test.test_zone_records_quota [36.758744s] ... ok\n{0} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasV2Test.test_zone_recordsets_quota [21.432003s] ... ok\n{0} designate_tempest_plugin.tests.scenario.v2.test_quotas.QuotasV2Test.test_zones_quota [20.539675s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 10 tests in 93.7436 sec.\n - Passed: 7\n - Skipped: 3\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 96.9347 sec.\n\n","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"144ceb8bcd3812f4ab6efbe9484e220c897b255b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f79ba324_5dc2b686","updated":"2022-12-29 08:23:20.000000000","message":"recheck","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8370404f9621318439a95903069a13bdf9e6d270","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c2e35db4_e4e7a452","updated":"2023-02-22 23:09:39.000000000","message":"There are still open comments on this patch","commit_id":"3422a258f9243479ca591d43ad8e85b0a307e6ad"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c8de161149d9c83c81d869bb8509b8e373103efb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"97e06e91_439cca0c","updated":"2023-06-20 09:09:08.000000000","message":"recheck","commit_id":"8c451269eeb22d12b94789f5c7a075c0a3518b53"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b1c19bbc447359881b0f337c8a9866135f4bcf5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"72e476f6_175ec62b","updated":"2025-10-22 10:47:51.000000000","message":"I have just fixed the bug that makes 2/4 of these tests to skip. You can try using it in this commit to make sure the tests pass\nhttps://review.opendev.org/c/openstack/designate/+/964527","commit_id":"a84128e4c6ef225dd44443941d2b810736be072d"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f4811b28468875b949c41473e3f6dfbdd702d4b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0d701116_eada15b0","updated":"2025-03-27 16:30:51.000000000","message":"recheck","commit_id":"a84128e4c6ef225dd44443941d2b810736be072d"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"158eb81cd871488b03a6eb490bca5d9c4f4da8a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"99342ab3_380b9cf5","updated":"2025-03-30 10:51:22.000000000","message":"recheck","commit_id":"a84128e4c6ef225dd44443941d2b810736be072d"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"930f27bfa27d19b6a09cf037eae60923e38ecf74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"dbceee2b_bb2c8de5","updated":"2025-03-27 18:13:30.000000000","message":"recheck","commit_id":"a84128e4c6ef225dd44443941d2b810736be072d"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"77fd87383d36c13d4274ed681178e44601171cc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"dfbe9b19_bcec5254","updated":"2025-10-22 09:04:10.000000000","message":"recheck","commit_id":"a84128e4c6ef225dd44443941d2b810736be072d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7e28f88020808c188a1678d7be293a8dea0ae32c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8f078da8_726a2758","updated":"2025-04-02 08:26:29.000000000","message":"recheck https://review.opendev.org/c/openstack/designate/+/946058 fixed the gates","commit_id":"a84128e4c6ef225dd44443941d2b810736be072d"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"b99b70c2c5634ab6a20b9ca14a3f4876ecf14fac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a20dbf7d_8205b2cd","updated":"2025-11-03 11:18:15.000000000","message":"Hi @oschwart@redhat.com!\n\nI think that all stable* gates failed are due to the fact that they don\u0027t include your fix patch provided in \"depends-on\".\nRest of the gates looks good, your fix does the job, I\u0027ll recheck once your fix patch is merged.","commit_id":"d78ab8b35068f4511abd6a0242512862725bfe41"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"ef12261f4090c6f8dd51ef10181ae515b8d4d70f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2e43321e_3f30bbd3","updated":"2026-03-22 09:50:40.000000000","message":"recheck","commit_id":"d78ab8b35068f4511abd6a0242512862725bfe41"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5762ac2fbfbdf5e1a96f2b99781b3882a7b2ea7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d609f6ac_1e99bc30","updated":"2026-01-18 10:31:42.000000000","message":"recheck","commit_id":"d78ab8b35068f4511abd6a0242512862725bfe41"}],"designate_tempest_plugin/tests/scenario/v2/test_quotas.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            cls.admin_tld_client \u003d cls.os_admin.dns_v2.TldClient()"},{"line_number":64,"context_line":"        cls.quotas_client \u003d cls.os_primary.dns_v2.QuotasClient()"},{"line_number":65,"context_line":"        cls.alt_client \u003d cls.os_alt.dns_v2.QuotasClient()"},{"line_number":66,"context_line":"        cls.zone_client \u003d cls.os_primary.dns_v2.ZonesClient()"},{"line_number":67,"context_line":"        cls.alt_zone_client \u003d cls.os_alt.dns_v2.ZonesClient()"},{"line_number":68,"context_line":"        cls.recordset_client \u003d cls.os_primary.dns_v2.RecordsetClient()"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d4107768_d732e521","line":66,"updated":"2023-02-22 22:59:06.000000000","message":"This is going to need a rebase, this client was removed in favor of having one client created in the base class.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d06470c2d1ec7f738db5c3fe6a0acdded645bff","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            cls.admin_tld_client \u003d cls.os_admin.dns_v2.TldClient()"},{"line_number":64,"context_line":"        cls.quotas_client \u003d cls.os_primary.dns_v2.QuotasClient()"},{"line_number":65,"context_line":"        cls.alt_client \u003d cls.os_alt.dns_v2.QuotasClient()"},{"line_number":66,"context_line":"        cls.zone_client \u003d cls.os_primary.dns_v2.ZonesClient()"},{"line_number":67,"context_line":"        cls.alt_zone_client \u003d cls.os_alt.dns_v2.ZonesClient()"},{"line_number":68,"context_line":"        cls.recordset_client \u003d cls.os_primary.dns_v2.RecordsetClient()"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5c2e541a_6c8ef288","line":66,"in_reply_to":"d4107768_d732e521","updated":"2023-02-22 23:09:20.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":354,"context_line":"        # Create a first Zone --\u003e Should PASS"},{"line_number":355,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("},{"line_number":356,"context_line":"            name\u003d\"test_zone_quota_boundary_attempt_1\", suffix\u003dself.tld_name)"},{"line_number":357,"context_line":"        quota_exeded_zone \u003d self.zone_client.create_zone("},{"line_number":358,"context_line":"            name\u003dzone_name, project_id\u003dtenant_id)[1]"},{"line_number":359,"context_line":"        self.addCleanup("},{"line_number":360,"context_line":"            self.wait_zone_delete, self.zone_client, quota_exeded_zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"d5c5d7f9_56bf7f3c","line":357,"range":{"start_line":357,"start_character":33,"end_line":357,"end_character":44},"updated":"2023-02-22 22:59:06.000000000","message":"This will need to be updated to zones_client, a rebase might catch this.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d06470c2d1ec7f738db5c3fe6a0acdded645bff","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        # Create a first Zone --\u003e Should PASS"},{"line_number":355,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("},{"line_number":356,"context_line":"            name\u003d\"test_zone_quota_boundary_attempt_1\", suffix\u003dself.tld_name)"},{"line_number":357,"context_line":"        quota_exeded_zone \u003d self.zone_client.create_zone("},{"line_number":358,"context_line":"            name\u003dzone_name, project_id\u003dtenant_id)[1]"},{"line_number":359,"context_line":"        self.addCleanup("},{"line_number":360,"context_line":"            self.wait_zone_delete, self.zone_client, quota_exeded_zone[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7867c4e1_cf7581b3","line":357,"range":{"start_line":357,"start_character":33,"end_line":357,"end_character":44},"in_reply_to":"d5c5d7f9_56bf7f3c","updated":"2023-02-22 23:09:20.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":398,"context_line":"            \u0027recordset_records\u0027: 7, \u0027api_export_size\u0027: 7}"},{"line_number":399,"context_line":"        self.quota_client.set_quotas("},{"line_number":400,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":401,"context_line":"            headers\u003dsudo_header)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        # Create a Zone"},{"line_number":404,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"60887815_76227aa9","line":401,"updated":"2023-02-22 22:59:06.000000000","message":"You do not want to sudo here as that project will not have enough permission to set a quota.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7299c83ac4387f8b6757a9f85bd7173fb244159e","unresolved":true,"context_lines":[{"line_number":398,"context_line":"            \u0027recordset_records\u0027: 7, \u0027api_export_size\u0027: 7}"},{"line_number":399,"context_line":"        self.quota_client.set_quotas("},{"line_number":400,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":401,"context_line":"            headers\u003dsudo_header)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        # Create a Zone"},{"line_number":404,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"fe4220b3_7eea8ee4","line":401,"in_reply_to":"60887815_76227aa9","updated":"2023-02-23 13:07:58.000000000","message":"I gave the client a \"bad\" name that misleads.\nSetting of quota for some project is done using the admin client, I\u0027ll replace \"quota_client\" to \"adm_quota_client\".","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4244a0039cd441fe83cb2f5733ee00dea96231ee","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            \u0027recordset_records\u0027: 7, \u0027api_export_size\u0027: 7}"},{"line_number":399,"context_line":"        self.quota_client.set_quotas("},{"line_number":400,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":401,"context_line":"            headers\u003dsudo_header)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        # Create a Zone"},{"line_number":404,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"77e9323a_7692ec60","line":401,"in_reply_to":"fe4220b3_7eea8ee4","updated":"2023-04-16 15:04:56.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":403,"context_line":"        # Create a Zone"},{"line_number":404,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("},{"line_number":405,"context_line":"            name\u003d\"test_zone_recordsets_boundary\", suffix\u003dself.tld_name)"},{"line_number":406,"context_line":"        zone \u003d self.zone_client.create_zone("},{"line_number":407,"context_line":"            name\u003dzone_name, project_id\u003dtenant_id)[1]"},{"line_number":408,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"00a5e601_22a7af0a","line":406,"range":{"start_line":406,"start_character":20,"end_line":406,"end_character":31},"updated":"2023-02-22 22:59:06.000000000","message":"This will need to be updated to zones_client","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d06470c2d1ec7f738db5c3fe6a0acdded645bff","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        # Create a Zone"},{"line_number":404,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("},{"line_number":405,"context_line":"            name\u003d\"test_zone_recordsets_boundary\", suffix\u003dself.tld_name)"},{"line_number":406,"context_line":"        zone \u003d self.zone_client.create_zone("},{"line_number":407,"context_line":"            name\u003dzone_name, project_id\u003dtenant_id)[1]"},{"line_number":408,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6c77634b_d6f380a1","line":406,"range":{"start_line":406,"start_character":20,"end_line":406,"end_character":31},"in_reply_to":"00a5e601_22a7af0a","updated":"2023-02-22 23:09:20.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":407,"context_line":"            name\u003dzone_name, project_id\u003dtenant_id)[1]"},{"line_number":408,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        # Create a 3rd recordset --\u003e Should PASS"},{"line_number":411,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":412,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":413,"context_line":"        resp, body \u003d self.recordset_client.create_recordset("}],"source_content_type":"text/x-python","patch_set":1,"id":"2dc8c4af_f05e9968","line":410,"range":{"start_line":410,"start_character":19,"end_line":410,"end_character":23},"updated":"2023-02-22 22:59:06.000000000","message":"I get that this is the 3rd because of the SOA/NS, but I think we want to fix this to be the \"1st\" for quota. Or at least leave a comment/todo\nCounting the SOA and NS can be odd give that a cloud could be running this test that has three NS records due to the pool configuration.\nPlus it makes this test confusing given you set a quota of one above on line 397","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4244a0039cd441fe83cb2f5733ee00dea96231ee","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            name\u003dzone_name, project_id\u003dtenant_id)[1]"},{"line_number":408,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        # Create a 3rd recordset --\u003e Should PASS"},{"line_number":411,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":412,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":413,"context_line":"        resp, body \u003d self.recordset_client.create_recordset("}],"source_content_type":"text/x-python","patch_set":1,"id":"8216d090_437e06f5","line":410,"range":{"start_line":410,"start_character":19,"end_line":410,"end_character":23},"in_reply_to":"20ebe565_134ce3fc","updated":"2023-04-16 15:04:56.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7299c83ac4387f8b6757a9f85bd7173fb244159e","unresolved":true,"context_lines":[{"line_number":407,"context_line":"            name\u003dzone_name, project_id\u003dtenant_id)[1]"},{"line_number":408,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        # Create a 3rd recordset --\u003e Should PASS"},{"line_number":411,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":412,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":413,"context_line":"        resp, body \u003d self.recordset_client.create_recordset("}],"source_content_type":"text/x-python","patch_set":1,"id":"20ebe565_134ce3fc","line":410,"range":{"start_line":410,"start_character":19,"end_line":410,"end_character":23},"in_reply_to":"2dc8c4af_f05e9968","updated":"2023-02-23 13:07:58.000000000","message":"Agree, in fact we do have a bug opened for this: \nhttps://bugs.launchpad.net/designate/+bug/1992445\nI\u0027ll add a comment saying that the test will need to be\nmodified according proposed fix.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":410,"context_line":"        # Create a 3rd recordset --\u003e Should PASS"},{"line_number":411,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":412,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":413,"context_line":"        resp, body \u003d self.recordset_client.create_recordset("},{"line_number":414,"context_line":"            zone[\u0027id\u0027], recordset_data, headers\u003dsudo_header)"},{"line_number":415,"context_line":"        self.addCleanup("},{"line_number":416,"context_line":"            self.wait_recordset_delete, self.recordset_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5bbf9cdd_1cb6968a","line":413,"range":{"start_line":413,"start_character":8,"end_line":413,"end_character":12},"updated":"2023-02-22 22:59:06.000000000","message":"nit: resp isn\u0027t used, in the future this could be an unused variable error.\nMaybe use [1] instead?","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4244a0039cd441fe83cb2f5733ee00dea96231ee","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        # Create a 3rd recordset --\u003e Should PASS"},{"line_number":411,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":412,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":413,"context_line":"        resp, body \u003d self.recordset_client.create_recordset("},{"line_number":414,"context_line":"            zone[\u0027id\u0027], recordset_data, headers\u003dsudo_header)"},{"line_number":415,"context_line":"        self.addCleanup("},{"line_number":416,"context_line":"            self.wait_recordset_delete, self.recordset_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2d1f5b8d_bcc76abb","line":413,"range":{"start_line":413,"start_character":8,"end_line":413,"end_character":12},"in_reply_to":"4de23b00_89ecec0d","updated":"2023-04-16 15:04:56.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7299c83ac4387f8b6757a9f85bd7173fb244159e","unresolved":true,"context_lines":[{"line_number":410,"context_line":"        # Create a 3rd recordset --\u003e Should PASS"},{"line_number":411,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":412,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":413,"context_line":"        resp, body \u003d self.recordset_client.create_recordset("},{"line_number":414,"context_line":"            zone[\u0027id\u0027], recordset_data, headers\u003dsudo_header)"},{"line_number":415,"context_line":"        self.addCleanup("},{"line_number":416,"context_line":"            self.wait_recordset_delete, self.recordset_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4de23b00_89ecec0d","line":413,"range":{"start_line":413,"start_character":8,"end_line":413,"end_character":12},"in_reply_to":"5bbf9cdd_1cb6968a","updated":"2023-02-23 13:07:58.000000000","message":"Yep, will be fixed.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":416,"context_line":"            self.wait_recordset_delete, self.recordset_client,"},{"line_number":417,"context_line":"            zone[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        # Create a 4th recordset --\u003e should FAIL on: 413 over_quota"},{"line_number":420,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":421,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":422,"context_line":"        quota_recset_zone \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"520c036c_0294d82c","line":419,"updated":"2023-02-22 22:59:06.000000000","message":"Same comment here, given this is the second recordset that counts against the quota in line 397, maybe this should be \"2nd\"?","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7299c83ac4387f8b6757a9f85bd7173fb244159e","unresolved":true,"context_lines":[{"line_number":416,"context_line":"            self.wait_recordset_delete, self.recordset_client,"},{"line_number":417,"context_line":"            zone[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        # Create a 4th recordset --\u003e should FAIL on: 413 over_quota"},{"line_number":420,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":421,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":422,"context_line":"        quota_recset_zone \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"5e828619_30aa878d","line":419,"in_reply_to":"520c036c_0294d82c","updated":"2023-02-23 13:07:58.000000000","message":"Yep, in fact this is the second one created for tenant, will fix that.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4244a0039cd441fe83cb2f5733ee00dea96231ee","unresolved":false,"context_lines":[{"line_number":416,"context_line":"            self.wait_recordset_delete, self.recordset_client,"},{"line_number":417,"context_line":"            zone[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        # Create a 4th recordset --\u003e should FAIL on: 413 over_quota"},{"line_number":420,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":421,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":422,"context_line":"        quota_recset_zone \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"0a063d92_6373a0df","line":419,"in_reply_to":"5e828619_30aa878d","updated":"2023-04-16 15:04:56.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":421,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":422,"context_line":"        quota_recset_zone \u003d None"},{"line_number":423,"context_line":"        try:"},{"line_number":424,"context_line":"            resp, quota_recset_zone \u003d self.recordset_client.create_recordset("},{"line_number":425,"context_line":"                zone[\u0027id\u0027], recordset_data, headers\u003dsudo_header)"},{"line_number":426,"context_line":"            self.addCleanup("},{"line_number":427,"context_line":"                self.wait_recordset_delete, self.recordset_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7cdc010_260596ee","line":424,"range":{"start_line":424,"start_character":18,"end_line":424,"end_character":36},"updated":"2023-02-22 22:59:06.000000000","message":"This is not a zone, we should update this variable name for clarity.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4244a0039cd441fe83cb2f5733ee00dea96231ee","unresolved":false,"context_lines":[{"line_number":421,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":422,"context_line":"        quota_recset_zone \u003d None"},{"line_number":423,"context_line":"        try:"},{"line_number":424,"context_line":"            resp, quota_recset_zone \u003d self.recordset_client.create_recordset("},{"line_number":425,"context_line":"                zone[\u0027id\u0027], recordset_data, headers\u003dsudo_header)"},{"line_number":426,"context_line":"            self.addCleanup("},{"line_number":427,"context_line":"                self.wait_recordset_delete, self.recordset_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"14812cd9_2a49754c","line":424,"range":{"start_line":424,"start_character":18,"end_line":424,"end_character":36},"in_reply_to":"b0dcd3a3_c67b5cff","updated":"2023-04-16 15:04:56.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7299c83ac4387f8b6757a9f85bd7173fb244159e","unresolved":true,"context_lines":[{"line_number":421,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":422,"context_line":"        quota_recset_zone \u003d None"},{"line_number":423,"context_line":"        try:"},{"line_number":424,"context_line":"            resp, quota_recset_zone \u003d self.recordset_client.create_recordset("},{"line_number":425,"context_line":"                zone[\u0027id\u0027], recordset_data, headers\u003dsudo_header)"},{"line_number":426,"context_line":"            self.addCleanup("},{"line_number":427,"context_line":"                self.wait_recordset_delete, self.recordset_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b0dcd3a3_c67b5cff","line":424,"range":{"start_line":424,"start_character":18,"end_line":424,"end_character":36},"in_reply_to":"f7cdc010_260596ee","updated":"2023-02-23 13:07:58.000000000","message":"OK, I\u0027ll rename it to quota_recset","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":434,"context_line":"            self.assertIn(\u0027over_quota\u0027, str(e),"},{"line_number":435,"context_line":"                          \u0027Failed, over_quota for a \u0027"},{"line_number":436,"context_line":"                          \u0027zone_recordsets was not raised\u0027)"},{"line_number":437,"context_line":"        finally:"},{"line_number":438,"context_line":"            if quota_recset_zone:"},{"line_number":439,"context_line":"                self.addCleanup("},{"line_number":440,"context_line":"                    self.wait_recordset_delete,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3815c2e9_83332d72","line":437,"updated":"2023-02-22 22:59:06.000000000","message":"This pattern seems a bit odd. We are adding two cleanups for the same resource.\nIt also seems like the client should either return a response or raise an exception. Catching a generic Exception seems wrong.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4244a0039cd441fe83cb2f5733ee00dea96231ee","unresolved":false,"context_lines":[{"line_number":434,"context_line":"            self.assertIn(\u0027over_quota\u0027, str(e),"},{"line_number":435,"context_line":"                          \u0027Failed, over_quota for a \u0027"},{"line_number":436,"context_line":"                          \u0027zone_recordsets was not raised\u0027)"},{"line_number":437,"context_line":"        finally:"},{"line_number":438,"context_line":"            if quota_recset_zone:"},{"line_number":439,"context_line":"                self.addCleanup("},{"line_number":440,"context_line":"                    self.wait_recordset_delete,"}],"source_content_type":"text/x-python","patch_set":1,"id":"27b377ee_d3f5b748","line":437,"in_reply_to":"036ed7c9_e16dd462","updated":"2023-04-16 15:04:56.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7299c83ac4387f8b6757a9f85bd7173fb244159e","unresolved":true,"context_lines":[{"line_number":434,"context_line":"            self.assertIn(\u0027over_quota\u0027, str(e),"},{"line_number":435,"context_line":"                          \u0027Failed, over_quota for a \u0027"},{"line_number":436,"context_line":"                          \u0027zone_recordsets was not raised\u0027)"},{"line_number":437,"context_line":"        finally:"},{"line_number":438,"context_line":"            if quota_recset_zone:"},{"line_number":439,"context_line":"                self.addCleanup("},{"line_number":440,"context_line":"                    self.wait_recordset_delete,"}],"source_content_type":"text/x-python","patch_set":1,"id":"036ed7c9_e16dd462","line":437,"in_reply_to":"3815c2e9_83332d72","updated":"2023-02-23 13:07:58.000000000","message":"I was trying to catch all possible options, therefore it looks a bit odd.\nAnyway, I think that asserting 413 will be enough here. I\u0027ll remove \"try except\" in the next patchset.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":454,"context_line":"        # Create a Zone"},{"line_number":455,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("},{"line_number":456,"context_line":"            name\u003d\"test_zone_records_boundary\", suffix\u003dself.tld_name)"},{"line_number":457,"context_line":"        zone \u003d self.zone_client.create_zone("},{"line_number":458,"context_line":"            name\u003dzone_name, project_id\u003dtenant_id)[1]"},{"line_number":459,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"11a404e1_b36fd16d","line":457,"range":{"start_line":457,"start_character":20,"end_line":457,"end_character":31},"updated":"2023-02-22 22:59:06.000000000","message":"This will need to be updated to zones_client","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d06470c2d1ec7f738db5c3fe6a0acdded645bff","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        # Create a Zone"},{"line_number":455,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("},{"line_number":456,"context_line":"            name\u003d\"test_zone_records_boundary\", suffix\u003dself.tld_name)"},{"line_number":457,"context_line":"        zone \u003d self.zone_client.create_zone("},{"line_number":458,"context_line":"            name\u003dzone_name, project_id\u003dtenant_id)[1]"},{"line_number":459,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"eaa530d5_f5324187","line":457,"range":{"start_line":457,"start_character":20,"end_line":457,"end_character":31},"in_reply_to":"11a404e1_b36fd16d","updated":"2023-02-22 23:09:20.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":465,"context_line":"            \u0027recordset_records\u0027: 7, \u0027api_export_size\u0027: 7}"},{"line_number":466,"context_line":"        self.quota_client.set_quotas("},{"line_number":467,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":468,"context_line":"            headers\u003dsudo_header)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        # Create recordset with a single record --\u003e Should PASS"},{"line_number":471,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("}],"source_content_type":"text/x-python","patch_set":1,"id":"c4e0fb91_a0ac9f6d","line":468,"updated":"2023-02-22 22:59:06.000000000","message":"Same here, I don\u0027t think we should be setting sudo here.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4244a0039cd441fe83cb2f5733ee00dea96231ee","unresolved":false,"context_lines":[{"line_number":465,"context_line":"            \u0027recordset_records\u0027: 7, \u0027api_export_size\u0027: 7}"},{"line_number":466,"context_line":"        self.quota_client.set_quotas("},{"line_number":467,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":468,"context_line":"            headers\u003dsudo_header)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        # Create recordset with a single record --\u003e Should PASS"},{"line_number":471,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("}],"source_content_type":"text/x-python","patch_set":1,"id":"eba1aa47_e4b02146","line":468,"in_reply_to":"08a47137_8b5311b2","updated":"2023-04-16 15:04:56.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7299c83ac4387f8b6757a9f85bd7173fb244159e","unresolved":true,"context_lines":[{"line_number":465,"context_line":"            \u0027recordset_records\u0027: 7, \u0027api_export_size\u0027: 7}"},{"line_number":466,"context_line":"        self.quota_client.set_quotas("},{"line_number":467,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":468,"context_line":"            headers\u003dsudo_header)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        # Create recordset with a single record --\u003e Should PASS"},{"line_number":471,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("}],"source_content_type":"text/x-python","patch_set":1,"id":"08a47137_8b5311b2","line":468,"in_reply_to":"c4e0fb91_a0ac9f6d","updated":"2023-02-23 13:07:58.000000000","message":"Same as in L401","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":481,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":482,"context_line":"        quota_recset_zone \u003d None"},{"line_number":483,"context_line":"        try:"},{"line_number":484,"context_line":"            resp, quota_recset_zone \u003d self.recordset_client.create_recordset("},{"line_number":485,"context_line":"                zone[\u0027id\u0027], recordset_data, headers\u003dsudo_header)"},{"line_number":486,"context_line":"            self.addCleanup("},{"line_number":487,"context_line":"                self.wait_recordset_delete, self.recordset_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2fc6f769_885e38fa","line":484,"range":{"start_line":484,"start_character":18,"end_line":484,"end_character":35},"updated":"2023-02-22 22:59:06.000000000","message":"This is not a zone, we should update this variable name for clarity.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7299c83ac4387f8b6757a9f85bd7173fb244159e","unresolved":true,"context_lines":[{"line_number":481,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":482,"context_line":"        quota_recset_zone \u003d None"},{"line_number":483,"context_line":"        try:"},{"line_number":484,"context_line":"            resp, quota_recset_zone \u003d self.recordset_client.create_recordset("},{"line_number":485,"context_line":"                zone[\u0027id\u0027], recordset_data, headers\u003dsudo_header)"},{"line_number":486,"context_line":"            self.addCleanup("},{"line_number":487,"context_line":"                self.wait_recordset_delete, self.recordset_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b9f64bc3_295c84a3","line":484,"range":{"start_line":484,"start_character":18,"end_line":484,"end_character":35},"in_reply_to":"2fc6f769_885e38fa","updated":"2023-02-23 13:07:58.000000000","message":"Same as in L424","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4244a0039cd441fe83cb2f5733ee00dea96231ee","unresolved":false,"context_lines":[{"line_number":481,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":482,"context_line":"        quota_recset_zone \u003d None"},{"line_number":483,"context_line":"        try:"},{"line_number":484,"context_line":"            resp, quota_recset_zone \u003d self.recordset_client.create_recordset("},{"line_number":485,"context_line":"                zone[\u0027id\u0027], recordset_data, headers\u003dsudo_header)"},{"line_number":486,"context_line":"            self.addCleanup("},{"line_number":487,"context_line":"                self.wait_recordset_delete, self.recordset_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0196a2f2_8175f032","line":484,"range":{"start_line":484,"start_character":18,"end_line":484,"end_character":35},"in_reply_to":"b9f64bc3_295c84a3","updated":"2023-04-16 15:04:56.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":495,"context_line":"                          \u0027Failed, over_quota for a \u0027"},{"line_number":496,"context_line":"                          \u0027zone_records was not raised\u0027)"},{"line_number":497,"context_line":"        finally:"},{"line_number":498,"context_line":"            if quota_recset_zone:"},{"line_number":499,"context_line":"                self.addCleanup("},{"line_number":500,"context_line":"                    self.wait_recordset_delete,"},{"line_number":501,"context_line":"                    self.recordset_client, quota_recset_zone[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"6bf8ae76_65eebaa7","line":498,"updated":"2023-02-22 22:59:06.000000000","message":"This pattern seems a bit odd. We are adding two cleanups for the same resource.\nIt also seems like the client should either return a response or raise an exception. Catching a generic Exception seems wrong.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7299c83ac4387f8b6757a9f85bd7173fb244159e","unresolved":true,"context_lines":[{"line_number":495,"context_line":"                          \u0027Failed, over_quota for a \u0027"},{"line_number":496,"context_line":"                          \u0027zone_records was not raised\u0027)"},{"line_number":497,"context_line":"        finally:"},{"line_number":498,"context_line":"            if quota_recset_zone:"},{"line_number":499,"context_line":"                self.addCleanup("},{"line_number":500,"context_line":"                    self.wait_recordset_delete,"},{"line_number":501,"context_line":"                    self.recordset_client, quota_recset_zone[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f947db8_8a756ef8","line":498,"in_reply_to":"6bf8ae76_65eebaa7","updated":"2023-02-23 13:07:58.000000000","message":"Same as in L437","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4244a0039cd441fe83cb2f5733ee00dea96231ee","unresolved":false,"context_lines":[{"line_number":495,"context_line":"                          \u0027Failed, over_quota for a \u0027"},{"line_number":496,"context_line":"                          \u0027zone_records was not raised\u0027)"},{"line_number":497,"context_line":"        finally:"},{"line_number":498,"context_line":"            if quota_recset_zone:"},{"line_number":499,"context_line":"                self.addCleanup("},{"line_number":500,"context_line":"                    self.wait_recordset_delete,"},{"line_number":501,"context_line":"                    self.recordset_client, quota_recset_zone[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"d2179401_9b3e38c2","line":498,"in_reply_to":"7f947db8_8a756ef8","updated":"2023-04-16 15:04:56.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":518,"context_line":"            \u0027recordset_records\u0027: 1, \u0027api_export_size\u0027: 7}"},{"line_number":519,"context_line":"        self.quota_client.set_quotas("},{"line_number":520,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":521,"context_line":"            headers\u003dsudo_header)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        # Create a Zone"},{"line_number":524,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"d7a6ecd0_e72b3bc6","line":521,"updated":"2023-02-22 22:59:06.000000000","message":"Same here, I don\u0027t think we should be setting sudo here.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4244a0039cd441fe83cb2f5733ee00dea96231ee","unresolved":false,"context_lines":[{"line_number":518,"context_line":"            \u0027recordset_records\u0027: 1, \u0027api_export_size\u0027: 7}"},{"line_number":519,"context_line":"        self.quota_client.set_quotas("},{"line_number":520,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":521,"context_line":"            headers\u003dsudo_header)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        # Create a Zone"},{"line_number":524,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"48e1d126_c451332a","line":521,"in_reply_to":"9a8e9bbd_d5a0d993","updated":"2023-04-16 15:04:56.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7299c83ac4387f8b6757a9f85bd7173fb244159e","unresolved":true,"context_lines":[{"line_number":518,"context_line":"            \u0027recordset_records\u0027: 1, \u0027api_export_size\u0027: 7}"},{"line_number":519,"context_line":"        self.quota_client.set_quotas("},{"line_number":520,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":521,"context_line":"            headers\u003dsudo_header)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        # Create a Zone"},{"line_number":524,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8e9bbd_d5a0d993","line":521,"in_reply_to":"d7a6ecd0_e72b3bc6","updated":"2023-02-23 13:07:58.000000000","message":"Same as in L401","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":523,"context_line":"        # Create a Zone"},{"line_number":524,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("},{"line_number":525,"context_line":"            name\u003d\"test_recordset_records_boundary\", suffix\u003dself.tld_name)"},{"line_number":526,"context_line":"        zone \u003d self.zone_client.create_zone("},{"line_number":527,"context_line":"            name\u003dzone_name, project_id\u003dtenant_id)[1]"},{"line_number":528,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"810bade9_7cc5d675","line":526,"range":{"start_line":526,"start_character":20,"end_line":526,"end_character":31},"updated":"2023-02-22 22:59:06.000000000","message":"This will need to be updated to zones_client","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d06470c2d1ec7f738db5c3fe6a0acdded645bff","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        # Create a Zone"},{"line_number":524,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("},{"line_number":525,"context_line":"            name\u003d\"test_recordset_records_boundary\", suffix\u003dself.tld_name)"},{"line_number":526,"context_line":"        zone \u003d self.zone_client.create_zone("},{"line_number":527,"context_line":"            name\u003dzone_name, project_id\u003dtenant_id)[1]"},{"line_number":528,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"01e2252c_9bfd4e00","line":526,"range":{"start_line":526,"start_character":20,"end_line":526,"end_character":31},"in_reply_to":"810bade9_7cc5d675","updated":"2023-02-22 23:09:20.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":541,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027], number_of_records\u003d2)"},{"line_number":542,"context_line":"        quota_recset_zone \u003d None"},{"line_number":543,"context_line":"        try:"},{"line_number":544,"context_line":"            resp, quota_recset_zone \u003d self.recordset_client.create_recordset("},{"line_number":545,"context_line":"                zone[\u0027id\u0027], recordset_data, headers\u003dsudo_header)"},{"line_number":546,"context_line":"            self.addCleanup("},{"line_number":547,"context_line":"                self.wait_recordset_delete, self.recordset_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"96ddc28d_99d8223a","line":544,"range":{"start_line":544,"start_character":18,"end_line":544,"end_character":35},"updated":"2023-02-22 22:59:06.000000000","message":"This is not a zone, we should update this variable name for clarity.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4244a0039cd441fe83cb2f5733ee00dea96231ee","unresolved":false,"context_lines":[{"line_number":541,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027], number_of_records\u003d2)"},{"line_number":542,"context_line":"        quota_recset_zone \u003d None"},{"line_number":543,"context_line":"        try:"},{"line_number":544,"context_line":"            resp, quota_recset_zone \u003d self.recordset_client.create_recordset("},{"line_number":545,"context_line":"                zone[\u0027id\u0027], recordset_data, headers\u003dsudo_header)"},{"line_number":546,"context_line":"            self.addCleanup("},{"line_number":547,"context_line":"                self.wait_recordset_delete, self.recordset_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"708bb035_c2306287","line":544,"range":{"start_line":544,"start_character":18,"end_line":544,"end_character":35},"in_reply_to":"496a47e0_6a08caae","updated":"2023-04-16 15:04:56.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7299c83ac4387f8b6757a9f85bd7173fb244159e","unresolved":true,"context_lines":[{"line_number":541,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027], number_of_records\u003d2)"},{"line_number":542,"context_line":"        quota_recset_zone \u003d None"},{"line_number":543,"context_line":"        try:"},{"line_number":544,"context_line":"            resp, quota_recset_zone \u003d self.recordset_client.create_recordset("},{"line_number":545,"context_line":"                zone[\u0027id\u0027], recordset_data, headers\u003dsudo_header)"},{"line_number":546,"context_line":"            self.addCleanup("},{"line_number":547,"context_line":"                self.wait_recordset_delete, self.recordset_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"496a47e0_6a08caae","line":544,"range":{"start_line":544,"start_character":18,"end_line":544,"end_character":35},"in_reply_to":"96ddc28d_99d8223a","updated":"2023-02-23 13:07:58.000000000","message":"OK, I\u0027ll rename it to quota_recset","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":555,"context_line":"                          \u0027Failed, over_quota for a \u0027"},{"line_number":556,"context_line":"                          \u0027recordset_records was not raised\u0027)"},{"line_number":557,"context_line":"        finally:"},{"line_number":558,"context_line":"            if quota_recset_zone:"},{"line_number":559,"context_line":"                self.addCleanup("},{"line_number":560,"context_line":"                    self.wait_recordset_delete,"},{"line_number":561,"context_line":"                    self.recordset_client, quota_recset_zone[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"2e8c77c0_daa48e35","line":558,"updated":"2023-02-22 22:59:06.000000000","message":"This pattern seems a bit odd. We are adding two cleanups for the same resource.\nIt also seems like the client should either return a response or raise an exception. Catching a generic Exception seems wrong.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7299c83ac4387f8b6757a9f85bd7173fb244159e","unresolved":true,"context_lines":[{"line_number":555,"context_line":"                          \u0027Failed, over_quota for a \u0027"},{"line_number":556,"context_line":"                          \u0027recordset_records was not raised\u0027)"},{"line_number":557,"context_line":"        finally:"},{"line_number":558,"context_line":"            if quota_recset_zone:"},{"line_number":559,"context_line":"                self.addCleanup("},{"line_number":560,"context_line":"                    self.wait_recordset_delete,"},{"line_number":561,"context_line":"                    self.recordset_client, quota_recset_zone[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"501db082_1afc0c15","line":558,"in_reply_to":"2e8c77c0_daa48e35","updated":"2023-02-23 13:07:58.000000000","message":"Same as in L437","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4244a0039cd441fe83cb2f5733ee00dea96231ee","unresolved":false,"context_lines":[{"line_number":555,"context_line":"                          \u0027Failed, over_quota for a \u0027"},{"line_number":556,"context_line":"                          \u0027recordset_records was not raised\u0027)"},{"line_number":557,"context_line":"        finally:"},{"line_number":558,"context_line":"            if quota_recset_zone:"},{"line_number":559,"context_line":"                self.addCleanup("},{"line_number":560,"context_line":"                    self.wait_recordset_delete,"},{"line_number":561,"context_line":"                    self.recordset_client, quota_recset_zone[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"e538c319_a184cea7","line":558,"in_reply_to":"501db082_1afc0c15","updated":"2023-04-16 15:04:56.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":579,"context_line":"            \u0027recordset_records\u0027: 7, \u0027api_export_size\u0027: 1}"},{"line_number":580,"context_line":"        self.quota_client.set_quotas("},{"line_number":581,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":582,"context_line":"            headers\u003dsudo_header)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        # Create a Zone"},{"line_number":585,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"f5ac8769_f5dfa3c4","line":582,"updated":"2023-02-22 22:59:06.000000000","message":"Same here, I don\u0027t think we should be setting sudo here.","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4244a0039cd441fe83cb2f5733ee00dea96231ee","unresolved":false,"context_lines":[{"line_number":579,"context_line":"            \u0027recordset_records\u0027: 7, \u0027api_export_size\u0027: 1}"},{"line_number":580,"context_line":"        self.quota_client.set_quotas("},{"line_number":581,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":582,"context_line":"            headers\u003dsudo_header)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        # Create a Zone"},{"line_number":585,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"4028706a_e4e63efa","line":582,"in_reply_to":"ddad90eb_f64f85f8","updated":"2023-04-16 15:04:56.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"7299c83ac4387f8b6757a9f85bd7173fb244159e","unresolved":true,"context_lines":[{"line_number":579,"context_line":"            \u0027recordset_records\u0027: 7, \u0027api_export_size\u0027: 1}"},{"line_number":580,"context_line":"        self.quota_client.set_quotas("},{"line_number":581,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":582,"context_line":"            headers\u003dsudo_header)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        # Create a Zone"},{"line_number":585,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"ddad90eb_f64f85f8","line":582,"in_reply_to":"f5ac8769_f5dfa3c4","updated":"2023-02-23 13:07:58.000000000","message":"Same as in L401","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7bd49c70343d3e80f46b07fcae6add6a7f8090f1","unresolved":true,"context_lines":[{"line_number":584,"context_line":"        # Create a Zone"},{"line_number":585,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("},{"line_number":586,"context_line":"            name\u003d\"test_api_export_size_boundary\", suffix\u003dself.tld_name)"},{"line_number":587,"context_line":"        zone \u003d self.zone_client.create_zone("},{"line_number":588,"context_line":"            name\u003dzone_name, project_id\u003dtenant_id)[1]"},{"line_number":589,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":590,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9bf73c0a_882602f5","line":587,"range":{"start_line":587,"start_character":20,"end_line":587,"end_character":31},"updated":"2023-02-22 22:59:06.000000000","message":"This will need to be updated to zones_client","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d06470c2d1ec7f738db5c3fe6a0acdded645bff","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        # Create a Zone"},{"line_number":585,"context_line":"        zone_name \u003d dns_data_utils.rand_zone_name("},{"line_number":586,"context_line":"            name\u003d\"test_api_export_size_boundary\", suffix\u003dself.tld_name)"},{"line_number":587,"context_line":"        zone \u003d self.zone_client.create_zone("},{"line_number":588,"context_line":"            name\u003dzone_name, project_id\u003dtenant_id)[1]"},{"line_number":589,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zone_client, zone[\u0027id\u0027])"},{"line_number":590,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4317976e_259010fe","line":587,"range":{"start_line":587,"start_character":20,"end_line":587,"end_character":31},"in_reply_to":"9bf73c0a_882602f5","updated":"2023-02-22 23:09:20.000000000","message":"Done","commit_id":"43708debd53ce1f4b08bafa507d58c07048791b4"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"bae221268e5107f0c8d379a5857da1a06e746606","unresolved":true,"context_lines":[{"line_number":377,"context_line":"        # Set Quotas \"zone_recordsets:1\" for a project"},{"line_number":378,"context_line":"        sudo_header \u003d {\u0027x-auth-sudo-project-id\u0027: tenant_id}"},{"line_number":379,"context_line":"        quotas \u003d {"},{"line_number":380,"context_line":"            \u0027zones\u0027: 7, \u0027zone_recordsets\u0027: 1, \u0027zone_records\u0027: 7,"},{"line_number":381,"context_line":"            \u0027recordset_records\u0027: 7, \u0027api_export_size\u0027: 7}"},{"line_number":382,"context_line":"        self.quota_client.set_quotas("},{"line_number":383,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"}],"source_content_type":"text/x-python","patch_set":9,"id":"efa6605c_20448be7","line":380,"range":{"start_line":380,"start_character":43,"end_line":380,"end_character":44},"updated":"2025-10-24 11:38:43.000000000","message":"Remember that the zone creates SOA and NS recordsets by default","commit_id":"f4d4f4e493e7ac8c01b57e2f5500c2f7abdd23ab"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"bae221268e5107f0c8d379a5857da1a06e746606","unresolved":true,"context_lines":[{"line_number":508,"context_line":"        sudo_header \u003d {\u0027x-auth-sudo-project-id\u0027: tenant_id}"},{"line_number":509,"context_line":"        quotas \u003d {"},{"line_number":510,"context_line":"            \u0027zones\u0027: 7, \u0027zone_recordsets\u0027: 7, \u0027zone_records\u0027: 7,"},{"line_number":511,"context_line":"            \u0027recordset_records\u0027: 7, \u0027api_export_size\u0027: 1}"},{"line_number":512,"context_line":"        self.quota_client.set_quotas("},{"line_number":513,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":514,"context_line":"            headers\u003dsudo_header)"}],"source_content_type":"text/x-python","patch_set":9,"id":"b4919813_ad7752bf","line":511,"range":{"start_line":511,"start_character":55,"end_line":511,"end_character":56},"updated":"2025-10-24 11:38:43.000000000","message":"Remember that the zone creates SOA and NS recordsets by default","commit_id":"f4d4f4e493e7ac8c01b57e2f5500c2f7abdd23ab"}]}