)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8e240d3567213753a760b8f4a122f7e4f1fef23f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b9def09a_c94a4731","updated":"2022-11-01 17:04:16.000000000","message":"based on the results here https://review.opendev.org/c/openinfra/python-tempestconf/+/862818/ it seems this fix works, please remove the Work in Progress label then so it can be reviewed by designate team","commit_id":"65a5aadf128665f72d3696bb3e671ca6b857eb19"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e246d05e137c8a37c0acaaee6f882f85fbcc18e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"28070c5c_8c0c54db","updated":"2022-11-03 08:50:18.000000000","message":"This would fix an issue in python-tempestconf:\nhttps://zuul.opendev.org/t/openstack/build/61f54d3072d54b1c9bbd825d08af080a","commit_id":"6be3fa583373b66379949efe7a8c0176ea1b684f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"15abde1acc2d8a3ac1ed45e2c07c8e257676e3dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"24f26775_803d6924","updated":"2022-11-03 09:23:35.000000000","message":"more context from the IRC discussion:\n```\nfrickler\nkopecmartin: I can review that, too, although I don\u0027t know what python-tempestconf is, can you point me to the issue that you are seeing there?\n\nkopecmartin\nfrickler: thanks, it\u0027s a tool that queries a cloud and generates tempest.conf basically\n\nkopecmartin\nhttps://zuul.opendev.org/t/openstack/build/61f54d3072d54b1c9bbd825d08af080a\n\nfrickler\nkopecmartin: ah, o.k., I\u0027m trying to see why those checks fail in your deployment but not for designate. maybe amending your test environment would be a better solution\n\nkopecmartin\nit worked for you because you used tempest.conf which was generated by devstack, python-tempestconf can\u0027t discover [dns].nameservers therefore it\u0027s not set in tempest.conf and all designate tests fail, my understanding is that even tests which don\u0027t require the value fail as well\n\nkopecmartin\ni think that the whole point is not to fail in init but only when the nameservers are about to be used -\u003e https://review.opendev.org/c/openstack/designate-tempest-plugin/+/862804/8/designate_tempest_plugin/services/dns/query/query_client.py#41\n\nfrickler\no.k., thanks for the context, I\u0027ll take a deeper look at the patch later\n\nkopecmartin\nin other words , do we want to make designate-tempest-plugin users to always set the the nameservers value in tempest.conf even if they want to run designate tests which do not require that\n```","commit_id":"6be3fa583373b66379949efe7a8c0176ea1b684f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b8cd843e282a438f28030c2a61ba1f002c0b1036","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7fc9060c_cff9e798","in_reply_to":"24f26775_803d6924","updated":"2022-11-03 21:50:54.000000000","message":"Yeah, really tripleo (I think the only thing that uses python-tempestconf) testing needs to be fixed to configure this setting, otherwise you really aren\u0027t testing much. Since the designate \"service\" in tripleo deploys name servers along with it, this setting should be configured in tempest for an designate tempest runs.","commit_id":"6be3fa583373b66379949efe7a8c0176ea1b684f"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"97350f56e63eecff371ed2bcfd0c55da6f6ea1a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1be04f0b_f99a7a1a","updated":"2022-11-04 08:17:57.000000000","message":"Thanks for the review!","commit_id":"e4eef80364e1516dcb25e8b7f36d866304541db2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"087f99b3d2b250f29336df5dbf0b6b846f8d0a51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"15de8064_494bcf79","updated":"2023-01-15 21:43:47.000000000","message":"LGTM","commit_id":"4f2367f64aad61078d38c717ed67f38053802a01"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f6db1b12873ad0548a5e8a7e6d91080bff6db955","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c25da903_5d5aa64d","updated":"2023-01-10 09:16:46.000000000","message":"ping to bump this in review queue","commit_id":"4f2367f64aad61078d38c717ed67f38053802a01"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"2e2aa9908e717846cad2e3c1f434a59084a3a350","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1d228329_3cb72d54","updated":"2022-11-09 12:05:57.000000000","message":"recheck \n\nThe failure of neutron-tempest-plugin-designate-scenario seems not related to the patch. It also looks like the issue with the job is fixed now. ","commit_id":"4f2367f64aad61078d38c717ed67f38053802a01"}],"designate_tempest_plugin/services/dns/query/query_client.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b8cd843e282a438f28030c2a61ba1f002c0b1036","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def __init__(self, nameservers\u003dNone, query_timeout\u003dNone,"},{"line_number":26,"context_line":"                 build_interval\u003dNone, build_timeout\u003dNone):"},{"line_number":27,"context_line":"        self.nameservers \u003d self._nameservers_not_empty("},{"line_number":28,"context_line":"            nameservers or CONF.dns.nameservers)"},{"line_number":29,"context_line":"        self.query_timeout \u003d query_timeout or CONF.dns.query_timeout"},{"line_number":30,"context_line":"        self.build_interval \u003d build_interval or CONF.dns.build_interval"}],"source_content_type":"text/x-python","patch_set":8,"id":"2b7e9aea_638e70e1","side":"PARENT","line":27,"updated":"2022-11-03 21:50:54.000000000","message":"Fixing this is a good call, you should be able to run the API compliance tests without actual backend DNS servers.","commit_id":"e52be15f300c5cb3aae56839a55b19e5f493119b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"97350f56e63eecff371ed2bcfd0c55da6f6ea1a7","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def __init__(self, nameservers\u003dNone, query_timeout\u003dNone,"},{"line_number":26,"context_line":"                 build_interval\u003dNone, build_timeout\u003dNone):"},{"line_number":27,"context_line":"        self.nameservers \u003d self._nameservers_not_empty("},{"line_number":28,"context_line":"            nameservers or CONF.dns.nameservers)"},{"line_number":29,"context_line":"        self.query_timeout \u003d query_timeout or CONF.dns.query_timeout"},{"line_number":30,"context_line":"        self.build_interval \u003d build_interval or CONF.dns.build_interval"}],"source_content_type":"text/x-python","patch_set":8,"id":"b52a76f2_b069f24b","side":"PARENT","line":27,"in_reply_to":"2b7e9aea_638e70e1","updated":"2022-11-04 08:17:57.000000000","message":"Ack","commit_id":"e52be15f300c5cb3aae56839a55b19e5f493119b"}],"designate_tempest_plugin/tests/api/v2/test_zone_tasks.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b8cd843e282a438f28030c2a61ba1f002c0b1036","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            cls.admin_tld_client \u003d cls.os_admin.dns_v2.TldClient()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @classmethod"},{"line_number":49,"context_line":"    def skip_checks(cls):"},{"line_number":50,"context_line":"        super(BaseZonesTest, cls).skip_checks()"},{"line_number":51,"context_line":"        if not CONF.dns.nameservers:"},{"line_number":52,"context_line":"            skip_msg \u003d f\"{cls.__name__} skipped as [dns].nameservers\" \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"42ddaca1_d76dd138","line":49,"updated":"2022-11-03 21:50:54.000000000","message":"These seem overly broad, but due to the object status checks, it\u0027s true that the test will probably fail if there are no backend nameservers configured.","commit_id":"6be3fa583373b66379949efe7a8c0176ea1b684f"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"97350f56e63eecff371ed2bcfd0c55da6f6ea1a7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            cls.admin_tld_client \u003d cls.os_admin.dns_v2.TldClient()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @classmethod"},{"line_number":49,"context_line":"    def skip_checks(cls):"},{"line_number":50,"context_line":"        super(BaseZonesTest, cls).skip_checks()"},{"line_number":51,"context_line":"        if not CONF.dns.nameservers:"},{"line_number":52,"context_line":"            skip_msg \u003d f\"{cls.__name__} skipped as [dns].nameservers\" \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"29a98a38_d39e28a3","line":49,"in_reply_to":"42ddaca1_d76dd138","updated":"2022-11-04 08:17:57.000000000","message":"Ack","commit_id":"6be3fa583373b66379949efe7a8c0176ea1b684f"}],"designate_tempest_plugin/tests/scenario/v2/test_zones.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b8cd843e282a438f28030c2a61ba1f002c0b1036","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        cls.primary_client \u003d cls.os_primary.dns_v2.BlacklistsClient()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @classmethod"},{"line_number":53,"context_line":"    def skip_checks(cls):"},{"line_number":54,"context_line":"        super(ZonesTest, cls).skip_checks()"},{"line_number":55,"context_line":"        if not CONF.dns.nameservers:"},{"line_number":56,"context_line":"            skip_msg \u003d f\"{cls.__name__} skipped as [dns].nameservers\" \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f040e59_ad1193ba","line":53,"updated":"2022-11-03 21:50:54.000000000","message":"This is overly broad and will skip some non-impacted tests (test_delete_zone_pending_create for example).","commit_id":"6be3fa583373b66379949efe7a8c0176ea1b684f"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"97350f56e63eecff371ed2bcfd0c55da6f6ea1a7","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        cls.primary_client \u003d cls.os_primary.dns_v2.BlacklistsClient()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @classmethod"},{"line_number":53,"context_line":"    def skip_checks(cls):"},{"line_number":54,"context_line":"        super(ZonesTest, cls).skip_checks()"},{"line_number":55,"context_line":"        if not CONF.dns.nameservers:"},{"line_number":56,"context_line":"            skip_msg \u003d f\"{cls.__name__} skipped as [dns].nameservers\" \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"93966da3_132429e8","line":53,"in_reply_to":"1f040e59_ad1193ba","updated":"2022-11-04 08:17:57.000000000","message":"Ack","commit_id":"6be3fa583373b66379949efe7a8c0176ea1b684f"}]}