)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"387a5937f9f1881f208f6793baeb996373366863","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3b3e101a_18d48e23","updated":"2023-04-06 01:25:19.000000000","message":"ck/resignate","commit_id":"afd4e555abda29f8ba41a72ab551b1e697ed2ddd"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"8336cad728bc37eaf068ab4977d1d5b364e59be2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"530750f7_32b72be4","updated":"2023-04-07 17:09:26.000000000","message":"recheck - base designate rebase.","commit_id":"afd4e555abda29f8ba41a72ab551b1e697ed2ddd"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"1722d7f8fd00488264cd633b4da37e1aee3ca341","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fd8a6649_04992747","updated":"2023-04-12 15:36:09.000000000","message":"recheck pipeline issues","commit_id":"afd4e555abda29f8ba41a72ab551b1e697ed2ddd"}],"designate_tempest_plugin/tests/api/v2/test_multipool_zones.py":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"8e87ed95aedbb12c4917ce7a054dba4dcf2ceff0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Hewlett Packard Enterprise Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"2ad2d6af_a3813fad","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":69},"updated":"2023-02-05 15:14:50.000000000","message":"Don, it looks like this file was created by you from scratch, right?\nI didn\u0027t find \"test_multipool_zones.py\" here: \nhttps://opendev.org/openstack/designate-tempest-plugin/src/branch/master/designate_tempest_plugin/tests/api/v2\n\nSo, if I\u0027m right, then I think that it should have:\n# Copyright 2023 Red Hat.","commit_id":"396c29ab020454d7d126f269b01441e01656a32a"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"d5b3a92937b4f134a806747c0b390ccb42f85677","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Hewlett Packard Enterprise Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"47481aff_55f12e6f","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":69},"in_reply_to":"2ad2d6af_a3813fad","updated":"2023-04-06 01:10:15.000000000","message":"Yes, will include the Copyright notice line as is defined in other files, i.e. 1st line of the file.","commit_id":"396c29ab020454d7d126f269b01441e01656a32a"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"8e87ed95aedbb12c4917ce7a054dba4dcf2ceff0","unresolved":true,"context_lines":[{"line_number":30,"context_line":"class BaseMultiPoolZonesTest(base.BaseDnsV2Test):"},{"line_number":31,"context_line":"    excluded_keys \u003d [\u0027created_at\u0027, \u0027updated_at\u0027, \u0027version\u0027, \u0027links\u0027,"},{"line_number":32,"context_line":"                    \u0027status\u0027, \u0027action\u0027]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def setup_clients(cls):"},{"line_number":36,"context_line":"        super(BaseMultiPoolZonesTest, cls).setup_clients()"}],"source_content_type":"text/x-python","patch_set":1,"id":"980482e8_b2730eea","line":33,"updated":"2023-02-05 15:14:50.000000000","message":"You have to include: \ncredentials \u003d [\"admin\", \"system_admin\"]\n\n\nOtherwise (once RBAC enabled)\n[enforce_scope]\nneutron \u003d False\ndesignate \u003d True\n\nyou\u0027ll get this Error:\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nERROR: setUpClass (designate_tempest_plugin.tests.api.v2.test_multipool_zones.MultiPoolZonesTest)\n----------------------------------------------------------------------\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/tempest/test.py\", line 206, in setUpClass\n    raise value.with_traceback(trace)\n  File \"/opt/stack/tempest/tempest/test.py\", line 196, in setUpClass\n    cls.setup_clients()\n  File \"/opt/stack/designate-tempest-plugin/designate_tempest_plugin/tests/api/v2/test_multipool_zones.py\", line 67, in setup_clients\n    super(MultiPoolZonesTest, cls).setup_clients()\n  File \"/opt/stack/designate-tempest-plugin/designate_tempest_plugin/tests/api/v2/test_multipool_zones.py\", line 39, in setup_clients\n    cls.admin_tld_client \u003d cls.os_system_admin.dns_v2.TldClient()\nAttributeError: type object \u0027MultiPoolZonesTest\u0027 has no attribute \u0027os_system_admin\u0027","commit_id":"396c29ab020454d7d126f269b01441e01656a32a"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"d5b3a92937b4f134a806747c0b390ccb42f85677","unresolved":false,"context_lines":[{"line_number":30,"context_line":"class BaseMultiPoolZonesTest(base.BaseDnsV2Test):"},{"line_number":31,"context_line":"    excluded_keys \u003d [\u0027created_at\u0027, \u0027updated_at\u0027, \u0027version\u0027, \u0027links\u0027,"},{"line_number":32,"context_line":"                    \u0027status\u0027, \u0027action\u0027]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def setup_clients(cls):"},{"line_number":36,"context_line":"        super(BaseMultiPoolZonesTest, cls).setup_clients()"}],"source_content_type":"text/x-python","patch_set":1,"id":"4a2c0c5e_4783c459","line":33,"in_reply_to":"980482e8_b2730eea","updated":"2023-04-06 01:10:15.000000000","message":"Will add","commit_id":"396c29ab020454d7d126f269b01441e01656a32a"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"8e87ed95aedbb12c4917ce7a054dba4dcf2ceff0","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        LOG.info(\u0027Create a PRIMARY zone\u0027)"},{"line_number":84,"context_line":"        plist \u003d self.pool_client.list_pools()[1]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # if there are more than two it will oscillate between the pools."},{"line_number":87,"context_line":"        pool_levels \u003d [\u0027default\u0027, \u0027secondary\u0027]"},{"line_number":88,"context_line":"        osc_idx \u003d 0"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # this should create a zone in each pool, use the attribute scheduler."},{"line_number":91,"context_line":"        for pool in plist[\u0027pools\u0027]:"},{"line_number":92,"context_line":"            zone_name \u003d dns_data_utils.rand_zone_name("},{"line_number":93,"context_line":"                name\u003d\u0027create_prim_zone\u0027, suffix\u003dself.tld_name)"},{"line_number":94,"context_line":"            LOG.info(\u0027Creating zone in pool: {}\u0027.format(pool[\u0027id\u0027]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"f8824842_0026aa74","line":91,"range":{"start_line":86,"start_character":0,"end_line":91,"end_character":35},"updated":"2023-02-05 15:14:50.000000000","message":"I think that usually we have only one pool available which is a “default” pool.\nWhy not creating additional pool (or more) within the test?\nAs of now \"for\" iteration L91 is done only once for a \"default\" pool.","commit_id":"396c29ab020454d7d126f269b01441e01656a32a"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"d5b3a92937b4f134a806747c0b390ccb42f85677","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        LOG.info(\u0027Create a PRIMARY zone\u0027)"},{"line_number":84,"context_line":"        plist \u003d self.pool_client.list_pools()[1]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # if there are more than two it will oscillate between the pools."},{"line_number":87,"context_line":"        pool_levels \u003d [\u0027default\u0027, \u0027secondary\u0027]"},{"line_number":88,"context_line":"        osc_idx \u003d 0"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # this should create a zone in each pool, use the attribute scheduler."},{"line_number":91,"context_line":"        for pool in plist[\u0027pools\u0027]:"},{"line_number":92,"context_line":"            zone_name \u003d dns_data_utils.rand_zone_name("},{"line_number":93,"context_line":"                name\u003d\u0027create_prim_zone\u0027, suffix\u003dself.tld_name)"},{"line_number":94,"context_line":"            LOG.info(\u0027Creating zone in pool: {}\u0027.format(pool[\u0027id\u0027]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1039ba53_d15fca83","line":91,"range":{"start_line":86,"start_character":0,"end_line":91,"end_character":35},"in_reply_to":"f8824842_0026aa74","updated":"2023-04-06 01:10:15.000000000","message":"With the designate_tempest_plugin/config.py:L96 set it uses a pool.yaml than has multiple pools created. So with the config option set this will run else it won\u0027t.","commit_id":"396c29ab020454d7d126f269b01441e01656a32a"}]}
