)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2f72a541cfcb83d9cdb2a92d80964a8b9dc155a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"706e5ddf_857ffe8b","updated":"2023-01-25 05:58:07.000000000","message":"recheck deps updated","commit_id":"12350442ace1332df7621e123aa07653fe60fe40"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b72d8d357979cf9dd848872043ff4ae5d363692f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db28dd1e_58bf9a31","updated":"2023-01-25 15:49:54.000000000","message":"recheck unrelated error for Conflict with state of target resource","commit_id":"12350442ace1332df7621e123aa07653fe60fe40"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cec6e1662905e3ab71527e755098e6801a47778f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"940c5647_c5449be7","updated":"2023-02-23 01:16:05.000000000","message":"I the list calls don\u0027t check disallow because everyone(with a valid token) gets a response but [] if they don\u0027t have permission to see anything.\nI think we should leave member and reader on those lists as they should get a response, but it should be zero length.\nFrankly I don\u0027t like this policy, but is what was in place before.","commit_id":"0270a6bc2da4be4227126b1e8669257eb2a4d9ad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2f0f518c5e8eedb93219b1caa5887e204a5eb606","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"03bec30e_7b6f1952","updated":"2023-02-19 05:38:20.000000000","message":"recheck deps updated","commit_id":"0270a6bc2da4be4227126b1e8669257eb2a4d9ad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6f56e32e0783f7d5364aeaa593f644bdf52d53b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"07ebd297_f6a293b4","updated":"2023-02-18 22:45:49.000000000","message":"recheck deps updated","commit_id":"0270a6bc2da4be4227126b1e8669257eb2a4d9ad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0097addfaf043e09a109aaaf026785798bde6ca9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"75b46abf_10cfce28","updated":"2023-02-18 22:39:18.000000000","message":"recheck deps updated","commit_id":"0270a6bc2da4be4227126b1e8669257eb2a4d9ad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6a2e7ce5e1654e1039f84bbdf2191be1c78e59b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"91ae028f_73ffb2c0","updated":"2023-02-08 23:06:29.000000000","message":"recheck deps updated","commit_id":"0270a6bc2da4be4227126b1e8669257eb2a4d9ad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4566a659b4059cee388fa0181a5a1895880914ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"782faaa1_0bc5f45e","updated":"2023-02-03 04:18:20.000000000","message":"recheck sg error in stable xena job","commit_id":"0270a6bc2da4be4227126b1e8669257eb2a4d9ad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bf84ad44d62486290054be3f35769a4985886334","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3b3f3a1e_fe70edef","updated":"2023-02-02 17:10:34.000000000","message":"recheck sg failure in ipv6 job","commit_id":"0270a6bc2da4be4227126b1e8669257eb2a4d9ad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0800b8f58a7dd50da55491560f34e0e34d3b4f47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a28ca803_0dc835f7","updated":"2023-02-02 21:26:41.000000000","message":"recheck sg failure, not sure if that is known issue","commit_id":"0270a6bc2da4be4227126b1e8669257eb2a4d9ad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"23386a65042f5eceb479d6f29e5f0d644817c448","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8bb59d76_0b9450b4","updated":"2023-02-20 00:44:39.000000000","message":"this is ready now. SG issue has been fixed in tempest depends-on https://review.opendev.org/c/openstack/tempest/+/871018/12","commit_id":"0270a6bc2da4be4227126b1e8669257eb2a4d9ad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb4dc422f9e8ae69519b35247066427f6aebf72e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2f8580e0_0b6584fb","updated":"2023-02-23 04:59:33.000000000","message":"so test are failing due to Member has access to list of objects and it does not return [] for them \n\ntesttools.matchers._impl.MismatchError: 0 !\u003d 1: Credential os_project_member saw 2 objects when 0 was expected.\n","commit_id":"d853dbf747cead6cbbf581ea5cadb29cd4b36a22"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f540c2fb59cf418fcb3381395168c1ff0ace4bf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9ad6ccaf_8b6af34e","updated":"2023-02-23 20:02:49.000000000","message":"LGTM, Thanks!","commit_id":"ed18e74a697ea2aaa51005363e2882f8856d37dd"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e552987b9da9e4ffbee8aa7b4ac17bccd9a1d927","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1e3879bb_db89d2d5","updated":"2023-02-24 01:00:04.000000000","message":"recheck\nDependent patch is in the gate","commit_id":"ed18e74a697ea2aaa51005363e2882f8856d37dd"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"23526a51fddca7d9972fcbe4946e44c9bc11bf98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5a99db94_7e567b8b","updated":"2023-02-24 06:53:47.000000000","message":"recheck build unblocked","commit_id":"ed18e74a697ea2aaa51005363e2882f8856d37dd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2cadff506e53b8b3a02b22c3881635f4ec925f7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"deafa978_78885f04","updated":"2023-02-24 04:55:22.000000000","message":"recheck depends-on is merged","commit_id":"ed18e74a697ea2aaa51005363e2882f8856d37dd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"526c1ee95c1ee3df7fe780cbb1d91b9d0654e475","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"dc55c176_8beafe69","updated":"2023-02-23 21:39:09.000000000","message":"tempest depends-on is still in gate, we need to wait for that to merge https://review.opendev.org/c/openstack/tempest/+/871018","commit_id":"ed18e74a697ea2aaa51005363e2882f8856d37dd"}],"designate_tempest_plugin/tests/api/v2/test_transfer_request.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cec6e1662905e3ab71527e755098e6801a47778f","unresolved":true,"context_lines":[{"line_number":312,"context_line":"        #             zero zones."},{"line_number":313,"context_line":"        if CONF.dns_feature_enabled.enforce_new_defaults:"},{"line_number":314,"context_line":"            expected_allowed \u003d [\u0027os_system_admin\u0027, \u0027os_system_reader\u0027,"},{"line_number":315,"context_line":"                                \u0027os_admin\u0027, \u0027os_project_member\u0027,"},{"line_number":316,"context_line":"                                \u0027os_project_reader\u0027]"},{"line_number":317,"context_line":"        else:"},{"line_number":318,"context_line":"            expected_allowed \u003d [\u0027os_alt\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"aca7b419_e5866dad","side":"PARENT","line":315,"updated":"2023-02-23 01:16:05.000000000","message":"This isn\u0027t right, member and reader should still be able to use this API, they would just get [] back. The rule for this is ANY. So, something is off.","commit_id":"c9429994a4afeb7ee8cf82efbe543a615511a535"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8922a52230aaec7b101d9862233335983ae0d06d","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        #             zero zones."},{"line_number":313,"context_line":"        if CONF.dns_feature_enabled.enforce_new_defaults:"},{"line_number":314,"context_line":"            expected_allowed \u003d [\u0027os_system_admin\u0027, \u0027os_system_reader\u0027,"},{"line_number":315,"context_line":"                                \u0027os_admin\u0027, \u0027os_project_member\u0027,"},{"line_number":316,"context_line":"                                \u0027os_project_reader\u0027]"},{"line_number":317,"context_line":"        else:"},{"line_number":318,"context_line":"            expected_allowed \u003d [\u0027os_alt\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"a0c9e532_a71fce63","side":"PARENT","line":315,"in_reply_to":"723c43fa_84952a4b","updated":"2023-02-23 02:17:53.000000000","message":"Done","commit_id":"c9429994a4afeb7ee8cf82efbe543a615511a535"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c8553ee7db40585fd97d54e46f8976fff327b77b","unresolved":true,"context_lines":[{"line_number":312,"context_line":"        #             zero zones."},{"line_number":313,"context_line":"        if CONF.dns_feature_enabled.enforce_new_defaults:"},{"line_number":314,"context_line":"            expected_allowed \u003d [\u0027os_system_admin\u0027, \u0027os_system_reader\u0027,"},{"line_number":315,"context_line":"                                \u0027os_admin\u0027, \u0027os_project_member\u0027,"},{"line_number":316,"context_line":"                                \u0027os_project_reader\u0027]"},{"line_number":317,"context_line":"        else:"},{"line_number":318,"context_line":"            expected_allowed \u003d [\u0027os_alt\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"723c43fa_84952a4b","side":"PARENT","line":315,"in_reply_to":"aca7b419_e5866dad","updated":"2023-02-23 02:07:33.000000000","message":"ok, I do not remember why they were failing but may be I checked before tempest fix? If it is allowed for ANY then it we should check these role access also. let me revert these and check if they fail","commit_id":"c9429994a4afeb7ee8cf82efbe543a615511a535"}],"designate_tempest_plugin/tests/api/v2/test_zones.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cec6e1662905e3ab71527e755098e6801a47778f","unresolved":true,"context_lines":[{"line_number":240,"context_line":"        #             zero zones."},{"line_number":241,"context_line":"        if CONF.dns_feature_enabled.enforce_new_defaults:"},{"line_number":242,"context_line":"            expected_allowed \u003d [\u0027os_system_admin\u0027, \u0027os_system_reader\u0027,"},{"line_number":243,"context_line":"                                \u0027os_admin\u0027, \u0027os_project_member\u0027,"},{"line_number":244,"context_line":"                                \u0027os_project_reader\u0027]"},{"line_number":245,"context_line":"        else:"},{"line_number":246,"context_line":"            expected_allowed \u003d [\u0027os_alt\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"edb64d91_84b5918a","side":"PARENT","line":243,"updated":"2023-02-23 01:16:05.000000000","message":"Same here, I would expect this to cause a failure as they should be able to call this, but get [] back.","commit_id":"c9429994a4afeb7ee8cf82efbe543a615511a535"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8922a52230aaec7b101d9862233335983ae0d06d","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        #             zero zones."},{"line_number":241,"context_line":"        if CONF.dns_feature_enabled.enforce_new_defaults:"},{"line_number":242,"context_line":"            expected_allowed \u003d [\u0027os_system_admin\u0027, \u0027os_system_reader\u0027,"},{"line_number":243,"context_line":"                                \u0027os_admin\u0027, \u0027os_project_member\u0027,"},{"line_number":244,"context_line":"                                \u0027os_project_reader\u0027]"},{"line_number":245,"context_line":"        else:"},{"line_number":246,"context_line":"            expected_allowed \u003d [\u0027os_alt\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"b8c44a31_786ad989","side":"PARENT","line":243,"in_reply_to":"edb64d91_84b5918a","updated":"2023-02-23 02:17:53.000000000","message":"Done","commit_id":"c9429994a4afeb7ee8cf82efbe543a615511a535"}],"designate_tempest_plugin/tests/api/v2/test_zones_exports.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cec6e1662905e3ab71527e755098e6801a47778f","unresolved":true,"context_lines":[{"line_number":232,"context_line":"        #             zero zones."},{"line_number":233,"context_line":"        if CONF.dns_feature_enabled.enforce_new_defaults:"},{"line_number":234,"context_line":"            expected_allowed \u003d [\u0027os_system_admin\u0027, \u0027os_system_reader\u0027,"},{"line_number":235,"context_line":"                                \u0027os_admin\u0027, \u0027os_project_member\u0027,"},{"line_number":236,"context_line":"                                \u0027os_project_reader\u0027]"},{"line_number":237,"context_line":"        else:"},{"line_number":238,"context_line":"            expected_allowed \u003d [\u0027os_alt\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"7eec47aa_5e110bdf","side":"PARENT","line":235,"updated":"2023-02-23 01:16:05.000000000","message":"Same, this should still be here I think.","commit_id":"c9429994a4afeb7ee8cf82efbe543a615511a535"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8922a52230aaec7b101d9862233335983ae0d06d","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        #             zero zones."},{"line_number":233,"context_line":"        if CONF.dns_feature_enabled.enforce_new_defaults:"},{"line_number":234,"context_line":"            expected_allowed \u003d [\u0027os_system_admin\u0027, \u0027os_system_reader\u0027,"},{"line_number":235,"context_line":"                                \u0027os_admin\u0027, \u0027os_project_member\u0027,"},{"line_number":236,"context_line":"                                \u0027os_project_reader\u0027]"},{"line_number":237,"context_line":"        else:"},{"line_number":238,"context_line":"            expected_allowed \u003d [\u0027os_alt\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"ab8867a8_488303af","side":"PARENT","line":235,"in_reply_to":"7eec47aa_5e110bdf","updated":"2023-02-23 02:17:53.000000000","message":"Done","commit_id":"c9429994a4afeb7ee8cf82efbe543a615511a535"}],"designate_tempest_plugin/tests/api/v2/test_zones_imports.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cec6e1662905e3ab71527e755098e6801a47778f","unresolved":true,"context_lines":[{"line_number":236,"context_line":"        #             zero zones."},{"line_number":237,"context_line":"        if CONF.dns_feature_enabled.enforce_new_defaults:"},{"line_number":238,"context_line":"            expected_allowed \u003d [\u0027os_system_admin\u0027, \u0027os_system_reader\u0027,"},{"line_number":239,"context_line":"                                \u0027os_admin\u0027, \u0027os_project_member\u0027,"},{"line_number":240,"context_line":"                                \u0027os_project_reader\u0027]"},{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            expected_allowed \u003d [\u0027os_alt\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"be17333f_085872ef","side":"PARENT","line":239,"updated":"2023-02-23 01:16:05.000000000","message":"Same","commit_id":"c9429994a4afeb7ee8cf82efbe543a615511a535"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8922a52230aaec7b101d9862233335983ae0d06d","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        #             zero zones."},{"line_number":237,"context_line":"        if CONF.dns_feature_enabled.enforce_new_defaults:"},{"line_number":238,"context_line":"            expected_allowed \u003d [\u0027os_system_admin\u0027, \u0027os_system_reader\u0027,"},{"line_number":239,"context_line":"                                \u0027os_admin\u0027, \u0027os_project_member\u0027,"},{"line_number":240,"context_line":"                                \u0027os_project_reader\u0027]"},{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            expected_allowed \u003d [\u0027os_alt\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"14e9006f_b7bfcf5b","side":"PARENT","line":239,"in_reply_to":"be17333f_085872ef","updated":"2023-02-23 02:17:53.000000000","message":"Done","commit_id":"c9429994a4afeb7ee8cf82efbe543a615511a535"}]}