)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"75a0645306642a30aedd31f446171ca9a43effd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3fca13e7_68fcc2c9","updated":"2023-02-14 16:21:05.000000000","message":"LGTM","commit_id":"bd21c75eaad9ac11d1f309a0cee5c6d1f569d220"}],"designate_tempest_plugin/tests/scenario/v2/test_zones.py":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1e566c252da0e9c3a886bb98761962b15c6febcb","unresolved":true,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        LOG.info(\"Update Zone\u0027s TTL, wait until ACTIVE and\""},{"line_number":234,"context_line":"                 \" ensure Zone\u0027s Serial has changed\")"},{"line_number":235,"context_line":"        self.client.update_zone("},{"line_number":236,"context_line":"            zone[\u0027id\u0027], ttl\u003ddns_data_utils.rand_ttl(), wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":237,"context_line":"        new_serial \u003d self.client.show_zone(zone[\u0027id\u0027])[1][\u0027serial\u0027]"},{"line_number":238,"context_line":"        self.assertNotEqual("},{"line_number":239,"context_line":"            new_serial, org_serial,"},{"line_number":240,"context_line":"            \"Failed, expected behaviour is that the Designate DNS changes the\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5920f0ef_2d3d7137","line":237,"range":{"start_line":235,"start_character":0,"end_line":237,"end_character":67},"updated":"2023-02-07 15:21:04.000000000","message":"Hi Erik!\n\nThis fix is not so clear to me, maybe I\u0027m missing something 😞\nIt look to me that such a change is just adding one more \"show_zone\" API request to be sent, what\u0027s the purpose?\n\nThe \"update_zone\" [1] is called with \"wait_untill\u003d\u0027ACTIVE\u0027\" meaning that the \"wait_for_zone_status\" [2] will be calling \"show_zone\" API up until zone is back to ACTIVE, once done \"update_zone\" will return a tuple (In the old code this \"return\" tuple was saved in \"updated_zone\" parameter)\n\nThe \"new_serial\" value in both cases (old and new code pieces) is exactly the same value:\nnew_serial \u003d updated_zone[\u0027serial\u0027]\nor\nnew_serial \u003d self.client.show_zone(zone[\u0027id\u0027])[1][\u0027serial\u0027]\n\nSo the only difference that I see here, is that the new code sends one more \"show_zone\" API request.\n\n[1] - https://github.com/openstack/designate-tempest-plugin/blob/master/designate_tempest_plugin/services/dns/v2/json/zones_client.py#L154\n[2] - https://github.com/openstack/designate-tempest-plugin/blob/master/designate_tempest_plugin/common/waiters.py#L61\n\nThanks!","commit_id":"bd21c75eaad9ac11d1f309a0cee5c6d1f569d220"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"77abc056b857884a2f2430fe944eb09b520813ad","unresolved":true,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        LOG.info(\"Update Zone\u0027s TTL, wait until ACTIVE and\""},{"line_number":234,"context_line":"                 \" ensure Zone\u0027s Serial has changed\")"},{"line_number":235,"context_line":"        self.client.update_zone("},{"line_number":236,"context_line":"            zone[\u0027id\u0027], ttl\u003ddns_data_utils.rand_ttl(), wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":237,"context_line":"        new_serial \u003d self.client.show_zone(zone[\u0027id\u0027])[1][\u0027serial\u0027]"},{"line_number":238,"context_line":"        self.assertNotEqual("},{"line_number":239,"context_line":"            new_serial, org_serial,"},{"line_number":240,"context_line":"            \"Failed, expected behaviour is that the Designate DNS changes the\""}],"source_content_type":"text/x-python","patch_set":1,"id":"622a8445_0dcf2893","line":237,"range":{"start_line":235,"start_character":0,"end_line":237,"end_character":67},"in_reply_to":"4bd644da_b0a6c030","updated":"2023-02-07 18:19:53.000000000","message":"Wrong link\nhttps://review.opendev.org/c/openstack/designate/+/871255","commit_id":"bd21c75eaad9ac11d1f309a0cee5c6d1f569d220"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"a1703a913ac0b235fc47871eca9fe776d9dda801","unresolved":true,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        LOG.info(\"Update Zone\u0027s TTL, wait until ACTIVE and\""},{"line_number":234,"context_line":"                 \" ensure Zone\u0027s Serial has changed\")"},{"line_number":235,"context_line":"        self.client.update_zone("},{"line_number":236,"context_line":"            zone[\u0027id\u0027], ttl\u003ddns_data_utils.rand_ttl(), wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":237,"context_line":"        new_serial \u003d self.client.show_zone(zone[\u0027id\u0027])[1][\u0027serial\u0027]"},{"line_number":238,"context_line":"        self.assertNotEqual("},{"line_number":239,"context_line":"            new_serial, org_serial,"},{"line_number":240,"context_line":"            \"Failed, expected behaviour is that the Designate DNS changes the\""}],"source_content_type":"text/x-python","patch_set":1,"id":"4bd644da_b0a6c030","line":237,"range":{"start_line":235,"start_character":0,"end_line":237,"end_character":67},"in_reply_to":"5920f0ef_2d3d7137","updated":"2023-02-07 18:17:09.000000000","message":"Hey Arkady. This is to add support for batch processing of incrementing the serial. The problem is that in a world where we batch these serial updates, the first call to update_zone won\u0027t have the new serial until the zone is back in ACTIVE. We could change update_zone to fetch the zone multiple times too, but this was just an easier fix.\n\nFor reference it\u0027s for this PR here.\nhttps://review.opendev.org/c/openstack/designate-tempest-plugin/+/871266","commit_id":"bd21c75eaad9ac11d1f309a0cee5c6d1f569d220"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"eda3e55228e57eece2e97598a7761357a1ba9f44","unresolved":true,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        LOG.info(\"Update Zone\u0027s TTL, wait until ACTIVE and\""},{"line_number":234,"context_line":"                 \" ensure Zone\u0027s Serial has changed\")"},{"line_number":235,"context_line":"        self.client.update_zone("},{"line_number":236,"context_line":"            zone[\u0027id\u0027], ttl\u003ddns_data_utils.rand_ttl(), wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":237,"context_line":"        new_serial \u003d self.client.show_zone(zone[\u0027id\u0027])[1][\u0027serial\u0027]"},{"line_number":238,"context_line":"        self.assertNotEqual("},{"line_number":239,"context_line":"            new_serial, org_serial,"},{"line_number":240,"context_line":"            \"Failed, expected behaviour is that the Designate DNS changes the\""}],"source_content_type":"text/x-python","patch_set":1,"id":"852365e3_dd488ff2","line":237,"range":{"start_line":235,"start_character":0,"end_line":237,"end_character":67},"in_reply_to":"622a8445_0dcf2893","updated":"2023-02-08 10:20:02.000000000","message":"Hi Erik!\n\nOK, I got it now, thanks.\nBTW - it looks like a pretty easy change to make this fix generic:\n1) We could \"return zone\" here [1] instead of \"return\"\n2) We could then return the \"zone\" here [2] with:\nreturn waiters.wait_for_zone_status(self, body[\u0027id\u0027], wait_until)\n[1] - https://github.com/openstack/designate-tempest-plugin/blob/master/designate_tempest_plugin/common/waiters.py#L74\n[2] - https://github.com/openstack/designate-tempest-plugin/blob/master/designate_tempest_plugin/services/dns/v2/json/zones_client.py#L184\nSounds good?\n\nThanks!","commit_id":"bd21c75eaad9ac11d1f309a0cee5c6d1f569d220"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"5f9748d8ce3cd5cf6553346fb7858619200f28e8","unresolved":true,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        LOG.info(\"Update Zone\u0027s TTL, wait until ACTIVE and\""},{"line_number":234,"context_line":"                 \" ensure Zone\u0027s Serial has changed\")"},{"line_number":235,"context_line":"        self.client.update_zone("},{"line_number":236,"context_line":"            zone[\u0027id\u0027], ttl\u003ddns_data_utils.rand_ttl(), wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":237,"context_line":"        new_serial \u003d self.client.show_zone(zone[\u0027id\u0027])[1][\u0027serial\u0027]"},{"line_number":238,"context_line":"        self.assertNotEqual("},{"line_number":239,"context_line":"            new_serial, org_serial,"},{"line_number":240,"context_line":"            \"Failed, expected behaviour is that the Designate DNS changes the\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7efa7035_2ba28481","line":237,"range":{"start_line":235,"start_character":0,"end_line":237,"end_character":67},"in_reply_to":"7044e419_fe703af9","updated":"2023-02-09 10:29:13.000000000","message":"Hi Erik!\n\nYep you are right, I\u0027ve missed this.\nSorry for annoying 😊 now this fix makes sense to me.\n\nThanks!","commit_id":"bd21c75eaad9ac11d1f309a0cee5c6d1f569d220"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"fbc26bf3977eb41e98ef8a20acaee3ce691f1c97","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        LOG.info(\"Update Zone\u0027s TTL, wait until ACTIVE and\""},{"line_number":234,"context_line":"                 \" ensure Zone\u0027s Serial has changed\")"},{"line_number":235,"context_line":"        self.client.update_zone("},{"line_number":236,"context_line":"            zone[\u0027id\u0027], ttl\u003ddns_data_utils.rand_ttl(), wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":237,"context_line":"        new_serial \u003d self.client.show_zone(zone[\u0027id\u0027])[1][\u0027serial\u0027]"},{"line_number":238,"context_line":"        self.assertNotEqual("},{"line_number":239,"context_line":"            new_serial, org_serial,"},{"line_number":240,"context_line":"            \"Failed, expected behaviour is that the Designate DNS changes the\""}],"source_content_type":"text/x-python","patch_set":1,"id":"519fc65b_6b9c0407","line":237,"range":{"start_line":235,"start_character":0,"end_line":237,"end_character":67},"in_reply_to":"7efa7035_2ba28481","updated":"2023-02-09 18:11:48.000000000","message":"Don\u0027t worry, was great feedback! Thanks","commit_id":"bd21c75eaad9ac11d1f309a0cee5c6d1f569d220"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"9c614d90eb45b28861579a7d7fe6fe7b20f8c522","unresolved":true,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        LOG.info(\"Update Zone\u0027s TTL, wait until ACTIVE and\""},{"line_number":234,"context_line":"                 \" ensure Zone\u0027s Serial has changed\")"},{"line_number":235,"context_line":"        self.client.update_zone("},{"line_number":236,"context_line":"            zone[\u0027id\u0027], ttl\u003ddns_data_utils.rand_ttl(), wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":237,"context_line":"        new_serial \u003d self.client.show_zone(zone[\u0027id\u0027])[1][\u0027serial\u0027]"},{"line_number":238,"context_line":"        self.assertNotEqual("},{"line_number":239,"context_line":"            new_serial, org_serial,"},{"line_number":240,"context_line":"            \"Failed, expected behaviour is that the Designate DNS changes the\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7044e419_fe703af9","line":237,"range":{"start_line":235,"start_character":0,"end_line":237,"end_character":67},"in_reply_to":"852365e3_dd488ff2","updated":"2023-02-09 03:16:19.000000000","message":"Hey. Looking at the code the show command is a `get` request, while `update_zone` is a `patch` request. Not sure if it matters, but they technically different types of requests.","commit_id":"bd21c75eaad9ac11d1f309a0cee5c6d1f569d220"}]}