)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"186bf3e1ff93bfac78075001167f000397c727fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04a34a67_079f59f8","updated":"2023-02-07 21:58:05.000000000","message":"LGTM - see comments","commit_id":"adf6319c1cfc3ca59e109865fb6cee5d8873d155"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"950e754e08d75b4fe28b50f0129a37a83db0c131","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5c4540df_f15d5444","updated":"2023-02-10 22:21:13.000000000","message":"recheck\nPDNS\nException during message handling: socket.gaierror: [Errno -2] Name or service not known","commit_id":"adf6319c1cfc3ca59e109865fb6cee5d8873d155"}],"designate_tempest_plugin/tests/api/v2/test_enabled_api_version.py":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d6ea27211c623b88c180f433a2f7a4cb01178206","unresolved":true,"context_lines":[{"line_number":80,"context_line":"            LOG.info(\u0027Received enabled API versions for {} \u0027"},{"line_number":81,"context_line":"                     \u0027user are:{}\u0027.format(user, versions))"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            enabled_ids \u003d {item[\u0027id\u0027] for item in versions}"},{"line_number":84,"context_line":"            LOG.info(\u0027Enabled versions IDs are:{}\u0027.format(enabled_ids))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            # Expect at least one of these to be present in the API"},{"line_number":87,"context_line":"            base_versions \u003d {\u0027v1\u0027, \u0027v2\u0027, \u0027v2.0\u0027}"},{"line_number":88,"context_line":"            self.assertFalse("},{"line_number":89,"context_line":"                enabled_ids.isdisjoint(base_versions),"},{"line_number":90,"context_line":"                \u0027Failed, at least one base API version: {} was not found in \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"94e25426_191c7ffc","line":87,"range":{"start_line":83,"start_character":0,"end_line":87,"end_character":48},"updated":"2023-02-07 11:26:07.000000000","message":"It looks like in term of this test logic, we don\u0027t really need the ID of CURRENT version. API response looks like this:\n[{\u0027id\u0027: \u0027v2\u0027, \u0027links\u0027: [{\u0027href\u0027: \u0027https://127.0.0.1:60053/v2\u0027, \u0027rel\u0027: \u0027self\u0027}, {\u0027href\u0027: \u0027https://docs.openstack.org/api-ref/dns\u0027, \u0027rel\u0027: \u0027help\u0027}], \u0027status\u0027: \u0027SUPPORTED\u0027, \u0027updated\u0027: \u00272022-06-29T00:00:00Z\u0027}, {\u0027id\u0027: \u0027v2.0\u0027, \u0027links\u0027: [{\u0027href\u0027: \u0027https://127.0.0.1:60053/v2\u0027, \u0027rel\u0027: \u0027self\u0027}, {\u0027href\u0027: \u0027https://docs.openstack.org/api-ref/dns\u0027, \u0027rel\u0027: \u0027help\u0027}], \u0027status\u0027: \u0027CURRENT\u0027, \u0027updated\u0027: \u00272022-06-29T00:00:00Z\u0027}]\n\nSo instead of:\nenabled_ids \u003d {item[\u0027id\u0027] for item in versions}\nenabled_ids \u003d {item[\u0027id\u0027] for item in versions if item[\u0027status\u0027] \u003d\u003d SUPPORTED}\nand instead of:\nbase_versions \u003d {\u0027v1\u0027, \u0027v2\u0027, \u0027v2.0\u0027}\nbase_versions \u003d {\u0027v1\u0027, \u0027v2\u0027}\n\nMakes sense to you too?","commit_id":"adf6319c1cfc3ca59e109865fb6cee5d8873d155"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c49d286fcf8c76e5eb4b900bc277cd675fdcd9d5","unresolved":true,"context_lines":[{"line_number":80,"context_line":"            LOG.info(\u0027Received enabled API versions for {} \u0027"},{"line_number":81,"context_line":"                     \u0027user are:{}\u0027.format(user, versions))"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            enabled_ids \u003d {item[\u0027id\u0027] for item in versions}"},{"line_number":84,"context_line":"            LOG.info(\u0027Enabled versions IDs are:{}\u0027.format(enabled_ids))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            # Expect at least one of these to be present in the API"},{"line_number":87,"context_line":"            base_versions \u003d {\u0027v1\u0027, \u0027v2\u0027, \u0027v2.0\u0027}"},{"line_number":88,"context_line":"            self.assertFalse("},{"line_number":89,"context_line":"                enabled_ids.isdisjoint(base_versions),"},{"line_number":90,"context_line":"                \u0027Failed, at least one base API version: {} was not found in \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"6f1878d4_0b7924d4","line":87,"range":{"start_line":83,"start_character":0,"end_line":87,"end_character":48},"in_reply_to":"94e25426_191c7ffc","updated":"2023-02-07 21:59:43.000000000","message":"Current is a rolling version that changes with each new API version. This change is to make sure tempest doesn\u0027t break the version tests when a new API version is released.","commit_id":"adf6319c1cfc3ca59e109865fb6cee5d8873d155"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"186bf3e1ff93bfac78075001167f000397c727fe","unresolved":true,"context_lines":[{"line_number":80,"context_line":"            LOG.info(\u0027Received enabled API versions for {} \u0027"},{"line_number":81,"context_line":"                     \u0027user are:{}\u0027.format(user, versions))"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            enabled_ids \u003d {item[\u0027id\u0027] for item in versions}"},{"line_number":84,"context_line":"            LOG.info(\u0027Enabled versions IDs are:{}\u0027.format(enabled_ids))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            # Expect at least one of these to be present in the API"},{"line_number":87,"context_line":"            base_versions \u003d {\u0027v1\u0027, \u0027v2\u0027, \u0027v2.0\u0027}"},{"line_number":88,"context_line":"            self.assertFalse("},{"line_number":89,"context_line":"                enabled_ids.isdisjoint(base_versions),"},{"line_number":90,"context_line":"                \u0027Failed, at least one base API version: {} was not found in \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"d513ac7f_14094a7a","line":87,"range":{"start_line":83,"start_character":0,"end_line":87,"end_character":48},"in_reply_to":"94e25426_191c7ffc","updated":"2023-02-07 21:58:05.000000000","message":"I think this is true, The point is semantics. In assertFalse, you are asserting that an expression evaluates to false. If it is not, then the message is displayed and the assertion fails.\n\nThe 1st proposed change results in a failure:\n86             # Expect at least one of these to be present in the API\n 87             base_versions \u003d {\u0027v1\u0027, \u0027v2\u0027, \u0027v2.0\u0027}\n 88             # base_versions \u003d {\u0027v1\u0027, \u0027v2\u0027}                                                                 \n 89             self.assertFalse(\n 90                 enabled_ids.isdisjoint(base_versions),\n 91                 \u0027Failed, at least one base API version: {} was not found in \u0027\n\nCaptured pythonlogging:\n~~~~~~~~~~~~~~~~~~~~~~~\n    2023-02-07 21:56:30,395 718535 INFO     [tempest.lib.common.rest_client] Request (DesignateApiVersion:test_list_enabled_api_versions): 200 GET http://192.168.122.69/dns/ 0.006s\n2023-02-07 21:56:30,396 718535 DEBUG    [tempest.lib.common.rest_client] Request - Headers: {\u0027Content-Type\u0027: \u0027application/json\u0027, \u0027Accept\u0027: \u0027application/json\u0027, \u0027X-Auth-Token\u0027: \u0027\u003comitted\u003e\u0027}\n        Body: None\n    Response - Headers: {\u0027date\u0027: \u0027Tue, 07 Feb 2023 21:56:30 GMT\u0027, \u0027server\u0027: \u0027Apache/2.4.41 (Ubuntu)\u0027, \u0027content-type\u0027: \u0027application/json\u0027, \u0027content-length\u0027: \u0027393\u0027, \u0027connection\u0027: \u0027close\u0027, \u0027status\u0027: \u0027200\u0027, \u0027content-location\u0027: \u0027http://192.168.122.69/dns/\u0027}\n        Body: b\u0027{\"versions\":[{\"id\":\"v2\",\"links\":[{\"href\":\"http://127.0.0.1:60053/v2\",\"rel\":\"self\"},{\"href\":\"https://docs.openstack.org/api-ref/dns\",\"rel\":\"help\"}],\"status\":\"SUPPORTED\",\"updated\":\"2022-06-29T00:00:00Z\"},{\"id\":\"v2.0\",\"links\":[{\"href\":\"http://127.0.0.1:60053/v2\",\"rel\":\"self\"},{\"href\":\"https://docs.openstack.org/api-ref/dns\",\"rel\":\"help\"}],\"status\":\"CURRENT\",\"updated\":\"2022-06-29T00:00:00Z\"}]}\\n\u0027\n2023-02-07 21:56:30,396 718535 INFO     [designate_tempest_plugin.tests.api.v2.test_enabled_api_version] Received enabled API versions for admin user are:[{\u0027id\u0027: \u0027v2\u0027, \u0027links\u0027: [{\u0027href\u0027: \u0027http://127.0.0.1:60053/v2\u0027, \u0027rel\u0027: \u0027self\u0027}, {\u0027href\u0027: \u0027https://docs.openstack.org/api-ref/dns\u0027, \u0027rel\u0027: \u0027help\u0027}], \u0027status\u0027: \u0027SUPPORTED\u0027, \u0027updated\u0027: \u00272022-06-29T00:00:00Z\u0027}, {\u0027id\u0027: \u0027v2.0\u0027, \u0027links\u0027: [{\u0027href\u0027: \u0027http://127.0.0.1:60053/v2\u0027, \u0027rel\u0027: \u0027self\u0027}, {\u0027href\u0027: \u0027https://docs.openstack.org/api-ref/dns\u0027, \u0027rel\u0027: \u0027help\u0027}], \u0027status\u0027: \u0027CURRENT\u0027, \u0027updated\u0027: \u00272022-06-29T00:00:00Z\u0027}]\n\n\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 1 tests in 0.0081 sec.\n - Passed: 0\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 1\nSum of execute time for each test: 0.0081 sec.\n\n\n\n\n-----------------------------------------------------------------------------\nFor the second change: After running the test it success in either rendition:\n\n # Expect at least one of these to be present in the API\n 87             base_versions \u003d {\u0027v1\u0027, \u0027v2\u0027, \u0027v2.0\u0027}\n 88             base_versions \u003d {\u0027v1\u0027, \u0027v2\u0027}                                                                   \n 89             self.assertFalse(\n 90                 enabled_ids.isdisjoint(base_versions),\n 91                 \u0027Failed, at least one base API version: {} was not found in \u0027\n 92                 \u0027the API version list: {}\u0027.format(base_versions, enabled_ids))\n\n{0} designate_tempest_plugin.tests.api.v2.test_enabled_api_version.DesignateApiVersion.test_list_enabled_api_versions [0.017948s] ... ok\n\n\u003d\u003d\u003d\u003d","commit_id":"adf6319c1cfc3ca59e109865fb6cee5d8873d155"}]}