)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"a8f0bcf1cffb262f0b9052ae0d89d02102fc0c0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0cf32c74_926d41d5","updated":"2023-03-05 11:49:23.000000000","message":"recheck","commit_id":"33b4f5e3e2175db042bf12211992e3baf7263102"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"cc14956a_92cf6e03","updated":"2023-04-13 12:13:12.000000000","message":"Thanks for review Michael 👍\nI\u0027m about to upload a new patchset.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b08a8468_8d826b50","updated":"2023-04-12 22:59:37.000000000","message":"We have a few things to fix here.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"26bebcf8388872c97253d5d9ca8588dc977ecff5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"fb8b392e_e11060ad","updated":"2023-03-22 11:20:08.000000000","message":"recheck","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"a4c641946bea81d52e711476839200df6389a75f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d0defa66_364cf359","updated":"2023-03-22 15:55:33.000000000","message":"recheck\nRecheck one more time, failed gates aren\u0027t related to the changes in this particular patch.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"924af4905ab428fe3b254d2bc09fcba96b8cf833","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"501e3512_cb845442","updated":"2023-03-25 00:03:45.000000000","message":"recheck\ngrenade gate issue is resolved","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"be99133eaff3992e5b9dbdb568b4ebff9670ea3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7890656e_0fc9d639","updated":"2023-04-13 17:49:26.000000000","message":"LGTM","commit_id":"fdbe35c32f21984ba0fa4b0932f10c0f04c8675e"}],"designate_tempest_plugin/data_utils.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from tempest import config"},{"line_number":20,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import uuid"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":15,"id":"2f35838c_04d84051","line":22,"updated":"2023-04-12 22:59:37.000000000","message":"This should be up under the \"from string\" section as uuid is a python builtin.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from tempest import config"},{"line_number":20,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import uuid"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":15,"id":"966a841c_bd582f4d","line":22,"in_reply_to":"2f35838c_04d84051","updated":"2023-04-13 12:13:12.000000000","message":"Yep, I had to check Tempest\u0027s data utils first, will be removed as well as the method itself added in L298.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":295,"context_line":"    return rand_string(4) + \u0027.\u0027 + rand_string(6) + \u0027.\u0027 + domain_tld + \u0027.\u0027"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"def rand_uuid():"},{"line_number":299,"context_line":"    return str(uuid.uuid1())"}],"source_content_type":"text/x-python","patch_set":15,"id":"0261718a_3acd5a3e","line":298,"updated":"2023-04-12 22:59:37.000000000","message":"Consider using the data_utils from tempest for this:\nhttps://github.com/openstack/tempest/blob/master/tempest/lib/common/utils/data_utils.py#L24","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":295,"context_line":"    return rand_string(4) + \u0027.\u0027 + rand_string(6) + \u0027.\u0027 + domain_tld + \u0027.\u0027"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"def rand_uuid():"},{"line_number":299,"context_line":"    return str(uuid.uuid1())"}],"source_content_type":"text/x-python","patch_set":15,"id":"ee79637d_a46afcba","line":298,"in_reply_to":"0261718a_3acd5a3e","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"}],"designate_tempest_plugin/tests/api/v2/test_shared_zones.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":285,"context_line":"            name\u003dsub_zone_name)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    @decorators.idempotent_id(\u0027957ba3f8-c250-11ed-a8b1-201e8823901f\u0027)"},{"line_number":288,"context_line":"    @decorators.skip_because(bug\u003d\"2011585\")"},{"line_number":289,"context_line":"    def test_share_zone_with_yourself_is_not_allowed(self):"},{"line_number":290,"context_line":"        # It doesn\u0027t makes sense sharing your own zone with yourself."},{"line_number":291,"context_line":"        # Expected API behaviour would be not responding with 201 as"}],"source_content_type":"text/x-python","patch_set":15,"id":"96cdf0b7_80856f32","line":288,"updated":"2023-04-12 22:59:37.000000000","message":"The fix for this bug has merged, we should be able to remove this skip.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":true,"context_lines":[{"line_number":285,"context_line":"            name\u003dsub_zone_name)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    @decorators.idempotent_id(\u0027957ba3f8-c250-11ed-a8b1-201e8823901f\u0027)"},{"line_number":288,"context_line":"    @decorators.skip_because(bug\u003d\"2011585\")"},{"line_number":289,"context_line":"    def test_share_zone_with_yourself_is_not_allowed(self):"},{"line_number":290,"context_line":"        # It doesn\u0027t makes sense sharing your own zone with yourself."},{"line_number":291,"context_line":"        # Expected API behaviour would be not responding with 201 as"}],"source_content_type":"text/x-python","patch_set":15,"id":"f2280074_60386142","line":288,"in_reply_to":"96cdf0b7_80856f32","updated":"2023-04-13 12:13:12.000000000","message":"Yep, test is now PASS, \"skip\" will be removed.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    @decorators.idempotent_id(\u00272bb7bcb2-b824-11ed-9e56-201e8823901f\u0027)"},{"line_number":310,"context_line":"    @testtools.skipUnless("},{"line_number":311,"context_line":"        config.CONF.dns.nameservers is True,"},{"line_number":312,"context_line":"        \"Skip if RBAC, to avoid \u0027project_id\u0027 cannot be None failure\")"},{"line_number":313,"context_line":"    def test_create_zone_share_all_projects_header(self):"},{"line_number":314,"context_line":"        LOG.info("}],"source_content_type":"text/x-python","patch_set":15,"id":"bbb3650b_06b7afb6","line":311,"updated":"2023-04-12 22:59:37.000000000","message":"\"is True\" is not needed here, you can just use \"config.CONF.dns.nameservers\"","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":true,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    @decorators.idempotent_id(\u00272bb7bcb2-b824-11ed-9e56-201e8823901f\u0027)"},{"line_number":310,"context_line":"    @testtools.skipUnless("},{"line_number":311,"context_line":"        config.CONF.dns.nameservers is True,"},{"line_number":312,"context_line":"        \"Skip if RBAC, to avoid \u0027project_id\u0027 cannot be None failure\")"},{"line_number":313,"context_line":"    def test_create_zone_share_all_projects_header(self):"},{"line_number":314,"context_line":"        LOG.info("}],"source_content_type":"text/x-python","patch_set":15,"id":"905b455b_ee1db630","line":311,"in_reply_to":"bbb3650b_06b7afb6","updated":"2023-04-13 12:13:12.000000000","message":"I\u0027m curious why I had to include this at all 😕\nThere are no API tests based on nameservers check, I\u0027ve probably lost my concentration while coding all these new tests 😊\nThis and similar will be removed.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":309,"context_line":"    @decorators.idempotent_id(\u00272bb7bcb2-b824-11ed-9e56-201e8823901f\u0027)"},{"line_number":310,"context_line":"    @testtools.skipUnless("},{"line_number":311,"context_line":"        config.CONF.dns.nameservers is True,"},{"line_number":312,"context_line":"        \"Skip if RBAC, to avoid \u0027project_id\u0027 cannot be None failure\")"},{"line_number":313,"context_line":"    def test_create_zone_share_all_projects_header(self):"},{"line_number":314,"context_line":"        LOG.info("},{"line_number":315,"context_line":"            \u0027Admin user creates shared zone for Alt tenant\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"22de8713_a0c12a83","line":312,"updated":"2023-04-12 22:59:37.000000000","message":"This comment doesn\u0027t seem to go with the skip condition.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    @decorators.idempotent_id(\u00272bb7bcb2-b824-11ed-9e56-201e8823901f\u0027)"},{"line_number":310,"context_line":"    @testtools.skipUnless("},{"line_number":311,"context_line":"        config.CONF.dns.nameservers is True,"},{"line_number":312,"context_line":"        \"Skip if RBAC, to avoid \u0027project_id\u0027 cannot be None failure\")"},{"line_number":313,"context_line":"    def test_create_zone_share_all_projects_header(self):"},{"line_number":314,"context_line":"        LOG.info("},{"line_number":315,"context_line":"            \u0027Admin user creates shared zone for Alt tenant\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba91aeaf_c44c943f","line":312,"in_reply_to":"22de8713_a0c12a83","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":314,"context_line":"        LOG.info("},{"line_number":315,"context_line":"            \u0027Admin user creates shared zone for Alt tenant\u0027"},{"line_number":316,"context_line":"            \u0027 using \"x-auth-all-projects\" header\u0027)"},{"line_number":317,"context_line":"        sudo_header \u003d self.all_projects_header"},{"line_number":318,"context_line":"        shared_zone \u003d self.adm_shr_client.create_zone_share("},{"line_number":319,"context_line":"            self.zone[\u0027id\u0027], self.alt_zone_client.project_id,"},{"line_number":320,"context_line":"            headers\u003dsudo_header)[1]"}],"source_content_type":"text/x-python","patch_set":15,"id":"bd4c724f_304603ff","line":317,"updated":"2023-04-12 22:59:37.000000000","message":"The sudo header is different than the all_projects_header.\nhttps://docs.openstack.org/api-ref/dns/dns-api-v2-index.html?expanded\u003dcreate-shared-zone-detail#id52","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":true,"context_lines":[{"line_number":314,"context_line":"        LOG.info("},{"line_number":315,"context_line":"            \u0027Admin user creates shared zone for Alt tenant\u0027"},{"line_number":316,"context_line":"            \u0027 using \"x-auth-all-projects\" header\u0027)"},{"line_number":317,"context_line":"        sudo_header \u003d self.all_projects_header"},{"line_number":318,"context_line":"        shared_zone \u003d self.adm_shr_client.create_zone_share("},{"line_number":319,"context_line":"            self.zone[\u0027id\u0027], self.alt_zone_client.project_id,"},{"line_number":320,"context_line":"            headers\u003dsudo_header)[1]"}],"source_content_type":"text/x-python","patch_set":15,"id":"23407bfc_18454c82","line":317,"in_reply_to":"bd4c724f_304603ff","updated":"2023-04-13 12:13:12.000000000","message":"OK, I\u0027ll rename \"sudo_header\" to \"all_projects_header\"","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":357,"context_line":"    @decorators.idempotent_id(\u0027ce2688e8-b90a-11ed-b4ca-201e8823901f\u0027)"},{"line_number":358,"context_line":"    @testtools.skipUnless("},{"line_number":359,"context_line":"        config.CONF.dns.nameservers is True,"},{"line_number":360,"context_line":"        \"Skip if RBAC, to avoid \u0027project_id\u0027 cannot be None failure\")"},{"line_number":361,"context_line":"    def test_show_shared_zone_all_projects_header(self):"},{"line_number":362,"context_line":"        LOG.info("},{"line_number":363,"context_line":"            \u0027Admin user creates shared zone for Alt tenant\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"6e50f490_cb510bc5","line":360,"updated":"2023-04-12 22:59:37.000000000","message":"Same two comments as above.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":357,"context_line":"    @decorators.idempotent_id(\u0027ce2688e8-b90a-11ed-b4ca-201e8823901f\u0027)"},{"line_number":358,"context_line":"    @testtools.skipUnless("},{"line_number":359,"context_line":"        config.CONF.dns.nameservers is True,"},{"line_number":360,"context_line":"        \"Skip if RBAC, to avoid \u0027project_id\u0027 cannot be None failure\")"},{"line_number":361,"context_line":"    def test_show_shared_zone_all_projects_header(self):"},{"line_number":362,"context_line":"        LOG.info("},{"line_number":363,"context_line":"            \u0027Admin user creates shared zone for Alt tenant\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"43ac19f3_733dda82","line":360,"in_reply_to":"6e50f490_cb510bc5","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":362,"context_line":"        LOG.info("},{"line_number":363,"context_line":"            \u0027Admin user creates shared zone for Alt tenant\u0027"},{"line_number":364,"context_line":"            \u0027 using \"x-auth-all-projects\" header\u0027)"},{"line_number":365,"context_line":"        sudo_header \u003d self.all_projects_header"},{"line_number":366,"context_line":"        shared_zone \u003d self.adm_shr_client.create_zone_share("},{"line_number":367,"context_line":"            self.zone[\u0027id\u0027], self.alt_zone_client.project_id,"},{"line_number":368,"context_line":"            headers\u003dsudo_header)[1]"}],"source_content_type":"text/x-python","patch_set":15,"id":"56d41b30_2b748bce","line":365,"updated":"2023-04-12 22:59:37.000000000","message":"Same here, sudo header is not the all projects header.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        LOG.info("},{"line_number":363,"context_line":"            \u0027Admin user creates shared zone for Alt tenant\u0027"},{"line_number":364,"context_line":"            \u0027 using \"x-auth-all-projects\" header\u0027)"},{"line_number":365,"context_line":"        sudo_header \u003d self.all_projects_header"},{"line_number":366,"context_line":"        shared_zone \u003d self.adm_shr_client.create_zone_share("},{"line_number":367,"context_line":"            self.zone[\u0027id\u0027], self.alt_zone_client.project_id,"},{"line_number":368,"context_line":"            headers\u003dsudo_header)[1]"}],"source_content_type":"text/x-python","patch_set":15,"id":"2280ebcc_b751f0b7","line":365,"in_reply_to":"56d41b30_2b748bce","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":400,"context_line":"    @decorators.idempotent_id(\u00272eedfd60-b90f-11ed-b4ca-201e8823901f\u0027)"},{"line_number":401,"context_line":"    @testtools.skipUnless("},{"line_number":402,"context_line":"        config.CONF.dns.nameservers is True,"},{"line_number":403,"context_line":"        \"Skip if RBAC, to avoid \u0027project_id\u0027 cannot be None failure\")"},{"line_number":404,"context_line":"    def test_list_zone_shares_all_projects_header(self):"},{"line_number":405,"context_line":"        LOG.info("},{"line_number":406,"context_line":"            \u0027Admin user creates shared zone for Alt tenant\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"5976b525_c7b9585c","line":403,"updated":"2023-04-12 22:59:37.000000000","message":"Same two comments as above.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":400,"context_line":"    @decorators.idempotent_id(\u00272eedfd60-b90f-11ed-b4ca-201e8823901f\u0027)"},{"line_number":401,"context_line":"    @testtools.skipUnless("},{"line_number":402,"context_line":"        config.CONF.dns.nameservers is True,"},{"line_number":403,"context_line":"        \"Skip if RBAC, to avoid \u0027project_id\u0027 cannot be None failure\")"},{"line_number":404,"context_line":"    def test_list_zone_shares_all_projects_header(self):"},{"line_number":405,"context_line":"        LOG.info("},{"line_number":406,"context_line":"            \u0027Admin user creates shared zone for Alt tenant\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"6457f257_9e7e803f","line":403,"in_reply_to":"5976b525_c7b9585c","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":405,"context_line":"        LOG.info("},{"line_number":406,"context_line":"            \u0027Admin user creates shared zone for Alt tenant\u0027"},{"line_number":407,"context_line":"            \u0027 using \"x-auth-all-projects\" header\u0027)"},{"line_number":408,"context_line":"        sudo_header \u003d self.all_projects_header"},{"line_number":409,"context_line":"        shared_zone \u003d self.adm_shr_client.create_zone_share("},{"line_number":410,"context_line":"            self.zone[\u0027id\u0027], self.alt_zone_client.project_id,"},{"line_number":411,"context_line":"            headers\u003dsudo_header)[1]"}],"source_content_type":"text/x-python","patch_set":15,"id":"76cbf900_f1ef0585","line":408,"updated":"2023-04-12 22:59:37.000000000","message":"Sudo header is not the same as the all projects header","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        LOG.info("},{"line_number":406,"context_line":"            \u0027Admin user creates shared zone for Alt tenant\u0027"},{"line_number":407,"context_line":"            \u0027 using \"x-auth-all-projects\" header\u0027)"},{"line_number":408,"context_line":"        sudo_header \u003d self.all_projects_header"},{"line_number":409,"context_line":"        shared_zone \u003d self.adm_shr_client.create_zone_share("},{"line_number":410,"context_line":"            self.zone[\u0027id\u0027], self.alt_zone_client.project_id,"},{"line_number":411,"context_line":"            headers\u003dsudo_header)[1]"}],"source_content_type":"text/x-python","patch_set":15,"id":"6a296088_fee640b1","line":408,"in_reply_to":"76cbf900_f1ef0585","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":408,"context_line":"        sudo_header \u003d self.all_projects_header"},{"line_number":409,"context_line":"        shared_zone \u003d self.adm_shr_client.create_zone_share("},{"line_number":410,"context_line":"            self.zone[\u0027id\u0027], self.alt_zone_client.project_id,"},{"line_number":411,"context_line":"            headers\u003dsudo_header)[1]"},{"line_number":412,"context_line":"        self.addCleanup("},{"line_number":413,"context_line":"            self.adm_shr_client.delete_zone_share, self.zone[\u0027id\u0027],"},{"line_number":414,"context_line":"            shared_zone[\u0027id\u0027], headers\u003dsudo_header)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bba85db9_25116491","line":411,"updated":"2023-04-12 22:59:37.000000000","message":"This header really isn\u0027t needed here right?","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":true,"context_lines":[{"line_number":408,"context_line":"        sudo_header \u003d self.all_projects_header"},{"line_number":409,"context_line":"        shared_zone \u003d self.adm_shr_client.create_zone_share("},{"line_number":410,"context_line":"            self.zone[\u0027id\u0027], self.alt_zone_client.project_id,"},{"line_number":411,"context_line":"            headers\u003dsudo_header)[1]"},{"line_number":412,"context_line":"        self.addCleanup("},{"line_number":413,"context_line":"            self.adm_shr_client.delete_zone_share, self.zone[\u0027id\u0027],"},{"line_number":414,"context_line":"            shared_zone[\u0027id\u0027], headers\u003dsudo_header)"}],"source_content_type":"text/x-python","patch_set":15,"id":"8f951187_58caab22","line":411,"in_reply_to":"bba85db9_25116491","updated":"2023-04-13 12:13:12.000000000","message":"OK, it\u0027s needed here as it\u0027s actually shares Primary zone with Alt.\nin base.py zone client is created for a Primary tenant:\nhttps://github.com/openstack/designate-tempest-plugin/blob/master/designate_tempest_plugin/tests/base.py#L108\nWithout using this header we\u0027ll get:\nDetails: {\u0027code\u0027: 404, \u0027type\u0027: \u0027zone_not_found\u0027, \u0027message\u0027: \u0027Could not find Zone\u0027, \u0027request_id\u0027: \u0027req-259cf1fd-046e-4dd5-be9a-2f84ae357e92\u0027}\nas expected.\nI\u0027ll edit the comment to make it more clear, by specifying that the source zone is owned by Primary.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":411,"context_line":"            headers\u003dsudo_header)[1]"},{"line_number":412,"context_line":"        self.addCleanup("},{"line_number":413,"context_line":"            self.adm_shr_client.delete_zone_share, self.zone[\u0027id\u0027],"},{"line_number":414,"context_line":"            shared_zone[\u0027id\u0027], headers\u003dsudo_header)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        LOG.info("},{"line_number":417,"context_line":"            \u0027Admin user creates shared zone for Demo tenant\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"a3d7e909_c5a2991b","line":414,"updated":"2023-04-12 22:59:37.000000000","message":"This header really isn\u0027t needed here right?","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            headers\u003dsudo_header)[1]"},{"line_number":412,"context_line":"        self.addCleanup("},{"line_number":413,"context_line":"            self.adm_shr_client.delete_zone_share, self.zone[\u0027id\u0027],"},{"line_number":414,"context_line":"            shared_zone[\u0027id\u0027], headers\u003dsudo_header)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        LOG.info("},{"line_number":417,"context_line":"            \u0027Admin user creates shared zone for Demo tenant\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"6f85da06_1679f5df","line":414,"in_reply_to":"a3d7e909_c5a2991b","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":450,"context_line":"            \u0027Admin user tries to create shared zone, using non existing \u0027"},{"line_number":451,"context_line":"            \u0027project ID id in \"x-auth-sudo-project-id\" header\u0027)"},{"line_number":452,"context_line":"        sudo_header \u003d {"},{"line_number":453,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":454,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":455,"context_line":"           lambda: self.adm_shr_client.create_zone_share("},{"line_number":456,"context_line":"               self.zone[\u0027id\u0027], self.alt_zone_client.project_id,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f90bb9c_8ff365a3","line":453,"updated":"2023-04-12 22:59:37.000000000","message":"We should probably us data_utils from tempest for this.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":450,"context_line":"            \u0027Admin user tries to create shared zone, using non existing \u0027"},{"line_number":451,"context_line":"            \u0027project ID id in \"x-auth-sudo-project-id\" header\u0027)"},{"line_number":452,"context_line":"        sudo_header \u003d {"},{"line_number":453,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":454,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":455,"context_line":"           lambda: self.adm_shr_client.create_zone_share("},{"line_number":456,"context_line":"               self.zone[\u0027id\u0027], self.alt_zone_client.project_id,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3e885225_4bf6a37d","line":453,"in_reply_to":"3f90bb9c_8ff365a3","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":452,"context_line":"        sudo_header \u003d {"},{"line_number":453,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":454,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":455,"context_line":"           lambda: self.adm_shr_client.create_zone_share("},{"line_number":456,"context_line":"               self.zone[\u0027id\u0027], self.alt_zone_client.project_id,"},{"line_number":457,"context_line":"               headers\u003dsudo_header))"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"19b599bb_f8b7c279","line":455,"updated":"2023-04-12 22:59:37.000000000","message":"lambda is not needed here. Use:\n(\u003cexception\u003e, \u003cmethod name\u003e, \u003cparam\u003e, \u003cparam\u003e, etc.)","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        sudo_header \u003d {"},{"line_number":453,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":454,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":455,"context_line":"           lambda: self.adm_shr_client.create_zone_share("},{"line_number":456,"context_line":"               self.zone[\u0027id\u0027], self.alt_zone_client.project_id,"},{"line_number":457,"context_line":"               headers\u003dsudo_header))"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"0f0901f5_beb40271","line":455,"in_reply_to":"19b599bb_f8b7c279","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":464,"context_line":"        sudo_header \u003d {"},{"line_number":465,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.alt_zone_client.project_id}"},{"line_number":466,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":467,"context_line":"           lambda: self.adm_shr_client.create_zone_share("},{"line_number":468,"context_line":"               dns_data_utils.rand_uuid(), self.alt_zone_client.project_id,"},{"line_number":469,"context_line":"               headers\u003dsudo_header))"},{"line_number":470,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ef07ea66_6272e73b","line":467,"updated":"2023-04-12 22:59:37.000000000","message":"lambda is not needed here.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        sudo_header \u003d {"},{"line_number":465,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.alt_zone_client.project_id}"},{"line_number":466,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":467,"context_line":"           lambda: self.adm_shr_client.create_zone_share("},{"line_number":468,"context_line":"               dns_data_utils.rand_uuid(), self.alt_zone_client.project_id,"},{"line_number":469,"context_line":"               headers\u003dsudo_header))"},{"line_number":470,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"a9b7cfde_a997b058","line":467,"in_reply_to":"ef07ea66_6272e73b","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":465,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.alt_zone_client.project_id}"},{"line_number":466,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":467,"context_line":"           lambda: self.adm_shr_client.create_zone_share("},{"line_number":468,"context_line":"               dns_data_utils.rand_uuid(), self.alt_zone_client.project_id,"},{"line_number":469,"context_line":"               headers\u003dsudo_header))"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    @decorators.idempotent_id(\u00279e7202ba-bd94-11ed-80f5-201e8823901f\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"87470db2_abd8f355","line":468,"updated":"2023-04-12 22:59:37.000000000","message":"We should probably us data_utils from tempest for this.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":465,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.alt_zone_client.project_id}"},{"line_number":466,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":467,"context_line":"           lambda: self.adm_shr_client.create_zone_share("},{"line_number":468,"context_line":"               dns_data_utils.rand_uuid(), self.alt_zone_client.project_id,"},{"line_number":469,"context_line":"               headers\u003dsudo_header))"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    @decorators.idempotent_id(\u00279e7202ba-bd94-11ed-80f5-201e8823901f\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"78bed8b6_2adcea23","line":468,"in_reply_to":"87470db2_abd8f355","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":475,"context_line":"        sudo_header \u003d {"},{"line_number":476,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.alt_zone_client.project_id}"},{"line_number":477,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":478,"context_line":"           lambda: self.adm_shr_client.show_zone_share("},{"line_number":479,"context_line":"               self.zone[\u0027id\u0027], dns_data_utils.rand_uuid(),"},{"line_number":480,"context_line":"               headers\u003dsudo_header))"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ae629cff_afb9866d","line":478,"updated":"2023-04-12 22:59:37.000000000","message":"lambda is not needed here.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":475,"context_line":"        sudo_header \u003d {"},{"line_number":476,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.alt_zone_client.project_id}"},{"line_number":477,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":478,"context_line":"           lambda: self.adm_shr_client.show_zone_share("},{"line_number":479,"context_line":"               self.zone[\u0027id\u0027], dns_data_utils.rand_uuid(),"},{"line_number":480,"context_line":"               headers\u003dsudo_header))"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba65d15a_a6d6fa18","line":478,"in_reply_to":"ae629cff_afb9866d","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":476,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.alt_zone_client.project_id}"},{"line_number":477,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":478,"context_line":"           lambda: self.adm_shr_client.show_zone_share("},{"line_number":479,"context_line":"               self.zone[\u0027id\u0027], dns_data_utils.rand_uuid(),"},{"line_number":480,"context_line":"               headers\u003dsudo_header))"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"    @decorators.idempotent_id(\u00278852329c-bd95-11ed-80f5-201e8823901f\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"902abcb9_c86b9f97","line":479,"updated":"2023-04-12 22:59:37.000000000","message":"We should probably us data_utils from tempest for this.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":476,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.alt_zone_client.project_id}"},{"line_number":477,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":478,"context_line":"           lambda: self.adm_shr_client.show_zone_share("},{"line_number":479,"context_line":"               self.zone[\u0027id\u0027], dns_data_utils.rand_uuid(),"},{"line_number":480,"context_line":"               headers\u003dsudo_header))"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"    @decorators.idempotent_id(\u00278852329c-bd95-11ed-80f5-201e8823901f\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"90101363_816bd657","line":479,"in_reply_to":"902abcb9_c86b9f97","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":492,"context_line":"            self.adm_shr_client.delete_zone_share, self.zone[\u0027id\u0027],"},{"line_number":493,"context_line":"            shared_zone[\u0027id\u0027], headers\u003dsudo_header)"},{"line_number":494,"context_line":"        sudo_header_invalid_project_id \u003d {"},{"line_number":495,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":496,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":497,"context_line":"           lambda: self.adm_shr_client.show_zone_share("},{"line_number":498,"context_line":"               self.zone[\u0027id\u0027], shared_zone[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":15,"id":"1b9b9d47_bcab724f","line":495,"updated":"2023-04-12 22:59:37.000000000","message":"We should probably us data_utils from tempest for this.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":492,"context_line":"            self.adm_shr_client.delete_zone_share, self.zone[\u0027id\u0027],"},{"line_number":493,"context_line":"            shared_zone[\u0027id\u0027], headers\u003dsudo_header)"},{"line_number":494,"context_line":"        sudo_header_invalid_project_id \u003d {"},{"line_number":495,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":496,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":497,"context_line":"           lambda: self.adm_shr_client.show_zone_share("},{"line_number":498,"context_line":"               self.zone[\u0027id\u0027], shared_zone[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":15,"id":"65f52b69_797af6ed","line":495,"in_reply_to":"1b9b9d47_bcab724f","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":494,"context_line":"        sudo_header_invalid_project_id \u003d {"},{"line_number":495,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":496,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":497,"context_line":"           lambda: self.adm_shr_client.show_zone_share("},{"line_number":498,"context_line":"               self.zone[\u0027id\u0027], shared_zone[\u0027id\u0027],"},{"line_number":499,"context_line":"               headers\u003dsudo_header_invalid_project_id))"},{"line_number":500,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"366e4715_70dd1ea6","line":497,"updated":"2023-04-12 22:59:37.000000000","message":"lambda is not needed here.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":494,"context_line":"        sudo_header_invalid_project_id \u003d {"},{"line_number":495,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":496,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":497,"context_line":"           lambda: self.adm_shr_client.show_zone_share("},{"line_number":498,"context_line":"               self.zone[\u0027id\u0027], shared_zone[\u0027id\u0027],"},{"line_number":499,"context_line":"               headers\u003dsudo_header_invalid_project_id))"},{"line_number":500,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"a9fcd44c_a83fa177","line":497,"in_reply_to":"366e4715_70dd1ea6","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":506,"context_line":"        sudo_header \u003d {"},{"line_number":507,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.share_zone_client.project_id}"},{"line_number":508,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":509,"context_line":"           lambda: self.adm_shr_client.list_zone_shares("},{"line_number":510,"context_line":"               dns_data_utils.rand_uuid(), headers\u003dsudo_header))"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    @decorators.idempotent_id(\u0027e71068c8-bdb1-11ed-80f5-201e8823901f\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"8980b10f_aad18579","line":509,"updated":"2023-04-12 22:59:37.000000000","message":"lambda is not needed here.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        sudo_header \u003d {"},{"line_number":507,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.share_zone_client.project_id}"},{"line_number":508,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":509,"context_line":"           lambda: self.adm_shr_client.list_zone_shares("},{"line_number":510,"context_line":"               dns_data_utils.rand_uuid(), headers\u003dsudo_header))"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    @decorators.idempotent_id(\u0027e71068c8-bdb1-11ed-80f5-201e8823901f\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"88dda307_6bea5b20","line":509,"in_reply_to":"8980b10f_aad18579","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":507,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.share_zone_client.project_id}"},{"line_number":508,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":509,"context_line":"           lambda: self.adm_shr_client.list_zone_shares("},{"line_number":510,"context_line":"               dns_data_utils.rand_uuid(), headers\u003dsudo_header))"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    @decorators.idempotent_id(\u0027e71068c8-bdb1-11ed-80f5-201e8823901f\u0027)"},{"line_number":513,"context_line":"    @ decorators.skip_because(bug\u003d\"2009819\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"3bcc586f_1b63b9a2","line":510,"updated":"2023-04-12 22:59:37.000000000","message":"We should probably us data_utils from tempest for this.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":507,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.share_zone_client.project_id}"},{"line_number":508,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":509,"context_line":"           lambda: self.adm_shr_client.list_zone_shares("},{"line_number":510,"context_line":"               dns_data_utils.rand_uuid(), headers\u003dsudo_header))"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    @decorators.idempotent_id(\u0027e71068c8-bdb1-11ed-80f5-201e8823901f\u0027)"},{"line_number":513,"context_line":"    @ decorators.skip_because(bug\u003d\"2009819\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"4a698f28_0d4be77f","line":510,"in_reply_to":"3bcc586f_1b63b9a2","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":515,"context_line":"        LOG.info(\u0027Admin user tries to list shared zone using \u0027"},{"line_number":516,"context_line":"                 \u0027not existing project ID\u0027)"},{"line_number":517,"context_line":"        sudo_header \u003d {"},{"line_number":518,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":519,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":520,"context_line":"           lambda: self.adm_shr_client.list_zone_shares("},{"line_number":521,"context_line":"               self.zone[\u0027id\u0027], headers\u003dsudo_header))"}],"source_content_type":"text/x-python","patch_set":15,"id":"68755f4a_924ce2c5","line":518,"updated":"2023-04-12 22:59:37.000000000","message":"We should probably us data_utils from tempest for this.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        LOG.info(\u0027Admin user tries to list shared zone using \u0027"},{"line_number":516,"context_line":"                 \u0027not existing project ID\u0027)"},{"line_number":517,"context_line":"        sudo_header \u003d {"},{"line_number":518,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":519,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":520,"context_line":"           lambda: self.adm_shr_client.list_zone_shares("},{"line_number":521,"context_line":"               self.zone[\u0027id\u0027], headers\u003dsudo_header))"}],"source_content_type":"text/x-python","patch_set":15,"id":"c171e569_02e31477","line":518,"in_reply_to":"68755f4a_924ce2c5","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":517,"context_line":"        sudo_header \u003d {"},{"line_number":518,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":519,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":520,"context_line":"           lambda: self.adm_shr_client.list_zone_shares("},{"line_number":521,"context_line":"               self.zone[\u0027id\u0027], headers\u003dsudo_header))"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    @decorators.idempotent_id(\u00277136b430-bdb2-11ed-80f5-201e8823901f\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"de78769d_d3a9c768","line":520,"updated":"2023-04-12 22:59:37.000000000","message":"lambda is not needed here.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":517,"context_line":"        sudo_header \u003d {"},{"line_number":518,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":519,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":520,"context_line":"           lambda: self.adm_shr_client.list_zone_shares("},{"line_number":521,"context_line":"               self.zone[\u0027id\u0027], headers\u003dsudo_header))"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    @decorators.idempotent_id(\u00277136b430-bdb2-11ed-80f5-201e8823901f\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7b3841af_a5d0f772","line":520,"in_reply_to":"de78769d_d3a9c768","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":521,"context_line":"               self.zone[\u0027id\u0027], headers\u003dsudo_header))"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    @decorators.idempotent_id(\u00277136b430-bdb2-11ed-80f5-201e8823901f\u0027)"},{"line_number":524,"context_line":"    def test_delete_zone_invalid_project_id(self):"},{"line_number":525,"context_line":"        LOG.info(\u0027Admin user creates shared zone for Alt user\u0027)"},{"line_number":526,"context_line":"        sudo_header \u003d {"},{"line_number":527,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.share_zone_client.project_id}"}],"source_content_type":"text/x-python","patch_set":15,"id":"69dc396e_866fc9c7","line":524,"range":{"start_line":524,"start_character":8,"end_line":524,"end_character":43},"updated":"2023-04-12 22:59:37.000000000","message":"test_delete_zone_share_invalid_project_id","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":521,"context_line":"               self.zone[\u0027id\u0027], headers\u003dsudo_header))"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    @decorators.idempotent_id(\u00277136b430-bdb2-11ed-80f5-201e8823901f\u0027)"},{"line_number":524,"context_line":"    def test_delete_zone_invalid_project_id(self):"},{"line_number":525,"context_line":"        LOG.info(\u0027Admin user creates shared zone for Alt user\u0027)"},{"line_number":526,"context_line":"        sudo_header \u003d {"},{"line_number":527,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.share_zone_client.project_id}"}],"source_content_type":"text/x-python","patch_set":15,"id":"7317cd54_dffc8837","line":524,"range":{"start_line":524,"start_character":8,"end_line":524,"end_character":43},"in_reply_to":"69dc396e_866fc9c7","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":535,"context_line":"        LOG.info(\u0027Admin user tries to delete the shared zone \u0027"},{"line_number":536,"context_line":"                 \u0027using non existing project ID\u0027)"},{"line_number":537,"context_line":"        invalid_sudo_header \u003d {"},{"line_number":538,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":539,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":540,"context_line":"           lambda: self.adm_shr_client.delete_zone_share("},{"line_number":541,"context_line":"               self.zone[\u0027id\u0027], shared_zone[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":15,"id":"cac9aef9_d4281cc6","line":538,"updated":"2023-04-12 22:59:37.000000000","message":"We should probably us data_utils from tempest for this.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        LOG.info(\u0027Admin user tries to delete the shared zone \u0027"},{"line_number":536,"context_line":"                 \u0027using non existing project ID\u0027)"},{"line_number":537,"context_line":"        invalid_sudo_header \u003d {"},{"line_number":538,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":539,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":540,"context_line":"           lambda: self.adm_shr_client.delete_zone_share("},{"line_number":541,"context_line":"               self.zone[\u0027id\u0027], shared_zone[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":15,"id":"a36de4d9_4d033d96","line":538,"in_reply_to":"cac9aef9_d4281cc6","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":537,"context_line":"        invalid_sudo_header \u003d {"},{"line_number":538,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":539,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":540,"context_line":"           lambda: self.adm_shr_client.delete_zone_share("},{"line_number":541,"context_line":"               self.zone[\u0027id\u0027], shared_zone[\u0027id\u0027],"},{"line_number":542,"context_line":"               headers\u003dinvalid_sudo_header))"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"21aeac7c_4f6c5a20","line":540,"updated":"2023-04-12 22:59:37.000000000","message":"lambda is not needed here.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        invalid_sudo_header \u003d {"},{"line_number":538,"context_line":"            \u0027x-auth-sudo-project-id\u0027: dns_data_utils.rand_uuid()}"},{"line_number":539,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":540,"context_line":"           lambda: self.adm_shr_client.delete_zone_share("},{"line_number":541,"context_line":"               self.zone[\u0027id\u0027], shared_zone[\u0027id\u0027],"},{"line_number":542,"context_line":"               headers\u003dinvalid_sudo_header))"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"14db28b1_7615e867","line":540,"in_reply_to":"21aeac7c_4f6c5a20","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":542,"context_line":"               headers\u003dinvalid_sudo_header))"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    @decorators.idempotent_id(\u0027d44c65e2-bdc1-11ed-80f5-201e8823901f\u0027)"},{"line_number":545,"context_line":"    def test_delete_zone_invalid_shared_zone_id(self):"},{"line_number":546,"context_line":"        LOG.info(\u0027Admin user creates shared zone for Alt user\u0027)"},{"line_number":547,"context_line":"        sudo_header \u003d {"},{"line_number":548,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.share_zone_client.project_id}"}],"source_content_type":"text/x-python","patch_set":15,"id":"55035cda_8d901da0","line":545,"range":{"start_line":545,"start_character":8,"end_line":545,"end_character":47},"updated":"2023-04-12 22:59:37.000000000","message":"test_delete_zone_share_invalide_shared_zone_id","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":542,"context_line":"               headers\u003dinvalid_sudo_header))"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    @decorators.idempotent_id(\u0027d44c65e2-bdc1-11ed-80f5-201e8823901f\u0027)"},{"line_number":545,"context_line":"    def test_delete_zone_invalid_shared_zone_id(self):"},{"line_number":546,"context_line":"        LOG.info(\u0027Admin user creates shared zone for Alt user\u0027)"},{"line_number":547,"context_line":"        sudo_header \u003d {"},{"line_number":548,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.share_zone_client.project_id}"}],"source_content_type":"text/x-python","patch_set":15,"id":"14a719b9_94554a38","line":545,"range":{"start_line":545,"start_character":8,"end_line":545,"end_character":47},"in_reply_to":"55035cda_8d901da0","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":556,"context_line":"        LOG.info(\u0027Admin user tries to delete the shared zone \u0027"},{"line_number":557,"context_line":"                 \u0027using non existing shared zone ID\u0027)"},{"line_number":558,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":559,"context_line":"           lambda: self.adm_shr_client.delete_zone_share("},{"line_number":560,"context_line":"               self.zone[\u0027id\u0027], dns_data_utils.rand_uuid(),"},{"line_number":561,"context_line":"               headers\u003dsudo_header))"},{"line_number":562,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"57392035_e1c5ec20","line":559,"updated":"2023-04-12 22:59:37.000000000","message":"lambda is not needed here.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":556,"context_line":"        LOG.info(\u0027Admin user tries to delete the shared zone \u0027"},{"line_number":557,"context_line":"                 \u0027using non existing shared zone ID\u0027)"},{"line_number":558,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":559,"context_line":"           lambda: self.adm_shr_client.delete_zone_share("},{"line_number":560,"context_line":"               self.zone[\u0027id\u0027], dns_data_utils.rand_uuid(),"},{"line_number":561,"context_line":"               headers\u003dsudo_header))"},{"line_number":562,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"48a0272e_d1fb5a80","line":559,"in_reply_to":"57392035_e1c5ec20","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":557,"context_line":"                 \u0027using non existing shared zone ID\u0027)"},{"line_number":558,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":559,"context_line":"           lambda: self.adm_shr_client.delete_zone_share("},{"line_number":560,"context_line":"               self.zone[\u0027id\u0027], dns_data_utils.rand_uuid(),"},{"line_number":561,"context_line":"               headers\u003dsudo_header))"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    @decorators.idempotent_id(\u002706de2342-bdc2-11ed-80f5-201e8823901f\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"77fe7769_d6e31b51","line":560,"updated":"2023-04-12 22:59:37.000000000","message":"We should probably us data_utils from tempest for this.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":557,"context_line":"                 \u0027using non existing shared zone ID\u0027)"},{"line_number":558,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":559,"context_line":"           lambda: self.adm_shr_client.delete_zone_share("},{"line_number":560,"context_line":"               self.zone[\u0027id\u0027], dns_data_utils.rand_uuid(),"},{"line_number":561,"context_line":"               headers\u003dsudo_header))"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    @decorators.idempotent_id(\u002706de2342-bdc2-11ed-80f5-201e8823901f\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"e7c878c0_5123543e","line":560,"in_reply_to":"77fe7769_d6e31b51","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":561,"context_line":"               headers\u003dsudo_header))"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    @decorators.idempotent_id(\u002706de2342-bdc2-11ed-80f5-201e8823901f\u0027)"},{"line_number":564,"context_line":"    def test_delete_zone_invalid_zone_id(self):"},{"line_number":565,"context_line":"        LOG.info(\u0027Admin user creates shared zone for Alt user\u0027)"},{"line_number":566,"context_line":"        sudo_header \u003d {"},{"line_number":567,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.share_zone_client.project_id}"}],"source_content_type":"text/x-python","patch_set":15,"id":"4d583a06_b0e64939","line":564,"range":{"start_line":564,"start_character":8,"end_line":564,"end_character":41},"updated":"2023-04-12 22:59:37.000000000","message":"test_delete_zone_share_invalid_zone_id","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":561,"context_line":"               headers\u003dsudo_header))"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    @decorators.idempotent_id(\u002706de2342-bdc2-11ed-80f5-201e8823901f\u0027)"},{"line_number":564,"context_line":"    def test_delete_zone_invalid_zone_id(self):"},{"line_number":565,"context_line":"        LOG.info(\u0027Admin user creates shared zone for Alt user\u0027)"},{"line_number":566,"context_line":"        sudo_header \u003d {"},{"line_number":567,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.share_zone_client.project_id}"}],"source_content_type":"text/x-python","patch_set":15,"id":"821713a4_8cec1806","line":564,"range":{"start_line":564,"start_character":8,"end_line":564,"end_character":41},"in_reply_to":"4d583a06_b0e64939","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":575,"context_line":"        LOG.info(\u0027Admin user tries to delete the shared zone \u0027"},{"line_number":576,"context_line":"                 \u0027using non zone ID\u0027)"},{"line_number":577,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":578,"context_line":"           lambda: self.adm_shr_client.delete_zone_share("},{"line_number":579,"context_line":"               dns_data_utils.rand_uuid(), shared_zone[\u0027id\u0027],"},{"line_number":580,"context_line":"               headers\u003dsudo_header))"}],"source_content_type":"text/x-python","patch_set":15,"id":"cb946ff0_92ccf601","line":578,"updated":"2023-04-12 22:59:37.000000000","message":"lambda is not needed here.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":575,"context_line":"        LOG.info(\u0027Admin user tries to delete the shared zone \u0027"},{"line_number":576,"context_line":"                 \u0027using non zone ID\u0027)"},{"line_number":577,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":578,"context_line":"           lambda: self.adm_shr_client.delete_zone_share("},{"line_number":579,"context_line":"               dns_data_utils.rand_uuid(), shared_zone[\u0027id\u0027],"},{"line_number":580,"context_line":"               headers\u003dsudo_header))"}],"source_content_type":"text/x-python","patch_set":15,"id":"1788f1d5_9524356e","line":578,"in_reply_to":"cb946ff0_92ccf601","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":576,"context_line":"                 \u0027using non zone ID\u0027)"},{"line_number":577,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":578,"context_line":"           lambda: self.adm_shr_client.delete_zone_share("},{"line_number":579,"context_line":"               dns_data_utils.rand_uuid(), shared_zone[\u0027id\u0027],"},{"line_number":580,"context_line":"               headers\u003dsudo_header))"}],"source_content_type":"text/x-python","patch_set":15,"id":"287a1be3_520d3322","line":579,"updated":"2023-04-12 22:59:37.000000000","message":"We should probably us data_utils from tempest for this.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":576,"context_line":"                 \u0027using non zone ID\u0027)"},{"line_number":577,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":578,"context_line":"           lambda: self.adm_shr_client.delete_zone_share("},{"line_number":579,"context_line":"               dns_data_utils.rand_uuid(), shared_zone[\u0027id\u0027],"},{"line_number":580,"context_line":"               headers\u003dsudo_header))"}],"source_content_type":"text/x-python","patch_set":15,"id":"dd425bb9_e19123d7","line":579,"in_reply_to":"287a1be3_520d3322","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"}],"designate_tempest_plugin/tests/api/v2/test_zones.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":252,"context_line":"        self.assertEqual(shared_zone[\u0027id\u0027], check_share[\u0027id\u0027])"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        LOG.info(\u0027Delete the zone using delete-shares\u0027)"},{"line_number":255,"context_line":"        body \u003d self.zones_client.delete_zone("},{"line_number":256,"context_line":"            zone[\u0027id\u0027], headers\u003d{\u0027x-designate-delete-shares\u0027: True})[1]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        LOG.info(\u0027Ensure we respond with DELETE+PENDING\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"338d8027_7d9fb4f3","line":255,"updated":"2023-04-12 22:59:37.000000000","message":"Since you updated the delete_zone client to have a delete_shares parameter, we should update this test to use it.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        self.assertEqual(shared_zone[\u0027id\u0027], check_share[\u0027id\u0027])"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        LOG.info(\u0027Delete the zone using delete-shares\u0027)"},{"line_number":255,"context_line":"        body \u003d self.zones_client.delete_zone("},{"line_number":256,"context_line":"            zone[\u0027id\u0027], headers\u003d{\u0027x-designate-delete-shares\u0027: True})[1]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        LOG.info(\u0027Ensure we respond with DELETE+PENDING\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"4dd40ebe_68cdd960","line":255,"in_reply_to":"338d8027_7d9fb4f3","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        LOG.info(\u0027Delete the zone using delete-shares\u0027)"},{"line_number":255,"context_line":"        body \u003d self.zones_client.delete_zone("},{"line_number":256,"context_line":"            zone[\u0027id\u0027], headers\u003d{\u0027x-designate-delete-shares\u0027: True})[1]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        LOG.info(\u0027Ensure we respond with DELETE+PENDING\u0027)"},{"line_number":259,"context_line":"        self.assertEqual(const.DELETE, body[\u0027action\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f4a5640_fe10008d","line":256,"updated":"2023-04-12 22:59:37.000000000","message":"Since you updated the delete_zone client to have a delete_shares parameter, we should update this test to use it.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        LOG.info(\u0027Delete the zone using delete-shares\u0027)"},{"line_number":255,"context_line":"        body \u003d self.zones_client.delete_zone("},{"line_number":256,"context_line":"            zone[\u0027id\u0027], headers\u003d{\u0027x-designate-delete-shares\u0027: True})[1]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        LOG.info(\u0027Ensure we respond with DELETE+PENDING\u0027)"},{"line_number":259,"context_line":"        self.assertEqual(const.DELETE, body[\u0027action\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"3fdab72d_7c037c0e","line":256,"in_reply_to":"9f4a5640_fe10008d","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":685,"context_line":"    def test_show_not_existing_zone(self):"},{"line_number":686,"context_line":"        LOG.info(\u0027Fetch non existing zone\u0027)"},{"line_number":687,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":688,"context_line":"            lambda: self.zones_client.show_zone(dns_data_utils.rand_uuid()))"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"    @decorators.idempotent_id(\u0027736e3b50-92e0-11eb-9d02-74e5f9e2a801\u0027)"},{"line_number":691,"context_line":"    def test_use_invalid_id_to_show_zone(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"a7d71e04_f358d307","line":688,"updated":"2023-04-12 22:59:37.000000000","message":"We should probably us data_utils from tempest for this.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":685,"context_line":"    def test_show_not_existing_zone(self):"},{"line_number":686,"context_line":"        LOG.info(\u0027Fetch non existing zone\u0027)"},{"line_number":687,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":688,"context_line":"            lambda: self.zones_client.show_zone(dns_data_utils.rand_uuid()))"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"    @decorators.idempotent_id(\u0027736e3b50-92e0-11eb-9d02-74e5f9e2a801\u0027)"},{"line_number":691,"context_line":"    def test_use_invalid_id_to_show_zone(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7d2cb8ec_19787ebc","line":688,"in_reply_to":"a7d71e04_f358d307","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":697,"context_line":"    def test_delete_non_existing_zone(self):"},{"line_number":698,"context_line":"        LOG.info(\u0027Delete non existing zone\u0027)"},{"line_number":699,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":700,"context_line":"            lambda: self.zones_client.delete_zone(dns_data_utils.rand_uuid()))"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    @decorators.idempotent_id(\u0027e391e30a-92e0-11eb-9d02-74e5f9e2a801\u0027)"},{"line_number":703,"context_line":"    def test_update_non_existing_zone(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"f7fa36f0_8318cd54","line":700,"updated":"2023-04-12 22:59:37.000000000","message":"We should probably us data_utils from tempest for this.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":697,"context_line":"    def test_delete_non_existing_zone(self):"},{"line_number":698,"context_line":"        LOG.info(\u0027Delete non existing zone\u0027)"},{"line_number":699,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":700,"context_line":"            lambda: self.zones_client.delete_zone(dns_data_utils.rand_uuid()))"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    @decorators.idempotent_id(\u0027e391e30a-92e0-11eb-9d02-74e5f9e2a801\u0027)"},{"line_number":703,"context_line":"    def test_update_non_existing_zone(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f96ff1a_5ab0e85b","line":700,"in_reply_to":"f7fa36f0_8318cd54","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":704,"context_line":"        LOG.info(\u0027Update non existing zone\u0027)"},{"line_number":705,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":706,"context_line":"            lambda: self.zones_client.update_zone("},{"line_number":707,"context_line":"                dns_data_utils.rand_uuid(),"},{"line_number":708,"context_line":"                description\u003ddata_utils.rand_name()))"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    @decorators.idempotent_id(\u0027925192f2-0ed8-4591-8fe7-a9fa028f90a0\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"66763df9_ff6ba3fd","line":707,"updated":"2023-04-12 22:59:37.000000000","message":"We should probably us data_utils from tempest for this.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":704,"context_line":"        LOG.info(\u0027Update non existing zone\u0027)"},{"line_number":705,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":706,"context_line":"            lambda: self.zones_client.update_zone("},{"line_number":707,"context_line":"                dns_data_utils.rand_uuid(),"},{"line_number":708,"context_line":"                description\u003ddata_utils.rand_name()))"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    @decorators.idempotent_id(\u0027925192f2-0ed8-4591-8fe7-a9fa028f90a0\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"2bf83fd8_db4e96e6","line":707,"in_reply_to":"66763df9_ff6ba3fd","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"}],"designate_tempest_plugin/tests/scenario/v2/test_quotas.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":456,"context_line":"            \u0027recordset_records\u0027: 7, \u0027api_export_size\u0027: 7}"},{"line_number":457,"context_line":"        self.adm_quota_client.set_quotas("},{"line_number":458,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":459,"context_line":"            headers\u003dsudo_header)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        # Admin creates a zone for project \"A\" and shares it Primary"},{"line_number":462,"context_line":"        zone \u003d self._create_shared_zone_for_project("}],"source_content_type":"text/x-python","patch_set":15,"id":"5fae2271_98273468","line":459,"updated":"2023-04-12 22:59:37.000000000","message":"Only a project with admin can set a quota, so this sudo should not be used here.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":true,"context_lines":[{"line_number":456,"context_line":"            \u0027recordset_records\u0027: 7, \u0027api_export_size\u0027: 7}"},{"line_number":457,"context_line":"        self.adm_quota_client.set_quotas("},{"line_number":458,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":459,"context_line":"            headers\u003dsudo_header)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        # Admin creates a zone for project \"A\" and shares it Primary"},{"line_number":462,"context_line":"        zone \u003d self._create_shared_zone_for_project("}],"source_content_type":"text/x-python","patch_set":15,"id":"3edf1d94_cd12eece","line":459,"in_reply_to":"5fae2271_98273468","updated":"2023-04-13 12:13:12.000000000","message":"It doesn\u0027t seem to be ignored, without this header API fails with:\ntempest.lib.exceptions.Forbidden: Forbidden\nDetails: {\u0027code\u0027: 403, \u0027type\u0027: \u0027forbidden\u0027, \u0027request_id\u0027: \u0027req-23259806-f28f-47de-b1cd-147c99df538c\u0027}","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":495,"context_line":"            \u0027recordset_records\u0027: 7, \u0027api_export_size\u0027: 7}"},{"line_number":496,"context_line":"        self.adm_quota_client.set_quotas("},{"line_number":497,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":498,"context_line":"            headers\u003dsudo_header)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"        # Admin creates a zone for project \"A\" and share it with Primary"},{"line_number":501,"context_line":"        zone \u003d self._create_shared_zone_for_project("}],"source_content_type":"text/x-python","patch_set":15,"id":"88a2cae1_f1530f81","line":498,"updated":"2023-04-12 22:59:37.000000000","message":"Only a project with admin can set a quota, so this sudo should not be used here. It will be ignored.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":true,"context_lines":[{"line_number":495,"context_line":"            \u0027recordset_records\u0027: 7, \u0027api_export_size\u0027: 7}"},{"line_number":496,"context_line":"        self.adm_quota_client.set_quotas("},{"line_number":497,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":498,"context_line":"            headers\u003dsudo_header)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"        # Admin creates a zone for project \"A\" and share it with Primary"},{"line_number":501,"context_line":"        zone \u003d self._create_shared_zone_for_project("}],"source_content_type":"text/x-python","patch_set":15,"id":"97f1bc1f_a4cbd294","line":498,"in_reply_to":"88a2cae1_f1530f81","updated":"2023-04-13 12:13:12.000000000","message":"It doesn\u0027t seem to be ignored, without this header API fails with:\ntempest.lib.exceptions.Forbidden: Forbidden\nDetails: {\u0027code\u0027: 403, \u0027type\u0027: \u0027forbidden\u0027, \u0027request_id\u0027: \u0027req-23259806-f28f-47de-b1cd-147c99df538c\u0027}","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":536,"context_line":"            \u0027recordset_records\u0027: 1, \u0027api_export_size\u0027: 7}"},{"line_number":537,"context_line":"        self.adm_quota_client.set_quotas("},{"line_number":538,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":539,"context_line":"            headers\u003dsudo_header)"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        # Admin creates a zone for project \"A\" and share it with Primary"},{"line_number":542,"context_line":"        zone \u003d self._create_shared_zone_for_project("}],"source_content_type":"text/x-python","patch_set":15,"id":"84c2b1c0_9b0001fb","line":539,"updated":"2023-04-12 22:59:37.000000000","message":"Only a project with admin can set a quota, so this sudo should not be used here. It will be ignored.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":true,"context_lines":[{"line_number":536,"context_line":"            \u0027recordset_records\u0027: 1, \u0027api_export_size\u0027: 7}"},{"line_number":537,"context_line":"        self.adm_quota_client.set_quotas("},{"line_number":538,"context_line":"            project_id\u003dtenant_id, quotas\u003dquotas,"},{"line_number":539,"context_line":"            headers\u003dsudo_header)"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        # Admin creates a zone for project \"A\" and share it with Primary"},{"line_number":542,"context_line":"        zone \u003d self._create_shared_zone_for_project("}],"source_content_type":"text/x-python","patch_set":15,"id":"e0719ab2_3b63e26d","line":539,"in_reply_to":"84c2b1c0_9b0001fb","updated":"2023-04-13 12:13:12.000000000","message":"It doesn\u0027t seem to be ignored, without this header API fails with:\ntempest.lib.exceptions.Forbidden: Forbidden\nDetails: {\u0027code\u0027: 403, \u0027type\u0027: \u0027forbidden\u0027, \u0027request_id\u0027: \u0027req-23259806-f28f-47de-b1cd-147c99df538c\u0027}","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"}],"designate_tempest_plugin/tests/scenario/v2/test_shared_zones.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":214,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zones_client, zone[\u0027id\u0027],"},{"line_number":215,"context_line":"                        ignore_errors\u003dlib_exc.NotFound)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        # Generate recordset data rto be used latter in the test"},{"line_number":218,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":219,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fe0a6d19_6bf1e506","line":217,"range":{"start_line":217,"start_character":34,"end_line":217,"end_character":37},"updated":"2023-04-12 22:59:37.000000000","message":"to","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        self.addCleanup(self.wait_zone_delete, self.zones_client, zone[\u0027id\u0027],"},{"line_number":215,"context_line":"                        ignore_errors\u003dlib_exc.NotFound)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        # Generate recordset data rto be used latter in the test"},{"line_number":218,"context_line":"        recordset_data \u003d dns_data_utils.rand_recordset_data("},{"line_number":219,"context_line":"            record_type\u003d\u0027A\u0027, zone_name\u003dzone[\u0027name\u0027])"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"27531b21_2a19ecf7","line":217,"range":{"start_line":217,"start_character":34,"end_line":217,"end_character":37},"in_reply_to":"fe0a6d19_6bf1e506","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        # Admin creates shared zone for Alt using \"x-auth-sudo-project-id\""},{"line_number":227,"context_line":"        sudo_header \u003d {"},{"line_number":228,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.share_zone_client.project_id}"},{"line_number":229,"context_line":"        shared_zone \u003d self.adm_shr_client.create_zone_share("},{"line_number":230,"context_line":"            zone[\u0027id\u0027], self.alt_rec_client.project_id,"},{"line_number":231,"context_line":"            headers\u003dsudo_header)[1]"}],"source_content_type":"text/x-python","patch_set":15,"id":"7605088f_620e7935","line":228,"updated":"2023-04-12 22:59:37.000000000","message":"We should probably use:\nself.zones_client.project_id here as that is the project the zone was created with. Even though both zones_client and share_zone_client are using the \"primary\" project, it\u0027s confusing to mix the clients here.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        # Admin creates shared zone for Alt using \"x-auth-sudo-project-id\""},{"line_number":227,"context_line":"        sudo_header \u003d {"},{"line_number":228,"context_line":"            \u0027x-auth-sudo-project-id\u0027: self.share_zone_client.project_id}"},{"line_number":229,"context_line":"        shared_zone \u003d self.adm_shr_client.create_zone_share("},{"line_number":230,"context_line":"            zone[\u0027id\u0027], self.alt_rec_client.project_id,"},{"line_number":231,"context_line":"            headers\u003dsudo_header)[1]"}],"source_content_type":"text/x-python","patch_set":15,"id":"0a49ab87_89fb5750","line":228,"in_reply_to":"7605088f_620e7935","updated":"2023-04-13 12:13:12.000000000","message":"Done","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":391,"context_line":"    @decorators.idempotent_id(\u0027cac8ea8e-c33b-11ed-a033-201e8823901f\u0027)"},{"line_number":392,"context_line":"    def test_alt_delete_shared_zone_export(self):"},{"line_number":393,"context_line":"        # Primary creates Zone and shares it with Alt"},{"line_number":394,"context_line":"        zone \u003d self._create_shared_zone("},{"line_number":395,"context_line":"            \u0027test_alt_delete_shared_zone_export\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":15,"id":"da4fb014_92181bda","line":392,"updated":"2023-04-12 22:59:37.000000000","message":"This says \"delete\", but the test tries to create a zone export (which is duplicate to the test above).","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":true,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":391,"context_line":"    @decorators.idempotent_id(\u0027cac8ea8e-c33b-11ed-a033-201e8823901f\u0027)"},{"line_number":392,"context_line":"    def test_alt_delete_shared_zone_export(self):"},{"line_number":393,"context_line":"        # Primary creates Zone and shares it with Alt"},{"line_number":394,"context_line":"        zone \u003d self._create_shared_zone("},{"line_number":395,"context_line":"            \u0027test_alt_delete_shared_zone_export\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":15,"id":"04900404_7eebcb13","line":392,"in_reply_to":"da4fb014_92181bda","updated":"2023-04-13 12:13:12.000000000","message":"Yep, it had to be \"delete\" here.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7eb8a8d33838cdbde9107b7948826da73f4a18ed","unresolved":true,"context_lines":[{"line_number":405,"context_line":"            \u0027test_alt_show_exported_zonefile_for_shared_zone\u0027)[0]"},{"line_number":406,"context_line":"        self.assertRaises("},{"line_number":407,"context_line":"            lib_exc.NotFound,"},{"line_number":408,"context_line":"            self.alt_export_client.show_exported_zonefile, zone[\u0027id\u0027])"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":411,"context_line":"    @decorators.idempotent_id(\u0027089136f2-c3e4-11ed-a102-201e8823901f\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"514946a5_7becfb3c","line":408,"updated":"2023-04-12 22:59:37.000000000","message":"This test never creates a zone export, so the test is invalid.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4c96badafa5ac8bbb4d1b09552487110f7bb13bd","unresolved":true,"context_lines":[{"line_number":405,"context_line":"            \u0027test_alt_show_exported_zonefile_for_shared_zone\u0027)[0]"},{"line_number":406,"context_line":"        self.assertRaises("},{"line_number":407,"context_line":"            lib_exc.NotFound,"},{"line_number":408,"context_line":"            self.alt_export_client.show_exported_zonefile, zone[\u0027id\u0027])"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":411,"context_line":"    @decorators.idempotent_id(\u0027089136f2-c3e4-11ed-a102-201e8823901f\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"b91d8a26_0336d0e9","line":408,"in_reply_to":"514946a5_7becfb3c","updated":"2023-04-13 12:13:12.000000000","message":"That\u0027s correct, the point here was to ensure that perhaps it does create zonefile for some reason, in spite of the fact that such an API is supposed to be forbidden for Alt as this tenant is not zone\u0027s owner.\nI\u0027ll rename the test name accordingly.","commit_id":"5d6aaea210832b5d67a4495a4c5a1ff5d498e031"}]}
