)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0c1d060b49ed460ab4b8cb1f2cf18b8482b73034","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e240a755_119f4b2b","updated":"2023-04-18 14:34:40.000000000","message":"Arkady, yes, DDT will need to eventually be removed from Designate. It defeats the purpose of the idempotent ID being unique per test[1]. This causes problems with refstack testing, etc. We have already unrolled some of the tests[2], this is just continuing that work while fixing a false pass bug.\n\n[1] https://docs.openstack.org/tempest/latest/HACKING.html#test-identification-with-idempotent-id\n[2] https://review.opendev.org/c/openstack/designate-tempest-plugin/+/814497","commit_id":"a5ba980ef4840a13032098bc583d556bbdef2b94"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"64fe7f7238373499bbd4803401dc0c666e986061","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"43285280_3dac127f","updated":"2023-04-18 14:56:56.000000000","message":"Hi Michael!\n\nOK, some works needs to be done to remove ddt from Designate 😞\nI\u0027ll also take a part in that stuff, will check it out soon.\n\nThanks!","commit_id":"a5ba980ef4840a13032098bc583d556bbdef2b94"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"b4a41884cffdc493d567c053d19fb102ee537d71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7e26d5b8_6ca79004","updated":"2023-04-18 10:43:01.000000000","message":"Hi Michael!\n  \nThe \"test_update_records_propagated_to_backends\" in its current manner is testing the exactly a SAME LOGIC for various record types provided by ddt module, so what is wrong in having a single idempotent ID for all? 😕\n\nIn case of failure we could just improve the Error message logged by adding the type in: https://review.opendev.org/c/openstack/designate-tempest-plugin/+/880681/2/designate_tempest_plugin/tests/scenario/v2/test_recordsets.py#b168\nSuch an \"ddt unrolling\" increases the numbers of code lines and I\u0027m not sure it worth.\n\nBTW we have a similar implementation in other places, for example:\nhttps://review.opendev.org/c/openstack/designate-tempest-plugin/+/880681/2/designate_tempest_plugin/tests/scenario/v2/test_recordsets.py#86\nAlso some APIs test doing the same.\n\nThanks!","commit_id":"a5ba980ef4840a13032098bc583d556bbdef2b94"}]}