)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"65ff9b631361a723b5b60e3b665937f938d8cffa","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-06-13 19:06:10 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Designate] IPv6 detection check added"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have test that check detection to IPv4"},{"line_number":10,"context_line":"and we need to detcet also IPv6."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6ee56fcc1f00bc55012bcd1895bddce5acfa07d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e7994619_10f12b2a","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":32},"updated":"2023-06-20 09:56:28.000000000","message":"I\u0027d suggest giving a bit more clear details on that, could be something like:\n\n\nThe current code assumes that the nameserver value configured in tempest.conf is one of these two options only: IPV4 or IPV4:PORT\nThere is no handling for IPV6 addresses, (If IPV6 is set it causes traceback). This patch adds support for IPV6.","commit_id":"c125237336d093e2651c431986037b66aebb218c"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"8b19f0a39330d4909c51ad6279ac1a5b445e034a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-06-13 19:06:10 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Designate] IPv6 detection check added"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have test that check detection to IPv4"},{"line_number":10,"context_line":"and we need to detcet also IPv6."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6ee56fcc1f00bc55012bcd1895bddce5acfa07d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"db43ea42_8d9c45e5","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":32},"in_reply_to":"e7994619_10f12b2a","updated":"2023-06-26 11:08:58.000000000","message":"Done","commit_id":"c125237336d093e2651c431986037b66aebb218c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6a0c98a577abee65217f04224286d2e5aa45c27a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f453cfc6_719d535f","updated":"2023-07-21 22:21:16.000000000","message":"LGTM","commit_id":"9b0cec95fa2a6ad06147a479186c5edb9f157e42"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"7acb0715550f30c727553240a7a6aca40faedcfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"28eefcd6_bb0b33a7","updated":"2023-07-20 09:46:51.000000000","message":"Nice!","commit_id":"9b0cec95fa2a6ad06147a479186c5edb9f157e42"}],"designate_tempest_plugin/services/dns/query/query_client.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6bfcdf8a452e1b34d4b6016e23d4dd8d7764b510","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def from_str(self, nameserver):"},{"line_number":82,"context_line":"        ip \u003d ipaddress.ip_address(nameserver)"},{"line_number":83,"context_line":"        if ip.version \u003d\u003d 4:"},{"line_number":84,"context_line":"            if \u0027:\u0027 in nameserver:"},{"line_number":85,"context_line":"                ip, port \u003d nameserver.rsplit(\u0027:\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d05cf3ec_99cd989f","line":82,"updated":"2023-06-14 18:32:01.000000000","message":"This does not take into account the possibility of an port in the \"nameserver\"string. I think there needs to be some try blocks here to narrow down if it has a port or not.","commit_id":"c125237336d093e2651c431986037b66aebb218c"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"8b19f0a39330d4909c51ad6279ac1a5b445e034a","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def from_str(self, nameserver):"},{"line_number":82,"context_line":"        ip \u003d ipaddress.ip_address(nameserver)"},{"line_number":83,"context_line":"        if ip.version \u003d\u003d 4:"},{"line_number":84,"context_line":"            if \u0027:\u0027 in nameserver:"},{"line_number":85,"context_line":"                ip, port \u003d nameserver.rsplit(\u0027:\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"77d4dfb2_1b02a33a","line":82,"in_reply_to":"d05cf3ec_99cd989f","updated":"2023-06-26 11:08:58.000000000","message":"Done","commit_id":"c125237336d093e2651c431986037b66aebb218c"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d2c9fe4900274eabceb6a0f718a8ec57d89ab174","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def check_if_IPv6_have_a_port(nameserver):"},{"line_number":69,"context_line":"    if \u0027]:\u0027 in nameserver:"},{"line_number":70,"context_line":"        ip, port \u003d nameserver[1:-1].rsplit(\u0027]:\u0027, 1)"},{"line_number":71,"context_line":"        ip_type \u003d ipaddress.ip_address(ip).version"},{"line_number":72,"context_line":"        return ip_type, ip, int(port)"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a853a2f8_c451bfd1","line":70,"updated":"2023-06-26 17:23:27.000000000","message":"You don\u0027t have to use negative index here, I mean -1.\nBecause port exported from IPV6 address this way will be just 5 (instead of 53)\nUse simply (\"till the end of the string\"), it means:\nip, port \u003d nameserver[1:].rsplit(\u0027]:\u0027, 1)","commit_id":"286b4bc9fb9f0b1bf7cf0116e1cf003f2c3258c1"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"99b4729e394707247a184009bc14f91c2814a915","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def check_if_IPv6_have_a_port(nameserver):"},{"line_number":69,"context_line":"    if \u0027]:\u0027 in nameserver:"},{"line_number":70,"context_line":"        ip, port \u003d nameserver[1:-1].rsplit(\u0027]:\u0027, 1)"},{"line_number":71,"context_line":"        ip_type \u003d ipaddress.ip_address(ip).version"},{"line_number":72,"context_line":"        return ip_type, ip, int(port)"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"aaa03ddc_f7b40e98","line":70,"in_reply_to":"a853a2f8_c451bfd1","updated":"2023-06-28 11:58:01.000000000","message":"Done","commit_id":"286b4bc9fb9f0b1bf7cf0116e1cf003f2c3258c1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"fc236a1887c19a08d253dddec88292962b73c2ec","unresolved":true,"context_lines":[{"line_number":115,"context_line":"        ]"},{"line_number":116,"context_line":"        for test in tests_list:"},{"line_number":117,"context_line":"            try:"},{"line_number":118,"context_line":"                test(nameserver)"},{"line_number":119,"context_line":"                if test(nameserver) is not None:"},{"line_number":120,"context_line":"                    break"},{"line_number":121,"context_line":"            except ValueError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3b91a215_e36b2d6b","line":118,"updated":"2023-07-07 18:49:50.000000000","message":"I feel like there is a better solution than just calling the same function three times. We could at least reduce it to two.\n\u003e result \u003d test(nameserver)\n\u003e if result is not None:\n\u003e     break","commit_id":"55d9170894ffd7a1a7b6e003d6f183f3fddb01d5"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1a99896ce6fce611277821df9b85776d0d77533f","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        ]"},{"line_number":116,"context_line":"        for test in tests_list:"},{"line_number":117,"context_line":"            try:"},{"line_number":118,"context_line":"                test(nameserver)"},{"line_number":119,"context_line":"                if test(nameserver) is not None:"},{"line_number":120,"context_line":"                    break"},{"line_number":121,"context_line":"            except ValueError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"c4e4c18f_26212a6a","line":118,"in_reply_to":"194d7194_db764131","updated":"2023-07-13 19:53:01.000000000","message":"Done","commit_id":"55d9170894ffd7a1a7b6e003d6f183f3fddb01d5"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"b698b5b86284a25904c0595ab0a7ed3f7139c858","unresolved":true,"context_lines":[{"line_number":115,"context_line":"        ]"},{"line_number":116,"context_line":"        for test in tests_list:"},{"line_number":117,"context_line":"            try:"},{"line_number":118,"context_line":"                test(nameserver)"},{"line_number":119,"context_line":"                if test(nameserver) is not None:"},{"line_number":120,"context_line":"                    break"},{"line_number":121,"context_line":"            except ValueError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"194d7194_db764131","line":118,"in_reply_to":"3b91a215_e36b2d6b","updated":"2023-07-13 12:21:09.000000000","message":"+1\nI\u0027ve changed the logic, IPV6 detection is now based on generated IPV6 parameter generated under [network-feature-enabled] section.\nThis makes code much more easier.","commit_id":"55d9170894ffd7a1a7b6e003d6f183f3fddb01d5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c8c3249c2249a6128fbd22fc9a9c33e8bc633fcf","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def from_str(self, nameserver):"},{"line_number":82,"context_line":"        ipv4_ptrn \u003d re.compile(\u0027\\\\d{1,3}\\\\.\\\\d{1,3}\\\\.\\\\d{1,3}\\\\.\\\\d{1,3}\u0027)"},{"line_number":83,"context_line":"        if ipv4_ptrn.search(nameserver):"},{"line_number":84,"context_line":"            if \u0027:\u0027 in nameserver:"},{"line_number":85,"context_line":"                ip, port \u003d nameserver.rsplit(\u0027:\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":7,"id":"e3fdbdcd_44d2e1df","line":82,"updated":"2023-07-13 20:19:02.000000000","message":"I should have thought of this sooner, I think we should use:\nhttps://github.com/openstack/oslo.utils/blob/master/oslo_utils/netutils.py#L37","commit_id":"122aea4ebdb5561937cc7beb221d98381aca34ad"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"c1daa3fd5822700db00453a38993b2cbd0bed21e","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def from_str(self, nameserver):"},{"line_number":82,"context_line":"        ipv4_ptrn \u003d re.compile(\u0027\\\\d{1,3}\\\\.\\\\d{1,3}\\\\.\\\\d{1,3}\\\\.\\\\d{1,3}\u0027)"},{"line_number":83,"context_line":"        if ipv4_ptrn.search(nameserver):"},{"line_number":84,"context_line":"            if \u0027:\u0027 in nameserver:"},{"line_number":85,"context_line":"                ip, port \u003d nameserver.rsplit(\u0027:\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":7,"id":"6054452a_6067f98d","line":82,"in_reply_to":"e3fdbdcd_44d2e1df","updated":"2023-07-14 07:54:27.000000000","message":"😊\nYep, this makes the code even more simple.","commit_id":"122aea4ebdb5561937cc7beb221d98381aca34ad"}]}